Re: [HACKERS] Git out of sync vs. CVS

2010-01-26 Thread Magnus Hagander
On Thu, Jan 21, 2010 at 17:11, Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: So add me to the list of people who think that if these are going to be recurring, we should look at moving from cvs to git as soon as 9.0 is released. The gating factor is

Re: [HACKERS] Git out of sync vs. CVS

2010-01-26 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: So add me to the list of people who think that if these are going to be recurring, we should look at moving from cvs to git as soon as 9.0 is released. The gating factor is not release schedule; it is the

Re: [HACKERS] Git out of sync vs. CVS

2010-01-22 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: So add me to the list of people who think that if these are going to be recurring, we should look at moving from cvs to git as soon as 9.0 is released. The gating factor is not release schedule; it is the still-unaddressed tasks that must be

Re: [HACKERS] Git out of sync vs. CVS

2010-01-21 Thread Magnus Hagander
On Wed, Jan 20, 2010 at 15:36, Robert Haas robertmh...@gmail.com wrote: On Wed, Jan 20, 2010 at 4:27 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Magnus Hagander wrote: On Wed, Jan 20, 2010 at 09:52, Magnus Hagander mag...@hagander.net wrote: On Tue, Jan 19, 2010 at

Re: [HACKERS] Git out of sync vs. CVS

2010-01-21 Thread Magnus Hagander
On Tue, Jan 19, 2010 at 21:07, Kevin Grittner kevin.gritt...@wicourts.gov wrote: I wrote: Perhaps it is as simple, though, as using the client's time instead of the CVS server's time -- that's one of the things I've seen cause problems for this sort of thing using CVS before. I got a brief

Re: [HACKERS] Git out of sync vs. CVS

2010-01-21 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Tue, Jan 19, 2010 at 21:07, Kevin Grittner Reality check: does the frequency of lost CVS commits within git seem consistent with this theory? Well, supposedly all our servers are synced with NTP. I know the main cvs server is, and the git server

Re: [HACKERS] Git out of sync vs. CVS

2010-01-21 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: I have noticed that CVS operations (at least from the user's viewpoint) work in local time. So even if the clocks are synced, a different TZ setting could conceivably lead to issues. Hmmm... If that were the issue I would think we'd've seen the problem

Re: [HACKERS] Git out of sync vs. CVS

2010-01-21 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: So the list really isn't very long. I think it's perfectly possible to clear it off before the release. Because we still only want to change after the release, or are you saying once those are fixed, we can change even if we happen to be in beta at

Re: [HACKERS] Git out of sync vs. CVS

2010-01-21 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: So add me to the list of people who think that if these are going to be recurring, we should look at moving from cvs to git as soon as 9.0 is released.

Re: [HACKERS] Git out of sync vs. CVS

2010-01-20 Thread Magnus Hagander
On Tue, Jan 19, 2010 at 16:59, Robert Haas robertmh...@gmail.com wrote: On Tue, Jan 19, 2010 at 10:44 AM, Magnus Hagander mag...@hagander.net wrote: On Mon, Jan 18, 2010 at 01:53, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Magnus Hagander  wrote: the Git repository is missing parts of

Re: [HACKERS] Git out of sync vs. CVS

2010-01-20 Thread Magnus Hagander
On Wed, Jan 20, 2010 at 09:52, Magnus Hagander mag...@hagander.net wrote: On Tue, Jan 19, 2010 at 16:59, Robert Haas robertmh...@gmail.com wrote: On Tue, Jan 19, 2010 at 10:44 AM, Magnus Hagander mag...@hagander.net wrote: On Mon, Jan 18, 2010 at 01:53, Kevin Grittner

Re: [HACKERS] Git out of sync vs. CVS

2010-01-20 Thread Heikki Linnakangas
Magnus Hagander wrote: On Wed, Jan 20, 2010 at 09:52, Magnus Hagander mag...@hagander.net wrote: On Tue, Jan 19, 2010 at 16:59, Robert Haas robertmh...@gmail.com wrote: On Tue, Jan 19, 2010 at 10:44 AM, Magnus Hagander mag...@hagander.net wrote: On Mon, Jan 18, 2010 at 01:53, Kevin Grittner

Re: [HACKERS] Git out of sync vs. CVS

2010-01-20 Thread Robert Haas
On Wed, Jan 20, 2010 at 4:27 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Magnus Hagander wrote: On Wed, Jan 20, 2010 at 09:52, Magnus Hagander mag...@hagander.net wrote: On Tue, Jan 19, 2010 at 16:59, Robert Haas robertmh...@gmail.com wrote: On Tue, Jan 19, 2010 at 10:44

Re: [HACKERS] Git out of sync vs. CVS

2010-01-20 Thread Heikki Linnakangas
Robert Haas wrote: On Wed, Jan 20, 2010 at 4:27 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Magnus Hagander wrote: Actually, such a correction patch would be nice and short. Attached for reference. Thoughts? That seems better than rewinding the history all the way back

Re: [HACKERS] Git out of sync vs. CVS

2010-01-20 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Magnus Hagander wrote: Actually, such a correction patch would be nice and short. Attached for reference. Thoughts? That seems better than rewinding the history all the way back to August. +1 ... I'm just an interested observer

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Magnus Hagander
On Mon, Jan 18, 2010 at 01:53, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Magnus Hagander  wrote: the Git repository is missing parts of two non-recent commits. We've seen this happen before. That seems like kind of a blasé attitude toward something upon which some people rely. For

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Robert Haas
On Tue, Jan 19, 2010 at 10:44 AM, Magnus Hagander mag...@hagander.net wrote: On Mon, Jan 18, 2010 at 01:53, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Magnus Hagander  wrote: the Git repository is missing parts of two non-recent commits. We've seen this happen before. That seems

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Magnus Hagander
On Tuesday, January 19, 2010, Robert Haas robertmh...@gmail.com wrote: On Tue, Jan 19, 2010 at 10:44 AM, Magnus Hagander mag...@hagander.net wrote: On Mon, Jan 18, 2010 at 01:53, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Magnus Hagander  wrote: the Git repository is missing parts of

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Aidan Van Dyk
* Magnus Hagander mag...@hagander.net [100119 10:44]: When we (at Wisconsin State Courts) were using CVS and had scripts to automatically merge changes from one branch to another, we saw this sort of thing unless people were very careful to grab a timestamp in the past for their ranges

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Kevin Grittner
Magnus Hagander mag...@hagander.net wrote: Kevin Grittner kevin.gritt...@wicourts.gov wrote: Magnus Hagander wrote: the Git repository is missing parts of two non-recent commits. We've seen this happen before. That seems like kind of a blasé attitude toward something upon which some

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Oh, and what sort of delay do you feel would be long enough to cover any cvs commit including potential network slowness during it etc.? Why should the script make any assumptions about delay at all? It seems to me that the problem comes from

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: Oh, and what sort of delay do you feel would be long enough to cover any cvs commit including potential network slowness during it etc.? Why should the script make any assumptions about delay at all? It

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Aidan Van Dyk
* Tom Lane t...@sss.pgh.pa.us [100119 11:47]: Kevin Grittner kevin.gritt...@wicourts.gov writes: Oh, and what sort of delay do you feel would be long enough to cover any cvs commit including potential network slowness during it etc.? Why should the script make any assumptions about delay

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Kevin Grittner
Kevin Grittner kevin.gritt...@wicourts.gov wrote: I haven't looked at the fromcvs code yet to know how easy or hard it would be to use this logic within that package Well, now I have looked. It's about 2,000 lines of pretty dense Ruby code (not as many comments as one would hope, especially

Re: [HACKERS] Git out of sync vs. CVS

2010-01-19 Thread Kevin Grittner
I wrote: Perhaps it is as simple, though, as using the client's time instead of the CVS server's time -- that's one of the things I've seen cause problems for this sort of thing using CVS before. I got a brief consult with a Ruby programmer here under the if it's less than ten minutes you

Re: [HACKERS] Git out of sync vs. CVS

2010-01-17 Thread Magnus Hagander
2010/1/17 Peter Eisentraut pete...@gmx.net: Maybe I'm hallucinating and someone could check this in their environment, but it appears to me that the Git repository is missing parts of two non-recent commits.  See attached patch. Not having looked at the repo in detail, but I bet this happened

Re: [HACKERS] Git out of sync vs. CVS

2010-01-17 Thread Peter Eisentraut
On sön, 2010-01-17 at 20:50 +0100, Magnus Hagander wrote: As for fixing it, I guess we can try the rewind-to-commit-before-this-and-rerun. That'll break people who have branched after, but last time it seemed that most peoples git clients would clean that up automatically. Which commits are

Re: [HACKERS] Git out of sync vs. CVS

2010-01-17 Thread Magnus Hagander
2010/1/17 Peter Eisentraut pete...@gmx.net: On sön, 2010-01-17 at 20:50 +0100, Magnus Hagander wrote: As for fixing it, I guess we can try the rewind-to-commit-before-this-and-rerun. That'll break people who have branched after, but last time it seemed that most peoples git clients would

Re: [HACKERS] Git out of sync vs. CVS

2010-01-17 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: 2010/1/17 Peter Eisentraut pete...@gmx.net: Maybe I'm hallucinating and someone could check this in their environment, but it appears to me that the Git repository is missing parts of two non-recent commits.  See attached patch. Not having looked

Re: [HACKERS] Git out of sync vs. CVS

2010-01-17 Thread Magnus Hagander
2010/1/17 Tom Lane t...@sss.pgh.pa.us: Magnus Hagander mag...@hagander.net writes: 2010/1/17 Peter Eisentraut pete...@gmx.net: Maybe I'm hallucinating and someone could check this in their environment, but it appears to me that the Git repository is missing parts of two non-recent commits.  

Re: [HACKERS] Git out of sync vs. CVS

2010-01-17 Thread Kevin Grittner
Magnus Hagander wrote: the Git repository is missing parts of two non-recent commits. We've seen this happen before. That seems like kind of a blasé attitude toward something upon which some people rely. When we (at Wisconsin State Courts) were using CVS and had scripts to automatically