Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-18 Thread Heikki Linnakangas
Zdenek Kotala wrote: Heikki Linnakangas wrote: - heap page diagnostic functions I would like to take this review (after PGCon). Too late, Bruce applied it already :). More eyeballs on it still wouldn't hurt of course. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-18 Thread Zdenek Kotala
Heikki Linnakangas wrote: - heap page diagnostic functions I would like to take this review (after PGCon). Zdenek ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ?

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-18 Thread Zdenek Kotala
Heikki Linnakangas wrote: Zdenek Kotala wrote: Heikki Linnakangas wrote: - heap page diagnostic functions I would like to take this review (after PGCon). Too late, Bruce applied it already :). Yes ... Never mind What's about - full page writes improvement but I will have time after

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-18 Thread Alvaro Herrera
Zdenek Kotala wrote: Heikki Linnakangas wrote: Zdenek Kotala wrote: Heikki Linnakangas wrote: - heap page diagnostic functions I would like to take this review (after PGCon). Too late, Bruce applied it already :). Yes ... Never mind You know, the fact that it was applied does not

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-18 Thread Alvaro Herrera
Alvaro Herrera wrote: Zdenek Kotala wrote: Heikki Linnakangas wrote: Zdenek Kotala wrote: Heikki Linnakangas wrote: - heap page diagnostic functions I would like to take this review (after PGCon). Too late, Bruce applied it already :). Yes ... Never mind You know, the

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-18 Thread Heikki Linnakangas
Alvaro Herrera wrote: Alvaro Herrera wrote: Zdenek Kotala wrote: Heikki Linnakangas wrote: Zdenek Kotala wrote: Heikki Linnakangas wrote: - heap page diagnostic functions I would like to take this review (after PGCon). Too late, Bruce applied it already :). Yes ... Never mind You know,

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-18 Thread Jim C. Nasby
On Fri, May 18, 2007 at 12:33:11AM +0800, Cui Shijun wrote: Thank you for your suggestions, I am thinking about Full page writes improvement. It seems not so complicated, just fit for a novice like me. I'll work on it. :-) Updated on

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-18 Thread Jim C. Nasby
On Fri, May 18, 2007 at 03:21:00PM +0200, Zdenek Kotala wrote: What's about - full page writes improvement but I will have time after PGCon. Added you to the list for that at http://developer.postgresql.org/index.php/Todo:PatchStatus -- Jim Nasby

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-17 Thread Dave Page
Marc G. Fournier wrote: --On Wednesday, May 16, 2007 20:09:44 -0400 Bruce Momjian [EMAIL PROTECTED] wrote: I think one of the things that is preventing urgency is that everyone knows we have large patches unapplied, so they know that their lack of activity is not holding up the

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-17 Thread Cui Shijun
I want to help the reviewing work of ctid chain following enhancement . I've been studying the souce code which related with that part recently. :-) 2007/5/17, Dave Page [EMAIL PROTECTED]: I think we just have to accept that we're gonna have a long feature freeze period, and ask people to help

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-17 Thread Dave Page
Cui Shijun wrote: I want to help the reviewing work of ctid chain following enhancement . I've been studying the souce code which related with that part recently. :-) Please go ahead :-) Regards Dave ---(end of broadcast)--- TIP 3: Have you

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-17 Thread Pavan Deolasee
On 5/17/07, Cui Shijun [EMAIL PROTECTED] wrote: I want to help the reviewing work of ctid chain following enhancement . I've been studying the souce code which related with that part recently. :-) Tom had objected to this patch on the grounds that it adds complexity without any significant

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-17 Thread Bruce Momjian
Pavan Deolasee wrote: On 5/17/07, Cui Shijun [EMAIL PROTECTED] wrote: I want to help the reviewing work of ctid chain following enhancement . I've been studying the souce code which related with that part recently. :-) Tom had objected to this patch on the grounds that it adds

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-17 Thread Cui Shijun
I see... I checked part of HOT patches(patch1), and found that it involves too many things I am not currently familar with. Maybe I should change an item to work. :-( Since I only studied part of source codes about transaction processing(lmgr/MVCC/xact but without xlog.c), I want to study Group

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-17 Thread Heikki Linnakangas
Cui Shijun wrote: I see... I checked part of HOT patches(patch1), and found that it involves too many things I am not currently familar with. Maybe I should change an item to work. :-( Yeah, that's one big patch.. Since I only studied part of source codes about transaction

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-17 Thread Cui Shijun
Thank you for your suggestions, I am thinking about Full page writes improvement. It seems not so complicated, just fit for a novice like me. I'll work on it. :-) 2007/5/17, Heikki Linnakangas [EMAIL PROTECTED]: Cui Shijun wrote: I see... I checked part of HOT patches(patch1), and found

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Joshua D. Drake
Bruce Momjian wrote: In talking to people who are assigned to review patches or could review patches, I often get the reply, Oh, yea, I need to do that. It seems there is a lot of reliance on Tom to get the patches applied, but I don't think that is fair or reasonable. I think we need more

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Guido Barosio
Bruce, where can I take a look at the patch list in order to find out if I can be of some help? Regards, g.- On 5/16/07, Bruce Momjian [EMAIL PROTECTED] wrote: In talking to people who are assigned to review patches or could review patches, I often get the reply, Oh, yea, I need to do that.

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Bruce Momjian
It is all on the developer roadmap page: http://momjian.us/cgi-bin/pgpatches --- Guido Barosio wrote: Bruce, where can I take a look at the patch list in order to find out if I can be of some help? Regards,

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Joshua D. Drake
Bruce Momjian wrote: It is all on the developer roadmap page: http://momjian.us/cgi-bin/pgpatches There is also a slightly more readable one here: http://developer.postgresql.org/index.php/Todo:PatchStatus Joshua D. Drake

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Andrew Dunstan
Bruce Momjian wrote: In talking to people who are assigned to review patches or could review patches, I often get the reply, Oh, yea, I need to do that. Folks, we are six weeks into feature freeze and have made slim progress on getting patches reviewed and applied. As I stated earlier, we

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Stefan Kaltenbrunner
Joshua D. Drake wrote: Bruce Momjian wrote: It is all on the developer roadmap page: http://momjian.us/cgi-bin/pgpatches There is also a slightly more readable one here: http://developer.postgresql.org/index.php/Todo:PatchStatus note that http://momjian.us/cgi-bin/pgpatches

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Bruce Momjian
Andrew Dunstan wrote: Bruce Momjian wrote: In talking to people who are assigned to review patches or could review patches, I often get the reply, Oh, yea, I need to do that. Folks, we are six weeks into feature freeze and have made slim progress on getting patches reviewed and

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Stefan Kaltenbrunner
Andrew Dunstan wrote: Bruce Momjian wrote: In talking to people who are assigned to review patches or could review patches, I often get the reply, Oh, yea, I need to do that. Folks, we are six weeks into feature freeze and have made slim progress on getting patches reviewed and applied.

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Guido Barosio
What about a mentoring schema in order to push up the gap that represents catching up with cases like the one Andrew posted? By the way, being a patch reviewer doesn't represents also to be able to find out potential problems in the code, which may have nothing to do with the patch

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Bruce Momjian
I think one of the things that is preventing urgency is that everyone knows we have large patches unapplied, so they know that their lack of activity is not holding up the release. Any way around that? --- bruce wrote: In

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Marc G. Fournier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - --On Wednesday, May 16, 2007 20:09:44 -0400 Bruce Momjian [EMAIL PROTECTED] wrote: I think one of the things that is preventing urgency is that everyone knows we have large patches unapplied, so they know that their lack of activity is not

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Jonah H. Harris
On 5/16/07, Marc G. Fournier [EMAIL PROTECTED] wrote: Set a fixed date (ie. 3 weeks) and whatever isn't in gets punted to 8.4 ... if that means those 'large patches' don't get applied, so be it ... I disagree with that approach. Larger more complex patches required much more work and effort

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Bruce Momjian
Jonah H. Harris wrote: On 5/16/07, Marc G. Fournier [EMAIL PROTECTED] wrote: Set a fixed date (ie. 3 weeks) and whatever isn't in gets punted to 8.4 ... if that means those 'large patches' don't get applied, so be it ... I disagree with that approach. Larger more complex patches

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Marc G. Fournier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - --On Wednesday, May 16, 2007 21:04:27 -0400 Bruce Momjian [EMAIL PROTECTED] wrote: Jonah H. Harris wrote: On 5/16/07, Marc G. Fournier [EMAIL PROTECTED] wrote: Set a fixed date (ie. 3 weeks) and whatever isn't in gets punted to 8.4 ... if

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Bruce Momjian
Marc G. Fournier wrote: Jonah H. Harris wrote: On 5/16/07, Marc G. Fournier [EMAIL PROTECTED] wrote: Set a fixed date (ie. 3 weeks) and whatever isn't in gets punted to 8.4 ... if that means those 'large patches' don't get applied, so be it ... I disagree with that approach. Larger

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Joshua D. Drake
Marc G. Fournier wrote: I disagree with that approach. Larger more complex patches required much more work and effort than small, simple ones. Not only do I think it's unfair to the authors who spent considerably more time on their work, but I think it also sets a bad precedent for future

Re: [HACKERS] Lack of urgency in 8.3 reviewing

2007-05-16 Thread Pavan Deolasee
On 5/16/07, Bruce Momjian [EMAIL PROTECTED] wrote: Yep, that is part of our problem, but even items people have already said they _can_ review have shown little progress. For complex patches, it might help to identify and associate a core/senior community member in the early stages of