2011/1/17 KaiGai Kohei kai...@ak.jp.nec.com:
Are you talking about an idea to apply toast id as an alternative key?
No, probably. I'm just talking about whether diff -q A.txt B.txt and
diff -q A.gz B.gz always returns the same result or not.
... I found it depends on version of gzip. So, if we
On Sun, Jan 16, 2011 at 11:31 PM, Magnus Hagander mag...@hagander.net wrote:
Ok. Updated patch that includes this change attached.
I could not apply the patch cleanly against the git master.
Do you know what the cause is?
$ patch -p1 -d. /hoge/pg_basebackup.patch
patching file
On 17/01/11 01:02, Hitoshi Harada wrote:
This is a review for the patch sent as
https://commitfest.postgresql.org/action/patch_view?id=456
Thanks!
It includes adequate amount of test. I found regression test failure
in plpython_error.
My environment is CentOS release 5.4 (Final) with
On Jan 17, 2011 9:16 AM, Fujii Masao masao.fu...@gmail.com wrote:
On Sun, Jan 16, 2011 at 11:31 PM, Magnus Hagander mag...@hagander.net
wrote:
Ok. Updated patch that includes this change attached.
I could not apply the patch cleanly against the git master.
Do you know what the cause is?
$
On Mon, Jan 17, 2011 at 5:44 PM, Magnus Hagander mag...@hagander.net wrote:
Weird, no idea. Will have to look into that later - meanwhile you can grab
the branch tip from my github repo if you want to review it.
Which repo should I grab? You seem to have many repos :)
Hi,
Here is updated version of this patch.
With best regards,
Alexander Korotkov.
*** a/contrib/pg_trgm/pg_trgm.sql.in
--- b/contrib/pg_trgm/pg_trgm.sql.in
***
*** 113,118 FOR TYPE text USING gist
--- 113,120
AS
OPERATOR1 % (text, text),
--On 16. Januar 2011 21:53:47 +0100 Dimitri Fontaine
dimi...@2ndquadrant.fr wrote:
Is walreceiver something that the average DBA is going to realize
what it is? Perhaps go for something like replication slave?
I think walreceiver is very good here, and the user is already
confronted to
On Mon, Jan 17, 2011 at 09:50, Fujii Masao masao.fu...@gmail.com wrote:
On Mon, Jan 17, 2011 at 5:44 PM, Magnus Hagander mag...@hagander.net wrote:
Weird, no idea. Will have to look into that later - meanwhile you can grab
the branch tip from my github repo if you want to review it.
Which
On Mon, Jan 17, 2011 at 04:05, Fujii Masao masao.fu...@gmail.com wrote:
On Mon, Jan 17, 2011 at 11:16 AM, Robert Haas robertmh...@gmail.com wrote:
On Sun, Jan 16, 2011 at 3:53 PM, Dimitri Fontaine
dimi...@2ndquadrant.fr wrote:
Magnus Hagander mag...@hagander.net writes:
Is walreceiver
On Sun, Jan 16, 2011 at 20:13, Dimitri Fontaine dimi...@2ndquadrant.fr wrote:
Magnus Hagander mag...@hagander.net writes:
However, it's not quite that simple. just adding a fork() doesn't
work on all our platforms, and you need to deal with feedback and such
between them as well.
I'd think
On Mon, Jan 17, 2011 at 09:13, Itagaki Takahiro
itagaki.takah...@gmail.com wrote:
2011/1/17 KaiGai Kohei kai...@ak.jp.nec.com:
Are you talking about an idea to apply toast id as an alternative key?
No, probably. I'm just talking about whether diff -q A.txt B.txt and
diff -q A.gz B.gz always
On Mon, Jan 17, 2011 at 6:53 PM, Magnus Hagander mag...@hagander.net wrote:
On Mon, Jan 17, 2011 at 09:50, Fujii Masao masao.fu...@gmail.com wrote:
On Mon, Jan 17, 2011 at 5:44 PM, Magnus Hagander mag...@hagander.net wrote:
Weird, no idea. Will have to look into that later - meanwhile you can
On 13.01.2011 12:35, Fujii Masao wrote:
On Thu, Jan 13, 2011 at 5:59 PM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
On 13.01.2011 10:28, Fujii Masao wrote:
When the master shuts down or crashes, there seems to be
the case where walreceiver exits without flushing WAL which
On Mon, Jan 17, 2011 at 10:57, Magnus Hagander mag...@hagander.net wrote:
On Mon, Jan 17, 2011 at 04:05, Fujii Masao masao.fu...@gmail.com wrote:
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
b/src/backend/replication/libpqwalreceiver/libpqwalreceiv
index
On Sun, Jan 16, 2011 at 21:57, Josh Berkus j...@agliodbs.com wrote:
I suggest instead either superuser or replication permissions.
That's another idea.
Oh, wait. I take that back ... we're trying to encourage users NOT to
use the replication user as a login, yes?
yeah.
Here's a patch
2011/1/16 Tom Lane t...@sss.pgh.pa.us:
Comments?
I think it's great you undertook the challenge of solving this problem
the proper way.
I think your desire to achieve perfection in every little detail is admirable.
Your patch is according to me, not far from perfect, but could be
improved in a
Hello, Robert.
You wrote:
RH 2011/1/13 Pavel Golub pa...@microolap.com:
Hello, Pgsql-hackers.
I'm getting such warnings:
pg_dump.c: In function 'dumpSequence':
pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format
pg_dump.c:11449:2: warning: too many arguments for
On Mon, Jan 17, 2011 at 19:51, Magnus Hagander mag...@hagander.net wrote:
Here's a patch that limits it to superuser only. We can't easily match
it to the user of the session given the way the walsender data is
returned - it doesn't contain the user information. But limiting it to
superuser
On 01/17/2011 05:54 AM, Pavel Golub wrote:
Hello, Robert.
You wrote:
RH 2011/1/13 Pavel Golubpa...@microolap.com:
Hello, Pgsql-hackers.
I'm getting such warnings:
pg_dump.c: In function 'dumpSequence':
pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format
On Jan 17, 2011, at 1:44 AM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
But I wonder if we should add lines in the default pg_hba.conf to trust
replication connections from loopback, like we do for normal connections?
Seems sorta pointless.
...Robert
--
Sent via
On Mon, Jan 17, 2011 at 12:11, Itagaki Takahiro
itagaki.takah...@gmail.com wrote:
On Mon, Jan 17, 2011 at 19:51, Magnus Hagander mag...@hagander.net wrote:
Here's a patch that limits it to superuser only. We can't easily match
it to the user of the session given the way the walsender data is
Hello, Andrew.
You wrote:
AD On 01/17/2011 05:54 AM, Pavel Golub wrote:
Hello, Robert.
You wrote:
RH 2011/1/13 Pavel Golubpa...@microolap.com:
Hello, Pgsql-hackers.
I'm getting such warnings:
pg_dump.c: In function 'dumpSequence':
pg_dump.c:11449:2: warning: unknown conversion type
On lör, 2011-01-15 at 19:10 +0100, Magnus Hagander wrote:
This patch creates pg_basebackup in bin/, being a client program for
the streaming base backup feature.
I think it's more or less done now. I've again split it out of
pg_streamrecv, because it had very little shared code with that
On Mon, Jan 17, 2011 at 13:38, Peter Eisentraut pete...@gmx.net wrote:
On lör, 2011-01-15 at 19:10 +0100, Magnus Hagander wrote:
This patch creates pg_basebackup in bin/, being a client program for
the streaming base backup feature.
I think it's more or less done now. I've again split it out
On mån, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote:
which, as Magnus points out, includes non-procedural languages (SQL).
I think that list languages could be confusing to newcomers -- the
very people who might be reading through the help output of psql for
the first time -- who
On Mon, Jan 17, 2011 at 5:54 AM, Pavel Golub pa...@microolap.com wrote:
RH It seems like PGAC_FUNC_SNPRINTF_LONG_LONG_INT_FORMAT is getting the
RH wrong answer on your machine, though I'm not sure why. The easiest
RH workaround is probably to run configure and then edit
RH
On Mon, Jan 17, 2011 at 2:56 AM, Peter Eisentraut pete...@gmx.net wrote:
On mån, 2011-01-17 at 07:35 +0100, Magnus Hagander wrote:
For text, I think locales may make that impossible. Aren't there
locale rules where two different characters can behave the same when
comparing them? I know in
On 14.01.2011 20:12, Peter Eisentraut wrote:
I have adjusted your old patch for the current tree, and it seems to
work. I think it was just forgotten last time because the move to
PQconnectdbParams had to happen first. But I'll throw it back into the
ring now.
Hello,
maybe i missed
On Mon, Jan 17, 2011 at 1:53 AM, Magnus Hagander mag...@hagander.net wrote:
On Mon, Jan 17, 2011 at 03:06, Robert Haas robertmh...@gmail.com wrote:
On Sun, Jan 16, 2011 at 9:19 AM, Magnus Hagander mag...@hagander.net wrote:
Currently, replication connections *always* logs something like:
LOG:
On Sun, 16 Jan 2011 01:55:19 +0100
Jan Urbański wulc...@wulczer.org wrote:
what follows is a review of the FDW API patch from
http://archives.postgresql.org/message-id/20110114212358.82c7.69899...@metrosystems.co.jp
Thanks for the comments!
For now, I answer to the first half of your comments.
On Mon, Jan 17, 2011 at 12:00 AM, Oliver Jowett oli...@opencloud.com wrote:
However, doing the same via a plpgsql function with an OUT parameter
produces something completely mangled:
test_udt=# CREATE FUNCTION p_enhance_address2 (address OUT u_address_type)
AS $$ BEGIN SELECT
On Mon, 17 Jan 2011 22:13:19 +0900
Shigeru HANADA han...@metrosystems.co.jp wrote:
Fixed in attached patch.
Sorry, I have not attached patch to last message.
I'll post revised patch in next message soon.
Regards,
--
Shigeru Hanada
--
Sent via pgsql-hackers mailing list
On 17 January 2011 12:58, Susanne Ebrecht susa...@2ndquadrant.com wrote:
Hello,
maybe i missed pre-discussion but ...
I miss considering auto-detect of file encoding.
A simple example:
$ psql -f dump.sql db
What happens when dump.sql is written by using
another encoding?
That doesn't
On Mon, Jan 17, 2011 at 7:14 PM, Fujii Masao masao.fu...@gmail.com wrote:
Oh, sorry about that. There is only one that contains postgresql though :P
http://github.com/mhagander/postgres, branch streaming_base.
Thanks!
Though I haven't seen the core part of the patch (i.e.,
ReceiveTarFile,
On Mon, Jan 17, 2011 at 9:43 PM, Magnus Hagander mag...@hagander.net wrote:
Probably yes, for consistency. I have been thinking for a while,
however, that it would be very good if the tools also supported a
conninfo string, so you don't have to invent a new option for every new
connection
On Mon, 2011-01-17 at 13:43 +0100, Magnus Hagander wrote:
Downthread you say that this tool is also useful for making base
backups
independent of replication functionality. Sounds good. But then
the
documentation says that the connection must be with a user that has
the
replication
On Mon, Jan 17, 2011 at 14:30, Fujii Masao masao.fu...@gmail.com wrote:
On Mon, Jan 17, 2011 at 7:14 PM, Fujii Masao masao.fu...@gmail.com wrote:
Oh, sorry about that. There is only one that contains postgresql though :P
http://github.com/mhagander/postgres, branch streaming_base.
Thanks!
On Mon, Jan 17, 2011 at 14:43, Fujii Masao masao.fu...@gmail.com wrote:
On Mon, Jan 17, 2011 at 9:43 PM, Magnus Hagander mag...@hagander.net wrote:
Probably yes, for consistency. I have been thinking for a while,
however, that it would be very good if the tools also supported a
conninfo
On Mon, Jan 17, 2011 at 14:49, Simon Riggs si...@2ndquadrant.com wrote:
On Mon, 2011-01-17 at 13:43 +0100, Magnus Hagander wrote:
Downthread you say that this tool is also useful for making base
backups
independent of replication functionality. Sounds good. But then
the
documentation
On Mon, Jan 17, 2011 at 14:00, Robert Haas robertmh...@gmail.com wrote:
On Mon, Jan 17, 2011 at 1:53 AM, Magnus Hagander mag...@hagander.net wrote:
On Mon, Jan 17, 2011 at 03:06, Robert Haas robertmh...@gmail.com wrote:
On Sun, Jan 16, 2011 at 9:19 AM, Magnus Hagander mag...@hagander.net
On 17.01.2011 14:26, Peter Geoghegan wrote:
On 17 January 2011 12:58, Susanne Ebrechtsusa...@2ndquadrant.com wrote:
Hello,
maybe i missed pre-discussion but ...
I miss considering auto-detect of file encoding.
A simple example:
$ psql -f dump.sql db
What happens when dump.sql is written by
On Mon, 2011-01-17 at 14:55 +0100, Magnus Hagander wrote:
It uses the replication features for it. You also have to set
max_walsenders 0, which is in the replication section of the
postgresql.conf file.
The point I wanted to make downthread was that it's useful without
having a
On Mon, Jan 3, 2011 at 14:11, Christian Ullrich ch...@chrullrich.net wrote:
Hello all,
this patch adds support for connecting to servers running on Windows
and requesting SSPI authentication. It does this by treating
AUTH_REQ_SSPI the same as AUTH_REQ_GSS if no native SSPI support is
On 01/17/2011 07:18 AM, Pavel Golub wrote:
AD Mingw has always had a huge number of format warnings. See for example
AD
http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=frogmouthdt=2011-01-17%2007%3A30%3A00stg=make
So you think I should just ignore these warnings? Because I can't
The attached, applied patch adds getopt() support to test_fsync.
--
Bruce Momjian br...@momjian.ushttp://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
diff --git a/src/tools/fsync/README
On Mon, Jan 17, 2011 at 02:48:43PM +0200, Peter Eisentraut wrote:
On mån, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote:
which, as Magnus points out, includes non-procedural languages
(SQL).
I think that list languages could be confusing to newcomers
-- the very people who might
On fre, 2011-01-14 at 18:45 -0500, Robert Haas wrote:
On Fri, Jan 14, 2011 at 3:45 PM, Marti Raudsepp ma...@juffo.org
wrote:
There's a similar case with CREATE TABLE IF NOT EXISTS, maybe this
is
worth covering in an updated patch too?
And if I change that, people might expect the same
On Mon, Jan 17, 2011 at 8:58 AM, Magnus Hagander mag...@hagander.net wrote:
What do you have in mind?
Either having it controlled by log_connections, or perhaps have a
log_highpriv_connections that controls replication *and* superuser, to
be somewhat consistent.
-1. We could provide an
On Mon, Jan 17, 2011 at 09:58:35AM +0200, Anssi Kääriäinen wrote:
One thing I have been thinking about is how does predicate locking
indexes work when using functional indexes and functions marked as
immutable but which really aren't. I don't know how predicate
locking indexes works, so it
On Mon, Jan 17, 2011 at 9:41 AM, Peter Eisentraut pete...@gmx.net wrote:
On fre, 2011-01-14 at 18:45 -0500, Robert Haas wrote:
On Fri, Jan 14, 2011 at 3:45 PM, Marti Raudsepp ma...@juffo.org
wrote:
There's a similar case with CREATE TABLE IF NOT EXISTS, maybe this
is
worth covering in an
On Mon, Jan 17, 2011 at 16:03, Robert Haas robertmh...@gmail.com wrote:
On Mon, Jan 17, 2011 at 8:58 AM, Magnus Hagander mag...@hagander.net wrote:
What do you have in mind?
Either having it controlled by log_connections, or perhaps have a
log_highpriv_connections that controls replication
On Mon, Jan 17, 2011 at 8:55 AM, Magnus Hagander mag...@hagander.net wrote:
Hmm. I don't like those names at all :(
I agree. I don't think your original names are bad, as long as
they're well-documented. I sympathize with Simon's desire to make it
clear that these use the replication
On Mon, Jan 17, 2011 at 16:18, Robert Haas robertmh...@gmail.com wrote:
On Mon, Jan 17, 2011 at 8:55 AM, Magnus Hagander mag...@hagander.net wrote:
Hmm. I don't like those names at all :(
I agree. I don't think your original names are bad, as long as
they're well-documented. I sympathize
I used the patch from CommitFest application and applied the following
commit to fix a known issue:
http://git.postgresql.org/gitweb?p=postgresql-extension.git;a=commitdiff;h=d4991d35283ae0ceeb7f9e4203cf6a9dfb5d128d
Is the patch in context diff format?
Yes.
Does the patch apply cleanly?
No:
On Mon, 2011-01-17 at 16:20 +0100, Magnus Hagander wrote:
On Mon, Jan 17, 2011 at 16:18, Robert Haas robertmh...@gmail.com wrote:
On Mon, Jan 17, 2011 at 8:55 AM, Magnus Hagander mag...@hagander.net
wrote:
Hmm. I don't like those names at all :(
I agree. I don't think your original
On Mon, Jan 17, 2011 at 07:35:52AM +0100, Magnus Hagander wrote:
On Mon, Jan 17, 2011 at 06:51, Itagaki Takahiro
itagaki.takah...@gmail.com wrote:
On Mon, Jan 17, 2011 at 04:05, Andy Colson a...@squeakycode.net wrote:
This is a review of:
On Mon, Jan 17, 2011 at 11:05:09AM +0100, Magnus Hagander wrote:
On Mon, Jan 17, 2011 at 09:13, Itagaki Takahiro
itagaki.takah...@gmail.com wrote:
2011/1/17 KaiGai Kohei kai...@ak.jp.nec.com:
Are you talking about an idea to apply toast id as an alternative key?
No, probably. I'm just
On Mon, Jan 17, 2011 at 10:12 AM, Magnus Hagander mag...@hagander.net wrote:
On Mon, Jan 17, 2011 at 16:03, Robert Haas robertmh...@gmail.com wrote:
On Mon, Jan 17, 2011 at 8:58 AM, Magnus Hagander mag...@hagander.net wrote:
What do you have in mind?
Either having it controlled by
On Mon, Jan 17, 2011 at 16:31, Robert Haas robertmh...@gmail.com wrote:
On Mon, Jan 17, 2011 at 10:12 AM, Magnus Hagander mag...@hagander.net wrote:
On Mon, Jan 17, 2011 at 16:03, Robert Haas robertmh...@gmail.com wrote:
On Mon, Jan 17, 2011 at 8:58 AM, Magnus Hagander mag...@hagander.net
Excerpts from Anssi Kääriäinen's message of lun ene 17 12:41:25 -0300 2011:
While it is not possible to drop functions in extensions, it is possible
to rename a function, and also to CREATE OR REPLACE a function in an
extension. After renaming or CORing a function, it is possible to drop
Is there a value to this test_fsync test?
Compare open_sync with different sizes:
(This is designed to compare the cost of one large
sync'ed write and two smaller sync'ed writes.)
open_sync 16k write 242.563 ops/sec
2 open_sync
On Mon, Jan 17, 2011 at 10:41 AM, Anssi Kääriäinen
anssi.kaariai...@thl.fi wrote:
I haven't had time to review the pg_dump part of the patch yet, will do that
next (tomorrow). I hope it is OK to post a partial review...
It is, and this is a very good and detailed review!
--
Robert Haas
Is there value in moving test_fsync to /contrib?
--
Bruce Momjian br...@momjian.ushttp://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
--
Sent via pgsql-hackers mailing list
On Mon, Jan 17, 2011 at 11:02 AM, Bruce Momjian br...@momjian.us wrote:
Is there value in moving test_fsync to /contrib?
Why would we want to do that?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list
Robert Haas wrote:
On Mon, Jan 17, 2011 at 11:02 AM, Bruce Momjian br...@momjian.us wrote:
Is there value in moving test_fsync to /contrib?
Why would we want to do that?
If we expect users to run the tool to best choose the best
wal_sync_method.
--
Bruce Momjian br...@momjian.us
Greg Smith wrote:
One of the components to the write queue is some notion that writes that
have been waiting longest should eventually be flushed out. Linux has
this number called dirty_expire_centiseconds which suggests it enforces
just that, set to a default of 30 seconds. This is why
On Mon, Jan 17, 2011 at 11:16 AM, Bruce Momjian br...@momjian.us wrote:
Robert Haas wrote:
On Mon, Jan 17, 2011 at 11:02 AM, Bruce Momjian br...@momjian.us wrote:
Is there value in moving test_fsync to /contrib?
Why would we want to do that?
If we expect users to run the tool to best
On Sun, Jan 16, 2011 at 7:13 PM, Greg Smith g...@2ndquadrant.com wrote:
I have finished a first run of benchmarking the current 9.1 code at various
sizes. See http://www.2ndquadrant.us/pgbench-results/index.htm for many
details. The interesting stuff is in Test Set 3, near the bottom. That's
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 11:02 AM, Bruce Momjian br...@momjian.us wrote:
Is there value in moving test_fsync to /contrib?
Why would we want to do that?
So it would be built by default, installed under reasonable conditions,
and there would be a place
Excerpts from Tom Lane's message of sáb ene 15 00:34:40 -0300 2011:
Stephen Frost sfr...@snowman.net writes:
What about something other than
version_x_y? I could maybe see having a 'default' and an 'all'
instead.. Then have the default be what we have currently and 'all' be
the full
Magnus Hagander mag...@hagander.net writes:
Before I go ahead and commit the part that adds
log_replication_connections, anybody else want to object to the idea?
I think it'd make more sense just to say that replication connections
are subject to the same log_connections rule as others. An
Magnus Hagander wrote:
On Mon, Jan 3, 2011 at 14:11, Christian Ullrichch...@chrullrich.net wrote:
Hello all,
this patch adds support for connecting to servers running on Windows
and requesting SSPI authentication. It does this by treating
AUTH_REQ_SSPI the same as AUTH_REQ_GSS if no native
Tom Lane wrote:
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 11:02 AM, Bruce Momjian br...@momjian.us wrote:
Is there value in moving test_fsync to /contrib?
Why would we want to do that?
So it would be built by default, installed under reasonable conditions,
and
On Mon, Jan 17, 2011 at 11:47 AM, Bruce Momjian br...@momjian.us wrote:
Tom Lane wrote:
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 11:02 AM, Bruce Momjian br...@momjian.us wrote:
Is there value in moving test_fsync to /contrib?
Why would we want to do that?
So it
On 01/17/2011 11:44 AM, Alvaro Herrera wrote:
Excerpts from Tom Lane's message of sáb ene 15 00:34:40 -0300 2011:
Stephen Frostsfr...@snowman.net writes:
What about something other than
version_x_y? I could maybe see having a 'default' and an 'all'
instead.. Then have the default be what
On Mon, Jan 17, 2011 at 17:46, Tom Lane t...@sss.pgh.pa.us wrote:
Magnus Hagander mag...@hagander.net writes:
Before I go ahead and commit the part that adds
log_replication_connections, anybody else want to object to the idea?
I think it'd make more sense just to say that replication
Excerpts from Bruce Momjian's message of lun ene 17 13:47:40 -0300 2011:
It seems like /contrib would be more natural, no? /bin seems like
overkill because most people will not want to run it. Most of /contrib
is installed already by installers, I think.
I don't understand why it would be
2011/1/17 Bruce Momjian br...@momjian.us:
Robert Haas wrote:
On Mon, Jan 17, 2011 at 11:02 AM, Bruce Momjian br...@momjian.us wrote:
Is there value in moving test_fsync to /contrib?
Why would we want to do that?
If we expect users to run the tool to best choose the best
wal_sync_method.
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 11:47 AM, Bruce Momjian br...@momjian.us wrote:
It seems like /contrib would be more natural, no? /bin seems like
overkill because most people will not want to run it. Most of /contrib
is installed already by installers, I
On Mon, Jan 17, 2011 at 12:05 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 11:47 AM, Bruce Momjian br...@momjian.us wrote:
It seems like /contrib would be more natural, no? /bin seems like
overkill because most people will not want
Magnus Hagander mag...@hagander.net writes:
The walsender can't read pg_class for example, so it can't generate
that mapping file.
I don't see any way out here. So let's call oid.tar good enough for now…
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation
Hi,
Thanks for your review!
Anssi Kääriäinen anssi.kaariai...@thl.fi writes:
Does the patch apply cleanly?
No:
That was some bitrot, has been fixed, thanks you for working from the
git repository meanwhile.
pg_dump.c:3748: warning: too many arguments for format
Fixed in v25 already sent
Alvaro Herrera alvhe...@commandprompt.com writes:
Excerpts from Anssi Kääriäinen's message of lun ene 17 12:41:25 -0300 2011:
While it is not possible to drop functions in extensions, it is possible
to rename a function, and also to CREATE OR REPLACE a function in an
extension. After
Magnus Hagander mag...@hagander.net writes:
But however we do it, it will be significantly more complex than just
including the WAL. And I want to make sure we get *something* done in
time for 9.1, and then improve upon it. If we can get the improvement
into 9.1 that's great, but if not it
Magnus Hagander mag...@hagander.net writes:
With pg_basebackup, you can set up streaming replication in what's
basically a single command (run the base backup, copy i na
recovery.conf file). In my first version I even had a switch that
would create the recovery.conf file for you - should we
Fujii Masao masao.fu...@gmail.com writes:
http://www.postgresql.org/docs/9.0/interactive/runtime-config-wal.html#GUC-MAX-WAL-SENDERS
+1 though I could not find the mention to walreceiver in the doc.
True, we already use wal sender, I should have said similar phrasing.
Regards,
--
Dimitri
Anssi Kääriäinen wrote:
I tried to break the version 11 of the patch (some of the work was
against earlier versions). In total I have used a full work day
just trying to break things, but haven't been able to find anything
after version 8. I can verify that the partial index issue is
fixed,
On Mon, Jan 17, 2011 at 11:18, Dimitri Fontaine dimi...@2ndquadrant.fr wrote:
Magnus Hagander mag...@hagander.net writes:
With pg_basebackup, you can set up streaming replication in what's
basically a single command (run the base backup, copy i na
recovery.conf file). In my first version I
Peter Eisentraut wrote:
On m?n, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote:
which, as Magnus points out, includes non-procedural languages (SQL).
I think that list languages could be confusing to newcomers -- the
very people who might be reading through the help output of psql
Tom Lane wrote:
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 11:47 AM, Bruce Momjian br...@momjian.us wrote:
It seems like /contrib would be more natural, no? ?/bin seems like
overkill because most people will not want to run it. ?Most of /contrib
is installed already
Robert Haas wrote:
On Mon, Jan 17, 2011 at 12:05 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 11:47 AM, Bruce Momjian br...@momjian.us wrote:
It seems like /contrib would be more natural, no? ?/bin seems like
overkill because
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 12:05 PM, Tom Lane t...@sss.pgh.pa.us wrote:
On Red Hat, it is not packaged at all (at least not by me), and won't
be unless it goes into contrib. I don't believe it belongs in the
base package.
I confess to some confusion
Jeff Janes wrote:
A review:
Thanks! Very thorough!
None of the issues I raise above are severe. Does that mean I
should change the status to ready for committer?
I see that notion was endorsed by Robert, so I'll leave it alone for
now. If a committer asks me to do something about any
Bruce Momjian br...@momjian.us writes:
Robert Haas wrote:
I confess to some confusion about what things belong where.
I was suggesting /contrib because it seems to be of limited usefulness.
I assume people want pg_upgrade to stay in /contrib for the same reason.
pg_upgrade is a different
On Mon, Jan 17, 2011 at 12:48 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 17, 2011 at 12:05 PM, Tom Lane t...@sss.pgh.pa.us wrote:
On Red Hat, it is not packaged at all (at least not by me), and won't
be unless it goes into contrib. I don't
Well I'm not seeing that here
I am not at work at the moment and I don't have the possibility to compile
PostgreSQL on this computer, so the example here is from memory.
The issue I saw was this: assume you have an extension foo, containing one
function, test().
CREATE EXTENSION foo;
DROP
Josh Berkus wrote:
On 1/15/11 4:30 PM, Bruce Momjian wrote:
Josh Berkus wrote:
Last I remember, we were going to add this as an option. But I don't
see a patch in the queue. Am I missing it? Was I supposed to write it?
I don't know, but let me add that I am confused how this would
Jeff Janes wrote:
Have you ever tested Robert's other idea of having a metronome process
do a periodic fsync on a dummy file which is located on the same ext3fs
as the table files? I think that that would be interesting to see.
To be frank, I really don't care about fixing this behavior on
I have been taking a peek at the following commitfest item:
https://commitfest.postgresql.org/action/patch_view?id=497
Submission:
- I had to trim a little off the end of the patch to apply it, but
that's likely the fault of how I cut'n'pasted it. It applied cleanly
against HEAD.
- I
Magnus Hagander mag...@hagander.net writes:
On Mon, Jan 17, 2011 at 17:46, Tom Lane t...@sss.pgh.pa.us wrote:
I think it'd make more sense just to say that replication connections
are subject to the same log_connections rule as others. An extra GUC
for this is surely overkill.
I thought so,
1 - 100 of 174 matches
Mail list logo
