Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

On 10/07/2015 09:27 AM, Michael Paquier wrote: > On Wed, Oct 7, 2015 at 7:51 AM, Michael Paquier > wrote: >> On Wed, Oct 7, 2015 at 7:43 AM, Michael Paquier >> wrote: >>> On Wed, Oct 7, 2015 at 5:58 AM, Robert Haas wrote: On Sat, Oct 3,

Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

On Wed, Oct 7, 2015 at 4:16 PM, Amir Rohan wrote: > On 10/07/2015 09:27 AM, Michael Paquier wrote: >> On Wed, Oct 7, 2015 at 7:51 AM, Michael Paquier >> wrote: >>> On Wed, Oct 7, 2015 at 7:43 AM, Michael Paquier >>>

Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

On 25 September 2015 at 14:29, Michael Paquier wrote: > I also arrived at the conclusion that it would be > better to place the new package file in src/test/perl instead of > src/test/recovery to allow any users of the TAP tests to have it in their > PERL5LIB path and

Re: [HACKERS] pg_ctl/pg_rewind tests vs. slow AIX buildfarm members

On Sat, Sep 26, 2015 at 9:12 AM, Tom Lane wrote: > So the attached modified patch adjusts the PID-match logic and some > comments, but is otherwise what I posted before. I believe that this > might actually work on Windows, but I have no way to test it. Someone > please try that? (Don't forget

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

Hello, At Wed, 7 Oct 2015 00:24:57 -0400, Robert Haas wrote in > On Wed, Oct 7, 2015 at 12:10 AM, Kyotaro HORIGUCHI > wrote: > >> IIUC, I think that if ROW_MARK_COPY is

[HACKERS] [PATCH] Documentation bug in 9.5/ master - pg_replication_origin_session_setup

Hi All, There appears to be a typo error in documentation of this function. Actual function is 'pg_replication_origin_session_setup' while documentation has it as 'pg_replication_origin_setup_session'. Please find patch for 9.5 and master attached. Thanks, Pallavi diff --git

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

On 2015/10/07 15:06, Kyotaro HORIGUCHI wrote: At Wed, 7 Oct 2015 00:24:57 -0400, Robert Haas wrote I think it rather requires *replacing* two resjunk columns by one new one. The whole-row references for the individual foreign tables are only there to support

Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

On Wed, Oct 7, 2015 at 7:51 AM, Michael Paquier wrote: > On Wed, Oct 7, 2015 at 7:43 AM, Michael Paquier > wrote: >> On Wed, Oct 7, 2015 at 5:58 AM, Robert Haas wrote: >>> On Sat, Oct 3, 2015 at 7:38 AM, Michael Paquier wrote: >>> It seems

Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

On 10/07/2015 10:29 AM, Michael Paquier wrote: > On Wed, Oct 7, 2015 at 4:16 PM, Amir Rohan wrote: >> On 10/07/2015 09:27 AM, Michael Paquier wrote: >>> On Wed, Oct 7, 2015 at 7:51 AM, Michael Paquier >>> wrote: On Wed, Oct 7, 2015 at 7:43 AM,

Re: [HACKERS] RLS bug in expanding security quals

Haribabu, * Haribabu Kommi (kommi.harib...@gmail.com) wrote: > During the testing of multi-tenancy feature from system catalog views, that > is described in [1], found a problem in executing "user_privileges" view > from information_schema. The following is the minimal test sql that > reproduces

Re: [HACKERS] cash_mul_int8 / cash_div_int8

On Thu, Oct 8, 2015 at 12:11 AM, Kohei KaiGai wrote: > Also, cash_pl, cash_mi, cash_mul_int4 and so on... does not have overflow > checks > like as int8pl has. > > Of course, most of people don't need to worry about 64bit overflow for > money... :-). If you are using

Re: [HACKERS] PATCH: index-only scans with partial indexes

Hello, > The attached patch applies on the latest v5 patch and will > address above issues. (And modifies expected files, which are the > manifestation of this improovement). As you see, it is a quite bad choice. Ugly and unreadable and fragile. The cause of this seeming mismatch would be the

Re: [HACKERS] More work on SortSupport for text - strcoll() and strxfrm() caching

On Tue, Oct 6, 2015 at 1:16 PM, Robert Haas wrote: > If you would care to revise the patch accordingly, I will commit it > (barring objections from others, of course). Here is a revision of 0001-*, with both BSWAP32() and BSWAP64() in a new header, src/port/pg_bswap.h. No

[HACKERS] RLS bug in expanding security quals

During the testing of multi-tenancy feature from system catalog views, that is described in [1], found a problem in executing "user_privileges" view from information_schema. The following is the minimal test sql that reproduces the problem. SELECT (u_grantor.rolname) AS grantor,

Re: [HACKERS] RLS bug in expanding security quals

On Thu, Oct 8, 2015 at 2:54 PM, Stephen Frost wrote: > Haribabu, > > * Haribabu Kommi (kommi.harib...@gmail.com) wrote: >> During the testing of multi-tenancy feature from system catalog views, that >> is described in [1], found a problem in executing "user_privileges" view >>

Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

On Wed, Oct 7, 2015 at 5:44 PM, Amir Rohan wrote: > On 10/07/2015 10:29 AM, Michael Paquier wrote: >> On Wed, Oct 7, 2015 at 4:16 PM, Amir Rohan wrote: >>> Also, the removal of poll_query_until from pg_rewind looks suspiciously >>> like a copy-paste gone bad. Pardon if I'm missing something. >> >>

Re: [HACKERS] bugs and bug tracking

On 7 October 2015 at 02:33, Nathan Wagner wrote: > I think even with a bug tracker the default "ignore" behavior can still > be done. In principle, we could even mark bugs as "unconfirmed" or > "logged" or something right away and only mark them as new or open or >

Re: [HACKERS] btreecheck extension

--On 16. Juni 2014 18:47:30 -0700 Peter Geoghegan wrote: > Attached prototype patch adds contrib extension, btreecheck. This > extension provides SQL-callable functions for checking these > conditions on nbtree indexes on live systems. What's the current state of this module?

Re: [HACKERS] btreecheck extension

On Wed, Oct 7, 2015 at 2:59 AM, Bernd Helmle wrote: > What's the current state of this module? I see you are interested in stress > testing, but i'm not sure how far this all is gone? > > This tool actually served a very good job during identifying index > corruption due to

Re: [HACKERS] bugs and bug tracking

On 6 October 2015 at 21:05, Nathan Wagner wrote: > A lot of the reports aren't bugs at all, but requests for help. My > guess is that the users either don't know where to ask or don't > understand the difference between a bug and not knowing how to do what > they want to

Re: [HACKERS] pg_dump LOCK TABLE ONLY question

Oct 2 2015 01:19 "Michael Paquier" wrote: > > On Thu, Oct 1, 2015 at 10:43 PM, Filip Rembiałkowski < filip.rembialkow...@gmail.com> wrote: > > I just want to understand why there is LOCK TABLE not LOCK TABLE ONLY. > > It seems to me that you'd still want to use LOCK

Re: [HACKERS] Small documentation fix in src/interfaces/ecpg/preproc/po/pt_BR.po

On Tue, Oct 6, 2015 at 6:49 PM, Andreas 'ads' Scherbaum wrote: > When working on a script, I stumbled over a mistake in the pt_BR.po > translation for ecpg. Patch attached. Translations are sync'd to the main repository from the translations project - so I assume this

Re: [HACKERS] pg_ctl/pg_rewind tests vs. slow AIX buildfarm members

Michael Paquier writes: > On Sat, Sep 26, 2015 at 9:12 AM, Tom Lane wrote: >> So the attached modified patch adjusts the PID-match logic and some >> comments, but is otherwise what I posted before. I believe that this >> might actually work on Windows, but I have no

Re: [HACKERS] Small documentation fix in src/interfaces/ecpg/preproc/po/pt_BR.po

On Wed, Oct 7, 2015 at 08:00:43AM -0400, Robert Haas wrote: > On Tue, Oct 6, 2015 at 6:49 PM, Andreas 'ads' Scherbaum > wrote: > > When working on a script, I stumbled over a mistake in the pt_BR.po > > translation for ecpg. Patch attached. > > Translations are sync'd to

Re: [HACKERS] bugs and bug tracking

Magnus, * Magnus Hagander (mag...@hagander.net) wrote: > On Wed, Oct 7, 2015 at 4:40 PM, Stephen Frost wrote: > > * Nathan Wagner (nw...@hydaspes.if.org) wrote: > > > I think I have suggested that there be a way to generate a bug id via > > > email. Presumably someone could

[HACKERS] cash_mul_int8 / cash_div_int8

I noticed cash_mul_int8 / cash_div_int8 are defined in cash.c, however, pg_proc.h and pg_operator.h contains no relevant entries. Is it just a careless oversight? Thanks, -- KaiGai Kohei -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] pg_ctl/pg_rewind tests vs. slow AIX buildfarm members

Michael Paquier writes: > On Sat, Sep 26, 2015 at 9:12 AM, Tom Lane wrote: >> So the attached modified patch adjusts the PID-match logic and some >> comments, but is otherwise what I posted before. I believe that this >> might actually work on Windows, but I have no

Re: [HACKERS] bugs and bug tracking

On Wed, Oct 7, 2015 at 4:56 PM, Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > > On Wed, Oct 7, 2015 at 4:40 PM, Stephen Frost > wrote: > > > * Nathan Wagner (nw...@hydaspes.if.org) wrote: > > > > I think I have suggested that

Re: [HACKERS] cash_mul_int8 / cash_div_int8

Also, cash_pl, cash_mi, cash_mul_int4 and so on... does not have overflow checks like as int8pl has. Of course, most of people don't need to worry about 64bit overflow for money... :-). 2015-10-08 0:03 GMT+09:00 Kohei KaiGai : > I noticed cash_mul_int8 / cash_div_int8 are

Re: [HACKERS] Small documentation fix in src/interfaces/ecpg/preproc/po/pt_BR.po

On 06-10-2015 19:49, Andreas 'ads' Scherbaum wrote: When working on a script, I stumbled over a mistake in the pt_BR.po translation for ecpg. Patch attached. I've already fixed it in the translation git. It'll be available only in the next set of releases. -- Euler Taveira

Re: [HACKERS] bugs and bug tracking

* Nathan Wagner (nw...@hydaspes.if.org) wrote: > I think I have suggested that there be a way to generate a bug id via > email. Presumably someone could just copy that email address to make a > not-tracked discussion get a bug id. If the system archived all the > lists (not hard) it would be

Re: [HACKERS] cash_mul_int8 / cash_div_int8

Kohei KaiGai writes: > I noticed cash_mul_int8 / cash_div_int8 are defined in cash.c, > however, pg_proc.h and pg_operator.h contains no relevant entries. > Is it just a careless oversight? Hm. I'd be inclined to fix that by removing the dead code, since it's evidently

Re: [HACKERS] bugs and bug tracking

On Wed, Oct 7, 2015 at 4:40 PM, Stephen Frost wrote: > * Nathan Wagner (nw...@hydaspes.if.org) wrote: > > I think I have suggested that there be a way to generate a bug id via > > email. Presumably someone could just copy that email address to make a > > not-tracked

Re: [HACKERS] bugs and bug tracking

Magnus Hagander writes: > If I understand that correct, it completely breaks the current workflow of > "reply-all"? When I need to comment on a bug, isntead of hitting reply-all, > i should send it to the @bugs address? Or are you saying in those cases you > still hit

Re: [HACKERS] bugs and bug tracking

Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > If you want such an API, I won't stop you from using it, but I will not > > use it myself. Please put in message-body commands as well. > > So, unsurprisingly, debbugs does support all commands that can be sent > to control@ also

Re: [HACKERS] Small documentation fix in src/interfaces/ecpg/preproc/po/pt_BR.po

On 07-10-2015 14:05, Alvaro Herrera wrote: Euler Taveira wrote: On 06-10-2015 19:49, Andreas 'ads' Scherbaum wrote: When working on a script, I stumbled over a mistake in the pt_BR.po translation for ecpg. Patch attached. I've already fixed it in the translation git. It'll be available only

Re: [HACKERS] [DOCS] max_worker_processes on the standby

On Fri, Oct 2, 2015 at 11:58 PM, Alvaro Herrera wrote: > Fujii Masao wrote: > >> What happens if pg_xact_commit_timestamp() is called in standby after >> track_commit_timestamp is disabled in master, DeactivateCommitTs() is >> called and all commit_ts files are removed

Re: [HACKERS] bugs and bug tracking

* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Stephen Frost wrote: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > > If you want such an API, I won't stop you from using it, but I will not > > > use it myself. Please put in message-body commands as well. > > > > So, unsurprisingly, debbugs

Re: [HACKERS] bugs and bug tracking

* Stephen Frost (sfr...@snowman.net) wrote: > Perhaps it'd be better to have pgsql-bugs be the "Package owner", who > also gets emails about bug activity on their packages. That way, we > could have a 'jdbc' package whose owner is pgsql-jdbc and pgsql-bugs > wouldn't end up with that bug traffic

Re: [HACKERS] bugs and bug tracking

Nathan Wagner wrote: > I am still working out exactly how to find multiple matching commits > along different branches. I'm running git patch-id on every commit, > but that will take a while. See src/tools/git_changelog (both the output and the implementation). Isn't that rather what you want?

Re: [HACKERS] bugs and bug tracking

On Wed, Oct 7, 2015 at 8:47 PM, Alvaro Herrera wrote: > Nathan Wagner wrote: > > > I am still working out exactly how to find multiple matching commits > > along different branches. I'm running git patch-id on every commit, > > but that will take a while. > > See

Re: [HACKERS] bugs and bug tracking

Stephen Frost writes: > I *really* don't like the idea of rewriting the From/To completely to > force all mail through a relay and I'm pretty sure that "fix" would be > far worse than the problem. Agreed; but adding a Reply-To: header seems quite reasonable. (Unless gmail

Re: [HACKERS] bugs and bug tracking

On Wed, Oct 7, 2015 at 8:59 PM, Tom Lane wrote: > Stephen Frost writes: > > I *really* don't like the idea of rewriting the From/To completely to > > force all mail through a relay and I'm pretty sure that "fix" would be > > far worse than the problem. >

Re: [HACKERS] bugs and bug tracking

* Nathan Wagner (nw...@hydaspes.if.org) wrote: > I have added full text searching to my tracker. I only index the first > 50 KB of each message. There's apparently a one MB limit on that > anyway, which a few messages exceed. I figure anything important is > probably in the first 50KB. I could

Re: [HACKERS] bugs and bug tracking

Josh Berkus wrote: > On 10/07/2015 10:25 AM, Alvaro Herrera wrote: > > Hmm, I guess we could have the bug form add > > To: n...@bugs.postgresql.org > > CC: pgsql-b...@postgresql.org > > as headers, which should work for most people (since we reply-all), Josh > > Berkus being the exception. > >

Re: [HACKERS] bugs and bug tracking

On 2015-10-07 14:58:41 -0300, Alvaro Herrera wrote: > Stephen Frost wrote: > > One example of how it's used can be seen with this thread: > > > > http://lists.alioth.debian.org/pipermail/pkg-postgresql-public/2015-September/002803.html > > So in the pipermail interface you get the impression

Re: [HACKERS] bugs and bug tracking

* Josh Berkus (j...@agliodbs.com) wrote: > As a serious response, "reply-all" is NOT the default for common GUI > mail clients (TB, Apple, Gmail, etc.), and I know on TB that it's not > even possible to make it the default (I miss Kmail). So a system which > depends on the user ... including

Re: [HACKERS] bugs and bug tracking

Stephen Frost wrote: > * Stephen Frost (sfr...@snowman.net) wrote: > > Perhaps it'd be better to have pgsql-bugs be the "Package owner", who > > also gets emails about bug activity on their packages. That way, we > > could have a 'jdbc' package whose owner is pgsql-jdbc and pgsql-bugs > >

Re: [HACKERS] bugs and bug tracking

On 10/07/2015 10:25 AM, Alvaro Herrera wrote: > Hmm, I guess we could have the bug form add > To: n...@bugs.postgresql.org > CC: pgsql-b...@postgresql.org > as headers, which should work for most people (since we reply-all), Josh > Berkus being the exception. Well, this will just give you more

Re: [HACKERS] bugs and bug tracking

* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Stephen Frost wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > > > Perhaps it'd be better to have pgsql-bugs be the "Package owner", who > > > also gets emails about bug activity on their packages. That way, we > > > could have a 'jdbc'

Re: [HACKERS] bugs and bug tracking

* Andres Freund (and...@anarazel.de) wrote: > On 2015-10-07 14:58:41 -0300, Alvaro Herrera wrote: > > Stephen Frost wrote: > > > One example of how it's used can be seen with this thread: > > > > > > http://lists.alioth.debian.org/pipermail/pkg-postgresql-public/2015-September/002803.html > > >

Re: [HACKERS] bugs and bug tracking

On 10/07/2015 11:05 AM, Alvaro Herrera wrote: > Josh Berkus wrote: >> On 10/07/2015 10:25 AM, Alvaro Herrera wrote: >>> Hmm, I guess we could have the bug form add >>> To: n...@bugs.postgresql.org >>> CC: pgsql-b...@postgresql.org >>> as headers, which should work for most people (since we

Re: [HACKERS] bugs and bug tracking

Stephen Frost wrote: > * Andres Freund (and...@anarazel.de) wrote: > > On 2015-10-07 14:58:41 -0300, Alvaro Herrera wrote: > > > Stephen Frost wrote: > > > > One example of how it's used can be seen with this thread: > > > > > > > >

Re: [HACKERS] bugs and bug tracking

* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > So in the pipermail interface you get the impression that after three > messages the thread stopped. But if you go to > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797804 > you realize that there's further traffic in the bug that wasn't

Re: [HACKERS] bugs and bug tracking

Josh Berkus wrote: > On 10/07/2015 11:05 AM, Alvaro Herrera wrote: > > Josh Berkus wrote: > >> On 10/07/2015 10:25 AM, Alvaro Herrera wrote: > >>> Hmm, I guess we could have the bug form add > >>> To: n...@bugs.postgresql.org > >>> CC: pgsql-b...@postgresql.org > >>> as headers, which should

Re: [HACKERS] bugs and bug tracking

I have added full text searching to my tracker. I only index the first 50 KB of each message. There's apparently a one MB limit on that anyway, which a few messages exceed. I figure anything important is probably in the first 50KB. I could be wrong. I could re-index fairly easily. It seems

Re: [HACKERS] Small documentation fix in src/interfaces/ecpg/preproc/po/pt_BR.po

Euler Taveira wrote: > On 06-10-2015 19:49, Andreas 'ads' Scherbaum wrote: > >When working on a script, I stumbled over a mistake in the pt_BR.po > >translation for ecpg. Patch attached. > > > I've already fixed it in the translation git. It'll be available only in the > next set of releases.

Re: [HACKERS] bugs and bug tracking

* Tom Lane (t...@sss.pgh.pa.us) wrote: > If you want such an API, I won't stop you from using it, but I will not > use it myself. Please put in message-body commands as well. So, unsurprisingly, debbugs does support all commands that can be sent to control@ also through the

Re: [HACKERS] bugs and bug tracking

* Magnus Hagander (mag...@hagander.net) wrote: > On Wed, Oct 7, 2015 at 4:56 PM, Stephen Frost wrote: > > reply-all works just fine, since you like to know *exactly* how it works > > at a technical level, I just checked and the bug email address is > > automatically included