Re: [HACKERS] 9.5 CF1

2014-06-18 Thread Magnus Hagander
the patch is much better from my point of view as a subsequent reviewer and committer. Worth noting also is that Magnus is working on a new version of the commitfest app that will be able to automatically keep track of threads about patches --- so long as they *are* threads according to our

Re: [HACKERS] BUG #10680 - ldapbindpasswd leaks to postgresql log

2014-06-18 Thread Magnus Hagander
(we parsed it out), it shouldn't be impossible to actually blank out *just the password*, without ruining all the other diagnostics usage of it. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] replication commands and log_statements

2014-06-11 Thread Magnus Hagander
it would be ddl,dml,all or something like that, and then you'd also add replication as an option. But that would cause all sorts of backwards compatibility annoyances.. And do you really want to be able to say things like ddl,all meanin you'd get ddl and select but not dml? -- Magnus Hagander Me

Re: [HACKERS] replication commands and log_statements

2014-06-11 Thread Magnus Hagander
On Wed, Jun 11, 2014 at 2:17 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-11 13:42:58 +0200, Magnus Hagander wrote: On Wed, Jun 11, 2014 at 12:34 PM, Fujii Masao masao.fu...@gmail.com wrote: Hi, Replication commands like IDENTIFY_COMMAND are not logged even when

Re: [HACKERS] replication commands and log_statements

2014-06-11 Thread Magnus Hagander
On Wed, Jun 11, 2014 at 2:35 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-11 14:22:43 +0200, Magnus Hagander wrote: Yes, but how would you specify for example i want DDL and all replication commands (which is quite a reasonable thing to log, I believe). If you actually

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-06-10 Thread Magnus Hagander
. I like the idea of an environment variable if we need it to be changeable. Or perhaps what we need is just better documentation of what's there already. Perhaps the documentation should have a section specifically aimed at packagers? /Magnus

Re: [HACKERS] pg_basebackup failed to back up large file

2014-06-09 Thread Magnus Hagander
On Wednesday, June 4, 2014, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net javascript:; writes: On Tue, Jun 3, 2014 at 6:38 PM, Tom Lane t...@sss.pgh.pa.us javascript:; wrote: Another thought is we could make pg_basebackup simply skip any files that exceed

Re: [HACKERS] Supporting Windows SChannel as OpenSSL replacement

2014-06-09 Thread Magnus Hagander
, but in the end I think we want to have symmetrical support. But it might be worth doing just the client side initially, and then move to the server. I think in general, the client side is actually likely to be *harder* than the server side.. -- Magnus Hagander Me: http://www.hagander.net/ Work: http

Re: [HACKERS] Supporting Windows SChannel as OpenSSL replacement

2014-06-09 Thread Magnus Hagander
that's what a lot of clients are interested in and they don't care aobut more than that. Obviously, we also have to do something about PQinitOpenSSL(). Unfortunately, I think it's too late to do that for 9.4 - otherwise it would've been good to have a whole cycle of deprecation on it... -- Magnus

Re: [HACKERS] Supporting Windows SChannel as OpenSSL replacement

2014-06-09 Thread Magnus Hagander
can't remember where that ended up - I'll see if I can poke his interest :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Supporting Windows SChannel as OpenSSL replacement

2014-06-09 Thread Magnus Hagander
On Mon, Jun 9, 2014 at 4:39 PM, Martijn van Oosterhout klep...@svana.org wrote: On Mon, Jun 09, 2014 at 03:35:23PM +0200, Magnus Hagander wrote: On Mon, Jun 9, 2014 at 3:19 PM, Andreas Karlsson andr...@proxel.se wrote: On 06/09/2014 01:45 PM, Heikki Linnakangas wrote

Re: [HACKERS] Supporting Windows SChannel as OpenSSL replacement

2014-06-09 Thread Magnus Hagander
On Mon, Jun 9, 2014 at 7:45 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 06/09/2014 06:03 PM, Magnus Hagander wrote: One tricky part is that programs like to use libpq for the authentication, and then they hijack the connection using PGgetssl(). Is there*anybody* other than

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Magnus Hagander
be confusing for many end-users. +500. We already have two directories that users remove to get free space thinking it's safe because it's just log files. We don't need one more :-) /Magnus

Re: [HACKERS] slotname vs slot_name

2014-06-05 Thread Magnus Hagander
. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] pg_basebackup failed to back up large file

2014-06-04 Thread Magnus Hagander
On Tue, Jun 3, 2014 at 6:38 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Yeah, that is a clear advantage of that method. Didn't read up on pax format backwards compatibility, does it have some trick to achieve something similar? I didn't read

Re: [HACKERS] Sigh, we need an initdb

2014-06-04 Thread Magnus Hagander
isn't valid, so if they are otherwise good, we should accept them. /Magnus

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-06-03 Thread Magnus Hagander
to apply the fix now... +1 for fixing it now. +1 for fixing it for 9.4 before the next beta, but *not* backpatching it to 9.3 - it *is* a behaviour change after all.. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] pg_basebackup failed to back up large file

2014-06-03 Thread Magnus Hagander
probably have an overflow check there, which it doesn't. It's going to write some strange values int here if it overflows.. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] pg_basebackup failed to back up large file

2014-06-03 Thread Magnus Hagander
On Tue, Jun 3, 2014 at 5:12 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-03 11:04:58 -0400, Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: On Tue, Jun 3, 2014 at 4:40 PM, Tom Lane t...@sss.pgh.pa.us wrote: There's a far bigger problem there, which is if we're

Re: [HACKERS] pg_basebackup failed to back up large file

2014-06-03 Thread Magnus Hagander
, or other popular platforms? (The size extension in the general ustar format seems to be, so it would be a shame if this one is less portable) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] pg_basebackup failed to back up large file

2014-06-03 Thread Magnus Hagander
On Jun 3, 2014 6:17 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-03 17:57:52 +0200, Magnus Hagander wrote: On Tue, Jun 3, 2014 at 5:42 PM, Tom Lane t...@sss.pgh.pa.us wrote: What we had better do, IMO, is fix things so that we don't have a filesize limit in the basebackup

Re: [HACKERS] Odd uuid-ossp behavior on smew and shearwater

2014-05-30 Thread Magnus Hagander
-containers. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] pg_basebackup: could not get transaction log end position from server: FATAL: could not open file ./pg_hba.conf~: Permission denied

2014-05-16 Thread Magnus Hagander
than ignoring errors. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] pg_basebackup: could not get transaction log end position from server: FATAL: could not open file ./pg_hba.conf~: Permission denied

2014-05-16 Thread Magnus Hagander
On Fri, May 16, 2014 at 6:25 PM, Andres Freund and...@2ndquadrant.comwrote: On 2014-05-16 18:20:35 +0200, Magnus Hagander wrote: On Fri, May 16, 2014 at 5:46 PM, Joshua D. Drake j...@commandprompt.com wrote: At a minimum: Check to see if there is going to be a permission error

Re: [HACKERS] imprecise pg_basebackup documentation about excluded files

2014-05-11 Thread Magnus Hagander
added a link to the protocol documentation and added more details there, also about pg_replslot handling. Not sure exactly how much detail we want to document, but it seems reasonable to make it complete if we provide a list at all. +1. Seems good to me. -- Magnus Hagander Me: http

Re: [HACKERS] New pg_lsn type doesn't have hash/btree opclasses

2014-05-10 Thread Magnus Hagander
it? Don't we have precedents for requiring pg_upgrade during beta? At least that's a smaller problem than requiring a complete dump/reload. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Wanted: jsonb on-disk representation documentation

2014-05-07 Thread Magnus Hagander
now or never. If the on-disk format needs changing, not doing it now is going to leave us with a jsonc in the future... Better bite the bullet now. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Wanted: jsonb on-disk representation documentation

2014-05-07 Thread Magnus Hagander
*know* a dump/reload will be needed to go beta1-beta2, we should actually document that in the releasenotes of beta1 already. So people can make proper plans.. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Wanted: jsonb on-disk representation documentation

2014-05-07 Thread Magnus Hagander
On Wed, May 7, 2014 at 3:04 PM, Andres Freund and...@2ndquadrant.comwrote: On 2014-05-07 15:00:01 +0200, Magnus Hagander wrote: On Wed, May 7, 2014 at 2:56 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-05-07 08:50:33 -0400, Robert Haas wrote: On Wed, May 7, 2014 at 7:40 AM

Re: [HACKERS] proposal: Set effective_cache_size to greater of .conf value, shared_buffers

2014-05-07 Thread Magnus Hagander
perhaps we can reach the level where we can just remove it.. But that's all handwaving about the future of course). -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] TABLESPACE and directory for Foreign tables?

2014-05-05 Thread Magnus Hagander
that, but they potentially could, in the future, with Logical Streaming Replication. Presumably they'd also be inconsistent? And as such not really useful unless you actually shut the database down before you back it up (e.g. don't use pg_basebackup)? -- Magnus Hagander Me: http://www.hagander.net/ Work

Re: [HACKERS] 9.4 release notes

2014-05-04 Thread Magnus Hagander
the technology, not the advocacy. (That's for things like the press kit..) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Sending out a request for more buildfarm animals?

2014-05-04 Thread Magnus Hagander
that - it's chipmunk. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Buildfarm master-next branch?

2014-04-29 Thread Magnus Hagander
blow the whole jail away once the build is complete), but one of the main platforms that people would want to use this on I bet is Windows, which has no such facilities AFAIK. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Compilation of pg_recvlogical on Windows

2014-04-24 Thread Magnus Hagander
On Thu, Apr 24, 2014 at 8:49 AM, Michael Paquier michael.paqu...@gmail.comwrote: Hi all, I noticed that pg_recvlogical is not currently compiled on Windows when using the msvc scripts. The patch attached corrects that. Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net

Re: [HACKERS] logical changeset generation v6

2014-04-24 Thread Magnus Hagander
of pg_recvxlog we have a few more days to make a decision..) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] logical changeset generation v6

2014-04-24 Thread Magnus Hagander
On Thu, Apr 24, 2014 at 9:43 AM, Andres Freund and...@2ndquadrant.comwrote: On 2014-04-24 09:39:21 +0200, Magnus Hagander wrote: I can't find that this discussion actually came to a proper consensus, but I may be missing something. Did we go with pg_recvlogical just because we couldn't

Re: [HACKERS] Perfomance degradation 9.3 (vs 9.2) for FreeBSD

2014-04-22 Thread Magnus Hagander
that in the discussion about that one. I agree that if we have that, it makes perfect sense to have the same setting available for the main shared memory segment. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Perfomance degradation 9.3 (vs 9.2) for FreeBSD

2014-04-21 Thread Magnus Hagander
the implementation when multiple are available, that could then be set by default for example by the freebsd ports build? That's a lot less overhead to keep dragging around... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo fix in src/backend/access/transam/recovery.conf.sample

2014-04-18 Thread Magnus Hagander
On Fri, Apr 18, 2014 at 12:24 PM, Amit Langote amitlangot...@gmail.comwrote: Hi, Attached fixes a minor typo in src/backend/access/transam/recovery.conf.sample. Applied, except I also rewrapped the line to make it shorter. Thanks! -- Magnus Hagander Me: http://www.hagander.net/ Work

[HACKERS] Tracking replication slot blockings

2014-04-16 Thread Magnus Hagander
of which slave(s) are having enough trouble keeping up to potentially cause issues. Not having looked at that code at all yet, would this be something that's simple to add? Or is it a silly idea? :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Tracking replication slot blockings

2014-04-16 Thread Magnus Hagander
On Wed, Apr 16, 2014 at 6:56 PM, Andres Freund and...@2ndquadrant.comwrote: Hi, On 2014-04-16 18:51:41 +0200, Magnus Hagander wrote: I'm thinking it could be interesting to know how many times (or in some other useful unit than times - how often) a specific replication slot has blocked

Re: [HACKERS] LDAP: bugfix and deprecated OpenLDAP API

2014-04-16 Thread Magnus Hagander
all over again..) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] New option in pg_basebackup to exclude pg_log files during base backup

2014-04-09 Thread Magnus Hagander
in pg_basebackup - like a guc saying which directories should always be excluded from a basebackup? So you don't have to remember it every time? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] New option in pg_basebackup to exclude pg_log files during base backup

2014-04-09 Thread Magnus Hagander
On Wed, Apr 9, 2014 at 4:55 PM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: Magnus Hagander wrote: While pg_log is definitely the most common one being the default on many platforms, we'll still be missing other ones. Should we really hardcode it, or should we somehow derive it from

Re: [HACKERS] Including replication slot data in base backups

2014-04-01 Thread Magnus Hagander
the solution is the right one. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] datistemplate of pg_database does not behave as per description in documentation

2014-03-27 Thread Magnus Hagander
better to document it. However, that also raises a third option. We could just drop the idea if datistemplate completely, and remove the column. Since clearly it's not actually doing anything, and people seem to have been happy with that for a while, why do we need it in the first place? -- Magnus

Re: [HACKERS] datistemplate of pg_database does not behave as per description in documentation

2014-03-27 Thread Magnus Hagander
On Mar 27, 2014 12:45 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Thu, Mar 27, 2014 at 9:12 AM, Rajeev rastogi rajeev.rast...@huawei.comwrote: But current code does not behave in this manner. Even if dbistemplate of database is false, still

[HACKERS] Dynamic background workers docs question

2014-03-24 Thread Magnus Hagander
. This doesn't apply to dynamic ones, which we might want to clarify. Do we have a term for non-dynamic background workers? static workers? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Dynamic background workers docs question

2014-03-24 Thread Magnus Hagander
On Mon, Mar 24, 2014 at 12:20 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Mar 24, 2014 at 5:54 PM, Magnus Hagander mag...@hagander.net wrote: I was looking at http://www.postgresql.org/docs/devel/static/bgworker.html with a client today. It says: Unlike

Re: [HACKERS] pg_basebackup --slot=SLOTNAME -X stream

2014-03-18 Thread Magnus Hagander
, and then destroyed by BASE_BACKUP. But you also want it auto-destroyed if the BASE_BACKUP connection gets terminated for example.. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Fix typo in nbtree.h introduced by efada2b

2014-03-17 Thread Magnus Hagander
On Mon, Mar 17, 2014 at 6:06 AM, Michael Paquier michael.paqu...@gmail.comwrote: Hi, I found a small typo in nbtree.h, introduced by commit efada2b. Patch is attached. Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] [bug fix] postgres.exe fails to start on Windows Server 2012 due to ASLR

2014-03-16 Thread Magnus Hagander
On Sat, Feb 22, 2014 at 5:44 AM, MauMau maumau...@gmail.com wrote: From: Magnus Hagander mag...@hagander.net Does somebody want to look at backpatching this to 9.1 and earlier, or should we just say that it's not fully supported on those Windows versions unless you apply the registry

Re: [HACKERS] Upcoming back branch releases

2014-03-16 Thread Magnus Hagander
for 9.0/9.1 in response to Magnus san? http://www.postgresql.org/message-id/9C709659FE3C4B8DA7135C6F307B83 F5@maumau Hi! I just applied this patch. Apologies for the delay, and thanks for the reminder! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2014-03-14 Thread Magnus Hagander
datatypes and not text? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] db_user_namespace a temporary measure

2014-03-12 Thread Magnus Hagander
? Given that a superuser can load and run binaries, how would you propose you restrict that superuser from doing anything they want? And if you don't need that functionality, then hows it really different from being the database owner? /Magnus

Re: [HACKERS] db_user_namespace a temporary measure

2014-03-12 Thread Magnus Hagander
On Wed, Mar 12, 2014 at 3:52 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Yeah, what we really need is encapsulated per-DB users and local superusers. I think every agrees that this is the goal, but nobody wants to put in the work to implement

Re: [HACKERS] db_user_namespace a temporary measure

2014-03-11 Thread Magnus Hagander
want to officially deprecate it for 9.4, and then remove it later? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] db_user_namespace a temporary measure

2014-03-11 Thread Magnus Hagander
On Tue, Mar 11, 2014 at 2:40 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Sun, Mar 9, 2014 at 9:00 PM, Thom Brown t...@linux.com wrote: It will be 12 years this year since this temporary measure was added. I'm just wondering, is there any complete

Re: [HACKERS] jsonb and nested hstore

2014-03-06 Thread Magnus Hagander
with it at all. Most future users are almost certainly going to use the json interfaces, but we don't want to leave upgraded users behind. (But of course it has to actually maintain backwards compatibility for that argument to hold) -- Magnus Hagander Me: http://www.hagander.net/ Work: http

Re: [HACKERS] commit fest status and release timeline

2014-03-03 Thread Magnus Hagander
for *this* one, and we don't want to distrupt the flow even more by making big changes to the tooling in the middle of it. That said, there is definitely a need :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Securing make check (CVE-2014-0067)

2014-03-02 Thread Magnus Hagander
. That could certainly be a useful feature of it's own. But as you say, non-backpatchable. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Securing make check (CVE-2014-0067)

2014-03-02 Thread Magnus Hagander
. As in, they return HANDLEs, not SOCKETs, and you can't recv() and send() on them. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Securing make check (CVE-2014-0067)

2014-03-01 Thread Magnus Hagander
- do we have *any* Unix platforms that can't do unix sockets? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] [bug fix] postgres.exe fails to start on Windows Server 2012 due to ASLR

2014-02-18 Thread Magnus Hagander
supported on those Windows versions unless you apply the registry workaround? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] [review] PostgreSQL Service on Windows does not start if data directory given is relative path

2014-02-18 Thread Magnus Hagander
(I haven't looked into that much detail), but definitely the one between pg_regress and pg_ctl should be shared. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] [bug fix] postgres.exe fails to start on Windows Server 2012 due to ASLR

2014-02-18 Thread Magnus Hagander
On Tue, Feb 18, 2014 at 3:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: I've applied this and backpatched to 9.3 and 9.2, which is as far back as it goes cleanly. In 9.1 the build system looked significantly different, which makes it strange since

Re: [HACKERS] HBA files w/include support?

2014-02-14 Thread Magnus Hagander
it though :) It's not all that hard to do, but requires some minor refactoring of how the HBA code works. What would also be useful would be to be able to use such a function/tool against a different file than the current HBA one, to verify *before* you reload... -- Magnus Hagander Me: http

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-13 Thread Magnus Hagander
On Wed, Feb 12, 2014 at 10:53 PM, Peter Eisentraut pete...@gmx.net wrote: On 2/12/14, 4:34 PM, Magnus Hagander wrote: On Wed, Feb 12, 2014 at 10:28 PM, Peter Eisentraut pete...@gmx.net mailto:pete...@gmx.net wrote: On 2/12/14, 12:47 PM, Magnus Hagander wrote: Since there were

Re: [HACKERS] Prevent pg_basebackup -Fp -D -?

2014-02-13 Thread Magnus Hagander
On Thu, Feb 13, 2014 at 4:10 AM, Bruce Momjian br...@momjian.us wrote: On Thu, Oct 3, 2013 at 06:50:57AM +0200, Magnus Hagander wrote: On Oct 3, 2013 2:47 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Oct 2, 2013 at 11:31 PM, Magnus Hagander mag...@hagander.net wrote

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-12 Thread Magnus Hagander
On Mon, Feb 10, 2014 at 7:39 PM, Magnus Hagander mag...@hagander.netwrote: On Mon, Feb 10, 2014 at 7:29 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 02/09/2014 02:17 PM, Magnus Hagander wrote: If an error occurs in the foreground (backup) process of pg_basebackup, and we exit

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-12 Thread Magnus Hagander
On Wed, Feb 12, 2014 at 10:28 PM, Peter Eisentraut pete...@gmx.net wrote: On 2/12/14, 12:47 PM, Magnus Hagander wrote: Since there were no other objections, I've applied this patch. I'm getting a compiler warning: pg_basebackup.c:105:3: error: implicit declaration of function 'kill

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-11 Thread Magnus Hagander
wouldn't hurt :-) /Magnus

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-10 Thread Magnus Hagander
On Mon, Feb 10, 2014 at 7:29 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 02/09/2014 02:17 PM, Magnus Hagander wrote: If an error occurs in the foreground (backup) process of pg_basebackup, and we exit in a controlled way, the background process (streaming xlog process) would

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-02-09 Thread Magnus Hagander
and an added comment. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] Terminating pg_basebackup background streamer

2014-02-09 Thread Magnus Hagander
also consider adding a sigterm handler to pg_basebackup, so if you send it a SIGTERM it kills off the background process as well? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2014-01-29 Thread Magnus Hagander
a minute to do some greping) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2014-01-29 Thread Magnus Hagander
to diagnose. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-28 Thread Magnus Hagander
refers to just the global one. You want to exclude based on PGSTAT_STAT_PERMANENT_DIRECTORY (and of course based on the guc stats_temp_directory if it's in PGDATA. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] shouldn't we log permission errors when accessing the configured trigger file?

2014-01-27 Thread Magnus Hagander
log line is also very easy to miss - this should log enough that you wouldn't) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Visual Studio 2013 build

2014-01-26 Thread Magnus Hagander
stable and 9.4dev. The argument being that it's a new build env, and it's not likely that people are going to use that t o build very old versions of postgres. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] effective_cache_size calculation overflow

2014-01-26 Thread Magnus Hagander
somewhere in the calculation of effective_cache_size, most likely from the fact that it's now dynamically calculated. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] Tablespace options in \db+

2014-01-26 Thread Magnus Hagander
this trivial patch into 9.4? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index 0d4b151..43f1a1c 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -176,6 +176,11

Re: [HACKERS] extension_control_path

2014-01-25 Thread Magnus Hagander
to make them separate for different platforms. Shouldn't we just use semicolon on all platforms, for consistency? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] proposal: hide application_name from other users

2014-01-25 Thread Magnus Hagander
On Sat, Jan 25, 2014 at 10:42 AM, Greg Stark st...@mit.edu wrote: On Fri, Jan 24, 2014 at 6:46 AM, Magnus Hagander mag...@hagander.net wrote: What actually happens if you set the application_name in the connection string in that environment? Does it override it to it's own default? If so

Re: [HACKERS] proposal: hide application_name from other users

2014-01-25 Thread Magnus Hagander
On Fri, Jan 24, 2014 at 5:21 PM, Harold Giménez har...@heroku.com wrote: On Fri, Jan 24, 2014 at 6:46 AM, Magnus Hagander mag...@hagander.net wrote: On Thu, Jan 23, 2014 at 2:01 AM, Greg Stark st...@mit.edu wrote: On Wed, Jan 22, 2014 at 1:03 PM, Josh Berkus j...@agliodbs.com wrote

Re: [HACKERS] extension_control_path

2014-01-25 Thread Magnus Hagander
On Sat, Jan 25, 2014 at 6:07 PM, Dimitri Fontaine dimi...@2ndquadrant.frwrote: Magnus Hagander mag...@hagander.net writes: Using colon as the path separator is going to break on windows. The patch notices this and uses semicolon on Windows instead. Do we really want to go down that path

Re: [HACKERS] proposal: hide application_name from other users

2014-01-24 Thread Magnus Hagander
these permissions more fine grained, but I just blanket hiding application name for non-superusers seems like a bad solution that still only fixes a small part of the problem. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Why do we let autovacuum give up?

2014-01-23 Thread Magnus Hagander
and clean it up... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] proposal: hide application_name from other users

2014-01-21 Thread Magnus Hagander
everything) Isn't CAP_BACKUP pretty much the REPLICATION privilege? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] proposal: hide application_name from other users

2014-01-21 Thread Magnus Hagander
On Tue, Jan 21, 2014 at 5:18 PM, Stephen Frost sfr...@snowman.net wrote: * Magnus Hagander (mag...@hagander.net) wrote: Isn't CAP_BACKUP pretty much the REPLICATION privilege? Not unless we change it to allow read-access to all tables to allow for pg_dump to work... That sounds more like

Re: [HACKERS] Feature request: Logging SSL connections

2014-01-19 Thread Magnus Hagander
On Fri, Jan 17, 2014 at 4:53 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Applied, thanks! Minor bikeshedding: the messages would read better, to my eye, as user=%s database=%s SSL enabled (protocol=%s, cipher=%s) Putting enabled where it is requires

Re: [HACKERS] Deprecations in authentication

2014-01-19 Thread Magnus Hagander
On Sat, Jan 18, 2014 at 3:59 PM, Andrew Dunstan and...@dunslane.net wrote: On 01/16/2014 08:01 AM, Magnus Hagander wrote: On Wed, Jan 15, 2014 at 6:57 PM, Tom Lane t...@sss.pgh.pa.us mailto: t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net mailto:mag...@hagander.net

Re: [HACKERS] [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio

2014-01-17 Thread Magnus Hagander
. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Feature request: Logging SSL connections

2014-01-17 Thread Magnus Hagander
to catch the closing braces. Thank you. Looks good now. I added it to next commitfest: https://commitfest.postgresql.org/action/patch_view?id=1324 Applied, thanks! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] wal_buffers = -1

2014-01-17 Thread Magnus Hagander
it, then does that just mean that we need to fix it so we can? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] wal_buffers = -1

2014-01-17 Thread Magnus Hagander
On Fri, Jan 17, 2014 at 2:07 PM, Thom Brown t...@linux.com wrote: On 17 January 2014 13:01, Magnus Hagander mag...@hagander.net wrote: Is there any real use-case for not setting wal_buffers to -1 these days? Or should we just remove it and use the -1 behaviour at all times? IIRC we

Re: [HACKERS] currawong is not a happy animal

2014-01-17 Thread Magnus Hagander
could've sworn I committed it that way, but I see now that it's sitting unstaged in my working directory... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Deprecations in authentication

2014-01-16 Thread Magnus Hagander
On Wed, Jan 15, 2014 at 6:57 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: One thing I noticed - in MSVC, the config parameter krb5 (equivalent of the removed --with-krb5) enabled *both* krb5 and gssapi, and there is no separate config parameter

Re: [HACKERS] WAL Rate Limiting

2014-01-15 Thread Magnus Hagander
like a really bad name if we are only slowing down some commands - that seems to indicate we're slowing down all of them. I think it should be something that indicates that it only affects the maintenance commands. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill

<    4   5   6   7   8   9   10   11   12   13   >