Robert Haas writes:
> So I really would like to get a pgindent run done. Any objections to
> doing it sometime RSN? It is of course possible that it might make
> something that we want to revert later harder to revert, but I think
> we should just accept that risk and move forward.
Now that we
On Tue, May 3, 2016 at 11:31 AM, Robert Haas wrote:
> On Tue, May 3, 2016 at 11:23 AM, Tom Lane wrote:
>> Robert Haas writes:
>>> OK, I committed this. Barring objections, I'll go ahead and pgindent
>>> the whole tree tomorrow. If we're going to revert anything big then
>>> we might want to ho
Robert Haas writes:
> On Tue, May 3, 2016 at 11:23 AM, Tom Lane wrote:
>> Well, there are at least two patchsets we're actively discussing
>> reverting, so I think this should wait till those decisions are resolved.
> OK, but that may well mean we don't get this done before beta1, which
> I thin
On Tue, May 3, 2016 at 11:23 AM, Tom Lane wrote:
> Robert Haas writes:
>> OK, I committed this. Barring objections, I'll go ahead and pgindent
>> the whole tree tomorrow. If we're going to revert anything big then
>> we might want to hold off, but otherwise I think its better to get
>> this don
Robert Haas writes:
> OK, I committed this. Barring objections, I'll go ahead and pgindent
> the whole tree tomorrow. If we're going to revert anything big then
> we might want to hold off, but otherwise I think its better to get
> this done sooner rather than later.
Well, there are at least tw
On Tue, May 3, 2016 at 9:40 AM, Tom Lane wrote:
> Robert Haas writes:
>> 1. Is pgindent supposed to touch DATA() lines? Because it does.
>
> It always has.
>
>> 2. CustomPathMethods is not in the buildfarm's typedefs.list. Why not?
>
> Probably because there are no variables, parameters, or fie
Robert Haas writes:
> 1. Is pgindent supposed to touch DATA() lines? Because it does.
It always has.
> 2. CustomPathMethods is not in the buildfarm's typedefs.list. Why not?
Probably because there are no variables, parameters, or fields declared
with that typedef, so it doesn't get into the d
On 05/02/2016 10:56 PM, Robert Haas wrote:
I spent some time going through the output of a trial pgindent run
today. Some questions/problems:
1. Is pgindent supposed to touch DATA() lines? Because it does.
Apart from being detabbed/entabbed, no. pgindent protects (or tries to
protect) DA
I spent some time going through the output of a trial pgindent run
today. Some questions/problems:
1. Is pgindent supposed to touch DATA() lines? Because it does.
2. CustomPathMethods is not in the buildfarm's typedefs.list. Why not?
I'm attaching a patch that fixes up a few other problems th
