Re: [HACKERS] Write Ahead Logging for Hash Indexes

2017-03-13 Thread Amit Kapila
On Sun, Mar 12, 2017 at 8:06 AM, Robert Haas wrote: > On Sat, Mar 11, 2017 at 12:20 AM, Amit Kapila wrote: >>> /* >>> + * Change the shared buffer state in critical section, >>> + * otherwise any

Re: [HACKERS] SQL/JSON in PostgreSQL

2017-03-13 Thread Oleg Bartunov
On Mon, Mar 13, 2017 at 9:24 AM, Nico Williams wrote: > On Thu, Mar 09, 2017 at 07:12:07PM +0100, Sven R. Kunze wrote: > > From my day-to-day work I can tell, the date(time) type is the only > missing > > piece of JSON to make it perfect for business applications (besides,

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-03-13 Thread Artur Zakirov
On 13.03.2017 13:01, Anastasia Lubennikova wrote: Thanks for catching that. It was caused by a conflict on applying of the patch. Updated versions of both patches are attached. I think the code is good and the patches are small. Documentation is updated by the patches. All regression

Re: [HACKERS] Enabling parallelism for queries coming from SQL or other PL functions

2017-03-13 Thread Rafia Sabih
On Wed, Mar 8, 2017 at 1:54 AM, Robert Haas wrote: > There are two places where we currently set CURSOR_OPT_PARALLEL_OK in > PL/pgsql: exec_stmt_return_query() sets it when calling > exec_dynquery_with_params(), and exec_run_select() calls it when > calling

Re: [HACKERS] Write Ahead Logging for Hash Indexes

2017-03-13 Thread Amit Kapila
On Thu, Mar 9, 2017 at 3:11 AM, Robert Haas wrote: > On Tue, Mar 7, 2017 at 6:41 PM, Robert Haas wrote: Great, thanks. 0001 looks good to me now, so committed. >>> >>> Committed 0002. >> >> Here are some initial review thoughts on 0003 based on

Re: [HACKERS] New CORRESPONDING clause design

2017-03-13 Thread Surafel Temesgen
On Sat, Mar 11, 2017 at 9:01 AM, Pavel Stehule wrote: > I am sending minor update - cleaning formatting and white spaces, error > messages + few more tests > Thank you very much for your help > Maybe correspondingClause needs own node type with attached location.

Re: [HACKERS] Typo in snapbuild.c

2017-03-13 Thread Magnus Hagander
On Mon, Mar 13, 2017 at 8:33 AM, Masahiko Sawada wrote: > Hi, > > Attached fixes comment typos in snapbuild.c file. > Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Parallel Append implementation

2017-03-13 Thread Robert Haas
On Mon, Mar 13, 2017 at 4:59 AM, Amit Khandekar wrote: > I agree that we should preferably have the non-partial plans started > first. But I am not sure if it is really worth ordering the partial > plans by cost. The reason we ended up not keeping track of the >

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-03-13 Thread Mithun Cy
Hi all, thanks for the feedback. Based on your recent comments I have implemented a new patch which is attached below, On Sun, Feb 26, 2017 at 10:16 PM, Robert Haas wrote: > This is not easy to fix. The lock has to be taken based on the > relation OID, not the

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-03-13 Thread Mithun Cy
>> - The error handling loop around load_block() suggests that you're >> expecting some reads to fail, which I guess is because you could be >> trying to read blocks from a relation that's been rewritten under a >> different relfilenode, or partially or entirely truncated. But I >> don't think

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Tom Lane
Robert Haas writes: > So now on every startup I get this: > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1" > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv4 address > "127.0.0.1" > 2017-03-13 10:08:49.400 EDT [90059] LOG: listening

Re: [HACKERS] [PATCH] ALTER DEFAULT PRIVILEGES with GRANT/REVOKE ON SCHEMAS

2017-03-13 Thread David Steele
Hi Matheus, On 3/2/17 8:27 AM, David Steele wrote: > On 1/18/17 7:18 PM, Petr Jelinek wrote: >> >> The patch looks good, the only thing I am missing is tab completion >> support for psql. > > It looks like this patch is still waiting on an update for tab > completion in psql. > > Do you know

Re: [HACKERS] [PATCH] Suppress Clang 3.9 warnings

2017-03-13 Thread Aleksander Alekseev
Hi David, Thank you for reminding about this patch! Here is a new patch. I tried to make as little changes as possible. This is no doubt not the most beautiful patch on Earth but it removes all warnings. I anyone could suggest an approach that would be significantly better please don't hesitate

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Robert Haas
On Fri, Mar 10, 2017 at 4:32 PM, Tom Lane wrote: > Improve postmaster's logging of listen socket creation. > > When one of the kernel calls in the socket()/bind()/listen() sequence > fails, include the specific address we're trying to bind to in the log > message. This

Re: [HACKERS] [PATCH] Suppress Clang 3.9 warnings

2017-03-13 Thread David Steele
Hi Aleksander, On 2/22/17 9:43 AM, Fabien COELHO wrote: > > Hello Aleksander, > >> ``` >> xloginsert.c:742:18: warning: implicit conversion from 'int' to 'char' >> changes value from 253 to -3 [-Wconstant-conversion] >> ``` > > There is a bunch of these in "xlog.c" as well, and the same code

Re: [HACKERS] IF (NOT) EXISTS in psql-completion

2017-03-13 Thread David Steele
Hello, On 3/1/17 9:38 PM, Kyotaro HORIGUCHI wrote: > At Tue, 28 Feb 2017 10:39:01 -0500, Stephen Frost wrote > in <20170228153901.gh9...@tamriel.snowman.net> >> * David Fetter (da...@fetter.org) wrote: >>> On Mon, Feb 27, 2017 at 11:53:17PM -0500, Stephen Frost wrote:

Re: [HACKERS] \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless)

2017-03-13 Thread Tom Lane
I wrote: > IIRC, I objected to putting knowledge of ConditionalStack > into the shared psqlscan.l lexer, and I still think that would be a bad > idea; but we need some way to get the lexer to shut that off. Probably > the best way is to add a passthrough "void *" argument that would let the >

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Tom Lane
Alvaro Herrera writes: > I think it's good to have it, but I would argue that it should be a > single line that lists all the addresses instead. I don't think that's a terribly good idea, for the reasons I mentioned in

Re: [HACKERS] New CORRESPONDING clause design

2017-03-13 Thread Pavel Stehule
2017-03-13 14:13 GMT+01:00 Surafel Temesgen : > > > On Sat, Mar 11, 2017 at 9:01 AM, Pavel Stehule > wrote: > > >> I am sending minor update - cleaning formatting and white spaces, error >> messages + few more tests >> > > Thank you very much for

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-13 Thread Ashutosh Sharma
Couple of review comments,, You may also need to update the documentation as now we are also going to support wal consistency check for hash index. The current documentation does not include hash index. +only records originating from those resource managers. Currently, +the

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Stephen Frost
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Tom Lane wrote: > > Robert Haas writes: > > > So now on every startup I get this: > > > > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1" > > > 2017-03-13 10:08:49.399 EDT [90059] LOG:

Re: [HACKERS] \h tab-completion

2017-03-13 Thread David Steele
Hi Andreas, On 3/1/17 8:47 AM, Peter Eisentraut wrote: > On 2/3/17 07:12, Andreas Karlsson wrote: >> On 01/25/2017 07:13 AM, Michael Paquier wrote: >>> What I think you should do is making the code path of >>> \\h smarter with some exceptions by using TailMatchesCS2() for ALTER. >>> There is as

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Alvaro Herrera
Tom Lane wrote: > Robert Haas writes: > > So now on every startup I get this: > > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1" > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv4 address > > "127.0.0.1" > > 2017-03-13

Re: [HACKERS] Parallel seq. plan is not coming against inheritance or partition table

2017-03-13 Thread Amit Kapila
On Wed, Mar 8, 2017 at 6:58 PM, Robert Haas wrote: > On Wed, Mar 8, 2017 at 7:04 AM, Amit Kapila wrote: >> On Wed, Mar 8, 2017 at 8:28 AM, Robert Haas wrote: >>> On Tue, Mar 7, 2017 at 9:24 PM, Amit Kapila

Re: [HACKERS] Parallel Append implementation

2017-03-13 Thread Robert Haas
On Mon, Mar 13, 2017 at 7:46 AM, Robert Haas wrote: > On Mon, Mar 13, 2017 at 4:59 AM, Amit Khandekar > wrote: >> I agree that we should preferably have the non-partial plans started >> first. But I am not sure if it is really worth ordering the

[HACKERS] Re: [GSOC 17] Eliminate O(N^2) scaling from rw-conflict tracking in serializable transactions

2017-03-13 Thread Kevin Grittner
On Sat, Mar 11, 2017 at 8:39 PM, Mengxing Liu wrote: >> The worst problems have been >> seen with 32 or more cores on 4 or more sockets with a large number >> of active connections. I don't know whether you have access to a >> machine capable of putting this kind

Re: [HACKERS] tuplesort_gettuple_common() and *should_free argument

2017-03-13 Thread David Steele
Hi Peter, On 3/2/17 9:43 AM, David Steele wrote: > Peter, > > On 2/1/17 12:59 AM, Michael Paquier wrote: >> On Thu, Jan 26, 2017 at 8:16 AM, Tom Lane wrote: >>> [ in the service of closing out this thread... ] >>> >>> Peter Geoghegan writes: Finally,

Re: [HACKERS] PATCH: Configurable file mode mask

2017-03-13 Thread David Steele
On 3/10/17 8:12 AM, Stephen Frost wrote: > Peter, > > * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: >> On 2/28/17 20:58, David Steele wrote: >>> This patch introduces a new initdb param, -u/-file-mode-mask, and a new >>> GUC, file_mode_mask, to allow the default mode of files and

Re: [HACKERS] \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless)

2017-03-13 Thread Corey Huinker
> > > Barring objection I'll push this so that Corey can rebase over it. > > regards, tom lane > Seems straightforward, and I appreciate you doing it for me!

Re: [HACKERS] PATCH: Configurable file mode mask

2017-03-13 Thread David Steele
On 3/10/17 8:34 AM, Stephen Frost wrote: > Greetings, > > * Tsunakawa, Takayuki (tsunakawa.ta...@jp.fujitsu.com) wrote: >> From: pgsql-hackers-ow...@postgresql.org >>> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of David Steele >>> PostgreSQL currently requires the file mode mask

Re: [HACKERS] scram and \password

2017-03-13 Thread Jeff Janes
On Fri, Mar 10, 2017 at 2:43 PM, Michael Paquier wrote: > On Sat, Mar 11, 2017 at 2:53 AM, Jeff Janes wrote: > > Should the \password tool in psql inspect password_encryption and act on > it > > being 'scram'? > > Not sure if it is wise to change

Re: [HACKERS] PATCH: Configurable file mode mask

2017-03-13 Thread Tom Lane
David Steele writes: > At miscinit.c:893: > /* We can treat the EPERM-error case as okay because that error implies > that the existing process has a different userid than we do, which means > it cannot be a competing postmaster. A postmaster cannot successfully > attach to

Re: [HACKERS] PATCH: Batch/pipelining support for libpq

2017-03-13 Thread Daniel Verite
Vaishnavi Prabakaran wrote: > > while (QbatchQueueProcess(conn)) { > >r = PQsetSingleRowMode(conn); > >if (r!=1) { > > fprintf(stderr, "PQsetSingleRowMode() failed"); > >} > >.. > Thanks for investigating the problem, and could you kindly

Re: [HACKERS] WIP: Faster Expression Processing v4

2017-03-13 Thread Konstantin Knizhnik
On 13.03.2017 11:03, Andres Freund wrote: Hi, On 2017-03-12 05:40:51 +0100, Tomas Vondra wrote: I wanted to do a bit of testing and benchmarking on this, but 0004 seems to be a bit broken. Well, "broken" in the sense that it's already outdated, because other stuff that got merged. The

Re: [HACKERS] PATCH: Configurable file mode mask

2017-03-13 Thread Tom Lane
... oh, and now that I've actually looked at the patch, I think it's a seriously bad idea to proceed by removing the mode parameter to PathNameOpenFile et al. That's basically doubling down on an assumption that there are NO places in the backend, and never will be any, in which we want to create

Re: [HACKERS] Gather Merge

2017-03-13 Thread Robert Haas
On Fri, Mar 10, 2017 at 7:59 AM, Rushabh Lathia wrote: > Error coming from create_gather_merge_plan() from below condition: > > if (memcmp(sortColIdx, gm_plan->sortColIdx, >numsortkeys * sizeof(AttrNumber)) != 0) > elog(ERROR, "GatherMerge

Re: [HACKERS] increasing the default WAL segment size

2017-03-13 Thread Beena Emerson
Hello, Thank you testing. I just wanted to confirm few things since I do not have linux32 setup yet. On Fri, Mar 10, 2017 at 1:09 PM, tushar wrote: > On 03/10/2017 11:23 AM, Beena Emerson wrote: > > >> Thank you for your reviews Kuntal, Jim, Ashutosh > > Attached

Re: [HACKERS] SQL/JSON in PostgreSQL

2017-03-13 Thread Nico Williams
On Thu, Mar 09, 2017 at 12:58:55PM -0500, Robert Haas wrote: > On Thu, Mar 9, 2017 at 12:48 PM, Sven R. Kunze wrote: > > On 08.03.2017 20:48, Peter van Hardenberg wrote: > >> > >> Small point of order: YAML is not strictly a super-set of JSON. > > > > I haven't read the whole

Re: [HACKERS] PassDownLimitBound for ForeignScan/CustomScan [take-2]

2017-03-13 Thread Jeevan Chalke
Hi, I have reviewed this patch further and here are my comments: 1. Will it be better to use compare_pathkeys() instead of equal(root->query_pathkeys, pathkeys)? 2. I think it will be good if we add a simple test-case in postgres_fdw.sql which shows that LIMIT is passed to remote server. We

[HACKERS] Typo in snapbuild.c

2017-03-13 Thread Masahiko Sawada
Hi, Attached fixes comment typos in snapbuild.c file. Regards, -- Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_small_typo_in_snapbuild.patch Description: Binary data -- Sent via pgsql-hackers mailing list

Re: [HACKERS] WIP: [[Parallel] Shared] Hash

2017-03-13 Thread Rafia Sabih
On Thu, Mar 9, 2017 at 5:28 PM, Thomas Munro wrote: > On Wed, Mar 8, 2017 at 12:58 PM, Andres Freund wrote: > > 0002: Check hash join work_mem usage at the point of chunk allocation. > > > > Modify the existing hash join code to detect work_mem

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-03-13 Thread Artur Zakirov
On 15.02.2017 20:54, Anastasia Lubennikova wrote: Done. I have gotten the error that AlterUserMappingStmt doesn't have if_not_exists (in Russian): gram.y: В функции «base_yyparse»: gram.y:4918:7: ошибка: «AlterUserMappingStmt {aka struct AlterUserMappingStmt}» не содержит элемента с

Re: [HACKERS] increasing the default WAL segment size

2017-03-13 Thread Prabhat Sahu
Hi, 2)Getting "Aborted (core dumped)" error at the time of running pg_basebackup , *(this issue is only coming on Linux32 ,not on Linux64)* we have double check to confirm it . Steps to reproduce on Linux32 > === >> fetch the sources >> apply both the patches >> ./configure

Re: [HACKERS] increasing the default WAL segment size

2017-03-13 Thread Beena Emerson
Hello, On Mon, Mar 13, 2017 at 1:49 PM, Prabhat Sahu wrote: > Hi, > > 2)Getting "Aborted (core dumped)" error at the time of running > pg_basebackup , *(this issue is only coming on Linux32 ,not on Linux64)* > we have double check to confirm it . > > Steps to

Re: [HACKERS] Changing references of password encryption to hashing

2017-03-13 Thread Craig Ringer
On 12 March 2017 at 06:51, Joe Conway wrote: > My opinion is that the user visible aspects of this should be deprecated > and correct syntax provided. But perhaps that is overkill. FWIW, in my experience, pretty much nobody understands the pretty tangled behaviour of "WITH

Re: [HACKERS] BRIN cost estimate

2017-03-13 Thread Emre Hasegeli
> Will Emre be around to make the required changes to the patch? I see > it's been a while since it was originally posted. I am around. I can post an update in a few days. Thank you for picking this up. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Parallel Append implementation

2017-03-13 Thread Amit Khandekar
On 10 March 2017 at 22:08, Robert Haas wrote: > On Fri, Mar 10, 2017 at 12:17 AM, Amit Khandekar > wrote: >> I agree that the two-lists approach will consume less memory than >> bitmapset. Keeping two lists will effectively have an extra pointer >>

Re: [HACKERS] multivariate statistics (v25)

2017-03-13 Thread David Rowley
On 3 March 2017 at 03:53, Tomas Vondra wrote: > This time with the attachments It's been a long while since I looked at this patch, but I'm now taking another look. I've made a list of stuff I've found from making my first pass on 0001 and 0002. Some of the

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-03-13 Thread Anastasia Lubennikova
13.03.2017 11:53, Artur Zakirov: On 15.02.2017 20:54, Anastasia Lubennikova wrote: Done. I have gotten the error that AlterUserMappingStmt doesn't have if_not_exists (in Russian): gram.y: В функции «base_yyparse»: gram.y:4918:7: ошибка: «AlterUserMappingStmt {aka struct

Re: [HACKERS] SQL/JSON in PostgreSQL

2017-03-13 Thread Nico Williams
On Thu, Mar 09, 2017 at 07:12:07PM +0100, Sven R. Kunze wrote: > From my day-to-day work I can tell, the date(time) type is the only missing > piece of JSON to make it perfect for business applications (besides, maybe, > a "currency" type). And a binary type. And a chunked-string type (to avoid

Re: [HACKERS] SQL/JSON in PostgreSQL

2017-03-13 Thread Pavel Stehule
2017-03-13 7:24 GMT+01:00 Nico Williams : > On Thu, Mar 09, 2017 at 07:12:07PM +0100, Sven R. Kunze wrote: > > From my day-to-day work I can tell, the date(time) type is the only > missing > > piece of JSON to make it perfect for business applications (besides, > maybe, > >

Re: [HACKERS] Changing references of password encryption to hashing

2017-03-13 Thread Michael Paquier
On Sun, Mar 12, 2017 at 7:51 AM, Joe Conway wrote: > On 03/09/2017 06:16 PM, Michael Paquier wrote: >> As discussed here: >> https://www.postgresql.org/message-id/98cafcd0-5557-0bdf-4837-0f2b7782d...@joeconway.com >> We are using in documentation and code comments "encryption"

Re: [HACKERS] SQL/JSON in PostgreSQL

2017-03-13 Thread Nico Williams
On Tue, Mar 07, 2017 at 10:43:16PM +0100, Sven R. Kunze wrote: > about the datetime issue: as far as I know, JSON does not define a > serialization format for dates and timestamps. Use strings in ISO 8601 format, with or without fractional seconds, and maybe with 5-digit years. > On the other

Re: [HACKERS] possible encoding issues with libxml2 functions

2017-03-13 Thread Pavel Stehule
2017-03-12 22:26 GMT+01:00 Pavel Stehule : > > > 2017-03-12 21:57 GMT+01:00 Noah Misch : > >> On Sun, Mar 12, 2017 at 08:36:58PM +0100, Pavel Stehule wrote: >> > 2017-03-12 0:56 GMT+01:00 Noah Misch : >> > > On Mon, Feb 20, 2017 at

Re: [HACKERS] Speedup twophase transactions

2017-03-13 Thread Michael Paquier
On Sat, Mar 11, 2017 at 7:26 PM, Nikhil Sontakke wrote: > Hi David and Michael, >> It would be great to get this thread closed out after 14 months and many >> commits. > > PFA, latest patch which addresses Michael's comments. Thanks for the new version. Let's head toward

Re: [HACKERS] Relation cache invalidation on replica

2017-03-13 Thread Victor Yegorov
2016-02-28 11:53 GMT+02:00 Simon Riggs : > We have various proposals for fixing this, so on consideration here's what > I think we should do... > > 1. Ignore my first patch to always set an xid. Andres thought that this > may break something else could be true, so is not

Re: [HACKERS] Relation cache invalidation on replica

2017-03-13 Thread Andres Freund
On March 12, 2017 11:22:22 PM PDT, Victor Yegorov wrote: >2016-02-28 11:53 GMT+02:00 Simon Riggs : > >> We have various proposals for fixing this, so on consideration here's >what >> I think we should do... >> >> 1. Ignore my first patch to always set

Re: [HACKERS] Parallel Append implementation

2017-03-13 Thread Amit Khandekar
On 12 March 2017 at 19:31, Tels wrote: > Moin, > > On Sat, March 11, 2017 11:29 pm, Robert Haas wrote: >> On Fri, Mar 10, 2017 at 6:01 AM, Tels >> wrote: >>> Just a question for me to understand the implementation details vs. the >>>

Re: [HACKERS] make check-world output

2017-03-13 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > For the basic build process, we've largely solved that through the > use of "make -s". But we don't really have a comparable "be quiet" > option for test runs, especially not the TAP tests. Maybe we need > to think a bit more globally about what it is

Re: [HACKERS] Partitioned tables and relfilenode

2017-03-13 Thread Amit Langote
On 2017/03/10 17:57, Amit Langote wrote: > On 2017/03/08 22:36, Robert Haas wrote: >> On Wed, Mar 8, 2017 at 5:36 AM, Amit Langote wrote: -rel = mtstate->resultRelInfo->ri_RelationDesc; +nominalRTE = rt_fetch(node->nominalRelation, estate->es_range_table); +nominalRel =

Re: [HACKERS] Partitioned tables and relfilenode

2017-03-13 Thread Amit Langote
On 2017/03/13 19:24, Amit Langote wrote: > On 2017/03/10 17:57, Amit Langote wrote: >> On 2017/03/08 22:36, Robert Haas wrote: >>> On Wed, Mar 8, 2017 at 5:36 AM, Amit Langote wrote: > -rel = mtstate->resultRelInfo->ri_RelationDesc; > +nominalRTE = rt_fetch(node->nominalRelation,

Re: [HACKERS] bytea_output vs make installcheck

2017-03-13 Thread Tom Lane
Robert Haas writes: > On Thu, Mar 9, 2017 at 6:45 PM, Neha Khatri wrote: >> With this, if an installcheck is done, that might also have been done with >> the expectation that the output will be in 'escape' format. In that case, >> how much is it

Re: [HACKERS] Performance improvement for joins where outer side is unique

2017-03-13 Thread David Rowley
On 14 March 2017 at 07:50, Tom Lane wrote: > [ getting back to this patch finally... ] > > David Rowley writes: > > I've attached a patch which implements this, though only for > > MergeJoin, else I'd imagine we'd also need to ensure all proofs

Re: [HACKERS] Need a builtin way to run all tests faster manner

2017-03-13 Thread Andrew Dunstan
On 03/13/2017 07:21 PM, Andrew Dunstan wrote: > > On 03/13/2017 12:35 AM, Tom Lane wrote: >> Andres Freund writes: >>> On 2017-03-11 22:14:07 -0500, Tom Lane wrote: This looks generally sane to me, although I'm not very happy about folding the "$(MKDIR_P)

Re: [HACKERS] tuplesort_gettuple_common() and *should_free argument

2017-03-13 Thread Peter Geoghegan
On Mon, Mar 13, 2017 at 8:23 AM, David Steele wrote: > It's been a while since there was a new patch or any activity on this > thread. > > If you need more time to produce a patch, please post an explanation for > the delay and a schedule for the new patch. If no patch or

Re: [HACKERS] Need a builtin way to run all tests faster manner

2017-03-13 Thread Andrew Dunstan
On 03/13/2017 12:35 AM, Tom Lane wrote: > Andres Freund writes: >> On 2017-03-11 22:14:07 -0500, Tom Lane wrote: >>> This looks generally sane to me, although I'm not very happy about folding >>> the "$(MKDIR_P) output_iso" call into pg_isolation_regress_check --- that >>>

Re: [HACKERS] Measuring replay lag

2017-03-13 Thread Thomas Munro
Hi, Please see separate replies to Simon and Craig below. On Sun, Mar 5, 2017 at 8:38 PM, Simon Riggs wrote: > On 1 March 2017 at 10:47, Thomas Munro wrote: >> I do see why a new user trying this feature for the first time might >> expect

Re: [HACKERS] Radix tree for character conversion

2017-03-13 Thread Michael Paquier
On Tue, Mar 14, 2017 at 4:07 AM, Heikki Linnakangas wrote: > On 03/13/2017 08:53 PM, Tom Lane wrote: >> Heikki Linnakangas writes: >>> >>> It would be nice to run the map_checker tool one more time, though, to >>> verify that the mappings match those from

Re: [HACKERS] PATCH: Configurable file mode mask

2017-03-13 Thread David Steele
Hi Tom, On 3/13/17 1:13 PM, Tom Lane wrote: > ... oh, and now that I've actually looked at the patch, I think it's > a seriously bad idea to proceed by removing the mode parameter to > PathNameOpenFile et al. That's basically doubling down on an assumption > that there are NO places in the

[HACKERS] Bogus tab completion tweak for UPDATE ... SET ... =

2017-03-13 Thread Thomas Munro
Hi, Even though the following is coincidentally meaningful, I don't think it was intentional or is useful: postgres=# update foo set x = DEFAULT Shouldn't that completion should be suppressed, like in the attached? -- Thomas Munro http://www.enterprisedb.com fix-update-set-completion.patch

Re: [HACKERS] Bogus tab completion tweak for UPDATE ... SET ... =

2017-03-13 Thread Tom Lane
Thomas Munro writes: > Even though the following is coincidentally meaningful, I don't think > it was intentional or is useful: > postgres=# update foo set x = DEFAULT Uh, seems perfectly sane to me. Why should we assume that can't be what the user wants?

Re: [HACKERS] Radix tree for character conversion

2017-03-13 Thread Heikki Linnakangas
On 03/06/2017 10:16 AM, Kyotaro HORIGUCHI wrote: At Fri, 3 Mar 2017 12:53:04 +0900, Michael Paquier wrote in On Thu, Mar 2, 2017 at 2:20 PM, Kyotaro HORIGUCHI

Re: [HACKERS] PATCH: Configurable file mode mask

2017-03-13 Thread David Steele
On 3/13/17 2:16 PM, Tom Lane wrote: > David Steele writes: >> On 3/13/17 1:03 PM, Tom Lane wrote: >>> TBH, the fact that we're relying on 0600 mode for considerations such >>> as these makes me tremendously afraid of this whole patch. I think that >>> the claimed advantages

Re: [HACKERS] PATCH: Configurable file mode mask

2017-03-13 Thread David Steele
Hi Tom, On 3/13/17 1:03 PM, Tom Lane wrote: > David Steele writes: >> At miscinit.c:893: > >> /* We can treat the EPERM-error case as okay because that error implies >> that the existing process has a different userid than we do, which means >> it cannot be a competing

Re: [HACKERS] PATCH: Configurable file mode mask

2017-03-13 Thread Tom Lane
David Steele writes: > On 3/13/17 1:03 PM, Tom Lane wrote: >> TBH, the fact that we're relying on 0600 mode for considerations such >> as these makes me tremendously afraid of this whole patch. I think that >> the claimed advantages are not anywhere near worth the risk that

Re: [HACKERS] PATCH: pageinspect / add page_checksum and bt_page_items(bytea)

2017-03-13 Thread Tomas Vondra
On 03/13/2017 06:49 AM, Ashutosh Sharma wrote: Hi, I had a look into this patch and would like to share some of my review comments that requires author's attention. 1) The comment for page_checksum() needs to be corrected. It seems like it has been copied from page_header and not edited it

Re: [HACKERS] WIP: Faster Expression Processing v4

2017-03-13 Thread Andres Freund
Hi, On 2017-03-13 01:03:51 -0700, Andres Freund wrote: > What's basically missing here is: > - pgindent run and minimizing resulting damage Running into a bit of an issue here - pgindent mangles something like EEO_SWITCH (op->opcode) { EEO_CASE(EEO_DONE): goto out;

Re: [HACKERS] asynchronous execution

2017-03-13 Thread Amit Langote
On 2017/03/14 10:08, Corey Huinker wrote: >> I don't think the plan itself will change as a result of applying this >> patch. You might however be able to observe some performance improvement. > > I could see no performance improvement, even with 16 separate queries > combined with UNION ALL.

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2017-03-13 Thread Alvaro Herrera
> @@ -234,6 +236,21 @@ index_beginscan(Relation heapRelation, > scan->heapRelation = heapRelation; > scan->xs_snapshot = snapshot; > > + /* > + * If the index supports recheck, make sure that index tuple is saved > + * during index scans. > + * > + * XXX

Re: [HACKERS] asynchronous execution

2017-03-13 Thread Amit Langote
On 2017/03/14 6:31, Corey Huinker wrote: > On Mon, Mar 13, 2017 at 1:06 AM, Corey Huinker > wrote: > >> >>> I think it will, because Append itself has been made async-capable by one >>> of the patches and UNION ALL uses Append. But as mentioned above, only >>> the

Re: [HACKERS] scram and \password

2017-03-13 Thread Michael Paquier
On Tue, Mar 14, 2017 at 9:54 AM, Joe Conway wrote: > On 03/12/2017 08:10 PM, Michael Paquier wrote: >> OK, so what about doing the following then: >> 1) Create pg_role_password_type(oid), taking a role OID in input and >> returning the type. > > That version would make sense

Re: [HACKERS] tuplesort_gettuple_common() and *should_free argument

2017-03-13 Thread Peter Geoghegan
On Wed, Jan 25, 2017 at 3:11 PM, Peter Geoghegan wrote: > On Wed, Jan 25, 2017 at 3:11 PM, Tom Lane wrote: >> Please. You might want to hit the existing ones with a separate patch, >> but it doesn't much matter; I'd be just as happy with a patch that did >>

[HACKERS] Updating the "tool sets" documentation for modern FreeBSD

2017-03-13 Thread Thomas Munro
Hi, For several operating systems we give handy package manager one-liners to install all the requirements for building our documentation. All current production FreeBSD releases have a friendly new package manager a bit like apt/yum, so here's a documentation patch to give the one line command.

Re: [HACKERS] [PATCH] Transaction traceability - txid_status(bigint)

2017-03-13 Thread Craig Ringer
On 14 March 2017 at 05:43, Robert Haas wrote: > For example, suppose vacuum #1 comes along, advances the limits, > truncates clog, and then gets descheduled. Now vacuum #2 comes along, > advances the limits further, and then gets descheduled. Now vacuum #1 > wakes up and

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-03-13 Thread Robert Haas
On Mon, Mar 13, 2017 at 3:24 PM, Robert Haas wrote: > Haven't looked at 0007 yet. + if (rel->part_scheme) + { + int cnt_parts; + + for (cnt_parts = 0; cnt_parts < nparts; cnt_parts++) +

Re: [HACKERS] tuplesort_gettuple_common() and *should_free argument

2017-03-13 Thread Peter Geoghegan
On Wed, Jan 25, 2017 at 3:16 PM, Tom Lane wrote: > Um, I didn't find it all that self-explanatory. Why wouldn't we want > to avoid writing undefined data? For roughly the same reason we'd want to avoid it in existing cases that are next to the proposed new suppression. We

Re: [HACKERS] asynchronous execution

2017-03-13 Thread Corey Huinker
> > I don't think the plan itself will change as a result of applying this > patch. You might however be able to observe some performance improvement. > > Thanks, > Amit > I could see no performance improvement, even with 16 separate queries combined with UNION ALL. Query performance was always

Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support

2017-03-13 Thread Haribabu Kommi
On Mon, Mar 13, 2017 at 6:38 AM, Stephen Frost wrote: > Greetings, > > * Stephen Frost (sfr...@snowman.net) wrote: > > * Haribabu Kommi (kommi.harib...@gmail.com) wrote: > > > On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy < > vitaly.buro...@gmail.com> wrote: > > > > The new

Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support

2017-03-13 Thread Haribabu Kommi
On Mon, Mar 13, 2017 at 6:52 AM, Stephen Frost wrote: > Greetings, > > * Stephen Frost (sfr...@snowman.net) wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > > > * Haribabu Kommi (kommi.harib...@gmail.com) wrote: > > > > On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy <

Re: [HACKERS] scram and \password

2017-03-13 Thread Tom Lane
Robert Haas writes: > I'm not talking about changing the default, just having it be possible > to use \password with the new system as it was with the old, whatever > exactly we think that means. Seems to me the intended behavior of \password is to use the best available

[HACKERS] Unacccented Fractions

2017-03-13 Thread David E. Wheeler
Hello Hackers, I noticed that unaccent.rules has spaces in front of the unaccented representation of fraction glyphs: ¼1/4 ½1/2 ¾3/4 Note the space after the tab. In case my client kills what I’ve pasted, those lines match ¼\t[ ]1/4 ½\t[ ]1/2 ¾\t[ ]3/4 This makes

Re: [HACKERS] \h tab-completion

2017-03-13 Thread Andreas Karlsson
On 03/13/2017 03:56 PM, David Steele wrote: Do you know when you will have a new patch available for review that incorporates Peter's request? I believe I will find the time to finish it some time in a couple of days. Andreas -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Should buffer of initialization fork have a BM_PERMANENT flag

2017-03-13 Thread Michael Paquier
On Tue, Mar 14, 2017 at 4:46 AM, Robert Haas wrote: > On Wed, Jan 25, 2017 at 7:14 PM, Michael Paquier > wrote: >> (Adding Robert in CC.) >> >> On Thu, Jan 26, 2017 at 4:34 AM, Wang Hao wrote: >>> An unlogged table has an

Re: [HACKERS] scram and \password

2017-03-13 Thread Joe Conway
On 03/12/2017 08:10 PM, Michael Paquier wrote: > OK, so what about doing the following then: > 1) Create pg_role_password_type(oid), taking a role OID in input and > returning the type. That version would make sense for administrative use. I still think we might want a version of this that takes

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-03-13 Thread Amit Langote
On 2017/03/14 9:17, Robert Haas wrote: > On Mon, Mar 13, 2017 at 3:24 PM, Robert Haas wrote: >> Haven't looked at 0007 yet. > > Overall this one looks pretty good and straightforward. In the following code of find_partition_scheme(): + /* Did not find matching

Re: [HACKERS] scram and \password

2017-03-13 Thread Robert Haas
On Sun, Mar 12, 2017 at 11:14 PM, Michael Paquier wrote: > On Mon, Mar 13, 2017 at 9:15 AM, Robert Haas wrote: >> On Fri, Mar 10, 2017 at 5:43 PM, Michael Paquier >> wrote: >>> On Sat, Mar 11, 2017 at 2:53 AM, Jeff

Re: [HACKERS] Performance improvement for joins where outer side is unique

2017-03-13 Thread David Rowley
On 14 March 2017 at 11:35, David Rowley wrote: > On 14 March 2017 at 07:50, Tom Lane wrote: > >> [ getting back to this patch finally... ] >> >> David Rowley writes: >> > I've attached a patch which implements

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Tom Lane
Andres Freund writes: > I don't mind the new output, but I kinda wonder whether it's a good idea > to include the '.s.PGSQL.5432' bit in the host and/or whether we > shouldn't include the port in the TCP cases as well Yeah, I've been thinking that maybe it should look like

Re: [HACKERS] PATCH: pageinspect / add page_checksum and bt_page_items(bytea)

2017-03-13 Thread Ashutosh Sharma
Hi, > >> 2) It seems like you have choosen wrong datatype for page_checksum. I >> am getting negative checksum value when trying to run below query. I >> think the return type for the SQL function page_checksum should be >> 'integer' instead of 'smallint'. >> >> postgres=# SELECT

Re: [HACKERS] scram and \password

2017-03-13 Thread Michael Paquier
On Tue, Mar 14, 2017 at 11:47 AM, Tom Lane wrote: > Robert Haas writes: >> I'm not talking about changing the default, just having it be possible >> to use \password with the new system as it was with the old, whatever >> exactly we think that means. I

  1   2   >