[PATCHES] Packed Varlena Update (v21)

2007-03-26 Thread stark
ngers. varvarlena-21.patch.gz Description: Binary data -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

[PATCHES] Patch for circular buffer in tuplestore to optimize merge joins (v1)

2007-03-27 Thread stark
27;s certainly ready to be reviewed. All that remains is polishing. If there's anything in there people object to now I would like to know. mergejoin-circbuffer-v1.patch.gz Description: Binary data -- Gregory Stark EnterpriseDB http://www.enterprisedb.com -

[PATCHES] Concurrent psql v4 [WIP]

2007-03-27 Thread stark
concurrent-psql-v4.patch.gz Description: Binary data -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail c

[PATCHES] Doc patch for create index

2007-04-03 Thread stark
A doc patch to add an example of what an invalid index looks like in psql, as requested by a commenter and Bruce. Index: doc/src/sgml/ref/create_index.sgml === RCS file: /home/stark/src/REPOSITORY/pgsql/doc/src/sgml/ref

Re: [HACKERS] [PATCHES] Maintaining cluster order on insert

2006-08-10 Thread stark
titioning?) is still worthwhile. If the columns being updated are very small or often not needed at all then it may be reasonably efficient to look them up separately and still let you store the bulk of the data efficiently and access it in a fast sequential scan. -- Gregory Stark Enterprise

[PATCHES] Trivial patch to double vacuum speed on tables with no indexes

2006-08-27 Thread stark
nonremovable tuples */ -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

[PATCHES] Autoconf test for incompatible version of flex

2003-07-04 Thread Greg Stark
This patch adds an autoconf test to check for the new incompatible version of flex. --- programs.m4.~1.12.~ 2003-05-06 19:33:52.0 -0400 +++ programs.m4 2003-07-04 20:45:47.0 -0400 @@ -30,6 +30,10 @@ pgac_broken_flex=$pgac_candidate continue fi

Re: [PATCHES] Autoconf test for incompatible version of flex

2003-07-05 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Greg Stark <[EMAIL PROTECTED]> writes: > > This patch adds an autoconf test to check for the new incompatible version of > > flex. > > It seems unlikely that we should cause configure to reject all future > versions of f

Re: [PATCHES] Autoconf test for incompatible version of flex

2003-07-06 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Greg Stark <[EMAIL PROTECTED]> writes: > > I inquired about this problem elsewhere, it's not a bug, it's an API change. > > Until postgres "ports" to the new API it won't work with newer versions of >

Re: [PATCHES] Concurrent connections in psql patch

2006-09-03 Thread Gregory Stark
leaning up the details. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your

Re: [HACKERS] [PATCHES] Trivial patch to double vacuum speed on tables with no indexes

2006-09-04 Thread Gregory Stark
re it released the share lock and did he LockBufferForCleanup only if necessary. I thought it was awkward to acquire a lock then release it to acquire a different lock on the same buffer but it's true that it doesn't always have to acquire the second lock. -- Gregory Stark EnterpriseD

[PATCHES] Some editing of docs for create index concurrently

2006-09-11 Thread Gregory Stark
or unacceptably ! long periods for a production system. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

[PATCHES] More doc patches

2006-09-19 Thread Gregory Stark
t; DATE '2006-03-01' ); ALTER TABLE measurement_y2006m02 INHERIT MEASUREMENT; + ! The following caveats currently apply to partitioned tables: -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] More doc patches

2006-09-19 Thread Gregory Stark
ith cvs -c. I don't know why I did it differently here, weird. Sorry about that. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriat

Re: [HACKERS] [PATCHES] Eliminating phase 3 requirement for varlen increases via ALTER COLUMN

2006-10-26 Thread Gregory Stark
hanges to be work-free and some not without exposing any implementation details outside the type. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will i

Re: [HACKERS] [PATCHES] WAL logging freezing

2006-10-31 Thread Gregory Stark
n i/o hog even more so. Perhaps something clever can be done with vacuum_cost_delay and commit_siblings. Something like inserting the delay between WAL logging and syncing the log and writing to the heap. So if another transaction commits in the meantime we can skip the extra fsync and continue.

Re: [HACKERS] [PATCHES] Enums patch v2

2006-12-19 Thread Gregory Stark
Well as long as we're talking "should"s the database should take care of this for you anyways. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL

Re: [PATCHES] WIP patch for "operator families"

2006-12-22 Thread Gregory Stark
one > is ... > Comments? Didn't we say discussion should happen on -hackers so development progress would be more visible? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 4: Have y

[PATCHES] Assorted typos

2007-01-04 Thread Gregory Stark
attalign in both places in pg_attribute.h -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [pgsql-patches] [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-11 Thread Gregory Stark
we can save CPU on every WAL write while not harming reliability (in fact increasing it, albeit insignificantly) why not? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

Re: [pgsql-patches] [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-11 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> What did you think about protecting against torn writes using id numbers >> every >> 512 bytes. > > Pretty much not happening; or are you volunteering to fix eve

Re: [pgsql-patches] [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-11 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> "Tom Lane" <[EMAIL PROTECTED]> writes: >>> Pretty much not happening; or are you volunteering to fix every part of >>> the system to tolerate i

Re: [pgsql-patches] [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-11 Thread Gregory Stark
using readv/writev. No copies, no corrupted datums. Essentially the tags would be inserted on the fly as the data was copied into kernel space. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 9: In versions

Re: [pgsql-patches] Recalculating OldestXmin in a long-running vacuum

2007-01-17 Thread Gregory Stark
can process them. Unfortunately indexes, again, mean that's not entirely true. As the table grows the indexes will grow as well and that will slow vacuum down. Though indexes are usually smaller than tables. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---

[PATCHES] WIP: Recursive Queries

2007-02-06 Thread Gregory Stark
select * from a; x --- 1 (1 row) postgres=# with a(x) as (select 1) select * from (select * from a) as x; ERROR: relation "a" does not exist Index: src/backend/nodes/copyfuncs.c === RCS file: /home/stark/src/REPOSITORY

[PATCHES] LIMIT/SORT optimization

2007-02-07 Thread Gregory Stark
it-sort.patch.4 Description: Binary data -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PRO

Re: [PATCHES] LIMIT/SORT optimization

2007-02-07 Thread Gregory Stark
"Simon Riggs" <[EMAIL PROTECTED]> writes: > On Wed, 2007-02-07 at 10:49 +, Gregory Stark wrote: > > The two open issues (which are arguably the same issue) is how to get > > the information down to the sort node and how to cost the plan. > > Currently

[PATCHES] [test]

2007-02-22 Thread Gregory Stark
[testing to see if -patches allows me to post yet. I send a patch last night but haven't seen it come through] -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 1: if posting/reading th

[PATCHES] Short varlena headers

2007-02-22 Thread Gregory Stark
ing not used in the system tables has any business being exempted which only leaves us with the occasional text attribute which I plan to double check aren't problems. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcas

[PATCHES] 1-byte packed varlena headers

2007-02-26 Thread Gregory Stark
rated by heap_form*tuple. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings

[PATCHES] Numeric patch to add special-case representations for < 8 bytes

2007-02-26 Thread Gregory Stark
ytes. But even now note how much space is saved for integers <1. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

[PATCHES] Updated Packed Varlena (relative to CVS post SET_VARSIZE changes)

2007-02-28 Thread Gregory Stark
which ones are supposed to be varlenas and which are just random C data structures. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [PATCHES] Numeric patch to add special-case representations for < 8 bytes

2007-02-28 Thread Gregory Stark
ely there must exist reasonable algorithms to do better. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] Numeric patch to add special-case representations for < 8 bytes

2007-03-02 Thread Gregory Stark
both libgmp and the java math.BigDecimal libraries use base-2 digits. The latter with base-10 exponents no less. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] A little COPY speedup

2007-03-02 Thread Gregory Stark
.) Or larger block sizes of course. A 32kb block would be 16x as bad which starts to be pretty serious. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] A little COPY speedup

2007-03-02 Thread Gregory Stark
. The only file formats I ever wanted when I was doing this kind of stuff is tab separated, all the others (comma separated and (egads) *pipe* separated?!) are just disasters. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Gregory Stark
function didn't actually output last I saw, but would be nice if it were added). -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-06 Thread Gregory Stark
f | f | f (1 row) That might be kind of tricky to cons up though. I had to create a table to do it here. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 6: explain analyze is your friend

[PATCHES] Packed Varlenas update

2007-03-08 Thread Gregory Stark
. Fixed all regressions in contrib (gist indexed) modules . Fixed a bug that occurs when a compressed datum ends up under 128 bytes . Fixed a bug on zero-column tuples . Added regression tests http://community.enterprisedb.com/varlena/patch-varvarlena-16.patch.gz -- Gregory Stark

[PATCHES] Updated packed varlena patch

2007-03-09 Thread Gregory Stark
I've left inet and cidr with toast support and changed them to have attstorage 'm' instead. http://community.enterprisedb.com/varlena/patch-varvarlena-17.patch.gz -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--

[PATCHES] non-recursive WITH clause support

2007-03-09 Thread Gregory Stark
y had been written as subqueries. We'll have to do something much more clever to get recursive queries to work but for non-recursive queries that's sufficient. Example: postgres=# with a as (select 1 as x) select * from (select * from a) as x; x --- 1 (1 row) -- Gregory Stark Enterp

Re: [PATCHES] WIP patch for plan invalidation

2007-03-10 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Comments? Why do CREATE/DROP/REINDEX DATABASE no longer call PreventTransactionChain? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)---

Re: [PATCHES] WIP patch for plan invalidation

2007-03-10 Thread Gregory Stark
"Gregory Stark" <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> writes: > >> Comments? > > Why do CREATE/DROP/REINDEX DATABASE no longer call PreventTransactionChain? sigh, nevermind. -- Gregory Stark

[PATCHES] Packed varlena patch update

2007-03-12 Thread Gregory Stark
that? I don't really need anything so large for the regression but it was the most convenient way to make something which after compressing was large enough to toast externally. It might be better to find some less compressible data. -- Gregory Stark EnterpriseDB http://www.ente

Re: [PATCHES] guc patch: Make variables fall back to default values

2007-03-12 Thread Gregory Stark
ome documentation file touched by this, no? Or have I missed it? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] guc patch: Make variables fall back to default values

2007-03-13 Thread Gregory Stark
sume that all custom variables are strings. There are about half a dozen Assert(variable->vartype == PGC_STRING) throughout the patch. That's not true, plperl's use_strict is a boolean and we have DefineCustome*Variable functions for each type of variable. Perl bombs because plperl.use_s

[PATCHES] Updated Packed Varlena patch v20 (final?)

2007-03-13 Thread Gregory Stark
the big-endian case. It really makes sense to either remove them or remove the #ifdef. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings

Re: [PATCHES] LIMIT/SORT optimization

2007-03-14 Thread Gregory Stark
t to take into account the optimization Whether the communication between the Limit node and the Sort node is kosher or whether something more abstract is needed. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)-

Re: [PATCHES] LIMIT/SORT optimization

2007-03-14 Thread Gregory Stark
"Gregory Stark" <[EMAIL PROTECTED]> writes: > Bruce Momjian <[EMAIL PROTECTED]> writes: > >> Is there a newer version of this patch? > > As requested, I've cut an updated version of this patch against CVS HEAD: > > http://community.enterprisedb

Re: [PATCHES] patch adding new regexp functions

2007-03-21 Thread Gregory Stark
sed there isn't a macro for it though. Do you need the alignment? If so I want to check the code against the packed varlena patch. Just in case. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)---

Re: [PATCHES] patch adding new regexp functions

2007-03-21 Thread Gregory Stark
"Gregory Stark" <[EMAIL PROTECTED]> writes: > "Jeremy Drake" <[EMAIL PROTECTED]> writes: > >> BTW, should I be calling get_typlenbyvalalign on TEXTOID or are there macros >> for those also? > > Hardcoding -1 for typlen of varlenas is one

Re: [PATCHES] Improvement of procArray.xmin for VACUUM

2007-03-24 Thread Gregory Stark
en the youngest extant xmax and the oldest in-progress transaction. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [PATCHES] LIMIT/SORT optimization

2007-03-24 Thread Gregory Stark
ot;ready for review". Are you asking if it's ready to apply? I don't know, that's why we have reviews. Or are you asking if it's ready for someone to look at? What's the point of posting WIP patches if you don't want someone to look at it? -- Gregory Stark

Re: [PATCHES] Improvement of procArray.xmin for VACUUM

2007-03-25 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> Well I think this would be the same infrastructure we would need to do >> the other discussed improvement to address pg_dump's impact. That >> would req

Re: [PATCHES] Improvement of procArray.xmin for VACUUM

2007-03-26 Thread Gregory Stark
n and therefore is deleted for you. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] Numeric patch to add special-case representations for < 8 bytes

2007-03-27 Thread Gregory Stark
rrently? Do we mind losing it? > --- > > Gregory Stark wrote: >> >> I've uploaded a quick hack to store numerics in < 8 bytes when possible. >> >> http://community.enterprisedb.com/numeric-hack-1.patch >> >> This is

Re: [PATCHES] Recalculating OldestXmin in a long-running vacuum

2007-03-27 Thread Gregory Stark
simal way vacuum's dirty buffers are handled until Simon's patch to fix that goes in. The benefit of the patch that we would expect to see is that you won't need to run VACUUM as often. In the long term we would expect the stock table to grow less too but I doubt these tests were

Re: [PATCHES] [PATCH] add CLUSTER table ORDER BY index

2007-03-27 Thread Gregory Stark
akes precedence over any columns. I've never seen anyone name their indexes in a way that would conflict with a column anyways. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] LIMIT/SORT optimization

2007-03-28 Thread Gregory Stark
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Some comments on the patch below. Thanks! > Gregory Stark wrote: > > > > The comment claims that we use heap sort when the user says he doesn't want to > use glibc's qsort. I recall that we alw

Re: [PATCHES] LIMIT/SORT optimization

2007-03-29 Thread Gregory Stark
t-limit-v7.patch.gz Description: Binary data "Gregory Stark" <[EMAIL PROTECTED]> writes: > "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > >> There's a few blocks of code surrounded with "#if 0 - #endif". Are those just >> leftover

Re: [PATCHES] Blocked post

2007-04-02 Thread Gregory Stark
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> Plaintext patch, plus two plaintext .c files. > > Then I have no clue. Actually I've had more success with .tar.gz than plain text attachments. -- Gregory Stark EnterpriseDB

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-04-04 Thread Gregory Stark
dexes. Perhaps it would be nice to have an ALTER TABLE foo LIKE bar INCLUDING CONSTRAINTS as well. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore

Re: [PATCHES] Packed Varlena Update (v21)

2007-04-06 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > I wrote: >> stark <[EMAIL PROTECTED]> writes: >>> [ packed varlena patch ] > >> Applied with revisions. > > Forgot to mention: one of the revisions was to not add the "sizes.sql" > test, b

Re: [PATCHES] non-recursive WITH clause support

2007-04-10 Thread Gregory Stark
se it's standard then it could be considered an omission in our standards compliance. I'm actually not too sure what the answer is. I hadn't heard of it before the discussion about recursive queries myself. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com --

Re: [PATCHES] Packed Varlena Update (v21)

2007-04-10 Thread Gregory Stark
"Bruce Momjian" <[EMAIL PROTECTED]> writes: > Added to TODO: > > o Allow single-byte header storage for arrays Fwiw this is "single-byte header storage for varlena array *elements*" The arrays themselves already get the packed varlena treatment.

Re: [PATCHES] Dead Space Map version 3 (simplified)

2007-04-23 Thread Gregory Stark
those pages *before* that happens... -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] LIMIT/SORT optimization

2007-04-25 Thread Gregory Stark
p kept going up as the input data set grew. Sorting the top 1,000 strings from an input set of 1,000,000 strings went from 8m11s in stock Postgres to 12s using the bounded heapsort. (Which was an even better result than I had prior to fully randomizing the data. It probably just got packed bett

[PATCHES] updated SORT/LIMIT patch

2007-04-25 Thread Gregory Stark
Updated patch against cvs update in case it makes applying easier. One minor change: . Added #include in tuplesort.h to pull in UINT_MAX (thanks to dpage for noticing this is necessary on OSX) sort-limit-v8.patch.gz Description: Binary data -- Gregory Stark EnterpriseDB

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-04 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> Updated patch against cvs update in case it makes applying easier. > > Applied with revisions --- notably, I avoided adding any overhead to > HEAPCOMPARE() by the exped

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-04 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> What does the executor do differently in the case of a subplan with a >> parameter that makes it re-execute the plan from scratch and not just do a >> simple rescan? &

[PATCHES] Doc and comment patch for packed varlena

2007-05-09 Thread Gregory Stark
x: doc/src/sgml/xtypes.sgml === RCS file: /home/stark/src/REPOSITORY/pgsql/doc/src/sgml/xtypes.sgml,v retrieving revision 1.28 diff -c -r1.28 xtypes.sgml *** doc/src/sgml/xtypes.sgml 16 Sep 2006 00:30:16 - 1.28 --- doc/src/sgml/xtypes.sgml 9

[PATCHES] Concurrent psql patch

2007-05-11 Thread Gregory Stark
nything better but it doesn't sound like anyone else has any better ideas either. If not then we're going to be stuck with them. More or less, it's explicitly described as an "experimental" feature in the docs so I suppose we could always change them later. concurrent-psq

Re: [PATCHES] updated WIP: arrays of composites

2007-05-11 Thread Gregory Stark
do we need array types to have names at all? The only user-visible way to refer to these types is always by foo[] isn't it? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] Concurrent psql patch

2007-05-13 Thread Gregory Stark
wait] seem to be about as good as we could get. I don't have \cs or \cn set up as abbreviations. I was originally thinking \c1, \c2, ... for \cswitch and \c& for \cnowait. I'm not sure if going for cryptic short commands is better or worse here. -- Grego

Re: [PATCHES] Concurrent psql patch

2007-05-13 Thread Gregory Stark
he background, you have to manually switch sessions before issuing subsequent commands. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] Concurrent psql patch

2007-05-13 Thread Gregory Stark
"Jim C. Nasby" <[EMAIL PROTECTED]> writes: > On Sun, May 13, 2007 at 02:39:45PM +0100, Gregory Stark wrote: >> >> I was originally thinking \c1, \c2, ... for \cswitch and \c& for \cnowait. >> I'm >> not sure if going for cryptic short comma

Re: [PATCHES] Concurrent psql patch

2007-05-13 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> "David Fetter" <[EMAIL PROTECTED]> writes: >>> What's the reasoning behind \c&? Does it "send things into the >>> background"

Re: [PATCHES] [DOCS] OS/X startup scripts

2007-05-14 Thread Gregory Stark
Personally I find CVS so terribly slow for large trees like Postgres that it's essential to use rsync to maintain a local CVS repository. That makes 'cvs diff' remarkably fast. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of

Re: [PATCHES] [DOCS] OS/X startup scripts

2007-05-14 Thread Gregory Stark
ed to using rsync. The alternative is to manually edit the Entries files to list the new files. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? htt

Re: [PATCHES] Concurrent psql patch

2007-05-14 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> So would you prefer \g& as Jim Nasby suggested? I hadn't even considered that >> previously since I'm not accustomed to using \g but it does seem kind of >&g

Re: [PATCHES] Concurrent psql patch

2007-05-14 Thread Gregory Stark
and \c postgres" do the same thing. And it means "\c1" might connect to a database named "1" today but switch sessions tomorrow. Or we treat it as the first argument in which case even "\c 9" switches to session 9. I would prefer to do that but I fear

Re: [PATCHES] Concurrent psql patch

2007-05-14 Thread Gregory Stark
oblem at all to only extend \g and not semicolon handling. That said, I think a next step for this for interactive use would be to handle C-z to "background" the currently running query. So perhaps it does make sense to keep use cases like that when deciding on command na

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-15 Thread Gregory Stark
resorting is pointless. I think it would be worthwhile adding a method to tuplesort to ask whether random access is possible and how many tuples were actually kept. Then nodeSort could ask it those values instead of just remembering what values were requested. sortlimit-fix-v2

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-16 Thread Gregory Stark
"Alvaro Herrera" <[EMAIL PROTECTED]> writes: > Gregory Stark wrote: > >> Attached is a small patch which fixes this case. It also makes the check >> slightly more liberal -- we don't need to resort if the previous sort was >> unbounded or the bou

Re: [PATCHES] [DOCS] OS/X startup scripts

2007-05-16 Thread Gregory Stark
Those lines go to stderr. If you do "cvs diff > file" it spits out all the cvs file statuses to the terminal but dumps the diff to the file. It doesn't matter, diffs can contain arbitrary junk between the file diffs. patch only looks at the things it recognizes. -- Gregory S

Re: [PATCHES] Concurrent psql patch

2007-05-16 Thread Gregory Stark
be back Monday. concurrent-psql-v8.patch.gz Description: Binary data -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-16 Thread Gregory Stark
ccess and using a boolean value we get back from asking tuplesort? The "tuples_needed" is a bit of a wart but then it's the same inevitable wart as set_bound. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(en

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-17 Thread Gregory Stark
"Gregory Stark" <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> writes: > >> This patch makes what was already a hack into a full-fledged crock (and >> it's not just the self-doubting comments that make me distrust it). >

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-05-17 Thread Gregory Stark
behaviour? > > It'd be contrary to SQL spec. The UNIQUE constraint takes a list of > column names, full stop. Does the SQL spec actually specify what happens if you provide an non-compliant table definition like this? -- Gregory Stark EnterpriseDB http://www.

Re: [PATCHES] Concurrent psql patch

2007-05-21 Thread Gregory Stark
"Andrew Dunstan" <[EMAIL PROTECTED]> writes: > Gregory Stark wrote: >> Attached is an updated patch. >> > > This patch appears to add a nonexistent test to the regression schedules. I must have forgotten to cvs add it. Sorry. Also, I forgot to mention pre

Re: [PATCHES] Concurrent psql patch

2007-05-24 Thread Gregory Stark
t (such as one running a script) we would want to exit I think. Another XXX is next to the include of libpq-int.h and a third one is where I have the pg_sleep loop instead of a select/poll loop. It occurs to me now that that loop should check cancel_pressed too. -- Gregory Stark Enterpris

Re: [PATCHES] cluster test

2007-05-25 Thread Gregory Stark
asure the table size shows up as different estimates for sequential scan costs? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate su

Re: [PATCHES] Seq scans status update

2007-05-28 Thread Gregory Stark
e_count when re-using a buffer from the ring). Is there a reason UnpinBuffer has to be the one to increment the usage count anyways? Why can't ReadBuffer handle incrementing the count and just trust that it won't be decremented until the buffer is unpinned anyways? -- Grego

Re: [PATCHES] Concurrent psql patch

2007-05-29 Thread Gregory Stark
esults. It's a bit annoying to have two state bits that hold the same data at two different levels of abstraction though. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] Concurrent psql patch

2007-05-29 Thread Gregory Stark
etter off adding a PQSocketPollms() which works in milliseconds instead of seconds? Or should I just copy all this code into psql? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] Concurrent psql patch

2007-06-01 Thread Gregory Stark
fixes? Yes, sorry, I started to already but got distracted by some tests I've been running. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings

[PATCHES] Bug in date.c

2007-06-02 Thread Gregory Stark
ch that just makes the minimal fix of calling textout when the error is thrown. Alternatively it might be handy to have a custom escape in errmsg format strings for text varlena data. date.c.patch.gz Description: Binary data date-minimal.c.patch.gz Description: Binary data --

Re: [PATCHES] Synchronized scans

2007-06-04 Thread Gregory Stark
t only if you were the last to update the scan position which i would expect would be pretty rare except for the last scanner. If a backend died it would leave a scan position behind but the next scanner on that table would overwrite the pid and then remove it when it's finished. --

Re: [PATCHES] Synchronized scans

2007-06-04 Thread Gregory Stark
onable value that won't cause problems but you expect under normal conditions not to reach that limit. There are also cases where people use OFFSET and LIMIT with degenerate values (either OFFSET 0 or LIMIT ) to induce the planner to plan queries differently knowing that it won't a

Re: [PATCHES] Synchronized scans

2007-06-09 Thread Gregory Stark
ause i/o it would basically work unless the sleep time was so large that the other scans managed to cycle through the entire ring in that time. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 1: i

  1   2   3   4   >