[PATCHES] misc doc fixes

2003-08-09 Thread Neil Conway
This patch makes two minor fixes to the docs: (1) fixes a spelling mistake in the PREPARE ref page (2) Makes some English more consistent, in the ref pages for some of the client apps (3) Adds a link to the libpq docs in the vacuumdb ref page. -Neil Index: doc/src/sgml/ref/clusterdb.sgml

[PATCHES] add (minimal) UPDATE regression test

2003-08-10 Thread Neil Conway
This patch adds a new regression test for the UPDATE command. Right now all that is tested is Rod Taylor's recent addition to allow this syntax: UPDATE ... SET col = DEFAULT; If anyone else would like to add more UPDATE tests, go ahead -- I just wanted to write a test for the above

Re: [PATCHES] logging enhancements, minor code cleanup

2003-08-10 Thread Neil Conway
On Sun, Aug 10, 2003 at 06:19:05PM -0400, Andrew Dunstan wrote: Neil Conway wrote: On Sat, Aug 09, 2003 at 07:22:56PM -0400, Andrew Dunstan wrote: Sure. Very easy. Nobody suggested it when I floated the idea of logging session end on the hackers list, but it's a simple change. How does

Re: [PATCHES] doc patch - linux memory handling

2003-08-22 Thread Neil Conway
Minor SGML gripes... On Fri, Aug 22, 2003 at 10:00:00AM -0400, Andrew Dunstan wrote: ! To avoid this situation, run postgres on a machine where you postgres should be productnamePostgreSQL/productname. ! altering the system's default behaviour. This can be determined ! by

[PATCHES] improve runtime config docs

2003-09-03 Thread Neil Conway
This patch makes a number of improvements to the runtime config documentation. -Neil Index: doc/src/sgml/runtime.sgml === RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/runtime.sgml,v retrieving revision 1.201 diff -c -r1.201

[PATCHES] minor documentation improvements

2003-09-04 Thread Neil Conway
This patch makes a few minor improvements to the docs: make the varname conventions more consistent, and improve the ANALYZE ref page. -Neil Index: doc/src/sgml/perform.sgml === RCS file:

[PATCHES] fix doc typo

2003-09-04 Thread Neil Conway
This patch fixes a trivial typo in the CREATE FUNCTION ref page. -Neil Index: doc/src/sgml/ref/create_function.sgml === RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/ref/create_function.sgml,v retrieving revision 1.49 diff -c

Re: [PATCHES] minor documentation improvements

2003-09-05 Thread Neil Conway
On Fri, 2003-09-05 at 17:16, Peter Eisentraut wrote: Currently, the documentation contains about 2 GUC variable names in upper case, the rest is lower case. There are significantly more than 2 uses of upper-case GUC names in the docs (more like 10 by my guess), but in any case, the current

Re: [PATCHES] mcxt.c

2003-09-08 Thread Neil Conway
On Mon, 2003-09-08 at 11:09, Gaetano Mendola wrote: Tom Lane [EMAIL PROTECTED] wrote: I see no value at all in an assert. The code will dump core just fine with or without an assert ... Right but an assert can display information about the file and line number without debug the

Re: [PATCHES] more doc cleanup

2003-09-11 Thread Neil Conway
On Thu, 2003-09-11 at 17:41, Bruce Momjian wrote: Patch applied. Thanks. Your documentation changes can be viewed in 5 minutes using links at the bottom of the developer's page. Right (... although I always build a copy of the docs locally while I'm making changes, to double-check that they

Re: [PATCHES] Regression test for stats collector

2003-09-11 Thread Neil Conway
On Thu, 2003-09-11 at 11:58, Bruce Momjian wrote: Uh, how do you force the stats collector to 'on' before the test is run? The stats collector is on by default (of course, that doesn't apply to make installcheck...) But this reminds me: I think it would be cool to extend the language we use

[PATCHES] more doc improvements

2003-09-13 Thread Neil Conway
This patch makes a few incremental improvements to geqo.sgml and arch-dev.sgml -Neil Index: doc/src/sgml/arch-dev.sgml === RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/arch-dev.sgml,v retrieving revision 2.21 diff -c -r2.21

[PATCHES] fix log_min_duration_statement logic error

2003-09-22 Thread Neil Conway
This patch fixes an obvious bug in the should I print the duration of this query? logic in postgres.c I also don't particularly like the format of the log message (for one thing, the duration_statement prefix in the log message shouldn't include an underscore, it's not a variable or anything --

[PATCHES] introduce default_use_oids

2003-09-30 Thread Neil Conway
This patch adds a new GUC var, default_use_oids, which follows the proposal for eventually deprecating OIDs on user tables that I posted earlier to pgsql-hackers. pg_dump now always specifies WITH OIDS or WITHOUT OIDS when dumping a table. The documentation has been updated. Comments are welcome.

Re: [PATCHES] [HACKERS] Open 7.4 items

2003-10-05 Thread Neil Conway
On Sun, 2003-10-05 at 19:58, Tom Lane wrote: That's a fairly useless place to put it, though, since someone would only think to look at sort_mem if they already had a clue. It should be mentioned under bulk data load (in performance tips chapter) Attached is a doc patch that does this. The

Re: [PATCHES] fix for strict-alias warnings

2003-10-14 Thread Neil Conway
On Tue, 2003-10-14 at 15:00, Manfred Spraul wrote: I think we must either add -fno-strict-aliasing, or switch to the c compiler memset functions for gcc. The last time we did some benchmarking, using the builtin memset() imposes a significant performance penalty on plenty of different

Re: [PATCHES] fix for strict-alias warnings

2003-10-14 Thread Neil Conway
On Tue, 2003-10-14 at 16:29, Peter Eisentraut wrote: The last time I did some testing, the builtin memset() was significantly faster on plenty of different platforms. Oh? Which platforms are you referring to, and what tests were performed? You can find the benchmark results I'm referring to in

[PATCHES] minor HISTORY improvement

2003-10-15 Thread Neil Conway
This patch adds another item to the migration to 7.4 list in the HISTORY file, and attributes the shared-buffer-alignment change to Manfred Spraul. -Neil Index: HISTORY === RCS file: /var/lib/cvs/pgsql-server/HISTORY,v retrieving

Re: [PATCHES] introduce default_use_oids

2003-10-17 Thread Neil Conway
On Fri, 2003-10-10 at 05:56, Manfred Koizar wrote: On Tue, 30 Sep 2003 20:00:22 -0400, Neil Conway [EMAIL PROTECTED] wrote: This patch adds a new GUC var, default_use_oids Shouldn't it be honoured by CREATE TABLE AS SELECT ... ? Good catch. I've attached an updated patch. I also included

[PATCHES] fix memory leak in libpq

2003-10-17 Thread Neil Conway
This patch fixes a small memory leak in libpq: the 'pstatus' field of PGconn is a linked list of malloc'ed nodes, so it should be freed on PQfinish(). -Neil Index: src/interfaces/libpq/fe-connect.c === RCS file:

[PATCHES] minor psql cleanup

2003-10-17 Thread Neil Conway
This patch reduces some unsightly #ifdefs, and fixes two typos in comments in the psql code. This doesn't make any functional change, so feel free to save it for 7.5 -Neil Index: src/bin/psql/command.c === RCS file:

[PATCHES] more improvements to release notes

2003-10-22 Thread Neil Conway
This patch makes a bunch of improvements to the release notes. I only modified release.sgml -- HISTORY will need to be regenerated. I was able to remove almost all of the Other uncategorized release note entries, but left a few that I wasn't sure what to do with. We should remove this section,

Re: [PATCHES] more improvements to release notes

2003-10-26 Thread Neil Conway
On Sun, 2003-10-26 at 00:50, Bruce Momjian wrote: listitemparaMake MOVE/FETCH 0 now does nothing (Bruce)/para/listitem Still wrong :-) Make ... now does nothing is ungrammatical. The other modified entry is incorrect for the same reason (Cause ... now returns). -Neil

[PATCHES] bufmgr code cleanup

2003-11-02 Thread Neil Conway
This patch cleans up some of the bufmgr code: - replace uses of LockBuffer(buf, BUFFER_LOCK_UNLOCK); ReleaseBuffer(buf); with the equivalent, but more concise: UnlockAndReleaseBuffer(buf); - analogous changes were made by replacing LockBuffer() +

[PATCHES] equal() perf tweak

2003-11-03 Thread Neil Conway
Currently, equal() does the following for List nodes: case T_List: { List *la = (List *) a; List *lb = (List *) b; List *l; /* * Try to reject by length check before we grovel through * all the elements... */ if

Re: [PATCHES] equal() perf tweak

2003-11-03 Thread Neil Conway
On Mon, 2003-11-03 at 10:04, Tom Lane wrote: You have effectively reverted the code to its previous slow state. Erm, the original version of this code in CVS (from ~7 years ago) is the following: case T_List: { List *la = (List*)a; List *lb = (List*)b;

Re: [PATCHES] bufmgr code cleanup

2003-11-03 Thread Neil Conway
On Mon, 2003-11-03 at 10:00, Tom Lane wrote: I do not actually agree with the UnlockAndReleaseBuffer changes anyway. I think this obscures the code by making resource grabbing and resource releasing code unsymmetrical Hmm... fair enough, I see your point. In that case, should I remove the

Re: [PATCHES] equal() perf tweak

2003-11-03 Thread Neil Conway
On Mon, 2003-11-03 at 16:39, Tom Lane wrote: The point is that the elements of the lists could be large, complicated structures that will take noticeable amounts of time to compare. Good point, I agree with your analysis. At the very least, I'll add a comment to equal() explaining why the

Re: [PATCHES] equal() perf tweak

2003-11-05 Thread Neil Conway
Ok, I've attached new versions of list.c and pg_list.h -- this is just a *rough sketch* of the new List code -- it definitely won't compile, the intent is just to concretely specify the new List design. Also, I've only updated the important list functions: I stopped at nth(). (I've attached the

Re: [PATCHES] equal() perf tweak

2003-11-05 Thread Neil Conway
Gaetano Mendola [EMAIL PROTECTED] writes: Why instead of reinvent the whell not use, or at least do a C port of stl::list ? Because (a) implementing a linked list is pretty trivial (b) the only difficult part is getting the semantics / API right. I don't see how std::list would help with (b),

Re: [PATCHES] equal() perf tweak

2003-11-05 Thread Neil Conway
Gaetano Mendola [EMAIL PROTECTED] writes: An interesting think that stl::list do is to never do an if branch during an insert/remove phase Why is this significant? Surely you're not claiming that avoid the branch will affect performance in a meaningful way... What if you will never call the

Re: [PATCHES] equal() perf tweak

2003-11-05 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: This does suggest that it might be worth making the struct layout be int NodeTag; int length; foo *head; foo *tail; since this would avoid some padding overhead on a machine where pointers are 8 bytes and need 8-byte alignment.

Re: [PATCHES] $PostgreSQL$ header -- Post 7.4 Release

2003-11-10 Thread Neil Conway
Rod Taylor [EMAIL PROTECTED] writes: In src/backend/utils/adt/inet_net_ntop.c and src/backend/utils/adt/inet_net_pton.c it would appear that the $Id$ tag is assigned to a variable (rcsid). ... which is never referenced AFAICT, even if the necessary preprocessor definitions are set so that it

Re: [PATCHES] equal() perf tweak

2003-11-11 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: Is there a TODO here? I've been short on time recently, so I haven't had a chance to make the suggested changes to the List patch. I'll send in an updated version of the List changes, and if there aren't any gripes, I'll begin making the changes to the

Re: [PATCHES] New List

2003-11-14 Thread Neil Conway
Gaetano Mendola [EMAIL PROTECTED] writes: 10E6 INSERT = real 0m5.161s user 0m4.010s sys0m1.150s What operation is this benchmarking? Only linked-list appends, or something else? -Neil ---(end of

[PATCHES] refactor CreateTupleDescCopy()

2003-11-17 Thread Neil Conway
This patch refactors CreateTupleDescCopy() and CreateTupleDescCopyConstr() to remove some duplicated code, and clean things up a little bit. -Neil Index: src/backend/access/common/tupdesc.c === RCS file:

Re: [PATCHES] initdb copyright notice

2003-11-17 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: I have grabbed code from NetBSD before, and I just mention that fact at the top of the file. There is no need to repeat their license as it is the same as our license. src/port/qsort.c is wrong, then: (a) it includes the full NetBSD copyright/warranty

Re: [PATCHES] initdb copyright notice

2003-11-17 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: I don't change the copyright, but I think we can take the copyright of the project rather than those of the individual files. So can we remove the offending license clauses, then? Also, it's worth noting that the license in 'COPYRIGHT' is not exactly the

Re: [PATCHES] initdb copyright notice

2003-11-17 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: I think there was an updated BSD license approved by Berkeley that we are using. I think this is an area where we need a higher degree of certainty than that. If we took the file unchanged, I would not remove the copyright because it is the file

[PATCHES] cleanup execTuples.c

2003-11-19 Thread Neil Conway
This patch refactors execTuples.c in two ways: (1) ExecInitXXXResultTupleSlot() used a macro to avoid some duplicated code, whereas calling ExecInitExtraTupleSlot() would make the code more clear. (2) ExecTypeFromTL() and ExecCleanTypeFromTL() duplicated a bunch

Re: [PATCHES] Add GUC setting to make created tables default to

2003-11-19 Thread Neil Conway
Hans-Jürgen Schönig [EMAIL PROTECTED] writes: I have attaches a patch against 7.4.0 which contains the implementation of the following todo item. I sent a proposal for this functionality to -hackers a month or so ago, and implemented it a couple days later -- it was sent to pgsql-patches, and

[PATCHES] fix compile warning

2003-11-20 Thread Neil Conway
This patch fixes a trivial compiler warning introduced recently in bufmgr.c -Neil Index: src/backend/storage/buffer/bufmgr.c === RCS file: /var/lib/cvs/pgsql-server/src/backend/storage/buffer/bufmgr.c,v retrieving revision 1.145 diff

Re: [PATCHES] refactor CreateTupleDescCopy()

2003-11-20 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: I think this is taking the avoid duplicated code mantra a little far. You've defined a subroutine that returns a TupleDesc that is internally inconsistent and cannot usefully be used for anything until it's fixed by the parent routines. Fair enough. Another

Re: [PATCHES] refactor CreateTupleDescCopy()

2003-11-20 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: That would be okay with me. It might be a good idea to change the name completely (perhaps CopyTupleDesc() ?) as a means of catching places that aren't correctly updated. Done, and done -- a revised patch is attached. -Neil Index:

[PATCHES] fix PL/PgSQL doc typo

2003-11-20 Thread Neil Conway
There is an unused variable in an example function in the PL/PgSQL documentation; this patch removes it. -Neil Index: doc/src/sgml/plpgsql.sgml === RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/plpgsql.sgml,v retrieving revision

Re: [PATCHES] [pgsql-hackers-win32] pg_ctl

2003-11-28 Thread Neil Conway
This code is pretty awful, IMHO. If you're going to copy code from a 3rd party (in this case, MSDN), it is standard practise to include an attribution. Also, what redistribution terms apply to MSDN sample code? Assuming we don't remove or rewrite the MSDN sample code, it is usually considered

Re: [PATCHES] pg_autovacuum patches

2003-11-29 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: I am going to try to fill the queue tonight and apply it Monday. I leave for Japan on Tuesday. Applying a load of patches and then promptly fleeing the country doesn't sound so wise -- it sounds mighty suspicious, in fact :-) (At the same time, I can

Re: [PATCHES] introduce default_use_oids

2003-12-01 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: We need a solution to this. I'm really not sure we do: the SQL produced by pg_dump was totally non-portable before, and it is slightly less portable now. ISTM that you will almost always need to do some post-processing of pg_dump's output to have any hope

Re: [PATCHES] [PATCH] Re: [pgsql-advocacy] Why READ ONLY

2003-12-01 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: I assume this patch is to control this way of breaking out of a read-only transaction: [...] This seems like a valuable feature, as others have mentioned. Why is this feature valuable? A read only user is still able to easily DOS the server, consume

Re: [PATCHES] introduce default_use_oids

2003-12-02 Thread Neil Conway
Peter Eisentraut [EMAIL PROTECTED] writes: I'm sure there are other ways to phase out OIDs in dumps. Okay, fair enough -- I'll submit a patch to change this. -Neil ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

[PATCHES] minor SGML fix

2003-12-04 Thread Neil Conway
A GUC variable in runtime.sgml had the wrong markup -- this patch fixes that, and makes a few other tiny SGML improvements. -Neil Index: doc/src/sgml/runtime.sgml === RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/runtime.sgml,v

[PATCHES] fix vpath doc builds

2003-12-10 Thread Neil Conway
At present, trying to build the documentation from outside the source tree (i.e. a vpath build) fails. This patch fixes that. Two changes were required: - in a vpath build, make sure that we look in the appropriate directory in the build tree, not just the source tree (some

[PATCHES] improvements to SGML

2003-12-10 Thread Neil Conway
This patch makes some editorial improvements to the bug reporting guidelines and the LOCK reference page. -Neil Index: doc/src/sgml/problems.sgml === RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/problems.sgml,v retrieving

[PATCHES] bufmgr code cleanup (revised)

2003-12-10 Thread Neil Conway
I posted some bufmgr cleanup a few weeks ago, but it conflicted with some concurrent changes Jan was making to the bufmgr. Here's an updated version of the patch -- it should apply cleanly to CVS HEAD and passes the regression tests. This patch makes the following changes: - remove the

[PATCHES] improve routine vacuuming docs

2003-12-10 Thread Neil Conway
This patch makes some improvements and adds some details to the documentation on routine database maintenance activities. Any comments on the new text would be appreciated. I decided not to mention the FSM -- I haven't seen any reports that users have had to tweak FSM settings in 7.4, and it is

Re: [PATCHES] improve routine vacuuming docs

2003-12-11 Thread Neil Conway
Robert Treat [EMAIL PROTECTED] writes: Should be TRUNCATE removes the emphasisentire/emphasis content of the table immediately, without requiring a subsequent commandVACUUM/command or commandVACUUM FULL/command to reclaim the now-unused disk space. I think the emphasis/ is overkill, but

[PATCHES] make wal_debug GUC var a boolean

2003-12-11 Thread Neil Conway
The wal_debug GUC variable was of type integer, but it was used in the code effectively as a boolean: the code only tested whether it was zero or non-zero. This patch makes it a proper boolean. -Neil Index: doc/src/sgml/runtime.sgml

Re: [PATCHES] improvements to SGML

2003-12-12 Thread Neil Conway
Peter Eisentraut [EMAIL PROTECTED] writes: Looks good, but did you have a specific reason to prefer LOCK TABLE over plain LOCK? None other than consistency: the majority of the usages in lock.sgml already used LOCK TABLE, so I converted the rest over. I don't particularly prefer one form over

Re: [PATCHES] make wal_debug GUC var a boolean

2003-12-12 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: I agree. Having a special debug variable for WAL seems like a short-term thing whose time has passed. ISTM that there is little distinguishing wal_debug and the following GUC vars: log_btree_build_stats trace_notify trace_locks trace_userlocks trace_lwlocks

Re: [PATCHES] improve routine vacuuming docs

2003-12-12 Thread Neil Conway
Peter Eisentraut [EMAIL PROTECTED] writes: It's kind of hard to see what you have really changed. Can you provide a summary? The majority of the changes are in the 3rd patch hunk; ISTM it is pretty easy to see what has been changed. I spent more time discussing the differences between VACUUM

Re: [PATCHES] make wal_debug GUC var a boolean

2003-12-12 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: The others are already #ifdef'd out by default, which is more or less what I was suggesting you do with the wal_debug code. (FWIW, trace_notify is not #ifdef'd out.) But I thought that you (and Peter) were suggesting that this shouldn't be made a GUC variable

[PATCHES] improve varname/ markup

2003-12-12 Thread Neil Conway
This patch fixes a few more uppercase GUC vars. I also removed an example from the RESET reference page because it seemed completely redundant. -Neil Index: doc/src/sgml/ref/analyze.sgml === RCS file:

Re: [PATCHES] minor SGML improvements

2003-12-13 Thread Neil Conway
Neil Conway [EMAIL PROTECTED] writes: This patch makes some SGML markup more consistent and makes a small improvement to the SSL auth docs. Patch applied to HEAD. -Neil ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go

Re: [PATCHES] improvements to SGML

2003-12-13 Thread Neil Conway
Neil Conway [EMAIL PROTECTED] writes: This patch makes some editorial improvements to the bug reporting guidelines and the LOCK reference page. Patch applied to HEAD. -Neil ---(end of broadcast)--- TIP 3: if posting/reading through Usenet

Re: [PATCHES] improve routine vacuuming docs

2003-12-13 Thread Neil Conway
Neil Conway [EMAIL PROTECTED] writes: I've attached a revised patch that incorporates these changes. Thanks for the feedback! Patch applied to HEAD. Thanks again, Robert Peter. -Neil ---(end of broadcast)--- TIP 4: Don't 'kill -9

Re: [PATCHES] improve varname/ markup

2003-12-13 Thread Neil Conway
Neil Conway [EMAIL PROTECTED] writes: This patch fixes a few more uppercase GUC vars. I also removed an example from the RESET reference page because it seemed completely redundant. Patch applied to HEAD. -Neil ---(end of broadcast)--- TIP 2

Re: [PATCHES] bufmgr code cleanup (revised)

2003-12-13 Thread Neil Conway
Neil Conway [EMAIL PROTECTED] writes: I posted some bufmgr cleanup a few weeks ago, but it conflicted with some concurrent changes Jan was making to the bufmgr. Here's an updated version of the patch -- it should apply cleanly to CVS HEAD and passes the regression tests. Patch applied to HEAD

Re: [PATCHES] fork/exec patch

2003-12-14 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: Let me add that Claudio is doing a fantastic job on this. The changes are minimal and clean. I think the writing of a per-backend temp file has allowed this patch to be smaller than it might have been. Did we REALLY conclude that the best way to work

Re: [PATCHES] fork/exec patch

2003-12-14 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: I don't think we ever discussed it, but it seemed logical and a minimal change to the code. We already have a GUC write of non-default values for exec and no one had issues with that. For the record, I think that is ugly as well :-) Anyway, I'm not

Re: [PATCHES] fork/exec patch

2003-12-15 Thread Neil Conway
Claudio Natoli [EMAIL PROTECTED] writes: This patch is the next step towards (re)allowing fork/exec. I've included a few comments on the patch below. Unfortunately I only had time to briefly look over the code... Why did you change ShmemIndexLock from an LWLock to a spinlock? The number of

Re: [PATCHES] fork/exec patch

2003-12-16 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: That one I can answer --- it's a bootstrapping issue: we can't use LWLocks until we have a PGProc (*MyProc), and we can't set that up without looking in the ShmemIndex for the related data structures. So ShmemIndex needs to use a more primitive lock type.

[PATCHES] remove some unused typedefs

2004-01-05 Thread Neil Conway
This patch removes the following unused typedefs from c.h: bool8, bool16, bool32, word8, word16, word32, Offset In order to remove Offset I had to update some code in page/bufpage.c, but that shouldn't have been using Offset to begin with, AFAICS. Unless anyone complains, I'll apply this

[PATCHES] remove 'noversion' from standalone backend

2004-01-05 Thread Neil Conway
This patch removes the remaining code for processing the '-C' command-line option in the standalone backend. It no longer actually functions (i.e. specifying the option does nothing), and I didn't think it was interesting enough to be worth reviving, so I removed it. Unless anyone objects, I

Re: [PATCHES] make wal_debug GUC var a boolean

2004-01-05 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: I think the combination of #ifdef and GUC variable is appropriate. The attached patch implements this: the wal_debug GUC var is now a boolean, and is encloded in `#ifdef WAL_DEBUG` blocks (and the WAL_DEBUG symbol is present in pg_config_manual.h, just

[PATCHES] remove obsolete NULL casts

2004-01-05 Thread Neil Conway
In any modern dialect of C, casting the NULL pointer literal to a specific pointer type is unnecessary. For example: char *foo; foo = malloc(...); if (foo == (char *) NULL) {...} The cast on the 3rd line serves no useful purpose. Hence, this patch removes all such instances of

[PATCHES] minor smgr code cleanup

2004-01-05 Thread Neil Conway
This patch cleans up some code in the smgr and elsewhere: - Update comment in IsReservedName() to the present day, remove ugly coding for speed as this is no longer a performance critical function - Improve some variable function names in commands/vacuum.c. I was

Re: List rewrite (was Re: [PATCHES] minor smgr code cleanup)

2004-01-05 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: BTW, I was planning to ask you where that stood. I've been writing new code on the assumption that I didn't have to bother with FastList Yeah, I definitely plan to have the list rewrite finished in time for 7.5. After the bufmgr work, it's the next thing on

Re: [PATCHES] remove 'noversion' from standalone backend

2004-01-06 Thread Neil Conway
Neil Conway [EMAIL PROTECTED] writes: Unless anyone objects, I intend to apply this in 24 hours or so. Patch applied. -Neil P.S. BTW, how does everyone feel about the methodology I've been using for submitting and applying patches? The procedure I'm following is: - for trivial / obviously

Re: [PATCHES] minor smgr code cleanup

2004-01-06 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: This change is actually wrong (backwards), no? You want a true result on equality. *sigh*, I'm an idiot. Thanks for catching my mistake! Pretending that the result of strcmp is a bool is a type pun, and one that can rise up to bite you. In the case at

[PATCHES] move 'Value' node into separate file

2004-01-06 Thread Neil Conway
This patch separates the 'Value' and 'List' nodes: now the Value node has its own interface (i.e. header) and implementation files. This is just house-keeping, in preparation for the list rewrite. I renumbered a NodeTag: does that require a catalog version number bump? Unless anyone objects, I

[PATCHES] add WITH OIDS to CREATE TABLE AS

2004-01-06 Thread Neil Conway
This patch adds a WITH / WITHOUT OIDS clause to CREATE TABLE AS. This allows the user to explicitly specify whether OIDs should be included in the newly-created relation (if form of this clause is specified, the default_with_oids configuration variable is used). This is useful because it provides

Re: [PATCHES] add WITH OIDS to CREATE TABLE AS

2004-01-06 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: Does this deal with the fact we now emit WITH/WITHOUT OID in pg_dump? No, that is an unrelated issue. I took a brief look at implementing this over the break, but I couldn't see an easy way to do it properly: if we pick a particular default for the GUC

Re: [PATCHES] move 'Value' node into separate file

2004-01-06 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: This is just cleanup, right? Right -- AFAICS, there is no reason for the two nodes to be in the same file. Or were you intending that something will happen to Value in connection with the List changes? I can't think what offhand ... Neither can I -- ISTM

Re: [PATCHES] add WITH OIDS to CREATE TABLE AS

2004-01-06 Thread Neil Conway
Bruce Momjian [EMAIL PROTECTED] writes: Couldn't we use SET only when we need to change the existing value? I'm not sure what you mean. The pg_dump output will look like: -- at the top of the dump SET default_with_oids = false; -- or true, doesn't really matter -- for a table that doesn't have

Re: [PATCHES] add WITH OIDS to CREATE TABLE AS

2004-01-07 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: One thing that is *not* fine is something that I see had snuck past me in the previous WITH OIDS patch. It is not okay for gram.y or scan.l to be looking at GUC variables --- that creates synchronization issues. Good point (I remember reading gram.y's

Re: [PATCHES] Patch to bring \copy syntax more in line with SQL

2004-01-20 Thread Neil Conway
Bill Moran [EMAIL PROTECTED] writes: Neil Conway wrote: - don't use C++-style comments Oops ... sorry ... been doing too much PHP. BTW: Why is this frowned apon so? Are there compilers that have problems with it? IMHO it's not so much that it's considered THAT evil, it's just an easy

[PATCHES] fix recent WITH OIDS bug

2004-01-22 Thread Neil Conway
This patch fixes a bug I introduced in the recent CREATE TABLE AS / WITH OIDS work. The patch should be pretty straight-forward. The only question I have is whether analyze.c (and therefore analyze.h) is the right place to put the new utility function interpretOidsOption() -- can anyone suggest a

Re: [PATCHES] fix recent WITH OIDS bug

2004-01-22 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: You could possibly put it next to the existing function interpretInhOption(), which does essentially the same kind of thing and for the same reason. However, I can't argue that that function's placement in parse_clause.c has any real strong motivation

[PATCHES] cleanup psql memory handling

2004-01-23 Thread Neil Conway
This patch makes some of the memory manipulation performed by psql a little more sane. Some parts of the code was using a static function xmalloc() that did safe memory allocation (where safe means bail out on OOM), but most of it was just invoking calloc() or malloc() directly. So I moved

[PATCHES] appendStringInfoString() micro-opt

2004-01-24 Thread Neil Conway
This patch replaces a bunch of call sites of appendStringInfo() with appendStringInfoString(). (For those without the code in front of you, the difference between these two functions is that the former takes a sprintf-style format string and a variable list of arguments, whereas the latter just

[PATCHES] next draft of list rewrite

2004-01-24 Thread Neil Conway
I've attached the latest header and implementation files (pg_list.h and list.c, respectively) for the new linked list implementation. I'm pretty satisfied with the new API: now would be the ideal time to suggest any changes you think I should make to it. I decided to use a new naming convention:

Re: [PATCHES] Clarify libpq docs

2004-01-26 Thread Neil Conway
Gavin Sherry [EMAIL PROTECTED] writes: The attached patch clarifies (or, rather, makes explicit) to readers how to handle memory management for char pointers returned by libpq functions. Patch applied. I expanded the tabs in that file to 4 spaces, per the discussion. I also noticed and fixed a

Re: [PATCHES] improve join_collapse_limit docs

2004-01-27 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: This should include some weasel-wording along the lines of At present, blah blah blah. Good point, thanks. It is theoretically legal to reorder outer joins in some cases Indeed; see Outerjoin Simplification and Reordering for Query Optimization by

Re: [PATCHES] support for printing/exporting xml

2004-01-29 Thread Neil Conway
Brian Moore [EMAIL PROTECTED] writes: please find attached my support for printing/exporting xml from postgresql. A few quick comments: - why is it necessary to include an entire hash table implementation? Why does this code require a hash table to begin with, considering the relatively

Re: [PATCHES] support for printing/exporting xml

2004-01-29 Thread Neil Conway
Brian Moore [EMAIL PROTECTED] writes: it's not necessary. i ran tests and the hashtable lookup was faster (though not by too much) than the bsearch for the data with which i populated the table. Right -- I'd expect the performance difference between the two to be pretty negligible for even the

[PATCHES] fix minor memory error in initdb

2004-01-31 Thread Neil Conway
The new C version of initdb presently provokes the following valgrind warnings: ==15366== ==15366== Conditional jump or move depends on uninitialised value(s) ==15366==at 0x8049713: mkdir_p (initdb.c:556) ==15366==by 0x8049C8E: mkdatadir (initdb.c:812) ==15366==by 0x804C833: main

Re: [PATCHES] reading uninitialized buffer

2004-02-01 Thread Neil Conway
Andrew Dunstan [EMAIL PROTECTED] writes: OK, then *This* patch does it the way I think is clearest. Most of it is just reindenting. Unless anyone objects, I'll review and apply this patch within 24 hours. Thanks for the patch, Dennis and Andrew. -Neil ---(end of

Re: [PATCHES] reading uninitialized buffer

2004-02-02 Thread Neil Conway
Andrew Dunstan [EMAIL PROTECTED] writes: OK, then *This* patch does it the way I think is clearest. Most of it is just reindenting. Okay, I applied this patch, and made a few additional cleanups along the way (the whole function and a couple other things don't need to be declared in hba.h, for

[PATCHES] fix memcpy() overlap

2004-02-02 Thread Neil Conway
Another error reported by valgrind on the postmaster ( children) is the following: ==30568== Source and destination overlap in memcpy(0xBFFFEA30, 0xBFFFEA30, 24) ==30568==at 0x40024224: memcpy (mac_replace_strmem.c:93) ==30568==by 0x82081F3: set_var_from_var (numeric.c:2732) ==30568==

Re: [PATCHES] fix memcpy() overlap

2004-02-02 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: This isn't a bug If that's the case I'm content with not changing the code, but I'd rather not just take it on faith: can you point me to some authority that says two objects with the same address do not overlap? (I checked C99 (draft 843) and while it

  1   2   3   4   5   6   7   8   9   >