[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2011-03-18 Thread piccolo2d
Updates: Status: Verified Comment #37 on issue 163 by atdi...@gmail.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Verified issue on Mac OS X 64-bit, Win Vista 32-bit -- Intel Mac Pro. OpenJDK - Intel Dell Dimension. --

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2011-03-07 Thread piccolo2d
Comment #36 on issue 163 by re...@colorado.edu: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 In r1112 I committed: Applied fixes from the piccolo 1.3 branch to trunk, see issue 163 Can huermh or others please verify that the chang

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2011-03-02 Thread piccolo2d
Comment #35 on issue 163 by heue...@gmail.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Looks good to me, please apply to trunk. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-08-25 Thread piccolo2d
Comment #34 on issue 163 by re...@colorado.edu: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Based on huermh's review, we committed r1046: PSwingDynamicComponentTest to examples/pswing and renamed to PSwingDynamicComponentExample.

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-08-25 Thread piccolo2d
Updates: Owner: re...@colorado.edu Comment #33 on issue 163 by heue...@gmail.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Fixed is correct, after review it goes to Verified. And yes, these changes should be copied to t

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-08-25 Thread piccolo2d
Comment #32 on issue 163 by re...@colorado.edu: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 After review of the fixes in r1045, we should discuss whether they should also be copied to trunk. -- Piccolo2D Developers Group: http://

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-08-25 Thread piccolo2d
Comment #31 on issue 163 by re...@colorado.edu: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 In r1045, I committed our fixes to PSwing and PSwingRepaintManager, and also our latest version of TestPSwingDynamicComponent, which has be

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-08-25 Thread piccolo2d
Updates: Status: Fixed Comment #30 on issue 163 by re...@colorado.edu: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 This issue was closed by revision r1045. -- Piccolo2D Developers Group: http://groups.google.com/group/piccol

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-08-25 Thread piccolo2d
Updates: Status: Started Owner: cmal...@pixelzoom.com Labels: Type-Defect Priority-High Effort-Medium OpSys-All Toolkit-Piccolo2D.Java Component-Extras Milestone-1.3.1 Comment #29 on issue 163 by heue...@gmail.com: PSwing doesn't draw dynamic JComponent properly http://code

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-08-25 Thread piccolo2d
Comment #28 on issue 163 by re...@colorado.edu: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 My collaborator cmalley & I resolved issue 163, by fixing PSwing and PSwingRepaintManager. We tested that this resolves the problem in T

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-08-23 Thread piccolo2d
Comment #27 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Yes, Sam Reid and I worked on this and made some good progress. But we have been delinquent in contributing our fixes back to Piccolo.

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-08-23 Thread piccolo2d
Comment #26 on issue 163 by heue...@gmail.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Chris, have you made any additional progress on this issue? -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-09 Thread piccolo2d
Comment #25 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 TestPSwingDynamicComponent has a PSwing wrapping a JPanel, which contains 3 JComponents. I added this debug output to the ComponentListen

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-09 Thread piccolo2d
Comment #24 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 More general issue... I don't understand why we need to explicitly call component.revalidate. When (for example) ComponentListener.comp

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-09 Thread piccolo2d
Comment #23 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 component.revalidate calls PSwingRepaintManager.addInvalidComponent, which calls PSwing.updateBounds. So calls to revalidate will resul

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-08 Thread piccolo2d
Comment #22 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 It's interesting that this bounds problem does not occur with PhET's Piccolo 1.2 snapshot (r390). I recall that we reported some breaki

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-08 Thread piccolo2d
Comment #21 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Committed PSwing r980, forgot to restore one component.revalidate call in constructor. -- You received this message because you are li

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-08 Thread piccolo2d
Comment #20 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Commited PSwing r979. This backs out the component.revalidate added in r978, since it was causing an infinite loop. PSwing should now b

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-08 Thread piccolo2d
Comment #19 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Commited PSwing r979. This backs out the component.repaint added in r978, since it was causing an infinite loop. PSwing should now be b

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-08 Thread piccolo2d
Comment #18 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Backed out the component.repaint added in r979, since it was causing an infinite loop. PSwing should now be back to the state it was in

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-08 Thread piccolo2d
Updates: Status: New Comment #17 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Rats. This is still broken. I've been developing and testing on a very fast MacBook Pro. One of my colleag

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-08 Thread piccolo2d
Comment #16 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 I applied the component.revalidate fix in r978. One thing that I didn't note in the commit message: I opted NOT to remove the Property

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-08 Thread piccolo2d
Comment #15 on issue 163 by ch...@chrismalley.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 I applied the component.revalidate fix in r978. One thing that I didn't note in the commit message: I opted NOT to remove the Property

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-08 Thread piccolo2d
Updates: Status: Fixed Comment #14 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 This issue was closed by revision r978. -- You received this message because you are listed in the owner o

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-05 Thread piccolo2d
Comment #13 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Sorry, I should have been clearer and it was late. Adding component.revalidate() with no other changes to PSwing fixes both the ellipsi

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-05 Thread piccolo2d
Comment #12 on issue 163 by allain.lalonde: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Can't disagree with you regarding the hierarchy listener, I even mentioned the strange behaviour when I made the change. The fact is, it did re

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-04 Thread piccolo2d
Comment #11 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Btw... If we decide to keep the listeners added to component in the constructor, they should really be added in initializeComponent. I

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-04 Thread piccolo2d
Comment #10 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 If I add this call as the first line of PSwing.updateBounds, the problem seems to be resolved: component.revalidate(); I also don't t

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-04 Thread piccolo2d
Comment #9 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 In PSwing r973, a HierarchyBoundsListener was added in the PSwing constructor. The javadoc for this interface says "The listener interfa

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-04 Thread piccolo2d
Comment #8 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Attached is an updated version of TestPSwingDynamicComponent that tests using a JLabel, JCheckBox and JRadioButton. The previous version

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-03-04 Thread piccolo2d
Updates: Status: New Comment #7 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 There's still a problem here. In TestPSwingDynamicComponent, change the type of topLabel and bottomLabel to

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Updates: Status: Verified Comment #6 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Marked as verified. -- You received this message because you are listed in the owner or CC fields of thi

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Comment #5 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Verified that r973 solves the problem, both in TestPSwingDynamicComponent and the PhET application where this was first noticed. Note t

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Updates: Status: Fixed Comment #4 on issue 163 by allain.lalonde: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Fixed in r973 -- You received this message because you are listed in the owner or CC fields of this issue, or beca

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Comment #3 on issue 163 by heue...@gmail.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 On second thought, I might -1 the 1.3-rc3 because of Issue 165, so let's see if we can get this fixed quickly. -- You received this message

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Comment #2 on issue 163 by heue...@gmail.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 I confirm that this happens with 1.3-rc3. If you add TestPSwingDynamicComponent.java, line 64: + piccoloLabelPanel.invalidate(); + piccoloLab

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-25 Thread piccolo2d
Comment #1 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 FYI... This is not a new problem. It happens with our 1.2 snapshot (r390) and 1.3-rc3. So it's the consensus of the PhET team that this