Re: [Piglit] [PATCH 04/11] framework/test/opengl.py: Add FastSkipMixin which checks extensions

On Mon, Jan 4, 2016 at 7:04 PM, Dylan Baker wrote: > Okay. I'm going to push the patch Jose reviewed, and I'll send out a patch > (and CC both of you) that adds an environment variable to turn fast skipping > off. > > If you could, I'd appreciate the output of wflinfo

Re: [Piglit] [Mesa-dev] [PATCH] Add (un)packHalf tests which don't fail on GCN

On Fri, Feb 5, 2016 at 3:56 PM, Roland Scheidegger <srol...@vmware.com> wrote: > Am 05.02.2016 um 15:44 schrieb Marek Olšák: >> On Fri, Feb 5, 2016 at 10:57 AM, Marek Olšák <mar...@gmail.com> wrote: >>> On Fri, Feb 5, 2016 at 1:55 AM, Matt Turner <matts...@gma

Re: [Piglit] [Mesa-dev] [PATCH] Add (un)packHalf tests which don't fail on GCN

On Fri, Feb 5, 2016 at 7:11 PM, Roland Scheidegger <srol...@vmware.com> wrote: > Am 05.02.2016 um 17:04 schrieb Marek Olšák: >> On Fri, Feb 5, 2016 at 4:48 PM, Roland Scheidegger <srol...@vmware.com> >> wrote: >>> Am 05.02.2016 um 16:08 schrieb Marek Olšák:

Re: [Piglit] [Mesa-dev] [PATCH] Add (un)packHalf tests which don't fail on GCN

On Fri, Feb 5, 2016 at 10:57 AM, Marek Olšák <mar...@gmail.com> wrote: > On Fri, Feb 5, 2016 at 1:55 AM, Matt Turner <matts...@gmail.com> wrote: >> On Thu, Feb 4, 2016 at 10:50 AM, Marek Olšák <mar...@gmail.com> wrote: >>> From: Marek Olšák <marek.

[Piglit] [PATCH 1/2] arb_shader_image_size/builtin: don't report subtests that are never run

From: Marek Olšák <marek.ol...@amd.com> this removes a lot of skipped subtests from results --- tests/spec/arb_shader_image_size/builtin.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/tests/spec/arb_shader_image_size/builtin.c b/test

[Piglit] [PATCH 2/2] Remove fs-discard-exit-3

From: Marek Olšák <marek.ol...@amd.com> The test is wrong and the GLSL 1.30 citation in the test states very clearly that discard can cause non-uniform control flow for any code that follows. --- .../execution/fs-discard-exit-3.shader_test| 76 -- 1 file chang

[Piglit] [PATCH] util: probe pixel rectangles as ubyte if possible

From: Marek Olšák <marek.ol...@amd.com> --- tests/util/piglit-util-gl.c | 154 1 file changed, 154 insertions(+) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index dbdfb13..99a396b 100644 --- a/tests/util/piglit-uti

[Piglit] [PATCH 1/3] shader_runner: use static keyword

From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 170 +- 1 file changed, 85 insertions(+), 85 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 8d2a9bd..65f26a0 100644 --- a

[Piglit] [PATCH 2/3] shader_runner: remove unused variable "path"

From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 65f26a0..3d2ab9d 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_ru

[Piglit] [PATCH 3/3] shader_runner: fix a may-be-used-uninitialized warning

From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 3d2ab9d..c41f9d2 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/s

[Piglit] Is piglit not portable? Unicode errors

Hi, I received piglit results from somebody else and can't generate html. Any idea what is wrong? Traceback (most recent call last): File "../piglit/piglit-summary-html.py", line 28, in html(sys.argv[1:]) File "/home/marek/dev/piglit/framework/exceptions.py", line 50, in _inner

Re: [Piglit] [PATCH 2/2] framework/summary/html_.py: Write output files as utf-8 bytes streams

Thank you very much. This fixes the Unicode error for me. For the series: Tested-by: Marek Olšák <marek.ol...@amd.com> Please let me know if you still need the problematic results file. Marek On Fri, Mar 25, 2016 at 10:28 PM, Dylan Baker <baker.dyla...@gmail.com> wrote: >

Re: [Piglit] Is piglit not portable? Unicode errors

On Fri, Mar 25, 2016 at 8:29 PM, Dylan Baker <baker.dyla...@gmail.com> wrote: > errr, sorry for the typo, "that should be which version of piglit you're > running" > > On Fri, Mar 25, 2016 at 12:26 PM, Dylan Baker <baker.dyla...@gmail.com> > wrote: >>

Re: [Piglit] [PATCH] shader_runner: allow GL_MAX_VERTEX_ATTRIBS in requirements (v2)

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Fri, Apr 29, 2016 at 2:20 PM, Andres Gomez <ago...@igalia.com> wrote: > v2: Just use the same query for GL or GLS 2.0 and 3.0 as noted by > Marek Olšák. > > Signed-off-by: Andres Gomez <ago...@igalia.

Re: [Piglit] [PATCH] shader_runner: allow GL_MAX_VERTEX_ATTRIBS in requirements

On Mon, Apr 25, 2016 at 4:03 PM, Andres Gomez wrote: > Signed-off-by: Andres Gomez > --- > tests/shaders/shader_runner.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/tests/shaders/shader_runner.c

Re: [Piglit] Nearly finished: shader_runner running THOUSANDS of tests per process

On Mon, Apr 18, 2016 at 6:45 PM, Dylan Baker <baker.dyla...@gmail.com> wrote: > Quoting Marek Olšák (2016-04-16 15:16:34) >> Hi, >> >> This makes shader_runner very fast. The expected result is 40% >> decrease in quick.py running time, or a 12x faster piglit run

[Piglit] Nearly finished: shader_runner running THOUSANDS of tests per process

Hi, This makes shader_runner very fast. The expected result is 40% decrease in quick.py running time, or a 12x faster piglit run if you run shader tests alone. Branch: https://cgit.freedesktop.org/~mareko/piglit/log/?h=shader-runner Changes: 1) Any number of test files can be specified as

[Piglit] [PATCH] util: probe pixel rectangles as ubyte if possible (v2)

From: Marek Olšák <marek.ol...@amd.com> v2: int -> bool, unify all new functions into one --- tests/util/piglit-util-gl.c | 94 + 1 file changed, 94 insertions(+) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c inde

[Piglit] [PATCH] util: fix regression with ubyte probing

From: Marek Olšák <marek.ol...@amd.com> clearbuffer-mixed-format regressed, because GL_RED_BITS doesn't have anything to do with the read buffer. --- tests/util/piglit-util-gl.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/tests/util/pigli

[Piglit] [PATCH 1/2] util: fix warnings

From: Marek Olšák <marek.ol...@amd.com> --- tests/util/piglit-framework-gl/piglit_wfl_framework.c | 4 +++- tests/util/piglit-shader.c| 1 + tests/util/piglit-util-gl.c | 5 + 3 files changed, 9 insertions(+), 1 deletion(-) diff

[Piglit] [PATCH 2/2] Fix asprintf warnings

From: Marek Olšák <marek.ol...@amd.com> --- tests/general/clipflat.c | 2 +- tests/general/object-namespace-pollution.c | 4 ++-- tests/shaders/built-in-constants.c | 4 ++-- tests/shaders/version-mi

[Piglit] [PATCH 3/4] shader_runner: use enum piglit_result in piglit_display

From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 2f90fee..45ba103 100644 --- a/tests/s

[Piglit] [PATCH 4/4] fs-dfdx/y-accuracy: report warn on failure

From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 6 ++ tests/spec/glsl-1.10/execution/fs-dfdx-accuracy.shader_test | 4 +++- tests/spec/glsl-1.10/execution/fs-dfdy-accuracy.shader_test | 4 +++- 3 files changed, 12 insertions

[Piglit] [PATCH 2/4] ext_framebuffer_multisample_blit_scaled: report warn on failure

From: Marek Olšák <marek.ol...@amd.com> --- tests/spec/ext_framebuffer_multisample_blit_scaled/blit-scaled.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spec/ext_framebuffer_multisample_blit_scaled/blit-scaled.cpp b/test

[Piglit] [PATCH 1/4] oes_fixed_point-attribute-arrays: set window_visual to fix the test under GBM

From: Marek Olšák <marek.ol...@amd.com> --- tests/spec/oes_fixed_point/oes_fixed_point-attribute-arrays.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/oes_fixed_point/oes_fixed_point-attribute-arrays.c b/tests/spec/oes_fixed_point/oes_fixed_point-attribute-arrays.c

[Piglit] [PATCH] initialized-texmemory: report WARN on failure

From: Marek Olšák <marek.ol...@amd.com> The tested behavior is not required by the spec and the test itself claims it reports WARN, so this is a typo. --- tests/security/initialized-texmemory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/security/initi

Re: [Piglit] [PATCH] arb_copy_buffer-intra-buffer-copy: new GL_ARB_copy_buffer test

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Tue, Jun 21, 2016 at 7:18 PM, Brian Paul <bri...@vmware.com> wrote: > To exercise copying within a single buffer. > --- > tests/all.py | 1 + > tests/spec/arb_copy_buffer/

Re: [Piglit] Nearly finished: shader_runner running THOUSANDS of tests per process

On Fri, May 27, 2016 at 7:53 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Marek Olšák (2016-04-16 15:16:34) >> Hi, >> >> This makes shader_runner very fast. The expected result is 40% >> decrease in quick.py running time, or a 12x faster piglit run

[Piglit] [PATCH] glean/fbo: fix GL_LINES vertex coordinates

From: Marek Olšák <marek.ol...@amd.com> The first case had had the change already, but lacked an explanation. See the OpenGL 4.5 Core spec, section 14.5.1, figure 14.2, page 450. --- tests/glean/tfbo.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests

Re: [Piglit] [PATCH] initialized-texmemory: report WARN on failure

On Wed, Jun 29, 2016 at 6:51 PM, Dylan Baker wrote: > Reviewed-by: Dylan Baker > > Maybe a good future change would be to pull these "good security > practices, but not required by the spec" tests into a separate profile > and report fail? In the

[Piglit] [PATCH 2/2] framework: double the number of concurrent tests per core

From: Marek Olšák <marek.ol...@amd.com> This makes piglit 16% faster, because 1 thread per core uses only 85% of the CPU. I don't know why the CPU is idle at times, but I guess it's due to waiting for fences. --- framework/profile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Piglit] [PATCH 1/2] framework: handle UnicodeDecodeError

From: Marek Olšák <marek.ol...@amd.com> this happened to me once --- framework/test/base.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/framework/test/base.py b/framework/test/base.py index 4e7c8b2..756b08a 100644 --- a/framework/test/base.py +++ b/framework/test/base.py @@ -

Re: [Piglit] [PATCH 1/2] framework: handle UnicodeDecodeError

On Mon, Feb 6, 2017 at 11:10 PM, Dylan Baker wrote: > I'm curious when you're hitting this because while this works around the > problem > it's not really fixing it, and I'd really like to fix it correctly. I don't remember. I guess the stdout/stderr output contained some

Re: [Piglit] [PATCH] primitive-restart: Delete more glDrawArrays tests.

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Wed, Feb 22, 2017 at 2:53 AM, Kenneth Graunke <kenn...@whitecape.org> wrote: > This interprets the new GL 4.5 rules (don't do primitive restart for > non-indexed-draws) as a clarification, even for the old NV tests. > &

[Piglit] [PATCH] draw-elements: test glMultiDrawElements(GL_UNSIGNED_BYTE)

From: Marek Olšák <marek.ol...@amd.com> this was broken in radeonsi --- tests/general/draw-elements.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/tests/general/draw-elements.c b/tests/general/draw-elements.c index 29436cf..d

[Piglit] [PATCH] arb_texture_view/rendering-formats: test all combinations of all formats

From: Marek Olšák <marek.ol...@amd.com> Almost. Everything is tested except these: - SRGB8_ALPHA8 - SRGB8 - R11G11B10_FLOAT - R5G5B5E9_FLOAT - compressed formats Both texturing and rendering are tested. There are 800+ subtests. --- tests/spec/arb_texture_view/rendering-formats.c

Re: [Piglit] [PATCH] framework: fix binary assignment for shader_runner

On Wed, Aug 10, 2016 at 7:42 PM, Dylan Baker wrote: > I've pushed this with Michel's Tested by, since piglit is broken without > this. If anyone else has issues we can fix them in new patches. Actually, the patch breaks piglit here. Reverting the patch fixes the problem for

[Piglit] [PATCH] arb_texture_view/rendering-formats: test glClear(1, 1, 1, 1) w/ texture views

From: Marek Olšák <marek.ol...@amd.com> needed to exercise radeonsi codepaths --- tests/spec/arb_texture_view/rendering-formats.c | 570 +++- 1 file changed, 559 insertions(+), 11 deletions(-) diff --git a/tests/spec/arb_texture_view/rendering-formats.c b/test

Re: [Piglit] [PATCH] cts_gl.py: only generate tests for GL45-CTS

On Mon, Sep 12, 2016 at 3:33 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 9 September 2016 at 14:10, Marek Olšák <mar...@gmail.com> wrote: >> From: Marek Olšák <marek.ol...@amd.com> >> >> Older versions don't work and there is no interest in fixing

Re: [Piglit] [PATCH 12/15] squash! shader_runner: add ability to run multiple tests per process

On Sat, Sep 10, 2016 at 1:33 PM, Nicolai Hähnle wrote: > On 09.09.2016 21:18, Dylan Baker wrote: >> >> Bug fixes from me for the above patch. >> >> I've split these out to make them easier to review. Before merging to >> master this will be squashed into the previous patch. >>

Re: [Piglit] [PATCH 15/15] framework: add boilerplate to turn off process isolation

On Fri, Sep 9, 2016 at 9:18 PM, Dylan Baker wrote: > This adds a switch to to turn off process isolation (it is normally on), > for now this only affects shader_runner, but in the future could affect > more tests, like glslparsertest or dEQP. > > Signed-off-by: Dylan Baker

Re: [Piglit] [PATCH 6/15] shader_runner: propagate all errors to piglit_init

On Sat, Sep 10, 2016 at 1:25 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > On 09.09.2016 21:18, Dylan Baker wrote: >> >> From: Marek Olšák <marek.ol...@amd.com> >> >> piglit_report_result prevents running multiple tests per process. >>

Re: [Piglit] [PATCH 0/15] Add support for shader_runner to run more than one test per process

On Tue, Sep 13, 2016 at 11:12 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Dylan Baker (2016-09-13 13:46:11) >> Quoting Marek Olšák (2016-09-13 13:27:21) >> > On Tue, Sep 13, 2016 at 8:30 PM, Dylan Baker <dy...@pnwbakers.com> wrote: >> > > So

Re: [Piglit] [PATCH 0/15] Add support for shader_runner to run more than one test per process

On Tue, Sep 13, 2016 at 8:30 PM, Dylan Baker wrote: > So, there were a few comments I've addressed, and Marek acked one patch. > Do y'all want to see a v2, or should I just push this? There are at least 2 piglit regressions with --process-isolation 0:

Re: [Piglit] [PATCH] cts_gl.py: only generate tests for GL45-CTS

On Sep 10, 2016 4:42 PM, "Alejandro Piñeiro" <apinhe...@igalia.com> wrote: > > > On 10/09/16 15:39, Marek Olšák wrote: > > On Sat, Sep 10, 2016 at 2:41 PM, Alejandro Piñeiro <apinhe...@igalia.com> wrote: > >> On 09/09/16 15:10, Marek Olšák wrote

Re: [Piglit] [PATCH v2 0/16] Add support for shader_runner to run more than one test per process

> squash! shader_runner: add ability to run multiple tests per process > framework: Add class for running multiple shader_tests in a single process > framework: Plug in fast-skipping to MultiShaderTest > framework: add boilerplate to turn off process isolation > > Marek Olšák (6):

Re: [Piglit] [PATCH v2 13/16] squash! shader_runner: add ability to run multiple tests per process

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Fri, Sep 30, 2016 at 11:17 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > These are changes since version 1, again split out for easier review. > > - use glClearDepthf for GL ES instead of glClearDepth, which doesn

[Piglit] [PATCH 1/2] shader_runner: add commands to set wrap modes and border color

From: Marek Olšák <marek.ol...@amd.com> Everybody loves border colors! --- tests/shaders/shader_runner.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index fc0de88..1070998 100644 --- a

[Piglit] [PATCH 2/2] arb_compute_shader: test the texture border color

From: Marek Olšák <marek.ol...@amd.com> This fails with radeonsi at the moment. --- .../execution/border-color.shader_test | 36 ++ 1 file changed, 36 insertions(+) create mode 100644 tests/spec/arb_compute_shader/execution/border-color.shader_test diff

[Piglit] [PATCH] glsl-1.10/fs-texture-select: new test for a radeonsi bug

From: Marek Olšák <marek.ol...@amd.com> --- .../execution/fs-texture-select.shader_test| 34 ++ 1 file changed, 34 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/fs-texture-select.shader_test diff --git a/tests/spec/glsl-1.10/execution/fs-t

Re: [Piglit] [PATCH] framework: fix binary assignment for shader_runner

On Tue, Aug 23, 2016 at 7:48 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Marek Olšák (2016-08-23 00:48:03) >> On Tue, Aug 23, 2016 at 2:24 AM, Michel Dänzer <mic...@daenzer.net> wrote: >> > On 22/08/16 11:11 PM, Marek Olšák wrote: >> >> On Wed

Re: [Piglit] [PATCH] framework: fix binary assignment for shader_runner

On Tue, Aug 23, 2016 at 7:57 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Marek Olšák (2016-08-23 10:53:34) >> On Tue, Aug 23, 2016 at 7:48 PM, Dylan Baker <dy...@pnwbakers.com> wrote: >> > Quoting Marek Olšák (2016-08-23 00:48:03) >> >> On T

[Piglit] [PATCH] Add profile cts_gl45

From: Marek Olšák <marek.ol...@amd.com> Older versions are broken at the moment and I don't find them useful anyway. This also creates the test list faster. --- tests/cts_gl45.py | 68 +++ 1 file changed, 68 insertions(+) create mode

[Piglit] Piglit is broken

Hi, Piglit has started failing at startup. Not sure why. I'm not able to find a good commit. Command: PIGLIT_NO_FAST_SKIP=1 \ ./piglit run --process-isolation 0 -p gbm quick Traceback (most recent call last): File "./piglit", line 174, in main() File "./piglit", line 166, in main

Re: [Piglit] [PATCH 06/18] shader_runner: Refactor handling of fb commands.

On Wed, Oct 19, 2016 at 1:36 AM, Francisco Jerez wrote: > This refactors the implementation of the various "fb" commands to be > part of a single 'if (parse_str(line, "fb ", ...)) {}' block in order > to make code-sharing easier among fb subcommands. Will be more useful >

Re: [Piglit] [PATCH 06/18] shader_runner: Refactor handling of fb commands.

uld probably also lead to FBO object leaks. >> >> No idea what's causing the failures, but releasing the FBO should be >> really easy at the end of that block. >> > > Does the attached patch fix the problem for you? I didn't get a full > piglit run to work with -

Re: [Piglit] [PATCH 06/18] shader_runner: Refactor handling of fb commands.

On Wed, Nov 9, 2016 at 8:10 PM, Francisco Jerez <curroje...@riseup.net> wrote: > Marek Olšák <mar...@gmail.com> writes: > >> On Wed, Oct 19, 2016 at 1:36 AM, Francisco Jerez <curroje...@riseup.net> >> wrote: >>> This refactors the implementatio

Re: [Piglit] [PATCH] framework/test/shader_test: Fix MultiShaderRunner handling of directories

Tested-by: Marek Olšák <marek.ol...@amd.com> Marek On Wed, Nov 9, 2016 at 12:51 AM, Dylan Baker <dy...@pnwbakers.com> wrote: > Currently MultiShaderRunner (used with --process-isolation false) > expects each directory will contain either GL, GLES2, or GLES3 shaders. > The

[Piglit] [PATCH] literal-varyings: new test for a radeonsi optimization

From: Marek Olšák <marek.ol...@amd.com> --- .../execution/literal-varyings.shader_test | 43 ++ 1 file changed, 43 insertions(+) create mode 100644 tests/spec/glsl-1.20/execution/literal-varyings.shader_test diff --git a/tests/spec/glsl-1.20/execution/l

Re: [Piglit] [PATCH 2/2] arb_gpu_shader_fp64: add some inout function argument tests

For the series: Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Mon, Oct 17, 2016 at 7:21 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > From: Nicolai Hähnle <nicolai.haeh...@amd.com> > > This exposes a bug in st_glsl_to_tgsi. > --- > .../execution/fs

Re: [Piglit] [PATCH] glsl-1.20: test declaring gl_Position with the invariant qualifier.

If it's just a linker test, the draw call is unnecessary. I think this can be used instead: [test] link success Whether or not you use that fix: Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Wed, Oct 19, 2016 at 1:28 AM, Brian Paul <bri...@vmware.com> wrote: > To exerc

Re: [Piglit] [PATCH 1/2] framework: change 'regressions' to mean 'regressions in the last test run'

On Mon, Oct 24, 2016 at 8:09 PM, Dylan Baker wrote: > I agree with Ilia that making regressions and fixes non-symmetric is bad. So > at > the very least I'd want to see the same change to fixes. > > The regressions page was designed that someone could run piglit using "git >

Re: [Piglit] [PATCH] Add glsl-1.50/execution/geometry/gs-conditional-emit

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Thu, Nov 17, 2016 at 11:22 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > From: Nicolai Hähnle <nicolai.haeh...@amd.com> > > This test exposes a subtle bug in st_glsl_to_tgsi. I found this bug while > in

Re: [Piglit] [PATCH] fbo-clear-formats: Do one of the 4 clears unscissored.

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Sat, Oct 15, 2016 at 1:36 AM, Eric Anholt <e...@anholt.net> wrote: > I was surprised to find through DEQP that 565 clearing was broken on > vc4, but that was because fbo-clear-formats never hit the hardware > clear

Re: [Piglit] [PATCH 2/2] glsl-1.30: add a test that gl_ClipDistance actually affects all primitive types

For the series: Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Thu, Dec 15, 2016 at 4:38 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > From: Nicolai Hähnle <nicolai.haeh...@amd.com> > > Exposes a bug on radeonsi for the points case. &g

Re: [Piglit] [PATCH] arb_vertex_attrib_64bit: remove piglit_ortho_projection() call

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Wed, Mar 29, 2017 at 9:59 PM, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > This is supported by compat only. > > Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> > --- > tests/spec/

[Piglit] [PATCH 3/8] arb_tessellation_shader/execution/sanity2: new variant of the test

From: Marek Olšák <marek.ol...@amd.com> --- .../execution/sanity2.shader_test | 65 ++ 1 file changed, 65 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/sanity2.shader_test diff --git a/tests/spec/arb_tessellation_

[Piglit] [PATCH 1/8] glsl-1.50: new trivial GS test

From: Marek Olšák <marek.ol...@amd.com> --- .../glsl-1.50/execution/gs-trivial.shader_test | 44 ++ 1 file changed, 44 insertions(+) create mode 100644 tests/spec/glsl-1.50/execution/gs-trivial.shader_test diff --git a/tests/spec/glsl-1.50/execut

[Piglit] [PATCH 5/8] arb_enhanced_layouts/component-layout: require GLSL 1.50

From: Marek Olšák <marek.ol...@amd.com> --- .../linker/component-layout/fs-out-array.shader_test| 2 +- .../linker/component-layout/fs-out-overlap2.shader_test | 2 +- .../linker/component-layout/fs-out-overlap3.shader_test | 2 +- .../

[Piglit] [PATCH 4/8] arb_blend_func_extended/output-location: require GLSL 1.50

From: Marek Olšák <marek.ol...@amd.com> --- tests/spec/arb_blend_func_extended/api/output-location.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_blend_func_extended/api/output-location.c b/tests/spec/arb_blend_func_extended/api/output-location.c index 1fc9203..4

[Piglit] [PATCH 2/8] arb_tessellation_shader/execution/trivial: new trivial tess test

From: Marek Olšák <marek.ol...@amd.com> --- .../execution/trivial.shader_test | 54 ++ 1 file changed, 54 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/trivial.shader_test diff --git a/tests/spec/arb_tessellation_

[Piglit] [PATCH 7/8] arb_shader_draw_parameters: require GLSL 3.30

From: Marek Olšák <marek.ol...@amd.com> --- tests/spec/arb_shader_draw_parameters/basevertex.c | 2 +- tests/spec/arb_shader_draw_parameters/drawid-indirect.c | 2 +- tests/spec/arb_shader_draw_parameters/drawid.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff

[Piglit] [PATCH 6/8] arb_separate_shader_objects/atomic-counter: require GLSL 1.50

From: Marek Olšák <marek.ol...@amd.com> --- tests/spec/arb_separate_shader_objects/atomic-counter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_separate_shader_objects/atomic-counter.c b/tests/spec/arb_separate_shader_objects/atomic-counter.c index 4e54c8e..d6845b7

[Piglit] [PATCH 8/8] tests/egl: report 'skip' instead of 'fail' if not running under X

From: Marek Olšák <marek.ol...@amd.com> --- tests/egl/egl-configless-context.c | 2 +- tests/egl/egl-util.c | 3 +-- tests/egl/spec/egl_ext_client_extensions/egl_ext_client_extensions.c | 2 +- tests/eg

Re: [Piglit] [PATCH 3/8] arb_tessellation_shader/execution/sanity2: new variant of the test

n, Apr 10, 2017 at 5:01 PM, Marek Olšák <mar...@gmail.com> wrote: >> From: Marek Olšák <marek.ol...@amd.com> >> >> --- >> .../execution/sanity2.shader_test | 65 >> ++ >> 1 file changed, 65 insertions(+) >>

Re: [Piglit] [PATCH 2/8] arb_tessellation_shader/execution/trivial: new trivial tess test

On Tue, Apr 11, 2017 at 6:20 PM, Marek Olšák <mar...@gmail.com> wrote: > On Tue, Apr 11, 2017 at 4:39 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >> On Tue, Apr 11, 2017 at 5:08 AM, Marek Olšák <mar...@gmail.com> wrote: >>> >>> >>> On Apr

Re: [Piglit] [PATCH 2/8] arb_tessellation_shader/execution/trivial: new trivial tess test

On Tue, Apr 11, 2017 at 4:39 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Tue, Apr 11, 2017 at 5:08 AM, Marek Olšák <mar...@gmail.com> wrote: >> >> >> On Apr 10, 2017 11:11 PM, "Ilia Mirkin" <imir...@alum.mit.edu> wrote: >&g

Re: [Piglit] [PATCH 3/8] arb_tessellation_shader/execution/sanity2: new variant of the test

On Tue, Apr 11, 2017 at 6:52 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Tue, Apr 11, 2017 at 12:17 PM, Marek Olšák <mar...@gmail.com> wrote: >> On Mon, Apr 10, 2017 at 11:12 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >>> This appears t

Re: [Piglit] [PATCH 2/8] arb_tessellation_shader/execution/trivial: new trivial tess test

r name. That's a really bad name, because it doesn't tell me that the test is trivial. See, I didn't even bother checking what patch-pair-verts.shader_test does. Bad name. Marek On Mon, Apr 10, 2017 at 5:01 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.c

[Piglit] [PATCH] arb_tessellation_shader: new tests for a radeonsi bug

From: Marek Olšák <marek.ol...@amd.com> --- .../execution/16in-1out.shader_test| 76 ++ .../execution/1in-1out.shader_test | 72 2 files changed, 148 insertions(+) create mode 100644 tests/spec/arb_tessellation_

[Piglit] [PATCH] glx-multithread-clearbuffer: new test reproducing amdgpu CS thread deadlock

From: Marek Olšák <marek.ol...@amd.com> --- tests/all.py| 1 + tests/glx/CMakeLists.gl.txt | 2 + tests/glx/glx-multithread-clearbuffer.c | 100 3 files changed, 103 insertions(+) create mode 100644 tests/g

[Piglit] [PATCH] Remove a useless GLU depedency

From: Marek Olšák <marek.ol...@amd.com> --- tests/spec/arb_arrays_of_arrays/CMakeLists.gl.txt | 1 - tests/spec/arb_gpu_shader_fp64/shader_storage/CMakeLists.gl.txt | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/spec/arb_arrays_of_arrays/CMakeLists.gl.txt b/test

Re: [Piglit] [PATCH] glx-multithread-clearbuffer: Check pthread_join return value.

If you do what Brian said: Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Tue, Jul 25, 2017 at 2:42 AM, Vinson Lee <v...@freedesktop.org> wrote: > Fix Coverity unchecked return value defect. > > CID: 1415101 > Signed-off-by: Vinson Lee <v...@freedesktop.

[Piglit] [PATCH 2/6] shader_runner: add "draw instanced rect ortho" commands

From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index b2eeba8..f82332c 100644 --- a/tests/shaders/shader_runner.c +++ b

[Piglit] [PATCH 4/6] glsl-1.50: test instancing with a geometry shader

From: Marek Olšák <marek.ol...@amd.com> --- .../glsl-1.50/execution/gs-instance-id.shader_test | 58 ++ 1 file changed, 58 insertions(+) create mode 100644 tests/spec/glsl-1.50/execution/gs-instance-id.shader_test diff --git a/tests/spec/glsl-1.50/execution/gs-in

[Piglit] [PATCH 3/6] arb_tessellation_shader: test instancing

From: Marek Olšák <marek.ol...@amd.com> --- .../execution/tess-instance-id.shader_test | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/tess-instance-id.shader_test diff --git a/test

[Piglit] [PATCH 5/6] arb_tessellation_shader: add 3 new trivial tess+gs tests

From: Marek Olšák <marek.ol...@amd.com> --- .../execution/trivial-tess-gs.shader_test | 56 ++ .../trivial-tess-gs_no-gs-inputs.shader_test | 60 +++ .../trivial-tess-gs_no-tes-inputs.shader_test | 67 ++ 3 files c

[Piglit] [PATCH 6/6] arb_compute_shader: test shaders when only 1 channel of gl_WorkGroupID is used

From: Marek Olšák <marek.ol...@amd.com> --- .../execution/basic-group-id-x.shader_test | 56 ++ .../execution/basic-group-id-y.shader_test | 56 ++ .../execution/basic-group-id-z.shader_test | 56 ++ 3

Re: [Piglit] [PATCH] drawoverhead: new microbenchmark

On Thu, May 11, 2017 at 9:49 PM, Eric Anholt <e...@anholt.net> wrote: > Marek Olšák <mar...@gmail.com> writes: > >> From: Marek Olšák <marek.ol...@amd.com> >> >> Based on a benchmark from mesa/demos, but rewritten and extended. >> It's a benchmark

Re: [Piglit] [PATCH] tests: Update integration for khronos CTS runner.

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Mon, May 15, 2017 at 5:13 PM, Andres Gomez <ago...@igalia.com> wrote: > After: > https://github.com/KhronosGroup/VK-GL-CTS/commit/af8c22a343ee2c230488f6de71b36dc3070b2024 > > OpenGL GL*-CTS case lists hav

[Piglit] [PATCH 4/4] drawoverhead: test 8 UBOs instead of 4

From: Marek Olšák <marek.ol...@amd.com> --- tests/perf/drawoverhead.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/perf/drawoverhead.c b/tests/perf/drawoverhead.c index fa6e1bb..429375f 100644 --- a/tests/perf/drawoverhead.c +++ b/tests/perf/drawover

[Piglit] [PATCH 2/4] drawoverhead: fix primitive restart testing for GL Compatibility

From: Marek Olšák <marek.ol...@amd.com> --- tests/perf/drawoverhead.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/tests/perf/drawoverhead.c b/tests/perf/drawoverhead.c index 7dff1b4..4e04a05 100644 --- a/tests/perf/drawoverhead.c +++ b/test

[Piglit] [PATCH 1/4] drawoverhead: test TBO state changes

From: Marek Olšák <marek.ol...@amd.com> --- tests/perf/drawoverhead.c | 196 +++--- 1 file changed, 149 insertions(+), 47 deletions(-) diff --git a/tests/perf/drawoverhead.c b/tests/perf/drawoverhead.c index bedaecb..7dff1b4 100644 --- a/test

[Piglit] [PATCH 3/4] drawoverhead: test images and image buffers

From: Marek Olšák <marek.ol...@amd.com> --- tests/perf/drawoverhead.c | 206 +- 1 file changed, 185 insertions(+), 21 deletions(-) diff --git a/tests/perf/drawoverhead.c b/tests/perf/drawoverhead.c index 4e04a05..fa6e1bb 100644 --- a/test

Re: [Piglit] [PATCH 1/1] cmake: bump gbm dependency to 17.1

Reviewed-by: Marek Olšák <marek.ol...@amd.com> On Jun 22, 2017 3:52 PM, "Jan Vesely" <jan.ves...@rutgers.edu> wrote: > c6e1dc5247 switched to use gbm_bo_get_offset and > gbm_bo_get_stride_for_plane. > These symbols were added in mesa 17.1. Since there is no al

Re: [Piglit] [PATCH] piglit_drm_dma_buf: fix the stride

On Mon, Jun 19, 2017 at 6:06 PM, Eric Anholt <e...@anholt.net> wrote: > Marek Olšák <mar...@gmail.com> writes: > >> From: Marek Olšák <marek.ol...@amd.com> >> >> dst_stride is from gbm_bo_map (CPU mapping), but we need the real stride. >> Th

[Piglit] [PATCH] piglit_drm_dma_buf: fix GPU offsets and strides

From: Marek Olšák <marek.ol...@amd.com> Most of the original code is simply wrong. This patch makes sure that at least the returned GPU offsets and strides are correct. This doesn't fix the incorrect CPU upload path for non-zero planes. GBM doesn't seem to have the capability to map a sp

Re: [Piglit] [PATCH] arb_texture_view: add simple test for rendering to R32UI texture view

Pushed, thanks! Marek On Tue, May 30, 2017 at 3:28 PM, Józef Kucia wrote: > This test exposes a Radeonsi driver bug. > > The test works on Nvidia binary driver and Mesa Intel (Broadwell). > It fails on Radeonsi with Cape Verde GPU. > --- > tests/all.py

Re: [Piglit] [PATCH] drawoverhead: use GL_TRIANGLES instead of GL_POINTS

I've re-tested radeonsi vs i965. radeonsi is 7.21x faster now, but there may be other GPU overheads (e.g. draw rate, command buffer fetch rate, etc.) Marek On Thu, Jun 8, 2017 at 12:35 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com>

[Piglit] [PATCH] drawoverhead: use GL_TRIANGLES instead of GL_POINTS

From: Marek Olšák <marek.ol...@amd.com> Triangles are degenerate and therefore culled. Points weren't. This decreases the likelihood of being GPU-bound. I might re-do the radeonsi vs i965 comparison with this. --- tests/perf/drawoverhead.c | 36 ++--

<    1   2   3   4   5   6   >