Re: [pkg-go] continuity_0.0~git20180216.d8fb858-1_amd64.changes REJECTED
On 04/11/2018 11:00 PM, Luke Faraone wrote: > Maintainer, > >> Files: * >> Copyright: 2015 containerd >> License: Apache-2.0 > If there is a license, than somebody has to grant this license. Upstream > contains no copyright statements, prod them to clarify? Thanks, actually we had the same problem with other packages from containerd, and they were very quick to clarify the copyright. Somehow I forgot to check continuity. I opened an issue upstream. Regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] DebConf18 - Anyone planning to go?
Dear Go Packaging team, is there anyone who plan to attend DebConf 2018 in Taiwan? I'd like to be there and maybe submit a talk about Go packaging. If anyone else have the same plan, it's time to talk about it :) Regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#894862: dh-golang: DH_GOPKG is empty in debian/rules, while documentation states that it's automatically set
Package: dh-golang Version: 1.34 Severity: normal Dear Maintainer, According to `man dh-golang`: "DH_GOPKG" (string) contains the Go package name which this Debian package is building. "DH_GOPKG" is automatically set to the value of the first import path of the "XS-Go-Import-Path" "debian/control" field, which can contain several comma-separated import paths. However, I tried to use this variable in the debian/rules file, in targets such as `override_dh_auto_test` and `override_dh_auto_build`, and this variable is empty. I added some debug to dh-golang, and I clearly see the code from `_set_dh_gopkg` being executed, and the variable is set there. So it looks like the environment in `debian/rules` is unrelated to the environment that is set by dh-golang. If it's expected, then maybe the man page needs a little rewording. If it's not expected, then it's a bug? Regards, Arnaud -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 4.13.0-1-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages dh-golang depends on: ii debhelper 11.1.5 ii dpkg 1.19.0.5 ii libdpkg-perl 1.19.0.5 ii perl 5.26.1-5 dh-golang recommends no packages. dh-golang suggests no packages. -- no debconf information ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] [Docker-maint] Guidance for packaging Docker for Debian
On 03/23/2018 08:57 PM, Ian Campbell wrote: > On Fri, 2018-03-23 at 10:35 +, Ian Campbell wrote: >> I think a bunch of the problems you are having are with the build of >> the `swarmd` binary. > I finally realised that the swarmkit→container dep was only for the > unmaintained containerd executor (this was very dense of me since I > wrote it way back in the mists of time...). > > I think the right answer will eventually be: > https://github.com/docker/swarmkit/pull/2568 > > Ian. > Many thanks for all your explications! I see that the PR was merged already, I will update my package and keep you informed. Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] [Docker-maint] Guidance for packaging Docker for Debian
On 03/22/2018 03:52 PM, Ian Campbell wrote: > I wasn't aware of that, how strange. I suppose the rationale is that > v1.1 will be upwards compatible with v1.0, but still... > > I'll mention this to some folks internally and see what, if anything, > can be done. Cool, thanks for relaying the information ! For more details, the error I get when trying to build swarmkit against containerd v1.0.2 is: # github.com/docker/swarmkit/agent/exec/containerd src/github.com/docker/swarmkit/agent/exec/containerd/adapter.go:101:35: undefined: cio.NewAttach src/github.com/docker/swarmkit/agent/exec/containerd/adapter.go:101:49: undefined: cio.WithStreams src/github.com/docker/swarmkit/agent/exec/containerd/adapter.go:249:12: undefined: cio.Opt src/github.com/docker/swarmkit/agent/exec/containerd/adapter.go:251:23: undefined: cio.WithTerminal src/github.com/docker/swarmkit/agent/exec/containerd/adapter.go:253:41: undefined: cio.NewCreator And the nasty commit that broke the containerd/cio API is: https://github.com/containerd/containerd/commit/7d4337e73871d6093cb6e68c78a3b545c4dce871 Regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] [Docker-maint] Guidance for packaging Docker for Debian
On 03/16/2018 04:43 PM, Ian Campbell wrote: >>>> In an ideal world, we should try to convince the docker people to use >>>> stable APIs (that means using only released non-alpha versions!), >>> FWIW the engine uses a non-alpha version in recent releases. It seems >>> to be swarmkit (another dep of engine) which is lagging and using the >>> alpha version (kind of interesting that that code seems to be ok when >>> vendored into moby but apparantly not when standalone, I suppose they >>> use different subsets of the API in different ways). >> Very interesting point indeed. For more details, here are the versions >> of containerd vendored by docker: >> >> - docker-engine (ie moby): 3fa104f (after v1.0.0) >> - docker-swarmkit: 29a4dd7 (somewhere between v1.0.0 alpha3 and alpha4) >> >> Having both in sync would help for sure. > I prodded some folks yesteday a lo: > https://github.com/docker/swarmkit/pull/2560 Hey Iann, I noticed that the pull request you mentioned was merged yesterday in Docker Swarmkit. So I gave it a try today, I updated my swarmkit package and tried to build against the latest stable version of containerd, `1.0.2` at the time of this writing. Of course, it didn't work ;) Swarmkit wants parts of the containerd API that don't exist, and it started giving me a headache, until I realized what's going on. Containerd has a branch 'release/1.0', and that's where the stable version 1.0 is developed. However, Docker vendors a commit from the branch 'master', ie. where the unstable version lives. So, even though this commit is after '1.0', it contains some part of the API that will be released in containerd '1.1' I guess, and therefore I'm stuck again with the same choice: either I package a specific version of containerd for docker, either I wait for a '1.1' release of containerd, in the hope that Docker can build against it. But it's very likely that it won't because containerd will be too new then, so I will have to wait for Docker to update its vendoring bits, and so on, a hopeless and endless cycle. So, in short, it's great that containerd tags its release and has a stable branch, but it's too bad Docker doesn't use it... Cheers, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Accepted golang-github-containerd-cgroups 0.0~git20180223.d578e4e-2 (source) into unstable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Tue, 20 Mar 2018 17:19:07 +0700 Source: golang-github-containerd-cgroups Binary: golang-github-containerd-cgroups-dev Architecture: source Version: 0.0~git20180223.d578e4e-2 Distribution: unstable Urgency: medium Maintainer: Debian Go Packaging Team <pkg-go-maintainers@lists.alioth.debian.org> Changed-By: Arnaud Rebillout <arnaud.rebill...@collabora.com> Description: golang-github-containerd-cgroups-dev - cgroups package for Go Changes: golang-github-containerd-cgroups (0.0~git20180223.d578e4e-2) unstable; urgency=medium . [ Arnaud Rebillout ] * Fix mistake in debian copyright . [ Michael Stapelberg ] * update debian/gitlab-ci.yml (using salsa.debian.org/go-team/ci/cmd/ci) * update debian/gitlab-ci.yml (using salsa.debian.org/go-team/ci/cmd/ci) . [ Arnaud Rebillout ] * Remove shlibs:Depends from the library package * Fix copyright Checksums-Sha1: 1c55b53fe29d493c941a1c31fb56bad71a07c534 2639 golang-github-containerd-cgroups_0.0~git20180223.d578e4e-2.dsc f026ea0a5ec054cac77b26724728e94dd1415d90 2528 golang-github-containerd-cgroups_0.0~git20180223.d578e4e-2.debian.tar.xz f9b389e9dd7b6c40c353c2f2eb09e6bf6697a35c 7479 golang-github-containerd-cgroups_0.0~git20180223.d578e4e-2_amd64.buildinfo Checksums-Sha256: afc3d26b3b0c7707178bed75a71e1351bdc2dcfaeeeb3032cbce9f47fe14ffb5 2639 golang-github-containerd-cgroups_0.0~git20180223.d578e4e-2.dsc da8ad304ed1e48bfc9379a99b77cbc4b4e7a432ef0eedc8f365e1f285d172fa7 2528 golang-github-containerd-cgroups_0.0~git20180223.d578e4e-2.debian.tar.xz 1805306a25bbc486b16c9f24f412326f1411b328c1987f5d2697892d016214a2 7479 golang-github-containerd-cgroups_0.0~git20180223.d578e4e-2_amd64.buildinfo Files: 2689b2078665f841f315873112fd92be 2639 devel optional golang-github-containerd-cgroups_0.0~git20180223.d578e4e-2.dsc e1397aca05eb41f3f5d467343ae16f56 2528 devel optional golang-github-containerd-cgroups_0.0~git20180223.d578e4e-2.debian.tar.xz 17a679ede88a20cec909861d3a6b60ce 7479 devel optional golang-github-containerd-cgroups_0.0~git20180223.d578e4e-2_amd64.buildinfo -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEQk4U1wPnxtQ9nW82TnFg7UrI7h0FAlqyDcgACgkQTnFg7UrI 7h09YBAAz8jgTrvsZ1bnC3f2zh6adsKTrwVxDuu4K4Nzetvn2gFZ/PsbTZL8Rp2f KZnlsQevjtYM5nEq6do1gHOrWd9WlQxIavQbo0Cq/wnv23j4qw0AKEvePlE08X/M xLLy2wBC8A089LFIyDNSXP7V8EKbq9vsGZPdujQVjZfEzbEmhMN1SwJ9KcutyXHu TO0AoIRNd6MkW6P7Zmtcp3SuwjUaB4fiv8Bsp0I0OBcjsYE/j6iTeKcZ6+bm9L57 Cf1orVzdzyc6w04kkCJ4mYRf0LFubDg/MPnr53SpIHtH+5cMYBu1isdTdViqKpsL +F2MzWW7igRGr2mZRbwKV3ExzZouqP2ejj89DQAO5SmUuJ4/YnLhg22vkgCRtP0n jcgr0zCIGVhh8E51KRZQ4hCkoDdUZfvYP35IjyMpcOSWuMWfK/0/oPjjI/4yynlR Pw9MeObcOxJLC2iCwvPFDsvWqLa/1n9dvOuKEH9tsHXJW7wUniN3u8gXFa+Fa3lN v497Hs0gB8LfjhoA4k6ntYaOl1knPVZ34UEmqOan+Tq1V3dYvZCyK/ToKNVLbBSP pzv7IJxi3vPAdd3eLRIuAF/bAVGlKnF36DPQZhW09AoFoYSeuyvtePsJJ5rL9Y3c CiLabG68SMHWaZq5cq3uJP8Tuy4cPHJBX5G9StPtEeJm4bKjwa4= =fwpy -END PGP SIGNATURE- ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review - containerd and dependencies
On 03/21/2018 03:12 PM, Arnaud Rebillout wrote: > > On 03/21/2018 02:55 PM, Michael Stapelberg wrote: >> >> >> On Tue, Mar 20, 2018 at 11:59 AM, Arnaud Rebillout >> <arnaud.rebill...@collabora.com >> <mailto:arnaud.rebill...@collabora.com>> wrote: >> >> >> On 03/20/2018 02:36 PM, Michael Stapelberg wrote: >>> >>> >>> Uploaded. >>> >>> >>> >>> >>> PULL - there are a few changes >>> >>> <https://salsa.debian.org/elboulangero-guest/containerd> >>> <https://salsa.debian.org/elboulangero-guest/containerd> >>> >>> >>> I’ll hold off with this one until the build-deps are satisfied. >>> >>> By the way, do you want to include the most recent commits in >>> the debian/changelog entry? >> >> Yep sure, I just updated the changelog and pushed it all. >> >> >> I can’t seem to build this >> because >> https://tracker.debian.org/pkg/golang-github-opencontainers-image-spec >> is broken, and I’m not entirely sure why/how to fix it. Any hints >> welcome. > > I think I know. The pristine-tar branch is missing a commit, compared > to the upstream branch. My tree at > https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec > has it all, so if you merge everything to the alioth git repo, I guess > that should fix the issue. > > Notice however that I issued a changelog entry ending with `-2`, I > didn't notice that the `-1` package didn't exist. I don't know if it's > a problem. BTW I just pushed a last commit at https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec that really address this issue, ie. fix the gbp configuration, if my understanding is correct. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review - containerd and dependencies
On 03/21/2018 02:55 PM, Michael Stapelberg wrote: > > > On Tue, Mar 20, 2018 at 11:59 AM, Arnaud Rebillout > <arnaud.rebill...@collabora.com > <mailto:arnaud.rebill...@collabora.com>> wrote: > > > On 03/20/2018 02:36 PM, Michael Stapelberg wrote: >> >> >> Uploaded. >> >> >> >> >> PULL - there are a few changes >> >> <https://salsa.debian.org/elboulangero-guest/containerd> >> <https://salsa.debian.org/elboulangero-guest/containerd> >> >> >> I’ll hold off with this one until the build-deps are satisfied. >> >> By the way, do you want to include the most recent commits in the >> debian/changelog entry? > > Yep sure, I just updated the changelog and pushed it all. > > > I can’t seem to build this > because https://tracker.debian.org/pkg/golang-github-opencontainers-image-spec > is broken, and I’m not entirely sure why/how to fix it. Any hints welcome. I think I know. The pristine-tar branch is missing a commit, compared to the upstream branch. My tree at https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec has it all, so if you merge everything to the alioth git repo, I guess that should fix the issue. Notice however that I issued a changelog entry ending with `-2`, I didn't notice that the `-1` package didn't exist. I don't know if it's a problem. Cheers, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review - containerd and dependencies
On 03/20/2018 02:36 PM, Michael Stapelberg wrote: > > > On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout > <arnaud.rebill...@collabora.com > <mailto:arnaud.rebill...@collabora.com>> wrote: > > Hello all, let me follow up on this ! > > According to discussions on this mailing list, I made the > following changes on the packages: > > - the license issues have been clarified with containerd projects, > except for containerd-typeurl which doesn't receive much attention > from upstream. As a consequence I let the copyright to > 'containerd', except if there's a better thing to do (like, > nothing in the copyright field ?). > - I re-packaged docker-go-metrics to a lower version, so that > there is no need to bump prometheus-client-golang. > - I think I addressed most (if all) of the comments from Michael, > ie. DEP-3 patches, more lintian warnings fixed, and others all > along the discussion. > > So let me sum up here the list of packages we're talking about, > and that received changes. > > FORGET ABOUT (because it's not needed anymore) > > > <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar> > > <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar> > > <https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang> > > <https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang> > > CLONE AGAIN (don't pull because I re-wrote history) > > > <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics> > > <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics> > > > Uploaded. > > > > > PULL - there are a few changes > > <https://salsa.debian.org/elboulangero-guest/containerd> > <https://salsa.debian.org/elboulangero-guest/containerd> > > > I’ll hold off with this one until the build-deps are satisfied. > > By the way, do you want to include the most recent commits in the > debian/changelog entry? Yep sure, I just updated the changelog and pushed it all. > > > <https://salsa.debian.org/elboulangero-guest/continuity> > <https://salsa.debian.org/elboulangero-guest/continuity> > > > Looks good. Can you move this repository to its intended location > https://salsa.debian.org/go-team/packages/continuity please? Repo moved. > > > <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs> > > <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs> > > > The description for golang-github-containerd-btrfs-dev should be > trimmed: upstream’s recommendation to vendor the package doesn’t make > sense in Debian, and neither does the contribution guidelines. > > Looks good otherwise. Can you move it > to https://salsa.debian.org/go-team/packages/golang-github-containerd-btrfs > please? Description updated, repo moved. > > > <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl> > > <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl> > > > Looks good. Can you move this > to https://salsa.debian.org/go-team/packages/golang-github-containerd-typeurl > please? Repo moved. > > > <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events> > > <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events> > > > Uploaded. > > > <https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec> > > <https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec> > > > This one is missing a debian/changelog entry for your changes. Indeed, I pushed some last changes. > > <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc> > <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc> > > > Looks good. Can you move this > to https://salsa.debian.org/elboulangero-guest/golang-gogottrpc > <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc> please? Repo moved. > > > > > PULL - these packages have been rejected due to copyright issues > > > <https://salsa.debian.org/go-team/packages/golang-github-containerd-console> > > <https://salsa.debian.org/go-team/packages/golang-github-containerd-console> > > > Uploaded. > > > <https://salsa.debian.org/go-team/packages/golang-github-containerd-fifo&
[pkg-go] Accepted golang-github-docker-go-events 0.0~git20170721.0.9461782-1 (source) into unstable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Thu, 22 Feb 2018 19:17:55 +0700 Source: golang-github-docker-go-events Binary: golang-github-docker-go-events-dev Architecture: source Version: 0.0~git20170721.0.9461782-1 Distribution: unstable Urgency: medium Maintainer: Debian Go Packaging Team <pkg-go-maintainers@lists.alioth.debian.org> Changed-By: Arnaud Rebillout <arnaud.rebill...@collabora.com> Description: golang-github-docker-go-events-dev - Composable event distribution for Go Changes: golang-github-docker-go-events (0.0~git20170721.0.9461782-1) unstable; urgency=medium . * Add watch file * Set priority to optional * Bump dh-helper required version * Bump standards version * Bump compat * Add testuite autopkgtest-pkg-go * Update copyright * Add myself to uploaders and copyright * New upstream version 0.0~git20170721.0.9461782 Checksums-Sha1: e4863f10f6bb0b451df2581223fd0375e46edb1a 2495 golang-github-docker-go-events_0.0~git20170721.0.9461782-1.dsc cbc473e11bec1b2a16889563a3ce5b7da694a547 15593 golang-github-docker-go-events_0.0~git20170721.0.9461782.orig.tar.gz 8adb968a9634a8381d434bdc413dc6dd1bfc0087 2004 golang-github-docker-go-events_0.0~git20170721.0.9461782-1.debian.tar.xz 2d264409573786df1fc27ea004d6d981e894d396 6213 golang-github-docker-go-events_0.0~git20170721.0.9461782-1_amd64.buildinfo Checksums-Sha256: e8586ae4a06fe4917b5c0d5a8d0e5d9ea42c4a379703c151030a14d76abd 2495 golang-github-docker-go-events_0.0~git20170721.0.9461782-1.dsc 8e0dbab4de9e676aaab0861b46e0b64fe69ea0a06cd7745a2bf2c2f3b6358070 15593 golang-github-docker-go-events_0.0~git20170721.0.9461782.orig.tar.gz 6a4058b0792bfbb715ac2a10127f668fd9740936f7bc98278b2bd0398ef769f5 2004 golang-github-docker-go-events_0.0~git20170721.0.9461782-1.debian.tar.xz 6c437f7fd63d2879eec16d71ba84a65ef02bb3ad8c73afda6a0cc52d41e4b54a 6213 golang-github-docker-go-events_0.0~git20170721.0.9461782-1_amd64.buildinfo Files: ee77716f6ea4402cccf7d643745a2ec4 2495 devel optional golang-github-docker-go-events_0.0~git20170721.0.9461782-1.dsc 2477f2f05c12d157ddd5d5885cfaaefc 15593 devel optional golang-github-docker-go-events_0.0~git20170721.0.9461782.orig.tar.gz 0be3b43477481c64bc41352ad2f38e47 2004 devel optional golang-github-docker-go-events_0.0~git20170721.0.9461782-1.debian.tar.xz a625b345c57644d59938ff60130846b5 6213 devel optional golang-github-docker-go-events_0.0~git20170721.0.9461782-1_amd64.buildinfo -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEQk4U1wPnxtQ9nW82TnFg7UrI7h0FAlqwtsoACgkQTnFg7UrI 7h1TQxAAnQ6dApIcqRxwxSrv5pPUUZJpjcFnUikhJmTkfm/lJxO5XYUpKlS6ovCS XEqAA/RD3/Jv0F6avht4RQNuDiPzrLLUFwp+gMT391BQoD62mj3jOpYYt8lChrKY rUAVP4VgmkZb0dxUGiUxO6Kvr+dgM41qyfW6M7j8Lqms+krjV8M/jT+5UZkBLHUk wp2jOnezvJ4c0CPyILJ5YTyvRICQWt4HPQMiqEddrGM72z+zUZaL0sWz+KfLjdal SoGDmVj3lOG9JlFIFX+qttbzcGyxSndkMDTUqffnLHICBhY+hL82OH7PFopwFtEZ yHVdOfxGNZ9Ec27ddjPmMZ4v/zIII7ajujAXzpPQcNeLHkzChzawSGrVBVYjsU19 UPf7jmI6D6F1UJZP3salw0p17+cdVnF3cdLbk7DclNL0JmbvgyOBu9+rix/Y1vQS kyF0gsj2zNN2SjusYBXYJbpLuaHvJLXAhkg5LsM0sg71Z9ISJnKdYHfxr3qCZp2n YD18a7v1y1bCQ4dCg5mYEidbONJ2RhIuzxZcrzh/YMVrVokcJUzHD1MDbpri1AcP ySFr2o6yn7rZbNIcPWoymLWDDEfTyF+9bvbnl5vlqxXaYigAz3RyqYWBnStVuhe7 nNB2Ae3BOcfK+LXGhEdVpL1kb+Mr0JhdJYRWBcu/1/bItcrOrTE= =5IuT -END PGP SIGNATURE- ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Accepted golang-github-docker-go-metrics 0.0~git20170503.0.d466d4f-1 (source) into unstable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Wed, 14 Mar 2018 09:12:53 +0700 Source: golang-github-docker-go-metrics Binary: golang-github-docker-go-metrics-dev Architecture: source Version: 0.0~git20170503.0.d466d4f-1 Distribution: unstable Urgency: medium Maintainer: Debian Go Packaging Team <pkg-go-maintainers@lists.alioth.debian.org> Changed-By: Arnaud Rebillout <arnaud.rebill...@collabora.com> Description: golang-github-docker-go-metrics-dev - Package for metrics collection in Docker projects Changes: golang-github-docker-go-metrics (0.0~git20170503.0.d466d4f-1) unstable; urgency=medium . * Bump compat * Update copyright * Set priority to optional * Bump debhelper requirement * Bump standards version * Add testsuite * Update watch file * Add myself to uploaders * Remove shlibs:Depends from the library package * New upstream version 0.0~git20170503.0.d466d4f * Update copyright for documentation Checksums-Sha1: 323f01e0e503b3564d0ae80a0cc7934003894863 2517 golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f-1.dsc 4114815225c882f14155fb40e801df9cb903a55d 14876 golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f.orig.tar.gz 6fb2d0eb71ce339ecea73116d689b33d83a31861 2388 golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f-1.debian.tar.xz ee47f26ea34aef288f93bf44764ff0612a4df1d0 8160 golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f-1_amd64.buildinfo Checksums-Sha256: 4eff993294f92d657cd88a9b863fff5cb769a733b2913a832d6d5fa45d07024d 2517 golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f-1.dsc 3d70ac619599203851547c19f307d6cae7ae2810bdfca6baf3c6acfa099e21ad 14876 golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f.orig.tar.gz 12301f14c4cfe511de96c84ad5c02571d5f4a153d5acd4f1af7baa3858c8d79d 2388 golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f-1.debian.tar.xz 2b923acb02e586c7009d1cd978b5ef05624585c171b2a7e8341e4ff27f649ee3 8160 golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f-1_amd64.buildinfo Files: 701960b4a2d4a14755c382a9746e8730 2517 devel optional golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f-1.dsc 294c58c9f9b917f5627ab0f997aa7b90 14876 devel optional golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f.orig.tar.gz fb6c27884b4f3d3e603c6ff1de0def53 2388 devel optional golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f-1.debian.tar.xz 333e7b03c6522ddfe6f94eaf296a72a7 8160 devel optional golang-github-docker-go-metrics_0.0~git20170503.0.d466d4f-1_amd64.buildinfo -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEQk4U1wPnxtQ9nW82TnFg7UrI7h0FAlqwsxQACgkQTnFg7UrI 7h0aFhAArwoadmWqH2mQ1Gk1uFHAwUgJTf7bf2x1kNOcnli2NvcGEqB4nvAT9vlK 0+yL2VTk5Rh+nPvlsg7eKVV7X2UvefThPMqaX6AKJpv4rLnsxyDSpwZV1GwdoTPL e2fdWz0U8gmihPHcznI9daeCRK8EC/TUuYa68SkR6WfGFUguRxTj2OZyH6BqyP+Y cfa7N5w6XqgQypez4WpS3U5Aw/5obelW/91hIHUOGi31mvbBo7b2GJ565KEijX4B jU3YA/Zf6UKy3lK0PXSoZ4D55g2wRQRg3S0ROVztiS131X55vBlEvVa0EVw7+czJ EQbEQ0a0qrNXHT5gnFOGWPIvmK3kEdCTxAP3XZUkC50+LzYlyjjtQQDAGwx7YHoy XnFgsY8mjzf1DVux0dQEOYK/Hb7VOWIwdzXtl5UsfjAEAjyvBPI5WnExguz5Qmvw IyG2gNiu6+i6+BFLF1eU4tgPXDof2xUKtLIE/D0leB+m86GZgZuBxm3wTaJXQs5Q yXbKXl1SwsB+ZX/PCDjBCO6oC03FZPdfqLeaMgkNXgmC5di9q7yXnR+px/C28/oD Z+XWo+IEJtyIqlAyqWWgXsbSWUV994/bZ1UdNOUJy/bKG/rc5YJnFxOWmv5+x4VG 9V5grOLCIGAyBqFUkOkXOS7cWKesztUMsl6IK1yWJ1IFNRZ1nx0= =MClM -END PGP SIGNATURE- ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review - containerd and dependencies
Hello all, let me follow up on this ! According to discussions on this mailing list, I made the following changes on the packages: - the license issues have been clarified with containerd projects, except for containerd-typeurl which doesn't receive much attention from upstream. As a consequence I let the copyright to 'containerd', except if there's a better thing to do (like, nothing in the copyright field ?). - I re-packaged docker-go-metrics to a lower version, so that there is no need to bump prometheus-client-golang. - I think I addressed most (if all) of the comments from Michael, ie. DEP-3 patches, more lintian warnings fixed, and others all along the discussion. So let me sum up here the list of packages we're talking about, and that received changes. FORGET ABOUT (because it's not needed anymore) <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar> <https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang> CLONE AGAIN (don't pull because I re-wrote history) <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics> PULL - there are a few changes <https://salsa.debian.org/elboulangero-guest/containerd> <https://salsa.debian.org/elboulangero-guest/continuity> <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs> <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl> <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events> <https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec> <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc> PULL - these packages have been rejected due to copyright issues <https://salsa.debian.org/go-team/packages/golang-github-containerd-console> <https://salsa.debian.org/go-team/packages/golang-github-containerd-fifo> <https://salsa.debian.org/go-team/packages/golang-github-containerd-go-runc> PULL - this package is already in Debian Sid, should I issue a new Debian release due to copyright change ? <https://salsa.debian.org/go-team/packages/golang-github-containerd-cgroups> Ok I think I didn't forget anything :) Feel free to tell me if there's anything that is still not ok with these packages, if there's anything I should do. Like, should I always finish with a commit that updates the changelog (which I didn't do), or not ? Is it OK to have a debian release ending with '-2' or more if the package was *never* uploaded before (I know that reprepro doesn't like that, but I guess the Debian infra doesn't use reprepro). Thanks a lot for the time and energy spend on that. Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] [Docker-maint] Guidance for packaging Docker for Debian
On 03/15/2018 08:42 PM, Ian Campbell wrote:
On Thu, 2018-03-15 at 12:52 +, Martín Ferrari wrote:
I sometimes have kept small dependencies vendored in for
convenience..
But keeping the whole containerd seems wrong to me.
OTOH it _might_ not be totally unreasonable to apply that tactic to
swarmkit which in essence has a single consumer (docker engine).
That's a good point. Here's the dependency tree that bothers me right now
docker-engine
\_ golang-github-docker-swarmkit
\_ golang-github-docker-libnetwork
The main problem here are the circular dependencies, since both swarmkit
and libnetwork import bits from docker-engine. To avoid the circular
dep, I vendor docker-engine within swarmkit and libnetwork. But it
doesn't work, because I end up with duplicated bits that are not
compatible, as described in
<https://github.com/Masterminds/glide/issues/73>.
To be more specific, both import 'pkg/plugingetter', and the build fails
with this error:
have Get(string, string, int)
("github.com/docker/swarmkit/vendor/github.com/docker/docker/pkg/plugingetter".CompatPlugin,
error)
want Get(string, string, int)
("github.com/docker/libnetwork/vendor/github.com/docker/docker/pkg/plugingetter".CompatPlugin,
error)
Actually, this 'pkg' directory is the main cause of circular
dependencies, and hence it's a big pain point. From the README that you
can find in moby/pkg:
"pkg/ is a collection of utility packages used by the Docker project
without being specific to its internals."
These utilities are useful outside of docker, and that's why every other
docker projects include docker-engine and fish into the pkg directory.
Hence the circular dependencies.
If we could somehow package this directory as a library, separately from
docker, then we would have much less circular dependencies. But since
this directory is definitely not something stable, that will also bring
us deeper in an "unresolvable dependencies hell".
So how to solve that ?
One easy solution would be to stop packaging swarmkit and libnetwork,
and just vendor it in docker-engine. Of course, that makes sense only if
there's no other consumers for these libraries.
The other solution (for me) is to learn more about Go and the way they
handle this problem of duplicated vendored bits, and then transpose this
solution somewhere in the debian packaging files.
It's also possible that I just do it something wrong somewhere, and I
didn't figure it out yet.
In an ideal world, we should try to convince the docker people to use
stable APIs (that means using only released non-alpha versions!),
FWIW the engine uses a non-alpha version in recent releases. It seems
to be swarmkit (another dep of engine) which is lagging and using the
alpha version (kind of interesting that that code seems to be ok when
vendored into moby but apparantly not when standalone, I suppose they
use different subsets of the API in different ways).
Very interesting point indeed. For more details, here are the versions
of containerd vendored by docker:
- docker-engine (ie moby): 3fa104f (after v1.0.0)
- docker-swarmkit: 29a4dd7 (somewhere between v1.0.0 alpha3 and alpha4)
Having both in sync would help for sure.
However after giving it a closer look, I think I could patch swarmkit to
build against containerd v1.0.0. Maybe it's not so hard.
I think now that containerd v1.0.0 is out and given the stated API
guarentees containerd is making[0] the problem will be less bad in the
future at least wrt this particular set of components since there
ougtn't to be build breakage from using a "too new" version of
container within a given major release series.
I hope you're right :)
Regards,
Arnaud
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Guidance for packaging Docker for Debian
On 03/15/2018 08:33 PM, Shengjing Zhu wrote: On Thu, Mar 15, 2018 at 5:22 PM, Arnaud Rebillout <arnaud.rebill...@collabora.com> wrote: So I could re-package containerd to an older version. But if I do this choice, I basically admit that Docker decides of the version of all its dependencies, possibly holding back all of them. What if someone needs a pretty recent version of containerd (or any other Docker dependency), and we can't deliver that because we're waiting for Docker to bump the version it vendors, and we have no idea when it will happen ? The docker maintainers have already packaged docker-containerd, and docker-runc. see #877146 for reasons why this happened. Thanks for the link, that helps ! I kind of forgot that there is a separate 'docker-runc' and 'docker-containerd' package. I could make good use of that, until docker catches up with containerd. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Guidance for packaging Docker for Debian
Dear go packaging team, lately I've been doing my best to try to package the current version of Docker in Debian. My approach was 'bottom-up': I listed all the dependencies, and tried to bump every pacakge to the latest version. I thought that in order to package the latest version of Docker, I needed the latest version of all its dependencies. Now I finally realize how wrong I was. In the world of go, there's often no stable api, no backward compatibility, even no release, that why we end up packaging some random git sha. So basically, applications vendor their dependencies, and they won't work with an older version (because it's too old and miss something), but it won't work either with a newer version (because, hey, no release, no backward compatibility). So I made a beginner mistake, but I'm learning, and hopefully I'm on the right track ! But now I face a dilemna. The current version of Docker vendors `containerd` somewhere between `v1.0.0-alpha3` and `v1.0.0-alpha4`. While I already packaged containerd to `v1.0.2`. There's almost 6 months of difference between them, and no, docker (or more specifically its dependency swarmkit) does not build. So I could re-package containerd to an older version. But if I do this choice, I basically admit that Docker decides of the version of all its dependencies, possibly holding back all of them. What if someone needs a pretty recent version of containerd (or any other Docker dependency), and we can't deliver that because we're waiting for Docker to bump the version it vendors, and we have no idea when it will happen ? The other solution is to keep a vendored version of containerd within Docker, just the way it's already done in Docker. I'm personally fine with that, but it seems that it's not the Debian way. But maybe in this situation it makes sense. I don't know what's the best way to deal with this situation, so if anyone from the team can provide some advice, that would be super welcome ! Thanks ! Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-github-containerd-console_0.0~git20170925.84eeaae-1_amd64.changes REJECTED
On Mon, 5 Mar 2018, Arnaud wrote: Should I file a bug upstream ? yes, please. Regarding the copyright on containerd packages, upstream was very responsive and updated their copyright on *almost* every package concerned. The only package left is https://github.com/containerd/typeurl, which didn't receive any commit for the last 6 months, therefore I have no idea when upstream will feedback. What should I do in this situation, should I just leave the copyright field empty in the Debian package ? For the 5 others packages, I updated debian/copyright accordingly. What's the correct workflow to submit them again ? - containerd-cgroups is already in Debian Sid, should I bump the debian/changelog to -2 ? - containerd-console, containerd-go-runc, containerd-fifo were all REJECTED due to the copyright issue, should I also bump the debian/changelog ? Thanks, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-github-containerd-console_0.0~git20170925.84eeaae-1_amd64.changes REJECTED
On 03/06/2018 04:45 AM, Thorsten Alteholz wrote: > > On Mon, 5 Mar 2018, Arnaud wrote: >> Should I file a bug upstream ? > > yes, please. Done, I will keep you updated. Regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review - containerd and dependencies
/cgi-bin/bugreport.cgi?bug=890958>> > - Patch and issues submitted upstream. > > > Can you add DEP-3 tags to the patches please? > See http://dep.debian.net/deps/dep3/. No need to go overboard, just > the last-updated/author/description/forwarded ones. Fixed. > > Also, there seems to be a lintian false-positive: it reports > statically-linked-binary despite the Build-Depends on golang-go. Can > you file a lintian bug about that please? Ok, I'm doing that right now. BTW, in this package I use the following Build-Depends for `golang-go`: golang-go (>= 2:1.9~) | golang-1.9-go, Using the epoch `2` in the version here. Is it actually needed ? I'm not 100% sure, but I think I saw other packages that don't mention epoch and just do something like `>1.9`, which is more concise. I'm also not sure about the tilde at then end, I just copy-pasted that from somewhere :) > > > > golang-github-containerd-btrfs > > <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs > > <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs>> > <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989 > <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989>> > - I disabled the test to avoid installing a btrfs-test binary. I don't > think it makes sense to create an additional binary package > just for shipping this test. > > > Sounds good. Maybe change cmd to cmd/btrfs-test so that we’ll notice > newly introduced binaries upon updates? Otherwise, the package looks good. Indeed, good catch ! Done. > > > > golang-github-containerd-typeurl > > <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl > > <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl>> > <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891181 > <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891181>> > - Patch submitted upstream > > > Please add DEP-3 tags to the patch. Looks good otherwise. > Done. > > golang-github-dmcgowan-go-tar > <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar > > <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar>> > <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890960 > <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890960>> > - This one was a tricky one, please read the commit messages for > details. > > > Does the package which needs this require support for sparse tar > files? If not, I think we can do away with this package in favor of > patching the consumer to use archive/tar instead. Doing a diff -ur > shows that this package is identical to archive/tar as of Go 1.10, > except for the sparse support, which is scheduled to land in Go 1.11. You're right, and there's no need for sparse support. I patched as you suggested to use archive/tar. Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review - containerd and dependencies
On 02/27/2018 03:32 AM, Michael Stapelberg wrote:
>
> There's a `docs/.gitignore`, it's in a subdirectory. Files-Excluded
> will remove it from the orig tarball, right ? Is it really suitable here ?
>
> Correct, and up to you (see the caveat which tincho expressed). Bug
> #812721 discusses a gbp import-ref command which would honor
> Files-Excluded, but we’re not quite there yet. So, if you want to
> stick to orig tarballs for the time being, Files-Excluded will work.
In the end I solved it a better way, simply by being more selective in
debian/docs.
>
>
>
> For the moment the only package in which I exclude a file from
> installation is done this way:
>
> override_dh_auto_install:
> dh_auto_install
> find $(CURDIR)/debian -name '.tool' -type d -prune -exec rm -r
> '{}' +
>
>
> nit: use find’s -delete action?
Nope :) `-delete` only works for files, not directories.
My concern here is not so much about the find command, but it's more the
location where I look for files. Here I use $(CURDIR)/debian, and it
works, but I'm surprised that there is not a "BUILDDIR" variable
defined, or something similar. I'm not sure if using $(CURDIR)/debian
works for every package in every situation, I don't know enough about
the internals.
>
> Ah, I see what’s wrong here: you are supposed to run lintian on a
> .changes file, so that it can inspect both the binary packages (*.deb)
> and the source package (*.dsc). Indeed, when building gogoprotobuf and
> running “lintian golang-gogoprotobuf_0.5-1_amd64.changes”, I don’t get
> any warnings about statically linked binaries.
A indeed, thanks for pointing that.
>
>
>>
>>
>>
>> In the `-dev` packages, is `${shlibs:Depends}` needed ?
>> During the builds
>> I see `unknown substitution variable ${shlibs:Depends}`
>> passing by.
>>
>>
>> The messages implies it’s not required. I’m not entirely sure,
>> but would suggest removing it for now.
>
> Ok. I think it should be also changed in dh-make-golang, should I
> look there and issue a PR, or do you prefer not to touch it for now ?
>
>
> Please feel free to send a PR! :)
Done !
Thanks again for all the explanations, that helps a lot.
Arnaud
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review - containerd and dependencies
On 02/27/2018 03:32 AM, Michael Stapelberg wrote: > Once you feel your packages are ready for review (possibly this reply > prompts some changes?), please send an up-to-date list of git URLs to > what you’d like reviewed. Thanks! Ok, here is the package list again, I prefer to leave all the packages on my personal salsa space for now, just so that I can fix every details according to your feedback, then cleanup the git history, and then move that definitive version to alioth or salsa, where applicable. URLS are the same as the initial email, it's just a copy/paste of the initial email, from which I removed comments that are not applicable anymore. BUMPED PACKAGES --- containerd <https://salsa.debian.org/elboulangero-guest/containerd> - As for testing the thing really, I didn't go far yet, I just launched the binary, the log messages that appeared looked healthy enough, and that's all for now. golang-github-docker-go-events <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events> golang-github-docker-go-metrics <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics> golang-github-opencontainers-image-spec <https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec> - I noticed only after doing all the work that Michael Stapelberg was working on this package lately. I hope I don't duplicate the work. - I'm not sure about the gbp.conf commit, please confirm whether it's ok. golang-github-prometheus-client-golang <https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang> NEW PACKAGES continuity <https://salsa.debian.org/elboulangero-guest/continuity> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890983> - I ran the series of test described at <https://github.com/containerd/continuity>, everything went fine. golang-gogottrpc <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890958> - Patch and issues submitted upstream. golang-github-containerd-btrfs <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989> - I disabled the test to avoid installing a btrfs-test binary. I don't think it makes sense to create an additional binary package just for shipping this test. golang-github-containerd-typeurl <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891181> - Patch submitted upstream golang-github-dmcgowan-go-tar <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890960> - This one was a tricky one, please read the commit messages for details. Best, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#891531: ITP: golang-github-bfirsh-funker-go -- Funker for Go
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-bfirsh-funker-go Version : 0.0~git20161231.eaa0a2e-1 Upstream Author : Ben Firshman * URL : https://github.com/bfirsh/funker-go * License : Apache-2.0 Programming Lang: Go Description : Funker for Go A Go implementation of Funker . Funker allows you to package up pieces of your application as Docker containers and have them run on-demand on a swarm. - why is this package useful/relevant? It is a dependency of docker. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#891506: ITP: gotestyourself -- A collection of go packages to support common testing patterns
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: gotestyourself Version : 1.3.0-1 Upstream Author : Daniel Nephin * URL : https://github.com/gotestyourself/gotestyourself * License : Apache-2.0 Programming Lang: Go Description : A collection of go packages to support common testing patterns Go Test Yourself is a collection of packages compatible with go test to support common testing patterns. . Packages . assert - compare values and fail the test when the comparison fails env - test code that uses environment variables fs - create test files and directories golden - compare large multi-line strings icmd - execute binaries and test the output poll - test asynchronous code by polling until a desired state is reached skip - skip tests based on conditions testsum - a program to summarize go test output and test failures . Related . maxbrunsfeld/counterfeiter - generate fakes for interfaces jonboulle/clockwork - a fake clock for testing code that uses time - why is this package useful/relevant? It is a dependency of docker. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review - containerd and dependencies
On 02/23/2018 05:10 PM, Michael Stapelberg wrote:
> I can’t have a look at the individual packages right now
No rush !
> containerd
> <https://salsa.debian.org/elboulangero-guest/containerd
> <https://salsa.debian.org/elboulangero-guest/containerd>>
> - There's a lintian warning about
> package-contains-vcs-control-file, but
> until
> now I didn't find the right way to remove a file from
> installation. I
> guess
> `override_dh_auto_install` is the way to go. Any hint welcome here.
>
>
> Which file specifically is affected? The Files-Excluded directive in
> debian/copyright is a good way to exclude files.
There's a `docs/.gitignore`, it's in a subdirectory. Files-Excluded will
remove it from the orig tarball, right ? Is it really suitable here ?
For the moment the only package in which I exclude a file from
installation is done this way:
override_dh_auto_install:
dh_auto_install
find $(CURDIR)/debian -name '.tool' -type d -prune -exec rm -r '{}' +
Not really elegant, and it took me two hours to come up with that, after
trying and failing every other way possible...
>
>
>
> golang-github-containerd-btrfs
>
> <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs
>
> <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs>>
> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989
> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989>>
> - I disabled the test to avoid installing a btrfs-test binary,
> plus I think the
> test failed for some reason, I'm not sure to remember though...
>
>
> To avoid installing a binary, can you use the DH_GOLANG_EXCLUDES
> option please?
> See
> https://manpages.debian.org/testing/dh-golang/Debian::Debhelper::Buildsystem::golang.3pm.en.html
>
> Also, please add a comment stating why precisely the tests are
> disabled, and what needs to change so that we can re-enable them.
Ok I'll try harder :)
I noticed that DH_GOLANG_EXCLUDES will not save me from a test which
fails though. For example, when I was working with containerd/cgroups,
the test commmand invoked by dh looks like that:
go test -vet=off -v -p 8 github.com/containerd/cgroups
DH_GOLANG_EXCLUDES is matched against github.com/containerd/cgroups, so
if it contains a file inside the cgroups directory, it's not excluded
from the files being tested.
It means that if I want to prevent a file from the test, I still need to
patch it with `// +build ignore`, if I understand properly.
>
>
>
> I see that most binaries come with the lintian warning
> `statically-linked-binary`, I guess it's just the way it works in the
> go world. Should I just add a lintian override ?
>
>
> lintian does not emit the statically-linked-binary tag for Go
> packages. Can you point me to a specific example where you see it please?
Yep, easy.
apt-get download gogoprotobuf
lintian gogoprotobuf_*_amd64.deb
Is this warning related to the field `Built-Using: ${misc:Built-Using}`
for binary packages ? After reading the Debian Policy Manual, I seem to
understand that this field is needed for go binary packages, am I correct ?
However even with this field, there is still the warning in the
`containerd` binary package that I built here, but only for *some* of
the binaries in the package, not all of them.
>
>
>
> In the `-dev` packages, is `${shlibs:Depends}` needed ? During the
> builds
> I see `unknown substitution variable ${shlibs:Depends}` passing by.
>
>
> The messages implies it’s not required. I’m not entirely sure, but
> would suggest removing it for now.
Ok. I think it should be also changed in dh-make-golang, should I look
there and issue a PR, or do you prefer not to touch it for now ?
>
>
>
> In the `-dev` packages, do we really need to copy-paste all the
> dependencies from the source package ?
>
>
> Yes. They differ in some cases, for example when code generation needs
> more dependencies than the actual compilation/test (in which case the
> extra dependencies show up only in Build-Depends, not Depends).
Ok...
Thanks !
Arnaud
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Call for review - containerd and dependencies
Hello Go Packaging Team,
I reached a milestone, I managed to get an up-to-date containerd package!
I changed a bit my workflow and worked on my "personal staging area" in
salsa, ie `salsa.debian.org/elboulangero-guest`, rather than directly
in `salsa.debian.org/go-team`. I find it more convenient, I can mess
around without bothering anyone.
I also packaged several packages before asking a review, as I don'twant
to waste your time with my iterations, and ask you to review thingsthat
in the end are not needed.
So now, the bad news is that there's quite a bunch of packages to review,
but the good news is that if it's all good, then we have the latest
containerd in Debian, and then we're closer to having docker packaged
as well (I can't say exactly *how close* though...) !
So here comes the review list, with links and comments !
BUMPED PACKAGES
---
I forked the packages from `anonscm.debian.org` into my personal staging
area `salsa.debian.org/elboulangero-guest`.
I don't think I have write access to `anonscm.debian.org`, although I
didn't try. I just don't want to mess up so it's more convenient to use
my personal namespace on salsa.
I didn't touch the control urls in `debian/control`, so I believe that my
changes can be merged into the anonscm.debian.org repository without any
drama. Well, I hope :)
containerd
<https://salsa.debian.org/elboulangero-guest/containerd>
- There's a lintian warning about package-contains-vcs-control-file, but
until
now I didn't find the right way to remove a file from installation. I
guess
`override_dh_auto_install` is the way to go. Any hint welcome here.
- As for testing the thing really, I didn't go far yet, I just launched
the binary, the log messages that appeared looked healthy enough, and
that's all for now.
golang-github-docker-go-events
<https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events>
golang-github-docker-go-metrics
<https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics>
golang-github-opencontainers-image-spec
<https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec>
- I noticed only after doing all the work that Michael Stapelberg was
working on this package lately. I hope I don't duplicate the work.
- The 3 last commits are probably not that good, please advise and I'll
fix it.
golang-github-prometheus-client-golang
<https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang>
NEW PACKAGES
These packages live in my personal staging area, that is:
`salsa.debian.org/elboulangero-guest`. However the control urls are set to
`salsa.debian.org/go-team`, so I believe it's just a matter of moving the
repository there if you give me your ack.
continuity
<https://salsa.debian.org/elboulangero-guest/continuity>
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890983>
- Produces continuity and golang-github-containerd-continuity-dev.
I looked at the existing packages docker and docker-containerd for
guidance.
- I ran the series of test described at
<https://github.com/containerd/continuity>,
everything went fine.
golang-gogottrpc
<https://salsa.debian.org/elboulangero-guest/golang-gogottrpc>
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890958>
- Produces golang-gogottrpc and golang-github-stevvooe-ttrpc-dev.
I looked at the existing package golang-gogoprotobuf for guidance.
- Patch and issues submitted upstream.
golang-github-containerd-btrfs
<https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs>
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989>
- I disabled the test to avoid installing a btrfs-test binary, plus I
think the
test failed for some reason, I'm not sure to remember though...
golang-github-containerd-typeurl
<https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl>
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891181>
- Patch submitted upstream
golang-github-dmcgowan-go-tar
<https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar>
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890960>
- This one was a tricky one, please read the commit messages for details.
GENERAL QUESTIONS
-
I see that most binaries come with the lintian warning
`statically-linked-binary`, I guess it's just the way it works in the
go world. Should I just add a lintian override ?
In the `-dev` packages, is `${shlibs:Depends}` needed ? During the builds
I see `unknown substitution variable ${shlibs:Depends}` passing by.
In the `-dev` packages, do we really need to copy-paste all the
dependencies from the source package ?
Thanks for reading, waiting for your feedback.
Best regards,
Arnaud
___
Pkg-go-maintainers mailing list
[pkg-go] Bug#891181: ITP: golang-github-containerd-typeurl -- Go package for managing marshaled types to protobuf.Any
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-containerd-typeurl Version : 0.0~git20170912.f694355-1 Upstream Author : Arnaud Rebillout * URL : https://github.com/containerd/typeurl * License : Apache-2.0 Programming Lang: Go Description : Go package for managing marshaled types to protobuf.Any A Go package for managing the registration, marshaling, and unmarshaling of encoded types. . This package helps when types are sent over a GRPC API and marshaled as a [protobuf.Any](). - why is this package useful/relevant? It is a dependency of containerd. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review: golang-github-containerd-cgroups
On 02/21/2018 11:15 PM, Michael Stapelberg wrote: > > > On Tue, Feb 20, 2018 at 11:35 AM, Arnaud > <arnaud.rebill...@collabora.com > <mailto:arnaud.rebill...@collabora.com>> wrote: > > Dear Go Packaging Team, > > here are the url related to this package: > > https://salsa.debian.org/go-team/packages/golang-github-containerd-cgroups > > <https://salsa.debian.org/go-team/packages/golang-github-containerd-cgroups> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890807 > <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890807> > > The test file paths_test.go fails in a chroot, as it requires the > cgroups hierarchy to be mounted. I tackled that by disabling all the > tests when the cgroup hierarchy is not mounted. > > > Could you move this check into the relevant test(s)? > See https://golang.org/pkg/testing/#T.Skip. Then, please contribute it > upstream so that others can benefit from this fix as well. The patch was accepted upstream, hence I bumped the package which is now ready to be uploaded I guess. Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#890989: ITP: golang-github-containerd-btrfs -- Btrfs bindings for Go
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-containerd-btrfs Version : 0.0~git20171005.72c0a35-1 Upstream Author : containerd * URL : https://github.com/containerd/btrfs * License : Apache-2.0 Programming Lang: Go Description : Btrfs bindings for Go Native Go bindings for btrfs. . Status . These are in the early stages. We will try to maintain stability, but please vendor if you are relying on these directly. . Contribute . This package may not cover all the use cases for btrfs. If something you need is missing, please don't hesitate to submit a PR. Note that due to struct alignment issues, this isn't yet fully native. Preferrably, this could be resolved, so contributions in this direction are greatly appreciated. - why is this package useful/relevant? It is a dependency of containerd. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#890983: ITP: continuity -- A transport-agnostic, filesystem metadata manifest system
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: continuity Version : 0.0~git20180216.d8fb858-1 Upstream Author : containerd * URL : https://github.com/containerd/continuity * License : Apache-2.0 Programming Lang: Go Description : A transport-agnostic, filesystem metadata manifest system A transport-agnostic, filesystem metadata manifest system . This project is a staging area for experiments in providing transport agnostic metadata storage. . Please see https://github.com/opencontainers/specs/issues/11 for more details. - why is this package useful/relevant? It is a dependency of containerd. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#890960: ITP: golang-github-dmcgowan-go-tar -- Fork of archive/tar in standard library to carry changes for all go versions
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-dmcgowan-go-tar Version : 0.0~git20170718.2e2c512-1 Upstream Author : Derek McGowan * URL : https://github.com/dmcgowan/go-tar * License : BSD-3-clause Programming Lang: Go Description : Fork of archive/tar in standard library to carry changes for all go versions - why is this package useful/relevant? It is a dependency of containerd. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#890958: ITP: golang-github-stevvooe-ttrpc -- GRPC for low-memory environments
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-stevvooe-ttrpc Version : 0.0~git20180205.d452837-1 Upstream Author : Stephen Day * URL : https://github.com/stevvooe/ttrpc * License : Apache-2.0 Programming Lang: Go Description : GRPC for low-memory environments The existing grpc-go project requires a lot of memory overhead for importing packages and at runtime. While this is great for many services with low density requirements, this can be a problem when running a large number of services on a single machine or on a machine with a small amount of memory. . Using the same GRPC definitions, this project reduces the binary size and protocol overhead required. We do this by eliding the net/http, net/http2 and grpc package used by grpc replacing it with a lightweight framing protocol. The result are smaller binaries that use less resident memory with the same ease of use as GRPC. . Please note that while this project supports generating either end of the protocol, the generated service definitions will be incompatible with regular GRPC services, as they do not speak the same protocol. - why is this package useful/relevant? It is a dependency of containerd. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Call for review: golang-github-containerd-cgroups
Dear Go Packaging Team, here are the url related to this package: https://salsa.debian.org/go-team/packages/golang-github-containerd-cgroups https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890807 The test file paths_test.go fails in a chroot, as it requires the cgroups hierarchy to be mounted. I tackled that by disabling all the tests when the cgroup hierarchy is not mounted. Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review: golang-github-urfave-cli
> > > > For the repository we're talking about right now, I understand > there's no need to bump the version right now, as long as I'm not > sure it's needed. > > Should I just delete it, or at least take it out of the go > packages group, and keep it as a personal repo ? > > > Yes please (whichever of the two you prefer). > I don't have the permission to delete the project from the go packages group, at https://salsa.debian.org/go-team/packages/golang-github-urfave-cli/edit. I think you can do it ? Thanks Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Call for review: golang-github-urfave-cli
On 02/20/2018 12:08 AM, Michael Stapelberg wrote: > Are you certain that this commit is actually a requirement, or just > happens to be the latest version the containerd people tried? It's just the version that is vendored by containerd. I assumed they used it for a good reason, that's all. Definitely not certain that it's needed. > Did you test the version currently in Debian and run into issues? No I didn't try, right now I'm just trying to package and bump everything required by containerd, then package containerd, then test the whole thing. > > I’m not saying importing new upstream versions isn’t a good idea, I’m > just trying to make sure you don’t do any extra work you don’t want to do. I get your point. I thought the best approach was to bump every dependency first, then package the missing dependencies. But maybe it's better to package what's missing first, then try containerd, and then bump dependencies to newer versions if it's really a need. Especially if I bump to a snapshot version like in the current case, it's always better to avoid that and stick to official releases, when they exist. > > > - the current debian package for urfave-cli is on > anonscm.debian.org <http://anonscm.debian.org>. So > here I had to create a repository on salsa.debian.org > <http://salsa.debian.org>. Maybe you don't > like that and already have a procedure for migrating packages from > anonscm to salsa. > > > While it is fine to create new repositories on salsa, we should either > add this repository to the rewritemap ASAP (+cc aviau) or don’t move > it for the time being. What is the rewritemap ? Is Alexandre Viau the person in charge of migrating go packages to salsa in general ? For the repository we're talking about right now, I understand there's no need to bump the version right now, as long as I'm not sure it's needed. Should I just delete it, or at least take it out of the go packages group, and keep it as a personal repo ? > Overall, your changes look good to me. Let me know which way you > prefer to proceed regarding repository location, fix the changelog, > and I can upload it for you. Let's just wait until we're sure this version bump is really needed, if you're ok with that. Thanks again for all the thorough feedback ! Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Call for review: golang-github-urfave-cli
Dear Debian Go Packaging Team, The latest version of containerd requires a recent snapshot of github.com/urfave/cli. This can be seen with a command such as: wget --quiet \ https://raw.githubusercontent.com/containerd/containerd/master/vendor.conf \ -O - | \ grep urfave At the moment, containerd requires the commit 7bc6a0a, from October 2017. Currently, the version packages in Debian is the latest released, 1.20.0, from August 2017. So I updated the Debian package to the snapshot required by containerd. You can see my attempt at: https://salsa.debian.org/go-team/packages/golang-github-urfave-cli Please notice that: - the current debian package for urfave-cli is on anonscm.debian.org. So here I had to create a repository on salsa.debian.org. Maybe you don't like that and already have a procedure for migrating packages from anonscm to salsa. - I didn't touch the gbp.conf file, which works good but is not as simple as the default gpb.conf file create by dh-make-golang. I don't know how much you want to enforce a common gbp config, and I don't want to be rude to the persons maintaining this package. - Lintian complained about NMU (as I'm not a DD), so I fixed that, but I don't remember having to do that for the packages I created these last days. So I don't know if it was right to care about that particular Lintian warning. Any comment appreciated ! Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#890807: ITP: golang-github-containerd-cgroups -- cgroups package for Go
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-containerd-cgroups Version : 0.0~git20180201.c0710c9-1 Upstream Author : containerd * URL : https://github.com/containerd/cgroups * License : Apache-2.0 Programming Lang: Go Description : cgroups package for Go Go package for creating, managing, inspecting, and destroying cgroups. The resources format for settings on the cgroup uses the OCI runtime-spec found here (https://github.com/opencontainers/runtime-spec). - why is this package useful/relevant? It is a dependency of containerd. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Circular dependency in a test file
On 02/13/2018 07:12 PM, Michael Stapelberg wrote: > > This error is actually not because of a circular dependency, but > rather because the import path specified in marshal_test.go is > incorrect: it reads github.com/containerd/containerd/typeurl > <http://github.com/containerd/containerd/typeurl>, but should > read github.com/containerd/typeurl <http://github.com/containerd/typeurl>. > > You can reproduce this issue outside of our packaging infrastructure > by running go get -t -u github.com/containerd/typeurl > <http://github.com/containerd/typeurl> > > Please file an upstream issue about this. Indeed, thanks for pointing that out. I just filed an issue and pull request upstream. Regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Circular dependency in a test file
Hi Tincho, thanks a lot for all the details ! On 02/13/2018 07:10 PM, Martín Ferrari wrote: > Hi Arnaud, > > On 13/02/18 12:37, Arnaud wrote: > >> The fact that it breaks dh-make-dolang is not the blocker here, as I can >> workaround and create the packaging files manually. However, what should >> I do with this `marshal_test.go` file ? Should I exclude it from the >> package ? Or should I patch it ? > You could either add an exclusion during build/test, or you can patch it > so it is ignored with '// +build ignore'. If you go with the exclusion, > you should probably add the dependency in the package dependencies (not > in the build-deps), but unless it is a very important test, maybe it is > better to just disable it. I think in this particular case it's better to disable the test and get rid of the dependency to containerd. Here we're talking about a lightweight library, it wouldn't make sense to make it depend on containerd which is a super heavy package. Regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Circular dependency in a test file
Dear pkg-go maintainers, I bumped into a trouble while packaging <https://github.com/containerd/typeurl>. The library is fairly simple, however the file marshal_test.go [1] contains this line: eventsapi "github.com/containerd/containerd/api/services/events/v1" This is a circulare dependency, since containerd/typeurl is a depency of of containerd/containerd, but requires containerd/containerd for this test. This breaks dh-make-golang with this error: 2018/02/13 18:29:20 Downloading "github.com/containerd/typeurl/..." go get: 82.03 MiBpackage github.com/containerd/typeurl imports github.com/containerd/containerd/typeurl: cannot find package "github.com/containerd/containerd/typeurl" in any of: /usr/lib/go-1.7/src/github.com/containerd/containerd/typeurl (from $GOROOT) /tmp/dh-make-golang738896973/src/github.com/containerd/containerd/typeurl (from $GOPATH) 2018/02/13 18:29:44 Could not create a tarball of the upstream source: exit status 1 The fact that it breaks dh-make-dolang is not the blocker here, as I can workaround and create the packaging files manually. However, what should I do with this `marshal_test.go` file ? Should I exclude it from the package ? Or should I patch it ? And more generally: I've noticed that a lot of go packages have test files named `*_test.go` Is it good policy to remove them from the package when they get in the way like this ? Or are they needed in some way that I don't expect ? Thanks, Arnaud [1]: https://github.com/containerd/typeurl/blob/master/marshal_test.go ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Review request for #890310: ITP: golang-github-containerd-fifo -- fifo pkg for Go
Dear pkg-go team, you will find the package ready for review at: https://salsa.debian.org/go-team/packages/golang-github-containerd-fifo The ITP link is: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890310 Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#890310: ITP: golang-github-containerd-fifo -- fifo pkg for Go
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-containerd-fifo Version : 0.0~git20170714.fbfb6a1-1 Upstream Author : containerd * URL : https://github.com/containerd/fifo * License : Apache-2.0 Programming Lang: Go Description : fifo pkg for Go Go package for handling fifos in a sane way. This is a dependency of containerd. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Plans to update the docker package
Dear Docker Packaging Team, I'm working at Collabora, and right now I have a bit of time to dedicate to the Docker Debian package. I would like to bump Docker to the latest version in Debian unstable. Up to now I've been struggling a bit to get the big picture, and I think I'm getting there. From what I understood from the latest `vendor.conf` file, Docker now uses runc and containerd from upstream. Moreover, I cooked a little script to compare the vendored libraries with their upstream version, and amazingly it looks like Docker doesn't patch any of its vendored libraries at the moment. Same goes with containerd. It seems that it was not so simple in the past, and that's why there is now a 'docker-runc' and a 'docker-containerd' package. But in this mail I won't talk about these packages, I'm interested in the 'runc' and 'containerd' packages which track the upstream repositories, not the docker forks. So what I want to do in a first step is to bump the 'runc' and 'containerd' package to the latest version. It seems that the 'runc' package is already up-to-date (1.0.0-rc4). However the 'containerd' package is still at '0.2.3', while upstream is at '1.0.2-rc1'. I looked at the situation, and there's a bit of work involved: a little less than 20 packages need to be created or bumped to a newer version. I already created 4 packages that I submitted through ITP and that are now available on salsa.debian.org. So in the following days and weeks, I will hopefully dedicate some time to package containerd dependencies, until I manage to get containerd itself packaged and up to date. Then I will attempt the same with the docker package. At least, that's the plan :) Tell me if I miss anything ! Additionally, I noticed that since mid-2017, Docker changed the way it manages its codebase. There's now 3 repo: - https://github.com/moby/moby for the engine - https://github.com/docker/cli for the client - https://github.com/docker/docker-ce which is a kind of "meta-repository" that contains both repositories above, plus packaging files. The tricky thing is that the engine and the client don't get tagged anymore, only docker-ce has tags and releases. I don't know if some of you already dived into this. It seems to me that it could be easier to have two packages: docker-engine that would track moby/moby, and docker-cli that would track docker/cli. Then a metapackage 'docker' that would depend on both, and ensure the versions match. On the other hand I'm quite new at Debian packaging, so I wouldn't trust myself :) What's your thoughts on that ? Any comment is welcome. Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Review request for #889882: ITP: golang-github-opencontainers-go-digest -- Common digest package used across the container ecosystem
On 02/13/2018 03:07 PM, Michael Stapelberg wrote: > You’ll need to update the pristine-tar branch as well. I can’t build > the package as-is: > > $ gbp buildpackage > gbp:info: Tarballs > 'golang-github-opencontainers-go-digest_1.0.0~rc1.orig.tar.xz' not > found at '..' > gbp:info: Creating > /tmp/exp/o/golang-github-opencontainers-go-digest_1.0.0~rc1.orig.tar.xz > gbp:error: Error creating > golang-github-opencontainers-go-digest_1.0.0~rc1.orig.tar.xz: > Pristine-tar couldn't checkout > "golang-github-opencontainers-go-digest_1.0.0~rc1.orig.tar.xz": fatal: > Path > 'golang-github-opencontainers-go-digest_1.0.0~rc1.orig.tar.xz.delta' > does not exist in 'refs/heads/pristine-tar' > pristine-tar: git show > refs/heads/pristine-tar:golang-github-opencontainers-go-digest_1.0.0~rc1.orig.tar.xz.delta > failed > You're right, my mistake. It's now fixed, the package builds, and I also tagged the last commit as `debian/...`. Regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Review request for #889947: ITP: golang-github-containerd-go-runc -- runc bindings for Go
On 02/13/2018 04:20 AM, Michael Stapelberg wrote: > Looks good. Thanks, sponsorship please ! Regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Review request for #889944: ITP: golang-github-containerd-console -- console package for Go
On 02/13/2018 04:18 AM, Michael Stapelberg wrote: > Looks good. Thanks ! Sponsorship would be appreciated ! Regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Review request for #889882: ITP: golang-github-opencontainers-go-digest -- Common digest package used across the container ecosystem
On 02/13/2018 04:17 AM, Michael Stapelberg wrote: > lintian reports: > > P: golang-github-opencontainers-go-digest source: > file-contains-trailing-whitespace debian/control (line 25) > W: golang-github-opencontainers-go-digest source: > rc-version-greater-than-expected-version 1.0.0-rc1 > 1.0.0 (consider > using 1.0.0~rc1) Thanks, I didn't see that. I pushed a fix. Sponsor would be appreciated ! Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Review request for #889880: ITP: golang-github-nvveen-gotty -- Go package for interacting with the capabilities of a terminal
On 02/13/2018 04:15 AM, Michael Stapelberg wrote: > The package looks good to me now. Would you like me to sponsor the upload? That would be great ! Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Review request for #889947: ITP: golang-github-containerd-go-runc -- runc bindings for Go
On 02/10/2018 04:28 PM, Michael Stapelberg wrote: > All the comments from the golang-github-nvveen-gotty review apply > here, too. Please bump once you addressed them and I’ll take another look. I re-created the package from scratch with the latest dh-make-golang, and the package is available at: https://salsa.debian.org/go-team/packages/golang-github-containerd-go-runc Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] Review request for #889882: ITP: golang-github-opencontainers-go-digest -- Common digest package used across the container ecosystem
On 02/10/2018 04:27 PM, Michael Stapelberg wrote: > All the comments from the golang-github-nvveen-gotty review apply > here, too. Please bump once you addressed them and I’ll take another look. I re-created the package from scratch with the latest dh-make-golang, and the package is available at: https://salsa.debian.org/go-team/packages/golang-github-opencontainers-go-digest Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Review request for #889880: ITP: golang-github-nvveen-gotty -- Go package for interacting with the capabilities of a terminal
Dear pkg-go team, you will find the package ready for review at: https://salsa.debian.org/elboulangero-guest/golang-github-nvveen-gotty The ITP link is: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889880 Please note that: - the package was created with dh-make-golang Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Review request for #889944: ITP: golang-github-containerd-console -- console package for Go
Dear pkg-go team, you will find the package ready for review at: https://salsa.debian.org/elboulangero-guest/golang-github-containerd-console The ITP link is: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889944 Please note that: - the package was created with dh-make-golang - the upstream does not mention copyright, and dh-make-golang defaults to '2017 containerd', which seems appropriate. Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Review request for #889947: ITP: golang-github-containerd-go-runc -- runc bindings for Go
Dear pkg-go team, you will find the package ready for review at: https://salsa.debian.org/elboulangero-guest/golang-github-containerd-go-runc The ITP link is: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889947 Please note that: - the package was created with dh-make-golang - the upstream does not mention copyright, and dh-make-golang defaults to '2017 containerd', which seems appropriate. Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Review request for #889882: ITP: golang-github-opencontainers-go-digest -- Common digest package used across the container ecosystem
Dear pkg-go team, you will find the package ready for review at: https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-go-digest The ITP link is: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889882 Please note that: - the package was created with dh-make-golang Best regards, Arnaud ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#889949: ITP: golang-github-opencontainers-runtime-spec -- OCI Runtime Specification
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-opencontainers-runtime-spec Version : 1.0.1+git20171211.8.b2d941e-1 Upstream Author : Open Container Initiative * URL : https://github.com/opencontainers/runtime-spec * License : Apache-2.0 Programming Lang: Go Description : OCI Runtime Specification Open Container Initiative Runtime Specification The Open Container Initiative (https://www.opencontainers.org) develops specifications for standards on Operating System process and application containers. - why is this package useful/relevant? It is a dependency of containerd from version 0.2.9. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#889948: ITP: runtime-spec -- OCI Runtime Specification
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: runtime-spec Version : 1.0.1+git20171211.8.b2d941e-1 Upstream Author : Open Container Initiative * URL : https://github.com/opencontainers/runtime-spec * License : Apache-2.0 Programming Lang: Go Description : OCI Runtime Specification Open Container Initiative Runtime Specification The Open Container Initiative (https://www.opencontainers.org) develops specifications for standards on Operating System process and application containers. - why is this package useful/relevant? It is a dependency of containerd from version 0.2.9. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#889947: ITP: golang-github-containerd-go-runc -- runc bindings for Go
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-containerd-go-runc Version : 0.0~git20180125.0.4f6e87a-1 Upstream Author : containerd * URL : https://github.com/containerd/go-runc * License : Apache-2.0 Programming Lang: Go Description : runc bindings for Go This is a package for consuming the runc binary in your Go applications. It tries to expose all the settings and features of the runc CLI. If there is something missing then add it, its opensource! - why is this package useful/relevant? It is a dependency of containerd from version 0.2.9. - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#889944: ITP: golang-github-containerd-console -- console package for Go
Package: wnpp Severity: wishlist Owner: Arnaud Rebillout <arnaud.rebill...@collabora.com> * Package name: golang-github-containerd-console Version : 0.0~git20170925.0.84eeaae-1 Upstream Author : containerd * URL : https://github.com/containerd/console * License : Apache-2.0 Programming Lang: Go Description : console package for Go Golang package for dealing with consoles. Light on deps and a simple API. - why is this package useful/relevant? It is a dependency of containerd from version 0.2.9, - how do you plan to maintain it? I plan to maintain it within the golang packaging team. ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
