D11308: Use the default Plasma wallpaper on the lock screen

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I think we first need to bring back some background for the UI elements. Otherwise it's too difficult to read. Personally I'm very confused as it was the vdg's wish to

D11306: Give the "Clear History" button some text

ngraham added a comment. In general, buttons need icons, especially buttons that don't look like buttons until you hover over them, like this one. While I agree that a better icon would be preferable, since we don't have one, let's maybe keep the discussion on the subject of this patch (the

D11308: Use the default Plasma wallpaper on the lock screen

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As discussed and agreed to by VDG, change the lock screen

D11309: Use the default Plasma wallpaper on the login screen

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As discussed and agreed to by VDG, change the SDDM theme

D11306: Give the "Clear History" button some text

zzag added a comment. In D11306#225222 , @ngraham wrote: > Get rid of what now? The icon. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11306 To: ngraham, #plasma, broulik, Fuchs Cc: zzag,

D11306: Give the "Clear History" button some text

ngraham added a comment. Get rid of what now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11306 To: ngraham, #plasma, broulik, Fuchs Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

zzag added a comment. Then get rid of it. It would cause only confusion :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11306 To: ngraham, #plasma, broulik, Fuchs Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11306: Give the "Clear History" button some text

ngraham added a comment. Agreed! In the VDG room we discussed a broom, but unfortunately we don't have any such icon. If we got one, I'd be happy to use it. Until then, the only other option is a trash can (`edit-delete-symbolic`). REPOSITORY R120 Plasma Workspace REVISION DETAIL

D11306: Give the "Clear History" button some text

zzag added a comment. Could another icon be used in the clear history button? The current one indicates that something is denied/prohibited. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11306 To: ngraham, #plasma, broulik, Fuchs Cc: zzag, plasma-devel,

D11306: Give the "Clear History" button some text

ngraham created this revision. ngraham added reviewers: Plasma, broulik, Fuchs. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Notifications Plasmoids recently gained a

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. I think it would be better to place new items on the left side of the system tray, as this is closer to default behavior. Also, sometimes the visibility state is updated incorrectly after moving items back and forth (showing hidden state for visible items). Other

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Ricardo J. Barberis changed: What|Removed |Added CC|

D11166: Simplify display when there's only a single input device and a single output device

ngraham updated this revision to Diff 29440. ngraham added a comment. Also implement Simple Mode for the App tab, when there are only apps playing or recording, but not both REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D11220: option to force FolderView icon-only presentation

mvourlakos added a comment. settings window looks like: F5752898: εικόνα.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11220 To: mvourlakos, #plasma, mart Cc: sebas, broulik, hein, plasma-devel, ZrenBot,

D11220: option to force FolderView icon-only presentation

mvourlakos updated this revision to Diff 29439. mvourlakos added a comment. - update semantics based on feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11220?vs=29195=29439 BRANCH alwaysShowAsIcon REVISION DETAIL

D8302: Add FreeBSD port from the development-repo

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. sorry, I missed that... REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D8302 To: tcberner, #freebsd, mvourlakos Cc: plasma-devel,

D10944: [taskmanager applet] Do not fill width

Pitel added a comment. Ping. The current version adds a configuration option `fillWidth` (enabled by default) which allows the applet to grow beyond its preferred size. I tested it in usual setup and with `fillWidth` enabled the behavior is unchanged. REPOSITORY R119 Plasma Desktop

D11292: [RFC] Ordered system tray v2

Pitel added a comment. In D11292#225006 , @davidedmundson wrote: > FWIW, the crash you're referring to is also fixed with an up-to-date (not released yet) Qt. If you are referring to https://codereview.qt-project.org/#/c/50/ I tried

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 29434. Kanedias added a comment. Typo REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=29433=29434 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 AFFECTED FILES

D11292: [RFC] Ordered system tray v2

davidedmundson added a comment. FWIW, the crash you're referring to is also fixed with an up-to-date (not released yet) Qt. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: davidedmundson, anthonyfieroni, wsdfhjxc,

D1230: GBM remote access support for KWin

Kanedias added inline comments. INLINE COMMENTS > romangg wrote in egl_gbm_backend.cpp:160 > Should be the default not directly activated remote funcitonality? And if one > wants to deactivate remote set `KWIN_NO_REMOTE` or something. There's no authentication protocol, so any malicious

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 29433. Kanedias marked 6 inline comments as done. Kanedias added a comment. Review fixes REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=28973=29433 BRANCH gbm-vnc REVISION DETAIL

D11292: [RFC] Ordered system tray v2

anthonyfieroni added inline comments. INLINE COMMENTS > ConfigEntries.qml:110-119 > + /* for (var i = 0; i < statusNotifierModel_cfg.count; ++i) { > +var item = statusNotifierModel.get(i); > +itemInfo[item.Id] = { > "taskId": item.Id, >

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. In D11292#224949 , @Pitel wrote: > I am aware of `getFixedItemId`, only forgot to mention it in summary. Right now it is not included mostly because it is another hack (but fixing stupid behavior of someone else so

Re: Compile kwin using yocto for embedded systems (opengles)

Thanks for your reply Martin. I see the following possibilities to address this error: > * forward declare Display (struct Display should be sufficent) > * disable building of the EglOnXBackend > Given that epoxy seems to not have X11 support I would say the second > option is the proper one.

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. In D10297#224935 , @apol wrote: > Here's some thoughts: > > - Why is there only one with the keyboard shortcut? many of these have (e.g. run a command) The initial idea of the tools menu was to make the Kill

D11292: [RFC] Ordered system tray v2

Pitel added a comment. I am aware of `getFixedItemId`, only forgot to mention it in summary. Right now it is not included mostly because it is another hack (but fixing stupid behavior of someone else so unavoidable) and I do not use DropBox, but if this gets any closer to landing, we should

D10297: Add new "Tools" button above System Monitor's process list

apol added a comment. Here's some thoughts: - Why is there only one with the keyboard shortcut? many of these have (e.g. run a command) - maybe sort the menu alphabetically first? or there's any meaning? REPOSITORY R111 KSysguard Library REVISION DETAIL

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. As for the getFixedItemId function (which was connected to an id trimming method in my example), it was because of Dropbox client's StatusNotifier item having some random number suffix. Without this, at every boot it was duplicated in the new config list-type

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. Sometimes silence equals consent, especially when there have been many requests for comment. If nobody else has an opinion before then, I propose landing this on March 20th. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. Any more thoughts on this patch before it is ready to land? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein Cc: anthonyfieroni, andreaska, rkflx, ngraham,

D11233: Ordered system tray

Pitel added a comment. I really like the idea of being able to reorder the systray as I wish. I could not resist and took my stab on the issue (with drag) D11292 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11233

D11292: [RFC] Ordered system tray v2

Pitel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY My try at ordered system try heavily inspired by D11233 .

D10750: wayland: Add support for zwp_linux_dmabuf

romangg added a comment. In D10750#216337 , @fredrik wrote: > An issue that this patch does not fully address is switching compositing backends at runtime. Do we support that at all? The backend is set at startup. Don't think you can

D10750: wayland: Add support for zwp_linux_dmabuf

romangg added a comment. Do typedefs for `KWayland::Server::LinuxDmabuf` in files where you use it more than once. INLINE COMMENTS > abstract_egl_backend.cpp:346 > > +void AbstractEglBackend::aboutToDestroy(EglDmabufBuffer *buffer) > +{ Name should be more descriptive in relation to

D11262: KDE logout screen background color fix

Pitel added a comment. I see that relative luminance formula is more correct but I would like to point out that we do not need here to calculate precise luminance. The point of the `?:` statement is to collapse colors close to back to real black because gray overlay with 50 % opacity does

D11166: Simplify display when there's only a single input device and a single output device

ngraham added a comment. In D11166#224822 , @drosca wrote: > In D11166#224814 , @ngraham wrote: > > > Can you help me understand why this might be unwanted in that circumstance? You'd still have

D11166: Simplify display when there's only a single input device and a single output device

drosca added a comment. In D11166#224814 , @ngraham wrote: > Can you help me understand why this might be unwanted in that circumstance? You'd still have only one input and one output, no? In case where both cards support both

D11166: Simplify display when there's only a single input device and a single output device

ngraham added a comment. In D11166#224808 , @drosca wrote: > There is still one case where this may not be wanted: when you have two cards and first have only sink and second source. Can you help me understand why this might be unwanted

D6313: WIP: Support device pixel ratio in icon loader and engine

acrouthamel added a comment. Hey there, any movement on this? I've been submitting some patches to fix icon scaling in apps and have noticed how they switch from monochrome to colored (hires) versions when fixed. Getting the underlying issue fixed would be great as more people buy

D11166: Simplify display when there's only a single input device and a single output device

drosca added a comment. There is still one case where this may not be wanted: when you have two cards and first have only sink and second source. Also this doesn't apply to Applications tab, why? INLINE COMMENTS > DeviceListItem.qml:39 > +} > +labelOpacity: onlyOne ? 1 : 0.6 >

D11109: [Notifications] Remove NoAccessNetworkAccessManagerFactory

This revision was automatically updated to reflect the committed changes. Closed by commit R120:71f168818439: [Notifications] Remove NoAccessNetworkAccessManagerFactory (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11109?vs=28890=29415#toc REPOSITORY R120

D1230: GBM remote access support for KWin

romangg added inline comments. INLINE COMMENTS > romangg wrote in drm_output.h:139 > Is it only a friend class to access `m_waylandOutput.data()`? In this case > better create a getter for it in DrmOutput. > > Or better do the `passBuffer` call in `DrmBackend::present` and give instead > of

D11103: Move "Standard Shortcut" KCM down in the list

This revision was automatically updated to reflect the committed changes. Closed by commit R119:51dd27e72640: Move Standard Shortcut KCM down in the list (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11103?vs=28870=29414

D11166: Simplify display when there's only a single input device and a single output device

ngraham added a comment. In D11166#224628 , @mart wrote: > i like it in principle. could it be less obviout tough which is the output and which is the input? > i know there are the speaker and microphone icons, but they are small and

D11289: checkable FormLayout items

progwolff created this revision. progwolff added reviewers: VDG, Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY In some cases, form items go together with a

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

ngraham added a comment. So what's our path forward here? We have some positive votes and some negative votes. Do we need to first have a wider conversation on wallpaper discoverability and then later circle back to something we can all agree on? REPOSITORY R119 Plasma Desktop REVISION

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 361 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/361/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Tue, 13 Mar 2018 14:55:55 + Build duration: 4 min 17 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 189 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/189/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Mar 2018 14:55:55 + Build duration: 2 min 21 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 360 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/360/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Tue, 13 Mar 2018 14:27:40 + Build duration: 4 min 12 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 188 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/188/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Mar 2018 14:27:40 + Build duration: 1 min 8 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 359 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/359/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Tue, 13 Mar 2018 14:22:00 + Build duration: 5 min 5 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 187 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/187/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Mar 2018 14:22:00 + Build duration: 1 min 40 sec and counting CONSOLE OUTPUT

D11274: Fix font rendering for non-HiDPI and integer scale factors

This revision was automatically updated to reflect the committed changes. Closed by commit R858:9a5f7d834f86: Fix font rendering for non-HiDPI and integer scale factors (authored by ngraham). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

broulik added a comment. > "plz keep this as short as pssible bcause is a context menu" Widget apps use `i18nc("@action:inmenu", "...")` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11253 To: ngraham, #plasma, davidedmundson Cc: mart, hein, broulik,

D11262: KDE logout screen background color fix

fredrik added inline comments. INLINE COMMENTS > mart wrote in Logout.qml:87 > the method lattes is using 0.2126*r + 0.7152*g + 0.0722*b is more correct > (a simple one would be convertin to gray scale with qGray, but unfortunately > is C++ only) qGray() uses an integer approximation that is

D11180: Reverse tooltip colors for Breeze colorscheme

rwurth added a comment. Okay! I never made a patch before or anything so I don't necessarily know the procedure, just wanted to throw in my two cents. Thanks for taking a look! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11180 To: rwurth, #breeze, #vdg Cc: mart,

D11220: option to force FolderView icon-only presentation

mvourlakos added a comment. In D11220#224622 , @mart wrote: > Shouldn't the quick launch applet cover this use case? The quick launch applet can show folder contents or activities-pinned documents? REPOSITORY R119 Plasma Desktop

D11166: Simplify display when there's only a single input device and a single output device

mart added a comment. i like it in principle. could it be less obviout tough which is the output and which is the input? i know there are the speaker and microphone icons, but they are small and secondary.. maybe in this case the soundcard icon should be dropped and the speaker/microphone

D11180: Reverse tooltip colors for Breeze colorscheme

mart added a comment. I also personally prefer dark tooltips. anyways this change has to be agreed upon widely in the VDG REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11180 To: rwurth, #breeze, #vdg Cc: mart, broulik, progwolff, ngraham, rwurth, plasma-devel,

D11220: option to force FolderView icon-only presentation

mart added a comment. Shouldn't the quick launch applet cover this use case? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11220 To: mvourlakos, #plasma, mart Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11233: Ordered system tray

mart added a comment. In D11233#223694 , @ngraham wrote: > In D11233#223661 , @broulik wrote: > > > Drag and drop might be an acceptable way to rearrange them but then I think we should just have a

D11233: Ordered system tray

mart added a comment. I'm really against manual reordering and saving.. as the only thing i would like for the systray is to make it simpler, not more complicated :p that said yes, icons need to be in a more predictable, or at least consistent position I think it would be fairly

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

mart added a comment. In D11253#223766 , @broulik wrote: > +1 > > I just hope it won't make the menu too wide „Arbeitsfläche und Hintergrundbild einrichten“ is what I guess it would be for my locale (but then we already have „Inhalt der

D11254: Fix scrollbar on empty search results

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7ddd20cfd35d: Fix scrollbar on empty search results (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11254?vs=29305=29394 REVISION DETAIL

D11257: Improve By Desktop sorting for task groups

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a9df1e20f527: Improve By Desktop sorting for task groups (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11257?vs=29309=29393 REVISION

D11262: KDE logout screen background color fix

mart added inline comments. INLINE COMMENTS > Logout.qml:87 > +function isLightColor(color) { > +return Math.max(color.r, color.g, color.b) > 0.5 > } the method lattes is using 0.2126*r + 0.7152*g + 0.0722*b is more correct (a simple one would be convertin to gray scale with

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. In D1231#224441 , @jtamate wrote: > As I don't see anything related to security in this patch, I have two questions. > > Could anyone with access to server:port manage the server wayland sessions or just create a

D1231: Add Remote Access interface to KWayland

jtamate added a comment. As I don't see anything related to security in this patch, I have two questions. Could anyone with access to server:port manage the server wayland sessions or just create a new session? The access control should be done in the firewall? REPOSITORY R127