D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added inline comments.

INLINE COMMENTS

> progwolff wrote in previewrenderengine.cpp:136
> Thanks, this would be much cleaner. Sadly it doesn't seem to work.
> I tried this before. Also tried `setDotsPerMeterX`.
> 
> The image is drawn too big with `QT_SCREEN_SCALE_FACTORS=2`:
> F5743060: Screenshot_20180306_090622.png 
> 

It's a bug in Qt: https://bugreports.qt.io/browse/QTBUG-38127

Workaround: set the sourceSize to something.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff marked 3 inline comments as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added inline comments.

INLINE COMMENTS

> davidedmundson wrote in previewrenderengine.cpp:136
> change to
> 
> QImage image(draw(name, style,...));
> image.setDevicePixelRatio(ratio);
> return image;
> 
> This keeps the metadata of the image scaling with the image, and then the 
> Image item knows automatically what the logical of this image is.

Thanks, this would be much cleaner. Sadly it doesn't seem to work.
I tried this before. Also tried `setDotsPerMeterX`.

The image is drawn too big with `QT_SCREEN_SCALE_FACTORS=2`:
F5743060: Screenshot_20180306_090622.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Takao Fujiwara]

fujiwara planned changes to this revision.
fujiwara marked 2 inline comments as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28792.
progwolff added a comment.


  - revert qml transforms, workaround QTBUG-38127

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28767&id=28792

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10973: [media controller applet] Support MPRIS services where CanPause==false

[Kai Uwe Broulik]

broulik added a comment.


  Other than those nitpicks would be good to go I guess

INLINE COMMENTS

> main.qml:91
>  if (root.state == "playing") {
> -plasmoid.setAction("playPause", i18nc("Pause playback", 
> "Pause"), "media-playback-pause")
> -plasmoid.action("playPause").enabled = Qt.binding(function() 
> {
> -return root.canPause;
> -});
> +if (canPause) {
> +plasmoid.setAction("pause", i18nc("Pause playback", 
> "Pause"), "media-playback-pause")

Shouldn't that be a binding? If the player cannot pause, the entry would just 
not show up rather than become disabled, ie. keep the action as "playPause" 
maybe?

> main.qml:149
> +root.state === "paused" ?  "media-playback-pause" :
> +   "media-playback-stop"
>  active: compactMouse.containsMouse

Not a huge fan of that stopped icon in the panel

> main.qml:203
> +function togglePlaying() {
> +if (root.canPause) {
> +root.action_playPause();

Please don't mix manual toggling and playPause, just do it manually then, 
otherwise the code becomes a bit convoluted

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10973

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Takao Fujiwara]

fujiwara updated this revision to Diff 28793.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11061?vs=28722&id=28793

REVISION DETAIL
  https://phabricator.kde.org/D11061

AFFECTED FILES
  applets/kimpanel/backend/ibus/ibus15/panel.cpp

To: fujiwara, #plasma, hein, xuetianweng
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Takao Fujiwara]

fujiwara requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

[Kai Uwe Broulik]

broulik added a comment.


  almost good

INLINE COMMENTS

> ContextMenu.qml:122
> +var playing = (playerData.PlaybackStatus === "Playing"),
> +menuItem = menu.newMenuItem(menu);
>  menuItem.text = i18nc("Play previous track", "Previous 
> Track");

Do two separate vars

  var playing = ...;
  var menuItem =  ...;

> ContextMenu.qml:169
> +menuItem.enabled = Qt.binding(function() {
> +return playerData.PlaybackStatus !== "Stopped";
> +});

In the media controller you do status == "playing" || status == "paused" 
whereas here you do status == "stopped"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11007

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 28796.
kossebau added a comment.


  call play() and pause() depending on playbackStatus

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10991?vs=28480&id=28796

BRANCH
  fixMPRISMediaKeysHandling

REVISION DETAIL
  https://phabricator.kde.org/D10991

AFFECTED FILES
  dataengines/mpris2/multiplexedservice.cpp

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixtaskmanagertooltipformpris

REVISION DETAIL
  https://phabricator.kde.org/D11025

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10973: [media controller applet] Support MPRIS services where CanPause==false

[Friedrich W . H . Kossebau]

kossebau marked an inline comment as done.
kossebau added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:91
> Shouldn't that be a binding? If the player cannot pause, the entry would just 
> not show up rather than become disabled, ie. keep the action as "playPause" 
> maybe?

Not sure myself (but the doubled canPause looks strange on second read).

In the context menu of the taskmanager all media actions are kept and only 
disabled if not possible, with play/pause action though being same and 
switching label for canPause.
Would be good to be consistent. Not sure what I prefer.

So no menu entry for Play if playing and !canPause? Instead of disabled menu 
entry?

> broulik wrote in main.qml:149
> Not a huge fan of that stopped icon in the panel

The icon will not be visible in the system tray, as it's only used when neither 
playing or paused, and then the status is passive, so hidden in system tray.

Showing the stopped icon on the compact version of the applet in general makes 
sense for me, to really show it's in a different state.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10973

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

[Friedrich W . H . Kossebau]

kossebau marked an inline comment as done.
kossebau added inline comments.

INLINE COMMENTS

> broulik wrote in ContextMenu.qml:169
> In the media controller you do status == "playing" || status == "paused" 
> whereas here you do status == "stopped"?

Yes, in the media controller the status is going for the applet qml state 
strings, given those are also used around. So there it is for consistency with 
rest of media controller code.

Here there is no QML state, so I used the mpris property state directly with 
shortest logic. Torn by two consistency attractors. Make a call, please :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11007

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 28799.
kossebau added a comment.


  one var per variable

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11007?vs=28776&id=28799

BRANCH
  fixtaskmanagercontextmenuformpris

REVISION DETAIL
  https://phabricator.kde.org/D11007

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

[Friedrich W . H . Kossebau]

kossebau edited the summary of this revision.
kossebau edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixtaskmanagertooltipformpris

REVISION DETAIL
  https://phabricator.kde.org/D11025

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:09eba0235b90: [taskmanager applet] Fix MPRIS buttons in 
tooltip for CanPause==false (authored by kossebau).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11025?vs=28778&id=28800

REVISION DETAIL
  https://phabricator.kde.org/D11025

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/main.qml

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11059: Add convenience method to get a persistent model index from TasksModel

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11059

To: davidedmundson, #plasma, hein
Cc: broulik, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11082: [WIP] Display all StreamRestore entries in it's own config Tab

[David Rosca]

drosca added a comment.


  You forgot to add StreamRestoreTab.qml to review.
  
  > I duplicated BaseMap in map.h to use a QString key focused on the info.name 
property. Code duplication sucks. :/
  
  Can't you just qHash() the name and use it as integer index for normal 
MapBase?
  
  > Every stream uses the system notifications icon. Would need to play around 
with that.
  
  I don't think you can get icon name for this from pa.
  
  > Double scrollbars sucks, but I'd need to look into why there's a binding 
loop on AppletConfiguration.height. We need to use ScrollView + ListView so 
that it only loads 4-5 delegates at a time since I personally had 100+ entries 
(games) which took a few seconds to load the tab when I removed the filter from 
the Applications tab.
  
  That should only be bug in Plasma, it should work fine in kcmshell/system 
settings.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11082

To: Zren, #plasma
Cc: drosca, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  In D11064#219273 , @abetts wrote:
  
  > Is there a way that the list width can be dynamic so as to accommodate the 
name of the font family?
  
  
  I would prefer not to include the font family name in the combobox at all. 
  Font family names might be quite short and contain only a subset of 
characters, so that the differences between the renderings might turn out too 
slight to notice.
  
  > Also, I would suggest one of two ways to show the list:
  
  I would prefer not to have multiple lines of text in the combobox, as single 
lines are easier to compare against each other.
  
  What do you think?
  
  F5743166: Screenshot_20180306_110024.png 

  
  F5743165: Screenshot_20180306_101833.png 

  
  F5743164: Screenshot_20180306_110122.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixtaskmanagercontextmenuformpris

REVISION DETAIL
  https://phabricator.kde.org/D11007

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28802.
progwolff added a comment.


  - adjust popup width to fit contents

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28792&id=28802

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff marked an inline comment as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

[Friedrich W . H . Kossebau]

kossebau edited the summary of this revision.
kossebau edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixtaskmanagercontextmenuformpris

REVISION DETAIL
  https://phabricator.kde.org/D11007

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2b3f9cd9092f: [taskmanager applet] Fix MPRIS entries in 
context menu for CanPause==false (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11007?vs=28799&id=28803#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11007?vs=28799&id=28803

REVISION DETAIL
  https://phabricator.kde.org/D11007

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28804.
progwolff added a comment.


  - never show scrollbars for the combobox popup (force pixel aligment)
  - prepare for multi-line preview images, resize images to pixel-align on high 
dpi displays

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28802&id=28804

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

To: romangg, #plasma, andreask
Cc: nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediaAppletStatusIcon

REVISION DETAIL
  https://phabricator.kde.org/D11056

To: romangg, #plasma, andreask
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10973: [media controller applet] Support MPRIS services where CanPause==false

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 28806.
kossebau added a comment.


  make play/pause action behaviour in context menu consistent with the one for 
taskmanager

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10973?vs=28777&id=28806

BRANCH
  mpriscontrollersupportnocanpause

REVISION DETAIL
  https://phabricator.kde.org/D10973

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28811.
progwolff added a comment.


  - style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28804&id=28811

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Nathaniel Graham]

ngraham added a comment.


  Out of those three, my vote goes to #2. The versions with numbers and symbols 
look really messy.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[David Edmundson]

davidedmundson added a comment.


  FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11057: Add a custom default avatar to the sddm-breeze theme.

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11057

To: pstefan, #plasma, #vdg, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10962: [Fonts KCM] Make font dialog modal

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10962

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10925: Wrap at end of selector instead of in the middle

[David Edmundson]

davidedmundson added a comment.


  > Didn't test it, just double checked the whitespace.
  
  Why not?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D10925

To: Zren, #breeze, abetts
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10955: [kaccess] Improve the port away from kdelibs4support

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improvekaccessport

REVISION DETAIL
  https://phabricator.kde.org/D10955

To: kossebau, #plasma, apol, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Nathaniel Graham]

ngraham added a comment.


  I don't like how black the shadow is on the bottom. Once the strength 
adjustment works, we might experiment with reducing it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10955: [kaccess] Improve the port away from kdelibs4support

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0f3e344f2317: [kaccess] Improve the port away from 
kdelibs4support (authored by kossebau).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10955?vs=28362&id=28814

REVISION DETAIL
  https://phabricator.kde.org/D10955

AFFECTED FILES
  kaccess/main.cpp

To: kossebau, #plasma, apol, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

romangg updated this revision to Diff 28816.
romangg marked 7 inline comments as done.
romangg added a comment.


  - Comments by Kai

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11063?vs=28772&id=28816

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: romangg, #plasma, andreask
Cc: nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player

[Friedrich W . H . Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d62c50d5c678: [mpris2 dataengine] Fix media key handling 
to match MediaPlayer2.Player (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10991?vs=28796&id=28815

REVISION DETAIL
  https://phabricator.kde.org/D10991

AFFECTED FILES
  dataengines/mpris2/multiplexedservice.cpp

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> broulik wrote in ExpandedRepresentation.qml:124
> Why is this thing no longer in a `ColumLayout`?

I want to have the controls always at the same fixed position at the bottom of 
the applet. With a layout it would shift them around according to the content 
available (which you can probably block somehow, but I couldn't really get it 
to work and using anchors or simple columns to achieve this seems more 
straightforward to me anyway).

> broulik wrote in ExpandedRepresentation.qml:269
> `height: undefined`

If I forget this trick one more time, hit me.

> broulik wrote in ExpandedRepresentation.qml:290
> Why not use a `ColumnLayout`?

As above. I want to have this stuff always at fixed positions. Or is there a 
simple way to achieve this with Layouts as well?

> broulik wrote in ExpandedRepresentation.qml:291
> I thought level only went up to 5 but fine with me

Yea, you're right. It just interprets everything above 5 as 5.

> broulik wrote in ExpandedRepresentation.qml:297
> So you now use the file name as "album"? How does it behave when you have no 
> id3 info at all?

I don't have changed anything in this regard.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

To: romangg, #plasma, andreask
Cc: nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10461: GMenu-DBusMenu-Proxy

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Fundamental design seems fine.
  
  It's a massive patchset, I'm not sure I've got my head round all of it yet, I 
might take a second round when these minor things are addressed.

INLINE COMMENTS

> actions.cpp:62
> +QDBusPendingReply reply = 
> QDBusConnection::sessionBus().asyncCall(msg);
> +QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(reply, 
> this);
> +connect(watcher, &QDBusPendingCallWatcher::finished, this, 
> [this](QDBusPendingCallWatcher *watcher) {

leak

> actions.cpp:119
> +QDBusPendingReply reply = 
> QDBusConnection::sessionBus().asyncCall(msg);
> +QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(reply, 
> this);
> +connect(watcher, &QDBusPendingCallWatcher::finished, this, [this, 
> name](QDBusPendingCallWatcher *watcher) {

leak

> gmenudbusmenuproxy.desktop:7
> +OnlyShowIn=KDE;
> +X-KDE-autostart-phase=0

Why 0?

> icons.cpp:24
> +
> +QString Icons::actionIcon(const QString &actionName)
> +{

does this list come from anywhere?

> menu.cpp:98
> +qCWarning(DBUSMENUPROXY) << "Got an empty menu for" << id << 
> "on" << m_serviceName << "at" << m_objectPath;
> +return;
> +}

watcher leaked

> menu.cpp:127
> +QDBusPendingReply reply = 
> QDBusConnection::sessionBus().asyncCall(msg);
> +QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(reply, 
> this);
> +connect(watcher, &QDBusPendingCallWatcher::finished, this, [this, 
> ids](QDBusPendingCallWatcher *watcher) {

and again...

> menuproxy.cpp:195
> +
> +if (applicationMenuObjectPath.isEmpty() && menuBarObjectPath.isEmpty()) {
> +return;

are these always set before the window is created?

> menuproxy.cpp:249
> +// FIXME Check type
> +if (/*propertyReply->type == 392 && */propertyReply->format == 8 && 
> propertyReply->value_len > 0) {
> +const char *data = (const char *) 
> xcb_get_property_value(propertyReply.data());

what's this about?

> window.cpp:92
> +if (!m_applicationObjectPath.isEmpty()) {
> +m_applicationActions = new Actions(m_serviceName, 
> m_applicationObjectPath);
> +connect(m_applicationActions, &Actions::actionsChanged, this, 
> [this](const QStringList &dirtyActions) {

who owns this?

> window.cpp:357
> +
> +new DbusmenuAdaptor(this); // do this before registering the object?
> +

I think it's safe, you'd have definitely added it before we process someone 
introspecting the path.

But why write it one way round and add a question when we can just move it.

> window.cpp:606
> +if (!accel.isEmpty()) {
> +// TODO replace "+" by "plus" and "-" by "minus"
> +shortcut.append(accel);

so do so?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, mart, rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28817.
progwolff added a comment.


  - fix parsing hinting index

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28811&id=28817

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10973: [media controller applet] Support MPRIS services where CanPause==false

[Friedrich W . H . Kossebau]

kossebau edited the summary of this revision.
kossebau edited the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10973

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10973: [media controller applet] Support MPRIS services where CanPause==false

[Friedrich W . H . Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:06913fc2556a: [media controller applet] Support MPRIS 
services where CanPause==false (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10973?vs=28806&id=28818

REVISION DETAIL
  https://phabricator.kde.org/D10973

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11069#219853 , @ngraham wrote:
  
  > I don't like how black the shadow is on the bottom. Once the strength 
adjustment works, we might experiment with reducing it.
  
  
  Yeah.. Shadow strength should at most 90%.
  
  In D11069#219503 , @zzag wrote:
  
  > About KStyle: I suggest to use gradients in order to approximate decoration 
shadows. It doesn't have big shadows so we don't need big precision. Also, I 
suggest to make them lighter.
  
  
  Forget about it. Bad idea.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11094: add baloo-search skill delegates

[Aditya Mehra]

Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.

REVISION SUMMARY
  Baloo-search Audio/Video/Documents result delegates for mycroft 
plasma-baloo-search-skill

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11094

AFFECTED FILES
  plasmoid/contents/ui/AudioFileDelegate.qml
  plasmoid/contents/ui/DocumentFileDelegate.qml
  plasmoid/contents/ui/VideoFileDelegate.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11094: add baloo-search skill delegates

[Aditya Mehra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:80d5e58e3434: add baloo-search skill delegates (authored 
by Aiix).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11094?vs=28819&id=28820

REVISION DETAIL
  https://phabricator.kde.org/D11094

AFFECTED FILES
  plasmoid/contents/ui/AudioFileDelegate.qml
  plasmoid/contents/ui/DocumentFileDelegate.qml
  plasmoid/contents/ui/VideoFileDelegate.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11003: Fix the Add Source dialog

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:b623a4afb12f: Fix the Add Source dialog (authored by 
ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11003?vs=28533&id=28821

REVISION DETAIL
  https://phabricator.kde.org/D11003

AFFECTED FILES
  discover/qml/AddSourceDialog.qml

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng added a comment.


  In D11061#219841 , @davidedmundson 
wrote:
  
  > FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem
  
  
  imho, this is pretty irrelevant here.. gsettings is not directly gconf and 
gconf itself is deprecated since gtk3 iirc.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng requested changes to this revision.
xuetianweng added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> panel.cpp:1049
> +g_signal_handlers_disconnect_by_func (impanel->settings_hotkey, 
> (gpointer)impanel_settings_changed_callback, impanel);
> +g_clear_pointer (&impanel->settings_general, g_object_unref);
> +g_clear_pointer (&impanel->settings_hotkey, g_object_unref);

I think you can use g_clear_object here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11096: [XWindowTasksModel] When name or visible name changed only update display role

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The window name and user visible name are not used in the app identification 
heuristic, so a change here cannot result in the icon, app id, app name, 
generic name, PID or launcher changing.

TEST PLAN
  Changed files in Qt Creator, noticed that it also erroneously signals a 
geometry change, when I ignored that, I verified that it was the name change 
code path updating the label and not the geometry one (which also nukes app 
info cache)
  
  Also verified that the icon isn't always signalled to have changed just 
because the window name changed (can be expensive for apps where we don't know 
the service and have to query the window icon)
  
  Inspected TaskTools namespace and didn't find any use of KWindowInfo (and as 
such no use of window name/visible name)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11096

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11096: [XWindowTasksModel] When name or visible name changed only update display role

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11096

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11096: [XWindowTasksModel] When name or visible name changed only update display role

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:36f4ff942b6c: [XWindowTasksModel] When name or visible 
name changed only update display role (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11096?vs=28825&id=28827

REVISION DETAIL
  https://phabricator.kde.org/D11096

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hello,
  
  - I agree with Nathan that the bottom part is likely too hard.
  - I think the same shadows should be used for windows and menus
  - Also, thanks for posting the pictures. Is there any chance you could also 
post new vs old shadows side by side for the different sizes ? I have the 
feeling that for a given shadow size the new shadows appear larger ...
  
  Tanks in advance !
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7e5dff648f01: [Dialog] Remove now obsolete 
KWindowSystem::setState calls (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10769?vs=27851&id=28828

REVISION DETAIL
  https://phabricator.kde.org/D10769

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10962: [Fonts KCM] Make font dialog modal

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c736f2e8a98c: [Fonts KCM] Make font dialog modal 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10962?vs=28380&id=28829

REVISION DETAIL
  https://phabricator.kde.org/D10962

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 28833.
zzag added a comment.


  control look of each separate shadow with the opacity prop

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28755&id=28833

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag planned changes to this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10461: GMenu-DBusMenu-Proxy

[Kai Uwe Broulik]

broulik marked 5 inline comments as done.
broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in icons.cpp:24
> does this list come from anywhere?

It was done trial and error by running couple of gtk apps (gedit, gimp, 
inkscape, shotwell) etc, the kde 4 appmenu also had something like this albeit 
less elaborate

> davidedmundson wrote in menuproxy.cpp:195
> are these always set before the window is created?

I haven't seen it not working and wasn't really keen on playing with native 
event filters again as I did in appmenu applet

> davidedmundson wrote in menuproxy.cpp:249
> what's this about?

KDE stuff shows up in `xprop` as

  _KDE_NET_WM_APPMENU_OBJECT_PATH(STRING) = "/MenuBar/1"

note the `STRING` whereas GTK shows up as

  _GTK_APPLICATION_OBJECT_PATH(UTF8_STRING)

note the `UTF8_STRING`. I did not find the corresponding type enum anywhere and 
it also seems to be different for different machines

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, mart, rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11069#219980 , 
@hpereiradacosta wrote:
  
  > - I agree with Nathan that the bottom part is likely too hard.
  
  
  I've added opacity prop so different shadows could be tweaked("darkess" at 
the bottom is coming from the contrast shadow). Also, shadow strength is 
ignored... And again, shadow params is an open question.
  
  > - I think the same shadows should be used for windows and menus
  
  Yep, that's why I rejected the idea to approximate deco shadows. I've been 
thinking about moving shadow creation logic out so it could be used by 
KDecoration and KStyle plugin. What's your opinion on this?
  
  I would like to get input from VDG folks how menu shadows should look like.
  
  > - Also, thanks for posting the pictures. Is there any chance you could also 
post new vs old shadows side by side for the different sizes ? I have the 
feeling that for a given shadow size the new shadows appear larger ...
  
  OK. I'll post later.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10461: GMenu-DBusMenu-Proxy

[Kai Uwe Broulik]

broulik updated this revision to Diff 28836.
broulik added a comment.


  - Fix leaks
  - Cleanup

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10461?vs=28320&id=28836

REVISION DETAIL
  https://phabricator.kde.org/D10461

AFFECTED FILES
  CMakeLists.txt
  gmenu-dbusmenu-proxy/CMakeLists.txt
  gmenu-dbusmenu-proxy/Messages.sh
  gmenu-dbusmenu-proxy/actions.cpp
  gmenu-dbusmenu-proxy/actions.h
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.cpp
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.h
  gmenu-dbusmenu-proxy/gmenudbusmenuproxy.desktop
  gmenu-dbusmenu-proxy/icons.cpp
  gmenu-dbusmenu-proxy/icons.h
  gmenu-dbusmenu-proxy/main.cpp
  gmenu-dbusmenu-proxy/menu.cpp
  gmenu-dbusmenu-proxy/menu.h
  gmenu-dbusmenu-proxy/menuproxy.cpp
  gmenu-dbusmenu-proxy/menuproxy.h
  gmenu-dbusmenu-proxy/utils.cpp
  gmenu-dbusmenu-proxy/utils.h
  gmenu-dbusmenu-proxy/window.cpp
  gmenu-dbusmenu-proxy/window.h

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, mart, rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Plasma 5.12.3

[Jonathan Riddell]

Plasma 5.12.3 bug fix release is available now for packagers

https://www.kde.org/announcements/plasma-5.12.3.php

D10753: Provide the source selection as a contextual action

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Turning the checkboxes into radio buttons is tracked with 
https://bugs.kde.org/show_bug.cgi?id=391144.
  
  One more visual papercut: The menu is not wide enough to accommodate all the 
text, so long strings get cut off:
  F5743489: gets cut off.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  sourcesUI

REVISION DETAIL
  https://phabricator.kde.org/D10753

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10461: GMenu-DBusMenu-Proxy

[Kai Uwe Broulik]

broulik updated this revision to Diff 28838.
broulik added a comment.


  Fix UTF8_STRING atom type check

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10461?vs=28836&id=28838

REVISION DETAIL
  https://phabricator.kde.org/D10461

AFFECTED FILES
  CMakeLists.txt
  gmenu-dbusmenu-proxy/CMakeLists.txt
  gmenu-dbusmenu-proxy/Messages.sh
  gmenu-dbusmenu-proxy/actions.cpp
  gmenu-dbusmenu-proxy/actions.h
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.cpp
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.h
  gmenu-dbusmenu-proxy/gmenudbusmenuproxy.desktop
  gmenu-dbusmenu-proxy/icons.cpp
  gmenu-dbusmenu-proxy/icons.h
  gmenu-dbusmenu-proxy/main.cpp
  gmenu-dbusmenu-proxy/menu.cpp
  gmenu-dbusmenu-proxy/menu.h
  gmenu-dbusmenu-proxy/menuproxy.cpp
  gmenu-dbusmenu-proxy/menuproxy.h
  gmenu-dbusmenu-proxy/utils.cpp
  gmenu-dbusmenu-proxy/utils.h
  gmenu-dbusmenu-proxy/window.cpp
  gmenu-dbusmenu-proxy/window.h

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, mart, rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10753: Provide the source selection as a contextual action

[Nathaniel Graham]

ngraham requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10753

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[Andres Betts]

abetts added a comment.


  Number 2 seems like the best option. I would also make sure that there is a 
color difference between title label and sample text. That way it is easier to 
distinguish between list items. When all labels are the same color, you give 
equal importance to all elements.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Andres Betts]

abetts added a comment.


  Not sure if it is within the scope of this patch but the spacing is uneven 
vertically between elements in the notification window. They need more space to 
breathe.
  
  Media Player
  Cover Artwork
  Progress Bar
  
  |
  |
  
  Song Title
  
  |
  |
  
  Media Controls
  Window bottom edge
  
  It should be:
  
  |
  |
  
  Media Player
  
  |
  |
  
  Cover Artwork
  
  |
  |
  
  Progress Bar
  
  |
  |
  
  Song Title
  
  |
  |
  
  Media Controls
  
  |
  |
  
  Window bottom edge

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

To: romangg, #plasma, andreask
Cc: abetts, nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Nathaniel Graham]

ngraham added a comment.


  In D11063#220051 , @abetts wrote:
  
  > Not sure if it is within the scope of this patch but the spacing is uneven 
vertically between elements in the notification window. They need more space to 
breathe.
  >
  > Media Player
  >  Cover Artwork
  >  Progress Bar
  >
  > |
  > |
  >
  > Song Title
  >
  > |
  > |
  >
  > Media Controls
  >  Window bottom edge
  >
  > It should be:
  >
  > |
  > |
  >
  > Media Player
  >
  > |
  > |
  >
  > Cover Artwork
  >
  > |
  > |
  >
  > Progress Bar
  >
  > |
  > |
  >
  > Song Title
  >
  > |
  > |
  >
  > Media Controls
  >
  > |
  > |
  >
  > Window bottom edge
  
  
  IMHO that would be way too much whitespace. We already get a lot of user 
complaints that Plasma widgets and menus have excessive padding and whitespace.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

To: romangg, #plasma, andreask
Cc: ngraham, abetts, nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  Left - old
  Right - new
  
  ---
  
  Small
  
  F5743502: small.png 
  
  Medium
  
  F5743505: medium.png 
  
  Large
  
  F5743510: large.png 
  
  Very Large
  
  F5743512: very-large.png 
  
  ---
  
  God, Phabricator is awful! Image upload sometimes works, sometimes not. Also, 
typing a comment is very CPU intensive.. :/

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Nathaniel Graham]

ngraham added a comment.


  So in general, I like the more rounded edges. But I still don't like the 
darker shadows and the big black line on the bottom.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  @abetts @ngraham 
  Do you count from 0 or 1?
  
  Number 2 is single line `The quick brown fox...`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Nathaniel Graham]

ngraham added a comment.


  Here we are counting like humans, not programmers. :) We like this one: 
https://phabricator.kde.org/file/data/s2ekczgv5q5xxqwofahp/PHID-FILE-7wh4qv3a3lx6xe7f5khm/Screenshot_20180306_101833.png

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Andres Betts]

abetts added a comment.


  > F5743165: Screenshot_20180306_101833.png 

  
  I like this one! :D above

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Nathaniel Graham]

ngraham added a comment.


  Also FYI @progwolff your screenshots are messed up because if a bug in 
Spectacle that was recently fixed. Until you get that fix, you can use Active 
Window mode instead of Window Under Cursor mode.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10753: Provide the source selection as a contextual action

[Aleix Pol Gonzalez]

apol added a comment.


  This is an issue in qqc2-desktop-style, not something to solve from Discover.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10753

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  How about this?
  
  F5743529: Screenshot_20180306_164925.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Andres Betts]

abetts added a comment.


  That seems pretty good to me. I would even make the title label bigger, so 
that it looks like a header.
  
  Also, can the list be longer? At least, double the size? People tend to have 
a lot of fonts installed. We install a lot of them by default. This can help 
the user click and scroll less when looking for the right font. I have seen 
other OSs where they literally fill the screen with the list just to help you 
find what you need faster.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11098: use opacity instead of visible

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  Qt documentation recomends to bind to opacity instead of visible as visible
  cascades down. The tabbar used to trigger its height behavior anim when the
  popup got hidden, binding to opacity (even if opacity isn't animated) is a
  more correct behavior.
  Plus with visible it triggers the Qt bug 
https://bugreports.qt.io/browse/QTBUG-66907
  which in turn triggers https://bugs.kde.org/show_bug.cgi?id=391432
  
  BUG:391432

TEST PLAN
  kickoff never opens the last tab anymore

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/kickoffover

REVISION DETAIL
  https://phabricator.kde.org/D11098

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: mart, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  The list will always have the same 6 entries. This is not about choosing a 
font, but about choosing details about how a font is rendered.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11098: use opacity instead of visible

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/kickoffover

REVISION DETAIL
  https://phabricator.kde.org/D11098

To: mart, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11098: use opacity instead of visible

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3a763498b6a4: use opacity instead of visible (authored by 
mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11098?vs=28841&id=28842

REVISION DETAIL
  https://phabricator.kde.org/D11098

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: mart, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Andres Betts]

abetts added a comment.


  You are right! I was confused. Looks great then! Would having a font number 
on the side help?
  
  Like this
  
  12  **Font Name**
  
A quick brown fox jumps over the rope

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  We don't have a font name here. The choices are always "Vendor default", 
"None", "RGB", "BGR", "vertical RGB", "vertical BGR".
  I am not sure what a number would mean here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28844.
progwolff added a comment.


  - Merge branch 'master' of git://anongit.kde.org/plasma-desktop
  - adjust label opacity and size

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28817&id=28844

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  F5743545: Screenshot_20180306_170938.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Andres Betts]

abetts added a comment.


  In D11064#220102 , @progwolff 
wrote:
  
  > We don't have a font name here. The choices are always "Vendor default", 
"None", "RGB", "BGR", "vertical RGB", "vertical BGR".
  >  I am not sure what a number would mean here?
  
  
  Forget what I said. I keep getting confused.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  Seems like VDG is happy then :D  
  Many thanks to both of you!
  
  @davidedmundson Any objections left?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Andres Betts]

abetts added a comment.


  In D11064#220118 , @progwolff 
wrote:
  
  > Seems like VDG is happy then :D  
  >  Many thanks to both of you!
  >
  > @davidedmundson Any objections left?
  
  
  I don't have any objections. I would say, however, keep an open mind to 
feedback. If this lands, people may react differently to the work than what we 
think here. Interacting with your work everyday is different. Be ready in case 
changes are needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 28847.
zzag added a comment.


  take shadow strength into account

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28833&id=28847

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag planned changes to this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  Because shadow strength isn't ignored anymore, kstyle shadows should be 
updated
  F5743558: ftw.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  In D11064#220120 , @abetts wrote:
  
  > In D11064#220118 , @progwolff 
wrote:
  >
  > > Seems like VDG is happy then :D  
  > >  Many thanks to both of you!
  > >
  > > @davidedmundson Any objections left?
  >
  >
  > I don't have any objections. I would say, however, keep an open mind to 
feedback. If this lands, people may react differently to the work than what we 
think here. Interacting with your work everyday is different. Be ready in case 
changes are needed.
  
  
  Of course!
  It's probably the mixture of different ideas and tastes that come together 
what makes open source software so great.
  And as stated in the summary, we will continue the discussion in 
https://phabricator.kde.org/T7927.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Nathaniel Graham]

ngraham added a comment.


  I'm not thrilled with the really light 50% opacity labels, to be honest.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  In D11064#220131 , @ngraham wrote:
  
  > I'm not thrilled with the really light 50% opacity labels, to be honest.
  
  
  What do you propose? I am not much of a designer...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Andres Betts]

abetts added a comment.


  I would use this as a guide
  
  https://community.kde.org/KDE_Visual_Design_Group/HIG/Color
  
  And I would select Icon Grey for the header and Shade Black for the text 
below.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Nathaniel Graham]

ngraham added a comment.


  I thought it was okay before. It's very unusual and unnerving to have a 
header be de-emphasized compared to its content. My vote goes to using the 
standard colors from the active theme without messing with them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  In D11064#220134 , @ngraham wrote:
  
  > My vote goes to using the standard colors from the active theme without 
messing with them.
  
  
  At least we should not hardcode colors. So it's either an opacity of about 
0.8 to roughly match Icon Grey in the default palette, or just standard colors.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Re: Fwd: Re: kwin display issue on librem5

[Martin Flöser]

Am 2018-03-06 06:23, schrieb Bhushan Shah:

Hello,

On Mon, Mar 05, 2018 at 06:58:08PM -0700, Heather Ellsworth wrote:

Since PureOS is based on Debian buster, the versions of kwayland and
kwin I was running were:

kwayland 5.42.0-2
kwin 5.12.1-1

Using the patches attached to T8067...
1. I built and installed a kwayland 5.42.0-3 and kwin 5.12.1-2 from 
the

debian sources + the patches
2. rebooted for good measure
3. I uncommented the 'export QT_QPA_PLATFORM=wayland' line in the
plasma-phone script (so that it is back to the original version with 
no

changes)
4. Started kwin_wayland with:
$ kwin_wayland --drm plasma-phone

I can confirm that the patches remove the bad display issue and the
display looks great!!


Awesome, glad that helped!


When will the Plasma 5.13 release be ready? I can carry them in a fork
but I'd like to be working ideally off of packages included in Debian,
or at least the patched kwin and kwayland repos.


Since 5.13 is next feature release and we "just" released Plasma 5.12,
there is still time till Plasma 5.13 release, the beta is expected on
May 17, and final release is on June 12.

So I think best for you is to have a patched kwin and kwayland 
packages.


also note that kwayland is part of KDE frameworks, so hopefully at 
least

kwayland patch will be included in Next month's KDE Frameworks 5.45
release.


Given that this seems to fix a severe bug, we could consider to backport 
it to 5.12 with a conditional building if frameworks 5.45 is found. It's 
something we haven't done so far, but given that we face the issue of 
Wayland protocol incompatibilities more often recently, I think it's 
something we will have to do for other protocols as well.


Cheers
Martin

D10753: Provide the source selection as a contextual action

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  OK then!

REPOSITORY
  R134 Discover Software Store

BRANCH
  sourcesUI

REVISION DETAIL
  https://phabricator.kde.org/D10753

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart