gregormi added a comment.
Looks great. Thanks, Nate. (Sidenote: I wonder if there is an obvious way to
close the additional session. Currently, I use the keyboard: Ctrl+Shift+F8 and
then Ctrl+Alt+Back,Back)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org
gregormi added a comment.
Hi, here is the discussion around my the patch that introduced the Copy
button: https://phabricator.kde.org/D7087
Originally, I proposed the untranslated English text. Those are the reasons
that lead to the fact that we have the translated version:
https
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:92f9f21e496f: Copy to clipboard: match item order of
copied text with GUI (authored by gregormi).
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16818?vs=45282
gregormi added a comment.
Link to bug: https://bugs.kde.org/show_bug.cgi?id=400732
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D16818
To: gregormi, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas
gregormi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gregormi requested review of this revision.
REVISION SUMMARY
BUG: 400732
and: fix a typo in a comment nearby
REPOSITORY
R102 KInfoCenter
BRANCH
master
REVISION DETAIL
https
gregormi added a comment.
In D14830#345210 <https://phabricator.kde.org/D14830#345210>, @broulik wrote:
> Note that Microsoft removed that option in Vista in favor of a
"Personalize" option but brought a dedicated Screen configuration entry back in
Windows 7
gregormi added a comment.
In D14830#313645 <https://phabricator.kde.org/D14830#313645>, @davidedmundson
wrote:
> I am still waiting for a single justification.
In https://phabricator.kde.org/T6875, under "Who should be our primary target
groups?" we have &qu
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:c0f28efd280f: Add Copy Info button to the
About System KCM (authored by gregormi).
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=40853=40854
REVISION
gregormi updated this revision to Diff 40853.
gregormi added a comment.
- Use QVector instead of QList
- Use the term "Operating System:" instead of "Distro"
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=39321=4085
gregormi updated this revision to Diff 39321.
gregormi added a comment.
Rebase on master
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=37787=39321
BRANCH
arcpatch-D7087_1
REVISION DETAIL
https://phabricator.kde.org/D7087
AFFECTED FILES
gregormi added a comment.
+1; great to have also text on the Configure button (as a new Plasma user I
thought this was just a non-clickable icon)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D14145
To: ngraham, #plasma
Cc: gregormi, abetts, broulik, plasma
gregormi added a comment.
You're welcome. And: thanks for the patience to help improving this patch
comes also from my side :).
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma, colomar, broulik, mart, hein, rkflx
Cc: apol
gregormi updated this revision to Diff 37787.
gregormi added a comment.
- Module.ui: add horizontal spacers
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=37786=37787
BRANCH
arcpatch-D7087_1
REVISION DETAIL
https://phabricator.kde.org
gregormi added a comment.
What do you think about this minor layout change? It is noticeable when the
window is resized horizontally. Instead of centering the grid's middle line, it
makes the left and right padding space to the window border equal which looks
more pleasing at least to my
gregormi updated this revision to Diff 37786.
gregormi marked 4 inline comments as done.
gregormi added a comment.
- Module.ui: Fix glitch near KernelName
- Avoid double connection of copyToClipboard
- Hide dummy label
- Better naming of loop variable and optimize loop code
REPOSITORY
gregormi added inline comments.
INLINE COMMENTS
> rkflx wrote in Module.cpp:263
> Coming back to this after a month, I now wonder what `p` stands for, which
> might indicate that variable could get a better name…
p stands for labelPair: renaming is a good idea. Done.
>
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:d039c8c74dcb: Add new Tools button above
System Monitors process list (authored by gregormi).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs
gregormi updated this revision to Diff 37783.
gregormi added a comment.
- Use setShortcuts to simplify code
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs=37782=37783
BRANCH
arcpatch-D10297_2
REVISION DETAIL
https
gregormi updated this revision to Diff 37782.
gregormi marked an inline comment as done.
gregormi added a comment.
- Use setShortcuts to simplify code
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs=36895=37782
BRANCH
arcpatch-D10297_2
gregormi added a comment.
+1. I have a similar experience with the red X-Button as shown here for the
Activity Manager:
F6104707: grafik.png <https://phabricator.kde.org/F6104707>
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D14116
To: n
gregormi added a comment.
In D10297#272726 <https://phabricator.kde.org/D10297#272726>, @rkflx wrote:
> Awesome, I did not expect that the fix for the shortcuts would be so
simple. Thanks for your patience, we are nearly there…
INLINE COMMENTS
> rkflx wrote in ksysguardpro
gregormi updated this revision to Diff 36895.
gregormi marked an inline comment as done.
gregormi edited the summary of this revision.
gregormi added a comment.
- info comment
- Remove the now useless "not set" string
- Set shortcut text with Qt methods and omit the translati
gregormi marked 6 inline comments as done.
gregormi added inline comments.
INLINE COMMENTS
> rkflx wrote in Module.cpp:260
> Maybe you could avoid this special case if you added a hidden label in
> `loadSoftware`?
>
> Also, "label in … the button" sounds a bit o
gregormi updated this revision to Diff 36893.
gregormi added a comment.
- Rework the Module.ui layout to fix the spacing
- Add dummy label to remove special case for "Distro"
- Use C++11 for loop and add qAsConst
- Make RTL aware by not removing the colon
- Improve translati
gregormi added a comment.
I added some qDebug code in Module::copyToClipboard() and noticed that the
method is always called twice when the Copy to clipboard button is clicked.
When I remove the line 125 in Module.cpp: connect(ui->pushButtonCopyInfo,
::clicked, this, ::copyToClipbo
gregormi added a comment.
Thanks Henrik for the review. I fixed the layout and it looks now like this
in Qt Designer:
F5972316: grafik.png <https://phabricator.kde.org/F5972316>
The blue arrow shows a difference to your proposal. Do you think the grid
layout there is ok?
gregormi updated this revision to Diff 35172.
gregormi added a comment.
> The text should use title case: "Kill a Window"
DONE
> The parentheses look a bit ugly, in normal menus the shortcuts are simply
aligned to the right (not sure how that's done, though).
gregormi updated this revision to Diff 35167.
gregormi added a comment.
- use auto, add comment
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=35165=35167
BRANCH
arcpatch-D7087_1
REVISION DETAIL
https://phabricator.kde.org/D7087
AFFECTED
gregormi updated this revision to Diff 35165.
gregormi marked 4 inline comments as done.
gregormi added a comment.
- Handle colon (:) problem for translating and fix one label bug
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=35163=35165
gregormi marked an inline comment as done.
gregormi added inline comments.
INLINE COMMENTS
> rkflx wrote in Module.ui:333-338
> Do you need this? Pressing the Reset button for that property in Qt Designer
> removes this for me.
If I remove that part, the button gets wider; I wou
gregormi updated this revision to Diff 35163.
gregormi marked 3 inline comments as done.
gregormi added a comment.
- Fix comment
- Clean ui file
- Shortcut handling
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=35158=35163
BRANCH
gregormi marked 5 inline comments as done.
gregormi added inline comments.
INLINE COMMENTS
> gregormi wrote in Module.cpp:246
> Yes, I also had the list idea in an earlier stage of the patch< but without
> reusing the translated label text. I don't expect the information labels
gregormi updated this revision to Diff 35158.
gregormi marked 2 inline comments as done.
gregormi added a comment.
- Translate the Distro string
- Rename button to 'Copy to Clipboard' for more clarity; and consistency with
other applications
- Use a QList of QPairs to collect labels
gregormi marked an inline comment as done.
gregormi added inline comments.
INLINE COMMENTS
> rkflx wrote in Module.cpp:246
> Probably not strictly required for this patch, but it would be nicer to
> refactor this in such a way that adding another string to the UI does not
> re
gregormi added a comment.
@rkflx: Hi Henrik, I resolved all your code remarks. Could you look it over
and give a go to have this landed.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc
gregormi added a comment.
@ngraham , @rkflx, @dhaumann: Do you have any more suggestions to this? I
think it is now ready to land.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas
gregormi added a comment.
This now ready from my side.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen,
Pitel
gregormi updated this revision to Diff 34204.
gregormi added a comment.
- Use qApp->desktopFileName()
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs=34199=34204
BRANCH
arcpatch-D10297_2
REVISION DETAIL
https://phabricator.kde.
gregormi added inline comments.
INLINE COMMENTS
> rkflx wrote in ksysguardprocesslist.cpp:412
> Recently I learned comparing with `qApp->desktopFileName()` might be even
> better than looking at the path of the executable…
Interesting. This indeed returns "org.kde.ksysgu
gregormi marked an inline comment as done.
gregormi added inline comments.
INLINE COMMENTS
> rkflx wrote in CMakeLists.txt:37
> Is `Plasma` needed here? If so, I think this needs more discussion or should
> be made optional.
>
> KSysGuard can also be used in other deskt
gregormi updated this revision to Diff 34199.
gregormi marked 6 inline comments as done.
gregormi added a comment.
- Revert unrelated changes
- Remove not needed Plasma dependency
- Undo unrelated whitespace change
- Clean code
- Use blank lines instead of blocks
REPOSITORY
R111
gregormi updated this revision to Diff 34111.
gregormi added a comment.
- Apply comments by reviewers:
- move declaration near to usage
- Reuse label texts
- Rename label to more speaking name
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
gregormi added a comment.
In D10297#224935 <https://phabricator.kde.org/D10297#224935>, @apol wrote:
> Here's some thoughts:
>
> - Why is there only one with the keyboard shortcut? many of these have
(e.g. run a command)
The initial idea of the tools menu was t
gregormi added a comment.
Any more thoughts on this patch before it is ready to land?
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma
gregormi added a comment.
In D10297#220548 <https://phabricator.kde.org/D10297#220548>, @rkflx wrote:
> In D10297#220547 <https://phabricator.kde.org/D10297#220547>, @gregormi
wrote:
>
> > Some people from Plasma reviewed the original review request on
re
gregormi added a comment.
In D7087#207306 <https://phabricator.kde.org/D7087#207306>, @rkflx wrote:
> In D7087#207286 <https://phabricator.kde.org/D7087#207286>, @dhaumann wrote:
>
> > In fact, I wonder whether there already is a script or similar helper
tools
gregormi added a comment.
In D10297#207127 <https://phabricator.kde.org/D10297#207127>, @rkflx wrote:
> Just tried the patch. I think for System Activity / [Ctrl] + [⎋] the button
is fine (annoyingly with a slightly larger height than the combobox, but that's
life…). For
gregormi edited the summary of this revision.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham, dhaumann
Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg
gregormi added a comment.
In D7087#207081 <https://phabricator.kde.org/D7087#207081>, @ngraham wrote:
> Fine from my side. We still need to figure out the translation
issue--either work to make it translatable, or accept that this output will be
English-only. I'll let
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:50229e7ec3c2: Fix whitespace (authored by gregormi).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10535?vs=27232=27241
REVISION DETAIL
https
gregormi added a comment.
Unrelated whitespace changes here: https://phabricator.kde.org/D10535
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot,
progwolff
gregormi retitled this revision from "Fix whitespace; this patch was extracted
from here https://phabricator.kde.org/D10297; to "Fix whitespace".
gregormi edited the summary of this revision.
gregormi edited the test plan for this revision.
gregormi added a reviewer: Plasma.
RE
gregormi created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gregormi requested review of this revision.
REPOSITORY
R111 KSysguard Library
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10535
AFFECTED
gregormi marked 2 inline comments as done.
gregormi added a comment.
Ready from my side.
INLINE COMMENTS
> ngraham wrote in ksysguardprocesslist.cpp:360
> Let's do unrelated whitespace/style cleanup in another patch.
does this comment still apply?
REPOSITORY
R111 KSysguard L
gregormi updated this revision to Diff 27231.
gregormi marked an inline comment as done.
gregormi added a comment.
- remove unrelated changes
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs=27223=27231
BRANCH
arcpatch-D10297_2
gregormi abandoned this revision.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10534
To: gregormi
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
gregormi updated this revision to Diff 27229.
gregormi added a comment.
...
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10534?vs=27227=27229
BRANCH
arcpatch-D10297_1
REVISION DETAIL
https://phabricator.kde.org/D10534
AFFECTED FILES
gregormi abandoned this revision.
gregormi removed a project: Plasma.
gregormi added a comment.
Restricted Application added a project: Plasma.
Tried to remove unrelated changes which results in a separate Phabricator
Differential
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https
gregormi created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gregormi requested review of this revision.
REPOSITORY
R111 KSysguard Library
BRANCH
arcpatch-D10297
REVISION DETAIL
https://phabricator.kde.org/D10534
gregormi edited the summary of this revision.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
gregormi updated this revision to Diff 27223.
gregormi added a comment.
- add missing include
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs=27222=27223
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10297
AFFECTED
gregormi updated this revision to Diff 27222.
gregormi added a comment.
- Merge remote-tracking branch 'origin/master'
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs=27221=27222
BRANCH
master
REVISION DETAIL
https
gregormi updated this revision to Diff 27221.
gregormi marked an inline comment as done.
gregormi added a comment.
- fix mem leak
- Set application-menu icon for Tools button
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs=26779=27221
gregormi added a comment.
Is there anything else I can do for this patch?
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham, dhaumann
Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot,
progwolff, lesliezhai
gregormi added a comment.
I just did a quick search for "menu" in the icon name:
F5698881: grafik.png <https://phabricator.kde.org/F5698881>
Sadly, the one, that is not so bold, looks rather strange.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://pha
gregormi added a comment.
In https://phabricator.kde.org/D10297#203138, @ngraham wrote:
> One more thought. For for consistency, maybe the tools menu should have a
horrible hamburger menu icon like the otherwise identiacal one we added to
Spectacle recently?
Do we really n
gregormi edited the summary of this revision.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma
Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
gregormi updated this revision to Diff 26779.
gregormi edited the summary of this revision.
gregormi added a comment.
- Do not show KSysGuard item if we are within KSysGuard
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs=26767=26779
gregormi added a comment.
In https://phabricator.kde.org/D10297#203118, @ngraham wrote:
> Feature-wise, I love it. My only objection is that I'd really like to
somehow remove the redundant KSysGuard entry from the menu if it was opened as
a standalone app, not via the [
gregormi edited the summary of this revision.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma
Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
gregormi added a comment.
In https://phabricator.kde.org/D10297#203110, @ngraham wrote:
> How about a new screenshot in the Summary section? ;)
How could I forget that :-). I'll add one.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10
gregormi added a reviewer: Plasma.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma
Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
gregormi added a comment.
In https://phabricator.kde.org/D10297#203027, @ngraham wrote:
> Maybe make it a PushButton instead of a ToolButton, and it will magically
work? Here's how @rkflx implemented an appropriate Tools menu in Spectacle
recently: D10371: Move printing to a new to
gregormi updated this revision to Diff 26767.
gregormi added a comment.
- Use to PushButton instead of QToolButton to put the down arrow to right
side. Still no manual setting of the icon needed.
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
gregormi updated this revision to Diff 26765.
gregormi added a comment.
Rebase to master. Tested again successfully. Ready from my side.
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=26764=26765
BRANCH
arcpatch-D7087
REVISION DETAIL
gregormi marked 2 inline comments as done.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham, dhaumann
Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts
gregormi marked an inline comment as done.
gregormi added inline comments.
INLINE COMMENTS
> gregormi wrote in Module.cpp:29
> This was a suggestion from the discussion on ReviewBoard. Is there an obvious
> way to tell arc to do this in a separate commit? Otherwise I'll try to
&
gregormi marked an inline comment as done.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham, dhaumann
Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts
gregormi updated this revision to Diff 26764.
gregormi added a comment.
- remove unrelated change
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=26493=26764
BRANCH
arcpatch-D7087
REVISION DETAIL
https://phabricator.kde.org/D7087
AFFECTED
gregormi added a comment.
In https://phabricator.kde.org/D7087#201065, @gregormi wrote:
> In https://phabricator.kde.org/D7087#200541, @gregormi wrote:
>
> > - Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does
not work (I will remove it if that'
gregormi added a comment.
The "All processes" button is a QCombobox. It feels like a dirty hack to turn
QCombobox into a drop down menu just to get the arrow at the correct position.
@ngraham: Just to be sure, do you think this is the way to go?
REPOSITORY
R111 KSysguard Library
gregormi added a comment.
In https://phabricator.kde.org/D7087#200541, @gregormi wrote:
> - Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does not
work (I will remove it if that's not easily fixable)
@dhaumann: any idea why the shortcut does not work h
gregormi added inline comments.
INLINE COMMENTS
> ngraham wrote in Module.cpp:29
> Is this necessary for this patch? If not, let's address it in a different
> patch or commit.
This was a suggestion from the discussion on ReviewBoard. Is there an obvious
way to tell
gregormi added a comment.
In https://phabricator.kde.org/D7087#201047, @dhaumann wrote:
> Translation is not yet working correctly, see above comment.
In the comment of the function copyToClipboard(); I wrote the following:
"Copies the software and hardware inf
gregormi added a comment.
In https://phabricator.kde.org/D10297#200680, @ngraham wrote:
> You can't just add the appropriate arrow icon to a regular button; you have
to actually use the correct type of button from the start, and then it gets the
icon in the right place automatica
gregormi added a reviewer: floeser.
gregormi added a comment.
In https://phabricator.kde.org/D10297#200668, @ngraham wrote:
> Seems useful! Couple of nitpicks:
>
> - `KsysGuard` itself appears in the menu :)
Yes, I know :-(. When someone presses Ctrl+Esc then t
gregormi edited the summary of this revision.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
gregormi added a comment.
Add screenshot:
F5691853: grafik.png <https://phabricator.kde.org/F5691853>
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreut
gregormi retitled this revision from "- Migrate from ReviewBoard
https://git.reviewboard.kde.org/r/128854/
- fix QStringLiteral
- Remove drop down arrow because it looks inconsistent with the widget left to
it" to "Add new "Tools" button above System Monitor's proce
gregormi created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gregormi requested review of this revision.
TEST PLAN
- Verify that each action in the menu works.
- Verify that if the global keyboard shortcut for Kill
gregormi retitled this revision from "WIP: Add menu with "Copy to Clipboard" to
the About System module" to "Add "Copy Info" button to the About System KCM".
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
T
gregormi updated this revision to Diff 26493.
gregormi added a comment.
- Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does not
work (I will remove it if that's not easily fixable)
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
gregormi updated this revision to Diff 26491.
gregormi added a comment.
- fix cleanup old code from previous revision
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=26490=26491
BRANCH
arcpatch-D7087
REVISION DETAIL
https
gregormi updated this revision to Diff 26490.
gregormi added a comment.
- cleanup old code from previous revision
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=26489=26490
BRANCH
arcpatch-D7087
REVISION DETAIL
https://phabricator.kde.org
gregormi updated this revision to Diff 26489.
gregormi added a comment.
- remove menu and update button position
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=17613=26489
BRANCH
arcpatch-D7087
REVISION DETAIL
https://phabricator.kde.org
gregormi added a comment.
Screenshot of new button location: F5691627: grafik.png
<https://phabricator.kde.org/F5691627>
Updated code follows.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham
Cc: ltoscano, sebas, elvisange
gregormi edited the summary of this revision.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
gregormi added a comment.
Any suggestions how to proceed with this?
I personally find the position of the menu not out of place because it is
centered like the main dialog's content.
The reason I put the "About KDE" item into the menu is because it is the
&qu
gregormi added a comment.
> 2. In KInfoCenter the "Module Help" button seems to be broken. E.g. "Help"
on the Memory KCM starts the Help Center at the correct location but the
corresponding "Module Help" button in KInfoCenter opens a Help Center page
tit
gregormi added a comment.
In https://phabricator.kde.org/D7087#131726, @sebas wrote:
> In https://phabricator.kde.org/D7087#131719, @gregormi wrote:
>
> > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote:
> >
> > > Why not just a
1 - 100 of 105 matches
Mail list logo
