Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-29 Thread Daniel Pittman
Igal Koshevoy i...@pragmaticraft.com writes: On Wed, Oct 27, 2010 at 5:34 PM, Daniel Pittman dan...@rimspace.net wrote: I am going to mention patchwork again - a bunch of Linux kernel projects use it to monitor patches that go past on their lists; it could easily capture, in fact, not just

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-29 Thread Daniel Pittman
Jacob Helwig ja...@puppetlabs.com writes: On Thu, 28 Oct 2010 11:34:48 +1100, Daniel Pittman wrote: I am going to mention patchwork again - a bunch of Linux kernel projects use it to monitor patches that go past on their lists; it could easily capture, in fact, not just the deliberate dev

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Felix Frank
As far as Gerrit...well...I rather dislike it, actually. I think that it has a rather awkward work-flow. Especially if you're not all that familiar with Git (and even if you are). I'd rather not raise the bar for submitting patches quite that high. Hi, I've worked with gerrit on OpenAFS,

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Paul Nasrat
On 27 October 2010 21:10, Matt Robinson m...@puppetlabs.com wrote: We've gotten feedback that a lot of the patches that are sent to the puppet-dev list aren't terribly useful to our community to read and tend to overwhelm the conversation. -1. How was this survey carried out? It's pretty easy

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Peter Meier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 We've gotten feedback that a lot of the patches that are sent to the puppet-dev list aren't terribly useful to our community to read and tend to overwhelm the conversation. -1. How was this survey carried out? It's pretty easy to filter mail

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Dean Wilson
On 27 October 2010 21:42, Brice Figureau brice-pup...@daysofwonder.com wrote: * I'd miss the review comments, usually of high value, giving more insights on internals. I agree with everything Brice said about the patches. Seeing the discussion about adding unit tests for example helped me

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Markus Roberts
So do we have any characterization of who didn't want to see code on puppet-dev? Are there any individuals that would like to come forward and speak for that side, or does anyone know who (in a general, demographic sense) was pushing for this change? -- Markus

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Nigel Kersten
On Thu, Oct 28, 2010 at 7:52 AM, Markus Roberts mar...@puppetlabs.com wrote: So do we have any characterization of who didn't want to see code on puppet-dev?  Are there any individuals that would like to come forward and speak for that side, or does anyone know who (in a general, demographic

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread R.I.Pienaar
- Markus Roberts mar...@puppetlabs.com wrote: So do we have any characterization of who didn't want to see code on puppet-dev? Are there any individuals that would like to come forward and speak for that side, or does anyone know who (in a general, demographic sense) was pushing for this

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Jeff McCune
On Thu, Oct 28, 2010 at 11:02 AM, Nigel Kersten ni...@puppetlabs.com wrote: On Thu, Oct 28, 2010 at 7:52 AM, Markus Roberts mar...@puppetlabs.com wrote: So do we have any characterization of who didn't want to see code on puppet-dev?  Are there any individuals that would like to come forward

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Nigel Kersten
On Thu, Oct 28, 2010 at 2:56 AM, Paul Nasrat pnas...@gmail.com wrote: On 27 October 2010 21:10, Matt Robinson m...@puppetlabs.com wrote: We've gotten feedback that a lot of the patches that are sent to the puppet-dev list aren't terribly useful to our community to read and tend to overwhelm

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Markus Roberts
We just absolutely should not have two patch review lists, one for community patches and one for puppet labs employee patches. Strongly agreed. -- Markus --- The power of accurate observation is commonly called cynicism by those who have

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Luke Kanies
On Oct 28, 2010, at 10:12 AM, Markus Roberts wrote: We just absolutely should not have two patch review lists, one for community patches and one for puppet labs employee patches. Strongly agreed. I don't think anyone was recommending that - the question was what's the best way to

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-28 Thread Markus Roberts
We just absolutely should not have two patch review lists, one for community patches and one for puppet labs employee patches. Strongly agreed. I don't think anyone was recommending that - the question was what's the best way to review patches, not how we can do privately. If we have two

[Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Matt Robinson
We've gotten feedback that a lot of the patches that are sent to the puppet-dev list aren't terribly useful to our community to read and tend to overwhelm the conversation. Because of this we're going to try no longer sending patches from the internal dev team to the list (community members will

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread R.I.Pienaar
hello, I find the code hard to read - due to the nature of diff's of complex code only making sense to people who know the code. But I do find the discussion around the code review helpful and would be a shame to not see that. - Matt Robinson m...@puppetlabs.com wrote: We've gotten

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Brice Figureau
Hi, On 27/10/10 22:10, Matt Robinson wrote: We've gotten feedback that a lot of the patches that are sent to the puppet-dev list aren't terribly useful to our community to read and tend to overwhelm the conversation. Because of this we're going to try no longer sending patches from the

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Thomas S Hatch
I am going to have to agree with the previous two posts, sure, I don't read the code commits, and my inbox is a cluttered disaster of puppet-dev mail, but I know whats going on, and there are many times when I am informed about something that matters in puppet development just by reading the

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Markus Roberts
I'm with Brice, R.I., Thomas on this one. -- Markus --- The power of accurate observation is commonly called cynicism by those who have not got it. ~George Bernard Shaw -- You

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Jeff McCune
On Wed, Oct 27, 2010 at 4:49 PM, Thomas S Hatch thatc...@gmail.com wrote: If it is moved off list, please maintain a public list where we can continue to receive these posts. +1 for maintaining a public list. I personally find it very useful. I also think there should just be one list for

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Luke Kanies
On Oct 27, 2010, at 1:54 PM, Jeff McCune wrote: On Wed, Oct 27, 2010 at 4:49 PM, Thomas S Hatch thatc...@gmail.com wrote: If it is moved off list, please maintain a public list where we can continue to receive these posts. +1 for maintaining a public list. I personally find it very useful.

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread James Turnbull
Markus Roberts wrote: I'm with Brice, R.I., Thomas on this one. As am I - pretty firmly so. James -- Puppet Labs - http://www.puppetlabs.com C: 503-734-8571 -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread James Turnbull
Luke Kanies wrote: On Oct 27, 2010, at 1:54 PM, Jeff McCune wrote: On Wed, Oct 27, 2010 at 4:49 PM, Thomas S Hatch thatc...@gmail.com wrote: If it is moved off list, please maintain a public list where we can continue to receive these posts. +1 for maintaining a public list. I personally

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Trevor Vaughan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 +1 Here as well... On 10/27/2010 05:51 PM, James Turnbull wrote: Markus Roberts wrote: I'm with Brice, R.I., Thomas on this one. As am I - pretty firmly so. James - -- Trevor Vaughan Vice President, Onyx Point, Inc. email:

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Daniel Pittman
James Turnbull ja...@puppetlabs.com writes: Luke Kanies wrote: On Oct 27, 2010, at 1:54 PM, Jeff McCune wrote: On Wed, Oct 27, 2010 at 4:49 PM, Thomas S Hatch thatc...@gmail.com wrote: If it is moved off list, please maintain a public list where we can continue to receive these posts. +1

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Jacob Helwig
On Thu, 28 Oct 2010 11:34:48 +1100, Daniel Pittman wrote: I am going to mention patchwork again - a bunch of Linux kernel projects use it to monitor patches that go past on their lists; it could easily capture, in fact, not just the deliberate dev list things, but also the user list set of

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Igal Koshevoy
On Wed, Oct 27, 2010 at 5:34 PM, Daniel Pittman dan...@rimspace.net wrote: I am going to mention patchwork again - a bunch of Linux kernel projects use it to monitor patches that go past on their lists; it could easily capture, in fact, not just the deliberate dev list things, but also the user

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

2010-10-27 Thread Markus
Gerit is a much bigger change of process, though, than patchwork. :) You say that like it's a bad thing. -- Markus -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send email to puppet-...@googlegroups.com. To