[PATCH v2 2/3] virtio-balloon: fix memory leak while attach virtio-balloon device

2019-12-03 Thread pannengyuan
From: Pan Nengyuan ivq/dvq/svq/free_page_vq is forgot to cleanup in virtio_balloon_device_unrealize, the memory leak stack is as follow: Direct leak of 14336 byte(s) in 2 object(s) allocated from: #0 0x7f99fd9d8560 in calloc (/usr/lib64/libasan.so.3+0xc7560) #1 0x7f99fcb20015 in

Re: [PATCH 20/21] hw/intc/s390: Simplify error handling in kvm_s390_flic_realize()

2019-12-03 Thread Markus Armbruster
Halil Pasic writes: > On Mon, 2 Dec 2019 17:40:07 +0100 > Cornelia Huck wrote: > >> On Sat, 30 Nov 2019 20:42:39 +0100 >> Markus Armbruster wrote: >> >> > Cc: Halil Pasic >> > Cc: Cornelia Huck >> > Cc: Christian Borntraeger >> > Signed-off-by: Markus Armbruster >> > --- >> >

[PATCH v2 3/3] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

2019-12-03 Thread pannengyuan
From: Pan Nengyuan ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in virtio_serial_device_unrealize, the memory leak stack is as bellow: Direct leak of 1290240 byte(s) in 180 object(s) allocated from: #0 0x7fc9bfc27560 in calloc (/usr/lib64/libasan.so.3+0xc7560) #1 0x7fc9bed6f015 in

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Pan Nengyuan
On 2019/12/4 15:19, Vladimir Sementsov-Ogievskiy wrote: > 04.12.2019 6:12, pannengyuan wrote: >> >> >> On 2019/12/4 1:38, Vladimir Sementsov-Ogievskiy wrote: >>> Hi! >>> >>> First, please, when sending more than one patch, create a cover-letter. >>> Also, >>> summarize (in cover letter) what

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
04.12.2019 6:12, pannengyuan wrote: > > > On 2019/12/4 1:38, Vladimir Sementsov-Ogievskiy wrote: >> Hi! >> >> First, please, when sending more than one patch, create a cover-letter. Also, >> summarize (in cover letter) what was changed since previous version. > In previous version, I only send

[PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-03 Thread pannengyuan
From: Pan Nengyuan Devices tend to maintain vq pointers, allow deleting them trough a vq pointer. Signed-off-by: Michael S. Tsirkin Signed-off-by: Pan Nengyuan --- Changes v2 to v1: - add a new function virtio_delete_queue to cleanup vq through a vq pointer --- hw/virtio/virtio.c |

Re: [PATCH 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

2019-12-03 Thread Philippe Mathieu-Daudé
On 12/2/19 10:09 PM, Niek Linnenbank wrote: Dear QEMU developers, Hereby I would like to contribute the following set of patches to QEMU which add support for the Allwinner H3 System on Chip and the Orange Pi PC machine. The following features and devices are supported: * SMP (Quad Core

Re: [PATCH 0/6] qapi: Module fixes and cleanups

2019-12-03 Thread Markus Armbruster
Markus Armbruster writes: > Kevin recently posted a minimally invasive fix for empty QAPI > modules[*]. This is my attempt at a fix that also addresses the > design weakness that led to the bug. Queued for 5.0.

Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2019-12-03 Thread Thomas Huth
On 03/12/2019 09.51, Philippe Mathieu-Daudé wrote: > On 12/3/19 9:25 AM, Thomas Huth wrote: >> On 03/12/2019 08.45, Philippe Mathieu-Daudé wrote: >>> On 12/3/19 8:29 AM, Thomas Huth wrote: It's been deprecated since QEMU v3.1. The 40p machine should be used nowadays instead.

Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2019-12-03 Thread Philippe Mathieu-Daudé
On 12/3/19 10:15 AM, Thomas Huth wrote: On 03/12/2019 09.51, Philippe Mathieu-Daudé wrote: On 12/3/19 9:25 AM, Thomas Huth wrote: On 03/12/2019 08.45, Philippe Mathieu-Daudé wrote: On 12/3/19 8:29 AM, Thomas Huth wrote: It's been deprecated since QEMU v3.1. The 40p machine should be used

Re: [PATCH 0/3] iotests: Check for the possibility to create large files

2019-12-03 Thread Alex Bennée
Thomas Huth writes: > Travis recently added the possibility to test on ppc64le, arm64 and s390x > hosts, too. However, the containers are very restricted there and do not > allow the creation of large files, so that the tests 060 and 079 are > currently failing there. So let's add some proper

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
We seem to be coming to the conclusion something that: a) It should live in the qemu tree b) It shouldn't live under contrib c) We'll create a new top level, i.e. 'daemons' d) virtiofsd will be daemons/virtiofsd Now, somethings I'm less clear on: e) What else would move into daemons?

Re: [PULL 0/1] HVF fix QEMU 4.2-rc

2019-12-03 Thread Peter Maydell
On Tue, 3 Dec 2019 at 08:16, Paolo Bonzini wrote: > > The following changes since commit 39032981fa851d25fb27527f25f046fed800e585: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2019-12-02' > into staging (2019-12-02 16:29:41 +) > > are available in the Git repository at:

Re: virtiofsd: Where should it live?

2019-12-03 Thread Daniel P . Berrangé
On Tue, Dec 03, 2019 at 11:06:44AM +, Peter Maydell wrote: > On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert > wrote: > > > > We seem to be coming to the conclusion something that: > > > > a) It should live in the qemu tree > > b) It shouldn't live under contrib > > c) We'll create

Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2019-12-03 Thread Thomas Huth
On 03/12/2019 08.45, Philippe Mathieu-Daudé wrote: > On 12/3/19 8:29 AM, Thomas Huth wrote: >> It's been deprecated since QEMU v3.1. The 40p machine should be >> used nowadays instead. >> >> Signed-off-by: Thomas Huth >> --- >>   .gitmodules    |   3 - >>   MAINTAINERS   

Re: [PATCH] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

2019-12-03 Thread Laurent Vivier
On 03/12/2019 01:53, pannengyuan wrote: > > > On 2019/12/2 21:58, Laurent Vivier wrote: >> On 02/12/2019 12:15, pannengy...@huawei.com wrote: >>> From: PanNengyuan >>> >>> ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in >>> virtio_serial_device_unrealize, the memory leak stack is as bellow: >>>

Re: [PATCH 2/2] Add -mem-shared option

2019-12-03 Thread Thomas Huth
On 02/12/2019 22.00, Eduardo Habkost wrote: > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote: >> On Fri, 29 Nov 2019 18:46:12 +0100 >> Paolo Bonzini wrote: >> >>> On 29/11/19 13:16, Igor Mammedov wrote: As for "-m", I'd make it just an alias that translates

Re: [PATCH 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

2019-12-03 Thread Philippe Mathieu-Daudé
On 12/2/19 10:09 PM, Niek Linnenbank wrote: Dear QEMU developers, Hereby I would like to contribute the following set of patches to QEMU which add support for the Allwinner H3 System on Chip and the Orange Pi PC machine. The following features and devices are supported: * SMP (Quad Core

Re: [PATCH v37 00/17] QEMU AVR 8 bit cores

2019-12-03 Thread Michael Rolnik
Aleksandar. enjoy your vacation. Regards, Michael Rolnik On Tue, Dec 3, 2019 at 3:48 AM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Tuesday, December 3, 2019, Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote: > >> >> >> On Tuesday, December 3, 2019, Aleksandar

Re: [PATCH v2 3/3] s390x: Fix cpu normal reset ri clearing

2019-12-03 Thread David Hildenbrand
On 02.12.19 15:01, Janosch Frank wrote: > As it turns out we need to clear the ri controls and PSW enablement > bit to be architecture compliant. > > Signed-off-by: Janosch Frank > --- > target/s390x/cpu.c | 5 + > target/s390x/cpu.h | 7 ++- > 2 files changed, 11 insertions(+), 1

Re: [PATCH v5 01/13] add device_legacy_reset function to prepare for reset api change

2019-12-03 Thread Cornelia Huck
On Fri, 18 Oct 2019 17:06:18 +0200 Damien Hedde wrote: > Provide a temporary device_legacy_reset function doing what > device_reset does to prepare for the transition with Resettable > API. > > All occurrence of device_reset in the code tree are also replaced > by device_legacy_reset. > > The

Re: [PATCH v5 03/13] hw/core: create Resettable QOM interface

2019-12-03 Thread Cornelia Huck
On Fri, 18 Oct 2019 17:06:20 +0200 Damien Hedde wrote: > This commit defines an interface allowing multi-phase reset. This aims > to solve a problem of the actual single-phase reset (built in > DeviceClass and BusClass): reset behavior is dependent on the order > in which reset handlers are

Re: [PATCH v5 00/13] Multi-phase reset mechanism

2019-12-03 Thread Cornelia Huck
On Fri, 18 Oct 2019 17:06:17 +0200 Damien Hedde wrote: > Hi all, > > The purpose of this series is to split the current reset procedure > into multiple phases. This will help to solve some ordering > difficulties we have during reset. Previous version can be found here: >

[PATCH 3/5] tests: fw_cfg: Use virt as default machine in fw_cfg-test.c

2019-12-03 Thread Xiang Zheng
The default machine type on aarch64 is not set which causes error in qtest_init(). Here we use the "virt" machine as the default machine type on aarch64. Signed-off-by: Xiang Zheng --- tests/fw_cfg-test.c | 65 +++-- 1 file changed, 51 insertions(+), 14

Re: [PATCH 10/10] arm: allwinner-h3: add EMAC ethernet device

2019-12-03 Thread KONRAD Frederic
Le 12/2/19 à 10:09 PM, Niek Linnenbank a écrit : The Allwinner H3 System on Chip includes an Ethernet MAC (EMAC) which provides 10M/100M/1000M Ethernet connectivity. This commit adds support for the Allwinner H3 EMAC, including emulation for the following functionality: * DMA transfers *

[PATCH 1/5] tests: fw_cfg: Rename pc_fw_cfg_* to fw_cfg_*

2019-12-03 Thread Xiang Zheng
Rename pc_fw_cfg_* to fw_cfg_* to make them common for other architectures so that we can run fw_cfg tests on aarch64. Signed-off-by: Xiang Zheng --- tests/fw_cfg-test.c | 48 tests/hd-geo-test.c | 6 ++--- tests/libqos/fw_cfg.h| 20

[PATCH 0/5] tests: Enable fw_cfg tests on AArch64

2019-12-03 Thread Xiang Zheng
There are quite a few tests disabled on AArch64 such as fw_cfg-tests. This patch series fix some problems in test code and adapt it to virt machine. Xiang Zheng (5): tests: fw_cfg: Rename pc_fw_cfg_* to fw_cfg_* tests: fw_cfg: Support read/write of fw_cfg registers on aarch64 tests: fw_cfg:

Re: [PATCH] monitor: Fix slow reading

2019-12-03 Thread Yury Kotov
02.12.2019, 23:50, "Markus Armbruster" : > Yury Kotov writes: > >>  Hi! >> >>  29.11.2019, 11:22, "Markus Armbruster" : >>>  Yury Kotov writes: >>>   The monitor_can_read (as a callback of qemu_chr_fe_set_handlers)   should return size of buffer which monitor_qmp_read or monitor_read

Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2019-12-03 Thread Philippe Mathieu-Daudé
On 12/3/19 9:25 AM, Thomas Huth wrote: On 03/12/2019 08.45, Philippe Mathieu-Daudé wrote: On 12/3/19 8:29 AM, Thomas Huth wrote: It's been deprecated since QEMU v3.1. The 40p machine should be used nowadays instead. Signed-off-by: Thomas Huth ---   .gitmodules    |   3 -  

Re: Network connection with COLO VM

2019-12-03 Thread Daniel Cho
Hi Dave, We could use the exist interface to add netfilter and chardev, it might not have the problem you said. However, the netfilter and chardev on the primary at the start, that means we could not dynamic set COLO feature to VM? We try to change this chardev to prevent primary VM will stuck

[Bug 1854910] [NEW] Support VHDX differencing images (ie images with backing)

2019-12-03 Thread Mark Zealey
Public bug reported: The qemu vhdx driver does not support type 2 (differencing) vhdx images (usually stored with file extension .avhdx). This means that any hyperv images with snapshots are not supported by qemu-img. It would be great to be able to convert to a new qcow image from a backing +

Re: [PATCH v2 3/3] s390x: Fix cpu normal reset ri clearing

2019-12-03 Thread Christian Borntraeger
On 02.12.19 15:01, Janosch Frank wrote: > As it turns out we need to clear the ri controls and PSW enablement > bit to be architecture compliant. > > Signed-off-by: Janosch Frank > --- > target/s390x/cpu.c | 5 + > target/s390x/cpu.h | 7 ++- > 2 files changed, 11 insertions(+), 1

Re: [PATCH v5 02/13] hw/core/qdev: add trace events to help with resettable transition

2019-12-03 Thread Cornelia Huck
On Fri, 18 Oct 2019 17:06:19 +0200 Damien Hedde wrote: > Adds trace events to reset procedure and when updating the parent > bus of a device. > > Signed-off-by: Damien Hedde > --- > hw/core/qdev.c | 27 --- > hw/core/trace-events | 9 + > 2 files

Re: virtiofsd: Where should it live?

2019-12-03 Thread Peter Maydell
On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert wrote: > > We seem to be coming to the conclusion something that: > > a) It should live in the qemu tree > b) It shouldn't live under contrib > c) We'll create a new top level, i.e. 'daemons' > d) virtiofsd will be daemons/virtiofsd > >

Re: [PATCH v37 12/17] target/avr: Add example board configuration

2019-12-03 Thread Philippe Mathieu-Daudé
On 11/30/19 5:57 PM, Michael Rolnik wrote: Hi Aleksandar. I guess no testing would be possible. My previous series of patches (about 2 years ago, before Sarah joined) did not contain any peripherals, there were only the CPU and the sample board, I used it to test instructions. Somebody

[PATCH 4/5] hw/arm/virt: Add FW_CFG_RAM_SIZE and FW_CFG_MAX_CPUS into fw_cfg

2019-12-03 Thread Xiang Zheng
I'm not sure whether it's neccesary to add FW_CFG_RAM_SIZE and FW_CFG_MAX_CPUS into fw_cfg on virt machine. This patch just makes the fw_cfg-test happy. Signed-off-by: Xiang Zheng --- hw/arm/virt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

2019-12-03 Thread David Hildenbrand
>> s390x: Fix query-cpu-model-FOO error API violations >> >> cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), >> qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It >> dereferences @errp when the visitor or the QOM setter fails. That's >>

Re: [PATCH v2 2/2] travis.yml: Run tcg tests with tci

2019-12-03 Thread Alex Bennée
Thomas Huth writes: > On 28/11/2019 22.06, Stefan Weil wrote: >> Am 28.11.19 um 16:35 schrieb Thomas Huth: >> >>> So far we only have compile coverage for tci. But since commit >>> 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation >>> for INDEX_op_ld16u_i64") has been

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert > wrote: > > > > We seem to be coming to the conclusion something that: > > > > a) It should live in the qemu tree > > b) It shouldn't live under contrib > > c) We'll create a new top

Re: [PATCH 1/2] exec: flush CPU TB cache in breakpoint_invalidate

2019-12-03 Thread Alex Bennée
Richard Henderson writes: > On 11/27/19 10:06 PM, Max Filippov wrote: >> When a breakpoint is inserted at location for which there's currently no >> virtual to physical translation no action is taken on CPU TB cache. If a >> TB for that virtual address already exists but is not visible ATM the

Re: [PATCH v5 11/13] hw/s390x/ipl: replace deprecated qdev_reset_all registration

2019-12-03 Thread Cornelia Huck
On Fri, 18 Oct 2019 17:06:28 +0200 Damien Hedde wrote: > Replace deprecated qdev_reset_all by resettable_cold_reset_fn for > the ipl registration in the main reset handlers. > > This does not impact the behavior for the following reasons: > + at this point resettable just call the old reset

Re: [PATCH] virtfs-proxy-helper: switch from libcap to libcap-ng

2019-12-03 Thread Paolo Bonzini
On 03/12/19 11:34, Greg Kurz wrote: > On Fri, 29 Nov 2019 13:59:37 +0100 > Greg Kurz wrote: > >> On Fri, 29 Nov 2019 13:49:20 +0100 >> Paolo Bonzini wrote: >> >>> On 29/11/19 13:32, Greg Kurz wrote: Nice. :) Reviewed-by: Greg Kurz Paolo, I can take this

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-03 Thread Philippe Mathieu-Daudé
On 12/2/19 10:09 PM, Niek Linnenbank wrote: The Xunlong Orange Pi PC is an Allwinner H3 System on Chip based embedded computer with mainline support in both U-Boot and Linux. The board comes with a Quad Core Cortex A7 @ 1.3GHz, 512MB RAM, 100Mbit ethernet, USB, SD/MMC, USB, HDMI and various

Re: [PATCH v6] 9pfs: well form error hint helpers

2019-12-03 Thread Greg Kurz
On Mon, 2 Dec 2019 09:36:21 + Vladimir Sementsov-Ogievskiy wrote: > 28.11.2019 1:37, Greg Kurz wrote: > > On Wed, 27 Nov 2019 22:15:49 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> Make error_append_security_model_hint and > >> error_append_socket_sockfd_hint hint append helpers

Re: [PATCH] virtiofs: Relax DAX window protection for ppc

2019-12-03 Thread Dr. David Alan Gilbert
* Fabiano Rosas (faro...@linux.ibm.com) wrote: > When setting up the DAX window during the virtiofs driver probe inside > the guest, the Linux arch-specific function arch_add_memory is called, > which on ppc tries to do a cache flush [1] of the recently added > memory. At this point the window is

Re: [PATCH 1/3] iotests: Provide a function for checking the creation of huge files

2019-12-03 Thread Alex Bennée
Thomas Huth writes: > Some tests create huge (but sparse) files, and to be able to run those > tests in certain limited environments (like CI containers), we have to > check for the possibility to create such files first. Thus let's introduce > a common function to check for large files, and

Re: [PATCH] virtfs-proxy-helper: switch from libcap to libcap-ng

2019-12-03 Thread Greg Kurz
On Fri, 29 Nov 2019 13:59:37 +0100 Greg Kurz wrote: > On Fri, 29 Nov 2019 13:49:20 +0100 > Paolo Bonzini wrote: > > > On 29/11/19 13:32, Greg Kurz wrote: > > > Nice. :) > > > > > > Reviewed-by: Greg Kurz > > > > > > Paolo, > > > > > > I can take this through my 9p tree if you want.

Re: [PATCH 1/2] usb-host: remove 'remote wakeup' flag from configuration descriptor

2019-12-03 Thread Gerd Hoffmann
Hi, > +/* If this is GET_DESCRIPTOR request for configuration descriptor, > + * remove 'remote wakeup' flag from it to prevent idle power down > + * in Windows guest */ scripts/checkpatch.pl complains about that, please fix (and also the other checkpatch warnings). > +

Re: [PATCH 00/15] s390x: Protected Virtualization support

2019-12-03 Thread Daniel P . Berrangé
On Fri, Nov 29, 2019 at 03:02:41PM +0100, Janosch Frank wrote: > On 11/29/19 1:35 PM, Daniel P. Berrangé wrote: > > Is there any way to prevent a guest from using protected mode even > > if QEMU supports it ? eg the mgmt app may want to be able to > > guarantee that all VMs are migratable, so

Re: [PATCH v37 10/17] target/avr: Add instruction disassembly function

2019-12-03 Thread Philippe Mathieu-Daudé
On 12/2/19 8:04 AM, Michael Rolnik wrote: Aleksandar. If this code is going to be merge in 2019 I should modify al the copyrights, right. or should I put 2020 in? Usually the copyright date is when you first contributed your code to the world (here, the list). If a patch was on the list in

Re: [PATCH v2 05/15] stubs: add stubs for io_uring interface

2019-12-03 Thread Stefan Hajnoczi
On Mon, Nov 11, 2019 at 12:13:47PM +0100, Kevin Wolf wrote: > Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: > > From: Aarushi Mehta > > > > Signed-off-by: Aarushi Mehta > > Signed-off-by: Stefan Hajnoczi > > This commit message needs to answer at least where these stubs are >

Re: [PATCH 1/1] tests/vm: Allow to set qemu-img path

2019-12-03 Thread Alex Bennée
Wainer dos Santos Moschetta writes: > By default VM build test use qemu-img from system's PATH to > create the image disk. Due the lack of qemu-img on the system > or the desire to simply use a version built with QEMU, it would > be nice to allow one to set its path. So this patch makes that >

Re: [PATCH v5 03/22] target/arm: Add MTE system registers

2019-12-03 Thread Peter Maydell
On Fri, 11 Oct 2019 at 14:48, Richard Henderson wrote: > > This is TFSRE0_EL1, TFSR_EL1, TFSR_EL2, TFSR_EL3, > RGSR_EL1, GCR_EL1, GMID_EL1, and PSTATE.TCO. > > Signed-off-by: Richard Henderson > --- > v3: Add GMID; add access_mte. > v4: Define only TCO at mte_insn_reg. > --- > target/arm/cpu.h

Re: [PATCH v3 0/5] hvf: stability fixes for HVF

2019-12-03 Thread Paolo Bonzini
On 03/12/19 00:55, Cameron Esfahani wrote: > Changes in v3: > - Change previous code which saved interrupt/exception type in > hvf_store_events() to inject later in hvf_inject_interrupts(). > Now, hvf_inject_interrupts() will correctly determine when it's appropriate > to inject

Re: [PATCH 2/2] usb-redir: remove 'remote wakeup' flag from configuration descriptor

2019-12-03 Thread Gerd Hoffmann
Hi, > +/* > + * If this is GET_DESCRIPTOR request for configuration descriptor, > + * remove 'remote wakeup' flag from it to prevent idle power down > + * in Windows guest > + */ > +if (dev->suppress_remote_wake && > +

Re: [PATCH v5 02/22] target/arm: Add regime_has_2_ranges

2019-12-03 Thread Peter Maydell
On Fri, 11 Oct 2019 at 14:48, Richard Henderson wrote: > > A translation with 2 ranges has both positive and negative addresses. > This is true for the EL1&0 and the as-yet unimplemented EL2&0 regimes. > > Signed-off-by: Richard Henderson > --- > target/arm/internals.h | 14 ++ >

Re: [PATCH v2 04/14] gdbstub: move mem_buf to GDBState and use GByteArray

2019-12-03 Thread Damien Hedde
On 11/30/19 9:45 AM, Alex Bennée wrote: > This is in preparation for further re-factoring of the register API > with the rest of the code. Theoretically the read register function > could overwrite the MAX_PACKET_LENGTH buffer although currently all > registers are well within the size range. >

Re: [PATCH v5 06/13] hw/core/qdev: handle parent bus change regarding resettable

2019-12-03 Thread Cornelia Huck
On Fri, 29 Nov 2019 18:41:26 + Peter Maydell wrote: > On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > > > In qdev_set_parent_bus(), when changing the parent bus of a > > realized device, if the source and destination buses are not in the > > same reset state, some adaptation are

Re: [PATCH for-5.0 v2 17/23] iotests: Use skip_if_unsupported decorator in 041

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > We can use this decorator above TestRepairQuorum.setUp() to skip all > quorum tests with a single line. > > Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

2019-12-03 Thread Cornelia Huck
On Tue, 03 Dec 2019 08:49:58 +0100 Markus Armbruster wrote: > Cornelia Huck writes: > > > On Sat, 30 Nov 2019 20:42:36 +0100 > > Markus Armbruster wrote: > > > > I don't really want to restart the discussion :), but what about: > > > >> cpu_model_from_info() is a helper for

Re: [PATCH v3 5/7] gpio: Add GPIO Aggregator/Repeater driver

2019-12-03 Thread Geert Uytterhoeven
Hi Harish, On Tue, Dec 3, 2019 at 6:42 AM Harish Jenny K N wrote: > > +static int gpio_aggregator_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = >dev; > > + struct gpio_desc **descs; > > + struct gpiochip_fwd *fwd; > > + int i, n; > > + > > + n =

[PULL 0/1] HVF fix QEMU 4.2-rc

2019-12-03 Thread Paolo Bonzini
The following changes since commit 39032981fa851d25fb27527f25f046fed800e585: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2019-12-02' into staging (2019-12-02 16:29:41 +) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for

[PULL 1/1] hvf: correctly inject VMCS_INTR_T_HWINTR versus VMCS_INTR_T_SWINTR.

2019-12-03 Thread Paolo Bonzini
From: Cameron Esfahani Previous implementation in hvf_inject_interrupts() would always inject VMCS_INTR_T_SWINTR even when VMCS_INTR_T_HWINTR was required. Now correctly determine when VMCS_INTR_T_HWINTR is appropriate versus VMCS_INTR_T_SWINTR. Make sure to clear ins_len and has_error_code

Re: [PATCH v2 3/4] target/arm: Prepare generic timer for per-platform CNTFRQ

2019-12-03 Thread Andrew Jeffery
On Tue, 3 Dec 2019, at 16:49, Philippe Mathieu-Daudé wrote: > On 12/3/19 5:14 AM, Andrew Jeffery wrote: > > The ASPEED AST2600 clocks the generic timer at the rate of HPLL. On > > recent firmwares this is at 1125MHz, which is considerably quicker than > > the assumed 62.5MHz of the current

Re: [PATCH v2 2/3] s390x: Add missing vcpu reset functions

2019-12-03 Thread Janosch Frank
On 12/2/19 4:46 PM, Cornelia Huck wrote: > On Mon, 2 Dec 2019 09:01:45 -0500 > Janosch Frank wrote: > >> Up to now we only had an ioctl to reset vcpu data QEMU couldn't reach >> for the initial reset, which was also called for the clear reset. To > > s/which/and that/ ? Ok > >> be

[PATCH v3 1/4] Header sync

2019-12-03 Thread Janosch Frank
Sync in the new vcpu resets. Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 4 1 file changed, 4 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 3d9b18f7f8..f9fc3f6dc0 100644 --- a/linux-headers/linux/kvm.h +++

[PATCH v3 3/4] s390x: Fix cpu normal reset ri clearing

2019-12-03 Thread Janosch Frank
As it turns out we need to clear the ri controls and PSW enablement bit to be architecture compliant. Signed-off-by: Janosch Frank Reviewed-by: Christian Borntraeger --- target/s390x/cpu.c | 7 ++- target/s390x/cpu.h | 7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff

[PATCH v3 4/4] pc-bios/s390x: Fix reset psw mask

2019-12-03 Thread Janosch Frank
We need to set the short psw indication bit in the reset psw, as it is a short psw. fixes: 9629823290 ("pc-bios/s390-ccw: do a subsystem reset before running the guest") Signed-off-by: Janosch Frank --- pc-bios/s390-ccw/jump2ipl.c | 12 +++- 1 file changed, 7 insertions(+), 5

Re: [PATCH] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

2019-12-03 Thread Amit Shah
On Tue, 2019-12-03 at 00:37 -0500, Michael S. Tsirkin wrote: > On Tue, Dec 03, 2019 at 08:53:42AM +0800, pannengyuan wrote: > > > > > > On 2019/12/2 21:58, Laurent Vivier wrote: > > > On 02/12/2019 12:15, pannengy...@huawei.com wrote: > > > > From: PanNengyuan > > > > > > > >

Re: [PATCH 1/5] tests: fw_cfg: Rename pc_fw_cfg_* to fw_cfg_*

2019-12-03 Thread Peter Maydell
On Tue, 3 Dec 2019 at 12:29, Xiang Zheng wrote: > > Rename pc_fw_cfg_* to fw_cfg_* to make them common for other > architectures so that we can run fw_cfg tests on aarch64. > > Signed-off-by: Xiang Zheng > -static inline QFWCFG *pc_fw_cfg_init(QTestState *qts) > +static inline QFWCFG

Re: virtiofsd: Where should it live?

2019-12-03 Thread Paolo Bonzini
On 26/11/19 13:14, Dr. David Alan Gilbert wrote: >> IOW, if we did decide we want it in QEMU, then instead of >> '$GIT/contrib/virtiofsd', I'd prefer to see '$GIT/virtiofsd'. > > I'm not sure it deserves a new top level for such a specific tool. > It could be in fsdev/virtiofsd, but I agree with

Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2019-12-03 Thread Paolo Bonzini
On 03/12/19 10:15, Thomas Huth wrote: Maybe we can rename this as read_boot_order_mm, and the previous read_boot_order_pc as read_boot_order_io. >>> >>> I don't think it makes much sense. This was completely specific to the >>> "prep" machine, even the "40p" machine seems to prefer

[PULL 2/2] seabios: update to pre-1.13 snapshot again

2019-12-03 Thread Sam Eiderman
Hi, Maybe we should add: CONFIG_HOST_BIOS_GEOMETRY=n to rom/config.seabios-128k and recreate the 128k image?

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 03/12/19 14:02, Dr. David Alan Gilbert wrote: > >> It could be in fsdev/virtiofsd, > > fsdev is currently all 9p stuff, so that would seem very confusing. > > Move it to fsdev/9p? Greg: Are you OK with us doing that, and then having

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 26/11/19 13:14, Dr. David Alan Gilbert wrote: > >> IOW, if we did decide we want it in QEMU, then instead of > >> '$GIT/contrib/virtiofsd', I'd prefer to see '$GIT/virtiofsd'. > > > > I'm not sure it deserves a new top level for such a specific

Re: [PATCH v5 05/22] target/arm: Suppress tag check for sp+offset

2019-12-03 Thread Peter Maydell
On Fri, 11 Oct 2019 at 14:49, Richard Henderson wrote: > > R0078 specifies that base register, or base register plus immediate > offset, is unchecked when the base register is SP. It looks like rule-numbers didn't make it into the final Arm ARM, so I guess the reference here would just be to

[PATCH 5/5] tests: Enable fw_cfg test on aarch64

2019-12-03 Thread Xiang Zheng
Now turn on the fw_cfg test for aarch64. Signed-off-by: Xiang Zheng --- tests/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index 8566f5f119..180e0ed2b7 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@

Custom logic gates on user space emulation

2019-12-03 Thread burak sarac
Hello All, Currently I am studying qemu and I want to figure out how I can use custom logic gates on user space emulation. I am searching very basic 'hello world' kind of tutorial or some resources to i.e. adding left or LOR : 1 | 0 = 1 but 0 | 1 = 0 to existing x86 arch

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Dec 03, 2019 at 11:06:44AM +, Peter Maydell wrote: > > On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert > > wrote: > > > > > > We seem to be coming to the conclusion something that: > > > > > > a) It should live in the qemu

Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2019-12-03 Thread Thomas Huth
On 03/12/2019 14.04, Paolo Bonzini wrote: > On 03/12/19 10:15, Thomas Huth wrote: > Maybe we can rename this as read_boot_order_mm, and the previous > read_boot_order_pc as read_boot_order_io. I don't think it makes much sense. This was completely specific to the "prep"

Re: virtiofsd: Where should it live?

2019-12-03 Thread Paolo Bonzini
On 03/12/19 14:02, Dr. David Alan Gilbert wrote: >> It could be in fsdev/virtiofsd, > fsdev is currently all 9p stuff, so that would seem very confusing. Move it to fsdev/9p? >> but I agree with Daniel that at this >> point the QEMU build system introduces baggage that you may not want for >>

Re: [PATCH v3 4/4] pc-bios/s390x: Fix reset psw mask

2019-12-03 Thread Christian Borntraeger
On 03.12.19 14:28, Janosch Frank wrote: > We need to set the short psw indication bit in the reset psw, as it is > a short psw. > > fixes: 9629823290 ("pc-bios/s390-ccw: do a subsystem reset before running the > guest") > Signed-off-by: Janosch Frank We should also add commit

Re: [PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
03.12.2019 16:32, Vladimir Sementsov-Ogievskiy wrote: > 11.11.2019 19:02, Max Reitz wrote: >> Signed-off-by: Max Reitz > > > Reviewed-by: Vladimir Sementsov-Ogievskiy > Oops, stop. Why do you remove line "self.vm.shutdown()" ? -- Best regards, Vladimir

Re: [RFC] QEMU Gating CI

2019-12-03 Thread Stefan Hajnoczi
On Mon, Dec 02, 2019 at 01:12:54PM -0500, Cleber Rosa wrote: > On Mon, Dec 02, 2019 at 05:00:18PM +, Stefan Hajnoczi wrote: > > On Mon, Dec 02, 2019 at 09:05:52AM -0500, Cleber Rosa wrote: > > > RFC: QEMU Gating CI > > > === > > > > Excellent, thank you for your work on this!

Re: [PATCH v5 06/22] target/arm: Implement the IRG instruction

2019-12-03 Thread Peter Maydell
On Fri, 11 Oct 2019 at 14:49, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Update to 00eac5. > Merge choose_random_nonexcluded_tag into helper_irg since > that pseudo function no longer exists separately. > --- > target/arm/helper-a64.h| 1 + >

Re: [PATCH for-5.0 v2 18/23] iotests: Add VM.assert_block_path()

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 59 +++ > 1 file changed, 59 insertions(+) > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py > index d34305ce69..3e03320ce3 100644

Re: [PATCH v3 5/7] gpio: Add GPIO Aggregator/Repeater driver

2019-12-03 Thread Eugeniu Rosca
Hi Geert, On Wed, Nov 27, 2019 at 09:42:51AM +0100, Geert Uytterhoeven wrote: > +static int gpio_aggregator_probe(struct platform_device *pdev) > +{ > + struct device *dev = >dev; > + struct gpio_desc **descs; > + struct gpiochip_fwd *fwd; > + int i, n; FWIW/FTR, doing some blind

Re: [PATCH v2 05/15] stubs: add stubs for io_uring interface

2019-12-03 Thread Kevin Wolf
Am 03.12.2019 um 12:16 hat Stefan Hajnoczi geschrieben: > On Mon, Nov 11, 2019 at 12:13:47PM +0100, Kevin Wolf wrote: > > Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: > > > From: Aarushi Mehta > > > > > > Signed-off-by: Aarushi Mehta > > > Signed-off-by: Stefan Hajnoczi > > > >

Re: [PATCH v2 2/4] target/arm: Abstract the generic timer frequency

2019-12-03 Thread Andrew Jeffery
On Tue, 3 Dec 2019, at 16:39, Philippe Mathieu-Daudé wrote: > On 12/3/19 5:14 AM, Andrew Jeffery wrote: > > Prepare for SoCs such as the ASPEED AST2600 whose firmware configures > > CNTFRQ to values significantly larger than the static 62.5MHz value > > currently derived from GTIMER_SCALE. As

Re: [PATCH 0/5] tests: Enable fw_cfg tests on AArch64

2019-12-03 Thread Thomas Huth
On 03/12/2019 13.27, Xiang Zheng wrote: > There are quite a few tests disabled on AArch64 such as fw_cfg-tests. > This patch series fix some problems in test code and adapt it to > virt machine. > > Xiang Zheng (5): > tests: fw_cfg: Rename pc_fw_cfg_* to fw_cfg_* > tests: fw_cfg: Support

Re: [PATCH v2 2/2] travis.yml: Run tcg tests with tci

2019-12-03 Thread Thomas Huth
On 28/11/2019 22.33, Stefan Weil wrote: > Am 28.11.19 um 22:06 schrieb Stefan Weil: > >> Am 28.11.19 um 16:35 schrieb Thomas Huth: >> >>> So far we only have compile coverage for tci. But since commit >>> 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation >>> for

Re: Network connection with COLO VM

2019-12-03 Thread Dr. David Alan Gilbert
* Daniel Cho (daniel...@qnap.com) wrote: > Hi Dave, > > We could use the exist interface to add netfilter and chardev, it might not > have the problem you said. > > However, the netfilter and chardev on the primary at the start, that means > we could not dynamic set COLO > feature to VM? I

[PATCH v3 2/4] s390x: Add missing vcpu reset functions

2019-12-03 Thread Janosch Frank
Up to now we only had an ioctl to reset vcpu data QEMU couldn't reach for the initial reset, and that was also called for the clear reset. To be architecture compliant, we also need to clear local interrupts on a normal reset. Because of this and the upcoming protvirt support we need to add

[PATCH v3 0/4] s390x: Increase architectural compliance

2019-12-03 Thread Janosch Frank
On a cpu reset normal, we need to clear local cpus. Unfortunately we need a new API for that, since KVM only exposes one of the three resets. Also we need to clear the riccb and the PSW ri mask on a normal reset. And we need to set the short psw bit indication in the bios when doing a reset.

Re: [PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v5 04/22] target/arm: Add helper_mte_check{1,2,3}

2019-12-03 Thread Peter Maydell
On Fri, 11 Oct 2019 at 14:49, Richard Henderson wrote: > > Implements the rules of "PE generation of Checked and Unchecked > accesses" which aren't already implied by TB_FLAGS_MTE_ACTIVE. > Implements the rules of "PE handling of Tag Check Failure". > > Does not implement tag physical address

Re: [Qemu-devel] [PATCH 3/4] tests/docker: Add test-acceptance runner

2019-12-03 Thread Alex Bennée
Cleber Rosa writes: > On Mon, Aug 19, 2019 at 01:18:26AM +0200, Philippe Mathieu-Daudé wrote: >> Add a runner script to be able to run acceptance tests within >> Docker images. We can now reproduce Travis CI builds locally (and >> debug them!). >> >> Signed-off-by: Philippe Mathieu-Daudé >>

Re: [PATCH 2/2] Add -mem-shared option

2019-12-03 Thread Igor Mammedov
On Tue, 3 Dec 2019 09:56:15 +0100 Thomas Huth wrote: > On 02/12/2019 22.00, Eduardo Habkost wrote: > > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote: > >> On Fri, 29 Nov 2019 18:46:12 +0100 > >> Paolo Bonzini wrote: > >> > >>> On 29/11/19 13:16, Igor Mammedov wrote: >

Re: [PATCH 4/5] hw/arm/virt: Add FW_CFG_RAM_SIZE and FW_CFG_MAX_CPUS into fw_cfg

2019-12-03 Thread Peter Maydell
On Tue, 3 Dec 2019 at 12:29, Xiang Zheng wrote: > > I'm not sure whether it's neccesary to add FW_CFG_RAM_SIZE and > FW_CFG_MAX_CPUS into fw_cfg on virt machine. This patch just makes > the fw_cfg-test happy. > > Signed-off-by: Xiang Zheng > --- > hw/arm/virt.c | 3 +++ > 1 file changed, 3

[PATCH 2/5] tests: fw_cfg: Support read/write of fw_cfg registers on aarch64

2019-12-03 Thread Xiang Zheng
Refer to the fw_cfg registers locations of x86 and arm in docs/specs/fw_cfg.txt, the test codes need to differ on the addresses for read/write. Besides, fix the endian problems in mm_fw_cfg_select(). Signed-off-by: Xiang Zheng --- tests/libqos/fw_cfg.c | 17 +++-- 1 file changed,

  1   2   3   >