[quagga-dev 12100] Re: Advise on implementation

, e.g. for monitoring purpose or whatever you have in mind, we need to implement a such interface on top of this new one. Thanks for all your valuable comment. Regards, Olivier Le 03/03/2015 23:12, Lou Berger a écrit : On 3/3/2015 4:50 PM, David Lamparter wrote: On Tue, Mar 3, 2015

[quagga-dev 12101] Re: Query regarding BGP/MPLS L3VPN support in Quagga

Vikram, We posted a patch for the core bgp support a while back. It's on our 'to do list' to update it to be aligned with the current head. Lou On 3/3/2015 4:54 AM, Vikram Choudhary wrote: Hi All, Does any of the Quagga release supports BGP/MPLS L3VPN (i.e. RFC-4364) ? Thanks

[quagga-dev 12106] Re: Query regarding BGP/MPLS L3VPN support in Quagga

can share the same. Thanks Vikram -Original Message- From: Lou Berger [mailto:lber...@labn.net] Sent: 04 March 2015 21:29 To: Vikram Choudhary Cc: quagga-dev@lists.quagga.net; Dhruv Dhody Subject: Re: [quagga-dev 12080] Query regarding BGP/MPLS L3VPN support in Quagga Vikram

[quagga-dev 12639] Re: [PATCH v3 00/22] VRF support in quagga

Paul, On 6/3/2015 12:40 PM, Paul Jakma wrote: On Tue, 2 Jun 2015, Lou Berger wrote: This is where you loose me. In any approach that allows multiple zebras there will be a way to map vrf to zebra instance (and presumably socket), and the client code will need to resolve/dispatch per-vrf

[quagga-dev 12655] Re: [PATCH v5 3/3] lib, vtysh: support multiple VRFs by using linux netns

So what would you expect the logical-table config to look like when supporting RFC4364 style BGP-VPNs? (and yes, there's some other really interesting config issues here related to interfaces and tunneling, but I think we can keep that discussion separate.) Lou On 6/5/2015 10:51 AM, Alain

[quagga-dev 12723] Re: [PATCH v3 00/22] VRF support in quagga

On 06/12/2015 12:06 PM, Nicolas Dichtel wrote: Le 05/06/2015 09:01, Nicolas Dichtel a écrit : [snip] After the last three patches, I've one more ready in my queue to rename vrf to domain because the term 'vrf' is too controversial. Not sure: was there a consensus on the name? domain?

[quagga-dev 12712] Re: [PATCH v3 00/22] VRF support in quagga

On 06/12/2015 02:34 PM, Lou Berger wrote: On 06/12/2015 12:06 PM, Nicolas Dichtel wrote: Le 05/06/2015 09:01, Nicolas Dichtel a écrit : [snip] After the last three patches, I've one more ready in my queue to rename vrf to domain because the term 'vrf' is too controversial. Not sure

[quagga-dev 12579] Re: [PATCH v3 00/22] VRF support in quagga

On 5/30/2015 9:45 AM, David Lamparter wrote: On Sat, May 30, 2015 at 02:32:36PM +0100, Paul Jakma wrote: On Sat, 30 May 2015, David Lamparter wrote: Upfront was half a year ago... and we have users that would like to start meshing with this. [http://patchwork.quagga.net/patch/952/] I

[quagga-dev 12609] Re: [PATCH v3 00/22] VRF support in quagga

Paul, On June 1, 2015 5:00:38 PM Paul Jakma p...@jakma.org wrote: On Mon, 1 Jun 2015, Lou Berger wrote: One Zserv instance for all makes it much harder to do multiple-processes later I'm not sure I see this. You have a Zserv protocol, which is an API. This API, with the proposed

[quagga-dev 13431] Re: Subject: [PATCH] Cleanup BGPD memory

Paul, On 10/23/2015 11:53 AM, Paul Jakma wrote: > On Fri, 23 Oct 2015, Lou Berger wrote: > >> Let me know if you want me/us to do anything more than code review. > I'm basically curious about the differences between the old and the new, > and whether those differences also

[quagga-dev 13428] Re: Subject: [PATCH] Cleanup BGPD memory

Paul, On 10/23/2015 5:39 AM, Paul Jakma wrote: > Hi Lou, > > Just comparing the previous old version and one you reposted, quoted > below. Question: > > On Tue, 20 Oct 2015, Lou Berger wrote: > > >> @@ -195,6 +201,19 @@ assegment_prepend_asns (struct assegmen

[quagga-dev 13429] Re: Subject: [PATCH] Cleanup BGPD memory

me/us to do anything more than code review. Thank you, Lou > > ---8<---8<---8<8<8<--- > > commit 73a5841990c9128c4c5bf1bbd250d04d211ad446 > Author: Lou Berger <lber...@labn.net> > Date: Wed Apr 10 12:30:04 2013 -0700 > > bgpd, lib: me

[quagga-dev 13384] Re: Subject: [PATCH] Cleanup BGPD memory

On 10/21/2015 11:56 AM, Paul Jakma wrote: > On Tue, 20 Oct 2015, Lou Berger wrote: > >> This patch corrects bgpd memory not being properly cleaned up on exit. >> Errors were identified and verified as part of an effort to use valgrind >> to ID any memory leaks. >>

[quagga-dev 13471] Re: BGP vpnv4 problem after configuring network with RD and tag

If interested, you can try https://github.com/LabNConsulting/quagga-vnc/tree/0.99.24.1-mplsvpn+encap which we're in the process of cleaning up (eg removing debug code, removing required 'modified by' header, conforming with quagga spacing conventions) and soon expect to (re)submit. If you do

[quagga-dev 13062] Re: BGP: deactivating an address-family for neighbor removes some of the config

On 09/11/2015 02:35 PM, Alexis Rosen wrote: > On Sep 11, 2015, at 8:25 AM, Michael H Lambert wrote: >>> On 11 Sep 2015, at 06:34, Paul Jakma wrote: >>> >>> Yeah, be nice to have 1 way to delete the per-AFI/SAFI config, and another >>> to disable the neighbour in

[quagga-dev 13066] Re: BGP: deactivating an address-family for neighbor removes some of the config

Sorry I miss typed in my original message On 9/11/2015 4:10 PM, Alexis Rosen wrote: > On Sep 11, 2015, at 3:37 PM, Lou Berger <lber...@labn.net> wrote: >> On 09/11/2015 02:35 PM, Alexis Rosen wrote: >>> On Sep 11, 2015, at 8:25 AM, Michael H Lambert <lamb...@psc.ed

[quagga-dev 14275] Re: VPN routing architecture and requirements

es yet? I'd like to see if we have any / how much overlap in code that is to be upstream-ed... Thanks, Lou > let's deep dive after season holidays. > > best regards, >Vincent > > On 15/12/2015 23:33, Lou Berger wrote: >> Hi Paul, >> Do you have any thoughts

[quagga-dev 14249] Re: VPN routing architecture and requirements

Hi Paul, Do you have any thoughts on how you'd like to have this discussion? Some detailed responses below. On 12/15/2015 10:34 AM, Paul Jakma wrote: > Hi, > > I'd like to figure out what the right architecture is to support VPN > routing. I'm not terribly interested in them myself, but it

[quagga-dev 14274] Re: VPN routing architecture and requirements

On 12/16/2015 9:41 AM, Paul Jakma wrote: > On Wed, 16 Dec 2015, Lou Berger wrote: > >> Sure. Although some of what we're talking about is quite mature (VPNs >> SAFI, encap attribute) and others are more recent (e.g., VXLAN tunnel >> type.) > I honestly have no i

[quagga-dev 14387] Re: [PATCH 01/25] lib: write "exit" to config after last route-map

ut. I would prefer that we come up with a methodology to handle this for all end blocks, instead of just for route-maps. donald On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger <lber...@labn.net> wrote: The last route-map written to config should have an "exit" at the end to return to th

[quagga-dev 14414] Re: [PATCH 15/25] bgpd: improve cleanup in bgp_delete()

> installed in zebra.". > > On Tue, Jan 5, 2016 at 6:57 AM, Lou Berger <lber...@labn.net > <mailto:lber...@labn.net>> wrote: > > Right. > > Lou > > On 1/5/2016 8:04 AM, Vivek Venkatraman wrote: > > Are the changes (fixes) here pri

[quagga-dev 14412] Re: [PATCH 00/25] IPv4 VPN fixes, IPv6 VPN and IPv4&6 Encap support

On 1/5/2016 10:50 AM, Vivek Venkatraman wrote: > > On Tue, Jan 5, 2016 at 5:44 AM, Lou Berger <lber...@labn.net > <mailto:lber...@labn.net>> wrote: > > Vivek, > > > I think there will be quite a few things to discuss and agree upon > > when

[quagga-dev 14410] Re: [PATCH 01/25] lib: write "exit" to config after last route-map

e up with a methodology to handle this >> for all end blocks, instead of just for route-maps. >> >> donald >> >> On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger <lber...@labn.net >> <mailto:lber...@labn.net>> wrote: >> >> The last ro

[quagga-dev 14400] Re: [PATCH 00/25] IPv4 VPN fixes, IPv6 VPN and IPv4&6 Encap support

re they any aspects of the above that you want to cover as part of the patch set (vs PE i/o) review that isn't covered in your patch specific emails? Thanks again, Lou > > Thanks, > Vivek > > On Thu, Dec 24, 2015 at 10:10 AM, Lou Berger <lber...@labn.net > <mailto:

[quagga-dev 14406] Re: [PATCH 16/25] bgpd: general MP/SAFI improvements

Vivek, On 1/5/2016 8:13 AM, Vivek Venkatraman wrote: > > On Thu, Dec 24, 2015 at 10:10 AM, Lou Berger <lber...@labn.net > <mailto:lber...@labn.net>> wrote: > > This is part of the core VPN and Encap SAFI changes. > > This fixes some minor mixups p

[quagga-dev 14401] Re: [PATCH 12/25] bgpd: handle AS4 and EOI route distinguishers

nywhere (e.g., when > injecting/configuring a VPNv4 prefix). So, how is this used? > > On Thu, Dec 24, 2015 at 10:10 AM, Lou Berger <lber...@labn.net > <mailto:lber...@labn.net>> wrote: > > This is part of the core VPN and Encap SAFI changes. > > Signed-o

[quagga-dev 14405] Re: [PATCH 15/25] bgpd: improve cleanup in bgp_delete()

Right. Lou On 1/5/2016 8:04 AM, Vivek Venkatraman wrote: > Are the changes (fixes) here primarily related to cleaning up memory > when a BGP instance is deleted? > > On Thu, Dec 24, 2015 at 10:10 AM, Lou Berger <lber...@labn.net > <mailto:lber...@labn.net>> wrote:

[quagga-dev 14430] Re: [PATCH 07/25] lib: add facility to log all CLI commands

fair enough, LOG_NOTICE or LOG_INFO? On 1/6/2016 8:57 AM, Donald Sharp wrote: > Ok, different use case. Why the LOG_EMERG? I think this should be > protected by a knob of some sort. Does every cli need to be saved no > matter what? > > donald > > On Wed, Jan 6, 2016 a

[quagga-dev 14424] Re: [PATCH 14/25] *: hook up bgp VPNv6 CLI node

Donald, Thanks for the review. See below. On 1/6/2016 8:31 AM, Donald Sharp wrote: > Comments Inline > > > On Thu, Dec 24, 2015 at 1:10 PM, Lou Berger <lber...@labn.net > <mailto:lber...@labn.net>> wrote: > > This is part of the core VPN and Encap

[quagga-dev 14403] Re: [PATCH 11/25] bgpd: make _vpnv4 static handling SAFI-agnostic

eneralize/fix what was there. I think it's at least useful for testing and perhaps other uses that may come up in actual operation. We also weren't comfortable suggesting removing existing function without a good reason. Thanks again, Lou > > On Thu, Dec 24, 2015 at 10:10 AM, Lou B

[quagga-dev 14404] Re: [PATCH 13/25] bgpd: wire up VPNv6 protocol processing

Vivek, On 1/5/2016 8:02 AM, Vivek Venkatraman wrote: > > On Thu, Dec 24, 2015 at 10:10 AM, Lou Berger <lber...@labn.net > <mailto:lber...@labn.net>> wrote: > > This is part of the core VPN and Encap SAFI changes. > > There wasn't much missing for VPN

[quagga-dev 14451] Re: [PATCH 16/25] bgpd: general MP/SAFI improvements

Vivek, to close this one off. On 1/5/2016 8:18 AM, Vivek Venkatraman wrote: > > > +#if 0 /* duplicates mpattr included in > bgp_packet.c */ >if (p && !(afi == AFI_IP && safi == SAFI_UNICAST)) > changed to: if (p && afi == AFI_IP6 && safi ==

[quagga-dev 14298] Re: VPN routing architecture and requirements

https://github.com/openstack/networking-bgpvpn > > let's deep dive after season holidays. > > best regards, > Vincent > > On 15/12/2015 23:33, Lou Berger wrote: > > Hi Paul, > Do you have any thoughts on how you'd like to have th

[quagga-dev 14345] [PATCH 00/25] IPv4 VPN fixes, IPv6 VPN and IPv4&6 Encap support

This patch set corrects issues with IPv4 MPLS VPN (RF4364) SAFI support, and adds support for IPv6 MPLS VPN (RFC4659), Encap SAFI and related attribute and types (RFC5512, 5566). These changes are appropriate for use of BGPd as a route reflector for these SAFIs. Import/export code can be built

[quagga-dev 14351] [PATCH 07/25] lib: add facility to log all CLI commands

To facilitate debugging and operation. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- lib/vty.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/lib/vty.c

[quagga-dev 14352] [PATCH 10/25] bgpd: kill unused variable in bgp_socket()

Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c index 3c5e6c5..511a0fe 100644 --- a/bgpd/b

[quagga-dev 14350] [PATCH 06/25] lib: add "show commandtree" CLI command

To facilitate debugging and operation. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- lib/command.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/lib/command.c b/lib/com

[quagga-dev 14347] [PATCH 01/25] lib: write "exit" to config after last route-map

The last route-map written to config should have an "exit" at the end to return to the main node from route-map processing. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- lib/routemap.c | 2 ++ 1 file changed,

[quagga-dev 14367] [PATCH 21/25] CLI: machineparse / random "show" improvements

[DL: the machineparse foo should probably be dropped] Signed-off-by: Lou Berger <lber...@labn.net> --- bgpd/bgp_mplsvpn.c | 2 +- bgpd/bgp_route.c | 56 ++ bgpd/bgp_route.h | 2 +- 3 files changed, 42 insertions(+), 18 del

[quagga-dev 14368] [PATCH 16/25] bgpd: general MP/SAFI improvements

This is part of the core VPN and Encap SAFI changes. This fixes some minor mixups particularly in MPLS-related SAFIs, as well as doing some stylistic changes & adding comments. Signed-off-by: Lou Berger <lber...@labn.net> Reviewed-by: David Lamparter <equi...@opensourcerouting.o

[quagga-dev 14360] [PATCH 13/25] bgpd: wire up VPNv6 protocol processing

This is part of the core VPN and Encap SAFI changes. There wasn't much missing for VPNv6 to begin with; just a few bits of de- & encoding and a few lists to be updated. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.o

[quagga-dev 14356] [PATCH 15/25] bgpd: improve cleanup in bgp_delete()

Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_nexthop.c | 21 bgpd/bgp_nexthop.h | 2 ++ bgpd/bgp_route.c| 99 - bgpd/bgp_route.h|

[quagga-dev 14355] [PATCH 11/25] bgpd: make _vpnv4 static handling SAFI-agnostic

This is part of the core VPN and Encap SAFI changes. This changes the existing _vpnv4 functions for MPLS-VPN into SAFI-agnostic functions, renaming them from *_vpnv4 to *_safi. Also adds route-map support while at it. Signed-off-by: Lou Berger <lber...@labn.net> Reviewed-by: David Lam

[quagga-dev 14358] [PATCH 12/25] bgpd: handle AS4 and EOI route distinguishers

This is part of the core VPN and Encap SAFI changes. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_mplsvpn.c | 81 -- bgpd/bgp_mplsvpn.h | 2 ++ 2 files

[quagga-dev 14366] [PATCH 19/25] bgpd: encap: add encap SAFI (RFC5512)

This is part of the core VPN and Encap SAFI changes. Adds RFC5512 and a (per DL) non-compliant version of Encapsulation Attribute. Signed-off-by: Lou Berger <lber...@labn.net> Reviewed-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/Makefile.am | 4 +- bgpd/bgp_at

[quagga-dev 14362] [PATCH 14/25] *: hook up bgp VPNv6 CLI node

This is part of the core VPN and Encap SAFI changes. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_vty.c | 112 ++- bgpd/bgpd.c | 15 +-- l

[quagga-dev 14365] [PATCH 18/25] bgpd: encap: add attribute handling

This is part of the core VPN and Encap SAFI changes. Signed-off-by: Lou Berger <lber...@labn.net> Reviewed-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/Makefile.am | 6 +- bgpd/bgp_attr.c| 332 ++- bgpd/bgp_attr.h|

[quagga-dev 14364] [PATCH 20/25] *: hook up bgp ENCAP CLI node

This is part of the core VPN and Encap SAFI changes. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_vty.c | 242 +++ bgpd/bgp_vty.h | 6 ++

[quagga-dev 14341] Re: Location of 'vrf ' option in a command

What's form of the commands when there are no VRFs in use? Lou On December 23, 2015 2:28:50 PM Vipin Kumar wrote: Thanks Nicolas. So, I assume you are fine with changing zebra commands (such as this) to.. 'show ip route vrf A.B.C.D/M' from its previous

[quagga-dev 14029] Re: VRF global and protocol specific config

ork across BGP instances, to work on > import/export of routes. > > For static routes import/export between VRFs, can be implemented in > Zebra I'm not sure this makes sense as the BGP has been the place where most have implemented RT policy as it just falls out from RFC4364/4659 imp

[quagga-dev 14030] Re: cleaning up commands (was Re: BGP 'view' to 'vrf')

Paul, On 11/26/2015 6:12 AM, Paul Jakma wrote: > If no one else is doing it, I'm fairly sure we're going to start writing > that code, but this thing is 'big' and high-impact enough that it needs > thrashing out in public first and getting consensus early to have a chance > of success /

[quagga-dev 14047] Re: VRF global and protocol specific config

; > On Fri, Nov 27, 2015 at 12:44 PM, Lou Berger <lber...@labn.net > <mailto:lber...@labn.net>> wrote: > > Vipin, > Good stuff. See below for responses in-line. > > > So are you suggesting import / export is not tied to BGP? Right? > RT

[quagga-dev 13940] Re: BGP 'view' to 'vrf'

Vipin, So this maps pretty well when talking vrf-lite, but before making this change I think we should agree upon how tunnel based VRFs are represented and configured over a core instance so we don't end up with naming or concept clashes. If not full syntax, I think we should at least have a

[quagga-dev 13972] Re: cleaning up commands (was Re: BGP 'view' to 'vrf')

Have you looked at or considered YANG? It is certainly the hammer of the day in this space... Lou On November 24, 2015 7:00:42 AM Paul Jakma wrote: On Mon, 23 Nov 2015, Paul Jakma wrote: On Mon, 23 Nov 2015, Renato Westphal wrote: I think that it would be better to

[quagga-dev 14499] [PATCH v2 09/30] lib: add SAFI_ENCAP type, safi2str prefix utility

Signed-off-by: Lou Berger <lber...@labn.net> --- lib/prefix.c | 16 lib/prefix.h | 1 + lib/zebra.h | 3 ++- 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/prefix.c b/lib/prefix.c index 936e9fc..3e4ca16 100644 --- a/lib/prefix.c +++ b/lib/pr

[quagga-dev 14497] [PATCH v2 05/30] lib: fix bookkeeping for libreadline malloc()s

When libreadline is used, we mistakenly mix in strdup() done in libreadline with Quagga's lib/memory bookkeeping/counting, leading to counter underflows on MTYPE_TMP. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- l

[quagga-dev 14501] [PATCH v2 11/30] bgpd: kill unused variable in bgp_socket()

Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c index 3c5e6c5..511a0fe 100644 --- a/bgpd/b

[quagga-dev 14500] [PATCH v2 08/30] lib: add facility to log all CLI commands

Signed-off-by: Lou Berger <lber...@labn.net> --- lib/vty.c | 38 -- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/lib/vty.c b/lib/vty.c index 480d34f..9f4d8fa 100644 --- a/lib/vty.c +++ b/lib/vty.c @@ -111,7 +111,7 @@ vty_out (struct vt

[quagga-dev 14516] [PATCH v2 20/30] bgpd: encap: add attribute handling

Signed-off-by: Lou Berger <lber...@labn.net> Reviewed-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/Makefile.am | 6 +- bgpd/bgp_attr.c| 329 ++- bgpd/bgp_attr.h| 16 + bgpd/bgp_encap_t

[quagga-dev 14517] [PATCH v2 24/30] bgpd: cleanup vty bgp_node_afi/safi utils

Signed-off-by: Lou Berger <lber...@labn.net> --- bgpd/bgp_vty.c | 42 +++--- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c index 1248b19..c540a7b 100644 --- a/bgpd/bgp_vty.c +++ b/bgpd/bgp_vty.c @@

[quagga-dev 14503] [PATCH v2 12/30] bgpd: make _vpnv4 static handling SAFI-agnostic

This changes the existing _vpnv4 functions for MPLS-VPN into SAFI-agnostic functions, renaming them from *_vpnv4 to *_safi. Also adds route-map support while at it. Signed-off-by: Lou Berger <lber...@labn.net> Reviewed-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/b

[quagga-dev 14508] [PATCH v2 13/30] bgpd: handle AS4 and EOI route distinguishers

Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_mplsvpn.c | 81 -- bgpd/bgp_mplsvpn.h | 2 ++ 2 files changed, 62 insertions(+), 21 deletions(-) diff

[quagga-dev 14504] [PATCH v2 17/30] bgpd: tests - add null pointer protection to fix bgp test failures

Signed-off-by: Lou Berger <lber...@labn.net> --- bgpd/bgp_nexthop.c | 2 ++ tests/bgp_mpath_test.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/bgpd/bgp_nexthop.c b/bgpd/bgp_nexthop.c index 7dbaf3c..d3e5821 100644 --- a/bgpd/bgp_nexthop.c +++ b/bgpd/bgp_nex

[quagga-dev 14514] [PATCH v2 25/30] CLI: VPNv6 show commands

Signed-off-by: Lou Berger <lber...@labn.net> --- bgpd/bgp_mplsvpn.c | 406 ++--- bgpd/bgp_route.c | 321 ++ 2 files changed, 427 insertions(+), 300 deletions(-) diff --git a/bgpd/bgp_mplsvpn.c

[quagga-dev 14493] [PATCH v2 02/30] zebra: wire up "debug zebra packet detail"

There was no way to actually set ZEBRA_DEBUG_DETAIL, even though some debug output was conditional to it. Add CLI command. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- zebra/debug.c | 5 +++-- 1 file changed, 3 inse

[quagga-dev 14495] [PATCH v2 04/30] zebra: additional redistribute related logging

Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- zebra/redistribute.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/zebra/redistribute.c b/zebra/redistribute.c index 5ec8219..57

[quagga-dev 14494] [PATCH v2 01/30] lib: write "exit" to config after last route-map

The last route-map written to config should have an "exit" at the end to return to the main node from route-map processing. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- lib/routemap.c | 2 ++ 1 file changed,

[quagga-dev 14506] [PATCH v2 14/30] bgpd: wire up VPNv6 protocol processing

There wasn't much missing for VPNv6 to begin with; just a few bits of de- & encoding and a few lists to be updated. Signed-off-by: Lou Berger <lber...@labn.net> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> --- bgpd/bgp_attr.c| 25 +++

[quagga-dev 14509] [PATCH v2 16/30] bgpd: improve cleanup in bgp_delete()

Signed-off-by: Lou Berger <lber...@labn.net> --- bgpd/bgp_nexthop.c | 21 +++ bgpd/bgp_nexthop.h | 2 + bgpd/bgp_route.c| 103 +++- bgpd/bgp_route.h| 3 ++ bgpd/bgp_routemap.c | 3 ++ bgpd/bgp_zebra.c| 10 +

[quagga-dev 15416] Re: Quagga Release Process Meeting Notes

Thanks for the notes. Since you asked: - I think having a documented release process and schedule is necessary - I think it's worth trying the documented process Lou On 6/2/2016 12:43 PM, Donald Sharp wrote: > Document is here: > >

[quagga-dev 15428] Re: Quagga Release Process Meeting Notes

On 6/3/2016 11:21 AM, Jafar Al-Gharaibeh wrote: > On 6/3/2016 10:03 AM, Lou Berger wrote: >> On 6/3/2016 9:35 AM, Olivier Dugeon wrote: >>> Hi Lou Jafar, >>> >>> Well, it becomes hard to follow this new numbering schema. >>> >> Probably s

[quagga-dev 15494] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

Philippe, see below. On 6/8/2016 1:55 PM, Philippe Guibert wrote: > On Tue, May 17, 2016 at 1:10 PM, Lou Berger <lber...@labn.net> wrote: > > Hi Lou, > >> This feature adds an L3 & L2 VPN application that makes use of the VPN >> and Encap SAFIs. This code

[quagga-dev 15500] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

Philippe, On 6/9/2016 4:15 AM, Philippe Guibert wrote: > On Wed, Jun 8, 2016 at 9:22 PM, Lou Berger <lber...@labn.net> wrote: > > Hi Lou, >>> * It seems the RD_TYPE_EOI type surfaced again (see >>> http://patchwork.quagga.net/patch/1728/ ), whereas I

[quagga-dev 15472] Re: Round 8

Once this is pushed I can also run our internal bgp VPN regression tests (including with valgrind) on this. Lou On 6/6/2016 12:09 PM, Paul Jakma wrote: > - I'll push > somewhere later or tomorrow. ___ Quagga-dev mailing list

[quagga-dev 15429] Re: Quagga Release Process Meeting Notes

On 6/5/2016 10:34 AM, Michael Richardson wrote: > Lou Berger <lber...@labn.net> wrote: > >> What do you (anyone) think? > I think we are thinking too much about it. > > Michael, If I'm not mistaken, you were around since quagga was set up as a gnu project. Wha

[quagga-dev 15422] Re: BGP EVPN support on Quagga

Some. Take a look at https://lists.quagga.net/pipermail/quagga-dev/2016-May/015364.html . Feel free to ask for details. Lou On June 3, 2016 2:45:52 AM bochi wrote: Hi all, I saw that there was a thread taking about BGP EVPN support on Quagga Oct last year.

[quagga-dev 15533] Re: Round 8

Eak -- the branch doesn't compile with -std=c99 . I think these changes need to be reworked with standard modern c declarations. Lou On 6/14/2016 9:47 AM, Lou Berger wrote: > Paul, > > Great to see this published. Is there a quagga convention WRT C99? > > I see the following

[quagga-dev 15537] Re: Round 8

Paul, On 6/14/2016 9:02 AM, Paul Jakma wrote: > Note: I've had a good few conflicts on 'install_element' lines, due to > various patches adding/removing commands with the restricted node and > 'auto-install view commands into enable' patches. I didn't look too > closely as to whether I

[quagga-dev 15532] Re: Round 8

Paul, Great to see this published. Is there a quagga convention WRT C99? I see the following when compiling proposed/8 if.c:1151: error: ?for? loop initial declarations are only allowed in C99 mode if.c:1151: note: use option -std=c99 or -std=gnu99 to compile your code zclient.c:903: error:

[quagga-dev 15592] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

Philippe, On 6/15/2016 10:45 AM, Philippe Guibert wrote: > On Thu, Jun 9, 2016 at 10:42 AM, Lou Berger <lber...@labn.net> wrote: > > Lou, > >> Philippe, > [..] >> Sure, as we said the RFP and VNC feature is aliened with the NVO3 >> architecture

[quagga-dev 15403] Re: Strawman Quagga Release Process

Donald, All, So what's the next step? Another meeting next week to review/close on this? Thanks, Lou On 5/26/2016 6:14 PM, Donald Sharp wrote: > > All - > > Lou and I have taken a first pass at the release document that was > discussed in the meeting. > > This description was inspired by,

[quagga-dev 15401] Re: [PATCH] lib: add skiplists; use for thread sorting by default

On 5/26/2016 1:00 PM, Christian Franke wrote: > On 05/26/2016 05:55 PM, G. Paul Ziemba wrote: >> p...@jakma.org (Paul Jakma) writes: >> >>> Cool. >>> I was going to ask if skiplist was the most appropriate DS for timer, >>> though regardless, surely a lot better than a simple list. ;) >> I

[quagga-dev 15400] Re: [PATCH 01/25] lib: write "exit" to config after last route-map

Jakma wrote: > On Tue, 5 Jan 2016, Lou Berger wrote: > >> >> On 1/5/2016 9:10 AM, Donald Sharp wrote: >>> I'm not sure that exit is the right way to go here, or at least I >>> would like some sort of agreement from everyone on what is the right >>> thi

[quagga-dev 15411] Re: Straw man (wacko?) idea on releases, process, and repo structure

Y = year because the version numbers are year based, e.g., 20160315 On 5/27/2016 12:02 PM, Paul Jakma wrote: > On Fri, 27 May 2016, Lou Berger wrote: > >> YE = alternate name for LTE as that wasn't well received... > And what does 'Y' mean? > > The aim with the roun

[quagga-dev 15394] Re: [PATCH 07/10] lib: add skiplist

ion to which he said "sure". Lou On 5/26/2016 6:18 AM, Paul Jakma wrote: > On Tue, 17 May 2016, Lou Berger wrote: > >> + * Permission to include in quagga provide by William Pugh on March 31, 2016 >> + * The author makes no claim/restriction on use. It is provided &qu

[quagga-dev 15677] Re: Call for Agenda

Vincent explained it to me. > > - Martin > > Disclaimer: I’m only the person who wrote it down. This does not mean that > I agree or disagree on it. But I want this choice to be discussed as well. > > > On 18 Jun 2016, at 14:23, Lou Berger wrote: > >

[quagga-dev 15685] Re: Quagga Monthly Meeting Notes

Paul, While the conclusion to work on ce may (or may not, I wasn't on the call for this) be premature, why can't a branch just be added under the existing repo if/when that's the consensus among the community? Lou On June 22, 2016 5:53:34 AM Paul Jakma wrote: On Tue, 21

[quagga-dev 15684] Re: Quagga Monthly Meeting Notes

Hi Donald, I'm sorry I couldn't stay for the rest of the meeting. I really think the roles discussion is separable from the release cycle discussion and it would be good to close the roles discussion first. Lou On June 21, 2016 11:01:45 AM Donald Sharp wrote:

[quagga-dev 15688] Re: Quagga Monthly Meeting Notes

Paul, Independent of branches/release discussion, my view is that either version of the roles documents - either Vincent's or the one posted for yesterday's meeting - would really help to _just get it done_. (of course, I am not maintainer nor do I expect to be one in the future.) It would

[quagga-dev 15698] Re: Quagga Monthly Meeting Notes

ad the document and let us know how you would like to proceed. > > Additionally I'll move the CE part back to the Quagga Release Process > docuemnt. > > thanks! > > donald > > On Wed, Jun 22, 2016 at 6:28 AM, Lou Berger <lber...@labn.net> wrote: >> Paul, >&

[quagga-dev 15613] Re: Round 8

Nothing but old habits, so easy to change. I've been favoring clang (much better warnings) which defaults to it in any case... Cheers, Lou On June 16, 2016 5:49:00 AM Paul Jakma wrote: On Thu, 16 Jun 2016, Paul Jakma wrote: If it's trivial like declaring stuff in the

[quagga-dev 15640] [PATCHv2] bgpd: eliminate RD related duplicate code in bgp_encap.c decode_rd_... apis are declared global in bgp_mplsvpn.c

--- bgpd/bgp_encap.c | 45 - bgpd/bgp_mplsvpn.c | 8 bgpd/bgp_mplsvpn.h | 5 + 3 files changed, 9 insertions(+), 49 deletions(-) diff --git a/bgpd/bgp_encap.c b/bgpd/bgp_encap.c index 1a09ba6..e69da04 100644 --- a/bgpd/bgp_encap.c +++

[quagga-dev 15641] Re: [PATCH] bgpd: eliminate RD related duplicate code in bgp_encap.c

just sent to list - rev should hopefully address the CI failure too. On June 17, 2016 5:26:23 AM Philippe Guibert <philippe.guib...@6wind.com> wrote: > On Thu, Jun 16, 2016 at 8:45 PM, Lou Berger <lber...@labn.net> wrote: > > Hello Lou, > >> >

[quagga-dev 15650] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

the references you asked for in the log. * https://github.com/LabNConsulting/quagga-vnc/tree/patches/R1.0.20160315%2Bvnc/v3 On 6/17/2016 10:10 AM, Lou Berger wrote: > > On 6/17/2016 9:15 AM, Philippe Guibert wrote: >> On Thu, Jun 16, 2016 at 8:52 PM, Lou Berger <lber...@labn.net> wrot

[quagga-dev 15702] Re: Quagga Monthly Meeting Notes

On 6/22/2016 6:17 PM, Paul Jakma wrote: > On Wed, 22 Jun 2016, Jafar Al-Gharaibeh wrote: > >> For example, assume I want to push the new feature that I have been working >> on: MTR-OSPF (RFC4915). Having that in the CE (thing ;) ) for a few cycles >> might help us understand its impact on

[quagga-dev 15605] Re: Round 8

On 6/15/2016 11:38 AM, David Lamparter wrote: > On Tue, Jun 14, 2016 at 10:03:41AM -0400, Lou Berger wrote: >> Eak -- the branch doesn't compile with -std=c99 . > Standard for Quagga is currently "-std=gnu99" as seen in configure.ac > line ~140; there seems to be a bu

[quagga-dev 15627] Re: [PATCH v2 07/30] lib: add "show commandtree" CLI command

Paul, See below. On 6/15/2016 5:53 AM, Paul Jakma wrote: > On Tue, 12 Jan 2016, Lou Berger wrote: > >> +DEFUN (show_commandtree, >> + show_commandtree_cmd, >> + "show commandtree", >> + NO_STR >> + "Show command tre

[quagga-dev 15630] [PATCH] bgpd: eliminate RD related duplicate code in bgp_encap.c

--- bgpd/bgp_encap.c | 45 - bgpd/bgp_mplsvpn.c | 8 bgpd/bgp_mplsvpn.h | 4 3 files changed, 8 insertions(+), 49 deletions(-) diff --git a/bgpd/bgp_encap.c b/bgpd/bgp_encap.c index d21924c..bd150ce 100644 --- a/bgpd/bgp_encap.c +++

[quagga-dev 15631] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

. (this patch will be rolled into the larger vnc patch.) Thanks, Lou On 6/9/2016 4:42 AM, Lou Berger wrote: > Philippe, > > On 6/9/2016 4:15 AM, Philippe Guibert wrote: >> > On Wed, Jun 8, 2016 at 9:22 PM, Lou Berger <lber...@labn.net> wrote: >> > >> > H

[quagga-dev 15713] Re: Quagga Monthly Meeting Notes

On 6/23/2016 1:46 AM, Jafar Al-Gharaibeh wrote: > On 6/22/2016 6:04 PM, Lou Berger wrote: >> why not just use personal github for this? that said,there might be >> value in having an easy way to see the features in development... > I do use github for this, as many of us pr

  1   2   3   >