RE: Is there a way we can disable ship it button to the submitter for that particular review request?

[Dunnigan, Terrence J]

The ability to remove the ‘ship it!’ button will be great! Glad to hear it’s in 
Review Board 3.0.

Terry

From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On 
Behalf Of Barret Rennie
Sent: Thursday, September 08, 2016 5:39 PM
To: reviewboard@googlegroups.com
Subject: Re: Is there a way we can disable ship it button to the submitter for 
that particular review request?

Hi David,

Review Board doesn't have this functionality built in. In Review Board 2.5, you 
could create an extension that conditionally adds CSS/JS to the page to hide 
the Ship It button. Review Board 3.0 will have a feature that allows you to 
fully replace all review request actions, so it could be replaced with an 
action that is not shown to the submitter but functions identically. I hope 
this helps.

Regards,
Barret Rennie.
On Sep 6, 2016, at 6:39 PM, Dave Ca 
> wrote:

Is there a way we can disable ship it button to the submitter for that 
particular review request?

I want to restrict the submitter in clicking ship it

--
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 
reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 
reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: "Error uploading diff" seen for certain clearcase file rules

[David Trowbridge]

Hari,

post-review is quite old at this point and we no longer support it.

-David

On Thu, Sep 1, 2016 at 5:13 AM Hari Prasad  wrote:

> Hi Christian,
>
> We use "post-review" for posting reviews while rbt attach and rbt
> publish to publish reviews. We had some issues in posting reviews
> using rbt in our setup we are using post-review command.
>
> In the attached log file, post-review fails for file XYZ.cc but works
> fine ABC.cc.
>
> Have attached the output of post-review running with --debug.
>
> Please clarify what is going wrong.
>
> Regards,
> Hari
>
> On Thu, Sep 1, 2016 at 12:56 PM, Christian Hammond
>  wrote:
> > Hi,
> >
> > How are you uploading the diffs?
> >
> > If you're using RBTools, can you show me a debug log (running with
> --debug)?
> >
> > Christian
> >
> > --
> > Christian Hammond
> > President/CEO of Beanbag
> > Makers of Review Board
> >
> > On Wed, Aug 31, 2016 at 10:58 PM, Hari Prasad 
> > wrote:
> >>
> >> Hi,
> >>
> >> We are using ReviewBoard version 2.5.2.
> >>
> >> When raising review requests, only for some specific clearcase file
> rules,
> >> getting the error "Error uploading diff".
> >>
> >> Not sure why this error is happening for such rules. I doubled checked
> the
> >> file rule and its a valid rule.
> >>
> >> Is there any way to debug this error?
> >>
> >> Please clarify.
> >>
> >> --
> >> Supercharge your Review Board with Power Pack:
> >> https://www.reviewboard.org/powerpack/
> >> Want us to host Review Board for you? Check out RBCommons:
> >> https://rbcommons.com/
> >> Happy user? Let us know! https://www.reviewboard.org/users/
> >> ---
> >> You received this message because you are subscribed to the Google
> Groups
> >> "reviewboard" group.
> >> To unsubscribe from this group and stop receiving emails from it, send
> an
> >> email to reviewboard+unsubscr...@googlegroups.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >
> >
> > --
> > Supercharge your Review Board with Power Pack:
> > https://www.reviewboard.org/powerpack/
> > Want us to host Review Board for you? Check out RBCommons:
> > https://rbcommons.com/
> > Happy user? Let us know! https://www.reviewboard.org/users/
> > ---
> > You received this message because you are subscribed to a topic in the
> > Google Groups "reviewboard" group.
> > To unsubscribe from this topic, visit
> > https://groups.google.com/d/topic/reviewboard/js9ZQt1gGCY/unsubscribe.
> > To unsubscribe from this group and all its topics, send an email to
> > reviewboard+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>
>
>
> --
> Best regards,
> Hari
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Is there a way we can disable ship it button to the submitter for that particular review request?

[Barret Rennie]

Hi David,

Review Board doesn't have this functionality built in. In Review Board 2.5, you 
could create an extension that conditionally adds CSS/JS to the page to hide 
the Ship It button. Review Board 3.0 will have a feature that allows you to 
fully replace all review request actions, so it could be replaced with an 
action that is not shown to the submitter but functions identically. I hope 
this helps.

Regards,
Barret Rennie.
> On Sep 6, 2016, at 6:39 PM, Dave Ca  wrote:
> 
> Is there a way we can disable ship it button to the submitter for that 
> particular review request?
> 
> I want to restrict the submitter in clicking ship it
> 
> -- 
> Supercharge your Review Board with Power Pack: 
> https://www.reviewboard.org/powerpack/ 
> 
> Want us to host Review Board for you? Check out RBCommons: 
> https://rbcommons.com/ 
> Happy user? Let us know! https://www.reviewboard.org/users/ 
> 
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4460: Clicking on the star on the dashboard after adding star column opens the review request

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4460/
--

New update by jamie
For Beanbag, Inc. > Review Board > Ticket #4460


Reply:

Fixed on release-2.5.x (fc9ddc63042f5c4ef35dc65509da64808c594441)


Status:
- PendingReview
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Can't find diff revision selector

[Christian Hammond]

Hi Walder,

I think there's some confusion about what the slider is for. I'll explain.

When you first create a review request with a diff, that diff is stored
along with the review request as revision 1. Once you get reviews from
peers and make changes, you'll eventually update that review request with a
new diff: revision 2. Next would be 3, and so on.

The revision slider makes it easy to select which diff revision (not
committed revision) you want to view, and makes it easy to view an
interdiff between them (showing the differences between two versions of
your change, to help with the review process).

This all assumes you're using a pre-commit model, where you post changes
for review and gain approval *before* it goes into the codebase. This is
the recommended way of doing code review, as it ensures that bugs don't
slip in and others aren't building upon potentially fragile foundations.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Thu, Sep 8, 2016 at 4:14 AM, 'Walder Röhrl' via reviewboard <
reviewboard@googlegroups.com> wrote:

> Hey,
>
> I'm using Version 2.5.6.1 of Review Board, but I can't find the diff
> revision selector introduced in 2.0. In my diff viewer it's simply not
> there. Do I need to enable this feature somehow? I could't find anything in
> the settings.
>
> Also, I'm not quite sure how it's supposed to be used: I would like to
> select specific revisions when creating a review request. This is not
> possible using the selector in the webGUI, right?
>
> Cheers,
> Walder
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Diff not generated for some file

[Barret Rennie]

Hi,

Can you run the rbt diff command with the --debug flag and mail the output here?

Thanks!

-Barret
> On Sep 8, 2016, at 10:07 AM, msc...@freejamgames.com wrote:
> 
> Sorry, forgot to post the files
> 
> On Thursday, 8 September 2016 16:24:58 UTC+1, msc...@freejamgames.com wrote:
> Hi all
> 
> i'm using ReviewBoard (2.5.6.1) with Perforce (2016.1) with rbt (0.7.6) and 
> i'm actually having some trouble in generating the diff from some files.
> 
> I've checked the line ending in the source file and the local and they seems 
> fine (both Unix), i've checked the encoding and both have the same encoding 
> (both UTF8 with BOM), i've checked for unicode character in the files but i 
> was not able to find anything. 
> We also tried to follow the code and we saw that the process fail on the 
> "patch -o oldfile newfile" so i suppose that the diff is already created (?) 
> , for some reason the first chunk of the files that i'm testing is returning 
> an error, so maybe it could be related to BOM (even if it sounds weird, since 
> also the source file have it)?
> 
> I'm running out of ideas why the diff is not generated, any suggestion?
> 
> -- 
> Supercharge your Review Board with Power Pack: 
> https://www.reviewboard.org/powerpack/ 
> 
> Want us to host Review Board for you? Check out RBCommons: 
> https://rbcommons.com/ 
> Happy user? Let us know! https://www.reviewboard.org/users/ 
> 
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com 
> .
> For more options, visit https://groups.google.com/d/optout 
> .
> 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #3746: Review emails should be in the recipient's locale not the sender's locale

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/3746/
--

New update by asot@yelp (Google Code)
For Beanbag, Inc. > Review Board > Ticket #3746


Reply:

We've removed all the localization from e-mails.


Status:
- New
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #3782: Race condition in publishing a review request

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/3782/
--

New update by theo.b**@gmai* (Google Code)
For Beanbag, Inc. > Review Board > Ticket #3782


Reply:

Haven't seen this in a while.


Status:
- New
+ UnableToReproduce

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #3783: Make it possible to see the contents of deleted files

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/3783/
--

New update by mconley
For Beanbag, Inc. > Review Board > Ticket #3783


Reply:

Yep! This will ship in 3.0


Status:
- Accepted
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4367: How can i integrate review board with jira? I can't some document.Thank you

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4367/
--

New update by youfang
For Beanbag, Inc. > Review Board > Ticket #4367


Reply:

See documentation at 
https://www.reviewboard.org/docs/manual/2.5/admin/configuration/repositories/#bug-tracker


Status:
- New
+ NotABug

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4397: Invalid diff: new line is highlighted as changed

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4397/
--

New update by EUG
For Beanbag, Inc. > Review Board > Ticket #4397


Reply:

This is a subtle consequence of the way that the Myers diff algorithm 
works, and while it's perhaps less than ideal, this looks like a particularly 
pathological case. I doubt there's anything we can do to the existing algorithm 
to improve this without causing other regressions.


Status:
- New
+ NotABug

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4404: "Start Over" in Update Diff popup creates a new review instead

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4404/
--

New update by kyz
For Beanbag, Inc. > Review Board > Ticket #4404


Reply:

I suspect this is relatively easy to fix but I haven't actually 
investigated the bug.


Tags:
+ Component:WebUI
+ EasyFix

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4455: rbt post shouldn't overwrite manually configured target groups (e.g. TARGET_GROUPS) based on .reviewboardrc config

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4455/
--

New update by lukeschlather
For Beanbag, Inc. > RBTools > Ticket #4455


Reply:

Unfortunately, due to the way TARGET_GROUPS works, it can't really tell the 
difference between it being in your configuration file and if you specified it 
as the command-line argument, and so this is working as designed.

Something that probably better matches your expectations is if you 
configured a "default reviewer" on the server-side to automatically assign the 
group based on repository or file paths. In this case, if you then make changes 
to the groups in the UI, they won't get overridden on updates.


Status:
- New
+ NotABug

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Can't get RB 2.5 to see the css file for rbmotd.

[Joshua Olson]

I figured it out.  I needed to clear rbmotd from the extensions table then 
it stopped looking in the htdocs/static/ext for the css files.

On Wednesday, September 7, 2016 at 7:53:25 PM UTC-7, Joshua Olson wrote:
>
> Looking closer none of the extensions installed their static assets in 
> htdocs/static/ext.
>
> On Wednesday, September 7, 2016 at 7:40:00 PM UTC-7, Joshua Olson wrote:
>>
>> I figured it out.  It wasn't getting copied to 
>> /export/apps/reviewboard/site/htdocs/static/ext/rbmotd.extension.MotdExtension/
>>
>> Any ideas why that wouldn't be getting setup properly?
>>
>> On Wednesday, September 7, 2016 at 7:35:32 PM UTC-7, Joshua Olson wrote:
>>>
>>> I downloaded everything using pip install --download, except for rbmotd 
>>> which I downloaded the egg directly and scp'ed all the files manually to 
>>> the server.
>>>
>>> I have a server that isn't connected to the internet and I've installed 
>>> 2.5.6.1 (but I did do a load of our prod data to the DB and just did a DB 
>>> upgrade) and everything works fine except the rbmotd won't use the 
>>> precompiled css files or the less files.
>>>
>>> Is there a step I'm missing?
>>>
>>> Cheers,
>>> Josh
>>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Diff not generated for some file

[mscifo]

Sorry, forgot to post the files

On Thursday, 8 September 2016 16:24:58 UTC+1, msc...@freejamgames.com wrote:
>
> Hi all
>
> i'm using ReviewBoard (2.5.6.1) with Perforce (2016.1) with rbt (0.7.6) 
> and i'm actually having some trouble in generating the diff from some files.
>
> I've checked the line ending in the source file and the local and they 
> seems fine (both Unix), i've checked the encoding and both have the same 
> encoding (both UTF8 with BOM), i've checked for unicode character in the 
> files but i was not able to find anything. 
> We also tried to follow the code and we saw that the process fail on the 
> "patch -o oldfile newfile" so i suppose that the diff is already created 
> (?) , for some reason the first chunk of the files that i'm testing is 
> returning an error, so maybe it could be related to BOM (even if it sounds 
> weird, since also the source file have it)?
>
> I'm running out of ideas why the diff is not generated, any suggestion?
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


reviewboard.p46R_2.rar
Description: application/rar

Re: error when svn root is not project root

['Walder Röhrl' via reviewboard]

Hey,

I stumbled across this as well. Maybe you could add a line to the 
documentation?


Cheers,
Walder

On Tuesday, August 5, 2014 at 11:29:36 PM UTC+2, empt...@gmail.com wrote:
>
> Interesting... so apparently I was making this too complicated... I was 
> worried that because my users don't have read access to the root that this 
> wouldn't work, but it seems to.  Thanks!
>
> On Tuesday, August 5, 2014 4:18:22 PM UTC-5, Christian Hammond wrote:
>>
>> Hi,
>>
>> Even if your users are checking out from a subdirectory, you need to 
>> configure Review Board to have one entry for the root of the repository. 
>> RBTools will compare against the Repository Root field, figure out the 
>> relative URL they’re using from there, and look up the correct URL on 
>> Review Board.
>>
>> What happens if you try that?
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>
>> On August 5, 2014 at 2:15:49 PM, empt...@gmail.com (empt...@gmail.com) 
>> wrote:
>>
>> ok, so I have a setup where my company's root svn is different from the 
>> projects that people checkout. In otherwords, each project is setup as only 
>> a folder in svn.
>>
>> so svn info shows:
>> URL: https://url.org/svn/root/projectname
>> Relative URL: ^/projectname
>> Repository Root: https://url.org/svn/root
>>
>> The repo is setup in ReviewBoard as https://url.org/svn/root/projectname
>>
>> Anytime I run rbt post, I get:
>>
>> The file was not found in the repository. (HTTP 400, API Error 207)
>>
>> I AM able to get diffs to post automatically using the post-review 
>> version that comes bundled with debian testing by running something like:
>>
>> post-review --repository-url=https://url.org/svn/root/projectname 
>> --diff-filename=/tmp/manualdiff 
>> 
>>
>> But obviously, this is hackish and post-review is deprecated, from my 
>> understanding.
>>
>> If I insert a logging line into get_file in pysvn.py per another post 
>> here, I see something like the following in the logs:
>>
>>  - repopath = "https://url.org/svn/root/projectname;, path = 
>> "/projectname/file.py", revision = "18376"
>>
>>
>>
>> Which I assume why this is not working is because of the screwy path root 
>> problem and the duplicate projectname above.
>>
>> So, my question... what is the best way to make this work for automatic 
>> diff uploads using rbt?  Even if I have to hardcode something hackish, I 
>> would rather have your advice on where is the best place to do so.  Any 
>> help appreciated.
>> --
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Diff not generated for some file

[mscifo]

Hi all

i'm using ReviewBoard (2.5.6.1) with Perforce (2016.1) with rbt (0.7.6) and 
i'm actually having some trouble in generating the diff from some files.

I've checked the line ending in the source file and the local and they 
seems fine (both Unix), i've checked the encoding and both have the same 
encoding (both UTF8 with BOM), i've checked for unicode character in the 
files but i was not able to find anything. 
We also tried to follow the code and we saw that the process fail on the 
"patch -o oldfile newfile" so i suppose that the diff is already created 
(?) , for some reason the first chunk of the files that i'm testing is 
returning an error, so maybe it could be related to BOM (even if it sounds 
weird, since also the source file have it)?

I'm running out of ideas why the diff is not generated, any suggestion?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Can't find diff revision selector

['Walder Röhrl' via reviewboard]

Hey,

I'm using Version 2.5.6.1 of Review Board, but I can't find the diff 
revision selector introduced in 2.0. In my diff viewer it's simply not 
there. Do I need to enable this feature somehow? I could't find anything in 
the settings.

Also, I'm not quite sure how it's supposed to be used: I would like to 
select specific revisions when creating a review request. This is not 
possible using the selector in the webGUI, right? 

Cheers,
Walder

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.