Hi,
To answer your first question, no, there is no way to map the existing
comments to your new changes. This has come up a couple times over the last
couple years, so hopefully I can explain the reasoning well enough.
Comments are tied to line numbers in per-file diffs. This is the line or row
I'll second this. It really is beneficial to try to break up the changes
more. Preferably into logical changes (such as code to implement one part of
the functionality rather than an entire feature, or doing code cleanups in a
separate change), though if you're past the point where that makes
The repository path specified must be the *root* of the SVN repository,
which must match what's in Review Board.
The files being put up for review should be passed as additional parameters.
For example:
$ post-review src/*.c
Are you trying to post existing (committed) code, or new
It should. When doing --revision-range with Subversion, we're essentially
passing that range to 'svn diff' when generating the diff.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Aug 24, 2010 at 9:10
Hi John,
I just gave a summary of why we don't carry over comments in another thread
just a few minutes ago. Hopefully that explains why things are the way they
are.
What I personally do is use the interdiff functionality to see what was
changed in that diff, and make sure that it matches what I
Hi,
I'm sorry nobody ever got back to you on this. I hope you've figured it out.
It would help to know what version of Review Board you're using. If it's the
1.5 betas/RC, then make sure that you've set the repository as Visible.
Christian
--
Christian Hammond - chip...@chipx86.com
Review
I upgrade my reviewboard installation from beta to 1.0.9.
I installed a new 1.0.9 reviewboard and make sure it's working on the new
server. and I copy the old db file to the new db (sqlite)
After installation, it tell me there is some missing column in the db so I
run rb-site upgrade Path to
Hi,
First of all, can you see what version of django_evolution is installed on
your system? I want to verify that it's new enough.
You can ignore the warnings about things not being called with a database
connection. That's just due to not using the new APIs in Django 1.2, but
it's harmless for
Hi!
Can someone, please, clarify if there is any option (or plans) to add
tags for review requests?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
Hi.
Is there plans, by any chance, to add support for mercurial forest
extension? (See http://mercurial.selenic.com/wiki/ForestExtension)
For now we add rb repository for each forest subrepos. So, commit
which contains changes in several repositories have to be splitted to
several review
Through trial and error and re-installing (easy_install just doesn't
work for me) tracked it down to the Reviewboard egg entry missing from
easy-install.pth (removed it trying to solve another problem, which
didn't work). Once the Reviewboard egg entry was added back to easy-
install.pth the
Well, I got past the P4PASSWD issue and then began getting the error
The current directory does not contain a checkout from a supported
source code repository. After much digging, I found that the error
is actually wrong.
The PerforceClient's def_repository_info function checks for a P4
install
Hi -
I am trying to review post-committed code on the HEAD of a new
project. How do I do this? I haven't found any simple way (yet).
Seems like all the diffs need two versions to compare, but I only have
one: the new version. Thanks!
- Aaron
--
Want to help the Review Board project?
hi,
Review board server is setup on a centos machine, repository used is
svn. All users connect to RB site through windows.
Everything seems to be working fine, came across a problem on firefox.
I verified this on 3 different machines and i got the same output.
VC++ resource file ( .rc)
Hi,
I've responded to that bug you filed on this. It looks very much like a
caching bug, and from your description, you seem to be running an older
version of Review Board that has caching problems. Please make sure you're
upgraded to 1.0.9, then clear your browser caches and memcached, and see
Thank you Christian for such timely help!!!
As you advised, I first checked the django-evolution version
it's django_evolution-0.5-py2.5.egg Is it new enough?
I will now also try to copy the database with the DB closed to see if it
works.
If it works, I will try to import the data from sqlite
Comment #1 on issue 1789 by nebu.john: .rc diff appears incorrectly on
Firefox
http://code.google.com/p/reviewboard/issues/detail?id=1789
RB 1.0
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to
Updates:
Status: NeedInfo
Comment #2 on issue 1789 by chipx86: .rc diff appears incorrectly on Firefox
http://code.google.com/p/reviewboard/issues/detail?id=1789
This sort of rendering is done server-side, and there shouldn't be a
difference between browsers in this way. This looks
Comment #2 on issue 387 by snaggen: Error Control Characters not allowed
http://code.google.com/p/reviewboard/issues/detail?id=387
I tried 1.5RC1 and this bug still exists, I had to add
key = %s:%s:%s % (urlquote(filediff.diffset.repository.path),
urlquote(file),
Status: New
Owner:
Labels: Type-Enhancement Priority-Medium
New issue 1790 by onkarshinde: Register on flattr.com
http://code.google.com/p/reviewboard/issues/detail?id=1790
Flattr is a nice micro-payment (micro-donation) system. It will be nice of
RB is registered on flattr. This way
Status: New
Owner:
Labels: Type-Enhancement Priority-Medium
New issue 1791 by josh.hamacher: Hide unreasonably large diffs.
http://code.google.com/p/reviewboard/issues/detail?id=1791
*NOTE: If you have a patch, please submit it to
http://reviews.reviewboard.org/
What version are you
21 matches
Mail list logo
