[Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Hi there,

I've successfully upgraded from reviewboard 1.7 to 2.0, (I did not had a 
repository configured before).

When trying to add a repository, with a ssh RSA private key added to the 
SSH configuration section, I get the following error :

https://lh5.googleusercontent.com/-nR1PWQWMaE8/U32j_GajKFI/AVA/mWBaa2ui1SA/s1600/permission-denied.PNG












After browsing a bit around the web, I found out it is raised when an IO 
exception occurs. I also changed the owner user to my site .ssh directory 
and file (/var/www/reviewboard/data/.ssh/id_rsa).

I must precise that my RSA private key is a passphrase-less key. This might 
also be the origin of the problem. Do you have any idea?

Thanks already,

Nicolas COMET.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Christian Hammond
Hi,

Can you enable logging in the Logging Settings, repeat this (you may need
to reload Apache first), and then see what errors appear in reviewboard.log?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Thu, May 22, 2014 at 12:21 AM, Nicolas Comet nicolas.co...@gmail.comwrote:

 Hi there,

 I've successfully upgraded from reviewboard 1.7 to 2.0, (I did not had a
 repository configured before).

 When trying to add a repository, with a ssh RSA private key added to the
 SSH configuration section, I get the following error :


 https://lh5.googleusercontent.com/-nR1PWQWMaE8/U32j_GajKFI/AVA/mWBaa2ui1SA/s1600/permission-denied.PNG












 After browsing a bit around the web, I found out it is raised when an IO
 exception occurs. I also changed the owner user to my site .ssh directory
 and file (/var/www/reviewboard/data/.ssh/id_rsa).

 I must precise that my RSA private key is a passphrase-less key. This
 might also be the origin of the problem. Do you have any idea?

 Thanks already,

 Nicolas COMET.




  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Here is what I get in reviewboard.log :

2014-05-22 07:55:38,620 - INFO -  - Reloading logging settings
2014-05-22 07:55:38,980 - DEBUG -  - Cache miss for key 
jsi18n-djangojs-reviewboard_djblets-fr-1400577976.
2014-05-22 07:57:12,670 - DEBUG -  - Cache miss for key 
jsi18n-djangojs-reviewboard_djblets-fr-1400577976.
2014-05-22 07:57:22,890 - DEBUG -  - SVNTool: Attempting ssh connection 
with host: svn1.*.com, username: eu_monitorplm_svc
2014-05-22 07:57:24,642 - DEBUG -  - Cache miss for key 
jsi18n-djangojs-reviewboard_djblets-fr-1400577976.

The stars are for privacy purpose.
Nothing interesting :(

Le jeudi 22 mai 2014 09:24:20 UTC+2, Christian Hammond a écrit :

 Hi,

 Can you enable logging in the Logging Settings, repeat this (you may need 
 to reload Apache first), and then see what errors appear in reviewboard.log?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 22, 2014 at 12:21 AM, Nicolas Comet 
 nicola...@gmail.comjavascript:
  wrote:

 Hi there,

 I've successfully upgraded from reviewboard 1.7 to 2.0, (I did not had a 
 repository configured before).

 When trying to add a repository, with a ssh RSA private key added to the 
 SSH configuration section, I get the following error :


 https://lh5.googleusercontent.com/-nR1PWQWMaE8/U32j_GajKFI/AVA/mWBaa2ui1SA/s1600/permission-denied.PNG












 After browsing a bit around the web, I found out it is raised when an IO 
 exception occurs. I also changed the owner user to my site .ssh directory 
 and file (/var/www/reviewboard/data/.ssh/id_rsa).

 I must precise that my RSA private key is a passphrase-less key. This 
 might also be the origin of the problem. Do you have any idea?

 Thanks already,

 Nicolas COMET.




  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Here it is :
data :
https://lh3.googleusercontent.com/-4WYtlKsmfZE/U32w6B3pU8I/AVQ/0heZolBteW0/s1600/dataPNG.PNG
.ssh :
https://lh5.googleusercontent.com/-vmek2BRleXM/U32xDs1VwvI/AVY/vsKejYhDHyI/s1600/ssh.PNG
id_rsa :
https://lh4.googleusercontent.com/-WDlz2Vq-Lnw/U32xKgwU5II/AVg/Xe_gcXnLre8/s1600/id_rsa.PNG





Le jeudi 22 mai 2014 10:05:24 UTC+2, Christian Hammond a écrit :

 Just to verify, can you show me the permissions and ownership of 
 /var/www/reviewboard/data/, .ssh within that, and then the contents within 
 that?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 22, 2014 at 1:03 AM, Nicolas Comet 
 nicola...@gmail.comjavascript:
  wrote:

 Here is what I get in reviewboard.log :

 2014-05-22 07:55:38,620 - INFO -  - Reloading logging settings
 2014-05-22 07:55:38,980 - DEBUG -  - Cache miss for key 
 jsi18n-djangojs-reviewboard_djblets-fr-1400577976.
 2014-05-22 07:57:12,670 - DEBUG -  - Cache miss for key 
 jsi18n-djangojs-reviewboard_djblets-fr-1400577976.
 2014-05-22 07:57:22,890 - DEBUG -  - SVNTool: Attempting ssh connection 
 with host: svn1.*.com, username: eu_monitorplm_svc
 2014-05-22 07:57:24,642 - DEBUG -  - Cache miss for key 
 jsi18n-djangojs-reviewboard_djblets-fr-1400577976.

 The stars are for privacy purpose.
 Nothing interesting :(

 Le jeudi 22 mai 2014 09:24:20 UTC+2, Christian Hammond a écrit :

 Hi,

 Can you enable logging in the Logging Settings, repeat this (you may 
 need to reload Apache first), and then see what errors appear in 
 reviewboard.log?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com

 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 22, 2014 at 12:21 AM, Nicolas Comet nicola...@gmail.comwrote:

  Hi there,

 I've successfully upgraded from reviewboard 1.7 to 2.0, (I did not had 
 a repository configured before).

 When trying to add a repository, with a ssh RSA private key added to 
 the SSH configuration section, I get the following error :


 https://lh5.googleusercontent.com/-nR1PWQWMaE8/U32j_GajKFI/AVA/mWBaa2ui1SA/s1600/permission-denied.PNG












 After browsing a bit around the web, I found out it is raised when an 
 IO exception occurs. I also changed the owner user to my site .ssh 
 directory and file (/var/www/reviewboard/data/.ssh/id_rsa).

 I must precise that my RSA private key is a passphrase-less key. This 
 might also be the origin of the problem. Do you have any idea?

 Thanks already,

 Nicolas COMET.




  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/
 powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.

 For more options, visit https://groups.google.com/d/optout.


  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Christian Hammond
Okay, those look fine.

You asked if the key could be passphrase-less, as in not having a
passphrase? That's completely fine, and in fact required, since we can't
prompt for the passphrase.

Another thing to check... Do you have SELinux enabled? It's possible it's
trying to run rbssh, and can't run it from within the context of Apache's
process. You'll need to disable SELinux if it is on.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Thu, May 22, 2014 at 1:11 AM, Nicolas Comet nicolas.co...@gmail.comwrote:

 Here it is :
 data :

 https://lh3.googleusercontent.com/-4WYtlKsmfZE/U32w6B3pU8I/AVQ/0heZolBteW0/s1600/dataPNG.PNG
 .ssh :

 https://lh5.googleusercontent.com/-vmek2BRleXM/U32xDs1VwvI/AVY/vsKejYhDHyI/s1600/ssh.PNG
 id_rsa :

 https://lh4.googleusercontent.com/-WDlz2Vq-Lnw/U32xKgwU5II/AVg/Xe_gcXnLre8/s1600/id_rsa.PNG





 Le jeudi 22 mai 2014 10:05:24 UTC+2, Christian Hammond a écrit :

 Just to verify, can you show me the permissions and ownership of
 /var/www/reviewboard/data/, .ssh within that, and then the contents within
 that?

 Christian

 --
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 22, 2014 at 1:03 AM, Nicolas Comet nicola...@gmail.comwrote:

 Here is what I get in reviewboard.log :

 2014-05-22 07:55:38,620 - INFO -  - Reloading logging settings
 2014-05-22 07:55:38,980 - DEBUG -  - Cache miss for key
 jsi18n-djangojs-reviewboard_djblets-fr-1400577976.
 2014-05-22 07:57:12,670 - DEBUG -  - Cache miss for key
 jsi18n-djangojs-reviewboard_djblets-fr-1400577976.
 2014-05-22 07:57:22,890 - DEBUG -  - SVNTool: Attempting ssh connection
 with host: svn1.*.com, username: eu_monitorplm_svc
 2014-05-22 07:57:24,642 - DEBUG -  - Cache miss for key
 jsi18n-djangojs-reviewboard_djblets-fr-1400577976.

  The stars are for privacy purpose.
 Nothing interesting :(

 Le jeudi 22 mai 2014 09:24:20 UTC+2, Christian Hammond a écrit :

 Hi,

 Can you enable logging in the Logging Settings, repeat this (you may
 need to reload Apache first), and then see what errors appear in
 reviewboard.log?

 Christian

 --
 Christian Hammond - chi...@chipx86.com

 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 22, 2014 at 12:21 AM, Nicolas Comet nicola...@gmail.comwrote:

  Hi there,

 I've successfully upgraded from reviewboard 1.7 to 2.0, (I did not had
 a repository configured before).

 When trying to add a repository, with a ssh RSA private key added to
 the SSH configuration section, I get the following error :


 https://lh5.googleusercontent.com/-nR1PWQWMaE8/U32j_GajKFI/AVA/mWBaa2ui1SA/s1600/permission-denied.PNG












 After browsing a bit around the web, I found out it is raised when an
 IO exception occurs. I also changed the owner user to my site .ssh
 directory and file (/var/www/reviewboard/data/.ssh/id_rsa).

 I must precise that my RSA private key is a passphrase-less key. This
 might also be the origin of the problem. Do you have any idea?

 Thanks already,

 Nicolas COMET.




  --
 Get the Review Board Power Pack at http://www.reviewboard.org/pow
 erpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.

 For more options, visit https://groups.google.com/d/optout.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because 

Re: [Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
$ cat /etc/sysconfig/selinux 

# This file controls the state of SELinux on the system.
# SELINUX= can take one of these three values:
# enforcing - SELinux security policy is enforced.
# permissive - SELinux prints warnings instead of enforcing.
# disabled - No SELinux policy is loaded.
SELINUX=enforcing
# SELINUXTYPE= can take one of these two values:
# targeted - Targeted processes are protected,
# mls - Multi Level Security protection.
SELINUXTYPE=targeted 

Should I disable it?

Le jeudi 22 mai 2014 10:14:44 UTC+2, Christian Hammond a écrit :

 Okay, those look fine.

 You asked if the key could be passphrase-less, as in not having a 
 passphrase? That's completely fine, and in fact required, since we can't 
 prompt for the passphrase.

 Another thing to check... Do you have SELinux enabled? It's possible it's 
 trying to run rbssh, and can't run it from within the context of Apache's 
 process. You'll need to disable SELinux if it is on.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Disabling it did not change a thing :(

I'll try to get in touch with the sysadmin, because it should't ask for a 
passphrase when loggin in to the svn, but it does in command line. Weird.


Le jeudi 22 mai 2014 10:18:04 UTC+2, Nicolas Comet a écrit :

 $ cat /etc/sysconfig/selinux 

 # This file controls the state of SELinux on the system.
 # SELINUX= can take one of these three values:
 # enforcing - SELinux security policy is enforced.
 # permissive - SELinux prints warnings instead of enforcing.
 # disabled - No SELinux policy is loaded.
 SELINUX=enforcing
 # SELINUXTYPE= can take one of these two values:
 # targeted - Targeted processes are protected,
 # mls - Multi Level Security protection.
 SELINUXTYPE=targeted 

 Should I disable it?

 Le jeudi 22 mai 2014 10:14:44 UTC+2, Christian Hammond a écrit :

 Okay, those look fine.

 You asked if the key could be passphrase-less, as in not having a 
 passphrase? That's completely fine, and in fact required, since we can't 
 prompt for the passphrase.

 Another thing to check... Do you have SELinux enabled? It's possible it's 
 trying to run rbssh, and can't run it from within the context of Apache's 
 process. You'll need to disable SELinux if it is on.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
It actually worked !!
I had to reboot the machine.

Thanks a lot.

Is it safe to let the SELinux off?

Le jeudi 22 mai 2014 10:23:21 UTC+2, Nicolas Comet a écrit :

 Disabling it did not change a thing :(

 I'll try to get in touch with the sysadmin, because it should't ask for a 
 passphrase when loggin in to the svn, but it does in command line. Weird.


 Le jeudi 22 mai 2014 10:18:04 UTC+2, Nicolas Comet a écrit :

 $ cat /etc/sysconfig/selinux 

 # This file controls the state of SELinux on the system.
 # SELINUX= can take one of these three values:
 # enforcing - SELinux security policy is enforced.
 # permissive - SELinux prints warnings instead of enforcing.
 # disabled - No SELinux policy is loaded.
 SELINUX=enforcing
 # SELINUXTYPE= can take one of these two values:
 # targeted - Targeted processes are protected,
 # mls - Multi Level Security protection.
 SELINUXTYPE=targeted 

 Should I disable it?

 Le jeudi 22 mai 2014 10:14:44 UTC+2, Christian Hammond a écrit :

 Okay, those look fine.

 You asked if the key could be passphrase-less, as in not having a 
 passphrase? That's completely fine, and in fact required, since we can't 
 prompt for the passphrase.

 Another thing to check... Do you have SELinux enabled? It's possible 
 it's trying to run rbssh, and can't run it from within the context of 
 Apache's process. You'll need to disable SELinux if it is on.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Christian Hammond
While it's technically safer to have it on than off, most Linux
distributions do not have it on by default, as it's very strict. You should
be fine to turn it off, so long as this box is otherwise secured from the
outside world.

I believe the RPMs have SELinux rules that you can use if you want to turn
SELinux on. Stephen Gallagher would be able to better answer that.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Thu, May 22, 2014 at 1:31 AM, Nicolas Comet nicolas.co...@gmail.comwrote:

 It actually worked !!
 I had to reboot the machine.

 Thanks a lot.

 Is it safe to let the SELinux off?

 Le jeudi 22 mai 2014 10:23:21 UTC+2, Nicolas Comet a écrit :

 Disabling it did not change a thing :(

 I'll try to get in touch with the sysadmin, because it should't ask for a
 passphrase when loggin in to the svn, but it does in command line. Weird.


 Le jeudi 22 mai 2014 10:18:04 UTC+2, Nicolas Comet a écrit :

 $ cat /etc/sysconfig/selinux

 # This file controls the state of SELinux on the system.
 # SELINUX= can take one of these three values:
 # enforcing - SELinux security policy is enforced.
 # permissive - SELinux prints warnings instead of enforcing.
 # disabled - No SELinux policy is loaded.
 SELINUX=enforcing
 # SELINUXTYPE= can take one of these two values:
 # targeted - Targeted processes are protected,
 # mls - Multi Level Security protection.
 SELINUXTYPE=targeted

 Should I disable it?

 Le jeudi 22 mai 2014 10:14:44 UTC+2, Christian Hammond a écrit :

 Okay, those look fine.

 You asked if the key could be passphrase-less, as in not having a
 passphrase? That's completely fine, and in fact required, since we can't
 prompt for the passphrase.

 Another thing to check... Do you have SELinux enabled? It's possible
 it's trying to run rbssh, and can't run it from within the context of
 Apache's process. You'll need to disable SELinux if it is on.

 Christian

 --
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Errno 13] Permission denied when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Ok.

Anyway, thanks a lot for your time, you saved ours a lot.
Let the reviews begin ;)

Nicolas.

Le jeudi 22 mai 2014 10:57:08 UTC+2, Christian Hammond a écrit :

 While it's technically safer to have it on than off, most Linux 
 distributions do not have it on by default, as it's very strict. You should 
 be fine to turn it off, so long as this box is otherwise secured from the 
 outside world.

 I believe the RPMs have SELinux rules that you can use if you want to turn 
 SELinux on. Stephen Gallagher would be able to better answer that.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 22, 2014 at 1:31 AM, Nicolas Comet 
 nicola...@gmail.comjavascript:
  wrote:

 It actually worked !!
 I had to reboot the machine.

 Thanks a lot.

 Is it safe to let the SELinux off?

 Le jeudi 22 mai 2014 10:23:21 UTC+2, Nicolas Comet a écrit :

 Disabling it did not change a thing :(

 I'll try to get in touch with the sysadmin, because it should't ask for 
 a passphrase when loggin in to the svn, but it does in command line. Weird.


 Le jeudi 22 mai 2014 10:18:04 UTC+2, Nicolas Comet a écrit :

 $ cat /etc/sysconfig/selinux 

 # This file controls the state of SELinux on the system.
 # SELINUX= can take one of these three values:
 # enforcing - SELinux security policy is enforced.
 # permissive - SELinux prints warnings instead of enforcing.
 # disabled - No SELinux policy is loaded.
 SELINUX=enforcing
 # SELINUXTYPE= can take one of these two values:
 # targeted - Targeted processes are protected,
 # mls - Multi Level Security protection.
 SELINUXTYPE=targeted 

 Should I disable it?

 Le jeudi 22 mai 2014 10:14:44 UTC+2, Christian Hammond a écrit :

 Okay, those look fine.

 You asked if the key could be passphrase-less, as in not having a 
 passphrase? That's completely fine, and in fact required, since we can't 
 prompt for the passphrase.

 Another thing to check... Do you have SELinux enabled? It's possible 
 it's trying to run rbssh, and can't run it from within the context of 
 Apache's process. You'll need to disable SELinux if it is on.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Broken Link on Main Page

2014-05-22 Thread Stein, Ruben
Hi,

the link to the Python API on the main page (http://www.reviewboard.org) is 
broken:
http://www.reviewboard.org/docs/rbtools/dev/api/

Regards
Ruben

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Problems upgrading from RB1.5 to RB2.0RC3

2014-05-22 Thread Stephen Gallagher
On 05/21/2014 09:09 PM, Christian Hammond wrote:
 Thanks for the info, everyone!
 
 I just put out a Django Evolution 0.7.1 release, which should fix this
 issue. You can upgrade with:
 
 easy_install -U django_evolution
 
 Or, if using RPMs, Stephen will get to it soon! :)


Updated python-django-evolution packages are now on their way to
updates-testing and epel-testing repositories. You can grab them
immediately from
https://admin.fedoraproject.org/updates/search/python-django-evolution

or wait until they hit the -testing mirrors within 48 hours.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Problems upgrading from RB1.5 to RB2.0RC3

2014-05-22 Thread Paul Fee
Thank you Christian and Stephen,

I'm now able to upgrade my RB1.5 database to RB2.0 using the packages from 
Fedora Rawhide.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: After installation of reviewboard, I am not able to see the site instead I can see only the directory structure

2014-05-22 Thread markdbeyer
Manoj, did you restart httpd and memcached ? I didn't see it in your log.

Mark Beyer

On Thursday, May 22, 2014 2:34:23 AM UTC-7, Manoj Kumar wrote:

 Following are  the steps that I have performed while setting up the 
 site.But I am unable to access the site.



 * Welcome to the Review Board site installation wizard

 This will prepare a Review Board site installation in:

 /var/www/sdk..com

 We need to know a few things before we can prepare your site for
 installation. This will only take a few minutes.


 * Make sure you have the modules you need

 Depending on your installation, you may need certain Python
 modules and servers that are missing.

 If you need support for any of the following, you will need to
 install the necessary modules and restart the install.

 Databases (optional):
 * MySQL (MySQLdb)
 * PostgreSQL (psycopg2)


 * What's the host name for this site?

 This should be the fully-qualified host name without the http://,
 port or path.

 Domain Name: review.com


 * What URL path points to Review Board?

 Typically, Review Board exists at the root of a URL. For example,
 http://reviews.example.com/. In this case, you would specify /.

 However, if you want to listen to, say,
 http://example.com/reviews/, you can specify /reviews/.

 Note that this is the path relative to the domain and should not
 include the domain name.

 The default is /

 Root Path [/]: di


 * What database type will you be using?

 You can type either the name or the number from the list below.

 (1) sqlite3 (not supported for production use)

 Database Type: 1


 * Determining database file path

 The sqlite database file will be stored in
 /var/www/sdk.inmobi.com/data/reviewboard.db

 If you are migrating from an existing installation, you can move
 your existing database there, or edit settings_local.py to point
 to your old location.


 * What memcached host should be used?

 This is in the format of hostname:port

 The default is localhost:11211

 Memcache Server [localhost:11211]: localhost:11211


 * Create an administrator account

 To configure Review Board, you'll need an administrator account.
 It is advised to have one administrator and then use that account
 to grant administrator permissions to your personal user account.

 If you plan to use NIS or LDAP, use an account name other than
 your NIS/LDAP account so as to prevent conflicts.

 The default is admin

 Username [admin]: admin

 Password: 

 Confirm Password: 

 E-Mail Address: xxx...@yyy.com javascript:


 * Installing the site...
 Building site directories ... OK
 Building site configuration files ... OK
 Creating database ... Creating tables ...
 Creating table django_admin_log
 Creating table auth_permission
 Creating table auth_group_permissions
 Creating table auth_group
 Creating table auth_user_groups
 Creating table auth_user_user_permissions
 Creating table auth_user
 Creating table django_content_type
 Creating table django_site
 Creating table django_session
 Creating table extensions_registeredextension
 Creating table siteconfig_siteconfiguration
 Creating table accounts_reviewrequestvisit
 Creating table accounts_profile_starred_review_requests
 Creating table accounts_profile_starred_groups
 Creating table accounts_profile
 Creating table accounts_localsiteprofile
 Creating table attachments_fileattachment
 Creating table changedescs_changedescription
 Creating table diffviewer_filediffdata
 Creating table diffviewer_filediff
 Creating table diffviewer_diffset
 Creating table diffviewer_diffsethistory
 Creating table hostingsvcs_hostingserviceaccount
 Creating table reviews_group_users
 Creating table reviews_group
 Creating table reviews_defaultreviewer_repository
 Creating table reviews_defaultreviewer_people
 Creating table reviews_defaultreviewer_groups
 Creating table reviews_defaultreviewer
 Creating table reviews_comment
 Creating table reviews_fileattachmentcomment
 Creating table reviews_screenshot
 Creating table reviews_reviewrequest_changedescs
 Creating table reviews_reviewrequest_target_people
 Creating table reviews_reviewrequest_inactive_screenshots
 Creating table reviews_reviewrequest_file_attachments
 Creating table reviews_reviewrequest_screenshots
 Creating table reviews_reviewrequest_depends_on
 Creating table reviews_reviewrequest_inactive_file_attachments
 Creating table reviews_reviewrequest_target_groups
 Creating table reviews_reviewrequest
 Creating table reviews_screenshotcomment
 Creating table reviews_review_comments
 Creating table reviews_review_file_attachment_comments
 Creating table reviews_review_screenshot_comments
 Creating table reviews_review
 Creating table reviews_reviewrequestdraft_target_people
 Creating table reviews_reviewrequestdraft_depends_on
 Creating table reviews_reviewrequestdraft_file_attachments
 Creating table 

Error posting review from ClearCase

2014-05-22 Thread Igor Litmanovich
Hi,

I'm trying to create a new review with rbt post and get an error The file 
was not found in the repository (HTTP 400, API Error 207)

My ClearCase client is a Windows machine, while RB server is on Linux, 
hence the CC path is different. So I wonder if it is possible in general to 
work with such setup.

Any input will be appreciated,
Igor.


RBTool output:


M:\igorl_view\devsuppC:\Python27\Scripts\rbt.exe post -d
 RBTools 0.6
 Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit 
(Intel)]
 Running on Windows-7-6.1.7601-SP1
 Home = C:\Users\igorl\AppData\Roaming
 Current directory = M:\igorl_view\devsupp
 Checking for a Subversion repository...
 Unable to execute svn help: skipping SVN
 Checking for a Git repository...
 Running: git rev-parse --git-dir
 Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
 Checking for a Mercurial repository...
 Unable to execute hg --help: skipping Mercurial
 Checking for a CVS repository...
 Unable to execute cvs: skipping CVS
 Checking for a Perforce repository...
 Unable to execute p4 help: skipping Perforce
 Checking for a Plastic repository...
 Unable to execute cm version: skipping Plastic
 Checking for a ClearCase repository...
 Running: cleartool pwv -short
 Running: diff --version
 Running: cleartool lsview -full -properties -cview
 Running: cleartool describe -short vob:.
 Running: cleartool pwv -root
 repository info: Path: M:\igorl_view\devsupp, Base path: 
M:\igorl_view\devsupp, Supports changesets: False
 Making HTTP GET request to http://galaxy521.il.marvell.com/api/
 Making HTTP GET request to http://galaxy521.il.marvell.com/api/info/
 Running: cleartool lscheckout -all -cview -me -fmt %En\t%PVn\t%Vn\n
 Running: diff -uN 
M:\igorl_view\devsupp\clearcase\CGY\scripts\dos2unix.txt@@\main\1 
M:\igorl_view\devsupp\clearcase\CGY\scripts\dos2unix.txt
 Command exited with rc 1: ['diff', '-uN', 
'M:\\igorl_view\\devsupp\\clearcase\\CGY\\scripts\\dos2unix.txt@@\\main\\1', 
'M:\\igorl_view\\devsupp\\clearcase\\
CGY\\scripts\\dos2unix.txt']
--- M:\igorl_view\devsupp\clearcase\CGY\scripts\dos2unix.txt@@\main\1   
2002-04-08 19:13:53.0 +0300
+++ M:\igorl_view\devsupp\clearcase\CGY\scripts\dos2unix.txt2014-05-22 
15:46:27.232475000 +0300
@@ -10,4 +10,6 @@
 - Make sure that you are using the branch/LATEST view to run the script.
 - Modify the script by replacing the main branch with the branch that you 
want to modify.
 - Set into the view, cd into the vob.
-- /dir_in_which_the_script_resides/ccfixEOLr2 . (dot representing the 
current directory)
\ No newline at end of file
+- /dir_in_which_the_script_resides/ccfixEOLr2 . (dot representing the 
current directory)
+
+- test
\ No newline at end of file
---
 Running: cleartool describe -fmt %On 
M:\igorl_view\devsupp\clearcase\CGY\scripts\dos2unix.txt@@\main\1
 Running: cleartool describe -fmt %On 
M:\igorl_view\devsupp\clearcase\CGY\scripts\dos2unix.txt
 Making HTTP GET request to 
http://galaxy521.il.marvell.com/api/review-requests/
 Making HTTP POST request to 
http://galaxy521.il.marvell.com/api/review-requests/
 Making HTTP GET request to 
http://galaxy521.il.marvell.com/api/review-requests/17/diffs/
 Making HTTP POST request to 
http://galaxy521.il.marvell.com/api/review-requests/17/diffs/
 Got API Error 207 (HTTP code 400): The file was not found in the 
repository
 Error data: {u'stat': u'fail', u'file': 
u'M:/igorl_view/devsupp/clearcase/CGY/scripts/dos2unix.txt@@/main/1', 
u'err': {u'msg': u'The file was not found in t
he repository', u'code': 207}, u'revision': u'/main/1'}
Traceback (most recent call last):
  File C:\Python27\Scripts\rbt-script.py, line 9, in module
load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()
  File 
C:\Python27\lib\site-packages\rbtools-0.6-py2.7.egg\rbtools\commands\main.py, 
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
C:\Python27\lib\site-packages\rbtools-0.6-py2.7.egg\rbtools\commands\__init__.py,
 
line 422, in run_from_argv
exit_code = self.main(*args) or 0
  File 
C:\Python27\lib\site-packages\rbtools-0.6-py2.7.egg\rbtools\commands\post.py, 
line 769, in main
submit_as=self.options.submit_as)
  File 
C:\Python27\lib\site-packages\rbtools-0.6-py2.7.egg\rbtools\commands\post.py, 
line 545, in post_request
raise CommandError('\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff


The file was not found in the repository (HTTP 400, API Error 207)

Your review request still exists, but the diff is not attached.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an 

Re: After installation of reviewboard, I am not able to see the site instead I can see only the directory structure

2014-05-22 Thread Christian Hammond
Also, how are you accessing it?

Can you show your Apache configuration? Your entry for the Root Path that
you've shown is not a path.

You also selected sqlite3, which will only support a single user at a time.
You need to install bindings for MySQL.

What Linux distro are you using?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Thu, May 22, 2014 at 10:43 AM, markdbe...@gmail.com wrote:

 Manoj, did you restart httpd and memcached ? I didn't see it in your log.

 Mark Beyer


 On Thursday, May 22, 2014 2:34:23 AM UTC-7, Manoj Kumar wrote:

 Following are  the steps that I have performed while setting up the
 site.But I am unable to access the site.



 * Welcome to the Review Board site installation wizard

 This will prepare a Review Board site installation in:

 /var/www/sdk..com

 We need to know a few things before we can prepare your site for
 installation. This will only take a few minutes.


 * Make sure you have the modules you need

 Depending on your installation, you may need certain Python
 modules and servers that are missing.

 If you need support for any of the following, you will need to
 install the necessary modules and restart the install.

 Databases (optional):
 * MySQL (MySQLdb)
 * PostgreSQL (psycopg2)


 * What's the host name for this site?

 This should be the fully-qualified host name without the http://,
 port or path.

 Domain Name: review.com


 * What URL path points to Review Board?

 Typically, Review Board exists at the root of a URL. For example,
 http://reviews.example.com/. In this case, you would specify /.

 However, if you want to listen to, say,
 http://example.com/reviews/, you can specify /reviews/.

 Note that this is the path relative to the domain and should not
 include the domain name.

 The default is /

 Root Path [/]: di


 * What database type will you be using?

 You can type either the name or the number from the list below.

 (1) sqlite3 (not supported for production use)

 Database Type: 1


 * Determining database file path

 The sqlite database file will be stored in
 /var/www/sdk.inmobi.com/data/reviewboard.db

 If you are migrating from an existing installation, you can move
 your existing database there, or edit settings_local.py to point
 to your old location.


 * What memcached host should be used?

 This is in the format of hostname:port

 The default is localhost:11211

 Memcache Server [localhost:11211]: localhost:11211


 * Create an administrator account

 To configure Review Board, you'll need an administrator account.
 It is advised to have one administrator and then use that account
 to grant administrator permissions to your personal user account.

 If you plan to use NIS or LDAP, use an account name other than
 your NIS/LDAP account so as to prevent conflicts.

 The default is admin

 Username [admin]: admin

 Password:

 Confirm Password:

 E-Mail Address: xxx...@yyy.com


 * Installing the site...
 Building site directories ... OK
 Building site configuration files ... OK
 Creating database ... Creating tables ...
 Creating table django_admin_log
 Creating table auth_permission
 Creating table auth_group_permissions
 Creating table auth_group
 Creating table auth_user_groups
 Creating table auth_user_user_permissions
 Creating table auth_user
 Creating table django_content_type
 Creating table django_site
 Creating table django_session
 Creating table extensions_registeredextension
 Creating table siteconfig_siteconfiguration
 Creating table accounts_reviewrequestvisit
 Creating table accounts_profile_starred_review_requests
 Creating table accounts_profile_starred_groups
 Creating table accounts_profile
 Creating table accounts_localsiteprofile
 Creating table attachments_fileattachment
 Creating table changedescs_changedescription
 Creating table diffviewer_filediffdata
 Creating table diffviewer_filediff
 Creating table diffviewer_diffset
 Creating table diffviewer_diffsethistory
 Creating table hostingsvcs_hostingserviceaccount
 Creating table reviews_group_users
 Creating table reviews_group
 Creating table reviews_defaultreviewer_repository
 Creating table reviews_defaultreviewer_people
 Creating table reviews_defaultreviewer_groups
 Creating table reviews_defaultreviewer
 Creating table reviews_comment
 Creating table reviews_fileattachmentcomment
 Creating table reviews_screenshot
 Creating table reviews_reviewrequest_changedescs
 Creating table reviews_reviewrequest_target_people
 Creating table reviews_reviewrequest_inactive_screenshots
 Creating table reviews_reviewrequest_file_attachments
 Creating table reviews_reviewrequest_screenshots
 Creating table reviews_reviewrequest_depends_on
 Creating table reviews_reviewrequest_inactive_file_attachments
 Creating table 

Content-Disposition is inline instead of attachment in response to Download Diff

2014-05-22 Thread Brett Randall
Hi,

RB 1.7.21.

I've noticed that the response to Download Diff includes a 
Content-Disposition: inline:

GET /r/1234/diff/raw/ HTTP/1.1

Content-Type: text/x-patch
...
Content-Disposition: *inline*; filename=some.patch


Shouldn't that be:

Content-Disposition: *attachment*; filename=some.patch


 ?  Current Chrome version sees text/ MIME type and displays the content 
inline (in the current window) as suggested, instead of raising a download 
dialog.  I image most if not all folks clicking Download Diff want the 
patch as a file, otherwise they would click View Diff.

Has this come up before?  Raise a bug?

Thanks
Brett

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Content-Disposition is inline instead of attachment in response to Download Diff

2014-05-22 Thread Christian Hammond
Hi Brett,

It's actually never come up before, that I know of. It may be more useful
to do that, but I think it's arguable. Certainly, I sometimes view the diff
and am happy looking at it right in the browser, instead of having to save
it somewhere and then open it.

I'm interested in hearing what others have to say.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Thu, May 22, 2014 at 6:25 PM, Brett Randall javabr...@gmail.com wrote:

 Hi,

 RB 1.7.21.

 I've noticed that the response to Download Diff includes a
 Content-Disposition: inline:

 GET /r/1234/diff/raw/ HTTP/1.1

 Content-Type: text/x-patch
 ...
 Content-Disposition: *inline*; filename=some.patch


 Shouldn't that be:

 Content-Disposition: *attachment*; filename=some.patch


  ?  Current Chrome version sees text/ MIME type and displays the content
 inline (in the current window) as suggested, instead of raising a download
 dialog.  I image most if not all folks clicking Download Diff want the
 patch as a file, otherwise they would click View Diff.

 Has this come up before?  Raise a bug?

 Thanks
 Brett

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Content-Disposition is inline instead of attachment in response to Download Diff

2014-05-22 Thread David Trowbridge
Personally, if I click Download X and it displays in the browser, I get
annoyed.

-David


On Thu, May 22, 2014 at 6:37 PM, Christian Hammond chip...@chipx86.comwrote:

 Hi Brett,

 It's actually never come up before, that I know of. It may be more useful
 to do that, but I think it's arguable. Certainly, I sometimes view the diff
 and am happy looking at it right in the browser, instead of having to save
 it somewhere and then open it.

 I'm interested in hearing what others have to say.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 22, 2014 at 6:25 PM, Brett Randall javabr...@gmail.comwrote:

 Hi,

 RB 1.7.21.

 I've noticed that the response to Download Diff includes a
 Content-Disposition: inline:

 GET /r/1234/diff/raw/ HTTP/1.1

 Content-Type: text/x-patch
 ...
 Content-Disposition: *inline*; filename=some.patch


 Shouldn't that be:

 Content-Disposition: *attachment*; filename=some.patch


  ?  Current Chrome version sees text/ MIME type and displays the content
 inline (in the current window) as suggested, instead of raising a download
 dialog.  I image most if not all folks clicking Download Diff want the
 patch as a file, otherwise they would click View Diff.

 Has this come up before?  Raise a bug?

 Thanks
 Brett

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Content-Disposition is inline instead of attachment in response to Download Diff

2014-05-22 Thread Steven MacLeod
Most sites seem to do the opposite of what I want about 50% of the time. I
think in this case though since Review Board gives you a diff viewer, you'd
generally want to download the diff when clicking Download Diff, so I
vote for changing it.

As an aside, here is a firefox add-on I use for dealing with the annoying
opposite case where things try to download and I want to view them in the
browser: https://addons.mozilla.org/en-US/firefox/addon/open-in-browser/


On Thu, May 22, 2014 at 9:41 PM, David Trowbridge trowb...@gmail.comwrote:

 Personally, if I click Download X and it displays in the browser, I get
 annoyed.

 -David


 On Thu, May 22, 2014 at 6:37 PM, Christian Hammond chip...@chipx86.comwrote:

 Hi Brett,

 It's actually never come up before, that I know of. It may be more useful
 to do that, but I think it's arguable. Certainly, I sometimes view the diff
 and am happy looking at it right in the browser, instead of having to save
 it somewhere and then open it.

 I'm interested in hearing what others have to say.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 22, 2014 at 6:25 PM, Brett Randall javabr...@gmail.comwrote:

 Hi,

 RB 1.7.21.

 I've noticed that the response to Download Diff includes a
 Content-Disposition: inline:

 GET /r/1234/diff/raw/ HTTP/1.1

 Content-Type: text/x-patch
 ...
 Content-Disposition: *inline*; filename=some.patch


 Shouldn't that be:

 Content-Disposition: *attachment*; filename=some.patch


  ?  Current Chrome version sees text/ MIME type and displays the content
 inline (in the current window) as suggested, instead of raising a download
 dialog.  I image most if not all folks clicking Download Diff want the
 patch as a file, otherwise they would click View Diff.

 Has this come up before?  Raise a bug?

 Thanks
 Brett

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Content-Disposition is inline instead of attachment in response to Download Diff

2014-05-22 Thread Brett Randall
Thanks Christian.  I ran blame to find the commit where this was added, and 
commented:

https://github.com/reviewboard/reviewboard/commit/ed3e2a4382aeaf4155dabe67a2d259ca72362096

So I think the drive here was to ensure that the patch filename is 
retained, but attachment might be more appropriate than inline for raw 
diff requests.

Thanks
Brett

On Friday, May 23, 2014 11:37:16 AM UTC+10, Christian Hammond wrote:

 Hi Brett,

 It's actually never come up before, that I know of. It may be more useful 
 to do that, but I think it's arguable. Certainly, I sometimes view the diff 
 and am happy looking at it right in the browser, instead of having to save 
 it somewhere and then open it.

 I'm interested in hearing what others have to say.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 22, 2014 at 6:25 PM, Brett Randall java...@gmail.comjavascript:
  wrote:

 Hi,

 RB 1.7.21.

 I've noticed that the response to Download Diff includes a 
 Content-Disposition: inline:

 GET /r/1234/diff/raw/ HTTP/1.1

 Content-Type: text/x-patch
 ...
 Content-Disposition: *inline*; filename=some.patch


 Shouldn't that be:

 Content-Disposition: *attachment*; filename=some.patch


  ?  Current Chrome version sees text/ MIME type and displays the content 
 inline (in the current window) as suggested, instead of raising a download 
 dialog.  I image most if not all folks clicking Download Diff want the 
 patch as a file, otherwise they would click View Diff.

 Has this come up before?  Raise a bug?

 Thanks
 Brett

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: how to apply review code on local machine

2014-05-22 Thread shankar KC
I raised a bug and its resoled as fixed. Fixed version is  0.6.x. Is this 
version available for download. I downloaded the latest version from GIT 
repo but it doesnt contain fix for this issue.
https://code.google.com/p/reviewboard/issues/detail?id=3365 

On Thursday, May 22, 2014 9:49:40 AM UTC+5:30, shankar KC wrote:

 These are the args that are passed to the method. I got them using print 
 statement.
 diff_file_path:- c:\users\shanka~1\appdata\local\temp\tmpzusqly, 
 repository_info.base_path :- None, 
 base_dir :- ,
 self.options.px :- None.

 It looked like its failing bcz base_dir empty and 
 repository_info.base_path :- None
 On Thursday, May 22, 2014 8:40:49 AM UTC+5:30, shankar KC wrote:

 Sure I will open a bug
 thx
 shankar



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3354 in reviewboard: TypeError for New Review Request and View Diff after updade to Review Board 2.0

2014-05-22 Thread reviewboard


Comment #5 on issue 3354 by nicolas@gmail.com: TypeError for New  
Review Request and View Diff after updade to Review Board 2.0

http://code.google.com/p/reviewboard/issues/detail?id=3354

Hello,

As it's an old Review Board installation, we have both PySVN and Subvertpy  
installed.

subversion is also present on the environment.

Here are the versions :
- python-subvertpy : 0.7.3-1
- python-svn : 1.7.2-3
- subversion : 1.6.12dfsg-7

Thanks.
Best regards,

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3366 in reviewboard: Release notes for Reviewboard not visible

2014-05-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3366 by ad643...@gmail.com: Release notes for Reviewboard not  
visible

http://code.google.com/p/reviewboard/issues/detail?id=3366

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What's the URL of the page containing the problem?
http://www.reviewboard.org/docs/releasenotes/


What steps will reproduce the problem?
1. Click on Reviewboard
2. ???
3. 500 - Internal server error

What is the expected output? What do you see instead?
I expect release notes, not a server error.

What operating system are you using? What browser?
Chromium Version 33.0.1750.152 Ubuntu 13.10 (256984) on Lubuntu



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3366 in reviewboard: Release notes for Reviewboard not visible

2014-05-22 Thread reviewboard

Updates:
Status: Fixed
Owner: chip...@gmail.com
Labels: -Priority-Medium Priority-Critical Component-Website

Comment #1 on issue 3366 by chip...@gmail.com: Release notes for  
Reviewboard not visible

http://code.google.com/p/reviewboard/issues/detail?id=3366

Thanks for letting us know. It regressed earlier today. Fixed now.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3354 in reviewboard: TypeError for New Review Request and View Diff after updade to Review Board 2.0

2014-05-22 Thread reviewboard


Comment #6 on issue 3354 by chip...@gmail.com: TypeError for New Review  
Request and View Diff after updade to Review Board 2.0

http://code.google.com/p/reviewboard/issues/detail?id=3354

Subvertpy is newer and somewhat experimental, and it looks like it has some  
issues. PySVN is going to be better-supported, so if you can remove  
subvertpy, you may want to do that for now until we figure out what it's  
doing.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3358 in reviewboard: Unable to reset password

2014-05-22 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 3358 by trowb...@gmail.com: Unable to reset password
http://code.google.com/p/reviewboard/issues/detail?id=3358

Fixed in release-2.0.x (04604ce). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3354 in reviewboard: TypeError for New Review Request and View Diff after updade to Review Board 2.0

2014-05-22 Thread reviewboard


Comment #7 on issue 3354 by nicolas@gmail.com: TypeError for New  
Review Request and View Diff after updade to Review Board 2.0

http://code.google.com/p/reviewboard/issues/detail?id=3354

subvertpy has been removed and Review Board works well.

Issue solved.
Many thanks for your help !

Best regards.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3367 in reviewboard: ImportError: No module named fcntl Djblets 0.8, Windows

2014-05-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3367 by carlos.c...@gmail.com: ImportError: No module named fcntl  
Djblets 0.8, Windows

http://code.google.com/p/reviewboard/issues/detail?id=3367

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?
2.0, Djblets 0.8

What's the URL of the page containing the problem?
First time I try to access reviewboard

What steps will reproduce the problem?
1. Install ReviewBoard on Windows
2. Access the index page
3. Internal server error

What is the expected output? What do you see instead?
Explained above

What operating system are you using? What browser?
Windows 7, Chrome

Please provide any additional information below.
Hi ReviewBoard developers. I'm Carlos Corrales, Bitnami developer. We are  
working on the new major version stack and we are having problems with the  
new Djblets 0.8 in Windows. The error we are getting is


[Thu May 22 09:56:35.183341 2014] [:error] [pid 2892:tid 884] [client  
192.168.1.128:49217]
File E:\\BitNami\\reviewboard-2.0-0\\python\\lib\\site-packages\\djblets-0.8-py2.7.egg\\djblets\\extensions\\manager.py,  
line 30, in module, referer: http://localhost/
[Thu May 22 09:56:35.183341 2014] [:error] [pid 2892:tid 884] [client  
192.168.1.128:49217] import fcntl, referer: http://localhost/
[Thu May 22 09:56:35.183341 2014] [:error] [pid 2892:tid 884] [client  
192.168.1.128:49217] ImportError: No module named fcntl, referer:  
http://localhost


We checked the Djblets Github and the fcntl module was included in Djblets  
in the latest version

https://github.com/djblets/djblets/commit/c24221f0a4aa29a20fc9b123dd4f2af077cdc3b8

This module is only available in Unix systems. Is there any other module  
you can use here which could be compatible with Windows too. Can we modify  
this file to avoid importing fcntl and don't lose its functionality?


Thanks!

Carlos




--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3367 in reviewboard: ImportError: No module named fcntl Djblets 0.8, Windows

2014-05-22 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3367 by chip...@gmail.com: ImportError: No module named  
fcntl Djblets 0.8, Windows

http://code.google.com/p/reviewboard/issues/detail?id=3367

Hi Carlos,

We use this to ensure we don't have multiple attempts at writing the media  
files. It's fairly important for any sites that use extensions.


It turns out that Django provides some abstractions around fcntl and the  
win32api equivalent. This is lock() and unlock() in django.core.files.locks.


I'd be happy to take a patch that switched us to that. Since you're having  
to test this on Windows anyway, you'd be in the best position to write this  
and make sure it works. Would that be okay?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3368 in reviewboard: Security Checker failing?

2014-05-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3368 by dangerpe...@gmail.com: Security Checker failing?
http://code.google.com/p/reviewboard/issues/detail?id=3368

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?
2.0

What's the URL of the page containing the problem?
/admin/security/

What steps will reproduce the problem?
1. Go to Security Checker
2. Adopt instructions from the failing test (executable uploads)
3.

What is the expected output? What do you see instead?
Expected is a passed test; Result is a failing test.

What operating system are you using? What browser?


Please provide any additional information below.

Apache config was there before the test, also replaced with the config from  
the instructions - didn't changed the result


Btw. there is a mismatch between the given list of the test and the  
instructions (the text is missing .phtm) and the nginx config also seem to  
miss the .phtm and .phtml extensions.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3360 in reviewboard: rbt patch crashes

2014-05-22 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 3360 by trowb...@gmail.com: rbt patch crashes
http://code.google.com/p/reviewboard/issues/detail?id=3360

Fixed in release-0.6.x (09ee08e). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3365 in reviewboard: rbt patch fails when used against Perforce repository

2014-05-22 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 3365 by trowb...@gmail.com: rbt patch fails when used  
against Perforce repository

http://code.google.com/p/reviewboard/issues/detail?id=3365

Fixed in release-0.6.x (09ee08e). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3350 in reviewboard: No support for rbt status for non-group submitters

2014-05-22 Thread reviewboard

Updates:
Status: PendingReview
Owner: trowb...@gmail.com
Labels: Component-RBTools

Comment #1 on issue 3350 by trowb...@gmail.com: No support for rbt status  
for non-group submitters

http://code.google.com/p/reviewboard/issues/detail?id=3350

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3370 in reviewboard: condense diffs function runs out of memory on larger installs

2014-05-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3370 by christia...@gmail.com: condense diffs function runs out  
of memory on larger installs

http://code.google.com/p/reviewboard/issues/detail?id=3370


What version are you running?
2.0

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. Running rb-site manage /var/www/codereview condensediffs

What is the expected output? What do you see instead?

The operation fails with a MemoryError:


rb-site manage /var/www/codereview condensediffs

Processing 152829 diffs for duplicates...

This may take a while. It is safe to continue using Review Board while this  
is

processing, but it may temporarily run slower.
Traceback (most recent call last):
  File /usr/local/bin/rb-site, line 9, in module
load_entry_point('ReviewBoard==2.0', 'console_scripts', 'rb-site')()
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0-py2.7.egg/reviewboard/cmdline/rbsite.py,  
line 1733, in main

command.run()
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0-py2.7.egg/reviewboard/cmdline/rbsite.py,  
line 1662, in run

site.run_manage_command(args[0], args[1:])
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0-py2.7.egg/reviewboard/cmdline/rbsite.py,  
line 626, in run_manage_command

execute_from_command_line([__file__, cmd] + params)
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/core/management/__init__.py,  
line 399, in execute_from_command_line

utility.execute()
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/core/management/__init__.py,  
line 392, in execute

self.fetch_command(subcommand).run_from_argv(self.argv)
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/core/management/base.py,  
line 242, in run_from_argv

self.execute(*args, **options.__dict__)
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/core/management/base.py,  
line 285, in execute

output = self.handle(*args, **options)
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/core/management/base.py,  
line 415, in handle

return self.handle_noargs(**options)
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0-py2.7.egg/reviewboard/diffviewer/management/commands/condensediffs.py,  
line 29, in handle_noargs

info = FileDiff.objects.migrate_all()
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0-py2.7.egg/reviewboard/diffviewer/managers.py,  
line 44, in migrate_all

for filediff in filediffs.iterator():
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/query.py,  
line 220, in iterator

for row in compiler.results_iter():
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/compiler.py,  
line 713, in results_iter

for rows in self.execute_sql(MULTI):
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/sql/compiler.py,  
line 786, in execute_sql

cursor.execute(sql, params)
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/util.py,  
line 53, in execute

return self.cursor.execute(sql, params)
   
File /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/backends/mysql/base.py,  
line 124, in execute

return self.cursor.execute(query, args)
  File /usr/lib/python2.7/dist-packages/MySQLdb/cursors.py, line 174, in  
execute

self.errorhandler(self, exc, value)
  File /usr/lib/python2.7/dist-packages/MySQLdb/connections.py, line 36,  
in defaulterrorhandler

raise errorclass, errorvalue
MemoryError


What operating system are you using? What browser?

Ubuntu 12.04 TLS running RB 2.0 on MySql 5.5 backend

Please provide any additional information below.

I upgraded from RB 1.7.25 to 2.0 and got given the advise to run the above  
command.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3371 in reviewboard: Minor UI bug on review request page with long branches

2014-05-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3371 by christia...@gmail.com: Minor UI bug on review request  
page with long branches

http://code.google.com/p/reviewboard/issues/detail?id=3371

What version are you running?
2.0

What's the URL of the page containing the problem?
A review request URL like http://myreviewboardsever/r/12345/

What steps will reproduce the problem?
1. Having a review request with the Branch field set and the branch path is  
fairly long


What is the expected output? What do you see instead?

On Firefox it looks ok but on Chrome it fails to word wrap and the text  
boxes start overlapping with the information properties.

See attached screenshot.

What operating system are you using? What browser?
Firefox vs Chrome on Windows


Please provide any additional information below.


Attachments:
rb_ui_bug.png  24.8 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.