Re: Upgrading from 1.6.4.1 to 2.0.5 woes

2014-09-23 Thread Steven Richards
Sorry I'm just now seeing this. I didn't get the errors for the duplicate entries but I also set MySQL to default all new databases to MyISAM before creating the RB site. Maybe that is the difference. I would also do another check on the tables to make sure they are all MyISAM (just for good

Re: Git style mercurial diffs with file renames don't work

2014-09-23 Thread Colin Caughie
I submitted the patch that enabled Mercurial rename support a few years ago. For the most part it works well but there are definitely cases where it doesn't and I haven't been able to pin them all down. I think it may be something to do with whether the original file was added or changed in

No module named importlib during rb-site upgrade

2014-09-23 Thread Austin Hanson
Trying to upgrade RB from 1.7.25 to 2.0.7 and having some problems. *[root@codereview www]#* uname -morvs Linux 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 GNU/Linux *[root@codereview www]#* python --version Python 2.6.6 *[root@codereview www]#* rb-site --version rb-site

Re: The file something/orother/withsomeextens.ion (revision hexadecimal joy) was not found in the repository

2014-09-23 Thread Kevin Jones
Sent via email. Semi-sensitive information. -Kevin On Monday, September 22, 2014 1:05:32 PM UTC-5, Kevin Jones wrote: Greetings, I'd like to thank the community for their continued help in attempting to figure out solutions to issues I'm having. I've searched the web for possible

Default reviewer not working

2014-09-23 Thread Dieter Odeurs
Hello I'm new to reviewboard and was experimenting with it. I want to test with default reviewers but i don't ge tit working. My test situation: 3 SVN repo's: repo1 repo2 repo3 All of them are structured like repo1 trunk branch tag 4user: admin (admin) me (admin) reviewer1

Re: Reviewboard 2.0.6 hungs on new request with non latin symbols

2014-09-23 Thread Sara Rayburn
Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing

Re: Reviewboard 2.0.6 hungs on new request with non latin symbols

2014-09-23 Thread Christian Hammond
Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. 2) How are you changing the submitter on a review request? We don't have any support for this, without modifying the database. 3) The original bug

Re: The file something/orother/withsomeextens.ion (revision hexadecimal joy) was not found in the repository

2014-09-23 Thread Christian Hammond
Hi Kevin, A few more questions: 1) Can you show me an exact revision string from the error? I'm mostly interested in whether it's a 7-character string (short SHA1) or a full SHA1. 2) Is the developer using RBTools (rbt post) to upload the diff? 3) If RBTools, can you have the developer `rbt

Re: Default reviewer not working

2014-09-23 Thread Christian Hammond
Hi Dieter, Try '/trunk/.*' for the regex path instead. The paths are prefixed with a '/' in modern versions of Review Board. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014

Re: Reviewboard 2.0.6 hungs on new request with non latin symbols

2014-09-23 Thread Sara Rayburn
On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the

Re: No module named importlib during rb-site upgrade

2014-09-23 Thread Austin Hanson
Hi Christian, I can't risk taking RB down. I've cloned the RB directory and the mysql DB it's connected to but haven't had much luck getting the clone to point to the new database. Am I missing an obvious command in rb-site manage? On Tuesday, September 23, 2014 1:20:10 PM UTC-5, Christian

Re: No module named importlib during rb-site upgrade

2014-09-23 Thread Christian Hammond
Hi Austin, Downgrading Markdown and reloading Apache shouldn't result in any further downtime.  To get the clone to talk to the new DB, edit the $sitedir/conf/settings_local.py file. At the top, there will be a DATABASES variable you can change to point to the new location. Christian --

Re: Reviewboard 2.0.6 hungs on new request with non latin symbols

2014-09-23 Thread Christian Hammond
Hi Sara, On September 23, 2014 at 11:39:53 AM, Sara Rayburn (sararayb...@gmail.com) wrote: On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since

httpd remains in 'starting' state when starting via systemctl

2014-09-23 Thread David Carson
After following all directions for installing ReviewBoard 2.0 on CentOS 7, I am still seeing one error that bothers me. When I try to restart httpd, it remains in *'starting'* state and will never go to *'active (running)'* state. However, if I remove the following file, httpd starts and

Re: Reviewboard 2.0.6 hungs on new request with non latin symbols

2014-09-23 Thread Sara Rayburn
I wish I knew what this was. We've had three developers run into this bug today alone. It's becoming a real problem for us. More answers to your questions inline below. Sara On Tuesday, September 23, 2014 2:08:28 PM UTC-5, Christian Hammond wrote: Hi Sara, On September 23, 2014 at

Re: Reviewboard 2.0.6 hungs on new request with non latin symbols

2014-09-23 Thread Christian Hammond
I wish I knew too... So, for each of these cases, is the only visible error the rsp is null error? This is tricky to diagnose without more direct access to the server. Hoping something will allow me to repro it here. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board -

Re: Reviewboard 2.0.6 hungs on new request with non latin symbols

2014-09-23 Thread Christian Hammond
Hi Sara, Something that would really help is a complete dump of the request/responses (headers and payloads) for any requests to /api/* in the Network tab of Firefox when these issues occur. I know some information was sent before, but those look to be the Console tab only. Christian --

ReviewBoard Extensions ( BaseTextAreaField )

2014-09-23 Thread Peter Williams
Hello RB users / admins, Is there a way to specify default text within a BaseTextAreaField? My current field looks something like below: from reviewboard.reviews.fields import BaseTextAreaField class OutputField(BaseTextAreaField): field_id = testme' label = 'test label' I couldn't

Re: ReviewBoard Extensions ( BaseTextAreaField )

2014-09-23 Thread Christian Hammond
Hi Peter, There is no official way of doing this, but you can probably try to override the load_value() function and have it return some default text if not otherwise specified. I'd be happy to take a patch that implements default values cleanly. Christian -- Christian Hammond -

Re: httpd remains in 'starting' state when starting via systemctl

2014-09-23 Thread Stephen Gallagher
On 09/23/2014 03:38 PM, David Carson wrote: After following all directions for installing ReviewBoard 2.0 on CentOS 7, I am still seeing one error that bothers me. When I try to restart httpd, it remains in *'starting'* state and will never go to *'active (running)'* state. However, if I

Re: Resetting open issue counters

2014-09-23 Thread Christian Hammond
Do you happen to have a database backup prior to the upgrade? I'd love to try with a real before/after. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 22, 2014 at 4:15:20 PM,

Re: Resetting open issue counters

2014-09-23 Thread Christian Hammond
Oh, regarding the fix the counts script, I can write one, but it's very unlikely to matter, I realized. It's just going to trigger the exact same logic that's triggered when viewing the review request for the first time, post-upgrade. If it got it wrong before, I don't have much reason to

Re: Reviewboard 2.0.6 hungs on new request with non latin symbols

2014-09-23 Thread Christian Hammond
Hi Sara, David has a repro case for this now, so we're looking into a fix. There will be a 2.0.8 release tonight. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 3:17:04

Re: httpd remains in 'starting' state when starting via systemctl

2014-09-23 Thread David Carson
On Tuesday, September 23, 2014 7:10:51 PM UTC-4, Stephen Gallagher wrote: On 09/23/2014 03:38 PM, David Carson wrote: After following all directions for installing ReviewBoard 2.0 on CentOS 7, I am still seeing one error that bothers me. When I try to restart httpd, it remains in

Re: Using complex filters in the Custom LDAP User Search Filter

2014-09-23 Thread Stephen Gallagher
On 09/23/2014 08:22 PM, Bruce Cran wrote: Should it be possible to use a more complex filter in the Custom LDAP User Search Filter field? For example I'd like to restrict access to a single AD/LDAP group, so I tried something like:

Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 What version are you running? 2.0.7 What's the URL of the page containing the problem?

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #1 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Are there any errors in the server's log file? -- You received this message because this project is configured to send all issue

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Updates: Status: NeedInfo Comment #2 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Also, what repository type? -- You received this message because this project is configured to send all

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #3 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 repository type is svn I can see an error report Email sent from server: Traceback (most recent call last): File

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #4 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Double checked the error in the log is the same as I got from Email, no further message can be seen -- You received this message because

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #5 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 OK, that's definitely something we'll get fixed, but I'm not sure it's causing your problem. Can you look in the browser's Network console

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #6 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Looks like a Javscript error: TypeError: rsp is null in http://servername/static/rb/js/newReviewRequest.min.4427138a3b1f.js Code is where

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #7 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Can you look in the network tab of the browser tools to find the response that's creating that error? It's probably a 500. -- You received

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #8 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Sorry I didn't mention it clear here, I can see no network traffic at all after I click OK, it looks JS crashed before that. I tried using

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #10 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 And/or any POSTS to validate-diff/ or diffs/ -- You received this message because this project is configured to send all issue

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #11 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Sorry no 500 error, there are some others after I chose Repository but all 200 normal request which I also believed is for Post-Commit

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #12 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Can you show me the responses to any POSTs (successful or not) to /api/validation/diffs/ or /api/review-requests/XX/diffs/? -- You

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #13 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Sorry in this failed case there is no post to /api/validation/diffs/ or /api/review-requests/XX/diffs/ at all. -- You received this

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #14 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 OK, I have a reproduction case. We'll get this fixed for 2.0.8,

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Updates: Status: Fixed Comment #15 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Fixed in release-2.0.x (e7e671a). Thanks for all your help! -- You received this message because this project

Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded

2014-09-23 Thread reviewboard
Comment #16 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Thank you for your quick fix, looking forward to the upgrade. -- You received this message because this project is configured to send all

Issue 3580 in reviewboard: IssueOpened checkbox status is not loaded correctly when opening that comment dialog the 1st time after page loading

2014-09-23 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3580 by oswi...@gmail.com: IssueOpened checkbox status is not loaded correctly when opening that comment dialog the 1st time after page loading https://code.google.com/p/reviewboard/issues/detail?id=3580 *** READ THIS