Re: Upgrading from 1.6.4.1 to 2.0.5 woes
Sorry I'm just now seeing this. I didn't get the errors for the duplicate entries but I also set MySQL to default all new databases to MyISAM before creating the RB site. Maybe that is the difference. I would also do another check on the tables to make sure they are all MyISAM (just for good measure). Quick from the mySQL prompt: USE information_schema; SELECT * FROM tables; I know I had a really hard time with this as well and I'm glad you got yours migrated. Steven Richards On Monday, September 22, 2014 10:35:45 PM UTC-4, Kenneth Wong wrote: I updated to 2.0.7 and then gave Steven's suggestion of converting all tables to use the MyISAM engine a try. I think everything is up and running. There were still the duplicate entry errors (as stated in my original msg) but I think everything is working. Thanks Steven! The rundown of steps were: 1. Created a brand new 2.0.7 reviewboard site that uses sqlite. (rb1) 2. Copied over the 1.6.4.1 reviewboard.db file. 3. Performed rb-site upgrade rb1. I had to run a couple of other changes from the commandline such as: 1. removing the old authentication backend 2. adding in active directirectory authentication 4. Performed rb-site manage rb1 condensediffs 5. Also performed all the necessary permission changed Now that I have a working reviewboard 2.0.7 using sqlite... I worked on migrating everything using Steven's suggestion. 1. Create a brand new 2.0.7 reviewboard site that uses mysql (rb2) 1. Performed mysqldump rb2 rb2.sql 2. Replaced all instances of ENGINE=InnoDB with ENGINE=MYISAM in the rb2.sql file and saved it as rb2_myisam.sql 3. Performed mysql rb2 rb2_myisam.sql (this re-creates all the tables using MyISAM... I tried using just the alter command but ran into errors foreign constraint errors again). 2. Performed rb-site manage rb1 dumpdb rb1.json 3. Performed rb-site manage rb2 loaddb rb1.json 4. I had to make a few more modifications as follows: 1. rb-site manage rb2 set-siteconfig -- --key=site_media_root --value=/var/www/rb2/htdocs/media 2. rb-site manage rb2 set-siteconfig -- --key=site_static_root --value=/var/www/rb2/htdocs/static 3. rb-site manage rb2 set-siteconfig -- --key=site_static_url --value=/rb2/static The last three commands were required to get the website to display correctly since I pulled over a lot of the older paths from the original installation. I'll provide additional updates as I do more testing. On Monday, 22 September 2014 13:20:22 UTC-4, Kenneth Wong wrote: Hi Steven, thanks for the info. I'll give it a try tonight. I think I read somewhere that using MyISAM instead of using InnoDB effectively removes the foreign constraint checks during the migration. This allows the row insertion even if there may be problems with the relationship between records. Am I understanding it correctly? If so, are there implications that I should be aware of if I go down this road permanently? On Mon, Sep 22, 2014 at 12:02 PM, Steven Richards wrote: Not sure if you've received a fix yet but i just wanted to share that I too had issues upgrading from 1.6 to (1.7.25 and 2.0.5). To fix the upgrade issue in my case I made MyISAM the default for MySQL before creating and restoring the database. Add the following line under [mysqld] in my.conf: default-storage-engine=MyISAM You can of course just set a single Database to use it instead of the entire install (just in case you run another application on the same box). I should probably also mention i had issues going to 2.0.5 even with this fix. The upgrade worked great but we would receive random error pages when trying to create a new Diff. 2.0.6 Worked flawlessly for me. Steven Richards On Monday, September 22, 2014 8:13:37 AM UTC-4, Kenneth Wong wrote: Hi Christian, looks like all of the tables are using the InnoDB engine. The commands I used inside mysql were: use rb2; show table status; On Sunday, 21 September 2014 22:24:09 UTC-4, Christian Hammond wrote: Hi Kenneth, Can you determine if the tables being created are using InnoDB or MyISAM? Or a mix? Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 21, 2014 at 7:18:11 PM, Kenneth Wong (lost...@gmail.com) wrote: Hi, I'm upgrading from 1.6.4.1 to 2.0.5 as well as transitioning from sqlite to mysql. I'm looking for some help on understanding the error messages and what I can do about it. As per Christian's recommendation (from another thread), I did the following: 1. Create a brand new 2.0.5 reviewboard site that uses sqlite. (rb1) 2. Copied over the 1.6.4.1 reviewboard.db file. 3. Performed rb-site upgrade rb1. I had to run a couple of other
Re: Git style mercurial diffs with file renames don't work
I submitted the patch that enabled Mercurial rename support a few years ago. For the most part it works well but there are definitely cases where it doesn't and I haven't been able to pin them all down. I think it may be something to do with whether the original file was added or changed in the parent diff, in which case the master repo may not know about it. I also know there's a bug where if a file has been renamed but there is no change to its content, the diff doesn't display correctly. Colin On 9/16/2014 6:39 AM, Sara Rayburn wrote: Hi, We have a problem where the diff viewer for diffs with rename operations. We use mercurial, and output the diff in git style. Here's a trivial example diff file: diff --git a/include/CCvideo/configUI.H b/include/CCvideo/configUITest.H rename from include/CCvideo/configUI.H rename to include/CCvideo/configUITest.H In the Diff summary section is: include/CCvideo/configUITest.H http://reviewboard.cctechnol.com/r/4112/diff/#0 Was include/CCvideo/configUI.H So I guess the rename works up to a point, but this is the error in the view diff page: The file 'include/CCvideo/configUI.H' (rUNKNOWN) could not be found in the repository This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support http://reviewboard.cctechnol.com/support/. With traceback as follows: Traceback (most recent call last): File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/reviews/views.py, line 1088, in create_renderer *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 328, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 369, in _get_requested_diff_file request=self.request) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 383, in populate_diff_chunks chunks = generator.get_chunks() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 153, in get_chunks large_data=True) File /usr/lib/python2.6/site-packages/Djblets-0.8.10-py2.6.egg/djblets/cache/backend.py, line 111, in cache_memoize data = lookup_callable() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 152, in lambda lambda: list(self._get_chunks_uncached()), File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 159, in _get_chunks_uncached old = get_original_file(self.filediff, self.request, encoding_list) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 169, in get_original_file request=request) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 291, in get_file large_data=True)[0] File /usr/lib/python2.6/site-packages/Djblets-0.8.10-py2.6.egg/djblets/cache/backend.py, line 111, in cache_memoize data = lookup_callable() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 290, in lambda request)], File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 456, in _get_file_uncached data = self.get_scmtool().get_file(path, revision) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/hg.py, line 43, in get_file return self.client.cat_file(path, six.text_type(revision)) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/hg.py, line 264, in cat_file raise FileNotFoundError(path, rev) FileNotFoundError: The file 'include/CCvideo/configUI.H' (rUNKNOWN) could not be found in the repository -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com mailto:reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons:
No module named importlib during rb-site upgrade
Trying to upgrade RB from 1.7.25 to 2.0.7 and having some problems. *[root@codereview www]#* uname -morvs Linux 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 GNU/Linux *[root@codereview www]#* python --version Python 2.6.6 *[root@codereview www]#* rb-site --version rb-site 2.0.7 *[root@codereview www]#* django-admin --version 1.6.7 *[root@codereview www]#* rb-site upgrade reviewboard Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- [!] Unable to execute the manager command syncdb: No module named importlib [!] Unable to execute the manager command registerscmtools: No module named importlib [!] Unable to execute the manager command evolve: No module named importlib --- end log output --- Resetting in-database caches. [!] Unable to execute the manager command fixreviewcounts: cannot import name FileAttachment Upgrade complete! There are duplicate copies of diffs in your database that can be condensed. These are the result of posting several iterations of a change for review on older versions of Review Board. Removing duplicate diff data will save space in your database and speed up future upgrades. To condense duplicate diffs, type the following: $ rb-site manage /var/www/reviewboard condensediffs *[root@codereview www]#* tail -f /var/log/httpd/error_log [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] from reviewboard.admin.widgets import increment_sync_num, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/admin/widgets.py, line 17, in module, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] from reviewboard.attachments.models import FileAttachment, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/attachments/models.py, line 12, in module, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] from reviewboard.attachments.mimetypes import MimetypeHandler, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/attachments/mimetypes.py, line 17, in module, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] import markdown, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/Markdown-2.5-py2.6.egg/markdown/__init__.py, line 40, in module, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] import importlib, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] ImproperlyConfigured: Error importing module reviewboard.admin.middleware: No module named importlib, referer: http://cr.carsforsale.local/r/ -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: The file something/orother/withsomeextens.ion (revision hexadecimal joy) was not found in the repository
Sent via email. Semi-sensitive information. -Kevin On Monday, September 22, 2014 1:05:32 PM UTC-5, Kevin Jones wrote: Greetings, I'd like to thank the community for their continued help in attempting to figure out solutions to issues I'm having. I've searched the web for possible solutions to this and haven't found any that have worked. We have our repositories on one machine while reviewboard sits on another. The links to the repositories are (I believe) configured correctly, as is user access. However, the error listed in the subject appears when one of my users attempts to post a review. I've examined access issues for the reviewboard user, whether or not the repo is set up properly, and about a million other things. Yet still the error persists. Attempts to turn on logging are met with read-only access errors. I realize that's probably the most critical piece of data, but what user needs access to write log files? The reviewboard user? -Kevin -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Default reviewer not working
Hello I'm new to reviewboard and was experimenting with it. I want to test with default reviewers but i don't ge tit working. My test situation: 3 SVN repo's: repo1 repo2 repo3 All of them are structured like repo1 trunk branch tag 4user: admin (admin) me (admin) reviewer1 reviewer2 Now i want that for every review in the trunk of repo 1 admin would be the default reviewer. Default review setting are: name: defaultRepo1 regex: trunk/.* default group: / default user: admin But when I add a new review request of the trunk in repo 1 no default reviewer would be added. Is there something wrong with the setting? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. 2) How are you changing the submitter on a review request? We don't have any support for this, without modifying the database. 3) The original bug report seemed to have to do with JavaScript errors on uploading diffs, but now it sounds like it's other fields as well? We haven't been able to come up with any working repro case for a diff causing a hang. If that's the true cause of your hangs, we're definitely going to need source files and patch files that consistently reproduce this for our own testing. Can you also answer a few more questions: 1) Is this still only happening with Firefox? 2) What version of Firefox? 3) What database server are you using, and which version? 4) If MySQL, are the tables set for Unicode? 5) Are you using any form of proxy server at your company? Thanks, Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn (sararayb...@gmail.com) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we updated, and when someone tried to change the submitter on the request it seems to have run into the error again. When the same user copied the patch and created a new review request (since they couldn't take ownership of the request) they ran into the unicode bug again. On Tuesday, September 23, 2014 12:51:51 PM UTC-5, Sara Rayburn wrote: Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: The file something/orother/withsomeextens.ion (revision hexadecimal joy) was not found in the repository
Hi Kevin, A few more questions: 1) Can you show me an exact revision string from the error? I'm mostly interested in whether it's a 7-character string (short SHA1) or a full SHA1. 2) Is the developer using RBTools (rbt post) to upload the diff? 3) If RBTools, can you have the developer `rbt post` with --debug, and provide the information? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 8:49:54 AM, Kevin Jones (kjlo...@gmail.com) wrote: Sent via email. Semi-sensitive information. -Kevin On Monday, September 22, 2014 1:05:32 PM UTC-5, Kevin Jones wrote: Greetings, I'd like to thank the community for their continued help in attempting to figure out solutions to issues I'm having. I've searched the web for possible solutions to this and haven't found any that have worked. We have our repositories on one machine while reviewboard sits on another. The links to the repositories are (I believe) configured correctly, as is user access. However, the error listed in the subject appears when one of my users attempts to post a review. I've examined access issues for the reviewboard user, whether or not the repo is set up properly, and about a million other things. Yet still the error persists. Attempts to turn on logging are met with read-only access errors. I realize that's probably the most critical piece of data, but what user needs access to write log files? The reviewboard user? -Kevin -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Default reviewer not working
Hi Dieter, Try '/trunk/.*' for the regex path instead. The paths are prefixed with a '/' in modern versions of Review Board. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:39:26 AM, Dieter Odeurs (dieterode...@gmail.com) wrote: Hello I'm new to reviewboard and was experimenting with it. I want to test with default reviewers but i don't ge tit working. My test situation: 3 SVN repo's: repo1 repo2 repo3 All of them are structured like repo1 trunk branch tag 4user: admin (admin) me (admin) reviewer1 reviewer2 Now i want that for every review in the trunk of repo 1 admin would be the default reviewer. Default review setting are: name: defaultRepo1 regex: trunk/.* default group: / default user: admin But when I add a new review request of the trunk in repo 1 no default reviewer would be added. Is there something wrong with the setting? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the bug since updating to 2.0.7. I know this because we have a request with non-unicode contents that was uploaded before I updated, without problems. Trying to reuse the same patch for an additional review request triggered the same unicode error we saw previously. 2) How are you changing the submitter on a review request? We don't have any support for this, without modifying the database. We are in fact modifying the database via the admin tab. 3) The original bug report seemed to have to do with JavaScript errors on uploading diffs, but now it sounds like it's other fields as well? We haven't been able to come up with any working repro case for a diff causing a hang. If that's the true cause of your hangs, we're definitely going to need source files and patch files that consistently reproduce this for our own testing. I will try to provide a broken diff. Can you also answer a few more questions: 1) Is this still only happening with Firefox? Yes 2) What version of Firefox? 30 3) What database server are you using, and which version? mysql 14.14 4) If MySQL, are the tables set for Unicode? The tables are a mix of latin1 and utf8. Perhaps this is the problem? 5) Are you using any form of proxy server at your company? No. Very vanilla setup on a VM. Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn (sarar...@gmail.com javascript:) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we updated, and when someone tried to change the submitter on the request it seems to have run into the error again. When the same user copied the patch and created a new review request (since they couldn't take ownership of the request) they ran into the unicode bug again. On Tuesday, September 23, 2014 12:51:51 PM UTC-5, Sara Rayburn wrote: Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: No module named importlib during rb-site upgrade
Hi Christian, I can't risk taking RB down. I've cloned the RB directory and the mysql DB it's connected to but haven't had much luck getting the clone to point to the new database. Am I missing an obvious command in rb-site manage? On Tuesday, September 23, 2014 1:20:10 PM UTC-5, Christian Hammond wrote: Hey Austin, There was another issue reported recently with 'importlib'-related issues, but we haven't had any responses yet, so we'll have to do some investigating with your server. I think the culprit is the Markdown module. Can you try downgrading to Markdown-2.3.1? You can delete /usr/lib/python2.6/site-packages/Markdown-2.5-py2.6.egg and then do: easy_install Markdown==2.3.1 This is the version I'm using, so I know it works at least. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 8:33:28 AM, Austin Hanson (ber...@gmail.com javascript:) wrote: Trying to upgrade RB from 1.7.25 to 2.0.7 and having some problems. *[root@codereview www]#* uname -morvs Linux 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 GNU/Linux *[root@codereview www]#* python --version Python 2.6.6 *[root@codereview www]#* rb-site --version rb-site 2.0.7 *[root@codereview www]#* django-admin --version 1.6.7 *[root@codereview www]#* rb-site upgrade reviewboard Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- -- [!] Unable to execute the manager command syncdb: No module named importlib [!] Unable to execute the manager command registerscmtools: No module named importlib [!] Unable to execute the manager command evolve: No module named importlib --- --- Resetting in-database caches. [!] Unable to execute the manager command fixreviewcounts: cannot import name FileAttachment Upgrade complete! There are duplicate copies of diffs in your database that can be condensed. These are the result of posting several iterations of a change for review on older versions of Review Board. Removing duplicate diff data will save space in your database and speed up future upgrades. To condense duplicate diffs, type the following: $ rb-site manage /var/www/reviewboard condensediffs *[root@codereview www]#* tail -f /var/log/httpd/error_log [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] from reviewboard.admin.widgets import increment_sync_num, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/admin/widgets.py, line 17, in , referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] from reviewboard.attachments.models import FileAttachment, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/attachments/models.py, line 12, in , referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] from reviewboard.attachments.mimetypes import MimetypeHandler, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/attachments/mimetypes.py, line 17, in , referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] import markdown, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/Markdown-2.5-py2.6.egg/markdown/__init__.py, line 40, in , referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] import importlib, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] ImproperlyConfigured: Error importing module reviewboard.admin.middleware: No module named importlib, referer: http://cr.carsforsale.local/r/ -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to
Re: No module named importlib during rb-site upgrade
Hi Austin, Downgrading Markdown and reloading Apache shouldn't result in any further downtime. To get the clone to talk to the new DB, edit the $sitedir/conf/settings_local.py file. At the top, there will be a DATABASES variable you can change to point to the new location. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 11:57:16 AM, Austin Hanson (ber...@gmail.com) wrote: Hi Christian, I can't risk taking RB down. I've cloned the RB directory and the mysql DB it's connected to but haven't had much luck getting the clone to point to the new database. Am I missing an obvious command in rb-site manage? On Tuesday, September 23, 2014 1:20:10 PM UTC-5, Christian Hammond wrote: Hey Austin, There was another issue reported recently with 'importlib'-related issues, but we haven't had any responses yet, so we'll have to do some investigating with your server. I think the culprit is the Markdown module. Can you try downgrading to Markdown-2.3.1? You can delete /usr/lib/python2.6/site-packages/Markdown-2.5-py2.6.egg and then do: easy_install Markdown==2.3.1 This is the version I'm using, so I know it works at least. Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 8:33:28 AM, Austin Hanson (ber...@gmail.com ) wrote: Trying to upgrade RB from 1.7.25 to 2.0.7 and having some problems. *[root@codereview www]#* uname -morvs Linux 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 GNU/Linux *[root@codereview www]#* python --version Python 2.6.6 *[root@codereview www]#* rb-site --version rb-site 2.0.7 *[root@codereview www]#* django-admin --version 1.6.7 *[root@codereview www]#* rb-site upgrade reviewboard Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- -- [!] Unable to execute the manager command syncdb: No module named importlib [!] Unable to execute the manager command registerscmtools: No module named importlib [!] Unable to execute the manager command evolve: No module named importlib --- --- Resetting in-database caches. [!] Unable to execute the manager command fixreviewcounts: cannot import name FileAttachment Upgrade complete! There are duplicate copies of diffs in your database that can be condensed. These are the result of posting several iterations of a change for review on older versions of Review Board. Removing duplicate diff data will save space in your database and speed up future upgrades. To condense duplicate diffs, type the following: $ rb-site manage /var/www/reviewboard condensediffs *[root@codereview www]#* tail -f /var/log/httpd/error_log [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] from reviewboard.admin.widgets import increment_sync_num, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/admin/widgets.py, line 17, in , referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] from reviewboard.attachments.models import FileAttachment, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/attachments/models.py, line 12, in , referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] from reviewboard.attachments.mimetypes import MimetypeHandler, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/attachments/mimetypes.py, line 17, in , referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] import markdown, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] File /usr/lib/python2.6/site-packages/Markdown-2.5-py2.6.egg/markdown/__init__.py, line 40, in , referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] import importlib, referer: http://cr.carsforsale.local/r/ [Tue Sep 23 15:12:02 2014] [error] [client 192.168.2.13] ImproperlyConfigured: Error importing module reviewboard.admin.middleware: No module named importlib, referer:
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Hi Sara, On September 23, 2014 at 11:39:53 AM, Sara Rayburn (sararayb...@gmail.com) wrote: On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the bug since updating to 2.0.7. I know this because we have a request with non-unicode contents that was uploaded before I updated, without problems. Trying to reuse the same patch for an additional review request triggered the same unicode error we saw previously. On September 9th, you posted saying I am having a similar problem after upgrading to 2.0.6. We didn't have a 2.0.7 release until the 15th. 1) Is this still only happening with Firefox? Yes 2) What version of Firefox? 30 Does 33 work? I haven't had any issues with any recent version... 4) If MySQL, are the tables set for Unicode? The tables are a mix of latin1 and utf8. Perhaps this is the problem? This is likely to be the cause of at least some of your problems. You'll need to make sure they're all in utf8, otherwise there will be issues even populating the database with non-latin1 text. This can break us in numerous ways. 5) Are you using any form of proxy server at your company? No. Very vanilla setup on a VM. How about HTTP proxies that the users configure in their browsers? We've seen cases in the past of some proxies messing with the responses from our API. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn (sarar...@gmail.com ) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we updated, and when someone tried to change the submitter on the request it seems to have run into the error again. When the same user copied the patch and created a new review request (since they couldn't take ownership of the request) they ran into the unicode bug again. On Tuesday, September 23, 2014 12:51:51 PM UTC-5, Sara Rayburn wrote: Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com . For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
httpd remains in 'starting' state when starting via systemctl
After following all directions for installing ReviewBoard 2.0 on CentOS 7, I am still seeing one error that bothers me. When I try to restart httpd, it remains in *'starting'* state and will never go to *'active (running)'* state. However, if I remove the following file, httpd starts and stops properly. /usr/lib/systemd/system/httpd.service.d/reviewboards-sites.conf I only discovered this file because there was an error in /var/log/messages regarding the line type=oneshot (which should be *T*ype=oneshot). After correcting the spelling, I no longer see the error, but I cannot start httpd either. I have moved this file out of the way, and my ReviewBoard installation is now working, at least to the point of bringing up the interface and allowing me to login as admin. But I'm wondering what the repercussions of removing the systemd file might be. Thanks, David -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
I wish I knew what this was. We've had three developers run into this bug today alone. It's becoming a real problem for us. More answers to your questions inline below. Sara On Tuesday, September 23, 2014 2:08:28 PM UTC-5, Christian Hammond wrote: Hi Sara, On September 23, 2014 at 11:39:53 AM, Sara Rayburn (sarar...@gmail.com javascript:) wrote: On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the bug since updating to 2.0.7. I know this because we have a request with non-unicode contents that was uploaded before I updated, without problems. Trying to reuse the same patch for an additional review request triggered the same unicode error we saw previously. On September 9th, you posted saying I am having a similar problem after upgrading to 2.0.6. We didn't have a 2.0.7 release until the 15th. Good point. I guess it's a problem since before that. 1) Is this still only happening with Firefox? Yes 2) What version of Firefox? 30 Does 33 work? I haven't had any issues with any recent version... Tried in most recent Firefox (35), issue remains. 4) If MySQL, are the tables set for Unicode? The tables are a mix of latin1 and utf8. Perhaps this is the problem? This is likely to be the cause of at least some of your problems. You'll need to make sure they're all in utf8, otherwise there will be issues even populating the database with non-latin1 text. This can break us in numerous ways. I made sure the database encodings were utf8 and even set the encoding for the repository in question to utf8 in the admin repo settings for reviewboard. I added utf8 as the charset in settings_local.py. All of these changes later, I still have the problem. 5) Are you using any form of proxy server at your company? No. Very vanilla setup on a VM. How about HTTP proxies that the users configure in their browsers? We've seen cases in the past of some proxies messing with the responses from our API. Nope, no one. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn (sarar...@gmail.com ) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we updated, and when someone tried to change the submitter on the request it seems to have run into the error again. When the same user copied the patch and created a new review request (since they couldn't take ownership of the request) they ran into the unicode bug again. On Tuesday, September 23, 2014 12:51:51 PM UTC-5, Sara Rayburn wrote: Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com . For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
I wish I knew too... So, for each of these cases, is the only visible error the rsp is null error? This is tricky to diagnose without more direct access to the server. Hoping something will allow me to repro it here. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 1:43:11 PM, Sara Rayburn (sararayb...@gmail.com) wrote: I wish I knew what this was. We've had three developers run into this bug today alone. It's becoming a real problem for us. More answers to your questions inline below. Sara On Tuesday, September 23, 2014 2:08:28 PM UTC-5, Christian Hammond wrote: Hi Sara, On September 23, 2014 at 11:39:53 AM, Sara Rayburn (sarar...@gmail.com ) wrote: On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the bug since updating to 2.0.7. I know this because we have a request with non-unicode contents that was uploaded before I updated, without problems. Trying to reuse the same patch for an additional review request triggered the same unicode error we saw previously. On September 9th, you posted saying I am having a similar problem after upgrading to 2.0.6. We didn't have a 2.0.7 release until the 15th. Good point. I guess it's a problem since before that. 1) Is this still only happening with Firefox? Yes 2) What version of Firefox? 30 Does 33 work? I haven't had any issues with any recent version... Tried in most recent Firefox (35), issue remains. 4) If MySQL, are the tables set for Unicode? The tables are a mix of latin1 and utf8. Perhaps this is the problem? This is likely to be the cause of at least some of your problems. You'll need to make sure they're all in utf8, otherwise there will be issues even populating the database with non-latin1 text. This can break us in numerous ways. I made sure the database encodings were utf8 and even set the encoding for the repository in question to utf8 in the admin repo settings for reviewboard. I added utf8 as the charset in settings_local.py. All of these changes later, I still have the problem. 5) Are you using any form of proxy server at your company? No. Very vanilla setup on a VM. How about HTTP proxies that the users configure in their browsers? We've seen cases in the past of some proxies messing with the responses from our API. Nope, no one. Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn (sarar...@gmail.com ) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we updated, and when someone tried to change the submitter on the request it seems to have run into the error again. When the same user copied the patch and created a new review request (since they couldn't take ownership of the request) they ran into the unicode bug again. On Tuesday, September 23, 2014 12:51:51 PM UTC-5, Sara Rayburn wrote: Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com . For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ ---
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Hi Sara, Something that would really help is a complete dump of the request/responses (headers and payloads) for any requests to /api/* in the Network tab of Firefox when these issues occur. I know some information was sent before, but those look to be the Console tab only. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 2:23:34 PM, Christian Hammond (christ...@beanbaginc.com) wrote: I wish I knew too... So, for each of these cases, is the only visible error the rsp is null error? This is tricky to diagnose without more direct access to the server. Hoping something will allow me to repro it here. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 1:43:11 PM, Sara Rayburn (sararayb...@gmail.com) wrote: I wish I knew what this was. We've had three developers run into this bug today alone. It's becoming a real problem for us. More answers to your questions inline below. Sara On Tuesday, September 23, 2014 2:08:28 PM UTC-5, Christian Hammond wrote: Hi Sara, On September 23, 2014 at 11:39:53 AM, Sara Rayburn (sarar...@gmail.com ) wrote: On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the bug since updating to 2.0.7. I know this because we have a request with non-unicode contents that was uploaded before I updated, without problems. Trying to reuse the same patch for an additional review request triggered the same unicode error we saw previously. On September 9th, you posted saying I am having a similar problem after upgrading to 2.0.6. We didn't have a 2.0.7 release until the 15th. Good point. I guess it's a problem since before that. 1) Is this still only happening with Firefox? Yes 2) What version of Firefox? 30 Does 33 work? I haven't had any issues with any recent version... Tried in most recent Firefox (35), issue remains. 4) If MySQL, are the tables set for Unicode? The tables are a mix of latin1 and utf8. Perhaps this is the problem? This is likely to be the cause of at least some of your problems. You'll need to make sure they're all in utf8, otherwise there will be issues even populating the database with non-latin1 text. This can break us in numerous ways. I made sure the database encodings were utf8 and even set the encoding for the repository in question to utf8 in the admin repo settings for reviewboard. I added utf8 as the charset in settings_local.py. All of these changes later, I still have the problem. 5) Are you using any form of proxy server at your company? No. Very vanilla setup on a VM. How about HTTP proxies that the users configure in their browsers? We've seen cases in the past of some proxies messing with the responses from our API. Nope, no one. Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn (sarar...@gmail.com ) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we updated, and when someone tried to change the submitter on the request it seems to have run into the error again. When the same user copied the patch and created a new review request (since they couldn't take ownership of the request) they ran into the unicode bug again. On Tuesday, September 23, 2014 12:51:51 PM UTC-5, Sara Rayburn wrote: Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at
ReviewBoard Extensions ( BaseTextAreaField )
Hello RB users / admins, Is there a way to specify default text within a BaseTextAreaField? My current field looks something like below: from reviewboard.reviews.fields import BaseTextAreaField class OutputField(BaseTextAreaField): field_id = testme' label = 'test label' I couldn't see any mention of this in the API and digging through the code suggests that you can't but I may be wrong. Thanks for any help. -P -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard Extensions ( BaseTextAreaField )
Hi Peter, There is no official way of doing this, but you can probably try to override the load_value() function and have it return some default text if not otherwise specified. I'd be happy to take a patch that implements default values cleanly. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 3:33:53 PM, Peter Williams (i.ask.django.questi...@gmail.com) wrote: Hello RB users / admins, Is there a way to specify default text within a BaseTextAreaField? My current field looks something like below: from reviewboard.reviews.fields import BaseTextAreaField class OutputField(BaseTextAreaField): field_id = testme' label = 'test label' I couldn't see any mention of this in the API and digging through the code suggests that you can't but I may be wrong. Thanks for any help. -P -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: httpd remains in 'starting' state when starting via systemctl
On 09/23/2014 03:38 PM, David Carson wrote: After following all directions for installing ReviewBoard 2.0 on CentOS 7, I am still seeing one error that bothers me. When I try to restart httpd, it remains in *'starting'* state and will never go to *'active (running)'* state. However, if I remove the following file, httpd starts and stops properly. /usr/lib/systemd/system/httpd.service.d/reviewboards-sites.conf I only discovered this file because there was an error in /var/log/messages regarding the line type=oneshot (which should be *T*ype=oneshot). After correcting the spelling, I no longer see the error, but I cannot start httpd either. I have moved this file out of the way, and my ReviewBoard installation is now working, at least to the point of bringing up the interface and allowing me to login as admin. But I'm wondering what the repercussions of removing the systemd file might be. I'll field this one, since this bit is unique to my packages. The purpose of that oneshot target is to guarantee that the Review Board automatically runs 'rb-site upgrade' for all sites when it is started up (thus guaranteeing that if you perform an RPM upgrade, it will upgrade Review Board the next time it is started. I'm curious why it's hanging during the upgrade step, though. Can you check the journal for what's happening when you see that? The command 'journalctl -e -u httpd.service' should give you the output. It's possible that there's a bug in the upgrade routine. Have you checked for SELinux denials? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Resetting open issue counters
Do you happen to have a database backup prior to the upgrade? I'd love to try with a real before/after. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 22, 2014 at 4:15:20 PM, Christian Hammond (christ...@beanbaginc.com) wrote: Hi Alexey, That's something we can get in. As for the manage command, it's just an oversight. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 22, 2014 at 3:09:41 PM, Alexey Neyman (alexey.ney...@gmail.com) wrote: Christian, Meanwhile, is it possible to have a rb-site manage subcommand to recalculate these counters? Thanks, Alexey. On Sep 22, 2014 2:00 PM, Christian Hammond wrote: I would love a repro case for this. I've seen a couple of reports, and have tried desperately to reproduce it, with no luck. The code is fairly straightforward in how it counts the initial values. Christian On Monday, September 22, 2014, Stephen Gallagher step...@gallagherhome.com wrote: On 09/22/2014 04:30 PM, Alexey Neyman wrote: Hi all, We have just upgraded our installation of RB to 2.0.7. One nice new feature is that the dashboard now displays the number of open issues in a review request. However, I have noticed that the counters don't seem to be accurate in some request. For example, one of the review requests has 4 reviews with ship-its, with 2 of them making a comment on the code which were not marked as issues. Yet, the status displayed in the dashboard is 1 open issue. I verified this in admin/database/review requests, and this review request is indeed recorded as having ship-it count: 4 and open issue count: 1. I've hit the same bug on one of my deployments, but I haven't been able to reproduce it yet. I am not sure if this was a 1.7 bug, or if it was caused by the upgrade - the request and some of the reviews were submitted before the RB upgrade. However, I am not sure if the rest of the counters are valid - going through all the requests and verifying them manually is obviously a lot of work. So, is there a way to make RB recalculate these counters - like it was with the dashboard counters and the rb-site manage /path/to/site fixreviewcounts command? As a side note, it seems that the 'rb-site --help' message does not mention the 'manage' command at all. Is it intentional or an oversight? Regards, Alexey. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com . For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to a topic in the Google Groups reviewboard group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/LKmrIXZGuDI/unsubscribe. To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to
Re: Resetting open issue counters
Oh, regarding the fix the counts script, I can write one, but it's very unlikely to matter, I realized. It's just going to trigger the exact same logic that's triggered when viewing the review request for the first time, post-upgrade. If it got it wrong before, I don't have much reason to believe it'll get it right the next time. I'll have to fix the bug properly. For that, I'll probably need a before/after or a solid repro case. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 4:21:23 PM, Christian Hammond (christ...@beanbaginc.com) wrote: Do you happen to have a database backup prior to the upgrade? I'd love to try with a real before/after. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 22, 2014 at 4:15:20 PM, Christian Hammond (christ...@beanbaginc.com) wrote: Hi Alexey, That's something we can get in. As for the manage command, it's just an oversight. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 22, 2014 at 3:09:41 PM, Alexey Neyman (alexey.ney...@gmail.com) wrote: Christian, Meanwhile, is it possible to have a rb-site manage subcommand to recalculate these counters? Thanks, Alexey. On Sep 22, 2014 2:00 PM, Christian Hammond wrote: I would love a repro case for this. I've seen a couple of reports, and have tried desperately to reproduce it, with no luck. The code is fairly straightforward in how it counts the initial values. Christian On Monday, September 22, 2014, Stephen Gallagher step...@gallagherhome.com wrote: On 09/22/2014 04:30 PM, Alexey Neyman wrote: Hi all, We have just upgraded our installation of RB to 2.0.7. One nice new feature is that the dashboard now displays the number of open issues in a review request. However, I have noticed that the counters don't seem to be accurate in some request. For example, one of the review requests has 4 reviews with ship-its, with 2 of them making a comment on the code which were not marked as issues. Yet, the status displayed in the dashboard is 1 open issue. I verified this in admin/database/review requests, and this review request is indeed recorded as having ship-it count: 4 and open issue count: 1. I've hit the same bug on one of my deployments, but I haven't been able to reproduce it yet. I am not sure if this was a 1.7 bug, or if it was caused by the upgrade - the request and some of the reviews were submitted before the RB upgrade. However, I am not sure if the rest of the counters are valid - going through all the requests and verifying them manually is obviously a lot of work. So, is there a way to make RB recalculate these counters - like it was with the dashboard counters and the rb-site manage /path/to/site fixreviewcounts command? As a side note, it seems that the 'rb-site --help' message does not mention the 'manage' command at all. Is it intentional or an oversight? Regards, Alexey. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com . For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Hi Sara, David has a repro case for this now, so we're looking into a fix. There will be a 2.0.8 release tonight. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 3:17:04 PM, Christian Hammond (christ...@beanbaginc.com) wrote: Hi Sara, Something that would really help is a complete dump of the request/responses (headers and payloads) for any requests to /api/* in the Network tab of Firefox when these issues occur. I know some information was sent before, but those look to be the Console tab only. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 2:23:34 PM, Christian Hammond (christ...@beanbaginc.com) wrote: I wish I knew too... So, for each of these cases, is the only visible error the rsp is null error? This is tricky to diagnose without more direct access to the server. Hoping something will allow me to repro it here. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 1:43:11 PM, Sara Rayburn (sararayb...@gmail.com) wrote: I wish I knew what this was. We've had three developers run into this bug today alone. It's becoming a real problem for us. More answers to your questions inline below. Sara On Tuesday, September 23, 2014 2:08:28 PM UTC-5, Christian Hammond wrote: Hi Sara, On September 23, 2014 at 11:39:53 AM, Sara Rayburn (sarar...@gmail.com ) wrote: On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the bug since updating to 2.0.7. I know this because we have a request with non-unicode contents that was uploaded before I updated, without problems. Trying to reuse the same patch for an additional review request triggered the same unicode error we saw previously. On September 9th, you posted saying I am having a similar problem after upgrading to 2.0.6. We didn't have a 2.0.7 release until the 15th. Good point. I guess it's a problem since before that. 1) Is this still only happening with Firefox? Yes 2) What version of Firefox? 30 Does 33 work? I haven't had any issues with any recent version... Tried in most recent Firefox (35), issue remains. 4) If MySQL, are the tables set for Unicode? The tables are a mix of latin1 and utf8. Perhaps this is the problem? This is likely to be the cause of at least some of your problems. You'll need to make sure they're all in utf8, otherwise there will be issues even populating the database with non-latin1 text. This can break us in numerous ways. I made sure the database encodings were utf8 and even set the encoding for the repository in question to utf8 in the admin repo settings for reviewboard. I added utf8 as the charset in settings_local.py. All of these changes later, I still have the problem. 5) Are you using any form of proxy server at your company? No. Very vanilla setup on a VM. How about HTTP proxies that the users configure in their browsers? We've seen cases in the past of some proxies messing with the responses from our API. Nope, no one. Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn (sarar...@gmail.com ) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we updated, and when someone tried to change the submitter on the request it seems to have run into the error again. When the same user copied the patch and created a new review request (since they couldn't take ownership of the request) they ran into the unicode bug again. On Tuesday, September 23, 2014 12:51:51 PM UTC-5, Sara Rayburn wrote: Any new information on
Re: httpd remains in 'starting' state when starting via systemctl
On Tuesday, September 23, 2014 7:10:51 PM UTC-4, Stephen Gallagher wrote:
On 09/23/2014 03:38 PM, David Carson wrote:
After following all directions for installing ReviewBoard 2.0 on CentOS
7, I am still seeing one error that bothers me. When I try to restart
httpd, it remains in *'starting'* state and will never go to *'active
(running)'* state. However, if I remove the following file, httpd
starts and stops properly.
/usr/lib/systemd/system/httpd.service.d/reviewboards-sites.conf
I only discovered this file because there was an error in
/var/log/messages regarding the line type=oneshot (which should be
*T*ype=oneshot). After correcting the spelling, I no longer see the
error, but I cannot start httpd either.
I have moved this file out of the way, and my ReviewBoard installation
is now working, at least to the point of bringing up the interface and
allowing me to login as admin. But I'm wondering what the repercussions
of removing the systemd file might be.
I'll field this one, since this bit is unique to my packages. The
purpose of that oneshot target is to guarantee that the Review Board
automatically runs 'rb-site upgrade' for all sites when it is started up
(thus guaranteeing that if you perform an RPM upgrade, it will upgrade
Review Board the next time it is started.
I'm curious why it's hanging during the upgrade step, though. Can you
check the journal for what's happening when you see that?
The command 'journalctl -e -u httpd.service' should give you the output.
It's possible that there's a bug in the upgrade routine. Have you
checked for SELinux denials?
Stephen,
This is an internal-only server, so I turned off SELinux before doing
anything else (and rebooted, of course).
The journalctl command seems to indicate that the update finished:
-- Logs begin at Tue 2014-09-23 18:56:22 EDT, end at Tue 2014-09-23
19:50:32 EDT. --
:
:
Sep 23 19:50:13 pinehurst.e.com systemd[1]: Stopping The Apache HTTP
Server...
Sep 23 19:50:14 pinehurst.e.com systemd[1]: Starting The Apache HTTP
Server...
Sep 23 19:50:14 pinehurst.e.com systemd[1]: Started The Apache HTTP Server.
Sep 23 19:50:27 pinehurst.e.com systemd[1]: Stopping The Apache HTTP
Server...
Sep 23 19:50:28 pinehurst.e.com systemd[1]: Starting The Apache HTTP
Server...
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Rebuilding directory
structure
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Updating database. This may
take a while.
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: The log output below,
including warnings and errors,
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: can be ignored unless
upgrade fails.
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: -- begin
log output --
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Creating tables ...
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Installing custom SQL ...
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Installing indexes ...
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Installed 0 object(s) from 0
fixture(s)
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: No evolution required.
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: --- end log
output ---
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Resetting in-database caches.
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: *Upgrade complete!*
But the systemctl command itself is sitting there, not returning to the
command prompt, and the status shows that it is still activating, but never
activated:
(0)[root@pinehurst ~] systemctl status httpd.service
httpd.service - The Apache HTTP Server
Loaded: loaded (/usr/lib/systemd/system/httpd.service; enabled)
Drop-In: /usr/lib/systemd/system/httpd.service.d
└─reviewboard-sites.conf
*Active: activating (start) *since Tue 2014-09-23 19:50:28 EDT; 11min ago
Process: 3223 ExecStop=/bin/kill -WINCH ${MAINPID} (code=exited,
status=0/SUCCESS)
Process: 3228 ExecStartPre=/usr/bin/rb-site upgrade --all-sites
(code=exited, status=0/SUCCESS)
Main PID: 3235 (httpd)
Status: Total requests: 0; Current requests/sec: 0; Current traffic: 0
B/sec
CGroup: /system.slice/httpd.service
├─3235 /usr/sbin/httpd -DFOREGROUND
├─3237 /usr/sbin/httpd -DFOREGROUND
├─3238 /usr/sbin/httpd -DFOREGROUND
├─3239 /usr/sbin/httpd -DFOREGROUND
├─3240 /usr/sbin/httpd -DFOREGROUND
├─3241 /usr/sbin/httpd -DFOREGROUND
└─3242 /usr/sbin/httpd -DFOREGROUND
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Rebuilding directory
structure
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: Updating database. This may
take a while.
Sep 23 19:50:32 pinehurst.e.com rb-site[3228]: The log output below,
including warnings and errors,
:
:
:
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message
Re: Using complex filters in the Custom LDAP User Search Filter
On 09/23/2014 08:22 PM, Bruce Cran wrote: Should it be possible to use a more complex filter in the Custom LDAP User Search Filter field? For example I'd like to restrict access to a single AD/LDAP group, so I tried something like: ((accountusername=%s)(memberOf=CN=agroup,CN=Users,DC=corp,DC=domain,DC=com)) However, I couldn't get it to work: reviewboard.log reported that it couldn't contact the LDAP server, which is odd because just changing the filter field fixed it. I'm not sure why you got the contact error, but I should warn you that the filter you're trying to use there won't really work (or at least, not the way you think it will). Active Directory's memberOf attribute only handles direct memberships, not indirect ones. So a user who is a member of group A which is a member of group B will not have memberOf(group B) in their attributes, even though the nested group membership should have it. For stuff like that, you need to start playing around with the tokenGroups attribute, but I'm not even going to pretend to be willing to try to explain that one. Check Microsoft documentation. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 What version are you running? 2.0.7 What's the URL of the page containing the problem? http://server/r/new/ What steps will reproduce the problem? 1.Create a patch file that contains a new file been created with utf-8 encoding that contains a BOM in the file, or contains any modification related with the first line of a file that has BOM 2.Upload the patch to the reviewboard What is the expected output? What do you see instead? Expected: Review can be created Actual: Reviewboard always showing loading but never finish. What operating system are you using? What browser? Win 8.1, tried IE9/Firefox 32.0.2/Chrome 37.0.2062.120 m Please provide any additional information below. If we manually remove the BOM from the patch file a review can be created with no problem. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #1 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Are there any errors in the server's log file? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Updates: Status: NeedInfo Comment #2 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Also, what repository type? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #3 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 repository type is svn I can see an error report Email sent from server: Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/Django-1.6.7-py2.7.egg/django/core/handlers/base.py, line 112, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.7/dist-packages/Django-1.6.7-py2.7.egg/django/views/decorators/cache.py, line 52, in _wrapped_view_func response = view_func(request, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Django-1.6.7-py2.7.egg/django/views/decorators/vary.py, line 19, in inner_func response = func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/resources.py, line 495, in __call__ request, method, view, api_format=api_format, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/resources.py, line 566, in call_method_view return view(request, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/webapi/decorators.py, line 110, in _check return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/webapi/decorators.py, line 33, in _check return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 287, in _validate return view_func(*args, **new_kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/webapi/resources/repository_commits.py, line 86, in get items = repository.get_commits(branch=branch, start=start) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/scmtools/models.py, line 366, in get_commits cache_period) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/cache/backend.py, line 120, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/scmtools/models.py, line 351, in lambda lambda: self.get_scmtool().get_commits(**commits_kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/scmtools/svn/__init__.py, line 195, in get_commits commit['message'])) File /usr/lib/python2.7/UserDict.py, line 23, in __getitem__ raise KeyError(key) KeyError: u'message' -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #4 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Double checked the error in the log is the same as I got from Email, no further message can be seen -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #5 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 OK, that's definitely something we'll get fixed, but I'm not sure it's causing your problem. Can you look in the browser's Network console while uploading the file and check the request/reponses there for errors? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #6 on issue 3579 by simonwa...@gmail.com: patch file contains BOM
can't be uploaded
https://code.google.com/p/reviewboard/issues/detail?id=3579
Looks like a Javscript error:
TypeError: rsp is null
in http://servername/static/rb/js/newReviewRequest.min.4427138a3b1f.js
Code is where it try to parse error code:
switch(rsp.err.code) {
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #7 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Can you look in the network tab of the browser tools to find the response that's creating that error? It's probably a 500. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #8 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Sorry I didn't mention it clear here, I can see no network traffic at all after I click OK, it looks JS crashed before that. I tried using both Firebug and Fiddler. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #10 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 And/or any POSTS to validate-diff/ or diffs/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #11 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Sorry no 500 error, there are some others after I chose Repository but all 200 normal request which I also believed is for Post-Commit review as the result is a revision history. Only thing after that is the JS error, nothing else -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #12 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Can you show me the responses to any POSTs (successful or not) to /api/validation/diffs/ or /api/review-requests/XX/diffs/? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #13 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Sorry in this failed case there is no post to /api/validation/diffs/ or /api/review-requests/XX/diffs/ at all. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #14 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 OK, I have a reproduction case. We'll get this fixed for 2.0.8, which should come out today. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Updates: Status: Fixed Comment #15 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Fixed in release-2.0.x (e7e671a). Thanks for all your help! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #16 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Thank you for your quick fix, looking forward to the upgrade. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3580 in reviewboard: IssueOpened checkbox status is not loaded correctly when opening that comment dialog the 1st time after page loading
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3580 by oswi...@gmail.com: IssueOpened checkbox status is not loaded correctly when opening that comment dialog the 1st time after page loading https://code.google.com/p/reviewboard/issues/detail?id=3580 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? 2.1 alpha 0 (dev) What's the URL of the page containing the problem? http://demo.reviewboard.org/r/13/diff/ What steps will reproduce the problem? 1. In the View Diff page, click one line in diff content to open one comment dialog 2. Create one comment WITHOUT issue opened 3. Reload that view diff page 4. Click the flag of that comment we just created, you could see the IssueOpened checkbox is checked in the dialog 5. Close the dialog and reopen it again 6. This time the checked status is OK What is the expected output? What do you see instead? It should be unchecked for such comment What operating system are you using? What browser? winxp,rh6. firefox 32 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
