Re: RB default reviewer group not getting updated

[manoj m]

Hello,

Is there a way to enable the "Default Reviewer" hook irrespective of review 
request state?

We don't use RB for any sensitive patches.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RB default reviewer group not getting updated

[manoj]

Makes sense, thanks for the quick reply.

On Thu, 25 Oct 2018 at 16:45, Christian Hammond 
wrote:

> Hi,
>
> This is expected. They only take effect for the initial review request.
> The idea is to prevent overriding the list of targeted reviewers, or to
> re-add someone who was removed, based on a re-run of the algorithm.
> Consider for instance an important confidential security fix that may
> initially trigger a Default Reviewer rule adding some people or groups to
> the list, but the owner of the review request erases them all and assigns
> it instead to a private "security" group. You wouldn't want anyone re-added
> if you were to update your change, for security disclosure reasons.
> Instead, once the review request is published, those fields are meant to be
> your responsibility to update.
>
> Christian
>
> On Thu, Oct 25, 2018 at 3:16 PM manoj m  wrote:
>
>> Hello,
>>
>> If an user uploads a new diff to an already published review request the
>> default groups doesn't get updated. Is this expected?
>>
>> On the contrary, an unpublished review requests gets updated properly.
>>
>> Thanks
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
> --
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "Review Board Community" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/reviewboard/vJATbjRVfJQ/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
--Manoj Kumar M

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RB default reviewer group not getting updated

[Christian Hammond]

Hi,

This is expected. They only take effect for the initial review request. The
idea is to prevent overriding the list of targeted reviewers, or to re-add
someone who was removed, based on a re-run of the algorithm. Consider for
instance an important confidential security fix that may initially trigger
a Default Reviewer rule adding some people or groups to the list, but the
owner of the review request erases them all and assigns it instead to a
private "security" group. You wouldn't want anyone re-added if you were to
update your change, for security disclosure reasons. Instead, once the
review request is published, those fields are meant to be your
responsibility to update.

Christian

On Thu, Oct 25, 2018 at 3:16 PM manoj m  wrote:

> Hello,
>
> If an user uploads a new diff to an already published review request the
> default groups doesn't get updated. Is this expected?
>
> On the contrary, an unpublished review requests gets updated properly.
>
> Thanks
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RB default reviewer group not getting updated

[manoj m]

Hello,

If an user uploads a new diff to an already published review request the 
default groups doesn't get updated. Is this expected?

On the contrary, an unpublished review requests gets updated properly.

Thanks

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[Shooter Gravatar]

I just tried to point to the root of the repo, it doesn't solve the issue : 
refault reviewer is applied when i upload a .diff file, but it doesn't when 
i use the UI to browse commits.

Le mercredi 18 janvier 2017 10:18:39 UTC+1, Shooter Gravatar a écrit :
>
> I'll see what i can do with the repo path.
>
> For the diff, see the attached file.
>
> Le mercredi 18 janvier 2017 01:02:06 UTC+1, Christian Hammond a écrit :
>>
>> If it's a new install and database, definitely point it to the root of 
>> the repo. This will prevent other kinds of problems.
>>
>> For the sample file paths, I need to see exact paths being shown in the 
>> diff viewer. Those are what the Default Reviewer regents will match 
>> against. I suspect the refex isn't formatted for those paths.
>>
>> Christian
>>
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[Shooter Gravatar]

I'll see what i can do with the repo path.

For the diff, see the attached file.

Le mercredi 18 janvier 2017 01:02:06 UTC+1, Christian Hammond a écrit :
>
> If it's a new install and database, definitely point it to the root of the 
> repo. This will prevent other kinds of problems.
>
> For the sample file paths, I need to see exact paths being shown in the 
> diff viewer. Those are what the Default Reviewer regents will match 
> against. I suspect the refex isn't formatted for those paths.
>
> Christian
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[Shooter Gravatar]

The repo contains a lot of branches and "stuff" that we don't want to 
survey (and we don't want to make things to complicated for our users 
ho well...), so the repo path points directly to the "trunk" of our 
development.
Too much history and not enough forward thinking at the time...
Existing review requests are not a problem, this new instance of RB will 
start from scratch.

Matching files can be :
  - main.cpp
  - index.html
  - js/service.js (in a sub-directory)

Le lundi 16 janvier 2017 11:31:45 UTC+1, Christian Hammond a écrit :
>
> The repository path should be pointing to the root of the repository 
> (probably /svn), rather than a subdirectory (/svn/trunk), but if you 
> already have a bunch of review requests in there, you probably have to keep 
> it as-is.
>
> Can you show me an example filename listed in the diff viewer that should 
> be matching?
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[Christian Hammond]

The repository path should be pointing to the root of the repository
(probably /svn), rather than a subdirectory (/svn/trunk), but if you
already have a bunch of review requests in there, you probably have to keep
it as-is.

Can you show me an example filename listed in the diff viewer that should
be matching?

Christian

-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

On Mon, Jan 16, 2017 at 2:29 AM, Shooter Gravatar <
shooter.grava...@gmail.com> wrote:

> Good news !
>
> As for the default reviewer, the expression is the following :
>
>> Base/Tools/Nora2/.*
>>
>
> The repo is :
>
>> https://x.x.x.x/svn/trunk
>>
>
> The commited files are located in :
>
>> myDrive:\_BaseSVN\Trunk\Base\Tools\Nora2  (on Windows...)
>>
>
> Le samedi 14 janvier 2017 23:56:15 UTC+1, Christian Hammond a écrit :
>>
>> I believe I have a fix we can put in for the upcoming Review Board 2.5.8
>> release for the warning.
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag <https://www.beanbaginc.com/>
>> Makers of Review Board <https://www.reviewboard.org/>
>>
>> On Sat, Jan 14, 2017 at 2:29 PM, Christian Hammond <
>> chri...@beanbaginc.com> wrote:
>>
>>> I've seen this. This is a behavioral quirk in MySQL.
>>>
>>> Basically, this is likely a longblob, but some versions of MySQL assume
>>> the incoming content should be Unicode text and does validation on that.
>>> The validation fails, and you get the warning you have above:
>>>
>>> /usr/local/lib/python2.7/dist-packages/django/db/backends/mysql/base.py:129:
>>>  Warning: Invalid utf8 character string: 'AAF744'
>>>   return self.cursor.execute(query, args)
>>>
>>>
>>> Another user hit this with MySQL 5.5. Upgrading to 5.6 solved this for
>>> him, but you're on 5.7, so I guess this wasn't "fixed."
>>>
>>> There is a proper fix that Django's put in place, based on the
>>> recommendations of the MySQL developers. However, we're not able to use
>>> that newer version of Django... Been meaning to see if we can monkey-patch
>>> the fix in.
>>>
>>> This is MySQL warning code 1300. You can see some discussion about this
>>> here: https://bugs.mysql.com/bug.php?id=79317
>>>
>>> Now, if you don't enable DEBUG = True in settings_local.py, then this
>>> warning is harmless. So I suspect your Default Reviewer issue is a
>>> configuration issue.
>>>
>>> Can you show me what your Default Reviewer configuration looks like?
>>>
>>> Christian
>>>
>>>
>>> --
>>> Christian Hammond
>>> President/CEO of Beanbag <https://www.beanbaginc.com/>
>>> Makers of Review Board <https://www.reviewboard.org/>
>>>
>>> On Fri, Jan 13, 2017 at 11:59 AM, David Trowbridge <trow...@gmail.com>
>>> wrote:
>>>
>>>> Something is super weird with your database schema. The "binary" field
>>>> of that table should be a longblob, not text (and therefore shouldn't care
>>>> at all about encodings one way or another). Can you pull out the schema and
>>>> send it here?
>>>>
>>>> -David
>>>>
>>>> On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar <shooter@gmail.com>
>>>> wrote:
>>>>
>>>>> Another update.
>>>>>
>>>>> I completely remove ReviewBoard 2.5.7 from my system and downloaded
>>>>> again 2.5.6.1 with easy_install.
>>>>> Run the installation again.
>>>>> Same configuration as before.
>>>>> I can now create a review request from the UI by browsing the commits
>>>>> on my repo, and the default reviewer rule is applied (the group is 
>>>>> assigned
>>>>> to the request i just created).
>>>>> But i still have the utf8 error on the database.
>>>>>
>>>>> I now have another problem : i cannot acces the
>>>>> /reviewboard/admin/settings/general/ page on the Admin dashboard.
>>>>>
>>>>>
>>>>> Traceback (most recent call last):
>>>>>>
>>>>>>
>>>>>>
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py",
>>>>>> line 112, in get_respon

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[Shooter Gravatar]

Good news !

As for the default reviewer, the expression is the following : 

> Base/Tools/Nora2/.*
>

The repo is : 

> https://x.x.x.x/svn/trunk 
>

The commited files are located in :

> myDrive:\_BaseSVN\Trunk\Base\Tools\Nora2  (on Windows...)
>

Le samedi 14 janvier 2017 23:56:15 UTC+1, Christian Hammond a écrit :
>
> I believe I have a fix we can put in for the upcoming Review Board 2.5.8 
> release for the warning.
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> On Sat, Jan 14, 2017 at 2:29 PM, Christian Hammond <chri...@beanbaginc.com 
> > wrote:
>
>> I've seen this. This is a behavioral quirk in MySQL.
>>
>> Basically, this is likely a longblob, but some versions of MySQL assume 
>> the incoming content should be Unicode text and does validation on that. 
>> The validation fails, and you get the warning you have above:
>>
>> /usr/local/lib/python2.7/dist-packages/django/db/backends/mysql/base.py:129: 
>> Warning: Invalid utf8 character string: 'AAF744'
>>   return self.cursor.execute(query, args)
>>
>>
>> Another user hit this with MySQL 5.5. Upgrading to 5.6 solved this for 
>> him, but you're on 5.7, so I guess this wasn't "fixed."
>>
>> There is a proper fix that Django's put in place, based on the 
>> recommendations of the MySQL developers. However, we're not able to use 
>> that newer version of Django... Been meaning to see if we can monkey-patch 
>> the fix in.
>>
>> This is MySQL warning code 1300. You can see some discussion about this 
>> here: https://bugs.mysql.com/bug.php?id=79317
>>
>> Now, if you don't enable DEBUG = True in settings_local.py, then this 
>> warning is harmless. So I suspect your Default Reviewer issue is a 
>> configuration issue.
>>
>> Can you show me what your Default Reviewer configuration looks like?
>>
>> Christian
>>
>>
>> -- 
>> Christian Hammond
>> President/CEO of Beanbag <https://www.beanbaginc.com/>
>> Makers of Review Board <https://www.reviewboard.org/>
>>
>> On Fri, Jan 13, 2017 at 11:59 AM, David Trowbridge <trow...@gmail.com 
>> > wrote:
>>
>>> Something is super weird with your database schema. The "binary" field 
>>> of that table should be a longblob, not text (and therefore shouldn't care 
>>> at all about encodings one way or another). Can you pull out the schema and 
>>> send it here?
>>>
>>> -David
>>>
>>> On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar <shooter@gmail.com 
>>> > wrote:
>>>
>>>> Another update.
>>>>
>>>> I completely remove ReviewBoard 2.5.7 from my system and downloaded 
>>>> again 2.5.6.1 with easy_install.
>>>> Run the installation again.
>>>> Same configuration as before.
>>>> I can now create a review request from the UI by browsing the commits 
>>>> on my repo, and the default reviewer rule is applied (the group is 
>>>> assigned 
>>>> to the request i just created).
>>>> But i still have the utf8 error on the database.
>>>>
>>>> I now have another problem : i cannot acces the 
>>>> /reviewboard/admin/settings/general/ page on the Admin dashboard.
>>>>
>>>>
>>>> Traceback (most recent call last):
>>>>>
>>>>>  
>>>>>
>>>>>   File 
>>>>> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", 
>>>>> line 
>>>>> 112, in get_response
>>>>>
>>>>> response = wrapped_callback(request, *callback_args, 
>>>>> **callback_kwargs)
>>>>>
>>>>>  
>>>>>
>>>>>   File 
>>>>> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line 
>>>>> 99, in _wrapped_view
>>>>>
>>>>> response = view_func(request, *args, **kwargs)
>>>>>
>>>>>  
>>>>>
>>>>>   File 
>>>>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>>>>>  
>>>>> line 17, in _checklogin
>>>>>
>>>>> return view_func(request, *args, **kwargs)
>>>>>
>>>>>  
>>>>&

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[Christian Hammond]

I believe I have a fix we can put in for the upcoming Review Board 2.5.8
release for the warning.

Christian

-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

On Sat, Jan 14, 2017 at 2:29 PM, Christian Hammond <christ...@beanbaginc.com
> wrote:

> I've seen this. This is a behavioral quirk in MySQL.
>
> Basically, this is likely a longblob, but some versions of MySQL assume
> the incoming content should be Unicode text and does validation on that.
> The validation fails, and you get the warning you have above:
>
> /usr/local/lib/python2.7/dist-packages/django/db/backends/mysql/base.py:129: 
> Warning: Invalid utf8 character string: 'AAF744'
>   return self.cursor.execute(query, args)
>
>
> Another user hit this with MySQL 5.5. Upgrading to 5.6 solved this for
> him, but you're on 5.7, so I guess this wasn't "fixed."
>
> There is a proper fix that Django's put in place, based on the
> recommendations of the MySQL developers. However, we're not able to use
> that newer version of Django... Been meaning to see if we can monkey-patch
> the fix in.
>
> This is MySQL warning code 1300. You can see some discussion about this
> here: https://bugs.mysql.com/bug.php?id=79317
>
> Now, if you don't enable DEBUG = True in settings_local.py, then this
> warning is harmless. So I suspect your Default Reviewer issue is a
> configuration issue.
>
> Can you show me what your Default Reviewer configuration looks like?
>
> Christian
>
>
> --
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> On Fri, Jan 13, 2017 at 11:59 AM, David Trowbridge <trowb...@gmail.com>
> wrote:
>
>> Something is super weird with your database schema. The "binary" field of
>> that table should be a longblob, not text (and therefore shouldn't care at
>> all about encodings one way or another). Can you pull out the schema and
>> send it here?
>>
>> -David
>>
>> On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar <
>> shooter.grava...@gmail.com> wrote:
>>
>>> Another update.
>>>
>>> I completely remove ReviewBoard 2.5.7 from my system and downloaded
>>> again 2.5.6.1 with easy_install.
>>> Run the installation again.
>>> Same configuration as before.
>>> I can now create a review request from the UI by browsing the commits on
>>> my repo, and the default reviewer rule is applied (the group is assigned to
>>> the request i just created).
>>> But i still have the utf8 error on the database.
>>>
>>> I now have another problem : i cannot acces the
>>> /reviewboard/admin/settings/general/ page on the Admin dashboard.
>>>
>>>
>>> Traceback (most recent call last):
>>>
>>>
>>>
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py",
>>> line 112, in get_response
>>>
>>> response = wrapped_callback(request, *callback_args,
>>> **callback_kwargs)
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>>> line 99, in _wrapped_view
>>>
>>> response = view_func(request, *args, **kwargs)
>>>
>>>
>>>
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>>> line 17, in _checklogin
>>>
>>> return view_func(request, *args, **kwargs)
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.6.1-
>>> py2.7.egg/reviewboard/admin/views.py", line 138, in site_settings
>>>
>>> 'root_path': settings.SITE_ROOT + "admin/db/"
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>>> line 99, in _wrapped_view
>>>
>>> response = view_func(request, *args, **kwargs)
>>>
>>>
>>>
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>>> line 17, in _checklogin
>>>
>>> return view_func(request, *args, **kwargs)
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/djblets/siteconfig/views.py",
>>> line 63, in site_settings
>>>
>>> return render_to_

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[Christian Hammond]

I've seen this. This is a behavioral quirk in MySQL.

Basically, this is likely a longblob, but some versions of MySQL assume the
incoming content should be Unicode text and does validation on that. The
validation fails, and you get the warning you have above:

/usr/local/lib/python2.7/dist-packages/django/db/backends/mysql/base.py:129:
Warning: Invalid utf8 character string: 'AAF744'
  return self.cursor.execute(query, args)


Another user hit this with MySQL 5.5. Upgrading to 5.6 solved this for him,
but you're on 5.7, so I guess this wasn't "fixed."

There is a proper fix that Django's put in place, based on the
recommendations of the MySQL developers. However, we're not able to use
that newer version of Django... Been meaning to see if we can monkey-patch
the fix in.

This is MySQL warning code 1300. You can see some discussion about this
here: https://bugs.mysql.com/bug.php?id=79317

Now, if you don't enable DEBUG = True in settings_local.py, then this
warning is harmless. So I suspect your Default Reviewer issue is a
configuration issue.

Can you show me what your Default Reviewer configuration looks like?

Christian


-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

On Fri, Jan 13, 2017 at 11:59 AM, David Trowbridge <trowb...@gmail.com>
wrote:

> Something is super weird with your database schema. The "binary" field of
> that table should be a longblob, not text (and therefore shouldn't care at
> all about encodings one way or another). Can you pull out the schema and
> send it here?
>
> -David
>
> On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar <
> shooter.grava...@gmail.com> wrote:
>
>> Another update.
>>
>> I completely remove ReviewBoard 2.5.7 from my system and downloaded again
>> 2.5.6.1 with easy_install.
>> Run the installation again.
>> Same configuration as before.
>> I can now create a review request from the UI by browsing the commits on
>> my repo, and the default reviewer rule is applied (the group is assigned to
>> the request i just created).
>> But i still have the utf8 error on the database.
>>
>> I now have another problem : i cannot acces the
>> /reviewboard/admin/settings/general/ page on the Admin dashboard.
>>
>>
>> Traceback (most recent call last):
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py",
>> line 112, in get_response
>>
>> response = wrapped_callback(request, *callback_args,
>> **callback_kwargs)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>> line 99, in _wrapped_view
>>
>> response = view_func(request, *args, **kwargs)
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>> line 17, in _checklogin
>>
>> return view_func(request, *args, **kwargs)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
>> 6.1-py2.7.egg/reviewboard/admin/views.py", line 138, in site_settings
>>
>> 'root_path': settings.SITE_ROOT + "admin/db/"
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>> line 99, in _wrapped_view
>>
>> response = view_func(request, *args, **kwargs)
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>> line 17, in _checklogin
>>
>> return view_func(request, *args, **kwargs)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/djblets/siteconfig/views.py",
>> line 63, in site_settings
>>
>> return render_to_response(template_name, RequestContext(request,
>> context))
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py",
>> line 29, in render_to_response
>>
>> return HttpResponse(loader.render_to_string(*args, **kwargs),
>> **httpresponse_kwargs)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py",
>> line 164, in render_to_string
>>
>> return t.render(Context(dictionary))
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
>> line 140, in render
>>
>> return self._render(context)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/djan

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[David Trowbridge]

Something is super weird with your database schema. The "binary" field of
that table should be a longblob, not text (and therefore shouldn't care at
all about encodings one way or another). Can you pull out the schema and
send it here?

-David

On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar <shooter.grava...@gmail.com>
wrote:

> Another update.
>
> I completely remove ReviewBoard 2.5.7 from my system and downloaded again
> 2.5.6.1 with easy_install.
> Run the installation again.
> Same configuration as before.
> I can now create a review request from the UI by browsing the commits on
> my repo, and the default reviewer rule is applied (the group is assigned to
> the request i just created).
> But i still have the utf8 error on the database.
>
> I now have another problem : i cannot acces the
> /reviewboard/admin/settings/general/ page on the Admin dashboard.
>
>
> Traceback (most recent call last):
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line
> 112, in get_response
>
> response = wrapped_callback(request, *callback_args,
> **callback_kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/admin/views.py",
> line 138, in site_settings
>
> 'root_path': settings.SITE_ROOT + "admin/db/"
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/djblets/siteconfig/views.py", line
> 63, in site_settings
>
> return render_to_response(template_name, RequestContext(request,
> context))
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py", line
> 29, in render_to_response
>
> return HttpResponse(loader.render_to_string(*args, **kwargs),
> **httpresponse_kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/template/loader.py", line
> 164, in render_to_string
>
> return t.render(Context(dictionary))
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 140, in render
>
> return self._render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 134, in _render
>
> return self.nodelist.render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 840, in render
>
> bit = self.render_node(node, context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 854, in render_node
>
> return node.render(context)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py",
> line 123, in render
>
> return compiled_parent._render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 134, in _render
>
> return self.nodelist.render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 840, in render
>
> bit = self.render_node(node, context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 854, in render_node
>
> return node.render(context)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py",
> line 123, in render
>
> return compiled_parent._render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 134, in _render
>
> return self.nodelist.render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 840, in render
>
> bit = self.render_node(node, context)
>
>
>
>   File "/usr/

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[Shooter Gravatar]

Another update.

I completely remove ReviewBoard 2.5.7 from my system and downloaded again 
2.5.6.1 with easy_install.
Run the installation again.
Same configuration as before.
I can now create a review request from the UI by browsing the commits on my 
repo, and the default reviewer rule is applied (the group is assigned to 
the request i just created).
But i still have the utf8 error on the database.

I now have another problem : i cannot acces the 
/reviewboard/admin/settings/general/ page on the Admin dashboard.


Traceback (most recent call last):
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 
> 112, in get_response
>
> response = wrapped_callback(request, *callback_args, 
> **callback_kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line 
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>  
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/admin/views.py",
>  
> line 138, in site_settings
>
> 'root_path': settings.SITE_ROOT + "admin/db/"
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line 
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>  
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/djblets/siteconfig/views.py", line 
> 63, in site_settings
>
> return render_to_response(template_name, RequestContext(request, 
> context))
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py", line 
> 29, in render_to_response
>
> return HttpResponse(loader.render_to_string(*args, **kwargs), 
> **httpresponse_kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/template/loader.py", line 
> 164, in render_to_string
>
> return t.render(Context(dictionary))
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 140, in render
>
> return self._render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 134, in _render
>
> return self.nodelist.render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 840, in render
>
> bit = self.render_node(node, context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 854, in render_node
>
> return node.render(context)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py", 
> line 123, in render
>
> return compiled_parent._render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 134, in _render
>
> return self.nodelist.render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 840, in render
>
> bit = self.render_node(node, context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 854, in render_node
>
> return node.render(context)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py", 
> line 123, in render
>
> return compiled_parent._render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 134, in _render
>
> return self.nodelist.render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 840, in render
>
> bit = self.render_node(node, context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 854, in render_node
>
> return node.render(context)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py", 
> line 123, in render
>
> return compiled_parent._render

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

[Shooter Gravatar]

More info on this.

I started from scratch once again : deleted MySQL database, remove all 
reviewboard sites and start the rb-site install process again.

My site now has one repository, 2 users (the admin and me), one group 
(myGroup) and one default reviewer (assigns a specific path to myGroup).

If i upload a patch file to the UI from my hard drive, with files 
corresponding to my default reviewer rule, everything is fine, the group is 
assigned.

If i browse the commits from the "/reviewboard/r/new/" URL and create a new 
review request for the same commit as my patch, the default reviewer IS NOT 
assigned and i will see some utf-8 parsing error in the server log.

I did not have the problem on version 2.5.6.1

On a side note, since i downloaded version 2.5.7, i cannot install a 
previous revision on my system (the dashboard asks me to perform a rb-site 
update...).

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Default reviewer not assigned to the review (yet another weird utf8 problem)

[Shooter Gravatar]

Hi.

Fresh installation of RB 2.5.7 on Ubuntu 16.04 LTS with Mysql Ver 14.14 
Distrib 5.7.16.
Repository is SVN.

The instance of Review Board has 6 users, 5 groups and one default reviewer 
rule to assign a group for a specific set of files.

Default reviewer rule is:

Base/Tools/Nora2/.*
>

When i try to upload a patch from the UI or even if i click on the "new 
review request" in the UI, i get the following warning in the logs : 

/usr/local/lib/python2.7/dist-packages/django/db/backends/mysql/base.py:129: 
Warning: Invalid utf8 character string: 'AAF744'
>   return self.cursor.execute(query, args)
>
>
The review draft is created but the default reviewer rule is not applied.

A dump of the MySql database allowed me to find the utf8 sequence : 

30 QueryUPDATE `diffviewer_rawfilediffdata` SET `binary_hash` = 
> '73625aad13035d5f8d206b03cf319d80bee14554', `binary` = 
> 'BZh91AY*ª÷D*\Ô\0\0B߀\00poò÷\ï!\Ö 
> .w\Ý@0\0´Á*L£i ›S\Ô\r ƒjzA @ ªŸªf¦h SL蘌 \Ó =L Š†ôS& 4   @\0ôN8‚\r  
> bI \É,¬±À;\ìs\Ì \Äk§B#W‰ 0|M\"\Z\"Ÿh™ˆ•W ˜ò³ò 
> ¶5 ¾liCžHr#l··­j3… h¡ \åq  Rˆ\ÜbÁ1Ev[}¤e I 
> §‘Œ\ïôg µ \ì€\è¿<\Ê ø_E¸  ¬ \Zhв T*  P\×$ 
> ¦\nˆ\Úóɫƪö 0aB!?‹¹\"œ(HU{¢j\0', `compression` = 'B', `extra_data` = 
> '{\"insert_count\": 1, \"delete_count\": 1}' WHERE 
> `diffviewer_rawfilediffdata`.`id` = 198
>

I don't know if the two problems are related.

Patch is attached to the message.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Index: index.html
===
--- index.html	(revision 52509)
+++ index.html	(revision 52510)
@@ -1,7 +1,7 @@
 
 
   
-	N.O.R.A.2
+	N.O.R.A.
 	
 	
 	

Re: Default reviewer per group

[Christian Hammond]

Hi Moisei,

There's no support for per-user default reviewers in Review Board itself
(but see below). The rationale is that reviewers tend to pertain to changes
(one group might be appropriate for one repository/path, while another
might be appropriate to another), rather than a reviewer pertaining to the
owner of a review request. Specifying a default reviewer for every change
could lead to an inappropriate reviewer if posting a change that applies to
some other area of the company. (This of course dependent on the size and
structure of your server.)

However, you can set a default in your personal .reviewboardrc for RBTools.
I'm not at a computer, but I believe it's TARGET_GROUPS. This will be set
any time you post a change for review using rbt post.

Christian


On Wed, Dec 21, 2016 at 09:37 Moisei Rabinovich <moi...@gmail.com> wrote:

> Hello,
> Is there some way to specify a default reviewer group for the user (and
> not by the file path as it is mentioned inthe documentation)?
> Every time I submit a new issue, I choose my group to be  a Reviewer group
> and I would like it to happen automatically.
>
> Thank you!
>
>
>
>
>
>
>
>
>
>
> --
>
>
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
>
>
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
>
>
> Happy user? Let us know! https://www.reviewboard.org/users/
>
>
> ---
>
>
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
>
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
>
>
> For more options, visit https://groups.google.com/d/optout.
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Default reviewer per group

[Moisei Rabinovich]

Hello,
Is there some way to specify a default reviewer group for the user (and not 
by the file path as it is mentioned inthe documentation)?
Every time I submit a new issue, I choose my group to be  a Reviewer group 
and I would like it to happen automatically.

Thank you!


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: reviewboard 2.5.7 default reviewer do'nt work

[LeeJunlong]

*user:* lijl, zengzq
*review group:* appas, member: lijl, zengzq
*Repositories: *appas

default reviewer:
   * name:* appas
File regular expression: .*
Default groups: appas
*Repositories: *appas


在 2016年11月10日星期四 UTC+8上午2:24:29，David Trowbridge写道：
>
> Could you share the entire default reviewer configuration?
>
> -David
>
> On Tue, Nov 8, 2016 at 9:18 PM LeeJunlong <zhuizhu...@gmail.com 
> > wrote:
>
>> my svn url like this: svn://10.8.199.63:10223/appas
>>
>> when i add a new request with file regular express ".*", ， the default 
>> reviewer dont work
>>
>>
>> <https://lh3.googleusercontent.com/-gcyKDwAnXj0/WCKu63gj5XI/AG0/I4p1BFjsgac-r9fGtTgWaGXoS_m0HJHdQCLcB/s1600/regular.png>
>>
>>
>>
>> <https://lh3.googleusercontent.com/-jyKFoBeXpvY/WCKvda86cZI/AG4/NkfFf5BUe9sFHA0ws0EP-L6seLMtl-QogCLcB/s1600/diff.png>
>>
>>
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

reviewboard 2.5.7 default reviewer do'nt work

[LeeJunlong]

my svn url like this: svn://10.8.199.63:10223/appas

when i add a new request with file regular express ".*", ， the default 
reviewer dont work

<https://lh3.googleusercontent.com/-gcyKDwAnXj0/WCKu63gj5XI/AG0/I4p1BFjsgac-r9fGtTgWaGXoS_m0HJHdQCLcB/s1600/regular.png>


<https://lh3.googleusercontent.com/-jyKFoBeXpvY/WCKvda86cZI/AG4/NkfFf5BUe9sFHA0ws0EP-L6seLMtl-QogCLcB/s1600/diff.png>



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Default reviewer not working

[Dieter Odeurs]

Hello

I'm new to reviewboard and was experimenting with it. I want to test with 
default reviewers but i don't ge tit working.
My test situation:

3 SVN repo's: 

repo1

repo2

repo3

 
All of them are structured like 

 repo1

trunk

branch

tag


4user:

admin (admin)

me (admin)

reviewer1

reviewer2 

 

Now i want that for every review in the trunk of repo 1 admin would be the 
default reviewer.
Default review setting are:

name: defaultRepo1

regex: trunk/.*

default group: /

default user: admin


But when I add a new review request of the trunk in repo 1 no default 
reviewer would be added.
Is there something wrong with the setting?


 
 

 

 

 

 

 

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Default reviewer not working

[Christian Hammond]

Hi Dieter,

Try '/trunk/.*' for the regex path instead. The paths are prefixed with a '/' 
in modern versions of Review Board.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org 
Beanbag, Inc. - https://www.beanbaginc.com


On September 23, 2014 at 10:39:26 AM, Dieter Odeurs (dieterode...@gmail.com) 
wrote:
 Hello
 
 I'm new to reviewboard and was experimenting with it. I want to test with
 default reviewers but i don't ge tit working.
 My test situation:
 
 3 SVN repo's:
 
 repo1
 
 repo2
 
 repo3
 
 
 All of them are structured like
 
 repo1
 
 trunk
 
 branch
 
 tag
 
 
 4user:
 
 admin (admin)
 
 me (admin)
 
 reviewer1
 
 reviewer2
 
 
 
 Now i want that for every review in the trunk of repo 1 admin would be the
 default reviewer.
 Default review setting are:
 
 name: defaultRepo1
 
 regex: trunk/.*
 
 default group: /
 
 default user: admin
 
 
 But when I add a new review request of the trunk in repo 1 no default
 reviewer would be added.
 Is there something wrong with the setting?
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard 
 group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com. 
 For more options, visit https://groups.google.com/d/optout.
 

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 2167 in reviewboard: Default Reviewer Submitter Regular Expression

[reviewboard]

Updates:
Labels: Component-Reviews

Comment #2 on issue 2167 by trowb...@gmail.com: Default Reviewer Submitter  
Regular Expression

http://code.google.com/p/reviewboard/issues/detail?id=2167

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Default reviewer list

[Scott Quesnelle]

Hello,

Just wanted to say thanks for the excellent tool. We have been using
reviewboard for over 2 years now. One question though. We use default
reviewers, and associate them with review groups. This helps reduce the
administration as users can join/leave groups as they see fit.  We are
using default reviewers and associate review groups on a per directory
basis. Some users would like to know a way to determining what group owns a
particular area of the tree.  I thought of using the REST api to get this
data out, but I noticed the default reviewers isn't part of the REST api.
Any particular reason that it isn't?

Thanks,

Scott

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Default reviewer list

[David Trowbridge]

It's not an intentional decision, it's just not something that we've
had a need for in the past. It would be pretty trivial to add a new
resource for this, especially if you just need read-only (GET) access.

-David


On Wed, Oct 17, 2012 at 9:43 AM, Scott Quesnelle
scott.quesne...@gmail.com wrote:
 Hello,

 Just wanted to say thanks for the excellent tool. We have been using
 reviewboard for over 2 years now. One question though. We use default
 reviewers, and associate them with review groups. This helps reduce the
 administration as users can join/leave groups as they see fit.  We are using
 default reviewers and associate review groups on a per directory basis. Some
 users would like to know a way to determining what group owns a particular
 area of the tree.  I thought of using the REST api to get this data out, but
 I noticed the default reviewers isn't part of the REST api. Any particular
 reason that it isn't?

 Thanks,

 Scott

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Default reviewer list

[Scott Quesnelle]

David,

Thanks. GET access is all that I would really want. This would let me build
up a view of 'who' owns what areas of our source, and also allow developers
to engage the right people when they are thinking of modifying a specific
piece. Will see if I have some time to take at doing this addition myself.

Scott

On Wed, Oct 17, 2012 at 1:05 PM, David Trowbridge trowb...@gmail.comwrote:

 It's not an intentional decision, it's just not something that we've
 had a need for in the past. It would be pretty trivial to add a new
 resource for this, especially if you just need read-only (GET) access.

 -David


 On Wed, Oct 17, 2012 at 9:43 AM, Scott Quesnelle
 scott.quesne...@gmail.com wrote:
  Hello,
 
  Just wanted to say thanks for the excellent tool. We have been using
  reviewboard for over 2 years now. One question though. We use default
  reviewers, and associate them with review groups. This helps reduce the
  administration as users can join/leave groups as they see fit.  We are
 using
  default reviewers and associate review groups on a per directory basis.
 Some
  users would like to know a way to determining what group owns a
 particular
  area of the tree.  I thought of using the REST api to get this data out,
 but
  I noticed the default reviewers isn't part of the REST api. Any
 particular
  reason that it isn't?
 
  Thanks,
 
  Scott
 
  --
  Want to help the Review Board project? Donate today at
  http://www.reviewboard.org/donate/
  Happy user? Let us know at http://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group at
  http://groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Issue 2641 in reviewboard: Adding repository to default reviewer fails with HTTP 500

[reviewboard]

Comment #2 on issue 2641 by ex...@dps-online.de: Adding repository to  
default reviewer fails with HTTP 500

http://code.google.com/p/reviewboard/issues/detail?id=2641

Thank you for the quick response. Downgrading to Django 1.3.1 fixed the  
problem for me, which also occured on our test machine running Reviewboard  
1.6.9 on Ubuntu.

We will also check switching to a linux server, thanks for your advice.

Side note:
since Django 1.4 seems to update all the password hashes with a stronger  
algorithm thus downgrading to 1.3.x leaves all your users locked out. So  
all of them need to recover their passwords. Not a big deal in our case  
(less than 20 users) but I thought it would be worth to mention.


Martin

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 2641 in reviewboard: Adding repository to default reviewer fails with HTTP 500

[reviewboard]

Comment #3 on issue 2641 by chip...@gmail.com: Adding repository to default  
reviewer fails with HTTP 500

http://code.google.com/p/reviewboard/issues/detail?id=2641

Installing Review Board 1.6.x forces an install of the proper version of  
Django, so it sounds like it was just overridden in this case by manually  
installing 1.4 on top of it. So, not a typical problem people will usually  
hit.


Sorry to hear about the account issues.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 2641 in reviewboard: Adding repository to default reviewer fails with HTTP 500

[reviewboard]

Updates:
Status: SetupIssue

Comment #1 on issue 2641 by chip...@gmail.com: Adding repository to default  
reviewer fails with HTTP 500

http://code.google.com/p/reviewboard/issues/detail?id=2641

Review Board 1.6.x is not compatible with Django 1.4. You're going to have  
to downgrade and re-run rb-site upgrade on the site.


You may also want to install this on Linux. We won't be supporting Windows  
as a server after 1.6.x.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 2167 in reviewboard: Default Reviewer Submitter Regular Expression

[reviewboard]

Comment #1 on issue 2167 by andrey...@gmail.com: Default Reviewer Submitter  
Regular Expression

http://code.google.com/p/reviewboard/issues/detail?id=2167

Be able to assign a reviewer name based on submitter name in addition to  
files is important for larger teams.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Issue 2367 in reviewboard: default reviewer setting for local site affects main site

[reviewboard]

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2367 by henry@gmail.com: default reviewer setting for local  
site affects main site

http://code.google.com/p/reviewboard/issues/detail?id=2367

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.6.1

What steps will reproduce the problem?
1. Create a local site
2. Create a default reviewer entry with at least one user and associate it  
for the local site, without restricting it to specific repositories and  
make it match any file (.*)
3. Create a review request using post-review on the main site and upload a  
diff.
The default reviewers for the local site is added to the review request on  
the main site.


What is the expected output? What do you see instead?
The default reviewers added to the review request on the main site should  
not include any site specific default reviewers.


What operating system are you using? What browser?
Ubuntu 9.04, Chrome 14, Firefox 7

Please provide any additional information below.
Used latest RBTools (0.3.4).
Workaround this by restricting the default reviewer for the local site with  
repositories associated with the local site.



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Issue 2167 in reviewboard: Default Reviewer Submitter Regular Expression

[reviewboard]

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2167 by cea...@gmail.com: Default Reviewer Submitter Regular  
Expression

http://code.google.com/p/reviewboard/issues/detail?id=2167

What version are you running?
1.6 beta 2

What's the URL of the page this enhancement relates to, if any?
http://reviewboard/admin/db/reviews/defaultreviewer/2/

Describe the enhancement and the motivation for it.
We use a script to auto-submit review requests based on svn commits and  
reviewboard kindly auto-assigns the proper reviewers to each commit.  
However, sometimes the reviewer is also the submitter which results  
extraneous emails. In addition, sometimes we have new users who need to  
have their code reviewed by specific people. We would like to be able to  
specify a regular expressions which works in combination with the file  
regular expression so that if both result to true, the proper users are  
assigned.


What operating system are you using? What browser?
Windows 7 Pro, Chrome 12

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Issue 987 in reviewboard: With a default reviewer setup adding a new review does work as expected.

[codesite-noreply]

Updates:
Status: NeedInfo

Comment #1 on issue 987 by trowbrds: With a default reviewer setup adding a  
new review does work as expected.
http://code.google.com/p/reviewboard/issues/detail?id=987

Please check your admin email for backtraces. It sounds like something is  
breaking in
the process but I can't tell what from this description.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Issue 987 in reviewboard: With a default reviewer setup adding a new review does work as expected.

[codesite-noreply]

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 987 by VirtualThoughts: With a default reviewer setup adding a  
new review does work as expected.
http://code.google.com/p/reviewboard/issues/detail?id=987

*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
http://ip:port/r/new/

What steps will reproduce the problem?
1. In the admin panel setup a default reviewer with several names selected.
2. Save that change.
3. Using the same account that setup the default reviewer attempt to create
a new review.


What is the expected output? What do you see instead?
Expected: I would expect to be transferred to the http://ip:port/r/id/  
page.
What happens: The base diff path and diff fields are cleared with no
transfer to the next page.

Note: The draft review IS created... you just have to browse to it manually.
Also: Prior to adding the default reviewers the transfer to the draft
review worked.

What operating system are you using? What browser?
Windows XP has host machine with Apache 2.2 mod_python
Firefox 3.0.7


Please provide any additional information below.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Default reviewer

[Nizar]

Hi,

I'm trying to setup default reviewers for my code-base. In the Change
default reviewer config screen, I've the file path regex set to *
and some users selected, but the review requests are not getting
copied to the default reviewers. Any help?

Thanks,
-Nizar.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Default reviewer

[Christian Hammond]

Try .*. It needs to be a regular expression rather than a file glob.

Christian

-- 
Christian Hammond - chip...@chipx86.com
VMware, Inc.


On Thu, Jan 29, 2009 at 6:59 AM, Nizar niza...@gmail.com wrote:


 Hi,

 I'm trying to setup default reviewers for my code-base. In the Change
 default reviewer config screen, I've the file path regex set to *
 and some users selected, but the review requests are not getting
 copied to the default reviewers. Any help?

 Thanks,
 -Nizar.
 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---