Re: Resetting open issue counters

2014-09-24 Thread Alexey Neyman
Hi Christian, Just upgraded to 2.0.8: [[[ bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts --recalculate --verbosity=2 2050 Usage: rb-site command [options] path rb-site: error: no such option: --recalculate bash-4.1# rb-site --version rb-site 2.0.8 ]]] BTW, release notes for

Re: Resetting open issue counters

2014-09-24 Thread Christian Hammond
Thanks, I'll fix the release notes. Make sure to put a -- before any --arguments, like:     rb-site manage /var/www/reviewboard reset-issue-counts -- --verbosity=2 --recalculate Not sure what you mean by the help output being wrong though? Christian -- Christian Hammond -

Re: Resetting open issue counters

2014-09-24 Thread Alexey Neyman
Figured it out, needs -- to have --recalculate argument applied to 'reset-issue-counts' rather than rb-site itself. Here is the output: DEBUG:root:Calculated issue counts for review request ID 2050 across 5 review(s): Resulting counts = {u'R': 0, u'D': 0, u'O': 1}; DB values =

Re: Resetting open issue counters

2014-09-24 Thread Alexey Neyman
Re help: the order of the 'manage' and path arguments is swapped. Correct order: rb-site manage path Help message: rb-site path manage Regards, Alexey. On Wed, Sep 24, 2014 at 12:41 PM, Christian Hammond christ...@beanbaginc.com wrote: Thanks, I'll fix the release notes. Make sure to put a

Re: Resetting open issue counters

2014-09-24 Thread Christian Hammond
Thanks for the debug info! Yeah, as I mentioned in an earlier reply, a reset command will *not* fix the problem, because the calculation is broken. Best I could do is to get this command in to reset and provide debug information, so that I can hopefully figure out the cause. I'll look into

Re: Resetting open issue counters

2014-09-24 Thread Alexey Neyman
Re release notes: you've fixed only one instance of the two where 'manage' was missing: A new rb-site path reset-issue-counts management command has been added... On Wed, Sep 24, 2014 at 12:41 PM, Christian Hammond christ...@beanbaginc.com wrote: Thanks, I'll fix the release notes. Make

Re: Resetting open issue counters

2014-09-24 Thread Christian Hammond
Can you tell it's been a very long few days? Fixed. New docs are building now. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 24, 2014 at 12:47:39 PM, Alexey Neyman

Re: Resetting open issue counters

2014-09-24 Thread Christian Hammond
So according to that debug output, there is one comment that has an issue open. I want to do some probing into this. Can you run this and provide the full output, commands included?     $ rb-site manage /path/to/site shell     from reviewboard.reviews.models import Comment, Review     comment

Re: Resetting open issue counters

2014-09-24 Thread Alexey Neyman
Here it is: from reviewboard.reviews.models import Comment, Review comment = Comment.objects.get(pk=8199) print comment.reply_to_id None print comment.issue_opened False print comment.issue_status O review = comment.review.get() print review.pk 6722 print review.public True print

Re: Resetting open issue counters

2014-09-24 Thread Christian Hammond
Hi Alexey, Thanks, that helps a lot. I think I know what's going on then. I'll send a patch your way for testing once I have a fix. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September

Re: Resetting open issue counters

2014-09-23 Thread Christian Hammond
Do you happen to have a database backup prior to the upgrade? I'd love to try with a real before/after. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 22, 2014 at 4:15:20 PM,

Re: Resetting open issue counters

2014-09-23 Thread Christian Hammond
Oh, regarding the fix the counts script, I can write one, but it's very unlikely to matter, I realized. It's just going to trigger the exact same logic that's triggered when viewing the review request for the first time, post-upgrade. If it got it wrong before, I don't have much reason to

Resetting open issue counters

2014-09-22 Thread Alexey Neyman
Hi all, We have just upgraded our installation of RB to 2.0.7. One nice new feature is that the dashboard now displays the number of open issues in a review request. However, I have noticed that the counters don't seem to be accurate in some request. For example, one of the review requests

Re: Resetting open issue counters

2014-09-22 Thread Stephen Gallagher
On 09/22/2014 04:30 PM, Alexey Neyman wrote: Hi all, We have just upgraded our installation of RB to 2.0.7. One nice new feature is that the dashboard now displays the number of open issues in a review request. However, I have noticed that the counters don't seem to be accurate in some

Re: Resetting open issue counters

2014-09-22 Thread Christian Hammond
I would love a repro case for this. I've seen a couple of reports, and have tried desperately to reproduce it, with no luck. The code is fairly straightforward in how it counts the initial values. Christian On Monday, September 22, 2014, Stephen Gallagher step...@gallagherhome.com wrote: On

Re: Resetting open issue counters

2014-09-22 Thread Alexey Neyman
Christian, Meanwhile, is it possible to have a rb-site manage subcommand to recalculate these counters? Thanks, Alexey. On Sep 22, 2014 2:00 PM, Christian Hammond chip...@chipx86.com wrote: I would love a repro case for this. I've seen a couple of reports, and have tried desperately to

Re: Resetting open issue counters

2014-09-22 Thread Christian Hammond
Hi Alexey, That's something we can get in. As for the manage command, it's just an oversight. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 22, 2014 at 3:09:41 PM, Alexey Neyman