Re: Confirming Git pre-commit workflow

2018-01-24 Thread Christian Hammond
Hi Mathias, That process looks right, but you shouldn't get that error if the repository configuration in Review Board is correct. Can you show me what that looks like? Christian On Wed, Jan 24, 2018 at 1:27 AM, Mathias Sulser wrote: > Hi, > > I am new to reviewboard and

Confirming Git pre-commit workflow

2018-01-24 Thread Mathias Sulser
Hi, I am new to reviewboard and currently debugging my setup. I wanted to confirm the “git pre-commit review” workflow: 1/ Clone the central repository 2/ Make a change to file X, and commit it to a local branch 3/ Run rbt post 4/ .. Should I now get an error saying file X was not found at rev

Re: Clarification of Pre-Commit Workflow

2014-08-12 Thread Kevan Stannard
. - http://www.beanbaginc.com On August 5, 2014 at 10:42:45 PM, Kevan Stannard (kevans...@gmail.com) wrote: I've been reading the workflow page here: https://www.reviewboard.org/docs/manual/2.0/users/getting- started/workflow/ We're planning to follow the pre-commit workflow. Would

Re: Clarification of Pre-Commit Workflow

2014-08-11 Thread David Trowbridge
here: https://www.reviewboard.org/docs/manual/2.0/users/getting- started/workflow/ We're planning to follow the pre-commit workflow. Would be grateful if someone could clarify some of the steps for us. Here's my current understanding of the first few steps: *1) Make a change to your local

Re: Clarification of Pre-Commit Workflow

2014-08-07 Thread Kevan Stannard
reading the workflow page here: https://www.reviewboard.org/docs/manual/2.0/users/getting-started/workflow/ We're planning to follow the pre-commit workflow. Would be grateful if someone could clarify some of the steps for us. Here's my current understanding of the first few steps: *1

Re: Clarification of Pre-Commit Workflow

2014-08-06 Thread Christian Hammond
/ We're planning to follow the pre-commit workflow. Would be grateful if someone could clarify some of the steps for us. Here's my current understanding of the first few steps: 1) Make a change to your local source tree. Here we: a) Edit a file b) Commit the change 2) Create a review request

Clarification of Pre-Commit Workflow

2014-08-05 Thread Kevan Stannard
I've been reading the workflow page here: https://www.reviewboard.org/docs/manual/2.0/users/getting-started/workflow/ We're planning to follow the pre-commit workflow. Would be grateful if someone could clarify some of the steps for us. Here's my current understanding of the first few steps

Re: Pre-Commit Workflow

2014-02-21 Thread Charles Yates
Guess it might be easier if I provide the script and associated document which I'm muttering about here :). https://docs.google.com/document/d/1z3XtAsVoCx9BDWS8itFZ0mOTd9d66tPus7eSE13m0eM It's very much a prototype - just knocked up in handful of shell scripts (I've only included a couple of

Re: Pre-Commit Workflow

2014-02-20 Thread Charles Yates
On Wednesday, 19 February 2014 16:36:21 UTC+1, Allen wrote: Really good question! I also encounter the same problem. Developers dont want to wait until the previous review passed to work on the next issue. One solution I think is, once a review passed, apply that review`s patch file to

Re: Pre-Commit Workflow

2014-02-20 Thread Charles Yates
On Wednesday, 19 February 2014 21:15:31 UTC+1, David Trowbridge wrote: The typical way that other dvcs users do this is to have local branches for each piece of work, and post from each of those. I don't know enough about bzr's workflow to know if that would be appropriate (though I recall

Re: Pre-Commit Workflow

2014-02-20 Thread Christian Hammond
On Wed, Feb 19, 2014 at 7:36 AM, Allen zhangsan8...@gmail.com wrote: I have no idea why the review board changes the paths from local to remote server, at least it should keep the local working copy`s path. Here`s a example of what those paths look like: ---

Re: Pre-Commit Workflow

2014-02-19 Thread Allen
Really good question! I also encounter the same problem. Developers dont want to wait until the previous review passed to work on the next issue. One solution I think is, once a review passed, apply that review`s patch file to a new working copy without touching what you are currently working

Re: Pre-Commit Workflow

2014-02-19 Thread David Trowbridge
PM, Charles Yates charles.ya...@gmail.com wrote: Hi, We're trying to follow a pre-commit workflow with bzr with all patches submitted to the review board prior to checkin to the repo - I was wondering anyone had any experience with this and how best to handle pending patches

Pre-Commit Workflow

2014-02-15 Thread Charles Yates
Hi, We're trying to follow a pre-commit workflow with bzr with all patches submitted to the review board prior to checkin to the repo - I was wondering anyone had any experience with this and how best to handle pending patches. Sometimes it's inconvenient to wait for the review process

Re: pre-commit workflow

2009-02-13 Thread Brot
Is there any documentation for this post-review script? Where should this script run? In my case we are using a linux server for review-board and have windows-client where we are working on our code (svn working base is on windows). Does this script fit into this environment? Do I have the