Thanks for the suggestion. I downloaded rbtools 0.2 stable from
http://github.com/reviewboard/rbtools, made my changes to
postreview.py, and reinstalled the package using "python setup.py
install" at the rbtool root.
In postreview.py I changed the "svn diff --diff-cmd=diff" to "svn diff
--diff-cmd
Timothy Pinet wrote:
I wanted to check post-review however since I am on Windows my
Python26\Scripts\post-review.exe is a compiled executable and not a
python file. Would it be enough to grab the post-review.py from the
repo and delete the exe?
Not with the current version. There are a few d
I wanted to check post-review however since I am on Windows my
Python26\Scripts\post-review.exe is a compiled executable and not a
python file. Would it be enough to grab the post-review.py from the
repo and delete the exe?
Thanks,
Tim
On Aug 20, 12:54 pm, Chris Clark wrote:
>
> It actually isn'
Timothy Pinet wrote:
In which file does reviewboard invoke the "svn diff --diff-cmd=diff"
command? I have been looking but can not find it. I then thought that
you probably call the pysvn lib for this. I checked the pysvn
documentation (http://pysvn.tigris.org/docs/
pysvn_prog_ref.html#pysvn_clie
In which file does reviewboard invoke the "svn diff --diff-cmd=diff"
command? I have been looking but can not find it. I then thought that
you probably call the pysvn lib for this. I checked the pysvn
documentation (http://pysvn.tigris.org/docs/
pysvn_prog_ref.html#pysvn_client_diff) and there is a
with svn and gnu diffutils (new review with
an added binary file)
There's no way to pass additional arguments right now. Personally I don't
like that we even use --diff-cmd, but it works around some other problems
we've hit in the past (I'd have to check the commit logs to r
There's no way to pass additional arguments right now. Personally I don't
like that we even use --diff-cmd, but it works around some other problems
we've hit in the past (I'd have to check the commit logs to remember exactly
what they were).
It may be worth modifying your copy for now to remove th
Alternatively, the diffutils docs (http://www.gnu.org/software/hello/
manual/diff.html#Binary) state:
"Differing binary files are considered to cause trouble because the
resulting diff output does not capture all the differences. This
trouble causes diff to exit with status 2. However, this troubl
