Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Updates: Status: Fixed Comment #11 on issue 1524 by trowb...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 Fixed in rbtools master (7160581). If you set GIT_USE_EXT_DIFF = True in ~/.reviewboardrc, rbtools will not use --no-ext-diff. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Updates: Labels: -Milestone-RBTools-Release1.0 Comment #9 on issue 1524 by trowb...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Comment #5 on issue 1524 by vzeit...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 It would be really great to get any reply about this because it's annoying to have to change this in every new installation of RBTools. Especially because I still think there is absolutely no good reason for using --no-ext-diff in the first place, so it's a pity that comment #4 apparently went completely unnoticed. Of course, it's also possible that I'm missing something here, but in this case I'd be really grateful if somebody could please point out what is it. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Updates: Status: New Comment #6 on issue 1524 by trowb...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 I'm sorry, we missed the earlier comment. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Comment #8 on issue 1524 by emil@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 If I recall correctly, the original issue I saw is that someone can configure external diff to run sort of graphical program that does not actually generate a diff to stdout. If I had to guess, probably someone I was helping had their external diff set to p4merge and couldn't figure out why their upload wasn't working. (As an aside, it seems that there is some debate as to whether one ought to properly use git difftool for that purpose or git with an external diff tool. Both seem to be possible. But the fact remains that with external diff, there isn't a guarantee that what you get on stdout is something RB will be able to understand once it has been uploaded.) Perhaps RB could try without no-ext-diff but if the upload fails fallback to no no-ext-diff before giving up? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Comment #4 on issue 1524 by vzeit...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 Sorry but could the decision to add --no-ext-diff be please reconsidered? I don't know what is the reasoning behind explicitly ignoring the user options but IMHO the answer to RB can't run the non-existent program I configured Git to use is simply Don't configure Git to use non-existent programs, not this. And I can definitely explain why this is a problem for me: I'm using a hack to disable diffs to some not interesting files by default, i.e. I have foobar diff=generated in .gitattributes and used git config diff.generated.command true to just suppress the diff for all files with this attribute. Unfortunately, when I use post-review, the diffs for all these files do get submitted, which is very annoying. And AFAICS there is no way to avoid it. So could the patch be either simply reverted or, if it's really needed, be at least made optional? In the latter case, please let me know if you'd accept a patch adding an option governing this behaviour. TIA! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: postreview.py failing with error message: Got API Error 218 (HTTP code 403): Unable to authenticate with the repository using the provided credentials
I don't have a list of lines. You'd have to trace yourself and try to narrow it down. If I knew where to put the logging statements, I'd have a better idea of what was wrong. All I can point you to is djblets/webapi/auth.py and reviewboard/accounts/backends.py. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Oct 11, 2011 at 10:57 PM, jack jack jais...@gmail.com wrote: Thanks for the quick response. if you could guide me exactly where you would like to put logging on LDAPBackend class and djblets/webapi/auth.py i can do this for you and provide you with results. On Wed, Oct 12, 2011 at 11:12 AM, Christian Hammond chip...@chipx86.comwrote: There have been other people encountering this. Without an LDAP setup I can repro it with, someone else will have to do the work of figuring out where this is failing. That would mean adding logging to the LDAPBackend class, and possibly to djblets/webapi/auth.py. I'd love to get this fixed, but someone else will need to do the leg work. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Oct 11, 2011 at 10:33 PM, jack jack jais...@gmail.com wrote: Hi All, At last I was able to login into the Reviewbaord using LDAP Authentication user account, thanks Christian and Stephen for your valuable input you have extended toward me really appreciated. Now I tried to post a review request using RB tool, RBtool prompts me with username and password, the username and password I provided is the LDAP user. But its failing with error message Error creating review request: Unable to authenticate with the repository using the provided credentials (HTTP 403, API Error 218) I am using the same LDAP user account user when prompted by the post-review tool for username and password. Can somebody tell what is happening wrong here. We are using perforce as version control. RBtools version 0.3.3. Regards, Jack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: postreview.py failing with error message: Got API Error 218 (HTTP code 403): Unable to authenticate with the repository using the provided credentials
i have added the logging in the djblets/webapi/auth.py i would like to sent logging message to you in person.please share your personal mail id. On Wed, Oct 12, 2011 at 11:34 AM, Christian Hammond chip...@chipx86.comwrote: I don't have a list of lines. You'd have to trace yourself and try to narrow it down. If I knew where to put the logging statements, I'd have a better idea of what was wrong. All I can point you to is djblets/webapi/auth.py and reviewboard/accounts/backends.py. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Oct 11, 2011 at 10:57 PM, jack jack jais...@gmail.com wrote: Thanks for the quick response. if you could guide me exactly where you would like to put logging on LDAPBackend class and djblets/webapi/auth.py i can do this for you and provide you with results. On Wed, Oct 12, 2011 at 11:12 AM, Christian Hammond chip...@chipx86.comwrote: There have been other people encountering this. Without an LDAP setup I can repro it with, someone else will have to do the work of figuring out where this is failing. That would mean adding logging to the LDAPBackend class, and possibly to djblets/webapi/auth.py. I'd love to get this fixed, but someone else will need to do the leg work. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Oct 11, 2011 at 10:33 PM, jack jack jais...@gmail.com wrote: Hi All, At last I was able to login into the Reviewbaord using LDAP Authentication user account, thanks Christian and Stephen for your valuable input you have extended toward me really appreciated. Now I tried to post a review request using RB tool, RBtool prompts me with username and password, the username and password I provided is the LDAP user. But its failing with error message Error creating review request: Unable to authenticate with the repository using the provided credentials (HTTP 403, API Error 218) I am using the same LDAP user account user when prompted by the post-review tool for username and password. Can somebody tell what is happening wrong here. We are using perforce as version control. RBtools version 0.3.3. Regards, Jack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: postreview.py failing with error message: Got API Error 218 (HTTP code 403): Unable to authenticate with the repository using the provided credentials
This seems to be blocker !! can somebody look into this...this will really help us On Wed, Oct 12, 2011 at 12:37 PM, jack jack jais...@gmail.com wrote: The host from where i post reviewrequest the file ~/.post-review-cookies.txt does not contain any RB site name or rbsessionid etc is this something related to this issue. bash-3.2$ cat ~/.post-review-cookies.txt # Netscape HTTP Cookie File # http://www.netscape.com/newsref/std/cookie_spec.html # This is a generated file! Do not edit. On Wed, Oct 12, 2011 at 12:13 PM, jack jack jais...@gmail.com wrote: Hello Chris, Please find the log attach. Regards, Jack. On Wed, Oct 12, 2011 at 12:05 PM, jack jack jais...@gmail.com wrote: i have added the logging in the djblets/webapi/auth.py i would like to sent logging message to you in person.please share your personal mail id. On Wed, Oct 12, 2011 at 11:34 AM, Christian Hammond chip...@chipx86.com wrote: I don't have a list of lines. You'd have to trace yourself and try to narrow it down. If I knew where to put the logging statements, I'd have a better idea of what was wrong. All I can point you to is djblets/webapi/auth.py and reviewboard/accounts/backends.py. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Oct 11, 2011 at 10:57 PM, jack jack jais...@gmail.com wrote: Thanks for the quick response. if you could guide me exactly where you would like to put logging on LDAPBackend class and djblets/webapi/auth.py i can do this for you and provide you with results. On Wed, Oct 12, 2011 at 11:12 AM, Christian Hammond chip...@chipx86.com wrote: There have been other people encountering this. Without an LDAP setup I can repro it with, someone else will have to do the work of figuring out where this is failing. That would mean adding logging to the LDAPBackend class, and possibly to djblets/webapi/auth.py. I'd love to get this fixed, but someone else will need to do the leg work. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Oct 11, 2011 at 10:33 PM, jack jack jais...@gmail.comwrote: Hi All, At last I was able to login into the Reviewbaord using LDAP Authentication user account, thanks Christian and Stephen for your valuable input you have extended toward me really appreciated. Now I tried to post a review request using RB tool, RBtool prompts me with username and password, the username and password I provided is the LDAP user. But its failing with error message Error creating review request: Unable to authenticate with the repository using the provided credentials (HTTP 403, API Error 218) I am using the same LDAP user account user when prompted by the post-review tool for username and password. Can somebody tell what is happening wrong here. We are using perforce as version control. RBtools version 0.3.3. Regards, Jack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at
postreview.py failing with error message: Got API Error 218 (HTTP code 403): Unable to authenticate with the repository using the provided credentials
Hi All, At last I was able to login into the Reviewbaord using LDAP Authentication user account, thanks Christian and Stephen for your valuable input you have extended toward me really appreciated. Now I tried to post a review request using RB tool, RBtool prompts me with username and password, the username and password I provided is the LDAP user. But its failing with error message Error creating review request: Unable to authenticate with the repository using the provided credentials (HTTP 403, API Error 218) I am using the same LDAP user account user when prompted by the post-review tool for username and password. Can somebody tell what is happening wrong here. We are using perforce as version control. RBtools version 0.3.3. Regards, Jack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: postreview.py failing with error message: Got API Error 218 (HTTP code 403): Unable to authenticate with the repository using the provided credentials
There have been other people encountering this. Without an LDAP setup I can repro it with, someone else will have to do the work of figuring out where this is failing. That would mean adding logging to the LDAPBackend class, and possibly to djblets/webapi/auth.py. I'd love to get this fixed, but someone else will need to do the leg work. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Oct 11, 2011 at 10:33 PM, jack jack jais...@gmail.com wrote: Hi All, At last I was able to login into the Reviewbaord using LDAP Authentication user account, thanks Christian and Stephen for your valuable input you have extended toward me really appreciated. Now I tried to post a review request using RB tool, RBtool prompts me with username and password, the username and password I provided is the LDAP user. But its failing with error message Error creating review request: Unable to authenticate with the repository using the provided credentials (HTTP 403, API Error 218) I am using the same LDAP user account user when prompted by the post-review tool for username and password. Can somebody tell what is happening wrong here. We are using perforce as version control. RBtools version 0.3.3. Regards, Jack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: postreview.py failing with error message: Got API Error 218 (HTTP code 403): Unable to authenticate with the repository using the provided credentials
Thanks for the quick response. if you could guide me exactly where you would like to put logging on LDAPBackend class and djblets/webapi/auth.py i can do this for you and provide you with results. On Wed, Oct 12, 2011 at 11:12 AM, Christian Hammond chip...@chipx86.comwrote: There have been other people encountering this. Without an LDAP setup I can repro it with, someone else will have to do the work of figuring out where this is failing. That would mean adding logging to the LDAPBackend class, and possibly to djblets/webapi/auth.py. I'd love to get this fixed, but someone else will need to do the leg work. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Oct 11, 2011 at 10:33 PM, jack jack jais...@gmail.com wrote: Hi All, At last I was able to login into the Reviewbaord using LDAP Authentication user account, thanks Christian and Stephen for your valuable input you have extended toward me really appreciated. Now I tried to post a review request using RB tool, RBtool prompts me with username and password, the username and password I provided is the LDAP user. But its failing with error message Error creating review request: Unable to authenticate with the repository using the provided credentials (HTTP 403, API Error 218) I am using the same LDAP user account user when prompted by the post-review tool for username and password. Can somebody tell what is happening wrong here. We are using perforce as version control. RBtools version 0.3.3. Regards, Jack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
postreview.py
Hi, my company using your RB since long time and they are very happy using the same. Presently we are using 1.0 RB server which i guess is absolute. But we are planning to upgrade stable release version of RB server, I guess 1.5.5. Please correct me if i am wrong or suggest if there is any other stable release. Are there any risk to upgrade of RB server to new version from RB 1.0 if yes then please let us know. There is requirement from our management that to perform md5 checksum of the diff file and perform some validation check, hence we wanted to know do we perform md5 sum of diff generated by postreview tools, if no can you provide us pointer where we can add these check. As i am new to python and new to this tool any help on this would appreciated. Thanks again. Jack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: postreview.py
Hi Jack, 1.6.1 is the latest stable. From our own tests, you should be able to upgrade, but it's possible you will hit issues. First, you will want to fully back up the database. Then you will want to rename your current site directory and make a new one in its place using rb-site. This is needed in order to get some of the new configuration. You should be ableto specify your existing database there. Review Board does not generate or store MD5 hashes of diffs. Assuming you want this passed to Review Board and stored, this to RB and post-review will be a bit complicated. You'll need to modify webapi code, upload forms code, database models, database evolution files, and post-review. It'll be hard to stay in sync. You'll need to perform your own builds and merges. Christian On Monday, September 19, 2011, jack jack jais...@gmail.com wrote: Hi, my company using your RB since long time and they are very happy using the same. Presently we are using 1.0 RB server which i guess is absolute. But we are planning to upgrade stable release version of RB server, I guess 1.5.5. Please correct me if i am wrong or suggest if there is any other stable release. Are there any risk to upgrade of RB server to new version from RB 1.0 if yes then please let us know. There is requirement from our management that to perform md5 checksum of the diff file and perform some validation check, hence we wanted to know do we perform md5 sum of diff generated by postreview tools, if no can you provide us pointer where we can add these check. As i am new to python and new to this tool any help on this would appreciated. Thanks again. Jack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: postreview.py
Thanks. On Sep 19, 11:42 pm, Christian Hammond chip...@chipx86.com wrote: Hi Jack, 1.6.1 is the latest stable. From our own tests, you should be able to upgrade, but it's possible you will hit issues. First, you will want to fully back up the database. Then you will want to rename your current site directory and make a new one in its place using rb-site. This is needed in order to get some of the new configuration. You should be ableto specify your existing database there. Review Board does not generate or store MD5 hashes of diffs. Assuming you want this passed to Review Board and stored, this to RB and post-review will be a bit complicated. You'll need to modify webapi code, upload forms code, database models, database evolution files, and post-review. It'll be hard to stay in sync. You'll need to perform your own builds and merges. Christian On Monday, September 19, 2011, jack jack jais...@gmail.com wrote: Hi, my company using your RB since long time and they are very happy using the same. Presently we are using 1.0 RB server which i guess is absolute. But we are planning to upgrade stable release version of RB server, I guess 1.5.5. Please correct me if i am wrong or suggest if there is any other stable release. Are there any risk to upgrade of RB server to new version from RB 1.0 if yes then please let us know. There is requirement from our management that to perform md5 checksum of the diff file and perform some validation check, hence we wanted to know do we perform md5 sum of diff generated by postreview tools, if no can you provide us pointer where we can add these check. As i am new to python and new to this tool any help on this would appreciated. Thanks again. Jack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
Hi Christian,
You mean post a review request to http://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request to http://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
No need to post a review request anymore, it's now fixed in RBTools It
was a breakage in post-review, not Review Board. That code was pretty
new, as we just recently updated it to use the new API.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Jan 13, 2011 at 7:53 PM, Dan birb...@gmail.com wrote:
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options
Re: Question about postreview.py get_repository_info
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
A more correct and readable json than last post, the indent for name
in the last post is wrong.
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method: GET}},
name: local-android}
}
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Question about postreview.py get_repository_info
Hi Here I have a problem with postreview.py when publish a review request, could anyone please have a look? My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py from https://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa0364f13aabe037470/rbtools/postreview.py, and configed the constants necessary. When I run postreivew, it throws a array index exception at line 677: url = rsp['links']['info']['href'], The whole piece of code is def get_repository_info(self, rid): Returns detailed information about a specific repository. if self.deprecated_api: url = 'api/json/repositories/%s/info/' % rid else: rsp = self.api_get( '%s%s/' % (self.root_resource['links']['repositories'] ['href'], rid)) url = rsp['links']['info']['href'] rsp = self.api_get(url) return rsp['info'] I added debug info for rep, it did not contain the links index indeed, but it contained a repository index. Then I manually went to check the xml from reviewboard server, and found the structure of the xml is like this rsp repository links info href so I changed line 677 to url = rsp[repository]['links']['info'] ['href'], finally it worked. Though it worked, I still did not know the reason and whether my change is right or wrong. I think it is unlike to be a bug of reviewboard, but I am too lazy to read all the code :-) so, could anyone kindly tell me that what the real problem is and what should I do? Any help will be highly appreciated! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1713 in reviewboard: postreview.py fails with API Error 105
Updates: Status: Incomplete Comment #4 on issue 1713 by trowbrds: postreview.py fails with API Error 105 http://code.google.com/p/reviewboard/issues/detail?id=1713 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1713 in reviewboard: postreview.py fails with API Error 105
Comment #2 on issue 1713 by lihuihhxx: postreview.py fails with API Error 105 http://code.google.com/p/reviewboard/issues/detail?id=1713 when i run `rb-site upgrade`, it tells meNo evolution required. So what causes the Got API Error 105 (HTTP code 200): One or more fields had errors -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1713 in reviewboard: postreview.py fails with API Error 105
Updates: Status: NeedInfo Owner: chipx86 Comment #3 on issue 1713 by chipx86: postreview.py fails with API Error 105 http://code.google.com/p/reviewboard/issues/detail?id=1713 You can get the API Error 105 for many reasons, but if it specifically says table diffviewer_filediff has no column named status then the evolution still needs to be applied. Of course, the question is, why didn't rb-site see that an evolution was missing. Can you look at the second line of your rb-site script? (I assume /usr/bin/rb-site). See what version it's referring to. It's possible, I suppose, that rb-site is running as the old version and therefore not seeing the new evolution files. Was the upgrade done using easy_install? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1713 in reviewboard: postreview.py fails with API Error 105
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1713 by daniel.shiryu: postreview.py fails with API Error 105
http://code.google.com/p/reviewboard/issues/detail?id=1713
We use the pre-commit-hook from this review:
http://reviews.reviewboard.org/r/822/
It uses the api-classes in reviewboard.py from RBTools 0.2 to make the
calls to the server and create a new review-request.
Since upgrading from 1.5beta2 to 1.5rc1 the commit-hook does not work
anymore because of the following error:
HTTP POSTing to
http://reviewboard.xxx.com/api/json/reviewrequests/44/diff/new/:
{'basedir': '/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': ['table diffviewer_filediff has no
column named status']}, 'stat': 'fail', 'err': {'msg': 'One or more
fields had errors', 'code': 105}, 'deprecated': {'in_version': '1.5'}}
Is this a regression introduced in ReviewBoard 1.5rc1, or is it that
reviewboard.py or the pre-commit-hook is outdated and needs fixing?
What version are you running?
ReviewBoard 1.5RC1.
What's the URL of the page containing the problem?
Probably api/json/reviewrequests/44/diff/new/
What steps will reproduce the problem?
1. Try to create a new review-request through the commit-handler (which
uses postreview.py)
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1713 in reviewboard: postreview.py fails with API Error 105
Comment #1 on issue 1713 by chipx86: postreview.py fails with API Error 105 http://code.google.com/p/reviewboard/issues/detail?id=1713 Neither. It looks like you didn't run 'rb-site upgrade' on your site, so there are fields missing from your database. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: postreview.py exists with invalid syntax using Windows
Thanks Christian, I've deinstalled Python 3.1 and installed Python 2.6. It's now working :-) So now I can start experimenting with svn hooks. Markus On Jun 10, 7:51 pm, Christian Hammond chip...@chipx86.com wrote: Hi Markus, Python 3.x is very different from 2.x. We don't support it yet (nor does most of our dependencies). You should install 2.6. Christian On Thursday, June 10, 2010, LeChuck m...@silverseed.de wrote: Hi, I'm using Windows 7 and I wanted to experiment with postreview.py (reviewboard server is already up and running in an ubuntu virtualbox). So I've installed Python 3.1.2 for Windows. But now when I try to execute python postreview I'm getting a syntax error in line 213 File postreview.py, line 213 except APIError, e: A quick seach with google brought up this syntax for python exception catching: except APIError as e: I'm not familiar with Python but I guess I'm either using the wrong Python version, the wrong script or something else is wrong here. Has anyone a suggestion on how to get this script running on Windows? Thanks, Markus BTW: I've downloaded RBTools-0.2.tar.gz from 18-Apr-2010 23:49 I've also tried to correct(?) the syntax by changing except APIError, e to except APIError as e but then other syntax errors follow (e.g line 276). -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: postreview.py exists with invalid syntax using Windows
If You look for SVN hooks I attach example in http://code.google.com/p/reviewboard/issues/detail?id=445 This hook check status of Roundup Issue tracker ticket. If ok they made review or commit code if review was made and diffs are identical. On Jun 11, 11:15 am, LeChuck m...@silverseed.de wrote: Thanks Christian, I've deinstalled Python 3.1 and installed Python 2.6. It's now working :-) So now I can start experimenting with svn hooks. Markus On Jun 10, 7:51 pm, Christian Hammond chip...@chipx86.com wrote: Hi Markus, Python 3.x is very different from 2.x. We don't support it yet (nor does most of our dependencies). You should install 2.6. Christian On Thursday, June 10, 2010, LeChuck m...@silverseed.de wrote: Hi, I'm using Windows 7 and I wanted to experiment with postreview.py (reviewboard server is already up and running in an ubuntu virtualbox). So I've installed Python 3.1.2 for Windows. But now when I try to execute python postreview I'm getting a syntax error in line 213 File postreview.py, line 213 except APIError, e: A quick seach with google brought up this syntax for python exception catching: except APIError as e: I'm not familiar with Python but I guess I'm either using the wrong Python version, the wrong script or something else is wrong here. Has anyone a suggestion on how to get this script running on Windows? Thanks, Markus BTW: I've downloaded RBTools-0.2.tar.gz from 18-Apr-2010 23:49 I've also tried to correct(?) the syntax by changing except APIError, e to except APIError as e but then other syntax errors follow (e.g line 276). -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: postreview.py exists with invalid syntax using Windows
Hi Markus, Python 3.x is very different from 2.x. We don't support it yet (nor does most of our dependencies). You should install 2.6. Christian On Thursday, June 10, 2010, LeChuck m...@silverseed.de wrote: Hi, I'm using Windows 7 and I wanted to experiment with postreview.py (reviewboard server is already up and running in an ubuntu virtualbox). So I've installed Python 3.1.2 for Windows. But now when I try to execute python postreview I'm getting a syntax error in line 213 File postreview.py, line 213 except APIError, e: A quick seach with google brought up this syntax for python exception catching: except APIError as e: I'm not familiar with Python but I guess I'm either using the wrong Python version, the wrong script or something else is wrong here. Has anyone a suggestion on how to get this script running on Windows? Thanks, Markus BTW: I've downloaded RBTools-0.2.tar.gz from 18-Apr-2010 23:49 I've also tried to correct(?) the syntax by changing except APIError, e to except APIError as e but then other syntax errors follow (e.g line 276). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
postreview.py exists with invalid syntax using Windows
Hi, I'm using Windows 7 and I wanted to experiment with postreview.py (reviewboard server is already up and running in an ubuntu virtualbox). So I've installed Python 3.1.2 for Windows. But now when I try to execute python postreview I'm getting a syntax error in line 213 File postreview.py, line 213 except APIError, e: A quick seach with google brought up this syntax for python exception catching: except APIError as e: I'm not familiar with Python but I guess I'm either using the wrong Python version, the wrong script or something else is wrong here. Has anyone a suggestion on how to get this script running on Windows? Thanks, Markus BTW: I've downloaded RBTools-0.2.tar.gz from 18-Apr-2010 23:49 I've also tried to correct(?) the syntax by changing except APIError, e to except APIError as e but then other syntax errors follow (e.g line 276). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Comment #2 on issue 1524 by alex.remen: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 Easy enough to fix by using --no-ext-diff, attaching a patch that fixes it for me at least. Attachments: postreview.py.patch 484 bytes -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1542 in reviewboard: postreview.py unhandled exception, line 659
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1542 by richardt: postreview.py unhandled exception, line 659
http://code.google.com/p/reviewboard/issues/detail?id=1542
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
March 5th nightly of RBTools.
What's the URL of the page containing the problem?
N/A
What steps will reproduce the problem?
It seems to be related to the handling of non-ascii characters in a
supposedly ASCII text file. We have a file, 'tinystr.cpp' from the TinyXML
distribution. postreview.py seems to choke when encoding the line
THIS FILE WAS ALTERED BY Tyge Løvset, 7. April 2005.
Specifically on the 'o' in Lovset. This is obviously not an ascii
character. I'm currently removing this code from my source control, which
is why I'm seeing this error now.
What is the expected output? What do you see instead?
It would be nice if:
1) The file post-reviewed anyway.
And at the very least I would expect
2) The rest of the files post-review, and I get a warning about this one,
and what exactly is wrong with it, along with (hopefully) a notice on the
review board server's website that the file changed and could not be
posted.
The text of the stack is (note that this is running in pdb):
Traceback (most recent call last):
File
p:\sa\ss\toolchain\python\export\2.6\2.6.2f0\tools\win32\i386\lib\pdb.py
, line 1283, in main
pdb._runscript(mainpyfile)
File
p:\sa\ss\toolchain\python\export\2.6\2.6.2f0\tools\win32\i386\lib\pdb.py
, line 1202, in _runscript
self.run(statement)
File
p:\sa\ss\toolchain\python\export\2.6\2.6.2f0\tools\win32\i386\lib\bdb.py
, line 368, in run
exec cmd in globals, locals
File string, line 1, in module
File postreview.py, line 2809, in module
main()
File postreview.py, line 2791, in main
submit_as=options.submit_as)
File postreview.py, line 2497, in tempt_fate
parent_diff_content)
File postreview.py, line 506, in upload_diff
review_request['id'], fields, files)
File postreview.py, line 625, in api_post
return self.process_json(self.http_post(path, fields, files))
File postreview.py, line 600, in http_post
content_type, body = self._encode_multipart_formdata(fields, files)
File postreview.py, line 659, in _encode_multipart_formdata
return content_type, content.encode('utf-8')
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf8 in position
818872: ordinal not in range(128)
What operating system are you using? What browser?
I'm running postreview.py on Windows 7.
Please provide any additional information below.
This error did not happen with an older version of RBTools (I had reviewed
adding this code to our source code control earlier, when we were thinking
about using it). I upgraded to this one to get a couple of other fixes,
but ran into this instead.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1542 in reviewboard: postreview.py unhandled exception, line 659
Updates: Status: Fixed Comment #1 on issue 1542 by chipx86: postreview.py unhandled exception, line 659 http://code.google.com/p/reviewboard/issues/detail?id=1542 The change that caused this has been reverted in a more recent nightly. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Updates: Status: Confirmed Labels: Milestone-RBTools-Release1.0 Component-RBTools Comment #1 on issue 1524 by chipx86: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1524 by emil.sit: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 *NOTE: Do not post confidential information in this bug report.* What version are you running? postreview 0.8. What steps will reproduce the problem? 1. git config diff.external /bin/does-not-exist 2. postreview.py What is the expected output? What do you see instead? Expect that a normal diff should be produced and uploaded. However, $ postreview.py -d --guess-description --guess-summary svn info git rev-parse --git-dir git symbolic-ref -q HEAD git svn info git svn --version git config --get svn-remote.svn.url git config --get branch.for-review.merge git config --get branch.for-review.remote git config remote.origin.url repository info: Path: git://internal/test.git, Base path: , Supports changesets: False git config --get reviewboard.url git merge-base origin/master refs/heads/for-review git diff --no-color --full-index b79bcb4c0c838df4406c01c59370977a53da5425..refs/heads/for-review Failed to execute command: ['git', 'diff', '--no-color', '--full-index', 'b79bcb4c0c838df4406c01c59370977a53da5425..refs/heads/for-review'] error: cannot run /bin/does-not-exist: No such file or directory external diff died, stopping at test/a.txt. [This log was manually edited diff; real results may vary.] What operating system are you using? What browser? Linux. Please provide any additional information below. Probably the best solution is to set GIT_CONFIG_NOSYSTEM and GIT_CONFIG_NOGLOBAL to insulate usage of git from any system/user/repo- specific settings. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1473 in reviewboard: Upload diff including binary file failed with postreview.py
Updates: Status: Fixed Labels: Component-RBTools Comment #1 on issue 1473 by chipx86: Upload diff including binary file failed with postreview.py http://code.google.com/p/reviewboard/issues/detail?id=1473 It sounds like your version of RBTools/post-review is quite old. Please upgrade to RC1. This was fixed long ago. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
