---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48415/#review136644
---
Ship it!
Ship It!
- Nate Cole
On June 8, 2016, 9:53 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48392/#review136627
---
Ship it!
Ship It!
- Nate Cole
On June 7, 2016, 11:49 p.m
] Finished at: Mon Jun 06 17:26:34 EDT 2016
[INFO] Final Memory: 35M/569M
[INFO]
Thanks,
Nate Cole
,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48258/#review136359
---
Ship it!
Ship It!
- Nate Cole
On June 6, 2016, 3:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48287/#review136347
---
Ship it!
Ship It!
- Nate Cole
On June 6, 2016, 1:20 p.m
> On June 6, 2016, 1:31 p.m., Nate Cole wrote:
> > I only see two changes here, and it's just logging. Was there some missed
> > files?
>
> Jonathan Hurley wrote:
> Same - only 2 changes and they are for logging.
>
> Dmytro Grinenko wrote:
>
there some missed
files?
- Nate Cole
On June 6, 2016, 1:20 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48234/#review136145
---
Ship it!
Ship It!
- Nate Cole
On June 3, 2016, 6:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48205/#review136118
---
Ship it!
Ship It!
- Nate Cole
On June 3, 2016, 9:56 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48221/#review136112
---
Ship it!
Ship It!
- Nate Cole
On June 3, 2016, 5:30 p.m
/ambari/server/controller/internal/AbstractProviderModule.java
(line 1175)
<https://reviews.apache.org/r/48221/#comment201118>
one day we'll support multi-cluster, so maybe this should combine cluster
name + component
- Nate Cole
On June 3, 2016, 4:56 p.m., Jonathan H
2119413
Diff: https://reviews.apache.org/r/48204/diff/
Testing
---
No automated testing, it's just XML change. Manual tested following:
- Default Install of 2.5.0.0 (make no URL changes, just "click through").
- Install 2.5.0.0, but change the URL to the version previous
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48181/#review136058
---
Ship it!
Ship It!
- Nate Cole
On June 2, 2016, 2:34 p.m
/services/stack_advisor.py (line
209)
<https://reviews.apache.org/r/48162/#comment201043>
%s % syntax is not the standard anymore, use "".format(...)
- Nate Cole
On June 2, 2016, 12:38 p.m., Josh Elser wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48036/#review135840
---
Ship it!
Ship It!
- Nate Cole
On June 1, 2016, 12:01 p.m
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48088/#review135788
---
On May 31, 2016, 3:48 p.m., Nate Cole wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/#review135792
---
Ship it!
Ship It!
- Nate Cole
On May 27, 2016, 6:48 p.m
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47978/#review135789
---
On May 31, 2016, 4:13 p.m., Nate Cole wrote:
>
>
://reviews.apache.org/r/48088/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47018/#review135643
---
Ship it!
Ship It!
- Nate Cole
On May 26, 2016, 12:15 p.m
] Finished at: Fri May 27 18:08:19 EDT 2016
[INFO] Final Memory: 33M/672M
[INFO]
Thanks,
Nate Cole
f fail messages to see how to do it.
- Nate Cole
On May 30, 2016, 9:30 a.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
eleted). Maybe
just make the host name where it was found to be informational rather than the
getFailedOn(). And in fact, getFailedOn() would be HDFS, not SNN since it's a
service and SNN is a component.
Either way, should make sure a test covers this appropriately.
- Nate Cole
-
>
> (Updated May 27, 2016, 4:15 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Nate Cole, and Sumit
> Mohanty.
>
>
> Bugs: AMBARI-16938
> https://issues.apache.org/jira/browse/AMBARI-16938
>
>
> Repository: ambari
>
>
69eb39d
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
237eed2
ambari-server/src/test/resources/hbase_version_test.xml 183da8c
Diff: https://reviews.apache.org/r/47978/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47933/#review135300
---
Ship it!
Ship It!
- Nate Cole
On May 27, 2016, 3:58 p.m
che.org/r/47961/#comment200288>
nit: you have two Runnables that do nearly the identical thing except how
to parse the resulting InputStream. Could push most of the run() to
MetricsRunnable and just have your subclasses parse.
- Nate Cole
On May 27, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47961/#review135261
---
Ship it!
Ship It!
- Nate Cole
On May 27, 2016, 12:26 p.m
query framework or something)?
- Nate Cole
On May 27, 2016, 6:01 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47933/#review135256
---
Ship it!
Ship It!
- Nate Cole
On May 27, 2016, 6:01 a.m
> On May 24, 2016, 4:41 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java,
> > lines 190-194
> > <https://reviews.apache.org/r/47783/diff/1/?file=1392703#file1392703line190>
> >
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47783/#review135253
---
Ship it!
Ship It!
- Nate Cole
On May 27, 2016, 11:40 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review135054
---
Ship it!
Ship It!
- Nate Cole
On May 26, 2016, 4:03 p.m
org.apache.ambari.server.state.repository.VersionDefinitionTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.595 sec - in
org.apache.ambari.server.state.repository.VersionDefinitionTest
Results :
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47785/#review134975
---
Ship it!
Ship It!
- Nate Cole
On May 25, 2016, 6:06 p.m
/upgrades/upgrade-2.5.xml (lines
897 - 899)
<https://reviews.apache.org/r/47871/#comment199970>
Why does downgrade get this message but not upgrade?
- Nate Cole
On May 25, 2016, 9:54 p.m., Alejandro Fernandez wrote:
>
> ---
Just wanted to make sure if this always be true?
>
> Nate Cole wrote:
> I think this assumption should be ok - we are already doing the symlink
> magic to point to the right spot.
>
> Tom Beerbower wrote:
> Thanks for the review Srimanth and Nate.
&g
]
Thanks,
Nate Cole
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47867/#review134902
---
On May 25, 2016, 8:54 p.m., Nate Cole wrote:
>
> ---
> This is an automatically genera
ply, visit:
> https://reviews.apache.org/r/47785/
> ---
>
> (Updated May 25, 2016, 6:06 p.m.)
>
>
> Review request for Ambari, John Speidel, Nate Cole, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-16853 and ATLAS-823
> https://issue
8347a7b
Diff: https://reviews.apache.org/r/47867/diff/
Testing
---
Manual. Automated pending
Thanks,
Nate Cole
> On May 24, 2016, 4:41 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java,
> > lines 190-194
> > <https://reviews.apache.org/r/47783/diff/1/?file=1392703#file1392703line190>
> >
&
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47790/#review134684
---
On May 24, 2016, 10:07 p.m., Nate Cole wrote:
>
> --
CESS
[INFO]
[INFO] Total time: 35:22.629s
[INFO] Finished at: Tue May 24 21:38:01 EDT 2016
[INFO] Final Memory: 34M/596M
[INFO]
Thanks,
Nate Cole
- 21)
<https://reviews.apache.org/r/47018/#comment199472>
Maybe this file should be called configuration-schema.xsd since the root
element is "configuration"?
- Nate Cole
On May 24, 2016, 12:11 p.m., Dmitro L
> On May 19, 2016, 10:20 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java,
> > line 298
> > <https://reviews.apache.org/r/47018/diff/2/?file=1387113#file1387113line298>
> >
> > Make a constant
> On May 19, 2016, 10:20 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java,
> > line 298
> > <https://reviews.apache.org/r/47018/diff/2/?file=1387113#file1387113line298>
> >
> > Make a constant
Would help with having to hard code action names here.
- Nate Cole
On May 24, 2016, 1:48 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
Testing
---
Manual. Automated Pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47757/#review134559
---
Ship it!
Ship It!
- Nate Cole
On May 23, 2016, 10:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47729/#review134363
---
Ship it!
Ship It!
- Nate Cole
On May 23, 2016, 11:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47718/#review134352
---
Ship it!
Ship It!
- Nate Cole
On May 23, 2016, 9:58 a.m
> On May 19, 2016, 10:20 a.m., Nate Cole wrote:
> > ambari-server/src/main/resources/property-schema.xsd, lines 68-70
> > <https://reviews.apache.org/r/47018/diff/2/?file=1387118#file1387118line68>
> >
> > All 3 required?
>
> Dmitro Lisnichenk
.
- Nate Cole
On May 12, 2016, 12:13 p.m., Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
open?
- Nate Cole
On May 19, 2016, 11:23 a.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
and can be
closed?
- Nate Cole
On May 4, 2016, 3:12 a.m., Gautam Borad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/#review134194
---
Ship it!
Ship It!
- Nate Cole
On May 20, 2016, 10:10 a.m
> On May 20, 2016, 7:57 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java,
> > lines 207-209
> > <https://reviews.apache.org/r/47631/diff/1/?file=1388816#file1388816line207>
> >
> > Should
40.java
(lines 2112 - 2117)
<https://reviews.apache.org/r/47428/#comment198793>
Shortcutting for ease-of-reading
- Nate Cole
On May 19, 2016, 10:06 p.m., Josh Elser wrote:
>
> ---
> This is an automatically
g/r/47631/#comment198789>
just runCommand?
- Nate Cole
On May 19, 2016, 11:32 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
mory: 34M/780M
[INFO] ----
Thanks,
Nate Cole
er/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
db66961
Diff: https://reviews.apache.org/r/47613/diff/
Testing
---
No changed tests. Manual testing. Automated pending.
Thanks,
Nate Cole
radeResourceProviderTest.java
(line 77)
<https://reviews.apache.org/r/47018/#comment198611>
no *
script.sh (lines 1 - 5)
<https://reviews.apache.org/r/47018/#comment198603>
What is this?
- Nate Cole
On May 18, 2016, 1:11 p.m., Dmitro Lisnichenko wrote:
>
> -
ions are you expecting here? You're already null checking a
bunch of stuff. A TODO like this should be taken care of in this patch.
- Nate Cole
On May 18, 2016, 6 a.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically
> On May 17, 2016, 10:30 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> > lines 890-892
> > <https://reviews.apache.org/r/45169/diff/2/?file=1382543#file1382543line890>
> >
> > Really need to
> On May 17, 2016, 10:30 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> > lines 890-892
> > <https://reviews.apache.org/r/45169/diff/2/?file=1382543#file1382543line890>
> >
> > Really need to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47498/#review133731
---
Ship it!
Ship It!
- Nate Cole
On May 17, 2016, 6:35 p.m
/package/scripts/upgrade.py
(lines 89 - 90)
<https://reviews.apache.org/r/47498/#comment198324>
This is an odd statement - typically would be os.path.join({stack_root},
{upgrade_from_version}, 'knox', 'data', '.')
Also, target_data_dir could use os.
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
>
> (Updated May 16, 2016, 2:50 p.m.)
>
>
> Review request for Amb
g/r/45169/#comment197999>
Changing this name may (or may not) impact UI. The group name is not
guaranteed unique, and some additional information may be displayed based on
it's name (unconfirmed, but that's the intent).
t;
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush
> Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-16687
> https://issues.apache.org/jira/browse/AMBARI-16687
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Duri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47421/#review133418
---
Ship it!
Ship It!
- Nate Cole
On May 16, 2016, 2:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47384/#review133267
---
Ship it!
Ship It!
- Nate Cole
On May 13, 2016, 10:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46270/#review133192
---
Ship it!
Ship It!
- Nate Cole
On May 4, 2016, 3:12 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47355/#review133190
---
Ship it!
Ship It!
- Nate Cole
On May 13, 2016, 3:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47331/#review133077
---
Ship it!
Ship It!
- Nate Cole
On May 13, 2016, 5:46 a.m
ps://reviews.apache.org/r/47321/#comment197213>
What is the decision making point here? You're overwriting the json you
just got from the request (which may actually have been json), but the method
you're calling is for a file URL. The operatingSystemsJson passed to the
download method will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47256/#review132926
---
Ship it!
Ship It!
- Nate Cole
On May 11, 2016, 4:41 p.m
.apache.org/r/47237/#comment197194>
"Cluster Admin" ?
- Nate Cole
On May 11, 2016, 10:06 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
: Thu May 12 07:46:59 EDT 2016
[INFO] Final Memory: 35M/703M
[INFO]
Thanks,
Nate Cole
/server/state/stack/LatestRepoCallable.java
fc2bab1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
1117d24
Diff: https://reviews.apache.org/r/47304/diff/
Testing
---
Manual. Automated pending
Thanks,
Nate Cole
t;
> (Updated May 10, 2016, 7:36 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-16439
> https://issues.apache.org/jira/browse/AMBARI-16439
>
>
> Repository: ambari
>
>
> Description
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47140/#review132486
---
Ship it!
Ship It!
- Nate Cole
On May 10, 2016, 12:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47136/#review132440
---
Ship it!
Ship It!
- Nate Cole
On May 9, 2016, 11:22 p.m
/ambari/server/controller/KerberosHelperImpl.java
(lines 1254 - 1258)
<https://reviews.apache.org/r/47136/#comment196521>
I realize hosts is defined as Collection, but it seems odd to mix
Sets and Lists here. Could just be a Set to indicate a unique-member
collection?
- Nate Cole
: 35M/700M
[INFO]
Thanks,
Nate Cole
/ServiceCheckValidityCheck.java
8b39863
ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
4a3ae5c
Diff: https://reviews.apache.org/r/47130/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
t;
> (Updated May 9, 2016, 5:56 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar,
> Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-16290
> https://issues.apache.org/jira/b
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47047/#review132038
---
Ship it!
Ship It!
- Nate Cole
On May 5, 2016, 7:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47010/#review132037
---
Ship it!
Ship It!
- Nate Cole
On May 6, 2016, 7:28 a.m
> On May 5, 2016, 1:20 p.m., Nate Cole wrote:
> > It feels to me like we should not be touching the stack for this, but
> > rather use the config-upgrade.xml or the upgrade pack to hold this
> > information. Then you can have ADD/DELETE/SKIP isolated in it's own fi
t;
> > Ewww... Log?
Will fix.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47038/#review131915
---
On
8/#review131915
---
On May 5, 2016, 3:44 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47034/#review131895
---
Ship it!
Ship It!
- Nate Cole
On May 5, 2016, 2:37 p.m
oved (as an example). But if you change the
stack, you don't get that flexibility.
I don't think blindly "don't merge up" is extremely dangerous and adds more
complexity to our "simple" *-site.xml files.
- Nate Cole
On May
-CREATE.sql (lines 1092 - 1096)
<https://reviews.apache.org/r/47010/#comment195902>
This syntax is so painful. Anyway to clean this up? maybe INSERT into
adminprincipal(principal_id, principal_type_id) VALUES (1, 1), (2, 3), (3,4)
... Oh, actually, I see we do that further down.
- Nat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46984/#review131716
---
Ship it!
Ship It!
- Nate Cole
On May 4, 2016, 12:49 p.m
,
Nate Cole
801 - 900 of 1030 matches
Mail list logo
