---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54936/#review160045
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 22, 2016, 9:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/#review160044
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 21, 2016, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54966/#review159976
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 22, 2016, 5:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54936/#review159938
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 22, 2016, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54942/#review159845
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 21, 2016, 5:52
g/r/54936/#comment230867>
I think the use of format is preferred over %
- Sebastian Toader
On Dec. 21, 2016, 5:41 p.m., Attila Magyar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54939/#review159827
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 21, 2016, 4:42
to
be sure that we don't flood the agent log.
- Sebastian Toader
On Dec. 21, 2016, 4:42 p.m., Attila Doroszlai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54933/#review159809
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 21, 2016, 2:05
tps://reviews.apache.org/r/54933/#comment230854>
Does setup-security perform any kerberos related tasks? If so I think
setup-security and setup-kerberos should be merged into setup-security to avoid
any confusion.
- Sebastian Toader
On Dec. 21, 2016, 1:58 p.m., Laszlo Puskas
ted here as well.
- Sebastian Toader
On Dec. 20, 2016, 1:20 p.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54698/#review159460
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 16, 2016, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54813/#review159452
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 16, 2016, 3:18
grade/UpgradeCatalog250Test.java
89dd567
Diff: https://reviews.apache.org/r/54743/diff/
Testing
---
Unit tests:
Results :
Tests run: 4797, Failures: 0, Errors: 0, Skipped: 37
Manual testing:
Tested with creating a new cluster. Also tested Ambari upgrade from 2.4.2 to 2.5
Thanks,
Seba
grade/UpgradeCatalog250Test.java
89dd567
Diff: https://reviews.apache.org/r/54743/diff/
Testing
---
Unit tests:
Results :
Tests run: 4797, Failures: 0, Errors: 0, Skipped: 37
Manual testing:
Tested with creating a new cluster. Also tested Ambari upgrade from 2.4.2 to 2.5
Thanks,
Sebastian Toader
e.org/r/54743/diff/
Testing
---
Unit tests:
Results :
Tests run: 4797, Failures: 0, Errors: 0, Skipped: 37
Manual testing:
Tested with creating a new cluster. Also tested Ambari upgrade from 2.4.2 to 2.5
Thanks,
Sebastian Toader
rs: 0, Skipped: 37
Manual testing:
Tested with creating a new cluster. Also tested Ambari upgrade from 2.4.2 to 2.5
Thanks,
Sebastian Toader
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54674/#review158894
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 12, 2016, 9:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54252/#review158524
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 2, 2016, 3:10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54476/#review158333
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 7, 2016, 3:10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54476/#review158326
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 7, 2016, 11:37
/logging/LogSearchDataRetrievalService.java
(line 292)
<https://reviews.apache.org/r/54476/#comment229100>
Can you add a unit test for this case?
- Sebastian Toader
On Dec. 7, 2016, 11:37 a.m., Miklos Gergely wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54377/#review158006
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 5, 2016, 5:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54364/#review157978
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 5, 2016, 9:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54318/#review157970
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 2, 2016, 8:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54264/#review157734
---
Ship it!
Ship It!
- Sebastian Toader
On Dec. 1, 2016, 11:45
.
ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java
(lines 88 - 90)
<https://reviews.apache.org/r/53943/#comment227413>
Why is this needed and where the 15 comes from?
- Sebastian Toader
On Nov. 25, 2016, 10:46 a.m., wang yaoxin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54064/#review156929
---
Ship it!
Ship It!
- Sebastian Toader
On Nov. 25, 2016, 10
> On Nov. 24, 2016, 4:01 p.m., Sebastian Toader wrote:
> >
Also can we test the following scenario?
1. Create a cluster using Blueprint and view.extract-after-cluster-config=true.
2. Stop Ambari once the cluster created and deployed.
3. Drop a new view jar into Ambari views archive
via the UI.
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
(line 1868)
<https://reviews.apache.org/r/54064/#comment227162>
'cluster created' might be confusing as views are deployed after cluster
configuration.
- Sebastian Toader
> On Nov. 22, 2016, 8:57 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java,
> > line 83
> > <https://reviews.apache.org/r/53959/diff/1/?file=1568079#file1568079line83&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53953/#review156566
---
Ship it!
Ship It!
- Sebastian Toader
On Nov. 22, 2016, 2:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53977/#review156556
---
Ship it!
Ship It!
- Sebastian Toader
On Nov. 22, 2016, 9:59
/quicklinks/Link.java
(line 55)
<https://reviews.apache.org/r/53953/#comment226747>
Shouldn't this new field be taken in account by ```mergeWithParent``` and
```isRemoved``` methods.
- Sebastian Toader
On Nov. 21, 2016, 5:31 p.m., Balázs Bence
/authorization/AmbariLdapAuthenticationProvider.java
(line 82)
<https://reviews.apache.org/r/53959/#comment226746>
Why is this logged as warn and not debug ?
- Sebastian Toader
On Nov. 21, 2016, 7:43 p.m., Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53959/#review156554
---
Ship it!
Ship It!
- Sebastian Toader
On Nov. 21, 2016, 7:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53855/#review156289
---
Ship it!
Ship It!
- Sebastian Toader
On Nov. 18, 2016, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53810/#review156062
---
Ship it!
Ship It!
- Sebastian Toader
On Nov. 16, 2016, 3:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53779/#review155906
---
Ship it!
Ship It!
- Sebastian Toader
On Nov. 15, 2016, 12
te_directory_archive
self.assertTrue(write_hash_sum_mock.called)
AssertionError: False is not true
Thanks,
Sebastian Toader
<https://reviews.apache.org/r/53576/#comment225550>
Add * to be consistent with the licensing header across all the src files.
- Sebastian Toader
On Nov. 9, 2016, 4:07 p.m., Attila Doroszlai wrote:
>
> ---
> This i
/configuration/Configuration.java
(lines 2459 - 2472)
<https://reviews.apache.org/r/53576/#comment225360>
The name of the property should be changed such as it clearly tells that
this is for topology tasks solely which is used in case of Blueprint
- Sebastian Toader
On Nov. 9, 2016,
tps://reviews.apache.org/r/53583/#comment225354>
Do we need to add the ```index.md``` file to the patch for review or not as
this is autogenerated from during build from the Markdowns?
- Sebastian Toader
On Nov. 8, 2016, 8:09 p.m., Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53477/#review155132
---
Ship it!
Ship It!
- Sebastian Toader
On Nov. 7, 2016, 2:54
ackage/scripts/service_check.py
(line 132)
<https://reviews.apache.org/r/53477/#comment224965>
Please add unit test to ensure that the curl command is invoked with
correct parameters.
- Sebastian Toader
On Nov. 7, 2016, 9:22 a.m., Attila
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53188/#review154532
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 29, 2016, 6:36
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53089/#review153547
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 21, 2016, 5:18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/#review153396
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 18, 2016, 8:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/#review152833
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 16, 2016, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52860/#review152786
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 14, 2016, 12
(line 359)
<https://reviews.apache.org/r/52691/#comment221768>
This could be an 'int' column and the values stored in it mapped to he
CommandExecutionType enum.
- Sebastian Toader
On Oct. 13, 2016, 5:50 p.m., Sand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52792/#review152462
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 12, 2016, 7:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52419/#review152155
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 11, 2016, 6:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52736/#review152126
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 11, 2016, 1:03
expected: but was:
DataStoreImplTest.testStore_update:357 expected: but was:
DataStoreImplTest.testStore_update_longStringValue:426
Expectation failure on verify:
DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
These failure are not related to this change.
Thanks,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52630/#review151788
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 7, 2016, 3:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52629/#review151785
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 7, 2016, 3:18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52602/#review151765
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 6, 2016, 10:48
/internal/BlueprintConfigurationProcessor.java
(line 59)
<https://reviews.apache.org/r/52602/#comment220135>
Can you add some unit test for this change to ensure that none introduces a
regression by mistake?
- Sebastian Toader
On Oct. 6, 2016, 4:05 p.m., Vitalyi Brodetskyi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52551/#review151686
---
Ship it!
Ship It!
- Sebastian Toader
On Oct. 5, 2016, 2:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52266/#review150699
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 26, 2016, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52264/#review150529
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 26, 2016, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52123/#review150378
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 22, 2016, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52163/#review150012
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 22, 2016, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52038/#review149798
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 19, 2016, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52043/#review149797
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 19, 2016, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51906/#review149461
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 16, 2016, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51969/#review149359
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 16, 2016, 11
-START/scripts/shared_initialization.py
(line 188)
<https://reviews.apache.org/r/51906/#comment216768>
Why is this needed ? There is already a action="create_on_execute"
- Sebastian Toader
On Sept. 16, 2016, 4:57 p.m., Attila
0.6/hooks/before-START/scripts/shared_initialization.py
(lines 107 - 116)
<https://reviews.apache.org/r/51906/#comment216712>
Factor this out into a separate method
- Sebastian Toader
On Sept. 15, 2016, 1:45 p.m., Attila Doroszlai wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51892/#review149047
---
Ship it!
Ship It!
- Sebastian Toader
On szept. 14, 2016, 5
al Memory: 73M/799M
[INFO] --------
Thanks,
Sebastian Toader
09:56:49 CEST 2016
[INFO] Final Memory: 73M/799M
[INFO] --------
Thanks,
Sebastian Toader
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51838/#review148757
---
On Sept. 14, 2016, 1:27 p.m., Sebastian Toader wrote:
>
>
[INFO] Total time: 1:43.849s
[INFO] Finished at: Tue Sep 13 09:56:49 CEST 2016
[INFO] Final Memory: 73M/799M
[INFO] --------
Thanks,
Sebastian Toader
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review148872
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 14, 2016, 8
/request/eventcreator/RequestEventCreator.java
(line 90)
<https://reviews.apache.org/r/51843/#comment216206>
Please add a unit test for this change.
- Sebastian Toader
On Sept. 13, 2016, 2:25 p.m., wang yaoxin wrote:
>
> ---
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 1:43.849s
[INFO] Finished at: Tue Sep 13 09:56:49 CEST 2016
[INFO] Final Memory: 73M/799M
[INFO] --------
Thanks,
Sebastian Toader
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51811/#review148510
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 12, 2016, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51801/#review148480
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 12, 2016, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51725/#review148317
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 9, 2016, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51632/#review147797
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 5, 2016, 6:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51597/#review147796
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 2, 2016, 2:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147643
---
Ship it!
Ship It!
- Sebastian Toader
On Sept. 1, 2016, 3:36
/common-services/MICROSOFT_R/8.0.0/service_advisor.py
(line 37)
<https://reviews.apache.org/r/51575/#comment214749>
Is there any unit test framework for m-pack? If so please add unit tests
for this class.
- Sebastian Toader
On Sept. 1, 2016, 3:36 p.m., Attila Doroszlai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51430/#review146797
---
Ship it!
Ship It!
- Sebastian Toader
On Aug. 25, 2016, 6:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51370/#review146703
---
Ship it!
Ship It!
- Sebastian Toader
On Aug. 24, 2016, 5:34
/ambari.properties b8e41b7
ambari-server/src/main/python/ambari_server/serverSetup.py d80c25a
Diff: https://reviews.apache.org/r/51364/diff/
Testing
---
1. Manual testing with Centos6/RHEL6.
2. Unit tests:
Three tests failed but those are unrelated to this change.
Thanks,
Sebastian Toader
/ambari.properties b8e41b7
ambari-server/src/main/python/ambari_server/serverSetup.py d80c25a
Diff: https://reviews.apache.org/r/51364/diff/
Testing
---
1. Manual testing with Centos6/RHEL6.
2. Unit tests:
Three tests failed but those are unrelated to this change.
Thanks,
Sebastian Toader
/main/python/ambari_server/serverSetup.py d80c25a
Diff: https://reviews.apache.org/r/51364/diff/
Testing
---
1. Manual testing with Centos6/RHEL6.
2. Unit tests:
Three tests failed but those are unrelated to this change.
Thanks,
Sebastian Toader
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51203/#review146170
---
Ship it!
Ship It!
- Sebastian Toader
On Aug. 18, 2016, 2:40
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50840/#review144901
---
Ship it!
Ship It!
- Sebastian Toader
On Aug. 5, 2016, 11:26
run: 4583, Failures: 0, Errors: 0, Skipped: 34
Thanks,
Sebastian Toader
d.
Diffs
-
ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml
e571067
Diff: https://reviews.apache.org/r/50786/diff/
Testing
---
Manual testing.
Thanks,
Sebastian Toader
t's make the message more explicit that the host is removed from
available hosts.
- Sebastian Toader
On Aug. 3, 2016, 4:47 p.m., Laszlo Puskas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
/actionmanager/HostRoleCommand.java
(lines 47 - 57)
<https://reviews.apache.org/r/50742/#comment210636>
Can you provide a description of the use case this patch implements?
- Sebastian Toader
On Aug. 3, 2016, 12:04 p.m., wang yaoxin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50653/#review144587
---
Ship it!
Ship It!
- Sebastian Toader
On Aug. 3, 2016, 3:15
> On Aug. 2, 2016, 6:58 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java,
> > line 51
> > <https://reviews.apache.org/r/50653/diff/1/?file=1459056#file1459056line51>
> >
> >
> On Aug. 2, 2016, 6:58 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java,
> > line 51
> > <https://reviews.apache.org/r/50653/diff/1/?file=1459056#file1459056line51>
> >
> >
?
If it doesn't than go ahead and change for X to Z
- Sebastian Toader
On Aug. 1, 2016, 12:23 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
301 - 400 of 546 matches
Mail list logo
