Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase

2016-05-20 Thread Dmytro Sen
, right after the cache is filled up. - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47595/#review134093 ---------

Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase

2016-05-20 Thread Dmytro Sen
-site.xml a7fd9c8 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 8f369f7 Diff: https://reviews.apache.org/r/47595/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 47651: Required empty config is present after Upgrade from 2.1.1 to 2.4.0.0 [HDFS: keyserver_port]

2016-05-20 Thread Dmytro Sen
/apache/ambari/server/upgrade/UpgradeCatalog240.java 729b577 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 20fa50f Diff: https://reviews.apache.org/r/47651/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names

2016-05-20 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47531/#review134164 --- Ship it! Ship It! - Dmytro Sen On Май 20, 2016, 3:27 п.п

Re: Review Request 47701: AMBARI-16642: After enabling HTTPS for YARN, NodeManager JVM Metrics on YARN Heatmaps show NA.

2016-05-23 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47701/#review134322 --- Ship it! Ship It! - Dmytro Sen On Май 23, 2016, 5:59 д.п

Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase

2016-05-23 Thread Dmytro Sen
-site.xml e5758bf ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 8f369f7 Diff: https://reviews.apache.org/r/47595/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-23 Thread Dmytro Sen
/sink/timeline/cache/TimelineMetricsCacheTest.java 18d973c Diff: https://reviews.apache.org/r/47730/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47734: AMBARI-15898 : Grafana fails to start when using custom data directory

2016-05-23 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47734/#review134389 --- Ship it! Ship It! - Dmytro Sen On Май 23, 2016, 5:10 п.п

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-24 Thread Dmytro Sen
enerated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review134370 ------- On Май 23, 2016, 3:48 п.п., Dmytro Sen wrote: > > --- > This is an automati

Review Request 47770: yarn statrtup is failing in HA cluster in wireencypted cluster

2016-05-24 Thread Dmytro Sen
Diff: https://reviews.apache.org/r/47770/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-24 Thread Dmytro Sen
faced a > > problem here before. Can we make this shaded ? > > Dmytro Sen wrote: > Do you mean use https://maven.apache.org/plugins/maven-shade-plugin ? I > would propose to use same 14.0.1 for ambari-metrics-common > > Sid Wagle wrote: > Yes but the parent had

Re: Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

2016-05-26 Thread Dmytro Sen
Get_num_ops ? - Dmytro Sen On Май 25, 2016, 10:04 п.п., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 47879: AMBARI-16807: After enabling HTTPS for HDFS, Data Node JVM Metrics on HDFS Heatmaps show NA

2016-05-26 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47879/#review134989 --- Ship it! Ship It! - Dmytro Sen On Май 26, 2016, 10:27 д.п

Re: Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

2016-05-27 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47856/#review135195 --- Ship it! Ship It! - Dmytro Sen On Май 26, 2016, 7:16 п.п

Review Request 47953: Add ability to query all hosts using hostname=% through AMS API.

2016-05-27 Thread Dmytro Sen
://reviews.apache.org/r/47953/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47953: Add ability to query all hosts using hostname=% through AMS API.

2016-05-27 Thread Dmytro Sen
SUCCESS [02:47 min] [INFO] [INFO] BUILD SUCCESS Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-27 Thread Dmytro Sen
/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-31 Thread Dmytro Sen
://reviews.apache.org/r/47730/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-31 Thread Dmytro Sen
-server/pom.xml 20d3fab Diff: https://reviews.apache.org/r/47730/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 48079: Capture user based metrics for Namenode fair call queue.

2016-05-31 Thread Dmytro Sen
--- Unit tests passed. + Manual testing Thanks, Dmytro Sen

Re: Review Request 48079: Capture user based metrics for Namenode fair call queue.

2016-05-31 Thread Dmytro Sen
] [INFO] BUILD SUCCESS Thanks, Dmytro Sen

Re: Review Request 48087: AMBARI-16969 : Provide ability in AMS to filter tracked metrics through a whitelist metic file.

2016-05-31 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48087/#review135772 --- Ship it! Ship It! - Dmytro Sen On Май 31, 2016, 7:25 п.п

Review Request 48121: YARN default configs are invalid

2016-06-01 Thread Dmytro Sen
fd2 Diff: https://reviews.apache.org/r/48121/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48121: YARN default configs are invalid

2016-06-01 Thread Dmytro Sen
r/internal/BlueprintConfigurationProcessorTest.java ec04fd2 Diff: https://reviews.apache.org/r/48121/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48139: Required empty config is present after Upgrade from 2.1.2.1 to 2.4.0.0 for HIVE and HBASE

2016-06-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48139/#review135828 --- Ship it! Ship It! - Dmytro Sen On Июнь 1, 2016, 6:06 п.п

Re: Review Request 47879: AMBARI-16807: After enabling HTTPS for HDFS, Data Node JVM Metrics on HDFS Heatmaps show NA

2016-06-02 Thread Dmytro Sen
> On Май 26, 2016, 3:11 п.п., Dmytro Sen wrote: > > Ship It! > > Qin Liu wrote: > Thank you so much Dmytro! > > Qin Liu wrote: > Hi Sid, > Could you please review the patch at your earliest convenience? Thank you > in advance! > > Qin Liu wr

Re: Review Request 48121: YARN default configs are invalid

2016-06-03 Thread Dmytro Sen
ation/yarn-site.xml 9777ee4 ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration/yarn-site.xml c8a588c Diff: https://reviews.apache.org/r/48121/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48121: YARN default configs are invalid

2016-06-03 Thread Dmytro Sen
#review135962 ----------- On Июнь 3, 2016, 10:43 д.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48121

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Dmytro Sen
-server/pom.xml 20d3fab Diff: https://reviews.apache.org/r/47730/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Dmytro Sen
2fbb1e1 ambari-server/pom.xml 20d3fab Diff: https://reviews.apache.org/r/47730/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Dmytro Sen
ForTesting.class - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review136064 --- On Июнь 3, 2016, 1:54 п.п., Dmytro Se

Re: Review Request 48283: Namenode failed to start while installing a cluster from UI

2016-06-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48283/#review136274 --- Ship it! Ship It! - Dmytro Sen On Июнь 6, 2016, 3:31 п.п

Re: Review Request 48282: YARN service check fails if there is no queue named "default"

2016-06-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48282/#review136282 --- Ship it! Ship It! - Dmytro Sen On Июнь 6, 2016, 3:18 п.п

Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48262/#review136288 --- Ship it! Ship It! - Dmytro Sen On Июнь 6, 2016, 6:26 д.п

Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Dmytro Sen
> On Июнь 6, 2016, 4:32 п.п., Dmytro Sen wrote: > > Ship It! Committed to trunk and branch-2.4. Please close this review board - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Dmytro Sen
st.java 8b1a9a6 Diff: https://reviews.apache.org/r/48321/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Dmytro Sen
ari/server/controller/internal/BlueprintConfigurationProcessorTest.java 8b1a9a6 Diff: https://reviews.apache.org/r/48321/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Dmytro Sen
d AMS HA - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48321/#review136457 --- On Июнь 7, 2016, 8:12 д.п., Dmytro Sen wrote: > > -

Re: Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Dmytro Sen
ari/server/controller/internal/BlueprintConfigurationProcessorTest.java 8b1a9a6 Diff: https://reviews.apache.org/r/48321/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 48402: ATS needs a dynamic dependency on Tez and Spark

2016-06-08 Thread Dmytro Sen
o.xml c6ee13d Diff: https://reviews.apache.org/r/48402/diff/ Testing --- Unit tests passed. Thanks, Dmytro Sen

Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Dmytro Sen
ternal/BlueprintConfigurationProcessor.java de70a2c ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java ad8d4f9 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 9ec0a09 Diff: https://reviews.apache.org/r/48494/diff/ Testing --- Unit tests and manual tests passed Thanks, Dmytro Sen

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Dmytro Sen
the server is least loaded. - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review136823 ------- On Июнь 9, 2016, 3:23 п.п., Dmytro Sen wrote: > > ---

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Dmytro Sen
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review136832 ----------- On Июнь 9, 2016, 3:23 п.п., Dmytro Sen wrote: > > --- > This

Re: Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48508/#review136973 --- Ship it! Ship It! - Dmytro Sen On Июнь 10, 2016, полночь

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-10 Thread Dmytro Sen
> > > > Please consider cyclomatic complexity in this method. > > Dmytro Sen wrote: > What is wrong with it ? The loop body is executed only once for every > property. > Moreover, this method is executed only once during ambari server > lifecycle, w

Review Request 48555: Kerberization of a cluster deletes ATS service

2016-06-10 Thread Dmytro Sen
/services/YARN/metainfo.xml 2c3afb0 Diff: https://reviews.apache.org/r/48555/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48641: yarncli throws log4j error "FileNotFoundException : /grid/0/log/yarn/hrt_qa/rm-audit.log"

2016-06-13 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48641/#review137305 --- Ship it! Ship It! - Dmytro Sen On Июнь 13, 2016, 2:31 п.п

Re: Review Request 48654: Upgrading Ambari Causes Alert Fields Not To Save Thresholds

2016-06-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48654/#review137478 --- Ship it! Ship It! - Dmytro Sen On Июнь 14, 2016, 10:41 д.п

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-14 Thread Dmytro Sen
/server/controller/internal/TrimmingStrategy.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java cda8fb8 Diff: https://reviews.apache.org/r/48494/diff/ Testing --- Unit tests and manual tests passed Thanks, Dmytro Sen

Re: Review Request 48706: 'ambari-server --version' command does not show build number

2016-06-15 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48706/#review137693 --- Ship it! Ship It! - Dmytro Sen On Июнь 15, 2016, 8:43 д.п

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Dmytro Sen
/server/controller/internal/TrimmingStrategy.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java cda8fb8 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java e70af3e Diff: https://reviews.apache.org/r/48494/diff/ Testing --- Unit tests and manual tests passed Thanks, Dmytro Sen

Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-15 Thread Dmytro Sen
Thanks, Dmytro Sen

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Dmytro Sen
/server/controller/internal/TrimmingStrategy.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java cda8fb8 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java e70af3e Diff: https://reviews.apache.org/r/48494/diff/ Testing --- Unit tests and manual tests passed Thanks, Dmytro Sen

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48729/#review137985 ------- On Июнь 15, 2016, 1:35 п.п., Dmytro Sen wrote: > > ---

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
g/r/48729/#review137985 --- On Июнь 15, 2016, 1:35 п.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
e some way to check if this property was set in the > > Blueprint, or is relying on the stack defaults. > > > > I realize that this change is not really a part of this current patch, > > but this looks like something that needs some investigation, and

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
e some way to check if this property was set in the > > Blueprint, or is relying on the stack defaults. > > > > I realize that this change is not really a part of this current patch, > > but this looks like something that needs some investigation, and

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
e some way to check if this property was set in the > > Blueprint, or is relying on the stack defaults. > > > > I realize that this change is not really a part of this current patch, > > but this looks like something that needs some investigation, and

Re: Review Request 48852: Ambari displays a warning about config values not being at optimal values right after a clean install with no customization

2016-06-17 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48852/#review138220 --- Ship it! Ship It! - Dmytro Sen On Июнь 17, 2016, 1:47 п.п

Review Request 48858: Ambari Metrics service check failed exceed timeout

2016-06-17 Thread Dmytro Sen
/ Diffs - ambari-metrics/ambari-metrics-timelineservice/pom.xml 2fefede Diff: https://reviews.apache.org/r/48858/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48985: AMBARI-17325 : Ambari Metrics service check failed exceed timeout due to invalid Phoenix JARS

2016-06-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48985/#review138803 --- Ship it! Ship It! - Dmytro Sen On Июнь 21, 2016, 1:41 д.п

Re: Review Request 49018: Downloading sqoop client files throws error

2016-06-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49018/#review138810 --- Ship it! Ship It! - Dmytro Sen On Июнь 21, 2016, 9:55 д.п

Re: Review Request 48985: AMBARI-17325 : Ambari Metrics service check failed exceed timeout due to invalid Phoenix JARS

2016-06-21 Thread Dmytro Sen
> On Июнь 21, 2016, 8:44 д.п., Dmytro Sen wrote: > > Ship It! committed to trunk and branch-2.4 - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48985/#rev

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-21 Thread Dmytro Sen
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review136067 --- On Июнь 3, 2016, 3:15 п.п., Dmytro Sen wrote: > > -

Review Request 49028: Alert mapreduce_history_server_process fails after enabling SSL

2016-06-21 Thread Dmytro Sen
passed Thanks, Dmytro Sen

Review Request 49030: Ambari agent log contains failures for AMS status commands

2016-06-21 Thread Dmytro Sen
- [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1:08.949s [INFO] Finished at: Tue Jun 21 18:52:10 EEST 2016 [INFO] Final Memory: 70M/948M Thanks, Dmytro Sen

Re: Review Request 49032: Hive metastore failed to start

2016-06-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49032/#review138866 --- Ship it! Ship It! - Dmytro Sen On Июнь 21, 2016, 4:28 п.п

Re: Review Request 49080: Tez install failed

2016-06-22 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49080/#review139052 --- Ship it! Ship It! - Dmytro Sen On Июнь 22, 2016, 11:12 д.п

Review Request 49142: Performance issues with ambari metrics (and Metrics Collector keeps going down)

2016-06-23 Thread Dmytro Sen
/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 49153: RU/EU Install packages fails on non-root

2016-06-23 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49153/#review139252 --- Ship it! Ship It! - Dmytro Sen On Июнь 23, 2016, 1:56 п.п

Review Request 49199: Falcon client install failed

2016-06-24 Thread Dmytro Sen
.xml 985e7f4 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 2bdaa48 ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/configuration/falcon-client.properties.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/metainfo.xml 2e444b1 ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/params.py 41ecafa Diff: https://reviews.apache.org/r/49199/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 49205: Fix serviceconfig NPE in db consistency checker

2016-06-24 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49205/#review139380 --- Ship it! Ship It! - Dmytro Sen On Июнь 24, 2016, 4:32 п.п

Re: Review Request 49263: Datanode start fails with umask 027 on ambari-server node

2016-06-27 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49263/#review139562 --- Ship it! Ship It! - Dmytro Sen On Июнь 27, 2016, 12:42 п.п

Re: Review Request 49372: Ambari try to find old jdbc etc despite reset and resetuping with another DB

2016-06-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49372/#review139989 --- Ship it! Ship It! - Dmytro Sen On Июнь 29, 2016, 2:24 п.п

Re: Review Request 49454: Atlas empty required config is present after Upgrade from 2.2.0.0 to 2.4.0.0

2016-06-30 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49454/#review140174 --- Ship it! Ship It! - Dmytro Sen On Июнь 30, 2016, 3:23 п.п

Re: Review Request 49504: StackAdvisor fix for Oracle 12C and Add message if user forgot to set jdbc

2016-07-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49504/#review140331 --- Ship it! Ship It! - Dmytro Sen On Июль 1, 2016, 10:51 д.п

Re: Review Request 48852: Ambari displays a warning about config values not being at optimal values right after a clean install with no customization

2016-07-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48852/#review140347 --- Ship it! Ship It! - Dmytro Sen On Июнь 17, 2016, 2:54 п.п

Review Request 49513: Ambari API for api/v1/clusters/?fields=hosts/* does not return the metrics information

2016-07-01 Thread Dmytro Sen
--- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 49513: Ambari API for api/v1/clusters/?fields=hosts/* does not return the metrics information

2016-07-01 Thread Dmytro Sen
://reviews.apache.org/r/49513/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 49513: Ambari API for api/v1/clusters/?fields=hosts/* does not return the metrics information

2016-07-01 Thread Dmytro Sen
---------- On Июль 1, 2016, 3:26 п.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49513/ >

Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Dmytro Sen
://reviews.apache.org/r/49514/diff/ Testing --- Unit testst passed Thanks, Dmytro Sen

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Dmytro Sen
catch, however, why not look for "._" and replace that only if > > needed. There is no change here. It's a copy of previous StormTimelineMetricsSink.java - Dmytro --- This is an automatically gen

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Dmytro Sen
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49514/#review140459 ----------- On Июль 1, 2016, 3:32 п.п., Dmytro Sen wrote: > >

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Dmytro Sen
--- Unit testst passed Thanks, Dmytro Sen

Review Request 49589: Quicklinks combobox is not present for Oozie

2016-07-04 Thread Dmytro Sen
://reviews.apache.org/r/49589/diff/ Testing --- Unit tests passed + manual testing Thanks, Dmytro Sen

Re: Review Request 49590: While changing NN, DN directories from UI, proper warning should be present for invalid values

2016-07-04 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49590/#review140653 --- Ship it! Ship It! - Dmytro Sen On Июль 4, 2016, 1:11 п.п

Review Request 49594: 'Restart all' services fails due to dependency on other service components

2016-07-04 Thread Dmytro Sen
urces/stacks/HDP/2.1/role_command_order.json 3adf5e1 Diff: https://reviews.apache.org/r/49594/diff/ Testing --- Manual unit tests Thanks, Dmytro Sen

Re: Review Request 49594: 'Restart all' services fails due to dependency on other service components

2016-07-05 Thread Dmytro Sen
ply, visit: https://reviews.apache.org/r/49594/#review140664 ----------- On Июль 4, 2016, 2:52 п.п., Dmytro Sen wrote: > > --- > This is an automatically ge

Re: Review Request 49702: HIVE_SERVER_INTERACTIVE STOP failed with error "Python script has been killed due to timeout after waiting 900 secs"

2016-07-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49702/#review140979 --- Ship it! Ship It! - Dmytro Sen On Июль 6, 2016, 11:37 д.п

Re: Review Request 49590: While changing NN, DN directories from UI, proper warning should be present for invalid values

2016-07-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49590/#review140993 --- Ship it! Ship It! - Dmytro Sen On Июль 6, 2016, 1:43 п.п

Re: Review Request 49749: Ambari server start fails after upgrade due to missing atlas-application configs

2016-07-07 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49749/#review141152 --- Ship it! Ship It! - Dmytro Sen On Июль 7, 2016, 12:08 п.п

Re: Review Request 49762: Oozie fails to start when Falcon is not on the same host

2016-07-07 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49762/#review141173 --- Ship it! Ship It! - Dmytro Sen On Июль 7, 2016, 3:43 п.п

Re: Review Request 49801: Syntax error in 'setup_ranger_xml.py' logging.

2016-07-08 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49801/#review141267 --- Ship it! Ship It! - Dmytro Sen On Июль 8, 2016, 10:30 д.п

Re: Review Request 49803: Kerberized Solr support for Atlas

2016-07-08 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49803/#review141268 --- Ship it! Ship It! - Dmytro Sen On Июль 8, 2016, 10:32 д.п

Review Request 49805: Ambari server schema upgrade failed from 2.1.1 with ORA-12516 error

2016-07-08 Thread Dmytro Sen
error, upgrade failed com.google.inject.ProvisionException: Guice provision errors: Diffs - ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java b10d32a Diff: https://reviews.apache.org/r/49805/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 49808: Host service mapping has incorrect default mapping

2016-07-11 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49808/#review141701 --- Ship it! Ship It! - Dmytro Sen On Июль 11, 2016, 3:29 п.п

Review Request 49902: Storm nimbus server fails to come up with CNF backtype.storm.metric.IClusterReporter error

2016-07-11 Thread Dmytro Sen
Thanks, Dmytro Sen

Re: Review Request 49902: Storm nimbus server fails to come up with CNF backtype.storm.metric.IClusterReporter error

2016-07-11 Thread Dmytro Sen
ain/resources/common-services/STORM/0.9.1/package/scripts/storm.py > bce71ca > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py > ef2c536 > > Diff: https://reviews.apache.org/r/49902/diff/ > > > Testing > --- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >

Re: Review Request 49902: Storm nimbus server fails to come up with CNF backtype.storm.metric.IClusterReporter error

2016-07-12 Thread Dmytro Sen
--- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 49982: Syntax error in ambari-server/src/main/resources/custom_actions/scripts/check_host.py

2016-07-13 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49982/#review142037 --- Ship it! Ship It! - Dmytro Sen On Июль 13, 2016, 8:55 д.п

<    1   2   3   4   5   6   >