/script/script.py
(lines 369 - 372)
<https://reviews.apache.org/r/50407/#comment209274>
Is there any reason we shouldn't just explicitely trust
`commandParams/version` if it's supplied? Does
`hostLevelParams/package_version` take precedence?
- Jonathan Hurley
On July 25, 2016,
ted)
---
Added unit tests
Thanks,
Jonathan Hurley
/upgrade/TaskWrapperBuilder.java
(lines 59 - 61)
<https://reviews.apache.org/r/50461/#comment209434>
Won't all CONFIGURE tasks have hosts since they run on the Ambari Server?
- Jonathan Hurley
On July 26, 2016, 4:17 p.m., Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50047/#review143607
---
Ship it!
Ship It!
- Jonathan Hurley
On July 26, 2016, 2:15
> On July 26, 2016, 4:36 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java,
> > lines 59-61
> > <https://reviews.apache.org/r/50461/diff/1/?file=1454273#file1454273line59>
> >
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50461/#review143629
---
Ship it!
Ship It!
- Jonathan Hurley
On July 26, 2016, 4:17
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50047/
> ---
>
> (Updated July 26, 2016, 2:15 p.m.)
>
>
> Review request for Amb
ckage/alerts/alert_ha_namenode_health.py
00d1421
Diff: https://reviews.apache.org/r/50526/diff/
Testing
---
Live testing on a cluster.
Thanks,
Jonathan Hurley
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/50526/#review143789
-------
On July 27, 2016, 3:06 p.m., Jonathan Hurley wrote:
>
> ---
>
/apache/ambari/server/stack/StackManagerTest.java
ee0a951
Diff: https://reviews.apache.org/r/50567/diff/
Testing
---
mvn clean test
Thanks,
Jonathan Hurley
[INFO]
[INFO] Total time: 35:09 min
[INFO] Finished at: 2016-07-28T10:21:17-04:00
[INFO] Final Memory: 38M/703M
[INFO]
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50539/#review143947
---
Ship it!
Ship It!
- Jonathan Hurley
On July 27, 2016, 7:06
> On July 28, 2016, 11:58 a.m., Jonathan Hurley wrote:
> > Ship It!
After other comments are resolved.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50539/#rev
ommon-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
(line 74)
<https://reviews.apache.org/r/50565/#comment209895>
I don't think you need the `upgrade_type is not None` since you have an
equality check right after it.
- Jonathan Hurley
On July 28,
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50532/
> ---
>
> (Updated July 27, 2016, 5:21 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez,
s is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50539/
> ---
>
> (Updated July 27, 2016, 7:06 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko,
> Jonathan
/utils/HostUtils.java
(lines 44 - 46)
<https://reviews.apache.org/r/50577/#comment209923>
Could you instead use Guava's `InternetDomainName.isValid(String)` for this?
- Jonathan Hurley
On July 28, 2016, 2:09 p.m., Robert
> On July 28, 2016, 3:38 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/HostUtils.java,
> > lines 44-46
> > <https://reviews.apache.org/r/50577/diff/1/?file=1456787#file1456787line44>
> >
>
y contains the correct HadoopMetrics2Reporter
properties`
- Jonathan Hurley
On July 28, 2016, 7:07 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
36/diff/
Testing
---
PENDING UNIT TESTS
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50646/#review144323
---
Ship it!
Ship It!
- Jonathan Hurley
On July 31, 2016, 8:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50647/#review144325
---
Ship it!
Ship It!
- Jonathan Hurley
On July 31, 2016, 10
he
DB.
- Jonathan Hurley
On Aug. 1, 2016, 12:16 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
s OK. But
if a heartbeat from an agent can cause problems as well, then there is still a
slight chance that the timing here could still reproduce the bug.
- Jonathan Hurley
On Aug. 4, 2016, 11:22 a.m., Laszlo Puskas wrote:
>
> ---
>
1b2e9
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
12ab568
Diff: https://reviews.apache.org/r/50865/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
/diff/
Testing (updated)
---
Added unit tests.
Thanks,
Jonathan Hurley
bari 2.4.0 on:
- MySQL
- Postgres
- Oracle
Still working on SQL Server, but figure I'd get the review up while I was
setting up yet another environment.
Thanks,
Jonathan Hurley
orm supports it coming after
the NULL constraint. Once again, Oracle sucks.
- Jonathan Hurley
On Aug. 7, 2016, 4:10 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
677M
[INFO]
Thanks,
Jonathan Hurley
677M
[INFO]
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50801/#review145222
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 8, 2016, 3:09
could use a null check for not
specified. Or, we could use a new type of Object under the hood as well to
store this value.
But I think we need to use the not-specified logic here instead of the
"false" logic.
- Jonathan Hurley
On Aug. 8, 2016, 7:34 p.m., Alej
the simpler constructor for ConfigurationResponse which takes a
Config instance?
- Jonathan Hurley
On Aug. 8, 2016, 3:10 a.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
/nonrolling-upgrade-2.5.xml
0044f11
Diff: https://reviews.apache.org/r/50930/diff/
Testing
---
Ran an EU from HDP 2.4 to 2.5 and verified Ranger/Ranger KMS were in the
service checks.
Thanks,
Jonathan Hurley
/nonrolling-upgrade-2.4.xml
<https://reviews.apache.org/r/50930/#comment211399>
Ranger KMS didn't exist in HDP 2.2; the other upgrade packs don't mention
it. This seemed like a copy/paste error that it was in here.
- Jonathan Hurley
On Aug. 9, 2016, 3:41 p.m., Jonat
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50930/#review145248
-------
On Aug. 9, 2016, 3:41 p.m., Jonathan Hurley wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50886/#review145334
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 9, 2016, 6:45
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50953/#review145354
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 10, 2016, 12:15
>
> (Updated Aug. 9, 2016, 9:22 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko,
> Jonathan Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe.
>
>
> Bugs: AMBARI-18070
> https://issues.ap
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/#review145394
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 10, 2016, 2:25
ews.apache.org/r/50963/#comment211680>
None of this is actually formatted and it's hard to read in MD.
- Jonathan Hurley
On Aug. 10, 2016, 2:31 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50988/#review145547
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 11, 2016, 11:41
-services/HDFS/2.1.0.2.0/package/alerts/alert_upgrade_finalized.py
(line 112)
<https://reviews.apache.org/r/50990/#comment211828>
Is it possible for the NN address not to have a port defined (and use a
default port?)
- Jonathan Hurley
On Aug. 11, 2016, 12:32 p.m., Dmitro Lisnichenko
grade/UpgradeTest.java
a1fd32d
ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java
89df7fb
Diff: https://reviews.apache.org/r/51004/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
Diff: https://reviews.apache.org/r/51004/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
he new class which I added to manage configurations better.
- Jonathan Hurley
On Aug. 11, 2016, 3:47 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50963/#review145559
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 11, 2016, 5:03
ished at: 2016-08-11T18:11:29-04:00
[INFO] Final Memory: 35M/601M
[INFO]
Thanks,
Jonathan Hurley
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51004/#review145622
---
On Aug. 12, 2016, 9:28 a.m., Jonathan Hurley wrote:
>
> ---
.java
2702fdf
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/LdapPerformanceTest.java
dbf28be
Diff: https://reviews.apache.org/r/51128/diff/
Testing
---
mvn clean test
Thanks,
Jonathan Hurley
but unfortunately, Markdown
and velocity have syntax compatibility problems; it was easier to just do a
simple string replace on a token.
- Jonathan Hurley
On Aug. 16, 2016, 12:01 a.m., Jonathan Hurley wrote:
>
> ---
> This is an aut
---------
On Aug. 16, 2016, 12:01 a.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51128/
>
ain/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
37e2426
Diff: https://reviews.apache.org/r/51179/diff/
Testing
---
--
Total run:1120
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51222/#review146142
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 18, 2016, 5:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51203/#review146143
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 18, 2016, 8:40
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/StormUpgradeKerberosDescriptorConfig.java
(line 140)
<https://reviews.apache.org/r/51241/#comment212571>
StringUtils.isBlank()/isNotBlank()
- Jonathan Hurley
On Aug. 19, 2016, 10:43 a.m
d collection
hostsType.hosts = order;
builder.add(context, hostsType, service.serviceName,
svc.isClientOnlyService(), pc, null);
}
break;
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51245/#review146199
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 19, 2016, 1:58
henko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51241/
> -------
>
> (Updated Aug. 19, 2016, 12:54 p.m
.
- Jonathan Hurley
On Aug. 19, 2016, 5:55 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
ces/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql (line
28)
<https://reviews.apache.org/r/51284/#comment212767>
Can you verify that this will ensure that commands run as the Ambari DB
user are automatically scoped to the `ambari` schema?
ambari-server/src/test/python/unitTests.py (lines 2
> On Aug. 22, 2016, 11:32 a.m., Jonathan Hurley wrote:
> > Looks good once the prior comments are resolved.
>
> Anita Jebaraj wrote:
> Thank you, I have created a jira to move the code once the upgrade
> catalog is identified for version 2.5 (AMBARI-18229). I have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51304/#review146444
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 22, 2016, 6:20
itely not very clean with methods
that say "Don't use me unless you're a unit test". With that said, the changes
make this a bit better. The inheritence of this field is bound to get messed up
in the future.
- Jonathan Hurley
On Aug. 22, 2016, 2:25 p.m.,
erver/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
5a431aa
Diff: https://reviews.apache.org/r/51337/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
e NameNode {namenode_id} is not listed as Active or
Standby, waiting...")
```
- Jonathan Hurley
On Aug. 23, 2016, 12:09 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically genera
restart.
Diffs (updated)
-
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
5a431aa
Diff: https://reviews.apache.org/r/51337/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
ed a full EU & RU HA UPGRADE/DOWNGRADE from 2.3 to
2.5
---
Total run:1123
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51370/#review146670
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 24, 2016, 11:34
/stacks/HDP/2.5/services/ATLAS/metainfo.xml
84e8e46
Diff: https://reviews.apache.org/r/51383/diff/
Testing
---
Installed Atlas on HDP 2.5 and observed a version get populated.
Thanks,
Jonathan Hurley
e.py
63d72aa
Diff: https://reviews.apache.org/r/51430/diff/
Testing
---
Verified the UI Wizard completes now.
Writing a new test to cover the change ...
Thanks,
Jonathan Hurley
/ambari/server/orm/entities/HostVersionEntity.java
(line 38)
<https://reviews.apache.org/r/51386/#comment213466>
Can you give this UC annotation the same name used in the SQL: UQ_host_repo
- Jonathan Hurley
On Aug. 24, 2016, 4:21 p.m., Nate Cole
Wizard completes now.
--
Total run:1124
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51386/#review146837
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 25, 2016, 2:54
er.java
(line 65)
<https://reviews.apache.org/r/51460/#comment213914>
Any reason this needs to be concurrent? I wouldn't expect other threads
reading from this while it's being populated.
- Jonathan Hurley
On Aug. 26, 2016, 11:41 a.m., Nate Cole wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51284/#review147133
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 25, 2016, 8:49
w unit test was written which reproduced the problem, passing once the
patch was complete.
Thanks,
Jonathan Hurley
so ID is OK to use when it exists.
Alerts get compared to frequently though, so I wanted to ensure that if we
didn't need to compare other stuff, we don't.
- Jonathan Hurley
On Aug. 29, 2016, 12:54 p.m., Jonathan Hurley wrote:
>
> -
D SUCCESS
[INFO]
[INFO] Total time: 34:07 min
[INFO] Finished at: 2016-08-29T14:23:54-04:00
[INFO] Final Memory: 38M/684M
[INFO] ----
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51550/#review147427
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 31, 2016, 4:08
/DatabaseConsistencyCheckHelper.java
(line 549)
<https://reviews.apache.org/r/51579/#comment214880>
I don't think that this situation should prevent Ambari from starting up,
however I do think we should at least log it.
- Jonathan Hurley
On Sept. 1, 2016, 3:05 p.m., Vitalyi Brode
/AmbariCustomCommandExecutionHelper.java
(lines 472 - 477)
<https://reviews.apache.org/r/51597/#comment214881>
I'm curious if we should also try to catch this in the
ServiceComponentHost; don't let it's state move to STARTED if it knows it's a
client.
- Jonathan Hu
tates": ["OK", "WARNING"]
"notification_type": "FOO",
"groups": [1,2,3]
}
}
```
This is also accomplished through the Web Client when created/editing the
target.
- Jonathan Hurley
On Sept. 3, 2016, 10:36 a.m., yao lei wrote:
>
&g
> On Sept. 3, 2016, 3:17 p.m., Jonathan Hurley wrote:
> > This is not the correct way to accomplish this. Instead, when you create
> > the alert target, you can specify which alert states the alert target cares
> > about:
> >
> > ```
> > {
> &g
> On Sept. 2, 2016, 10:22 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java,
> > lines 473-478
> > <https://reviews.apache.org/r/51597/diff/3/?file=1490551#file1490551line473>
&g
vices/MetricsRetrievalServiceTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/51691/diff/
Testing
---
mvn clean test
Thanks,
Jonathan Hurley
[INFO]
[INFO] Total time: 37:19 min
[INFO] Finished at: 2016-09-07T11:45:03-04:00
[INFO] Final Memory: 38M/635M
[INFO]
Thanks,
Jonathan Hurley
list was
updated/written successfully ...
ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java
(lines 102 - 107)
<https://reviews.apache.org/r/51659/#comment215416>
Documentation.
- Jonathan Hurley
On Sept. 6, 2016, 1:23 p.m., Dmitro Lisnic
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/51691/#review148019
---
On Sept. 7, 2016, 1:18 p.m., Jonathan Hurley wrote:
>
> ---
> This is an a
-------
On Sept. 7, 2016, 1:18 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51691/
> --
Doesn't that mean that this needs to check direction as well?
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
(lines 107 - 108)
<https://reviews.apache.org/r/51713/#comment215647>
Does this change require work in the next upgrade catalog
- 139)
<https://reviews.apache.org/r/51733/#comment215661>
Doesn't this mean that the test won't run on some boxes since it won't
assert anything?
- Jonathan Hurley
On Sept. 8, 2016, 12:57 p.m., Nahapp
I'd say either make this
a flat list of password-protected fields or enhance the python code to extract
properties of type PASSWORD to check on.
- Jonathan Hurley
On Sept. 7, 2016, 5:14 p.m., Anita Jebaraj wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51733/#review148233
---
Ship it!
Ship It!
- Jonathan Hurley
On Sept. 8, 2016, 2:37
---
Total run:1124
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
> On Sept. 8, 2016, 1:07 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelper.java,
> > lines 555-558
> > <https://reviews.apache.org/r/51713/diff/2/?file=1494445#file1494445line555>
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51713/#review148340
---
Ship it!
Ship It!
- Jonathan Hurley
On Sept. 9, 2016, 9:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51762/#review148497
---
Ship it!
Ship It!
- Jonathan Hurley
On Sept. 9, 2016, 1:07
he.org/r/51818/diff/
Testing
---
--
Total run:1125
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
instead throw exceptions and fail startup on problems like
this?
- Jonathan Hurley
On Sept. 13, 2016, 5 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated
401 - 500 of 1558 matches
Mail list logo
