Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57810/#review169586 --- Ship it! Ship It! - Robert Levas On March 21, 2017, 1:19

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Robert Levas
,host3.example.com ``` - Robert Levas On March 27, 2017, 10:54 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Robert Levas
/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml Lines 152-153 (patched) <https://reviews.apache.org/r/57959/#comment242956> Multiple master KDC hosts may be listed as comma-separated values... the documention should indicate this. - Robert Levas On March 27, 20

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Robert Levas
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57959/ > --- > > (Updated March 27, 2017, 10:54 a.m.) > > > Review request for Ambari, Atti

Re: Review Request 57986: Prune files contained in zkmigrator.jar to a minimal set

2017-03-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57986/#review170314 --- Ship it! Ship It! - Robert Levas On March 28, 2017, 4:54

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Robert Levas
> On March 27, 2017, 11:49 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > > Lines 97 (patched) > > <https://reviews.apache.org/r/57959/diff/1/?file=1676915#file1676915line97> > > &

Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar to a minimal set

2017-03-28 Thread Robert Levas
Diff: https://reviews.apache.org/r/57968/diff/2/ Changes: https://reviews.apache.org/r/57968/diff/1-2/ Testing --- Manualy tested jar. Thanks, Robert Levas

Review Request 57968: Prune files contained in jcepolicyinfo.jar to a minimal set

2017-03-27 Thread Robert Levas
from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues. Diffs - ambari-agent/pom.xml 292fd07 Diff: https://reviews.apache.org/r/57968/diff/1/ Testing --- Manualy tested jar. Thanks, Robert Levas

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57966/#review170211 --- Ship it! Ship It! - Robert Levas On March 27, 2017, 2:54

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-30 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57959/#review170635 --- Ship it! Ship It! - Robert Levas On March 30, 2017, 3:04

Re: Review Request 57771: Unlimited Key JCE policy is enabled or not on each host

2017-03-22 Thread Robert Levas
s an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57771/ > --- > > (Updated March 22, 2017, 5:44 a.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Robert Leva

Re: Review Request 57874: Configuration types from both the blueprint and cluster template are validated before cluster creation

2017-03-23 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57874/#review169870 --- Ship it! Ship It! - Robert Levas On March 23, 2017, 9:54

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-29 Thread Robert Levas
--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57959/ > ------- > > (Updated March 27, 2017, 10:54 a.m.) > > > Review request for Ambari, Attila

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Robert Levas
> On March 28, 2017, 7:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > <https://reviews.apache.org/r/58006/diff/1/?file=1677953#file1677953line66> > > > > Maybe th

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58006/#review170429 --- Ship it! Ship It! - Robert Levas On March 29, 2017, 1:06

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Robert Levas
> On March 28, 2017, 7:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > <https://reviews.apache.org/r/58006/diff/1/?file=1677953#file1677953line66> > > > > Maybe th

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-28 Thread Robert Levas
server is not trusted. Also, this function will return `ssl.PROTOCOL_SSLv23` no matter what, so the caller has no indication that an error may have occurred. - Robert Levas On March 28, 2017, 6:03 p.m., Aravindan Vijayan

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Robert Levas
> On March 28, 2017, 7:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > <https://reviews.apache.org/r/58006/diff/1/?file=1677953#file1677953line66> > > > > Maybe th

Re: Review Request 57955: Allow for larger Ephemeral DH Keys in Ambari server running on JVM versions 1.8 and above

2017-03-27 Thread Robert Levas
--- > > (Updated March 27, 2017, 9:42 a.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Laszlo > Puskas, Robert Levas, and Sebastian Toader. > > > Bugs: AMBARI-20583 > https://issues.apache.org/

Re: Review Request 57954: Single process executor possibly can cause deadlock

2017-03-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57954/#review170173 --- Ship it! Ship It! - Robert Levas On March 27, 2017, 7:46

Re: Review Request 58079: Cleanup temporary files needed for downloading client configurations response

2017-03-31 Thread Robert Levas
hanged using the `server.tmp.dir` property in `ambari-server.properties` file. So someone could set this a `/var/tmp`. Ideally the _correct_ permission was set on this directory when it was created. - Robert Levas On March 31, 2017, 11:57 a.m., Attila Magyar

Re: Review Request 58079: Cleanup temporary files needed for downloading client configurations response

2017-03-31 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58079/#review170759 --- Ship it! I tested out the patch. Nice job. - Robert Levas

Re: Review Request 57610: Tokenize kerberos principal name appearing in kerberos rules in exported blueprint

2017-03-16 Thread Robert Levas
> On March 16, 2017, 9:12 a.m., Sandor Magyari wrote: > > The question is here whether is useful or not to export auth_to_local > > properties, since they are generated at deploy time anyway. May be would be > > better to exclude from export. > > Could you p

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Robert Levas
/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java Lines 1 (patched) <https://reviews.apache.org/r/57733/#comment241659> This should be below the copywrite block. - Robert Levas On March 17, 2017, 1:45 p.m., Laszlo Puskas

Re: Review Request 57718: Duplicate entries in DB for auto__instance privileges upon Ambari server restart

2017-03-17 Thread Robert Levas
tch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11070//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11070//console ``` Thanks, Robert Levas

Re: Review Request 57625: Minor refactoring and clean up in ambari-server

2017-03-15 Thread Robert Levas
what happens if `security.server.keys_dir` is set to something like ``` ;touch /tmp/security_issue; ``` - Robert Levas On March 14, 2017, 6:35 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 57625: Minor refactoring and clean up in ambari-server

2017-03-15 Thread Robert Levas
> On March 15, 2017, 9:51 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/CertificateManager.java > > Lines 166-167 (patched) > > <https://reviews.apache.org/r/57625/diff/1/?file=1664892#file1664892line166> > >

Review Request 57770: Disabling security fails with AttributeError

2017-03-20 Thread Robert Levas
5.026s [INFO] Finished at: Sat Mar 18 21:16:02 EDT 2017 [INFO] Final Memory: 71M/1372M [INFO] ``` # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 57781: Configuration Markdown Not Property Parsed By Some Editors

2017-03-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57781/#review169475 --- Ship it! Ship It! - Robert Levas On March 20, 2017, 12:13

Re: Review Request 57771: Unlimited Key JCE policy is enabled or not on each host

2017-03-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57771/#review169456 --- Ship it! Thanks for making those changes. - Robert Levas

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57733/#review169434 --- Ship it! Ship It! - Robert Levas On March 20, 2017, 7:48

Re: Review Request 57770: Disabling security fails with AttributeError

2017-03-20 Thread Robert Levas
r:green}+1 core tests{color}. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11080//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11080//console ``` Thanks, Robert Levas

Re: Review Request 57771: Unlimited Key JCE policy is enabled or not on each host

2017-03-20 Thread Robert Levas
ed key JCE policy contained to one location, maintenance will be easier. - Robert Levas On March 20, 2017, 8:49 a.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 57771: Unlimited Key JCE policy is enabled or not on each host

2017-03-20 Thread Robert Levas
> On March 20, 2017, 10:18 a.m., Robert Levas wrote: > > ambari-agent/src/main/python/ambari_agent/HostInfo.py > > Lines 293-298 (patched) > > <https://reviews.apache.org/r/57771/diff/1/?file=1668296#file1668296line294> > > &g

Re: Review Request 57610: Tokenize kerberos principal name appearing in kerberos rules in exported blueprint

2017-03-16 Thread Robert Levas
> On March 16, 2017, 9:12 a.m., Sandor Magyari wrote: > > The question is here whether is useful or not to export auth_to_local > > properties, since they are generated at deploy time anyway. May be would be > > better to exclude from export. > > Could you p

Re: Review Request 57683: Accessing a user after sync with AD is failing with 500

2017-03-16 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57683/#review169190 --- Ship it! Ship It! - Robert Levas On March 16, 2017, 12:40

Re: Review Request 57610: Tokenize kerberos principal name appearing in kerberos rules in exported blueprint

2017-03-16 Thread Robert Levas
tate.kerberos.KerberosDescriptor#getAllAuthToLocalProperties`. ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java Line 230 (original), 230 (patched) <https://reviews.apache.org/r/57610/#comment241533> `clusetrName` ==> `clusterName` - R

Review Request 57718: Duplicate entries in DB for auto__instance privileges upon Ambari server restart

2017-03-16 Thread Robert Levas
16 22:07:20 EDT 2017 [INFO] Final Memory: 72M/570M [INFO] ``` # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 57718: Duplicate entries in DB for auto__instance privileges upon Ambari server restart

2017-03-17 Thread Robert Levas
NFO] [INFO] Total time: 24:01.487s [INFO] Finished at: Thu Mar 16 22:07:20 EDT 2017 [INFO] Final Memory: 72M/570M [INFO] ``` # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 58180: Cluster Merge At End Of Upgrade Creation Cascades Unnecessarily

2017-04-04 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58180/#review171014 --- Ship it! Ship It! - Robert Levas On April 4, 2017, 1:18 p.m

Re: Review Request 58306: Use Infra-Solr user to create Solr user-roles

2017-04-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58306/#review171450 --- Ship it! Ship It! - Robert Levas On April 10, 2017, 11:58

Re: Review Request 57610: Tokenize kerberos principal name appearing in kerberos rules in exported blueprint

2017-04-10 Thread Robert Levas
propeties. This is a better solution since it is expected that the Kerberos logic will dynamically create them anyways. - Robert Levas On April 5, 2017, 12:56 p.m., Amruta Borkar wrote: > > --- > This is an automatically generat

Re: Review Request 58079: Cleanup temporary files needed for downloading client configurations response

2017-04-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58079/#review170872 --- Ship it! Ship It! - Robert Levas On April 3, 2017, 6 a.m

Re: Review Request 57563: Kerberos principal creation fails during blueprint install when kdc_hosts is not specified in blueprint

2017-04-03 Thread Robert Levas
pty. I am not sure if this check is possible. - Robert Levas On April 3, 2017, 12:42 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-04-03 Thread Robert Levas
> On March 31, 2017, 5:07 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java > > Lines 184-185 (original), 153-154 (patched) > > <https://reviews.apache.org/r/58109/diff/2/?file=1682589#file1682589line190> > &g

Re: Review Request 57563: Kerberos principal creation fails during blueprint install when kdc_hosts is not specified in blueprint

2017-04-03 Thread Robert Levas
> On March 14, 2017, 7:01 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml > > Line 135 (original), 135 (patched) > > <https://reviews.apache.org/r/57563/diff/1/?file=1662766#file1662766line13

Re: Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-03-31 Thread Robert Levas
AS foo ON (s.request_id = foo.request_id and s.stage_id = foo.stage_id); ``` - Robert Levas On March 31, 2017, 3:02 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-04-01 Thread Robert Levas
> On March 31, 2017, 5:07 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java > > Lines 184-185 (original), 153-154 (patched) > > <https://reviews.apache.org/r/58109/diff/2/?file=1682589#file1682589line190> > &g

Re: Review Request 58218: Upgrade Progress Dialog Executes Query Which Causes StackOverflow in JPA

2017-04-06 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58218/#review171192 --- Ship it! Ship It! - Robert Levas On April 5, 2017, 7:20 p.m

Re: Review Request 58346: AMBARI-20733 /var/log/krb5kdc.log is growing rapidly on the KDC server

2017-04-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58346/#review171912 --- Ship it! Ship It! - Robert Levas On April 13, 2017, 8:29

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

2017-04-13 Thread Robert Levas
/ambari/server/controller/internal/ProvisionClusterRequest.java Lines 127-129 (patched) <https://reviews.apache.org/r/58415/#comment244868> This is in the wrong place in the Java file. - Robert Levas On April 13, 2017, 11:33 a.m., Laszlo Puskas

Re: Review Request 58429: After pam setup- Hive View user home test fails

2017-04-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58429/#review171916 --- Can you add Vishal Ghugare to the review? - Robert Levas

Re: Review Request 58425: Remove Server attribute from the HTTP response headers

2017-04-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58425/#review171914 --- Ship it! Ship It! - Robert Levas On April 13, 2017, 1:16

Re: Review Request 58574: BE: Characters used in usernames should be constrained

2017-04-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58574/#review172491 --- Ship it! Ship It! - Robert Levas On April 20, 2017, 10:28

Re: Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

2017-03-02 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57204/#review167688 --- Ship it! Ship It! - Robert Levas On March 2, 2017, 7:53 a.m

Re: Review Request 57423: Stack Upgrade tests fail during Hive Metastore restart due to missing hive-site.jceks file

2017-03-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57423/#review168305 --- Ship it! Ship It! - Robert Levas On March 8, 2017, 11:04

Re: Review Request 57563: Kerberos principal creation fails during blueprint install when kdc_hosts is not specified in blueprint

2017-03-14 Thread Robert Levas
s to manaully manage the krb5.conf file (`krb5-conf/manage_krb5_conf` is set to "false"), then `kerberos-env/kdc-hosts` is not required. - Robert Levas On March 13, 2017, 1:11 p.m., Amruta Borkar wrote: > > --- > Th

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57506/#review168620 --- Ship it! Ship It! - Robert Levas On March 10, 2017, 8:53

Review Request 57544: Atlas MetaData server start fails while granting permissions to HBase tables after unkerberizing the cluster

2017-03-12 Thread Robert Levas
nfiguration changes were set properly - espically the HBASE coprocessor properties. # Local test results: Java test passed, unlrealted python test failed # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 57544: Atlas MetaData server start fails while granting permissions to HBase tables after unkerberizing the cluster

2017-03-12 Thread Robert Levas
i/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java Line 211 (original) <https://reviews.apache.org/r/57544/#comment240994> Moved to `ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java` - Robert Levas O

Re: Review Request 57521: HOU wizard wrongly shows hosts with only client components at the start of 'Upgrade Hosts' group

2017-03-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57521/#review168687 --- Ship it! Ship It! - Robert Levas On March 10, 2017, 5:09

Review Request 57417: NPE during Ambari server schema upgrade while updating hbase_master_cpu alert definition

2017-03-08 Thread Robert Levas
upgrade (`ambari-server upgrade`) on DB from Ambari 2.2.2 # Local test results: PENDING # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 57396: AMBARI-20329 After restarting Ranger, PAM files are overwritten by default template

2017-03-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57396/#review168295 --- Ship it! Ship It! - Robert Levas On March 7, 2017, 5:45 p.m

Re: Review Request 57543: When agent retries commands it needs to handle credential store processing correctly

2017-03-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57543/#review168815 --- Ship it! Ship It! - Robert Levas On March 12, 2017, 4:12

Re: Review Request 57324: HBase Master CPU Utilization Alert is in unknown state due to kinit error

2017-03-06 Thread Robert Levas
that it unlikely that the original value would have been changed, I am open to go the explicit JSON route. - Robert ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57324/#review167976 --

Re: Review Request 57339: Server startup script keeps waiting even if DB consistency has failed

2017-03-06 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57339/#review167986 --- Ship it! Ship It! - Robert Levas On March 6, 2017, 9:54 a.m

Re: Review Request 57324: HBase Master CPU Utilization Alert is in unknown state due to kinit error

2017-03-06 Thread Robert Levas
uriJson.addProperty("kerberos_keytab", > > "{{cluster-env/smokeuser_keytab}}"); > > uriJson.addProperty("kerberos_principal", > > "{{cluster-env/smokeuser_principal_name}}"); > > ``` > > > > As

Re: Review Request 57324: HBase Master CPU Utilization Alert is in unknown state due to kinit error

2017-03-06 Thread Robert Levas
50.java 2a684dc ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/alerts.json 1b3ae25 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 7ee66ef Diff: https://reviews.apache.org/r/57324/diff/2/ Testing (updated) --- Manually tested in new Ambari 2.5.0 cluster and upgrade scenario from Ambari 2.4.2 to Ambari 2.5.0 # Local test results: ``` [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 26:07.123s [INFO] Finished at: Mon Mar 06 12:25:32 EST 2017 [INFO] Final Memory: 70M/596M [INFO] ``` # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate

2017-03-06 Thread Robert Levas
al), 122-141 (patched) <https://reviews.apache.org/r/57326/#comment240008> Same as above, related to the _reference_. - Robert Levas On March 6, 2017, 1:29 a.m., wang yaoxin wrote: > > --- > This is an automaticall

Re: Review Request 57324: HBase Master CPU Utilization Alert is in unknown state due to kinit error

2017-03-06 Thread Robert Levas
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 2a684dc ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/alerts.json 1b3ae25 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 7ee66ef Diff: https://reviews.apache.org/r/57324/diff/2/ Changes: https://reviews.apache.org/r/57324/diff/1-2/ Testing --- Manually tested in new Ambari 2.5.0 cluster and upgrade scenario from Ambari 2.4.2 to Ambari 2.5.0 # Local test results: PASSED # Jenkins test results: PENDING Thanks, Robert Levas

Review Request 57350: Kerberos identity reference not working for ranger-audit property in hbase

2017-03-06 Thread Robert Levas
[INFO] Total time: 23:53.766s [INFO] Finished at: Mon Mar 06 16:55:35 EST 2017 [INFO] Final Memory: 71M/772M [INFO] -------- ``` # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate

2017-03-07 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57326/#review168112 --- Ship it! Ship It! - Robert Levas On March 6, 2017, 9:59 p.m

Review Request 57324: HBase Master CPU Utilization Alert is in unknown state due to kinit error

2017-03-05 Thread Robert Levas
"kerberos_keytab": "{{hbase-site/hbase.security.authentication.spnego.kerberos.keytab}}" ``` Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 2a684dc ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/alerts.json 1b3ae25 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 7ee66ef Diff: https://reviews.apache.org/r/57324/diff/1/ Testing --- Manually tested in new Ambari 2.5.0 cluster and upgrade scenario from Ambari 2.4.2 to Ambari 2.5.0 # Local test results: PASSED # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-03-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57040/#review167817 --- Ship it! Ship It! - Robert Levas On March 3, 2017, 7:30 a.m

Re: Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

2017-03-01 Thread Robert Levas
isting service configuration will be untouched, and by removing the relelvant configuration specification from the user-defined Kerberos descriptor, the config will remain untouched during Kerberos-related operations, as desired. - Robert Levas On March 1, 2017, 11:12 a.m., Eugene Chekanskiy

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

2017-03-01 Thread Robert Levas
, 2017, 6:18 a.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, > and Sebastian Toader. > > > Bugs: AMBARI-20140 > https://issues.apache.org/jira/browse/AMBARI-20140 > > > Repository: ambari > > > Description

Re: Review Request 57250: NPE thrown if downscale is performed before all hosts registered with cluster.

2017-03-02 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57250/#review167720 --- Ship it! Ship It! - Robert Levas On March 2, 2017, 2:31 p.m

Review Request 57410: When SPNEGO authentication is enabled for Hadoop in a cluster with NN HA, PXF Process alert fails

2017-03-07 Thread Robert Levas
ting the PXF component. Diffs - ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py d0ed0a4 Diff: https://reviews.apache.org/r/57410/diff/1/ Testing --- Manually tested in cluster - Ambari 2.5 with HPD 2.5 and HDB 2.1.2 Thanks, Robert Levas

Re: Review Request 57410: When SPNEGO authentication is enabled for Hadoop in a cluster with NN HA, PXF Process alert fails

2017-03-07 Thread Robert Levas
/package/alerts/api_status.py Line 33 (original), 35 (patched) <https://reviews.apache.org/r/57410/#comment240443> The `pfx` user is hard coded in `common-services/PXF/3.0.0/package/scripts/pxf_constants.py:32`. ``` pxf_user = "pxf" ``` - Robert Levas On March 7,

Re: Review Request 57410: When SPNEGO authentication is enabled for Hadoop in a cluster with NN HA, PXF Process alert fails

2017-03-08 Thread Robert Levas
side the call at > > ``` > namenode_address = > get_active_namenode(ConfigDictionary(configurations[HDFS_SITE]), > configurations[CLUSTER_ENV_SECURITY], configurations[HADOOP_ENV_HDFS_USER])[1] > ``` > > # Solution > Ensure the configured user's Kerberos ticket cache contains a valid ticket > before querying for the active NN. Possibly change the acting user to one > executing the PXF component. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py > d0ed0a4 > > > Diff: https://reviews.apache.org/r/57410/diff/1/ > > > Testing > --- > > Manually tested in cluster - Ambari 2.5 with HPD 2.5 and HDB 2.1.2 > > > Thanks, > > Robert Levas > >

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Robert Levas
ks/HDP/2.5/services/stack_advisor.py Line 502 (original), 502 (patched) <https://reviews.apache.org/r/57810/#comment241982> Does `'No'.lower()` != `'no'`? - Robert Levas On March 21, 2017, 11:52 a.m., Dmyt

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Robert Levas
> On March 21, 2017, 12:18 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > > Lines 499-503 (original), 499-503 (patched) > > <https://reviews.apache.org/r/57810/diff/1/?file=1670925#file1670925line499&

Re: Review Request 61168: Hive-Service check failing in post EU validation (BI-HDP)

2017-07-28 Thread Robert Levas
authToLocalRules = authToLocalRules.replaceAll(SPNEGO_PRINC_PATTERN, ""); ... } - Robert Levas On July 28, 2017, 12:16 a.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-02 Thread Robert Levas
PIPE, stderr = PIPE, timeout = 5, sudo = True) ``` - Robert Levas On Aug. 2, 2017, 7:59 a.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review182085 --- Ship it! Ship It! - Robert Levas On Aug. 3, 2017, 4:14 a.m

Re: Review Request 61404: Do not use 'dbo' schema name in idempotent Ambari DDL generator for AzureDB.

2017-08-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61404/#review182114 --- Ship it! Ship It! - Robert Levas On Aug. 3, 2017, 9:17 a.m

Re: Review Request 61501: Prevent users from authenticating if they exceed a configured number of login failures

2017-08-11 Thread Robert Levas
> On Aug. 10, 2017, 2:26 p.m., Robert Levas wrote: > > Would it have been possble to add the lockout logic in > > `org.apache.ambari.server.security.authentication.AmbariAuthenticationEventHandlerImpl#onSuccessfulAuthentication`? > > I am not sure if chaning the _su

Re: Review Request 60403: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2017-08-15 Thread Robert Levas
> On July 5, 2017, 2:38 p.m., Robert Levas wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py > > Lines 33 (patched) > > <https://reviews.apache.org/r/60403/diff/1/?file=1761672#file1761672line33> > > &g

Re: Review Request 61501: Prevent users from authenticating if they exceed a configured number of login failures

2017-08-11 Thread Robert Levas
> On Aug. 10, 2017, 2:26 p.m., Robert Levas wrote: > > Would it have been possble to add the lockout logic in > > `org.apache.ambari.server.security.authentication.AmbariAuthenticationEventHandlerImpl#onSuccessfulAuthentication`? > > I am not sure if chaning the _su

Re: Review Request 61501: Prevent users from authenticating if they exceed a configured number of login failures

2017-08-10 Thread Robert Levas
cation mechanism, maybe `authentication.max.failures` should be renamed to something like `authentication.local.max.failures`? - Robert Levas On Aug. 10, 2017, 11:28 a.m., Attila Magyar wrote: > > --- > This is an automatica

Re: Review Request 61707: Pre-configure services when Kerberos is enabled to reduce number of core service restarts when services are added

2017-08-17 Thread Robert Levas
compiler warnings. {color:green}+1 core tests{color}. The patch passed unit tests in ambari-server. Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/12008//console ``` Thanks, Robert Levas

Re: Review Request 60711: Assigning hosts concurrently to same config group may fail with "org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Config group already exist'

2017-07-07 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60711/#review179896 --- Ship it! Ship It! - Robert Levas On July 7, 2017, 1 p.m

Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Robert Levas
: https://reviews.apache.org/r/60844/diff/1/ Testing --- Manually tested Thanks, Robert Levas

Re: Review Request 60774: Ambari updates memory settings in blueprint incorrectly

2017-07-13 Thread Robert Levas
/org/apache/ambari/server/topology/validators/UnitValidatedProperty.java Lines 27 (patched) <https://reviews.apache.org/r/60774/#comment255622> missing JavaDoc - Robert Levas On July 13, 2017, 10:03 a.m., Attila Magyar

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Robert Levas
r/60844/#review180474 --- On July 13, 2017, 12:03 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60844/ > ---

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Robert Levas
eviews.apache.org/r/60844/#review180470 --- On July 13, 2017, 12:03 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 60637: Cleanup relevant Kerberos identities when a service is removed

2017-07-11 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60637/#review180216 --- Ship it! Ship It! - Robert Levas On July 6, 2017, 7:08 a.m

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-10 Thread Robert Levas
ate a local authentication source for the new resource. - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60707/#review180009 ------- O

Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-07 Thread Robert Levas
Memory: 108M/1769M [INFO] ``` # Jenkins test results: PENDING Thanks, Robert Levas

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-07 Thread Robert Levas
] [INFO] Total time: 29:37 min [INFO] Finished at: 2017-07-07T07:47:34-04:00 [INFO] Final Memory: 108M/1769M [INFO] ``` # Jenkins test results: PENDING Thanks, Robert Levas

<    1   2   3   4   5   6   7   8   9   >