Re: Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT
> On April 29, 2017, 3:35 a.m., Aravindan Vijayan wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! Could you commit it? > > Aravindan Vijayan wrote: > Done. Please close the review and the jira. Thank you very much! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58575/#review173361 --- On April 20, 2017, 11:59 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58575/ > --- > > (Updated April 20, 2017, 11:59 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-20797 > https://issues.apache.org/jira/browse/AMBARI-20797 > > > Repository: ambari > > > Description > --- > > I had in trouble compiling same as in > https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html > The solution is also mentioned in the URL above. We should use storm-1.1.0 , > not storm-1.1.0-SNAPSHOT > > > Diffs > - > > ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63 > > > Diff: https://reviews.apache.org/r/58575/diff/1/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 core tests. The patch passed unit tests in > ambari-metrics/ambari-metrics-storm-sink. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
> On May 3, 2017, 3:37 a.m., Alejandro Fernandez wrote: > > Ship It! Thank you very much! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review173621 --- On April 17, 2017, 9:40 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57687/ > --- > > (Updated April 17, 2017, 9:40 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku > Sako. > > > Bugs: AMBARI-20443 > https://issues.apache.org/jira/browse/AMBARI-20443 > > > Repository: ambari > > > Description > --- > > In Advanced hive-env, there is a parameter named hive_ambari_database. Though > I change the parameter, it looks like nothing has changed. I greped the > entire ambari source code, the parameter is not referenced. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 5f56617 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 4ed26f7 > > > Diff: https://reviews.apache.org/r/57687/diff/3/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12863418/AMBARI-20443.3.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 core tests. The patch passed unit tests in ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11398//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11398//console > > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review173540 --- Could anyone review this? - Masahiro Tanaka On 4月 17, 2017, 9:40 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57687/ > --- > > (Updated 4月 17, 2017, 9:40 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku > Sako. > > > Bugs: AMBARI-20443 > https://issues.apache.org/jira/browse/AMBARI-20443 > > > Repository: ambari > > > Description > --- > > In Advanced hive-env, there is a parameter named hive_ambari_database. Though > I change the parameter, it looks like nothing has changed. I greped the > entire ambari source code, the parameter is not referenced. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 5f56617 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 4ed26f7 > > > Diff: https://reviews.apache.org/r/57687/diff/3/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12863418/AMBARI-20443.3.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 core tests. The patch passed unit tests in ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11398//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11398//console > > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT
> On 4月 29, 2017, 3:35 a.m., Aravindan Vijayan wrote: > > Ship It! Thank you! Could you commit it? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58575/#review173361 --- On 4月 20, 2017, 11:59 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58575/ > --- > > (Updated 4月 20, 2017, 11:59 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-20797 > https://issues.apache.org/jira/browse/AMBARI-20797 > > > Repository: ambari > > > Description > --- > > I had in trouble compiling same as in > https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html > The solution is also mentioned in the URL above. We should use storm-1.1.0 , > not storm-1.1.0-SNAPSHOT > > > Diffs > - > > ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63 > > > Diff: https://reviews.apache.org/r/58575/diff/1/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 core tests. The patch passed unit tests in > ambari-metrics/ambari-metrics-storm-sink. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58575/#review173189 --- Could anyone review this? - Masahiro Tanaka On April 20, 2017, 11:59 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58575/ > --- > > (Updated April 20, 2017, 11:59 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-20797 > https://issues.apache.org/jira/browse/AMBARI-20797 > > > Repository: ambari > > > Description > --- > > I had in trouble compiling same as in > https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html > The solution is also mentioned in the URL above. We should use storm-1.1.0 , > not storm-1.1.0-SNAPSHOT > > > Diffs > - > > ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63 > > > Diff: https://reviews.apache.org/r/58575/diff/1/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 core tests. The patch passed unit tests in > ambari-metrics/ambari-metrics-storm-sink. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58575/ --- Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako. Bugs: AMBARI-20797 https://issues.apache.org/jira/browse/AMBARI-20797 Repository: ambari Description --- I had in trouble compiling same as in https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html The solution is also mentioned in the URL above. We should use storm-1.1.0 , not storm-1.1.0-SNAPSHOT Diffs - ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63 Diff: https://reviews.apache.org/r/58575/diff/1/ Testing --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 core tests. The patch passed unit tests in ambari-metrics/ambari-metrics-storm-sink. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/ --- (Updated 4月 17, 2017, 9:39 a.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku Sako. Bugs: AMBARI-20443 https://issues.apache.org/jira/browse/AMBARI-20443 Repository: ambari Description --- In Advanced hive-env, there is a parameter named hive_ambari_database. Though I change the parameter, it looks like nothing has changed. I greped the entire ambari source code, the parameter is not referenced. Diffs (updated) - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f56617 ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 4ed26f7 Diff: https://reviews.apache.org/r/57687/diff/3/ Changes: https://reviews.apache.org/r/57687/diff/2-3/ Testing --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/ --- (Updated 4月 17, 2017, 9:40 a.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku Sako. Bugs: AMBARI-20443 https://issues.apache.org/jira/browse/AMBARI-20443 Repository: ambari Description --- In Advanced hive-env, there is a parameter named hive_ambari_database. Though I change the parameter, it looks like nothing has changed. I greped the entire ambari source code, the parameter is not referenced. Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f56617 ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 4ed26f7 Diff: https://reviews.apache.org/r/57687/diff/3/ Testing (updated) --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12863418/AMBARI-20443.3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11398//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11398//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
> On April 12, 2017, 10:19 p.m., Attila Doroszlai wrote: > > Sorry for my careless mistakeness... I'll fix this. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review171728 --- On April 9, 2017, 4:03 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57687/ > --- > > (Updated April 9, 2017, 4:03 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku > Sako. > > > Bugs: AMBARI-20443 > https://issues.apache.org/jira/browse/AMBARI-20443 > > > Repository: ambari > > > Description > --- > > In Advanced hive-env, there is a parameter named hive_ambari_database. Though > I change the parameter, it looks like nothing has changed. I greped the > entire ambari source code, the parameter is not referenced. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 5f56617 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 4ed26f7 > > > Diff: https://reviews.apache.org/r/57687/diff/2/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
> On April 12, 2017, 10:19 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > > Lines 89 (patched) > > <https://reviews.apache.org/r/57687/diff/2/?file=1686899#file1686899line89> > > > > Same here. Oh, sorry... I'll fix this shortly. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review171728 --- On April 9, 2017, 4:03 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57687/ > --- > > (Updated April 9, 2017, 4:03 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku > Sako. > > > Bugs: AMBARI-20443 > https://issues.apache.org/jira/browse/AMBARI-20443 > > > Repository: ambari > > > Description > --- > > In Advanced hive-env, there is a parameter named hive_ambari_database. Though > I change the parameter, it looks like nothing has changed. I greped the > entire ambari source code, the parameter is not referenced. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 5f56617 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 4ed26f7 > > > Diff: https://reviews.apache.org/r/57687/diff/2/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/ --- (Updated April 9, 2017, 4:03 p.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku Sako. Bugs: AMBARI-20443 https://issues.apache.org/jira/browse/AMBARI-20443 Repository: ambari Description --- In Advanced hive-env, there is a parameter named hive_ambari_database. Though I change the parameter, it looks like nothing has changed. I greped the entire ambari source code, the parameter is not referenced. Diffs (updated) - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f56617 ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 4ed26f7 Diff: https://reviews.apache.org/r/57687/diff/2/ Changes: https://reviews.apache.org/r/57687/diff/1-2/ Testing --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
> On April 7, 2017, 8:58 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > > Line 97 (original), 97 (patched) > > <https://reviews.apache.org/r/57687/diff/1/?file=1666075#file1666075line97> > > > > Let's keep the property then, but mark it as deleted. > > true > > > > > > Also, perform the same change for Hive 3.0.0 in common-services Thank you! I'll update the patch in a few days. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review171285 ------- On March 16, 2017, 9:55 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57687/ > --- > > (Updated March 16, 2017, 9:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku > Sako. > > > Bugs: AMBARI-20443 > https://issues.apache.org/jira/browse/AMBARI-20443 > > > Repository: ambari > > > Description > --- > > In Advanced hive-env, there is a parameter named hive_ambari_database. Though > I change the parameter, it looks like nothing has changed. I greped the > entire ambari source code, the parameter is not referenced. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > be79331 > > > Diff: https://reviews.apache.org/r/57687/diff/1/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
> On 3月 17, 2017, 5:21 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > > Line 97 (original), 97 (patched) > > <https://reviews.apache.org/r/57687/diff/1/?file=1666075#file1666075line97> > > > > Does this config need to be deleted from existing clusters? Which stack > > versions does this affect? > > > > If so, you can mark the property as , which will also cause > > Ambari to delete it during EU/RU > > Masahiro Tanaka wrote: > Sorry for late reply, and thank you for your reviewing. > I'll check if existing clusters do not need this property. I checked the Ambari source code, and found out that ambari 1.2.3 used `hive_ambari_database` in puppet manifest. But it was disappered from ambari 1.2.4 (maybe in [AMBARI-2144](https://issues.apache.org/jira/browse/AMBARI-2144)) - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review169205 ------- On 3月 16, 2017, 9:55 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57687/ > --- > > (Updated 3月 16, 2017, 9:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku > Sako. > > > Bugs: AMBARI-20443 > https://issues.apache.org/jira/browse/AMBARI-20443 > > > Repository: ambari > > > Description > --- > > In Advanced hive-env, there is a parameter named hive_ambari_database. Though > I change the parameter, it looks like nothing has changed. I greped the > entire ambari source code, the parameter is not referenced. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > be79331 > > > Diff: https://reviews.apache.org/r/57687/diff/1/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
> On 3月 17, 2017, 5:21 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > > Line 97 (original), 97 (patched) > > <https://reviews.apache.org/r/57687/diff/1/?file=1666075#file1666075line97> > > > > Does this config need to be deleted from existing clusters? Which stack > > versions does this affect? > > > > If so, you can mark the property as , which will also cause > > Ambari to delete it during EU/RU Sorry for late reply, and thank you for your reviewing. I'll check if existing clusters do not need this property. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review169205 ------- On 3月 16, 2017, 9:55 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57687/ > --- > > (Updated 3月 16, 2017, 9:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku > Sako. > > > Bugs: AMBARI-20443 > https://issues.apache.org/jira/browse/AMBARI-20443 > > > Repository: ambari > > > Description > --- > > In Advanced hive-env, there is a parameter named hive_ambari_database. Though > I change the parameter, it looks like nothing has changed. I greped the > entire ambari source code, the parameter is not referenced. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > be79331 > > > Diff: https://reviews.apache.org/r/57687/diff/1/ > > > Testing > --- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku Sako. Bugs: AMBARI-20443 https://issues.apache.org/jira/browse/AMBARI-20443 Repository: ambari Description --- In Advanced hive-env, there is a parameter named hive_ambari_database. Though I change the parameter, it looks like nothing has changed. I greped the entire ambari source code, the parameter is not referenced. Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml be79331 Diff: https://reviews.apache.org/r/57687/diff/1/ Testing --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55369/ --- (Updated 1月 16, 2017, 12:34 p.m.) Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, Sebastian Toader, and Yusaku Sako. Bugs: AMBARI-19415 https://issues.apache.org/jira/browse/AMBARI-19415 Repository: ambari Description --- Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but some environments (e.g. CentOS 7.3 with minimal install) doens't have `ifconfig` command, but `ip` command. A warning like below (which is in ambari-agent.log) is because of the assumption. ``` WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network interfaces list from ``` It would be better to check the NIC with `ifconfig` and `ip` both for better coverage. Diffs - ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7 ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b Diff: https://reviews.apache.org/r/55369/diff/ Testing (updated) --- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12847494/AMBARI-19415.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-agent. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/10063//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10063//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55369/ --- (Updated 1月 16, 2017, 12:33 p.m.) Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, Sebastian Toader, and Yusaku Sako. Bugs: AMBARI-19415 https://issues.apache.org/jira/browse/AMBARI-19415 Repository: ambari Description --- Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but some environments (e.g. CentOS 7.3 with minimal install) doens't have `ifconfig` command, but `ip` command. A warning like below (which is in ambari-agent.log) is because of the assumption. ``` WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network interfaces list from ``` It would be better to check the NIC with `ifconfig` and `ip` both for better coverage. Diffs (updated) - ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7 ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b Diff: https://reviews.apache.org/r/55369/diff/ Testing --- Hadoop QA added a comment - 13 hours ago +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12846316/AMBARI-19415.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-agent. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command
> On Jan. 11, 2017, 3:37 a.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/Facter.py, line 400
> > <https://reviews.apache.org/r/55369/diff/1/?file=1600539#file1600539line400>
> >
> > Add documentation to these 2 functions
Thanks you for reviewing my patch! You mean, `setDataIplinkOutput` and
`setDataIfConfigOutput` function like below?
```
# Returns `ip link` output
@staticmethod
def setDataIpLinkOutput():
try:
result = os.popen(FacterLinux.GET_IP_LINK_CMD).read()
return result
except OSError:
log.warn("Can't execute {0}".format(FacterLinux.GET_IP_LINK_CMD))
return ""
```
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55369/#review161098
-------
On Jan. 10, 2017, 2:23 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55369/
> ---
>
> (Updated Jan. 10, 2017, 2:23 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver
> Szabo, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-19415
> https://issues.apache.org/jira/browse/AMBARI-19415
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but
> some environments (e.g. CentOS 7.3 with minimal install) doens't have
> `ifconfig` command, but `ip` command.
>
> A warning like below (which is in ambari-agent.log) is because of the
> assumption.
> ```
> WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network
> interfaces list from
> ```
>
> It would be better to check the NIC with `ifconfig` and `ip` both for better
> coverage.
>
>
> Diffs
> -
>
> ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7
> ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b
>
> Diff: https://reviews.apache.org/r/55369/diff/
>
>
> Testing
> ---
>
> Hadoop QA added a comment - 13 hours ago
>
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12846316/AMBARI-19415.0.patch
> against trunk revision .
>
> +1 @author. The patch does not contain any @author tags.
>
> +1 tests included. The patch appears to include 1 new or modified test files.
>
> +1 javac. The applied patch does not increase the total number of javac
> compiler warnings.
>
> +1 release audit. The applied patch does not increase the total number of
> release audit warnings.
>
> +1 core tests. The patch passed unit tests in ambari-agent.
>
> Test results:
> https://builds.apache.org/job/Ambari-trunk-test-patch/9963//testReport/
> Console output:
> https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console
>
> This message is automatically generated.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Review Request 55369: Network interface check returns no value if there is no `ifconfig` command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55369/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, Sebastian Toader, and Yusaku Sako. Bugs: AMBARI-19415 https://issues.apache.org/jira/browse/AMBARI-19415 Repository: ambari Description --- Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but some environments (e.g. CentOS 7.3 with minimal install) doens't have `ifconfig` command, but `ip` command. A warning like below (which is in ambari-agent.log) is because of the assumption. ``` WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network interfaces list from ``` It would be better to check the NIC with `ifconfig` and `ip` both for better coverage. Diffs - ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7 ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b Diff: https://reviews.apache.org/r/55369/diff/ Testing --- Hadoop QA added a comment - 13 hours ago +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12846316/AMBARI-19415.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-agent. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 54399: Broken links in ambari-server/docs/api/v1/schemas.md
> On 12月 6, 2016, 4:38 p.m., Attila Doroszlai wrote:
> > Ship It!
Thanks again!
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54399/#review158128
---
On 12月 6, 2016, 9:06 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54399/
> ---
>
> (Updated 12月 6, 2016, 9:06 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Tom
> Beerbower.
>
>
> Bugs: AMBARI-19076
> https://issues.apache.org/jira/browse/AMBARI-19076
>
>
> Repository: ambari
>
>
> Description
> ---
>
> This is very trivial thing. When I see API document on
> https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md,
> I can't jump to {code} [POST/PUT/DELETE resource] {code} by clicking the
> link.
>
> We can jump to there by using
> https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md#postputdelete-resource.
>
>
> Diffs
> -
>
> ambari-server/docs/api/v1/schemas.md f52bc10
>
> Diff: https://reviews.apache.org/r/54399/diff/
>
>
> Testing
> ---
>
> manually tested
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Review Request 54399: Broken links in ambari-server/docs/api/v1/schemas.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54399/
---
Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Tom Beerbower.
Bugs: AMBARI-19076
https://issues.apache.org/jira/browse/AMBARI-19076
Repository: ambari
Description
---
This is very trivial thing. When I see API document on
https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md,
I can't jump to {code} [POST/PUT/DELETE resource] {code} by clicking the link.
We can jump to there by using
https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/schemas.md#postputdelete-resource.
Diffs
-
ambari-server/docs/api/v1/schemas.md f52bc10
Diff: https://reviews.apache.org/r/54399/diff/
Testing
---
manually tested
Thanks,
Masahiro Tanaka
Re: Review Request 53506: AMBARI-18761 NTP check fails even if chrony is working on CentOS7
> On Nov. 8, 2016, 3:54 a.m., Alejandro Fernandez wrote: > > Does this need to be tested on CentOS 6? If everything passes, +1 I tested on CentOS 6.7 with ntpd installed, and it works. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53506/#review155181 --- On Nov. 6, 2016, 10:23 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53506/ > --- > > (Updated Nov. 6, 2016, 10:23 a.m.) > > > Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-18761 > https://issues.apache.org/jira/browse/AMBARI-18761 > > > Repository: ambari > > > Description > --- > > I use CentOS 7 as a host OS. When the host check runs, it shows warning. The > warning says "The following services should be up: Service ntpd." > I think "chrony" is a default NTP client and server on CentOS7. So We should > check if there are ntpd or chronyd on a host. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 3871e72 > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 0c0a3b3 > > Diff: https://reviews.apache.org/r/53506/diff/ > > > Testing > --- > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12837535/AMBARI-18761.3.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/9154//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/9154//console > This message is automatically generated. > ``` > > Manual test: Installed Ambari2.4.1 on centos7, replaced HostInfo.py and > recheck host. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 53506: AMBARI-18761 NTP check fails even if chrony is working on CentOS7
> On Nov. 5, 2016, 12:51 p.m., Sid Wagle wrote:
> > ambari-agent/src/main/python/ambari_agent/HostInfo.py, line 120
> > <https://reviews.apache.org/r/53506/diff/1/?file=1555020#file1555020line120>
> >
> > This should return a ('chronyd', 'ntp') since both are valid. Need to
> > chnage the caller to do a OR.
Thank you for reviewing Sid Wagle! I updated the patch.
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53506/#review155046
---
On Nov. 6, 2016, 10:23 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53506/
> ---
>
> (Updated Nov. 6, 2016, 10:23 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-18761
> https://issues.apache.org/jira/browse/AMBARI-18761
>
>
> Repository: ambari
>
>
> Description
> ---
>
> I use CentOS 7 as a host OS. When the host check runs, it shows warning. The
> warning says "The following services should be up: Service ntpd."
> I think "chrony" is a default NTP client and server on CentOS7. So We should
> check if there are ntpd or chronyd on a host.
>
>
> Diffs
> -
>
> ambari-agent/src/main/python/ambari_agent/HostInfo.py 3871e72
> ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 0c0a3b3
>
> Diff: https://reviews.apache.org/r/53506/diff/
>
>
> Testing
> ---
>
> ```
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12837535/AMBARI-18761.3.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results:
> https://builds.apache.org/job/Ambari-trunk-test-patch/9154//testReport/
> Console output:
> https://builds.apache.org/job/Ambari-trunk-test-patch/9154//console
> This message is automatically generated.
> ```
>
> Manual test: Installed Ambari2.4.1 on centos7, replaced HostInfo.py and
> recheck host.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Review Request 53506: AMBARI-18761 NTP check fails even if chrony is working on CentOS7
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53506/ --- Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-18761 https://issues.apache.org/jira/browse/AMBARI-18761 Repository: ambari Description --- I use CentOS 7 as a host OS. When the host check runs, it shows warning. The warning says "The following services should be up: Service ntpd." I think "chrony" is a default NTP client and server on CentOS7. So We should check if there are ntpd or chronyd on a host. Diffs (updated) - ambari-agent/src/main/python/ambari_agent/HostInfo.py 3871e72 Diff: https://reviews.apache.org/r/53506/diff/ Testing --- ``` -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12837135/AMBARI-18761.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9144//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9144//console This message is automatically generated. ``` Manual test: Installed Ambari2.4.1 on centos7, replaced HostInfo.py and recheck host. Thanks, Masahiro Tanaka
Re: Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6
> On 9月 10, 2016, 6:06 a.m., Lav Jain wrote:
> > Ship It!
Thanks Lav Jain, could you commit this?
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/#review148370
---
On 9月 9, 2016, 10:21 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51754/
> ---
>
> (Updated 9月 9, 2016, 10:21 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
>
>
> Bugs: AMBARI-18337
> https://issues.apache.org/jira/browse/AMBARI-18337
>
>
> Repository: ambari
>
>
> Description
> ---
>
> With Python 2.6, ` {"A", "B"} ` syntax isn't allowed.
>
> Ref. https://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset
>
> ```
> As of Python 2.7, non-empty sets (not frozensets) can be created by placing a
> comma-separated list of elements within braces, for example: {'jack',
> 'sjoerd'}, in addition to the set constructor.
> ```
>
> Error
>
> ```
> Traceback (most recent call last):
> File "unitTests.py", line 129, in stack_test_executor
> modules]
> File "/usr/lib64/python2.6/unittest.py", line 575, in loadTestsFromName
> module = __import__('.'.join(parts_copy))
> File
> "/tmp/ambari/ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py",
> li
> ne 646
> self.assertFalse({'HAWQMASTER', 'HAWQSTANDBY'}.issubset(hostComponents))
> ^
> SyntaxError: invalid syntax
> ```
>
>
> Diffs
> -
>
> ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py
> 71c109f
>
> Diff: https://reviews.apache.org/r/51754/diff/
>
>
> Testing
> ---
>
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12827665/AMBARI-18337.patch
> against trunk revision .
>
> +1 @author. The patch does not contain any @author tags.
>
> +1 tests included. The patch appears to include 1 new or modified test files.
>
> +1 javac. The applied patch does not increase the total number of javac
> compiler warnings.
>
> +1 release audit. The applied patch does not increase the total number of
> release audit warnings.
>
> +1 core tests. The patch passed unit tests in ambari-server.
>
> Test results:
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//testReport/
> Console output:
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//console
>
> This message is automatically generated.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Re: Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6
> On 9月 17, 2016, 1:20 a.m., Alexander Denissov wrote:
> > Ship It!
Thanks Alexander Denissov!
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/#review149208
---
On 9月 9, 2016, 10:21 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51754/
> ---
>
> (Updated 9月 9, 2016, 10:21 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
>
>
> Bugs: AMBARI-18337
> https://issues.apache.org/jira/browse/AMBARI-18337
>
>
> Repository: ambari
>
>
> Description
> ---
>
> With Python 2.6, ` {"A", "B"} ` syntax isn't allowed.
>
> Ref. https://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset
>
> ```
> As of Python 2.7, non-empty sets (not frozensets) can be created by placing a
> comma-separated list of elements within braces, for example: {'jack',
> 'sjoerd'}, in addition to the set constructor.
> ```
>
> Error
>
> ```
> Traceback (most recent call last):
> File "unitTests.py", line 129, in stack_test_executor
> modules]
> File "/usr/lib64/python2.6/unittest.py", line 575, in loadTestsFromName
> module = __import__('.'.join(parts_copy))
> File
> "/tmp/ambari/ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py",
> li
> ne 646
> self.assertFalse({'HAWQMASTER', 'HAWQSTANDBY'}.issubset(hostComponents))
> ^
> SyntaxError: invalid syntax
> ```
>
>
> Diffs
> -
>
> ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py
> 71c109f
>
> Diff: https://reviews.apache.org/r/51754/diff/
>
>
> Testing
> ---
>
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12827665/AMBARI-18337.patch
> against trunk revision .
>
> +1 @author. The patch does not contain any @author tags.
>
> +1 tests included. The patch appears to include 1 new or modified test files.
>
> +1 javac. The applied patch does not increase the total number of javac
> compiler warnings.
>
> +1 release audit. The applied patch does not increase the total number of
> release audit warnings.
>
> +1 core tests. The patch passed unit tests in ambari-server.
>
> Test results:
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//testReport/
> Console output:
> https://builds.apache.org/job/Ambari-trunk-test-patch/8623//console
>
> This message is automatically generated.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Re: Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/
---
(Updated 9月 9, 2016, 10:21 a.m.)
Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
Bugs: AMBARI-18337
https://issues.apache.org/jira/browse/AMBARI-18337
Repository: ambari
Description
---
With Python 2.6, ` {"A", "B"} ` syntax isn't allowed.
Ref. https://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset
```
As of Python 2.7, non-empty sets (not frozensets) can be created by placing a
comma-separated list of elements within braces, for example: {'jack',
'sjoerd'}, in addition to the set constructor.
```
Error
```
Traceback (most recent call last):
File "unitTests.py", line 129, in stack_test_executor
modules]
File "/usr/lib64/python2.6/unittest.py", line 575, in loadTestsFromName
module = __import__('.'.join(parts_copy))
File
"/tmp/ambari/ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py",
li
ne 646
self.assertFalse({'HAWQMASTER', 'HAWQSTANDBY'}.issubset(hostComponents))
^
SyntaxError: invalid syntax
```
Diffs
-
ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py
71c109f
Diff: https://reviews.apache.org/r/51754/diff/
Testing
---
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12827665/AMBARI-18337.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/8623//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/8623//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/
---
Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
Repository: ambari
Description
---
With Python 2.6, ` {"A", "B"} ` syntax isn't allowed.
Ref. https://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset
```
As of Python 2.7, non-empty sets (not frozensets) can be created by placing a
comma-separated list of elements within braces, for example: {'jack',
'sjoerd'}, in addition to the set constructor.
```
Error
```
Traceback (most recent call last):
File "unitTests.py", line 129, in stack_test_executor
modules]
File "/usr/lib64/python2.6/unittest.py", line 575, in loadTestsFromName
module = __import__('.'.join(parts_copy))
File
"/tmp/ambari/ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py",
li
ne 646
self.assertFalse({'HAWQMASTER', 'HAWQSTANDBY'}.issubset(hostComponents))
^
SyntaxError: invalid syntax
```
Diffs
-
ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py
71c109f
Diff: https://reviews.apache.org/r/51754/diff/
Testing
---
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12827665/AMBARI-18337.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/8623//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/8623//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
Re: Review Request 51088: AMBARI-18113 Installing ambari-metrics-grafana fails due to lack of conf directory
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51088/#review145758
---
Oops, I found that the actual reason of this error message is because somehow I
created ambari-metrics-grafana-2.1.0.0-0.noarch.rpm (actually it doesn't do
anything), put it in my private repository, and installed it via Ambari.
If ambari-metrics-grafana-2.0.0.0-1.x86_64.rpm is in repository, there is no
problem.
- Masahiro Tanaka
On Aug. 15, 2016, 3:06 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51088/
> ---
>
> (Updated Aug. 15, 2016, 3:06 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
>
>
> Bugs: AMBARI-18113
> https://issues.apache.org/jira/browse/AMBARI-18113
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When installing Ambari Metrics, I got an error
>
> Stderr
> ```
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
> line 67, in
> AmsGrafana().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 280, in execute
> method(env)
> File
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
> line 32, in install
> self.configure(env) # for security
> File
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
> line 37, in configure
> ams(name='grafana', action=action)
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py",
> line 89, in thunk
> return fn(*args, **kwargs)
> File
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py",
> line 413, in ams
> recursive_ownership = True
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py",
> line 155, in __init__
> self.env.run()
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 160, in run
> self.run_action(resource, action)
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 124, in run_action
> provider_action()
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
> line 189, in action_create
> raise Fail("Applying %s failed, parent directory %s doesn't exist" %
> (self.resource, dirname))
> resource_management.core.exceptions.Fail: Applying
> Directory['/etc/ambari-metrics-grafana/conf'] failed, parent directory
> /etc/ambari-metrics-grafana doesn't exist
> ```
>
> Stdout
> ```
> 2016-08-11 13:38:44,481 - Group['hadoop'] {}
> 2016-08-11 13:38:44,483 - Adding group Group['hadoop']
> 2016-08-11 13:38:44,499 - User['zookeeper'] {'gid': 'hadoop',
> 'fetch_nonlocal_groups': True, 'groups': ['hadoop']}
> 2016-08-11 13:38:44,499 - Adding user User['zookeeper']
> 2016-08-11 13:38:44,555 - User['ams'] {'gid': 'hadoop',
> 'fetch_nonlocal_groups': True, 'groups': ['hadoop']}
> 2016-08-11 13:38:44,556 - Adding user User['ams']
> 2016-08-11 13:38:44,582 - User['ambari-qa'] {'gid': 'hadoop',
> 'fetch_nonlocal_groups': True, 'groups': ['users']}
> 2016-08-11 13:38:44,582 - Adding user User['ambari-qa']
> 2016-08-11 13:38:44,616 - File['/var/lib/ambari-agent/tmp/changeUid.sh']
> {'content': StaticFile('changeToSecureUid.sh'), 'mode': 0555}
> 2016-08-11 13:38:44,622 - Writing
> File['/var/lib/ambari-agent/tmp/changeUid.sh'] because it doesn't exist
> 2016-08-11 13:38:44,622 - Changing permission for
> /var/lib/ambari-agent/tmp/changeUid.sh from 644 to 555
> 2016-08-11 13:38:44,622 - Execute['/var/lib/ambari-agent/tmp/changeUid.sh
> ambari-qa
> /tmp/hadoop-ambari-qa,/tmp/hsperfdata_ambari-qa,/home/ambari-qa,/tmp/ambari-qa,/tmp/sqoop-ambari-qa']
> {'not_if': '(test $(id -u ambari-qa) -gt 1000) || (false)'}
> 2016-08-11 13:38:44,666 - Initializing 2 repositories
> 2016-08-11 13:38:44,666 - Repository['HDP-2.5'] {'base_url':
> 'http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-1181',
> 'action': ['create'], 'components': ['HDP', 'main'], 'repo_template':
> '[{{repo_id}}]\nname={{repo_id}}\n{% if mirror_list
> %}mirrorlist={
Re: Review Request 50475: AMBARI-17778 Add usage information in ambari-server script
> On July 27, 2016, 10:56 p.m., Nate Cole wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you for reviewing. Could you commit it? > > Nate Cole wrote: > Should it be committed to trunk? > > Masahiro Tanaka wrote: > Yes, please. I added "trunk" to "Branch" on this review board. > > Nate Cole wrote: > This has been pushed. Please close this review as Submitted and > appropriate jira as resolved. Thank you for submitting! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50475/#review143727 ------- On Aug. 9, 2016, 8:18 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50475/ > --- > > (Updated Aug. 9, 2016, 8:18 p.m.) > > > Review request for Ambari, Nate Cole, Sebastian Toader, Sid Wagle, and Yusaku > Sako. > > > Bugs: AMBARI-17778 > https://issues.apache.org/jira/browse/AMBARI-17778 > > > Repository: ambari > > > Description > --- > > In ambari-server script, there are some lacks of usage information (e.g. > install-mpack, upgrade-mpack.) > > They should be included in usage information. > > > Diffs > - > > ambari-server/sbin/ambari-server 81cf53b > > Diff: https://reviews.apache.org/r/50475/diff/ > > > Testing > --- > > ``` > --1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12818681/AMBARI-17778.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 core tests. The patch passed unit tests in ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7913//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7913//console > > This message is automatically generated. > ``` > & manual test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.
> On Aug. 5, 2016, 3:02 p.m., Masahiro Tanaka wrote: > > Thank you for reviewing! Could anyone commit this? > > Jayush Luniya wrote: > Done. Please close review request. Thnak you! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49935/#review144879 --- On Aug. 6, 2016, 10:17 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49935/ > --- > > (Updated Aug. 6, 2016, 10:17 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush > Luniya, Myroslav Papirkovskyy, and Sumit Mohanty. > > > Bugs: AMBARI-17633 > https://issues.apache.org/jira/browse/AMBARI-17633 > > > Repository: ambari > > > Description > --- > > When installing YARN+MapReduce2, I got a WARN message in nodemanager log(in > Log Search View) like below > ``` > 2016-07-09 06:30:21,865 WARN logaggregation.LogAggregationService > LogAggregationService.java:230 - Remote Root Log Dir [/app-logs] already > exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: > [rwxrwxrwx]. The cluster may have problems with multiple users. > ``` > I think the cause of this WARN is > [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py#L115). > We should add stickybit to yarn.nodemanager.remote-app-log-dir. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py > cf5736e > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > 4600063 > > Diff: https://reviews.apache.org/r/49935/diff/ > > > Testing > --- > > mvn clean test && manual test > > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12817505/AMBARI-17633.2.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > +1 tests included. The patch appears to include 1 new or modified test files. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 core tests. The patch passed unit tests in ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7805//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7805//console > > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49935/ --- (Updated Aug. 6, 2016, 10:17 a.m.) Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty. Bugs: AMBARI-17633 https://issues.apache.org/jira/browse/AMBARI-17633 Repository: ambari Description --- When installing YARN+MapReduce2, I got a WARN message in nodemanager log(in Log Search View) like below ``` 2016-07-09 06:30:21,865 WARN logaggregation.LogAggregationService LogAggregationService.java:230 - Remote Root Log Dir [/app-logs] already exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: [rwxrwxrwx]. The cluster may have problems with multiple users. ``` I think the cause of this WARN is [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py#L115). We should add stickybit to yarn.nodemanager.remote-app-log-dir. Diffs - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py cf5736e ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 4600063 Diff: https://reviews.apache.org/r/49935/diff/ Testing --- mvn clean test && manual test +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12817505/AMBARI-17633.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7805//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7805//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50653/ --- (Updated Aug. 4, 2016, 8:10 p.m.) Review request for Ambari, Daniel Gergely, Dmytro Sen, Oliver Szabo, and Sebastian Toader. Bugs: AMBARI-17308 https://issues.apache.org/jira/browse/AMBARI-17308 Repository: ambari Description --- In logsearch_feeder service log, we got errors like below ``` 2016-06-20 15:28:09,368 ERROR file=ambari-audit.log org.apache.ambari.logfeeder.mapper.MapperDate LogFeederUtil.java:356 - Error applying date transformation. isEpoch=false, dateFormat=-MM-dd'T'HH:mm:ss.SSSZ, value=2016-06-20T15:28:08.000. mapClass=map_date, input=input:source=file, path=/var/log/ambari-server/ambari-audit.log, fieldName=logtime. Messages suppressed before: 2 java.text.ParseException: Unparseable date: "2016-06-20T15:28:08.000" at java.text.DateFormat.parse(DateFormat.java:366) at org.apache.ambari.logfeeder.mapper.MapperDate.apply(MapperDate.java:83) at org.apache.ambari.logfeeder.filter.Filter.apply(Filter.java:154) at org.apache.ambari.logfeeder.filter.FilterGrok.applyMessage(FilterGrok.java:291) at org.apache.ambari.logfeeder.filter.FilterGrok.flush(FilterGrok.java:320) at org.apache.ambari.logfeeder.input.Input.flush(Input.java:125) at org.apache.ambari.logfeeder.input.InputFile.processFile(InputFile.java:430) at org.apache.ambari.logfeeder.input.InputFile.start(InputFile.java:260) at org.apache.ambari.logfeeder.input.Input.run(Input.java:100) at java.lang.Thread.run(Thread.java:745) ``` ambari-audit.log is like below ``` 2016-07-21T01:52:49.875+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo id(HDP-2.5), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025) 2016-07-21T01:52:49.905+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu16/repositories/HDP-2.5), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu16), Repo id(HDP-2.5), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu16/2.x/BUILDS/2.5.0.0-1025) 2016-07-21T01:52:50.015+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-UTILS-1.1.0.21), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo id(HDP-UTILS-1.1.0.21), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/ubuntu14) ``` I think date format of the ambari-audit.log (2016-07-21T01:52:49.875+09) should be like 2016-07-21T01:52:49.875+0900, since grok-pattern can't handle 2016-07-21T01:52:49.875+09 format. Diffs - ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java ea6524f ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 5f751bf Diff: https://reviews.apache.org/r/50653/diff/ Testing --- mvn clean test Thanks, Masahiro Tanaka
Re: Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50653/ --- (Updated Aug. 3, 2016, 9:36 p.m.) Review request for Ambari, Daniel Gergely, Dmytro Sen, Oliver Szabo, and Sebastian Toader. Changes --- Updated the patch Bugs: AMBARI-17308 https://issues.apache.org/jira/browse/AMBARI-17308 Repository: ambari Description --- In logsearch_feeder service log, we got errors like below ``` 2016-06-20 15:28:09,368 ERROR file=ambari-audit.log org.apache.ambari.logfeeder.mapper.MapperDate LogFeederUtil.java:356 - Error applying date transformation. isEpoch=false, dateFormat=-MM-dd'T'HH:mm:ss.SSSZ, value=2016-06-20T15:28:08.000. mapClass=map_date, input=input:source=file, path=/var/log/ambari-server/ambari-audit.log, fieldName=logtime. Messages suppressed before: 2 java.text.ParseException: Unparseable date: "2016-06-20T15:28:08.000" at java.text.DateFormat.parse(DateFormat.java:366) at org.apache.ambari.logfeeder.mapper.MapperDate.apply(MapperDate.java:83) at org.apache.ambari.logfeeder.filter.Filter.apply(Filter.java:154) at org.apache.ambari.logfeeder.filter.FilterGrok.applyMessage(FilterGrok.java:291) at org.apache.ambari.logfeeder.filter.FilterGrok.flush(FilterGrok.java:320) at org.apache.ambari.logfeeder.input.Input.flush(Input.java:125) at org.apache.ambari.logfeeder.input.InputFile.processFile(InputFile.java:430) at org.apache.ambari.logfeeder.input.InputFile.start(InputFile.java:260) at org.apache.ambari.logfeeder.input.Input.run(Input.java:100) at java.lang.Thread.run(Thread.java:745) ``` ambari-audit.log is like below ``` 2016-07-21T01:52:49.875+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo id(HDP-2.5), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025) 2016-07-21T01:52:49.905+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu16/repositories/HDP-2.5), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu16), Repo id(HDP-2.5), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu16/2.x/BUILDS/2.5.0.0-1025) 2016-07-21T01:52:50.015+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-UTILS-1.1.0.21), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo id(HDP-UTILS-1.1.0.21), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/ubuntu14) ``` I think date format of the ambari-audit.log (2016-07-21T01:52:49.875+09) should be like 2016-07-21T01:52:49.875+0900, since grok-pattern can't handle 2016-07-21T01:52:49.875+09 format. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java ea6524f ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 5f751bf Diff: https://reviews.apache.org/r/50653/diff/ Testing --- mvn clean test Thanks, Masahiro Tanaka
Re: Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50653/ --- (Updated Aug. 3, 2016, 10:15 a.m.) Review request for Ambari, Daniel Gergely, Dmytro Sen, Oliver Szabo, and Sebastian Toader. Changes --- Update the patch Bugs: AMBARI-17308 https://issues.apache.org/jira/browse/AMBARI-17308 Repository: ambari Description --- In logsearch_feeder service log, we got errors like below ``` 2016-06-20 15:28:09,368 ERROR file=ambari-audit.log org.apache.ambari.logfeeder.mapper.MapperDate LogFeederUtil.java:356 - Error applying date transformation. isEpoch=false, dateFormat=-MM-dd'T'HH:mm:ss.SSSZ, value=2016-06-20T15:28:08.000. mapClass=map_date, input=input:source=file, path=/var/log/ambari-server/ambari-audit.log, fieldName=logtime. Messages suppressed before: 2 java.text.ParseException: Unparseable date: "2016-06-20T15:28:08.000" at java.text.DateFormat.parse(DateFormat.java:366) at org.apache.ambari.logfeeder.mapper.MapperDate.apply(MapperDate.java:83) at org.apache.ambari.logfeeder.filter.Filter.apply(Filter.java:154) at org.apache.ambari.logfeeder.filter.FilterGrok.applyMessage(FilterGrok.java:291) at org.apache.ambari.logfeeder.filter.FilterGrok.flush(FilterGrok.java:320) at org.apache.ambari.logfeeder.input.Input.flush(Input.java:125) at org.apache.ambari.logfeeder.input.InputFile.processFile(InputFile.java:430) at org.apache.ambari.logfeeder.input.InputFile.start(InputFile.java:260) at org.apache.ambari.logfeeder.input.Input.run(Input.java:100) at java.lang.Thread.run(Thread.java:745) ``` ambari-audit.log is like below ``` 2016-07-21T01:52:49.875+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo id(HDP-2.5), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025) 2016-07-21T01:52:49.905+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu16/repositories/HDP-2.5), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu16), Repo id(HDP-2.5), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu16/2.x/BUILDS/2.5.0.0-1025) 2016-07-21T01:52:50.015+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-UTILS-1.1.0.21), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo id(HDP-UTILS-1.1.0.21), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/ubuntu14) ``` I think date format of the ambari-audit.log (2016-07-21T01:52:49.875+09) should be like 2016-07-21T01:52:49.875+0900, since grok-pattern can't handle 2016-07-21T01:52:49.875+09 format. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java ea6524f ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 5f751bf Diff: https://reviews.apache.org/r/50653/diff/ Testing --- mvn clean test Thanks, Masahiro Tanaka
Re: Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date
> On 8月 2, 2016, 1:58 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java,
> > line 51
> > <https://reviews.apache.org/r/50653/diff/1/?file=1459056#file1459056line51>
> >
> > The 'X' stands for the ISO timezone representation.
> >
> > I think grok supports ISO timezone format as well. Can you confirm that
> > grok patterns do not support iso 8061 timezone format?
> >
> > If it doesn't than go ahead and change for X to Z
>
> Masahiro Tanaka wrote:
> Thank you for reviewing! I used [this
> site](https://grokdebug.herokuapp.com/) to check if the pattern is able to
> parse the log.
> Please try pattern A and pattern B below.
>
> Pattern A:
> ```
> # input
> 2016-07-21T01:52:49.875+09, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo
> id(HDP-2.5), Base
> URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025)
>
> # pattern
> (?m)^%{TIMESTAMP_ISO8601:logtime},%{SPACE}%{GREEDYDATA:log_message}
> ```
>
> Pattern B:
> ```
> # input (timestamp is different from above, others are the same)
> 2016-07-21T01:52:49.875+0900, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo
> id(HDP-2.5), Base
> URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025)
>
> # pattern
> (?m)^%{TIMESTAMP_ISO8601:logtime},%{SPACE}%{GREEDYDATA:log_message}
> ```
>
> Sebastian Toader wrote:
> Can you try ```return new
> SimpleDateFormat("-MM-dd'T'HH:mm:ss.SSS**XX**");```? According to the
> documentation is a single pattern letter is used than any fraction of an hour
> is ignored. For example, if the pattern is "X" and the time zone is
> "GMT+05:30", "+05" is produced.
>
> Sebastian Toader wrote:
> I meant: SimpleDateFormat("-MM-dd'T'HH:mm:ss.SSSXX")
>
> Masahiro Tanaka wrote:
> I've tried that. The result (`/var/log/ambari-server/ambari-audit.log` is
> like as below
> ```
> 2016-08-02T21:57:58.799+0900, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/redhat6/repositories/HDP-UTILS-1.1.0.21),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(redhat6), Repo
> id(HDP-UTILS-1.1.0.21), Base
> URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos6)
> 2016-08-02T21:57:58.810+0900, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/redhat7/repositories/HDP-UTILS-1.1.0.21),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(redhat7), Repo
> id(HDP-UTILS-1.1.0.21), Base
> URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7)
> 2016-08-02T21:57:58.816+0900, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/debian7/repositories/HDP-UTILS-1.1.0.21),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(debian7), Repo
> id(HDP-UTILS-1.1.0.21), Base
> URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/debian7)
> 2016-08-02T21:57:58.823+0900, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/redhat6/repositories/HDP-2.5),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(redhat6), Repo
> id(HDP-2.5), Base
> URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-1116)
> ```
>
> I think this format is same as
> `SimpleDateFormat("-MM-dd'T'HH:mm:ss.SSSZ");` at least in JST.
>
> Oliver Szabo wrote:
> in SimpleDateFormat:
> Z Time zone RFC 822 time zone -0800
> X Time zone ISO 8601 time zone -08; -0800; -08:00
>
>
Re: Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date
> On Aug. 2, 2016, 1:58 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java,
> > line 51
> > <https://reviews.apache.org/r/50653/diff/1/?file=1459056#file1459056line51>
> >
> > The 'X' stands for the ISO timezone representation.
> >
> > I think grok supports ISO timezone format as well. Can you confirm that
> > grok patterns do not support iso 8061 timezone format?
> >
> > If it doesn't than go ahead and change for X to Z
>
> Masahiro Tanaka wrote:
> Thank you for reviewing! I used [this
> site](https://grokdebug.herokuapp.com/) to check if the pattern is able to
> parse the log.
> Please try pattern A and pattern B below.
>
> Pattern A:
> ```
> # input
> 2016-07-21T01:52:49.875+09, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo
> id(HDP-2.5), Base
> URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025)
>
> # pattern
> (?m)^%{TIMESTAMP_ISO8601:logtime},%{SPACE}%{GREEDYDATA:log_message}
> ```
>
> Pattern B:
> ```
> # input (timestamp is different from above, others are the same)
> 2016-07-21T01:52:49.875+0900, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo
> id(HDP-2.5), Base
> URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025)
>
> # pattern
> (?m)^%{TIMESTAMP_ISO8601:logtime},%{SPACE}%{GREEDYDATA:log_message}
> ```
>
> Sebastian Toader wrote:
> Can you try ```return new
> SimpleDateFormat("-MM-dd'T'HH:mm:ss.SSS**XX**");```? According to the
> documentation is a single pattern letter is used than any fraction of an hour
> is ignored. For example, if the pattern is "X" and the time zone is
> "GMT+05:30", "+05" is produced.
>
> Sebastian Toader wrote:
> I meant: SimpleDateFormat("-MM-dd'T'HH:mm:ss.SSSXX")
I've tried that. The result (`/var/log/ambari-server/ambari-audit.log` is like
as below
```
2016-08-02T21:57:58.799+0900, User(admin), RemoteIp(192.168.72.1),
Operation(Repository update), RequestType(PUT),
url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/redhat6/repositories/HDP-UTILS-1.1.0.21),
ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(redhat6), Repo
id(HDP-UTILS-1.1.0.21), Base
URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos6)
2016-08-02T21:57:58.810+0900, User(admin), RemoteIp(192.168.72.1),
Operation(Repository update), RequestType(PUT),
url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/redhat7/repositories/HDP-UTILS-1.1.0.21),
ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(redhat7), Repo
id(HDP-UTILS-1.1.0.21), Base
URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7)
2016-08-02T21:57:58.816+0900, User(admin), RemoteIp(192.168.72.1),
Operation(Repository update), RequestType(PUT),
url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/debian7/repositories/HDP-UTILS-1.1.0.21),
ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(debian7), Repo
id(HDP-UTILS-1.1.0.21), Base
URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/debian7)
2016-08-02T21:57:58.823+0900, User(admin), RemoteIp(192.168.72.1),
Operation(Repository update), RequestType(PUT),
url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/redhat6/repositories/HDP-2.5),
ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(redhat6), Repo
id(HDP-2.5), Base
URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-1116)
```
I think this format is same as
`SimpleDateFormat("-MM-dd'T'HH:mm:ss.SSSZ");` at least in JST.
- Masahiro
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50653/#review144381
---
On Aug. 1, 2016, 7:23 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50653/
>
Re: Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date
> On Aug. 2, 2016, 1:58 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java,
> > line 51
> > <https://reviews.apache.org/r/50653/diff/1/?file=1459056#file1459056line51>
> >
> > The 'X' stands for the ISO timezone representation.
> >
> > I think grok supports ISO timezone format as well. Can you confirm that
> > grok patterns do not support iso 8061 timezone format?
> >
> > If it doesn't than go ahead and change for X to Z
Thank you for reviewing! I used [this site](https://grokdebug.herokuapp.com/)
to check if the pattern is able to parse the log.
Please try pattern A and pattern B below.
Pattern A:
```
# input
2016-07-21T01:52:49.875+09, User(admin), RemoteIp(192.168.72.1),
Operation(Repository update), RequestType(PUT),
url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5),
ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo
id(HDP-2.5), Base
URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025)
# pattern
(?m)^%{TIMESTAMP_ISO8601:logtime},%{SPACE}%{GREEDYDATA:log_message}
```
Pattern B:
```
# input (timestamp is different from above, others are the same)
2016-07-21T01:52:49.875+0900, User(admin), RemoteIp(192.168.72.1),
Operation(Repository update), RequestType(PUT),
url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5),
ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo
id(HDP-2.5), Base
URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025)
# pattern
(?m)^%{TIMESTAMP_ISO8601:logtime},%{SPACE}%{GREEDYDATA:log_message}
```
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50653/#review144381
-------
On Aug. 1, 2016, 7:23 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50653/
> ---
>
> (Updated Aug. 1, 2016, 7:23 p.m.)
>
>
> Review request for Ambari, Daniel Gergely, Dmytro Sen, Oliver Szabo, and
> Sebastian Toader.
>
>
> Bugs: AMBARI-17308
> https://issues.apache.org/jira/browse/AMBARI-17308
>
>
> Repository: ambari
>
>
> Description
> ---
>
> In logsearch_feeder service log, we got errors like below
> ```
> 2016-06-20 15:28:09,368 ERROR file=ambari-audit.log
> org.apache.ambari.logfeeder.mapper.MapperDate LogFeederUtil.java:356 - Error
> applying date transformation. isEpoch=false,
> dateFormat=-MM-dd'T'HH:mm:ss.SSSZ, value=2016-06-20T15:28:08.000.
> mapClass=map_date, input=input:source=file,
> path=/var/log/ambari-server/ambari-audit.log, fieldName=logtime. Messages
> suppressed before: 2
> java.text.ParseException: Unparseable date: "2016-06-20T15:28:08.000"
> at java.text.DateFormat.parse(DateFormat.java:366)
> at
> org.apache.ambari.logfeeder.mapper.MapperDate.apply(MapperDate.java:83)
> at org.apache.ambari.logfeeder.filter.Filter.apply(Filter.java:154)
> at
> org.apache.ambari.logfeeder.filter.FilterGrok.applyMessage(FilterGrok.java:291)
> at
> org.apache.ambari.logfeeder.filter.FilterGrok.flush(FilterGrok.java:320)
> at org.apache.ambari.logfeeder.input.Input.flush(Input.java:125)
> at
> org.apache.ambari.logfeeder.input.InputFile.processFile(InputFile.java:430)
> at org.apache.ambari.logfeeder.input.InputFile.start(InputFile.java:260)
> at org.apache.ambari.logfeeder.input.Input.run(Input.java:100)
> at java.lang.Thread.run(Thread.java:745)
> ```
> ambari-audit.log is like below
> ```
> 2016-07-21T01:52:49.875+09, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo
> id(HDP-2.5), Base
> URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025)
> 2016-07-21T01:52:49.905+09, User(admin), RemoteIp(192.168.72.1),
> Operation(Repository update), RequestType(PUT),
> url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu16/repositories/HDP-2.5),
> ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu16), Repo
> id(HDP-2.5), Base
> URL(http://s3.amazonaws.com/de
Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50653/ --- Review request for Ambari, Daniel Gergely, Dmytro Sen, Oliver Szabo, and Sebastian Toader. Bugs: AMBARI-17308 https://issues.apache.org/jira/browse/AMBARI-17308 Repository: ambari Description --- In logsearch_feeder service log, we got errors like below ``` 2016-06-20 15:28:09,368 ERROR file=ambari-audit.log org.apache.ambari.logfeeder.mapper.MapperDate LogFeederUtil.java:356 - Error applying date transformation. isEpoch=false, dateFormat=-MM-dd'T'HH:mm:ss.SSSZ, value=2016-06-20T15:28:08.000. mapClass=map_date, input=input:source=file, path=/var/log/ambari-server/ambari-audit.log, fieldName=logtime. Messages suppressed before: 2 java.text.ParseException: Unparseable date: "2016-06-20T15:28:08.000" at java.text.DateFormat.parse(DateFormat.java:366) at org.apache.ambari.logfeeder.mapper.MapperDate.apply(MapperDate.java:83) at org.apache.ambari.logfeeder.filter.Filter.apply(Filter.java:154) at org.apache.ambari.logfeeder.filter.FilterGrok.applyMessage(FilterGrok.java:291) at org.apache.ambari.logfeeder.filter.FilterGrok.flush(FilterGrok.java:320) at org.apache.ambari.logfeeder.input.Input.flush(Input.java:125) at org.apache.ambari.logfeeder.input.InputFile.processFile(InputFile.java:430) at org.apache.ambari.logfeeder.input.InputFile.start(InputFile.java:260) at org.apache.ambari.logfeeder.input.Input.run(Input.java:100) at java.lang.Thread.run(Thread.java:745) ``` ambari-audit.log is like below ``` 2016-07-21T01:52:49.875+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-2.5), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo id(HDP-2.5), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu14/2.x/BUILDS/2.5.0.0-1025) 2016-07-21T01:52:49.905+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu16/repositories/HDP-2.5), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu16), Repo id(HDP-2.5), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP/ubuntu16/2.x/BUILDS/2.5.0.0-1025) 2016-07-21T01:52:50.015+09, User(admin), RemoteIp(192.168.72.1), Operation(Repository update), RequestType(PUT), url(http://192.168.72.101:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/ubuntu14/repositories/HDP-UTILS-1.1.0.21), ResultStatus(200 OK), Stack(HDP), Stack version(2.5), OS(ubuntu14), Repo id(HDP-UTILS-1.1.0.21), Base URL(http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.21/repos/ubuntu14) ``` I think date format of the ambari-audit.log (2016-07-21T01:52:49.875+09) should be like 2016-07-21T01:52:49.875+0900, since grok-pattern can't handle 2016-07-21T01:52:49.875+09 format. Diffs - ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java ea6524f ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 5f751bf Diff: https://reviews.apache.org/r/50653/diff/ Testing --- mvn clean test Thanks, Masahiro Tanaka
Review Request 50475: AMBARI-17778 Add usage information in ambari-server script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50475/ --- Review request for Ambari, Nate Cole, Sebastian Toader, Sid Wagle, and Yusaku Sako. Bugs: AMBARI-17778 https://issues.apache.org/jira/browse/AMBARI-17778 Repository: ambari Description --- In ambari-server script, there are some lacks of usage information (e.g. install-mpack, upgrade-mpack.) They should be included in usage information. Diffs - ambari-server/sbin/ambari-server 81cf53b Diff: https://reviews.apache.org/r/50475/diff/ Testing --- ``` --1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12818681/AMBARI-17778.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7913//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7913//console This message is automatically generated. ``` & manual test Thanks, Masahiro Tanaka
Review Request 50173: AMBARI-17753 Add some of value-attributes to property files in ZOOKEEPER
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50173/ --- Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Sid Wagle. Bugs: AMBARI-17753 https://issues.apache.org/jira/browse/AMBARI-17753 Repository: ambari Description --- Some of the property files in ZOOKEEPER lack value-attributes. It would be nice to have value-attributes on most of the properties. If so, we can notice careless mistakes in Ambari Server WebUI. Diffs - ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zoo.cfg.xml 99421c0 ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/configuration/zoo.cfg.xml 41cb645 Diff: https://reviews.apache.org/r/50173/diff/ Testing --- mvn clean test See screenshot on JIRA Thanks, Masahiro Tanaka
Review Request 50171: AMBARI-17722 Add some of value-attributes to property files in TEZ
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50171/ --- Review request for Ambari, Dmitriy Lyubimov, Jayush Luniya, and Sid Wagle. Bugs: AMBARI-17722 https://issues.apache.org/jira/browse/AMBARI-17722 Repository: ambari Description --- Some of the property files in TEZ lack value-attributes. It would be nice to have value-attributes on most of the properties. If so, we can notice a careless mistakes in Ambari Server WebUI. Diffs - ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml e7a851c ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/TEZ/configuration/tez-site.xml 704022c ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml d865579 ambari-server/src/main/resources/stacks/HDP/2.3/services/TEZ/configuration/tez-site.xml 8c2c6cf ambari-server/src/main/resources/stacks/HDP/2.5/services/TEZ/configuration/tez-site.xml 382025e ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/TEZ/configuration/tez-site.xml d719322 Diff: https://reviews.apache.org/r/50171/diff/ Testing --- mvn clean test See screenshot on JIRA Thanks, Masahiro Tanaka
Review Request 50170: AMBARI-17749 Typo "rather then" in spark-default.conf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50170/ --- Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Yusaku Sako. Bugs: AMBARI-17749 https://issues.apache.org/jira/browse/AMBARI-17749 Repository: ambari Description --- There is a typo in Spark config description. See attached screenshot. Diffs - ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml c53dcd7 ambari-server/src/main/resources/common-services/SPARK/1.5.2/configuration/spark-thrift-sparkconf.xml 67120d3 Diff: https://reviews.apache.org/r/50170/diff/ Testing --- mvn clean test Thanks, Masahiro Tanaka
Re: Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49905/ --- (Updated July 15, 2016, 3:24 a.m.) Review request for Ambari, Jaimin Jetly, jun aoki, and Sumit Mohanty. Changes --- Update a patch Bugs: AMBARI-17645 https://issues.apache.org/jira/browse/AMBARI-17645 Repository: ambari Description --- The Dockerfile in dev-support uses Java 7 while its support is finished. It would be nice it is Java 8 for developing purpose. Diffs (updated) - dev-support/docker/docker/Dockerfile 802d20a Diff: https://reviews.apache.org/r/49905/diff/ Testing --- Hadooop QAed & manual tests done ``` -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12817064/AMBARI-17645.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7768//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7768//console This message is automatically generated. ``` Thanks, Masahiro Tanaka
Re: Review Request 49930: AMBARI-17614 Clean up import * for AMBARI_METRICS services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49930/#review142255 --- Thanks Juanjo Marron and Aravindan Vijayan! - Masahiro Tanaka On July 12, 2016, 7:59 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49930/ > --- > > (Updated July 12, 2016, 7:59 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Juanjo > Marron. > > > Bugs: AMBARI-17614 > https://issues.apache.org/jira/browse/AMBARI-17614 > > > Repository: ambari > > > Description > --- > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py > and > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py > uses `from resource_management import *`. It increases code tracking > difficulty. > I think this is related to AMBARI-16101 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py > 7dc66b2 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py > fa4e8a4 > > Diff: https://reviews.apache.org/r/49930/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On July 12, 2016, 6:51 a.m., Masahiro Tanaka wrote: > > Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0? > > Jonathan Hurley wrote: > That depends; there's no Fix Version on this Jira, so I don't know if > it's only going into trunk or if it's going to into branch-2.4. If you get > approval to put this in branch 2.4 from the 2.4 release manager, then you can > add it to UgpradeCatalog240. If this is going only in trunk, then you'll want > to create it a new UpgradeCatalog250. Thanks. I'll ask release manager if this patch should be into branch-2.4 or not. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141786 --- On July 12, 2016, 6:50 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated July 12, 2016, 6:50 a.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 7ef12a7 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49935/ --- (Updated July 13, 2016, 6:55 a.m.) Review request for Ambari, Andrew Onischuk, jun aoki, and Myroslav Papirkovskyy. Changes --- Update the patch Bugs: AMBARI-17633 https://issues.apache.org/jira/browse/AMBARI-17633 Repository: ambari Description --- When installing YARN+MapReduce2, I got a WARN message in nodemanager log(in Log Search View) like below ``` 2016-07-09 06:30:21,865 WARN logaggregation.LogAggregationService LogAggregationService.java:230 - Remote Root Log Dir [/app-logs] already exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: [rwxrwxrwx]. The cluster may have problems with multiple users. ``` I think the cause of this WARN is [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py#L115). We should add stickybit to yarn.nodemanager.remote-app-log-dir. Diffs (updated) - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py cf5736e ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 4600063 Diff: https://reviews.apache.org/r/49935/diff/ Testing --- mvn clean test && manual test I think Hadoop QA result is unrelated to this patch Thanks, Masahiro Tanaka
Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7
> On July 12, 2016, 5:02 p.m., Andrew Onischuk wrote: > > Committed the patch. Please close the reviewboard. thann you! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review141866 --- On July 12, 2016, 3:33 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48309/ > --- > > (Updated July 12, 2016, 3:33 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro Sen, > Florian Barca, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-17047 > https://issues.apache.org/jira/browse/AMBARI-17047 > > > Repository: ambari > > > Description > --- > > In firewall.py, `systemctl is-active iptables || systemctl is-active > firewalld` is passed to `run_in_shell` function, which splits cmd string by > using `shlex.split`. > > run_in_shell function finally calls `subprocess.Popen` with `shell=True`, so > the cmd string is evaluated like `Popen(['/bin/sh', '-c', 'systemctl', > 'is-active', 'iptables', '||', 'systemctl', 'is-active', 'firewalld'])`. This > doesn't returns values as expected, because after args[1] (in this case, > after the first `is-active`) are evaluated as sh arguements. > > `systemctl is-active` can take multiple arugments, so we can use it. > > > Diffs > - > > ambari-common/src/main/python/ambari_commons/firewall.py 72e6d26 > ambari-server/src/test/python/TestAmbariServer.py 254aeb7 > > Diff: https://reviews.apache.org/r/48309/diff/ > > > Testing > --- > > mvn clean test & manual test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.
> On July 12, 2016, 3:46 p.m., Andrew Onischuk wrote: > > Ship It! > > Andrew Onischuk wrote: > We have tests for those scripts. Are you sure they pass with your changes? Thank you for reviewing. I'm afraid I didn't check that. I'll check it soon and update. Sorry for that. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49935/#review141861 --- On July 12, 2016, 9:19 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49935/ > --- > > (Updated July 12, 2016, 9:19 a.m.) > > > Review request for Ambari, Andrew Onischuk, jun aoki, and Myroslav > Papirkovskyy. > > > Bugs: AMBARI-17633 > https://issues.apache.org/jira/browse/AMBARI-17633 > > > Repository: ambari > > > Description > --- > > When installing YARN+MapReduce2, I got a WARN message in nodemanager log(in > Log Search View) like below > ``` > 2016-07-09 06:30:21,865 WARN logaggregation.LogAggregationService > LogAggregationService.java:230 - Remote Root Log Dir [/app-logs] already > exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: > [rwxrwxrwx]. The cluster may have problems with multiple users. > ``` > I think the cause of this WARN is > [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py#L115). > We should add stickybit to yarn.nodemanager.remote-app-log-dir. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py > ce312e0 > > Diff: https://reviews.apache.org/r/49935/diff/ > > > Testing > --- > > mvn clean test && manual test > > I think Hadoop QA result is unrelated to this patch > > > Thanks, > > Masahiro Tanaka > >
Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49935/ --- Review request for Ambari, Andrew Onischuk, jun aoki, and Myroslav Papirkovskyy. Bugs: AMBARI-17633 https://issues.apache.org/jira/browse/AMBARI-17633 Repository: ambari Description --- When installing YARN+MapReduce2, I got a WARN message in nodemanager log(in Log Search View) like below ``` 2016-07-09 06:30:21,865 WARN logaggregation.LogAggregationService LogAggregationService.java:230 - Remote Root Log Dir [/app-logs] already exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: [rwxrwxrwx]. The cluster may have problems with multiple users. ``` I think the cause of this WARN is [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py#L115). We should add stickybit to yarn.nodemanager.remote-app-log-dir. Diffs - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py ce312e0 Diff: https://reviews.apache.org/r/49935/diff/ Testing --- mvn clean test && manual test I think Hadoop QA result is unrelated to this patch Thanks, Masahiro Tanaka
Review Request 49930: AMBARI-17614 Clean up import * for AMBARI_METRICS services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49930/ --- Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Juanjo Marron. Bugs: AMBARI-17614 https://issues.apache.org/jira/browse/AMBARI-17614 Repository: ambari Description --- ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py and ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py uses `from resource_management import *`. It increases code tracking difficulty. I think this is related to AMBARI-16101 Diffs - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py 7dc66b2 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py fa4e8a4 Diff: https://reviews.apache.org/r/49930/diff/ Testing --- mvn clean test Thanks, Masahiro Tanaka
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141786 --- Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0? - Masahiro Tanaka On July 11, 2016, 9:50 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated July 11, 2016, 9:50 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 7ef12a7 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- (Updated July 11, 2016, 9:50 p.m.) Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. Changes --- Update a patch Bugs: AMBARI-17253 https://issues.apache.org/jira/browse/AMBARI-17253 Repository: ambari Description --- There are too many WARNING in ZooKeeper log. ``` 2016-06-15 21:02:15,405 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of stream exception EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) at java.lang.Thread.run(Thread.java:745) ``` It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port to do monitoring. We should use 'ruok' to monitor zookeepers. Diffs (updated) - ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java d7279de ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 7ef12a7 ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 469036a Diff: https://reviews.apache.org/r/48972/diff/ Testing --- mvn clean test ``` +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console This message is automatically generated. ``` Thanks, Masahiro Tanaka
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On July 11, 2016, 3:46 p.m., Jonathan Hurley wrote: > > Thank you for reviewing! I'm going to fix the issues, and wait till the other reviewers leave comments that we should use `parameters` or not. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141703 --- On July 8, 2016, 8:20 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated July 8, 2016, 8:20 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 7ef12a7 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49905/ --- (Updated July 11, 2016, 5:27 p.m.) Review request for Ambari, Jaimin Jetly, jun aoki, and Sumit Mohanty. Bugs: AMBARI-17645 https://issues.apache.org/jira/browse/AMBARI-17645 Repository: ambari Description --- The Dockerfile in dev-support uses Java 7 while its support is finished. It would be nice it is Java 8 for developing purpose. Diffs - dev-support/docker/docker/Dockerfile 802d20a Diff: https://reviews.apache.org/r/49905/diff/ Testing (updated) --- Hadooop QAed & manual tests done ``` -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12817064/AMBARI-17645.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7768//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7768//console This message is automatically generated. ``` Thanks, Masahiro Tanaka
Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49905/ --- Review request for Ambari, Jaimin Jetly, jun aoki, and Sumit Mohanty. Bugs: AMBARI-17645 https://issues.apache.org/jira/browse/AMBARI-17645 Repository: ambari Description --- The Dockerfile in dev-support uses Java 7 while its support is finished. It would be nice it is Java 8 for developing purpose. Diffs - dev-support/docker/docker/Dockerfile 802d20a Diff: https://reviews.apache.org/r/49905/diff/ Testing --- ``` -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12817064/AMBARI-17645.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7768//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7768//console This message is automatically generated. ``` Thanks, Masahiro Tanaka
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On July 8, 2016, 8:45 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines 68-71 > > <https://reviews.apache.org/r/48972/diff/4/?file=1439903#file1439903line68> > > > > We use underscore notation in our json, not dotted names. Match for > > consistency. > > Masahiro Tanaka wrote: > Thank you for reviewing! I checked other `alerts.json` which uses > `parameters` attributes, and they use dotted name (see > [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json#L194)) > > Should I use underscore? (Like, `socket_command`)? > > Nate Cole wrote: > Bah! :) Ok, I guess dotted is fine. We are supposed to keep things > consistent, but I guess not everyone knows that. You can drop the issue. > Just make sure Jonathan reviews before pushing. OK, I'll wait Jonathan review. Thanks again! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141332 ------- On July 8, 2016, 8:20 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated July 8, 2016, 8:20 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 7ef12a7 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On July 8, 2016, 8:45 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines 68-71 > > <https://reviews.apache.org/r/48972/diff/4/?file=1439903#file1439903line68> > > > > We use underscore notation in our json, not dotted names. Match for > > consistency. Thank you for reviewing! I checked other `alerts.json` which uses `parameters` attributes, and they use dotted name (see [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json#L194)) Should I use underscore? (Like, `socket_command`)? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141332 --- On July 8, 2016, 8:20 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated July 8, 2016, 8:20 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 7ef12a7 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- (Updated July 8, 2016, 8:20 p.m.) Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. Changes --- Update the patch * Check response message * Dealing with Ambari Upgrade Bugs: AMBARI-17253 https://issues.apache.org/jira/browse/AMBARI-17253 Repository: ambari Description --- There are too many WARNING in ZooKeeper log. ``` 2016-06-15 21:02:15,405 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of stream exception EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) at java.lang.Thread.run(Thread.java:745) ``` It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port to do monitoring. We should use 'ruok' to monitor zookeepers. Diffs (updated) - ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java d7279de ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 7ef12a7 ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 469036a Diff: https://reviews.apache.org/r/48972/diff/ Testing --- mvn clean test ``` +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console This message is automatically generated. ``` Thanks, Masahiro Tanaka
Review Request 49735: AMBARI-17570 Lack of importing ClientComponentHasNoStatus
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49735/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo Marron. Bugs: AMBARI-17570 https://issues.apache.org/jira/browse/AMBARI-17570 Repository: ambari Description --- Some of the *_client.py files (e.g. ambari/ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py) don't import ClientComponentHasNoStatus while it is used. It should be imported. Diffs - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 1e7ed1f3 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py f8c33dd ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 93d244d ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 1f85fc0 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py 5a398db ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 7c5b6e0 ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 111f4d2 ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 99314ec ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_client.py fac92e1 Diff: https://reviews.apache.org/r/49735/diff/ Testing --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12816319/AMBARI-17570.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7710//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7710//console This message is automatically generated. Thanks, Masahiro Tanaka
Re: Review Request 48971: AMBARI-17291 zookeeper.quorum in storm-metrics2.properties is broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48971/ --- (Updated July 5, 2016, 6:20 p.m.) Review request for Ambari, Andrew Onischuk, Gautam Borad, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-17291 https://issues.apache.org/jira/browse/AMBARI-17291 Repository: ambari Description (updated) --- When installed Storm and Ambari Metrics, `zookeeper.quorum` in /etc/storm/conf/storm-metrics2.properties is looks like this. ``` zookeeper.quorum=[:2181,':2181,c:2181,7:2181,2:2181,0:2181,1:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,,:2181,':2181,c:2181,7:2181,2:2181,0:2181,2:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,,:2181,':2181,c:2181,7:2181,2:2181,0:2181,3:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,]:2181 ``` storm.zookeeper.servers is `'c7201.ambari.apache.org','c7202.ambari.apache.org','c7203.ambari.apache.org']` Steps to reproduce. 1. Install Ambari Server (I used `http://s3.amazonaws.com/dev.hortonworks.com/ambari/centos7/2.x/latest/trunk/ambaribn.repo`) 2. Setup and start Ambari Server (`ambari-server setup -s` and `ambari-server start`) 3. Install Storm and ZooKeeper via Ambari Server (HDP2.4) 4. Install Ambari Metrics 5. Restart all required Diffs - ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py fac6331 Diff: https://reviews.apache.org/r/48971/diff/ Testing --- mvn clean test && manual test ``` --1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12811836/AMBARI-17291.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The test build failed in ambari-server Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7426//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7426//console This message is automatically generated. ``` Core test fails seems unrelated to this patch Thanks, Masahiro Tanaka
Re: Review Request 48971: AMBARI-17291 zookeeper.quorum in storm-metrics2.properties is broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48971/ --- (Updated July 5, 2016, 6:16 p.m.) Review request for Ambari, Andrew Onischuk, Gautam Borad, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-17291 https://issues.apache.org/jira/browse/AMBARI-17291 Repository: ambari Description (updated) --- When installed Storm and Ambari Metrics, `zookeeper.quorum` in /etc/storm/conf/storm-metrics2.properties is looks like this. ``` zookeeper.quorum=[:2181,':2181,c:2181,7:2181,2:2181,0:2181,1:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,,:2181,':2181,c:2181,7:2181,2:2181,0:2181,2:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,,:2181,':2181,c:2181,7:2181,2:2181,0:2181,3:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,]:2181 ``` storm.zookeeper.servers is `'c7201.ambari.apache.org','c7202.ambari.apache.org','c7203.ambari.apache.org']` Steps to reproduce. 1. Install Ambari Server (I used `http://s3.amazonaws.com/dev.hortonworks.com/ambari/centos7/2.x/latest/trunk/ambaribn.repo`) 2. Setup and start Ambari Server (`ambari-server setup -s` and `ambari-server start`) 3. Install Storm and ZooKeeper via Ambari Server 4. Install Ambari Metrics 5. Restart all required Diffs - ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py fac6331 Diff: https://reviews.apache.org/r/48971/diff/ Testing --- mvn clean test && manual test ``` --1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12811836/AMBARI-17291.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The test build failed in ambari-server Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7426//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7426//console This message is automatically generated. ``` Core test fails seems unrelated to this patch Thanks, Masahiro Tanaka
Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/
---
(Updated July 5, 2016, 4:38 a.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
Changes
---
Update the patch
Bugs: AMBARI-17184
https://issues.apache.org/jira/browse/AMBARI-17184
Repository: ambari
Description
---
When we wanted to restart HBase, we got an error
```
Traceback (most recent call last):
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
line 159, in
HbaseMaster().execute()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 257, in execute
method(env)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 686, in restart
self.start(env, upgrade_type=upgrade_type)
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
line 86, in start
self.configure(env) # for security
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
line 41, in configure
hbase(name='master')
File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py",
line 89, in thunk
return fn(*args, **kwargs)
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
line 166, in hbase
tag = 'GANGLIA-MASTER' if name == 'master' else 'GANGLIA-RS'
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
line 233, in hbase_TemplateConfig
template_tag = tag
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py",
line 155, in __init__
self.env.run()
File
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
line 160, in run
self.run_action(resource, action)
File
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
line 124, in run_action
provider_action()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/template_config.py",
line 46, in action_create
content = Template(template_name, extra_imports=self.resource.extra_imports)
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py",
line 155, in __init__
self.env.run()
File
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
line 160, in run
self.run_action(resource, action)
File
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
line 124, in run_action
provider_action()
File
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
line 123, in action_create
content = self._get_content()
File
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
line 160, in _get_content
return content()
File "/usr/lib/python2.6/site-packages/resource_management/core/source.py",
line 51, in __call__
return self.get_content()
File "/usr/lib/python2.6/site-packages/resource_management/core/source.py",
line 142, in get_content
rendered = self.template.render(self.context)
File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line
891, in render
return self.environment.handle_exception(exc_info, True)
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2",
line 76, in top-level template code
hbase.sink.timeline.truststore.password = {{metric_truststore_password}}
ambari_jinja2.exceptions.UndefinedError: 'metric_collector_hosts' is undefined
```
We should define metric_collector_hosts in
ambari/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
Diffs (updated)
-
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
6d304d4
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
dcec3d4
Diff: https://reviews.apache.org/r/48628/diff/
Testing
---
mvn clean test && manual test
Thanks,
Masahiro Tanaka
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On July 4, 2016, 10:58 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json, > > line 43 > > <https://reviews.apache.org/r/48972/diff/3/?file=1436506#file1436506line43> > > > > What about a response? In this case, ZK will response with `imok` ... > > we should probably check that value if it's OK. > > Masahiro Tanaka wrote: > yes, but if the code checks the response, I don't know how to write test > codes. > > Jonathan Hurley wrote: > You can mock out socket to return a specific code always. If you don't > think that checking the code is necessary, you can drop this. However, I > figured since ZK offers an actual value to check we could check it. Thanks. I'll update the mock. On July 4, 2016, 10:58 p.m., Masahiro Tanaka wrote: > > What about existing clusters? We probably need to modify any existing ZK > > alerts with this using the UpgradeCatalog. > > Masahiro Tanaka wrote: > Thank you for reviewing. Which one should we change, > `UpgradeCatalog230.java`, or `UpgradeCatalog240.java`? > > Jonathan Hurley wrote: > Always the latest one for the release (or the branch). Since we're > readying the 2.4 release, then you can edit UpgadeCatalog240. If you > backported this to, say, the 2.2 branch (as an example), you'd edit > UpgradeCatalog220. Thanks. I'll update UpgradeCatalog240 and UpgradeCatalog220 - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review140707 --- On July 4, 2016, 7:01 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated July 4, 2016, 7:01 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On July 4, 2016, 10:58 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json, > > line 43 > > <https://reviews.apache.org/r/48972/diff/3/?file=1436506#file1436506line43> > > > > What about a response? In this case, ZK will response with `imok` ... > > we should probably check that value if it's OK. yes, but if the code checks the response, I don't know how to write test codes. On July 4, 2016, 10:58 p.m., Masahiro Tanaka wrote: > > What about existing clusters? We probably need to modify any existing ZK > > alerts with this using the UpgradeCatalog. Thank you for reviewing. Which one should we change, `UpgradeCatalog230.java`, or `UpgradeCatalog240.java`? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review140707 ------- On July 4, 2016, 7:01 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated July 4, 2016, 7:01 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On June 25, 2016, 10:29 p.m., Nate Cole wrote: > > Latest patch still seems like forced solution. Why not just allow the > > alert definition to provide "data" attribute (or whatever) in json that > > port_alert can use? > > Masahiro Tanaka wrote: > Thanks for reviewing. I've tried to chagne the code as you said, but that > requires to change the Ambari metadata DB schema. > It seemed exaggerated to me, but the fact is remained that my latest > patch isn't a simple solution. > > Which one do you (or community) prefer? I'll try to follw the idea. > > Nate Cole wrote: > If you change the "source" part of the definition (or use "parameters" > object in that) then you don't need to change schema. Sorry for the late reply, and thank you for advise. I update the patch, just to add "socket_command" attribute in "source" part - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review139457 --- On July 4, 2016, 7:01 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated July 4, 2016, 7:01 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- (Updated July 4, 2016, 7:01 p.m.) Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. Bugs: AMBARI-17253 https://issues.apache.org/jira/browse/AMBARI-17253 Repository: ambari Description --- There are too many WARNING in ZooKeeper log. ``` 2016-06-15 21:02:15,405 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of stream exception EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) at java.lang.Thread.run(Thread.java:745) ``` It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port to do monitoring. We should use 'ruok' to monitor zookeepers. Diffs (updated) - ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java d7279de ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 469036a Diff: https://reviews.apache.org/r/48972/diff/ Testing --- mvn clean test ``` +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console This message is automatically generated. ``` Thanks, Masahiro Tanaka
Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable
> On June 28, 2016, 2:52 a.m., Sid Wagle wrote:
> > hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 Should also be change to use
> > the comma separated host:port field.
Thank you for reviewing! I'll update the patch in a few days.
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/#review139719
---
On June 13, 2016, 10:24 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48628/
> ---
>
> (Updated June 13, 2016, 10:24 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid
> Wagle.
>
>
> Bugs: AMBARI-17184
> https://issues.apache.org/jira/browse/AMBARI-17184
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When we wanted to restart HBase, we got an error
> ```
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
> line 159, in
> HbaseMaster().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 257, in execute
> method(env)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 686, in restart
> self.start(env, upgrade_type=upgrade_type)
> File
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
> line 86, in start
> self.configure(env) # for security
> File
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
> line 41, in configure
> hbase(name='master')
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py",
> line 89, in thunk
> return fn(*args, **kwargs)
> File
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
> line 166, in hbase
> tag = 'GANGLIA-MASTER' if name == 'master' else 'GANGLIA-RS'
> File
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
> line 233, in hbase_TemplateConfig
> template_tag = tag
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py",
> line 155, in __init__
> self.env.run()
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 160, in run
> self.run_action(resource, action)
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 124, in run_action
> provider_action()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/template_config.py",
> line 46, in action_create
> content = Template(template_name,
> extra_imports=self.resource.extra_imports)
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py",
> line 155, in __init__
> self.env.run()
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 160, in run
> self.run_action(resource, action)
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 124, in run_action
> provider_action()
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
> line 123, in action_create
> content = self._get_content()
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
> line 160, in _get_content
> return content()
> File "/usr/lib/python2.6/site-packages/resource_management/core/source.py",
> line 51, in __call__
> return self.get_content()
> File "/usr/lib/python2.6/site-packages/resource_management/core/source.py",
> line 142, in get_content
> rendered = self.template.render(self.context)
> File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line
> 891, in render
> return self.environment.handle_exception(exc_info, True)
> File
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2",
> line 76, in top-level template code
> hbase.sink.timeline.truststore.password = {{metr
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On June 26, 2016, 1:56 a.m., Jonathan Hurley wrote:
> > ambari-agent/conf/unix/ambari-agent.ini, line 40
> > <https://reviews.apache.org/r/48972/diff/2/?file=1430174#file1430174line40>
> >
> > This is still not supportable as it's based off of a specific alert
> > name. Also, it's on a per-agent basis where it should be on a
> > per-definition basis.
> >
> > What we should be doing for this is extending the Alert Definition for
> > type PORT to include this optional information.
Okay, so I'll entend alerts.json (adding an attribute to specify some command)
which is in ZOOKEEPER like below:
```
(snip)
"ZOOKEEPER_SERVER": [
{
"name": "zookeeper_server_process",
"label": "ZooKeeper Server Process",
"description": "This host-level alert is triggered if the ZooKeeper
server process cannot be determined to be up and listening on the network.",
"interval": 1,
"scope": "ANY",
"source": {
"type": "PORT",
"uri": "{{zoo.cfg/clientPort}}",
"default_port": 2181,
"socket_command": "ruok",# insert this line
"reporting": {
(snip)
```
and update some other related codes.Thanks for suggestion.
- Masahiro
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review139466
---
On June 25, 2016, 1:54 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
>
> (Updated June 25, 2016, 1:54 p.m.)
>
>
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-17253
> https://issues.apache.org/jira/browse/AMBARI-17253
>
>
> Repository: ambari
>
>
> Description
> ---
>
> There are too many WARNING in ZooKeeper log.
> ```
> 2016-06-15 21:02:15,405 - WARN
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of
> stream exception
> EndOfStreamException: Unable to read additional data from client sessionid
> 0x0, likely client has closed socket
> at
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> at
> org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
> at java.lang.Thread.run(Thread.java:745)
> ```
>
> It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port
> to do monitoring.
> We should use 'ruok' to monitor zookeepers.
>
>
> Diffs
> -
>
> ambari-agent/conf/unix/ambari-agent.ini 914e09a
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0
> ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327
> ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py
> 1202c81
> ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c
>
> Diff: https://reviews.apache.org/r/48972/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
> ```
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results:
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
> Console output:
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
> This message is automatically generated.
> ```
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On June 25, 2016, 10:29 p.m., Nate Cole wrote: > > Latest patch still seems like forced solution. Why not just allow the > > alert definition to provide "data" attribute (or whatever) in json that > > port_alert can use? Thanks for reviewing. I've tried to chagne the code as you said, but that requires to change the Ambari metadata DB schema. It seemed exaggerated to me, but the fact is remained that my latest patch isn't a simple solution. Which one do you (or community) prefer? I'll try to follw the idea. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review139457 --- On June 25, 2016, 1:54 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated June 25, 2016, 1:54 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/conf/unix/ambari-agent.ini 914e09a > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py > 1202c81 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On June 21, 2016, 3:05 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines > > 133-135 > > <https://reviews.apache.org/r/48972/diff/1/?file=1425784#file1425784line133> > > > > We don't hardcode specific workarounds into the alerts framework. It's > > not maintainable. > > Masahiro Tanaka wrote: > Thank you for reviewing Jonathan! I'll update the patch to respond to > your comment. I adde a new property `port_alert_socket_commands` in `ambari-agent.ini` to specify the workaround and use it in `port_alert.py`. Could you please check it? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review138843 ------- On June 25, 2016, 1:54 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated June 25, 2016, 1:54 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/conf/unix/ambari-agent.ini 914e09a > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py > 1202c81 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- (Updated June 25, 2016, 1:54 p.m.) Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. Changes --- Update the patch Bugs: AMBARI-17253 https://issues.apache.org/jira/browse/AMBARI-17253 Repository: ambari Description --- There are too many WARNING in ZooKeeper log. ``` 2016-06-15 21:02:15,405 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of stream exception EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) at java.lang.Thread.run(Thread.java:745) ``` It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port to do monitoring. We should use 'ruok' to monitor zookeepers. Diffs (updated) - ambari-agent/conf/unix/ambari-agent.ini 914e09a ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 1202c81 ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c Diff: https://reviews.apache.org/r/48972/diff/ Testing --- mvn clean test ``` +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console This message is automatically generated. ``` Thanks, Masahiro Tanaka
Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
> On 6月 21, 2016, 3:05 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines > > 133-135 > > <https://reviews.apache.org/r/48972/diff/1/?file=1425784#file1425784line133> > > > > We don't hardcode specific workarounds into the alerts framework. It's > > not maintainable. Thank you for reviewing Jonathan! I'll update the patch to respond to your comment. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review138843 --- On 6月 20, 2016, 10:29 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > --- > > (Updated 6月 20, 2016, 10:29 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > --- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > --- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48829: AMBARI-17245 Failed to start Hive metastore due to UnicodeDecodeError
> On June 17, 2016, 9:44 a.m., Andrew Onischuk wrote:
> > Ship It!
Thank you! could you commit this ?
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48829/#review138187
---
On June 17, 2016, 12:18 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48829/
> ---
>
> (Updated June 17, 2016, 12:18 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and jun aoki.
>
>
> Bugs: AMBARI-17245
> https://issues.apache.org/jira/browse/AMBARI-17245
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When we start hivemestore in the environment described above, we got an error
> ```
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py",
> line 254, in
> HiveMetastore().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 257, in execute
> method(env)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 686, in restart
> self.start(env, upgrade_type=upgrade_type)
> File
> "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py",
> line 61, in start
> hive_service('metastore', action='start', upgrade_type=upgrade_type)
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py",
> line 89, in thunk
> return fn(*args, **kwargs)
> File
> "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py",
> line 70, in hive_service
> pid = get_user_call_output.get_user_call_output(format("cat {pid_file}"),
> user=params.hive_user, is_checked_call=False)[1]
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/get_user_call_output.py",
> line 59, in get_user_call_output
> err_msg = Logger.filter_text(("Execution of '%s' returned %d. %s") %
> (command_string, code, all_output))
> File "/usr/lib/python2.6/site-packages/resource_management/core/logger.py",
> line 101, in filter_text
> text = text.replace(unprotected_string, protected_string)
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xe3 in position 117:
> ordinal not in range(128)
> ```
> I think the reason why this error occurs is because
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/get_user_call_output.py".
> This script calls system command (e.g. cat), writes stdout & stderr in the
> tempfile, and read it. The outputs (stdout, stderr) are in UTF-8 encoded
> Japanese in the above environment.
>
> When reading string from file, python regards the file as ASCII encoded by
> default. But if the file is utf-8 encoded, this causes an error.
>
> We should decode UTF-8 when reading the file.
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_user_call_output.py
> 016161c
>
> Diff: https://reviews.apache.org/r/48829/diff/
>
>
> Testing
> ---
>
> mvn clean test && manual test
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. Bugs: AMBARI-17253 https://issues.apache.org/jira/browse/AMBARI-17253 Repository: ambari Description --- There are too many WARNING in ZooKeeper log. ``` 2016-06-15 21:02:15,405 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of stream exception EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) at java.lang.Thread.run(Thread.java:745) ``` It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port to do monitoring. We should use 'ruok' to monitor zookeepers. Diffs - ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c Diff: https://reviews.apache.org/r/48972/diff/ Testing --- mvn clean test ``` +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console This message is automatically generated. ``` Thanks, Masahiro Tanaka
Review Request 48971: AMBARI-17291 zookeeper.quorum in storm-metrics2.properties is broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48971/ --- Review request for Ambari, Andrew Onischuk, Gautam Borad, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-17291 https://issues.apache.org/jira/browse/AMBARI-17291 Repository: ambari Description --- When installed Storm, `zookeeper.quorum` in /etc/storm/conf/storm-metrics2.properties is looks like this. ``` zookeeper.quorum=[:2181,':2181,c:2181,7:2181,2:2181,0:2181,1:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,,:2181,':2181,c:2181,7:2181,2:2181,0:2181,2:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,,:2181,':2181,c:2181,7:2181,2:2181,0:2181,3:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,]:2181 ``` storm.zookeeper.servers is `'c7201.ambari.apache.org','c7202.ambari.apache.org','c7203.ambari.apache.org']` Diffs - ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py fac6331 Diff: https://reviews.apache.org/r/48971/diff/ Testing --- mvn clean test && manual test ``` --1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12811836/AMBARI-17291.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The test build failed in ambari-server Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7426//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7426//console This message is automatically generated. ``` Core test fails seems unrelated to this patch Thanks, Masahiro Tanaka
Re: Review Request 48607: AMBARI-17181: Add some of value-attributes to property files in AMBARI_METRICS
> On June 16, 2016, 7:35 p.m., Aravindan Vijayan wrote: > > Ship It! Thank you, could you commit it? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48607/#review138067 --- On June 16, 2016, 3:55 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48607/ > --- > > (Updated June 16, 2016, 3:55 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17181 > https://issues.apache.org/jira/browse/AMBARI-17181 > > > Repository: ambari > > > Description > --- > > Some of the property files in AMBARI_METRICS lack value-attributes. > It would be nice to have value-attributes on most of the properties. If so, > we can notice a careless mistakes in Ambari Server WebUI. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml > eaafc6b > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml > da4599e > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml > 3ce1af2 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml > f4e5fb2 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > 6484285 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml > 6f9c6dc > > Diff: https://reviews.apache.org/r/48607/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Masahiro Tanaka > >
Review Request 48829: AMBARI-17245 Failed to start Hive metastore due to UnicodeDecodeError
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48829/
---
Review request for Ambari, Andrew Onischuk and jun aoki.
Bugs: AMBARI-17245
https://issues.apache.org/jira/browse/AMBARI-17245
Repository: ambari
Description
---
When we start hivemestore in the environment described above, we got an error
```
Traceback (most recent call last):
File
"/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py",
line 254, in
HiveMetastore().execute()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 257, in execute
method(env)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 686, in restart
self.start(env, upgrade_type=upgrade_type)
File
"/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py",
line 61, in start
hive_service('metastore', action='start', upgrade_type=upgrade_type)
File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py",
line 89, in thunk
return fn(*args, **kwargs)
File
"/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py",
line 70, in hive_service
pid = get_user_call_output.get_user_call_output(format("cat {pid_file}"),
user=params.hive_user, is_checked_call=False)[1]
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/get_user_call_output.py",
line 59, in get_user_call_output
err_msg = Logger.filter_text(("Execution of '%s' returned %d. %s") %
(command_string, code, all_output))
File "/usr/lib/python2.6/site-packages/resource_management/core/logger.py",
line 101, in filter_text
text = text.replace(unprotected_string, protected_string)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe3 in position 117:
ordinal not in range(128)
```
I think the reason why this error occurs is because
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/get_user_call_output.py".
This script calls system command (e.g. cat), writes stdout & stderr in the
tempfile, and read it. The outputs (stdout, stderr) are in UTF-8 encoded
Japanese in the above environment.
When reading string from file, python regards the file as ASCII encoded by
default. But if the file is utf-8 encoded, this causes an error.
We should decode UTF-8 when reading the file.
Diffs
-
ambari-common/src/main/python/resource_management/libraries/functions/get_user_call_output.py
016161c
Diff: https://reviews.apache.org/r/48829/diff/
Testing
---
mvn clean test && manual test
Thanks,
Masahiro Tanaka
Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7
> On June 13, 2016, 1:53 p.m., Andrew Onischuk wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! Could you commit it? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review137293 --- On June 7, 2016, 11:11 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48309/ > --- > > (Updated June 7, 2016, 11:11 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, Florian Barca, and > Yusaku Sako. > > > Bugs: AMBARI-17047 > https://issues.apache.org/jira/browse/AMBARI-17047 > > > Repository: ambari > > > Description > --- > > In firewall.py, `systemctl is-active iptables || systemctl is-active > firewalld` is passed to `run_in_shell` function, which splits cmd string by > using `shlex.split`. > > run_in_shell function finally calls `subprocess.Popen` with `shell=True`, so > the cmd string is evaluated like `Popen(['/bin/sh', '-c', 'systemctl', > 'is-active', 'iptables', '||', 'systemctl', 'is-active', 'firewalld'])`. This > doesn't returns values as expected, because after args[1] (in this case, > after the first `is-active`) are evaluated as sh arguements. > > `systemctl is-active` can take multiple arugments, so we can use it. > > > Diffs > - > > ambari-common/src/main/python/ambari_commons/firewall.py 72e6d26 > > Diff: https://reviews.apache.org/r/48309/diff/ > > > Testing > --- > > mvn clean test & manual test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48607: AMBARI-17181: Add some of value-attributes to property files in AMBARI_METRICS
> On 6月 15, 2016, 5:56 p.m., Aravindan Vijayan wrote: > > Masahiro, was this patch manually tested on a cluster? Thank you for reviewing ! I retested on a cluster and added screenshots before and after patched. See https://issues.apache.org/jira/browse/AMBARI-17181 I just checked that the WebUI has changed. I'm sorry but I noticed that I can't apply the previous patch to the latest trunk, I update the patch with some modification. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48607/#review137783 --- On 6月 16, 2016, 3:55 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48607/ > --- > > (Updated 6月 16, 2016, 3:55 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17181 > https://issues.apache.org/jira/browse/AMBARI-17181 > > > Repository: ambari > > > Description > --- > > Some of the property files in AMBARI_METRICS lack value-attributes. > It would be nice to have value-attributes on most of the properties. If so, > we can notice a careless mistakes in Ambari Server WebUI. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml > eaafc6b > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml > da4599e > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml > 3ce1af2 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml > f4e5fb2 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > 6484285 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml > 6f9c6dc > > Diff: https://reviews.apache.org/r/48607/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48523: AMBARI-17145 Unformatted configs remain in zeppelin-env.sh
> On June 10, 2016, 9:35 p.m., Jayush Luniya wrote:
> > Ship It!
Thank you! Could you commit this ?
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48523/#review137073
---
On June 9, 2016, 11:49 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48523/
> ---
>
> (Updated June 9, 2016, 11:49 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Pallav
> Kulshreshtha, and Sumit Mohanty.
>
>
> Bugs: AMBARI-17145
> https://issues.apache.org/jira/browse/AMBARI-17145
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When we just installed Zeppelin Notebook, /etc/zeppelin/conf/zeppelin-env.sh
> is like this
>
> ```
> # Spark master url. eg. spark://master_addr:7077. Leave empty if you want to
> use local mode
> export MASTER=yarn-client
> export SPARK_YARN_JAR={spark_jar_dir}/zeppelin-spark-0.5.5-SNAPSHOT.jar
>
> (snip)
> ```
>
> It maybe
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
> doesn't import from resource_management.libraries.functions.format import
> format
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
> a4efd72
>
> Diff: https://reviews.apache.org/r/48523/diff/
>
>
> Testing
> ---
>
> mvn clean test && manual test
>
>
> Thanks,
>
> Masahiro Tanaka
>
>
Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > <https://reviews.apache.org/r/48309/diff/1/?file=1408121#file1408121line123> > > > > Can you please explain why did we remove the check for firewalld? > > Masahiro Tanaka wrote: > Thank you for reviewing. > Acutually I didn't remove the check for firewalld. `systemctl is-active` > can take multiple arguments. > This is a sample output on CentOS7.2 > > ``` > # systemctl is-active iptables firewalld > inactive > active > # systemctl is-active iptables > inactive > # systemctl is-active firewalld > active > ``` > > Andrew Onischuk wrote: > Oh, I see. > > So: > if first is active and second is inactive what is the return code of > command? > if second is active and first is inactive what is the return code of > command? > > Masahiro Tanaka wrote: > Accoding to the `man systemctl`: > ``` > is-active PATTERN... > Check whether any of the specified units are active (i.e. running). > Returns an exit > code 0 if at least one is active, or non-zero otherwise. Unless > --quiet is specified, > this will also print the current unit state to standard output. > ``` > > We can expect that if at least one unit is active, then return code (exit > code) equals 0. > > BUT there is a bug in *systemd*. See [this PR on > GitHub](https://github.com/systemd/systemd/pull/2430) > > So the actual behavior on CentOS 7.2 is below: > ``` > # systemctl is-active iptables firewalld > inactive > active > # systemctl is-active iptables > inactive > # systemctl is-active firewalld > active > # systemctl is-active iptables firewalld > inactive > active > # echo $? > 3 > # systemctl is-active firewalld iptables > active > inactive > # echo $? > 3 > ``` > > That's why I checked if stdout includes the string `active` in my code. > > Andrew Onischuk wrote: > What will happen is firewalld or iptables is absent as a services, could > that be the case for centos7? > > Andrew Onischuk wrote: > Basically try doing something like this: > > # systemctl is-active firewalld somethingunknown > # echo $? > > Masahiro Tanaka wrote: > Here > ``` > # systemctl is-active firewalld somethingunknown > active > unknown > # echo $? > 3 > # systemctl is-active somethingunknown firewalld > unknown > active > # echo $? > 3 > ``` > > Andrew Onischuk wrote: > Thanks! And the exact environment is this ``` # cat /etc/redhat-release CentOS Linux release 7.2.1511 (Core) # systemctl --version systemd 219 +PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ -LZ4 -SECCOMP +BLKID +ELFUTILS +KMOD +IDN ``` - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review137283 --- On June 7, 2016, 11:11 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48309/ > --- > > (Updated June 7, 2016, 11:11 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, Florian Barca, and > Yusaku Sako. > > > Bugs: AMBARI-17047 > https://issues.apache.org/jira/browse/AMBARI-17047 > > > Repository: ambari > > > Description > --- > > In firewall.py, `systemctl is-active iptables || systemctl is-active > firewalld` is passed to `run_in_shell` function, which splits cmd string by > using `shlex.split`. > > run_in_shell function finally calls `subprocess.Popen` with `shell=True`, so > the cmd string is evaluated like `Popen(['/bin/sh', '-c', 'systemctl', > 'is-active', 'iptables', '||', 'systemctl', 'is-active', 'firewalld'])`. This > doesn't returns values as expected, because after args[1] (in this case, > after the first `is-active`) are evaluated as sh arguements. > > `systemctl is-active` can take multiple arugments, so we can use it. > > > Diffs > - > > ambari-common/src/main/python/ambari_commons/firewall.py 72e6d26 > > Diff: https://reviews.apache.org/r/48309/diff/ > > > Testing > --- > > mvn clean test & manual test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > <https://reviews.apache.org/r/48309/diff/1/?file=1408121#file1408121line123> > > > > Can you please explain why did we remove the check for firewalld? > > Masahiro Tanaka wrote: > Thank you for reviewing. > Acutually I didn't remove the check for firewalld. `systemctl is-active` > can take multiple arguments. > This is a sample output on CentOS7.2 > > ``` > # systemctl is-active iptables firewalld > inactive > active > # systemctl is-active iptables > inactive > # systemctl is-active firewalld > active > ``` > > Andrew Onischuk wrote: > Oh, I see. > > So: > if first is active and second is inactive what is the return code of > command? > if second is active and first is inactive what is the return code of > command? > > Masahiro Tanaka wrote: > Accoding to the `man systemctl`: > ``` > is-active PATTERN... > Check whether any of the specified units are active (i.e. running). > Returns an exit > code 0 if at least one is active, or non-zero otherwise. Unless > --quiet is specified, > this will also print the current unit state to standard output. > ``` > > We can expect that if at least one unit is active, then return code (exit > code) equals 0. > > BUT there is a bug in *systemd*. See [this PR on > GitHub](https://github.com/systemd/systemd/pull/2430) > > So the actual behavior on CentOS 7.2 is below: > ``` > # systemctl is-active iptables firewalld > inactive > active > # systemctl is-active iptables > inactive > # systemctl is-active firewalld > active > # systemctl is-active iptables firewalld > inactive > active > # echo $? > 3 > # systemctl is-active firewalld iptables > active > inactive > # echo $? > 3 > ``` > > That's why I checked if stdout includes the string `active` in my code. > > Andrew Onischuk wrote: > What will happen is firewalld or iptables is absent as a services, could > that be the case for centos7? > > Andrew Onischuk wrote: > Basically try doing something like this: > > # systemctl is-active firewalld somethingunknown > # echo $? Here ``` # systemctl is-active firewalld somethingunknown active unknown # echo $? 3 # systemctl is-active somethingunknown firewalld unknown active # echo $? 3 ``` - Masahiro ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review137283 --- On June 7, 2016, 11:11 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48309/ > --- > > (Updated June 7, 2016, 11:11 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, Florian Barca, and > Yusaku Sako. > > > Bugs: AMBARI-17047 > https://issues.apache.org/jira/browse/AMBARI-17047 > > > Repository: ambari > > > Description > --- > > In firewall.py, `systemctl is-active iptables || systemctl is-active > firewalld` is passed to `run_in_shell` function, which splits cmd string by > using `shlex.split`. > > run_in_shell function finally calls `subprocess.Popen` with `shell=True`, so > the cmd string is evaluated like `Popen(['/bin/sh', '-c', 'systemctl', > 'is-active', 'iptables', '||', 'systemctl', 'is-active', 'firewalld'])`. This > doesn't returns values as expected, because after args[1] (in this case, > after the first `is-active`) are evaluated as sh arguements. > > `systemctl is-active` can take multiple arugments, so we can use it. > > > Diffs > - > > ambari-common/src/main/python/ambari_commons/firewall.py 72e6d26 > > Diff: https://reviews.apache.org/r/48309/diff/ > > > Testing > --- > > mvn clean test & manual test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > <https://reviews.apache.org/r/48309/diff/1/?file=1408121#file1408121line123> > > > > Can you please explain why did we remove the check for firewalld? > > Masahiro Tanaka wrote: > Thank you for reviewing. > Acutually I didn't remove the check for firewalld. `systemctl is-active` > can take multiple arguments. > This is a sample output on CentOS7.2 > > ``` > # systemctl is-active iptables firewalld > inactive > active > # systemctl is-active iptables > inactive > # systemctl is-active firewalld > active > ``` > > Andrew Onischuk wrote: > Oh, I see. > > So: > if first is active and second is inactive what is the return code of > command? > if second is active and first is inactive what is the return code of > command? Accoding to the `man systemctl`: ``` is-active PATTERN... Check whether any of the specified units are active (i.e. running). Returns an exit code 0 if at least one is active, or non-zero otherwise. Unless --quiet is specified, this will also print the current unit state to standard output. ``` We can expect that if at least one unit is active, then return code (exit code) equals 0. BUT there is a bug in *systemd*. See [this PR on GitHub](https://github.com/systemd/systemd/pull/2430) So the actual behavior on CentOS 7.2 is below: ``` # systemctl is-active iptables firewalld inactive active # systemctl is-active iptables inactive # systemctl is-active firewalld active # systemctl is-active iptables firewalld inactive active # echo $? 3 # systemctl is-active firewalld iptables active inactive # echo $? 3 ``` That's why I checked if stdout includes the string `active` in my code. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review137283 --- On June 7, 2016, 11:11 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48309/ > --- > > (Updated June 7, 2016, 11:11 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, Florian Barca, and > Yusaku Sako. > > > Bugs: AMBARI-17047 > https://issues.apache.org/jira/browse/AMBARI-17047 > > > Repository: ambari > > > Description > --- > > In firewall.py, `systemctl is-active iptables || systemctl is-active > firewalld` is passed to `run_in_shell` function, which splits cmd string by > using `shlex.split`. > > run_in_shell function finally calls `subprocess.Popen` with `shell=True`, so > the cmd string is evaluated like `Popen(['/bin/sh', '-c', 'systemctl', > 'is-active', 'iptables', '||', 'systemctl', 'is-active', 'firewalld'])`. This > doesn't returns values as expected, because after args[1] (in this case, > after the first `is-active`) are evaluated as sh arguements. > > `systemctl is-active` can take multiple arugments, so we can use it. > > > Diffs > - > > ambari-common/src/main/python/ambari_commons/firewall.py 72e6d26 > > Diff: https://reviews.apache.org/r/48309/diff/ > > > Testing > --- > > mvn clean test & manual test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > <https://reviews.apache.org/r/48309/diff/1/?file=1408121#file1408121line123> > > > > Can you please explain why did we remove the check for firewalld? Thank you for reviewing. Acutually I didn't remove the check for firewalld. `systemctl is-active` can take multiple arguments. This is a sample output on CentOS7.2 ``` # systemctl is-active iptables firewalld inactive active # systemctl is-active iptables inactive # systemctl is-active firewalld active ``` - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review137283 --- On June 7, 2016, 11:11 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48309/ > --- > > (Updated June 7, 2016, 11:11 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, Florian Barca, and > Yusaku Sako. > > > Bugs: AMBARI-17047 > https://issues.apache.org/jira/browse/AMBARI-17047 > > > Repository: ambari > > > Description > --- > > In firewall.py, `systemctl is-active iptables || systemctl is-active > firewalld` is passed to `run_in_shell` function, which splits cmd string by > using `shlex.split`. > > run_in_shell function finally calls `subprocess.Popen` with `shell=True`, so > the cmd string is evaluated like `Popen(['/bin/sh', '-c', 'systemctl', > 'is-active', 'iptables', '||', 'systemctl', 'is-active', 'firewalld'])`. This > doesn't returns values as expected, because after args[1] (in this case, > after the first `is-active`) are evaluated as sh arguements. > > `systemctl is-active` can take multiple arugments, so we can use it. > > > Diffs > - > > ambari-common/src/main/python/ambari_commons/firewall.py 72e6d26 > > Diff: https://reviews.apache.org/r/48309/diff/ > > > Testing > --- > > mvn clean test & manual test > > > Thanks, > > Masahiro Tanaka > >
Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/
---
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
Bugs: AMBARI-17184
https://issues.apache.org/jira/browse/AMBARI-17184
Repository: ambari
Description
---
When we wanted to restart HBase, we got an error
```
Traceback (most recent call last):
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
line 159, in
HbaseMaster().execute()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 257, in execute
method(env)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 686, in restart
self.start(env, upgrade_type=upgrade_type)
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
line 86, in start
self.configure(env) # for security
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
line 41, in configure
hbase(name='master')
File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py",
line 89, in thunk
return fn(*args, **kwargs)
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
line 166, in hbase
tag = 'GANGLIA-MASTER' if name == 'master' else 'GANGLIA-RS'
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
line 233, in hbase_TemplateConfig
template_tag = tag
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py",
line 155, in __init__
self.env.run()
File
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
line 160, in run
self.run_action(resource, action)
File
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
line 124, in run_action
provider_action()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/template_config.py",
line 46, in action_create
content = Template(template_name, extra_imports=self.resource.extra_imports)
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py",
line 155, in __init__
self.env.run()
File
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
line 160, in run
self.run_action(resource, action)
File
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
line 124, in run_action
provider_action()
File
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
line 123, in action_create
content = self._get_content()
File
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
line 160, in _get_content
return content()
File "/usr/lib/python2.6/site-packages/resource_management/core/source.py",
line 51, in __call__
return self.get_content()
File "/usr/lib/python2.6/site-packages/resource_management/core/source.py",
line 142, in get_content
rendered = self.template.render(self.context)
File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line
891, in render
return self.environment.handle_exception(exc_info, True)
File
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2",
line 76, in top-level template code
hbase.sink.timeline.truststore.password = {{metric_truststore_password}}
ambari_jinja2.exceptions.UndefinedError: 'metric_collector_hosts' is undefined
```
We should define metric_collector_hosts in
ambari/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
Diffs
-
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
05bad1c
Diff: https://reviews.apache.org/r/48628/diff/
Testing
---
mvn clean test && manual test
Thanks,
Masahiro Tanaka
Review Request 48607: AMBARI-17181: Add some of value-attributes to property files in AMBARI_METRICS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48607/ --- Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-17181 https://issues.apache.org/jira/browse/AMBARI-17181 Repository: ambari Description --- Some of the property files in AMBARI_METRICS lack value-attributes. It would be nice to have value-attributes on most of the properties. If so, we can notice a careless mistakes in Ambari Server WebUI. Diffs - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml eaafc6b ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml da4599e ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml b40923a ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml f4e5fb2 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 6484285 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml 6f9c6dc Diff: https://reviews.apache.org/r/48607/diff/ Testing --- mvn clean test Thanks, Masahiro Tanaka
Review Request 48523: AMBARI-17145 Unformatted configs remain in zeppelin-env.sh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48523/
---
Review request for Ambari, Andrew Onischuk, Jayush Luniya, Pallav Kulshreshtha,
and Sumit Mohanty.
Bugs: AMBARI-17145
https://issues.apache.org/jira/browse/AMBARI-17145
Repository: ambari
Description
---
When we just installed Zeppelin Notebook, /etc/zeppelin/conf/zeppelin-env.sh is
like this
```
# Spark master url. eg. spark://master_addr:7077. Leave empty if you want to
use local mode
export MASTER=yarn-client
export SPARK_YARN_JAR={spark_jar_dir}/zeppelin-spark-0.5.5-SNAPSHOT.jar
(snip)
```
It maybe
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
doesn't import from resource_management.libraries.functions.format import
format
Diffs
-
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
a4efd72
Diff: https://reviews.apache.org/r/48523/diff/
Testing
---
mvn clean test && manual test
Thanks,
Masahiro Tanaka
Review Request 48396: AMBARI-17104: Conflicts supported OS version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48396/ --- Review request for Ambari and Yusaku Sako. Bugs: AMBARI-17104 https://issues.apache.org/jira/browse/AMBARI-17104 Repository: ambari Description --- Apache Ambari Website says Ambari Apache supports RHEL 5,6, CentOS 5,6, and OEL 5,6. But docs at Hortonworks webpage says RHEL 6,7, CentOS 6,7, and OEL 6,7. We should fix this conflicts. Diffs - docs/src/site/apt/index.apt 7a4245b Diff: https://reviews.apache.org/r/48396/diff/ Testing --- This is a document fix. Thanks, Masahiro Tanaka
Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/ --- Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Florian Barca. Bugs: AMBARI-17047 https://issues.apache.org/jira/browse/AMBARI-17047 Repository: ambari Description --- In firewall.py, `systemctl is-active iptables || systemctl is-active firewalld` is passed to `run_in_shell` function, which splits cmd string by using `shlex.split`. run_in_shell function finally calls `subprocess.Popen` with `shell=True`, so the cmd string is evaluated like `Popen(['/bin/sh', '-c', 'systemctl', 'is-active', 'iptables', '||', 'systemctl', 'is-active', 'firewalld'])`. This doesn't returns values as expected, because after args[1] (in this case, after the first `is-active`) are evaluated as sh arguements. `systemctl is-active` can take multiple arugments, so we can use it. Diffs - ambari-common/src/main/python/ambari_commons/firewall.py 72e6d26 Diff: https://reviews.apache.org/r/48309/diff/ Testing --- mvn clean test & manual test Thanks, Masahiro Tanaka
Re: Review Request 47705: AMBARI-16731 Should close file object in security.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47705/#review135888 --- Could anyone review this? I think this isn't a difficult patch. - Masahiro Tanaka On 5月 29, 2016, 2:55 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47705/ > --- > > (Updated 5月 29, 2016, 2:55 a.m.) > > > Review request for Ambari, Andrew Onischuk, Mahadev Konar, Sid Wagle, and > Yusaku Sako. > > > Bugs: AMBARI-16731 > https://issues.apache.org/jira/browse/AMBARI-16731 > > > Repository: ambari > > > Description > --- > > reqSignCrt method opens CSR file with open function but that doesn't close it. > And, loadSrvrCrt method opens a file but this is unclosed too. > They waste resources and may cause a problem > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/security.py 779b85c > > Diff: https://reviews.apache.org/r/47705/diff/ > > > Testing > --- > > mvn -fae clean install > > > Thanks, > > Masahiro Tanaka > >
Review Request 47705: AMBARI-16731 Should close file object in security.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47705/ --- Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sid Wagle. Bugs: AMBARI-16731 https://issues.apache.org/jira/browse/AMBARI-16731 Repository: ambari Description --- reqSignCrt method opens CSR file with open function but that doesn't close it. And, loadSrvrCrt method opens a file but this is unclosed too. They waste resources and may cause a problem Diffs - ambari-agent/src/main/python/ambari_agent/security.py 779b85c Diff: https://reviews.apache.org/r/47705/diff/ Testing --- mvn -fae clean install Thanks, Masahiro Tanaka
Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/ --- (Updated 4月 22, 2016, 9:35 a.m.) Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush Luniya, and Vitalyi Brodetskyi. Bugs: AMBARI-15678 https://issues.apache.org/jira/browse/AMBARI-15678 Repository: ambari Description --- If yarn app state is not state or yarn app finalStatus is not succeeded, YARN service check should fail. But in the YARN service_check.py, it doesn't fail because raise statement is in try block and there is only `pass` in except block. Diffs - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py e8d98ab Diff: https://reviews.apache.org/r/45676/diff/ Testing --- mvn clean test Thanks, Masahiro Tanaka
Re: Review Request 45998: AMBARI-15792: HIVE service_check doesn't work properly
> On 4月 21, 2016, 12:25 a.m., Masahiro Tanaka wrote: > > Thanks for the review Nate and Andrew! > > Could you commit this? > > Andrew Onischuk wrote: > before we can commit we need an apache jira for this change, and +1 from > Hadoop QA. > > Do you have one? If yes specify its id in "Bugs" field here. > > Masahiro Tanaka wrote: > I forgot to add the jira number... I'm sorry. > > Andrew Onischuk wrote: > no worries > > Andrew Onischuk wrote: > Thanks for the contribution! Committed the patch to trunk. Please feel > free to close this review. thank you! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129845 ------- On 4月 21, 2016, 10:30 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45998/ > --- > > (Updated 4月 21, 2016, 10:30 a.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. > > > Bugs: AMBARI-15792 > https://issues.apache.org/jira/browse/AMBARI-15792 > > > Repository: ambari > > > Description > --- > > In templetonSmoke.sh, there are > 1) unnecessary `exit 0` > 2) lack of redirect `>` command > 3) unassigned variable > > we should correct them all to check the HIVE service properly. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > dd00e02 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py > 9965bfa9 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 6c4dc00 > > Diff: https://reviews.apache.org/r/45998/diff/ > > > Testing > --- > > mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 45998: AMBARI-15792: HIVE service_check doesn't work properly
> On 4月 21, 2016, 12:25 a.m., Masahiro Tanaka wrote: > > Thanks for the review Nate and Andrew! > > Could you commit this? > > Andrew Onischuk wrote: > before we can commit we need an apache jira for this change, and +1 from > Hadoop QA. > > Do you have one? If yes specify its id in "Bugs" field here. I forgot to add the jira number... I'm sorry. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129845 ------- On 4月 21, 2016, 10:30 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45998/ > --- > > (Updated 4月 21, 2016, 10:30 a.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. > > > Bugs: AMBARI-15792 > https://issues.apache.org/jira/browse/AMBARI-15792 > > > Repository: ambari > > > Description > --- > > In templetonSmoke.sh, there are > 1) unnecessary `exit 0` > 2) lack of redirect `>` command > 3) unassigned variable > > we should correct them all to check the HIVE service properly. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > dd00e02 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py > 9965bfa9 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 6c4dc00 > > Diff: https://reviews.apache.org/r/45998/diff/ > > > Testing > --- > > mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 45998: HIVE service_check doesn't work properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129845 --- Thanks for the review Nate and Andrew! Could you commit this? - Masahiro Tanaka On 4月 16, 2016, 7:02 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45998/ > --- > > (Updated 4月 16, 2016, 7:02 p.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. > > > Repository: ambari > > > Description > --- > > In templetonSmoke.sh, there are > 1) unnecessary `exit 0` > 2) lack of redirect `>` command > 3) unassigned variable > > we should correct them all to check the HIVE service properly. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > dd00e02 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py > 9965bfa9 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 6c4dc00 > > Diff: https://reviews.apache.org/r/45998/diff/ > > > Testing > --- > > mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 45998: HIVE service_check doesn't work properly
> On 4月 20, 2016, 1:17 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py, > > lines 117-119 > > <https://reviews.apache.org/r/45998/diff/2/?file=1347716#file1347716line117> > > > > Given how many things get passed to this script, why not do all this in > > python? Seems a whole lot of setup for a script file that we control > > anyway. We have plenty of knowledge around making curl calls and reading > > output etc. Food for thought; I'm not holding up the review for it. Yes, this is complicated and buggy. We might should replace these shell script with python. - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129732 --- On 4月 16, 2016, 7:02 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45998/ > --- > > (Updated 4月 16, 2016, 7:02 p.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. > > > Repository: ambari > > > Description > --- > > In templetonSmoke.sh, there are > 1) unnecessary `exit 0` > 2) lack of redirect `>` command > 3) unassigned variable > > we should correct them all to check the HIVE service properly. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > dd00e02 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py > 9965bfa9 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 6c4dc00 > > Diff: https://reviews.apache.org/r/45998/diff/ > > > Testing > --- > > mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable
> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote: > > Ship It! Thank you, could you commit this? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/#review129706 --- On April 19, 2016, 11:52 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45676/ > --- > > (Updated April 19, 2016, 11:52 p.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush > Luniya, and Vitalyi Brodetskyi. > > > Repository: ambari > > > Description > --- > > If yarn app state is not state or yarn app finalStatus is not succeeded, YARN > service check should fail. > But in the YARN service_check.py, it doesn't fail because raise statement is > in try block and there is only `pass` in except block. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py > e8d98ab > > Diff: https://reviews.apache.org/r/45676/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 45998: HIVE service_check doesn't work properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129700 --- Could anyone review this? - Masahiro Tanaka On 4月 16, 2016, 7:02 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45998/ > --- > > (Updated 4月 16, 2016, 7:02 p.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. > > > Repository: ambari > > > Description > --- > > In templetonSmoke.sh, there are > 1) unnecessary `exit 0` > 2) lack of redirect `>` command > 3) unassigned variable > > we should correct them all to check the HIVE service properly. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > dd00e02 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py > 9965bfa9 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 6c4dc00 > > Diff: https://reviews.apache.org/r/45998/diff/ > > > Testing > --- > > mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 45998: HIVE service_check doesn't work properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/ --- (Updated April 16, 2016, 7:02 p.m.) Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. Changes --- Update a patch Repository: ambari Description --- In templetonSmoke.sh, there are 1) unnecessary `exit 0` 2) lack of redirect `>` command 3) unassigned variable we should correct them all to check the HIVE service properly. Diffs (updated) - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh dd00e02 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py 9965bfa9 ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6c4dc00 Diff: https://reviews.apache.org/r/45998/diff/ Testing --- mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 Thanks, Masahiro Tanaka
