Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/
---

(Updated May 10, 2016, 10:22 p.m.)


Review request for Ambari.


Bugs: AMBARI-16417
https://issues.apache.org/jira/browse/AMBARI-16417


Repository: ambari


Description
---

When Standby master is down (actually I removed it through API, and it got 
deleted but somehow the configuration has the old IP) the hawq alert pops up(, 
which is good) but only saying "HAWQSTANDBY is not in sync with HAWQMASTER".

If you take a close look at gp_master_mirroring table, it has more detailed 
information. (in this case, connection issue)
{code}
[gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
gp_master_mirroring;"
  summary_state   |   detail_state   |log_time| 
 error_message
--+--++--
 Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error received 
sending data to standby master: server closed the connection unexpectedly
  : This 
probably means the server terminated abnormally
  : before 
or while processing the request.
  :
(1 row)
{code}


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
 c94be9e 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
7d030dc 

Diff: https://reviews.apache.org/r/47156/diff/


Testing
---


Thanks,

jun aoki

Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

> On May 10, 2016, 9:53 p.m., Lav Jain wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py,
> >  line 93
> > <https://reviews.apache.org/r/47156/diff/1/?file=1377351#file1377351line93>
> >
> > Please try to use one SQL statement. Delimiter can be defined using -F 
> > option. E.g.:
> > ```
> > source /usr/local/hawq/greenplum_path.sh && psql -F $'##' --no-align -t 
> > -d template1 -c "SELECT summary_state, error_message FROM 
> > gp_master_mirroring"
> > Not Synchronized##error received sending data to standby master: server 
> > closed the connection unexpectedly
> > This probably means the server terminated abnormally
> > before or while processing the request.
> > ```

Lav, this is a good stuff. I actually have to use --no-align option to not to 
be aligned.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132547
---


On May 10, 2016, 9:54 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
> 
> (Updated May 10, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Standby master is down (actually I removed it through API, and it got 
> deleted but somehow the configuration has the old IP) the hawq alert pops 
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with 
> HAWQMASTER".
> 
> If you take a close look at gp_master_mirroring table, it has more detailed 
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
> gp_master_mirroring;"
>   summary_state   |   detail_state   |log_time|   
>error_message
> --+--++--
>  Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error 
> received sending data to standby master: server closed the connection 
> unexpectedly
>   : This 
> probably means the server terminated abnormally
>   : 
> before or while processing the request.
>   :
> (1 row)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  c94be9e 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
> 7d030dc 
> 
> Diff: https://reviews.apache.org/r/47156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

> On May 10, 2016, 7:10 a.m., Matt wrote:
> >
> 
> Matt wrote:
> Please double check if any unit tests have to be updated.

will do


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132384
---


On May 10, 2016, 9:54 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
> 
> (Updated May 10, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Standby master is down (actually I removed it through API, and it got 
> deleted but somehow the configuration has the old IP) the hawq alert pops 
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with 
> HAWQMASTER".
> 
> If you take a close look at gp_master_mirroring table, it has more detailed 
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
> gp_master_mirroring;"
>   summary_state   |   detail_state   |log_time|   
>error_message
> --+--++--
>  Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error 
> received sending data to standby master: server closed the connection 
> unexpectedly
>   : This 
> probably means the server terminated abnormally
>   : 
> before or while processing the request.
>   :
> (1 row)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  c94be9e 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
> 7d030dc 
> 
> Diff: https://reviews.apache.org/r/47156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/
---

(Updated May 10, 2016, 9:54 p.m.)


Review request for Ambari.


Changes
---

Feedback applied


Bugs: AMBARI-16417
https://issues.apache.org/jira/browse/AMBARI-16417


Repository: ambari


Description
---

When Standby master is down (actually I removed it through API, and it got 
deleted but somehow the configuration has the old IP) the hawq alert pops up(, 
which is good) but only saying "HAWQSTANDBY is not in sync with HAWQMASTER".

If you take a close look at gp_master_mirroring table, it has more detailed 
information. (in this case, connection issue)
{code}
[gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
gp_master_mirroring;"
  summary_state   |   detail_state   |log_time| 
 error_message
--+--++--
 Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error received 
sending data to standby master: server closed the connection unexpectedly
  : This 
probably means the server terminated abnormally
  : before 
or while processing the request.
  :
(1 row)
{code}


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
 c94be9e 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
7d030dc 

Diff: https://reviews.apache.org/r/47156/diff/


Testing
---


Thanks,

jun aoki

Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

> On May 10, 2016, 7:10 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py,
> >  line 68
> > <https://reviews.apache.org/r/47156/diff/1/?file=1377351#file1377351line68>
> >
> > Would be better to have **'HAWQSTANDBY is not in sync with HAWQMASTER. 
> > ERROR: ' + error_message**

will fix


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132384
-------


On May 10, 2016, 4:27 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
> 
> (Updated May 10, 2016, 4:27 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Standby master is down (actually I removed it through API, and it got 
> deleted but somehow the configuration has the old IP) the hawq alert pops 
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with 
> HAWQMASTER".
> 
> If you take a close look at gp_master_mirroring table, it has more detailed 
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
> gp_master_mirroring;"
>   summary_state   |   detail_state   |log_time|   
>error_message
> --+--++--
>  Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error 
> received sending data to standby master: server closed the connection 
> unexpectedly
>   : This 
> probably means the server terminated abnormally
>   : 
> before or while processing the request.
>   :
> (1 row)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  c94be9e 
> 
> Diff: https://reviews.apache.org/r/47156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132518
---



Do we have to Clean PXF from the previous NN node, if the node does no longer 
have any of PXF related ones? (DN, HAWQ etc.?)

- jun aoki


On May 10, 2016, 7:26 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47160/
> ---
> 
> (Updated May 10, 2016, 7:26 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16419
> https://issues.apache.org/jira/browse/AMBARI-16419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After move NAMENODE wizard is executed,
> - PXF should be installed on the target host.
> - If the source host does not have a DATANODE, PXF should be removed from the 
> source host.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> f718d46 
>   ambari-web/app/messages.js e388526 
>   ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
> 89e2325 
> 
> Diff: https://reviews.apache.org/r/47160/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
>   27727 tests complete (25 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:14 min
> [INFO] Finished at: 2016-05-10T00:20:54-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>

Review Request 47156: More information for Standby sync alert

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/
---

Review request for Ambari.


Bugs: AMBARI-16417
https://issues.apache.org/jira/browse/AMBARI-16417


Repository: ambari


Description
---

When Standby master is down (actually I removed it through API, and it got 
deleted but somehow the configuration has the old IP) the hawq alert pops up(, 
which is good) but only saying "HAWQSTANDBY is not in sync with HAWQMASTER".

If you take a close look at gp_master_mirroring table, it has more detailed 
information. (in this case, connection issue)
{code}
[gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
gp_master_mirroring;"
  summary_state   |   detail_state   |log_time| 
 error_message
--+--++--
 Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error received 
sending data to standby master: server closed the connection unexpectedly
  : This 
probably means the server terminated abnormally
  : before 
or while processing the request.
  :
(1 row)
{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
 c94be9e 

Diff: https://reviews.apache.org/r/47156/diff/


Testing
---


Thanks,

jun aoki

Re: Review Request 47134: HAWQ Password handling updated

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132339
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 54)
<https://reviews.apache.org/r/47134/#comment196517>

Could you add a comment why "$1$salt$"? it is so magic if you are not 
familier with crpyt(I'm one of them)
$1 to be MD5 instead of default DES and more

https://en.wikipedia.org/wiki/Crypt_(C)#Key_Derivation_Functions_Supported_by_crypt


- jun aoki


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> 

Re: Review Request 46996: HAWQ service can be stopped and checked even when STANDBY MASTER is stopped

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46996/#review131769
---


Ship it!





ambari-web/app/controllers/main/service/item.js (line 1005)
<https://reviews.apache.org/r/46996/#comment195807>

I'm not knowledgable on this but wonder if it takes care of service check 
being enabled ?


- jun aoki


On May 4, 2016, 11:52 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46996/
> ---
> 
> (Updated May 4, 2016, 11:52 p.m.)
> 
> 
> Review request for Ambari, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav 
> Jain, and Matt.
> 
> 
> Bugs: AMBARI-16236
> https://issues.apache.org/jira/browse/AMBARI-16236
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ service can be stopped and checked even when STANDBY MASTER is stopped
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/item.js bfede8a 
>   ambari-web/test/controllers/main/service/item_test.js 4bac784 
> 
> Diff: https://reviews.apache.org/r/46996/diff/
> 
> 
> Testing
> ---
> 
> manual. added unit tests:
> 
> 27532 tests complete (29 seconds)
> 154 tests pending
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 45.229 s
> [INFO] Finished at: 2016-05-04T16:25:14-08:00
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[jun aoki]

> On May 4, 2016, 4:45 p.m., Alexander Denissov wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py,
> >  line 143
> > <https://reviews.apache.org/r/46949/diff/1/?file=1370315#file1370315line143>
> >
> > The code in line 57 is:
> > 
> > raise Fail('No active NameNode was found.')
> > 
> > Should the same be done here for consistency ?

Modified.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/#review131705
-------


On May 4, 2016, 9:28 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46949/
> ---
> 
> (Updated May 4, 2016, 9:28 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16237
> https://issues.apache.org/jira/browse/AMBARI-16237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF alerts shows "Configuration parameter 'fs_root' was not found in 
> configurations dictionary!" when both namnodes are down on secured NN HA 
> environment, which the error message is not too clear.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  ee16c9b 
> 
> Diff: https://reviews.apache.org/r/46949/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/
---

(Updated May 4, 2016, 9:28 p.m.)


Review request for Ambari.


Bugs: AMBARI-16237
https://issues.apache.org/jira/browse/AMBARI-16237


Repository: ambari


Description
---

PXF alerts shows "Configuration parameter 'fs_root' was not found in 
configurations dictionary!" when both namnodes are down on secured NN HA 
environment, which the error message is not too clear.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
 ee16c9b 

Diff: https://reviews.apache.org/r/46949/diff/


Testing
---

Manually tested.


Thanks,

jun aoki

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > <https://reviews.apache.org/r/46860/diff/1/?file=1367779#file1367779line85>
> >
> > Unless HAWQ is using YARN as the scheduler, HAWQ may still be 
> > functional and we may need not restart HAWQ with the move of RM. 
> > So do you think should we restart it only when HAWQ is using 
> > hawq_global_rm_type as yarn ?
> 
> jun aoki wrote:
> I thought it'd be a good idea but data.Cluters won't return enoguh 
> information to decide if HAWQ is on YARN. 
> ```
> data.Clusters.desired_configs["hawq-site"]
> Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
> ```
> Let me know if you have a better idea to find it out.
> 
> bhuvnesh chaudhary wrote:
> You can get the configuration as soon you reach onLoadConfigs, and then 
> you can use it which is before the start service ?
> 
> Matt wrote:
> That sounds better to me. Modify the array after receiving the config.
> If HAWQ is using YARN, append value 'HAWQ' to RESOURCEMANAGER's array 
> value.
> 
> jun aoki wrote:
> I'm checking right now to see if it works.

Good stuff Bhuvnesh, it works.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
---


On May 3, 2016, 12:59 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 3, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On May 2, 2016, 10:31 p.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 581
> > <https://reviews.apache.org/r/46860/diff/2/?file=1369090#file1369090line581>
> >
> > somehow placing the logic here does not fit well to the method, you can 
> > move this logic to setAdditionalConfigs which imo more appropriate place 
> > and hopefully it will work there too as its used after setting additional 
> > configurations ?

setAdditionalConfigs() (at least intention ) is to simply take 
additionalConfigsMap parameter and transform it in "configs", so it shouldn't 
have some condition logic to modify the parameter.
Instead, we should modify the parameter, additionalConfigsMap beforehand, which 
onLoadConfigs() as you suggested.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131403
-------


On May 3, 2016, 12:59 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 3, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/
---

(Updated May 3, 2016, 12:59 a.m.)


Review request for Ambari.


Bugs: AMBARI-16174
https://issues.apache.org/jira/browse/AMBARI-16174


Repository: ambari


Description
---

when RM HA is not enabled, following properties should be updated in 
hawq-site.xml should be updated.
hawq_rm_yarn_address
hawq_rm_yarn_scheduler_address
When RM HA Is enabled and then a RM is moved, following properties in 
yarn-client.xml should be updated
yarn.resourcemanager.ha
yarn.resourcemanager.scheduler.ha


Diffs (updated)
-

  ambari-web/app/controllers/main/service/reassign/step4_controller.js 736f467 
  ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
329249c 

Diff: https://reviews.apache.org/r/46860/diff/


Testing
---

Unit test passed
Calling set on destroyed view

  27428 tests complete (35 seconds)
  154 tests pending


Manually tested


Thanks,

jun aoki

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > <https://reviews.apache.org/r/46860/diff/1/?file=1367779#file1367779line85>
> >
> > Unless HAWQ is using YARN as the scheduler, HAWQ may still be 
> > functional and we may need not restart HAWQ with the move of RM. 
> > So do you think should we restart it only when HAWQ is using 
> > hawq_global_rm_type as yarn ?
> 
> jun aoki wrote:
> I thought it'd be a good idea but data.Cluters won't return enoguh 
> information to decide if HAWQ is on YARN. 
> ```
> data.Clusters.desired_configs["hawq-site"]
> Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
> ```
> Let me know if you have a better idea to find it out.
> 
> bhuvnesh chaudhary wrote:
> You can get the configuration as soon you reach onLoadConfigs, and then 
> you can use it which is before the start service ?
> 
> Matt wrote:
> That sounds better to me. Modify the array after receiving the config.
> If HAWQ is using YARN, append value 'HAWQ' to RESOURCEMANAGER's array 
> value.

I'm checking right now to see if it works.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
---


On May 2, 2016, 9:47 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 2, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On May 2, 2016, 10:16 p.m., Matt wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > <https://reviews.apache.org/r/46860/diff/2/?file=1369090#file1369090line85>
> >
> > If HAWQ is configured to work on Standalone mode, should HAWQ be in the 
> > list of services to stop/start when some operation is done with YARN 
> > service? Can this be appended to this list based on what type of resource 
> > management HAWQ is relying on?
> > 
> > I would configure HAWQ in standalone mode, and move YARN Resource 
> > Manager - I would not expect HAWQ to be restarted in this case.

@Matt, please my comment on May 2, 2016, 8:57 p.m.


> On May 2, 2016, 10:16 p.m., Matt wrote:
> > ambari-web/app/utils/configs/move_rm_config_initializer.js, line 120
> > <https://reviews.apache.org/r/46860/diff/2/?file=1369091#file1369091line120>
> >
> > The line numbers on the link does not stick when the file in that 
> > repository gets updated.

It is to a release tag, so hopefuly won't be updated.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131391
---


On May 2, 2016, 9:47 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 2, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/
---

(Updated May 2, 2016, 9:47 p.m.)


Review request for Ambari.


Bugs: AMBARI-16174
https://issues.apache.org/jira/browse/AMBARI-16174


Repository: ambari


Description
---

when RM HA is not enabled, following properties should be updated in 
hawq-site.xml should be updated.
hawq_rm_yarn_address
hawq_rm_yarn_scheduler_address
When RM HA Is enabled and then a RM is moved, following properties in 
yarn-client.xml should be updated
yarn.resourcemanager.ha
yarn.resourcemanager.scheduler.ha


Diffs (updated)
-

  ambari-web/app/controllers/main/service/reassign/step4_controller.js 736f467 
  ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
329249c 

Diff: https://reviews.apache.org/r/46860/diff/


Testing
---

Unit test passed
Calling set on destroyed view

  27428 tests complete (35 seconds)
  154 tests pending


Manually tested


Thanks,

jun aoki

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > <https://reviews.apache.org/r/46860/diff/1/?file=1367779#file1367779line85>
> >
> > Unless HAWQ is using YARN as the scheduler, HAWQ may still be 
> > functional and we may need not restart HAWQ with the move of RM. 
> > So do you think should we restart it only when HAWQ is using 
> > hawq_global_rm_type as yarn ?

I thought it'd be a good idea but data.Cluters won't return enoguh information 
to decide if HAWQ is on YARN. 
```
data.Clusters.desired_configs["hawq-site"]
Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
```
Let me know if you have a better idea to find it out.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
-------


On April 29, 2016, 11:57 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated April 29, 2016, 11:57 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> a20aa82 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 460726b 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131350
---




ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 85)
<https://reviews.apache.org/r/46860/#comment195277>

Good idea. Let me see if I can add HAWQ dynamically at onLoadConfigsTags().



ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 582)
<https://reviews.apache.org/r/46860/#comment195276>

I will keep this logic here as this is the first loation the logic can see 
cluster information and the definitions can get modified.
getConfigUrlParams() is to generate a list of partial URLs. 

The second suggestion is good and I will invert this if statement and 
remove them from the default values.


- jun aoki


On April 29, 2016, 11:57 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated April 29, 2016, 11:57 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> a20aa82 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 460726b 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46852/#review131228
---


Ship it!




Ship It!

- jun aoki


On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46852/
> ---
> 
> (Updated April 29, 2016, 8:50 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16191
> https://issues.apache.org/jira/browse/AMBARI-16191
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ Configuration should be updated whenever Namenode is being moved using 
> the move namenode wizard.
> Parameters which should be updated
> Case 1: HDFS HA
> hdfs-client parameters under HAWQ service
> dfs.namenode.rpc-address..
> dfs.namenode.http-address..
> Case 2: Non HA HDFS
> hawq-site parmeters under HAWQ service
> hawq_dfs_url
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> a20aa82 
>   ambari-web/app/utils/configs/move_namenode_config_initializer.js 160848c 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 460726b 
> 
> Diff: https://reviews.apache.org/r/46852/diff/
> 
> 
> Testing
> ---
> 
> yes.
>   27472 tests complete (29 seconds)
>   154 tests pending
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 46.556 s
> [INFO] Finished at: 2016-04-29T13:53:51-07:00
> [INFO] Final Memory: 14M/338M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/
---

Review request for Ambari.


Bugs: AMBARI-16174
https://issues.apache.org/jira/browse/AMBARI-16174


Repository: ambari


Description
---

when RM HA is not enabled, following properties should be updated in 
hawq-site.xml should be updated.
hawq_rm_yarn_address
hawq_rm_yarn_scheduler_address
When RM HA Is enabled and then a RM is moved, following properties in 
yarn-client.xml should be updated
yarn.resourcemanager.ha
yarn.resourcemanager.scheduler.ha


Diffs
-

  ambari-web/app/controllers/main/service/reassign/step4_controller.js a20aa82 
  ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
460726b 

Diff: https://reviews.apache.org/r/46860/diff/


Testing
---

Unit test passed
Calling set on destroyed view

  27428 tests complete (35 seconds)
  154 tests pending


Manually tested


Thanks,

jun aoki

Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46852/#review131191
---




ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 83)
<https://reviews.apache.org/r/46852/#comment195105>

Do you know how related services (or HAWQ) are restared after proeprties 
are changed?


- jun aoki


On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46852/
> ---
> 
> (Updated April 29, 2016, 8:50 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16191
> https://issues.apache.org/jira/browse/AMBARI-16191
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ Configuration should be updated whenever Namenode is being moved using 
> the move namenode wizard.
> Parameters which should be updated
> Case 1: HDFS HA
> hdfs-client parameters under HAWQ service
> dfs.namenode.rpc-address..
> dfs.namenode.http-address..
> Case 2: Non HA HDFS
> hawq-site parmeters under HAWQ service
> hawq_dfs_url
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> a20aa82 
>   ambari-web/app/utils/configs/move_namenode_config_initializer.js 160848c 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 460726b 
> 
> Diff: https://reviews.apache.org/r/46852/diff/
> 
> 
> Testing
> ---
> 
> yes.
>   27472 tests complete (29 seconds)
>   154 tests pending
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 46.556 s
> [INFO] Finished at: 2016-04-29T13:53:51-07:00
> [INFO] Final Memory: 14M/338M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46852/#review131189
---




ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 571)
<https://reviews.apache.org/r/46852/#comment195101>

you can use serviceToConfigSiteMap structure to add HAWQ.



ambari-web/app/utils/configs/move_namenode_config_initializer.js (line 113)
<https://reviews.apache.org/r/46852/#comment195103>

Did you test if this works when HAWQ is not installed?


- jun aoki


On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46852/
> ---
> 
> (Updated April 29, 2016, 8:50 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16191
> https://issues.apache.org/jira/browse/AMBARI-16191
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ Configuration should be updated whenever Namenode is being moved using 
> the move namenode wizard.
> Parameters which should be updated
> Case 1: HDFS HA
> hdfs-client parameters under HAWQ service
> dfs.namenode.rpc-address..
> dfs.namenode.http-address..
> Case 2: Non HA HDFS
> hawq-site parmeters under HAWQ service
> hawq_dfs_url
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> a20aa82 
>   ambari-web/app/utils/configs/move_namenode_config_initializer.js 160848c 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 460726b 
> 
> Diff: https://reviews.apache.org/r/46852/diff/
> 
> 
> Testing
> ---
> 
> yes.
>   27472 tests complete (29 seconds)
>   154 tests pending
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 46.556 s
> [INFO] Finished at: 2016-04-29T13:53:51-07:00
> [INFO] Final Memory: 14M/338M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 46800: HAWQ Configuration should be updated whenever Namenode is being moved.

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46800/#review131186
---


Ship it!




Ship It!

- jun aoki


On April 29, 2016, 8:46 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46800/
> ---
> 
> (Updated April 29, 2016, 8:46 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, Oleksandr 
> Diachenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-16172
> https://issues.apache.org/jira/browse/AMBARI-16172
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ Configuration should be updated whenever Namenode is being moved using 
> the move namenode wizard.
> Parameters which should be updated
> Case 1: HDFS HA
> hdfs-client parameters under HAWQ service
> dfs.namenode.rpc-address..
> dfs.namenode.http-address..
> Case 2: Non HA HDFS
> hawq-site parmeters under HAWQ service
> hawq_dfs_url
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 840bda3 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 1e137ee 
> 
> Diff: https://reviews.apache.org/r/46800/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
>   10505 tests complete (13 seconds)
>   121 tests pending
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 29.607 s
> [INFO] Finished at: 2016-04-28T14:53:42-07:00
> [INFO] Final Memory: 11M/213M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/#review130526
---


Ship it!




Ship It!

- jun aoki


On April 22, 2016, 11:51 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46585/
> ---
> 
> (Updated April 22, 2016, 11:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16074
> https://issues.apache.org/jira/browse/AMBARI-16074
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Show number of PXFs Live widget on main dashboard
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js 33e7f1c 
>   ambari-web/app/mappers/components_state_mapper.js 755c0f5 
>   ambari-web/app/messages.js 907d9ae 
>   ambari-web/app/views.js 6bb2774 
>   ambari-web/app/views/main/dashboard/widgets.js 067607f 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46585/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> Added Unit test.
> 
> Unit test Results:
> 
>   27538 tests complete (22 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:11 min
> [INFO] Finished at: 2016-04-22T16:50:37-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 46359: HAWQ Immediate Stop cluster fails with key error

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46359/#review129576
---


Ship it!




Ship It!

- jun aoki


On April 19, 2016, 1:20 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46359/
> ---
> 
> (Updated April 19, 2016, 1:20 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-15960
> https://issues.apache.org/jira/browse/AMBARI-15960
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Error log from running the wizard:
> 
> 
> stderr: 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 98, in 
> HawqMaster().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 219, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 69, in immediate_stop_hawq_service
> common.stop_component(hawq_constants.CLUSTER, hawq_constants.IMMEDIATE)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/common.py",
>  line 309, in stop_component
> port_property_name = 
> hawq_constants.COMPONENT_ATTRIBUTES_MAP[component_name]['port_property']
> KeyError: 'cluster'
>  stdout:
> None
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  4ce0c94 
> 
> Diff: https://reviews.apache.org/r/46359/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested. Unit Tests passed.
> 
> 
> Thanks,
> 
> Matt
> 
>

Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46294/
---

Review request for Ambari.


Bugs: AMBARI-15926
https://issues.apache.org/jira/browse/AMBARI-15926


Repository: ambari


Description
---

Activating standby could start a master with an old port, and the following 
operations in the Activate Standby wizard could be mislead. 
The fix is to stop the newly become master so that the wizard will only have to 
deal with the current value.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 e2114d8 

Diff: https://reviews.apache.org/r/46294/diff/


Testing
---

Unit test passed.
Manually tested.


Thanks,

jun aoki

Re: Review Request 46283: hawq init master fails to syncup hawq-site xml if there is a segment host down

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46283/#review129201
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 302)
<https://reviews.apache.org/r/46283/#comment192655>

```
# utils.exec_hawq_operation(hawq_constants.INIT, "{0}".format(options_str))
utils.exec_hawq_operation(hawq_constants.INIT, options_str)
```
Do we need format()?


- jun aoki


On April 15, 2016, 10:15 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46283/
> ---
> 
> (Updated April 15, 2016, 10:15 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, jun aoki, 
> Jayush Luniya, Matt, Oleksandr Diachenko, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15930
> https://issues.apache.org/jira/browse/AMBARI-15930
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In hawq init command, default bucket number is calculated and the updated 
> hawq-site.xml is copied to all the other nodes, if there is a segment host 
> down it will fail to syncup the fail. 
> Including the option to skip bad hosts as ambari will override this file 
> whenever the segment host is brought online and started.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  b929430 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 5f7f085 
> 
> Diff: https://reviews.apache.org/r/46283/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-15 
> 15:16:22,910 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys 
> is either set to false or is not available in hawq-env.xml
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_co

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
---

(Updated April 15, 2016, midnight)


Review request for Ambari.


Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852


Repository: ambari


Description
---

HAWQ restart after port change will fail because Ambari looks for a currently 
running process with a new port number.
This change is to make Ambari to look for an older port value.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 413cf1a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
 3f6c371 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
 f2ec914 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 636dcad 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 67d1cb0 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 92ac0af 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
 0baa4c5 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_utils.py PRE-CREATION 

Diff: https://reviews.apache.org/r/46186/diff/


Testing (updated)
---

Unit test has passed.
--
Ran 277 tests in 8.851s

OK
--
Total run:957
Total errors:0
Total failures:0
OK

Manual Test in progress.


Thanks,

jun aoki

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

> On April 14, 2016, 11 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py,
> >  line 26
> > <https://reviews.apache.org/r/46186/diff/3/?file=1345552#file1345552line26>
> >
> > do we need unit test for this function ?

will add unit test.


> On April 14, 2016, 11 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py,
> >  line 46
> > <https://reviews.apache.org/r/46186/diff/1-3/?file=1343693#file1343693line46>
> >
> > variable is not used anywhere else other than the line below, can 
> > probably inline it for brevity

will do


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review129024
-------


On April 14, 2016, 9:20 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 9:20 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  3f6c371 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
---

(Updated April 14, 2016, 9:20 p.m.)


Review request for Ambari.


Changes
---

Added missing import.


Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852


Repository: ambari


Description
---

HAWQ restart after port change will fail because Ambari looks for a currently 
running process with a new port number.
This change is to make Ambari to look for an older port value.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 413cf1a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
 3f6c371 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
 f2ec914 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 636dcad 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 67d1cb0 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 92ac0af 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
 0baa4c5 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 

Diff: https://reviews.apache.org/r/46186/diff/


Testing
---

Unit test has passed.
Manual Test in progress.


Thanks,

jun aoki

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

> On April 14, 2016, 3:33 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py,
> >  line 92
> > <https://reviews.apache.org/r/46186/diff/1/?file=1343689#file1343689line92>
> >
> > I think this function should only take a name of component and use 
> > utility to get process name and port number based on metadata. Maybe 
> > refactor that function from status into utils ?

PROCESS_INFO(now renamed to COMPONENT_ATTRIBUTES) holds port property names but 
not port numbers themselve. And a old port and a new port can be different 
depending on where it is from (either from Ambari or local hawq-site.xml)
The source can be determined by action(whether it is start or stop). so here is 
too much dependencies. This function should only form a string of netstat so 
I'd rather not to have the logic. 
(I'd replace the if statement with PROCESS_INFO though)


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128826
-------


On April 14, 2016, 2:19 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 2:19 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128934
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 (line 25)
<https://reviews.apache.org/r/46186/#comment192381>

that's a good idea Matt.


- jun aoki


On April 14, 2016, 2:19 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 2:19 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

> On April 14, 2016, 2:33 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py,
> >  line 92
> > <https://reviews.apache.org/r/46186/diff/1/?file=1343689#file1343689line92>
> >
> > Are the expected return values just 0 and 1?
> > 
> > If yes, the function can have a name similar to  __is_process_running

This returns a string of command wihich will be passed to not_if and only_if 
parameters.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128823
-------


On April 14, 2016, 2:19 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 2:19 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
---

Review request for Ambari.


Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852


Repository: ambari


Description
---

HAWQ restart after port change will fail because Ambari looks for a currently 
running process with a new port number.
This change is to make Ambari to look for an older port value.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 413cf1a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
 f2ec914 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 636dcad 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 67d1cb0 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 92ac0af 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
 0baa4c5 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 

Diff: https://reviews.apache.org/r/46186/diff/


Testing
---

Unit test has passed.
Manual Test in progress.


Thanks,

jun aoki

Re: Review Request 46062: PXF service check must occur only after PXF is started

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46062/#review128288
---


Ship it!




Ship It!

- jun aoki


On April 11, 2016, 11:23 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46062/
> ---
> 
> (Updated April 11, 2016, 11:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Jayush Luniya, Lav Jain, Matt, Sumit Mohanty, and Srimanth 
> Gunturi.
> 
> 
> Bugs: AMBARI-15817
> https://issues.apache.org/jira/browse/AMBARI-15817
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF service check must occur only after PXF is started
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 
> b179d1c 
> 
> Diff: https://reviews.apache.org/r/46062/diff/
> 
> 
> Testing
> ---
> 
> Tested manually, ran tests:
> --
> Ran 246 tests in 7.222s
> OK
> --
> Total run:925
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 45012: Recommendation and validation logic for HAWQ hdfs-client.xml output.replace-datanode-on-failure property

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45012/#review124221
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
694)
<https://reviews.apache.org/r/45012/#comment186682>

do you want to inline this since propertyvalue is used only once.



ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
979)
<https://reviews.apache.org/r/45012/#comment186681>

Do you want to set (constant) variable for a magic number 4?
```
REPLACE_DATANODE_ON_FAILURE_THREASHOLD = 4 # my poor naming skill...
if numSegments > REPLACE_DATANODE_ON_FAILURE_THREASHOLD and value ... :
  ...
elif numSegments <= REPLACE_DATANODE_ON_FAILURE_THREASHOLD and value ... : 
  ...

```

and you can use it on line 694


- jun aoki


On March 18, 2016, 2:01 a.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45012/
> ---
> 
> (Updated March 18, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Jayush Luniya, Lav Jain, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15499
> https://issues.apache.org/jira/browse/AMBARI-15499
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Recommendation and validation logic for HAWQ hdfs-client.xml 
> output.replace-datanode-on-failure property
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml
>  c2a756a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> c0bc4e2 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 4f0b4b7 
> 
> Diff: https://reviews.apache.org/r/45012/diff/
> 
> 
> Testing
> ---
> 
> manual
> 
> --
> Ran 253 tests in 7.111s
> 
> OK
> --
> Total run:927
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/#review124128
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 60)
<https://reviews.apache.org/r/44987/#comment186521>

Good point. That will acutally help cleaning some code. Will fix it.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 66)
<https://reviews.apache.org/r/44987/#comment186511>

```
-  for path in dir_paths.split(','):
-if path != "":
-  utils.create_dir_as_hawq_user(path)
+#   for path in dir_paths.split(','):
+# if path != "":
+#   utils.create_dir_as_hawq_user(path)
+  utils.create_dir_as_hawq_user(dir_paths)
```
I tried the code above but it does not work as commented.
When I have "/tmp/hawq/segment2,/tmp/hawq/segment3" then "segment2," (with 
a comman) was created.(I know it is weird)
I'd stick with my original.


- jun aoki


On March 17, 2016, 10:37 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44987/
> ---
> 
> (Updated March 17, 2016, 10:37 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15475
> https://issues.apache.org/jira/browse/AMBARI-15475
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many 
> [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
> and the change is not propagated to segments and the folders are not created.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  d62332d 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  0a597b6 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  9482b35 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  1bdc5aa 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496 
> 
> Diff: https://reviews.apache.org/r/44987/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 
> 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
> ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 
> 15:33:43,025 - Active master c6401.ambari.apache.org initialized
> ok
> test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 
> 15:33:43,049 - Master c6401.ambari.apache.org started
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

[jun aoki]

> On March 17, 2016, 11:10 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py,
> >  line 45
> > <https://reviews.apache.org/r/44987/diff/2/?file=1303610#file1303610line45>
> >
> > plural, so perhaps "..they should be.." instead of "..it should be.."

Good catch!


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/#review124115
-------


On March 17, 2016, 10:37 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44987/
> ---
> 
> (Updated March 17, 2016, 10:37 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15475
> https://issues.apache.org/jira/browse/AMBARI-15475
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many 
> [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
> and the change is not propagated to segments and the folders are not created.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  d62332d 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  0a597b6 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  9482b35 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  1bdc5aa 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496 
> 
> Diff: https://reviews.apache.org/r/44987/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 
> 15:33:42,969 - Standby host c6401.ambari.apache.org initialized
> ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 
> 15:33:43,025 - Active master c6401.ambari.apache.org initialized
> ok
> test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 
> 15:33:43,049 - Master c6401.ambari.apache.org started
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/
---

Review request for Ambari.


Bugs: AMBARI-15475
https://issues.apache.org/jira/browse/AMBARI-15475


Repository: ambari


Description
---

Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many 
[/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
and the change is not propagated to segments and the folders are not created.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 d62332d 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 0a597b6 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 9482b35 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
 1bdc5aa 

Diff: https://reviews.apache.org/r/44987/diff/


Testing
---

manually tested.


Thanks,

jun aoki

Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44987/
---

(Updated March 18, 2016, 10:17 p.m.)


Review request for Ambari.


Bugs: AMBARI-15475
https://issues.apache.org/jira/browse/AMBARI-15475


Repository: ambari


Description
---

Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many 
[/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment]
and the change is not propagated to segments and the folders are not created.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 d62332d 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 0a597b6 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 9482b35 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
 1bdc5aa 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
 dc6c203 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496 

Diff: https://reviews.apache.org/r/44987/diff/


Testing
---

manually tested.

test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
test_install_default (test_hawqsegment.TestHawqSegment) ... ok
test_start_default (test_hawqsegment.TestHawqSegment) ... ok
test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
test_install_default (test_hawqstandby.TestHawqStandby) ... ok
test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 
15:33:42,969 - Standby host c6401.ambari.apache.org initialized
ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,025 
- Active master c6401.ambari.apache.org initialized
ok
test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 
15:33:43,049 - Master c6401.ambari.apache.org started
ok
test_stop_default (test_hawqmaster.TestHawqMaster) ... ok


Thanks,

jun aoki

Re: Review Request 44868: Changed HAWQ directory descriptions

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44868/#review123818
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 (line 121)
<https://reviews.apache.org/r/44868/#comment186104>

```
... temp directories is equal ...
```
as 1. use "directories" instead of "dirs" and 2. "is" instead of "are" as 
it is a verb of "the recommended number"? 
Sorry this is trivial but since you are enhancing the description.


- jun aoki


On March 15, 2016, 10:51 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44868/
> ---
> 
> (Updated March 15, 2016, 10:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Jayush Luniya, Lav Jain, Oleksandr Diachenko, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15433
> https://issues.apache.org/jira/browse/AMBARI-15433
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed HAWQ directory descriptions
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  d3aa0ed 
> 
> Diff: https://reviews.apache.org/r/44868/diff/
> 
> 
> Testing
> ---
> 
> manual.
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 44528: Align PXF Alert description with other services

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44528/
---

(Updated March 8, 2016, 11:56 p.m.)


Review request for Ambari.


Bugs: AMBARI-15339
https://issues.apache.org/jira/browse/AMBARI-15339


Repository: ambari


Description
---

Align PXF Alert description with other services


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
d32fc97 

Diff: https://reviews.apache.org/r/44528/diff/


Testing
---

Manually Done


Thanks,

jun aoki