-
CONTRIBUTING.md daf95bc94befcf425da2fd32fffcdaec93f3706f
docs/development/committers-guide.md 2650f19d057cd17b62b80833dc4a53f7f5398edf
ui/package.json 567dd78a359ec4a9f167689648decb108a6247cf
Diff: https://reviews.apache.org/r/68110/diff/1/
Testing
---
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68071/#review206520
---
Ship it!
Ship It!
- Jordan Ly
On July 26, 2018, 10:02 p.m
and ensure the new metrics are being recorded.
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67967/#review206206
---
Ship it!
Ship It!
- Jordan Ly
On July 18, 2018, 8:27 p.m
events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
before being evaluated for the update, then we will
kill A' and update the configuration
Lots of moving parts for updates so hopefully what I said makes sense :/
- Jordan
---
This is an automatically generated e-mail
-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
/67696/diff/8-9/
Testing
---
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
; > Drop `_` here and everywhere. `SLA_CHECKING` sounds like a valid event
> > that is definied in code.
>
> Jordan Ly wrote:
> Can you elaborate on this? Did you mean drop `_MESSAGE`? I added
> `_MESSAGE` because it is not a true "event" in the sense tha
/diff/7-8/
Testing
---
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
/
Testing
---
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67696/#review205879
---
@ReviewBot retry
- Jordan Ly
On July 9, 2018, 11:12 p.m
://reviews.apache.org/r/67696/diff/5-6/
Testing
---
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
t; Drop `_` here and everywhere. `SLA_CHECKING` sounds like a valid event
> > that is definied in code.
Can you elaborate on this? Did you mean drop `_MESSAGE`? I added `_MESSAGE`
because it is not a true "event" in the sense that it piggybacks on
`INSTANCE_UPDATING` or `INSTANCE_ROLLING_BACK` with a message showing progress.
- Jordan
-
://reviews.apache.org/r/67696/diff/4-5/
Testing
---
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
---
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
/2-3/
Testing
---
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
Diff: https://reviews.apache.org/r/67696/diff/1/
Testing
---
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring
concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
metadata like countdown-ms inside the query
param of a POST request. If we add more metadata, we could soon have very long
query strings.
Overall, I don't have a strong preference either way. I would probably err
towards adding a metadata field to the json body, but no blocking concerns.
- Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67639/#review205005
---
Ship it!
Ship It!
- Jordan Ly
On June 19, 2018, 1:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67638/#review204965
---
Ship it!
Ship It!
- Jordan Ly
On June 18, 2018, 11:20 p.m
> On June 15, 2018, 6:03 p.m., Jordan Ly wrote:
> > Oops missed one thing:
> >
> > You need to add a scheduler active binding in the module:
> > ```
> > SchedulerServicesModule.addSchedulerActiveServiceBinding(binder())
> > .to([SOMETHING].cla
active binding in the module:
```
SchedulerServicesModule.addSchedulerActiveServiceBinding(binder())
.to([SOMETHING].class);
```
- Jordan Ly
On June 15, 2018, 6:02 p.m., Santhosh Kumar Shanmugham wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204856
---
Ship it!
Ship It!
- Jordan Ly
On June 15, 2018, 5:58 p.m
gt;
nit: why double dashes?
src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java
Lines 384 (patched)
<https://reviews.apache.org/r/66716/#comment286264>
Would it be useful to add a log message here for forcing through SLA
requirements?
- Jordan Ly
On May 25, 2018, 12
/state/MaintenanceController.java
Lines 453 (patched)
<https://reviews.apache.org/r/66716/#comment285990>
Remove `ISlaPolicy.build`
src/test/java/org/apache/aurora/scheduler/sla/SlaManagerTest.java
Lines 1018 (patched)
<https://reviews.apache.org/r/66716/#comment285997>
`Thread.sleep(15
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67141/#review203525
---
@ReviewBot retry
- Jordan Ly
On May 17, 2018, 2:07 a.m
/apache/aurora/scheduler/events/WebhookTest.java
3e10c57e00ba12725310bd50bd55743bec95a77b
Diff: https://reviews.apache.org/r/67219/diff/5/
Changes: https://reviews.apache.org/r/67219/diff/4-5/
Testing
---
`./gradlew test` passes.
Repeated AuroraBot tests.
Thanks,
Jordan Ly
(updated)
---
`./gradlew test` passes.
Repeated AuroraBot tests.
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/#review203458
---
@ReviewBot retry
- Jordan Ly
On May 18, 2018, 6:43 p.m
---
Thanks,
Jordan Ly
we use a feature toggle here operators can enable the backwards
> > incompatible change after they have vetted the release (i.e. once they are
> > sure they don't need to do a rollback for unrelated issues).
> >
> > We can then simply enable the feature toggle
> On May 16, 2018, 5:02 p.m., Jordan Ly wrote:
> > Mostly LGTM.
> >
> > This patch only allows for a better rollback story if you are developing
> > from HEAD? You might have to cut a release after this patch so there is
> > -1/+1 version compatabili
torage/durability/WriteRecorder.java
Lines 266-267 (patched)
<https://reviews.apache.org/r/67141/#comment285339>
Same as above.
- Jordan Ly
On May 15, 2018, 9:15 p.m., Santhosh Kumar Shanmugham wrote:
>
> ---
> Thi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67141/#review203242
---
@ReviewBot retry
- Jordan Ly
On May 15, 2018, 9:15 p.m
.py
Line 170 (original), 171 (patched)
<https://reviews.apache.org/r/66716/#comment284880>
nit: newline
src/main/python/apache/aurora/executor/executor_vars.py
Line 65 (original), 65 (patched)
<https://reviews.apache.org/r/66716/#comment28488
d into a list or
joined into a string. This will print out an object reference.
- Jordan Ly
On May 1, 2018, 9:19 p.m., Santhosh Kumar Shanmugham wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
omment284152>
I think this (+ its dependencies and options) may be better suited for the
`SlaModule`.
src/main/java/org/apache/aurora/scheduler/state/StateModule.java
Lines 131-140 (patched)
<https://reviews.apache.org/r/66716/#comment284153>
I would create a `MaintenanceModule` and mo
:/
Vagrantfile
Lines 20-21 (original), 20-21 (patched)
<https://reviews.apache.org/r/66922/#comment284109>
Should we need to update (or remove) this comment?
- Jordan Ly
On May 2, 2018, 10:08 p.m., Renan DelValle
y role.
```
Not a huge deal though
src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java
Lines 64 (patched)
<https://reviews.apache.org/r/66806/#comment283681>
rename from `test` to something more descriptive
- Jordan Ly
On April 26, 2018, 5:51 p.m., David McLa
utes an action provided by the
caller. I am thinking about this in terms of my proposed SLA-aware updates -- I
would be able to utilize this interface as well.
src/main/java/org/apache/aurora/scheduler/storage/HostMaintenanceStore.java
Lines 22-28 (patched)
<https://reviews.apache.org/r/66716/#c
interval.
Thanks,
Jordan Ly
0bd8d214f49aeb09721cd33776ef213e9cf00347
Diff: https://reviews.apache.org/r/66570/diff/1/
Testing
---
`./gradlew test` passes. Manually forcing `JOB_A` (the condition that caused
the error before) to get searched first passes.
Thanks,
Jordan Ly
at scale.
Thanks,
Jordan Ly
/
Testing
---
Added unit tests, `./gradlew test` passes.
Manually ensured new metrics are exported.
Tested at scale.
Thanks,
Jordan Ly
://reviews.apache.org/r/66199/diff/1/
Testing
---
`./gradlew test`
Thanks,
Jordan Ly
batch size specified to the variable strategy should behave
the same as the current implementation).
- Jordan Ly
On March 21, 2018, 2:10 a.m., Renan DelValle wrote:
>
> ---
> This is an automatically generated e-mail. To rep
> On March 21, 2018, 12:10 a.m., Jordan Ly wrote:
> > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java
> > Lines 386-387 (original), 386-387 (patched)
> > <https://reviews.apache.org/r/66190/diff/1/?file=1984290#file1984290line387>
> >
> &g
SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark:·stack
1000 thrpt NaN
---
```
Benchmark is slower as it is doing more (correct) work.
Thanks,
Jordan Ly
---
```
Benchmark is slower as it is doing more (correct) work.
Thanks,
Jordan Ly
s the number of hosts we look at when doing preemptions.
- Jordan Ly
On March 21, 2018, 12:04 a.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
```
Benchmark is slower as it is doing more (correct) work.
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66136/#review199447
---
Ship it!
Ship It!
- Jordan Ly
On March 19, 2018, 2:55 p.m
8, 2:55 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66136/
> ---
>
> (Updated Ma
o reply, visit:
https://reviews.apache.org/r/65769/#review199333
---
On Feb. 23, 2018, 6:04 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
ver[3129]: Bottle v0.11.6 server starting up
(using CherryPyServer())...
Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on
http://192.168.33.7:1338/
Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
```
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65769/#review199219
---
bump
- Jordan Ly
On Feb. 23, 2018, 6:04 p.m., Jordan Ly wrote
/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
35e9348e6ab0c14e6ae20af4076358d7e12681c7
Diff: https://reviews.apache.org/r/66074/diff/1/
Testing
---
Manually tested state endpoint returns jobs when preemptor is both on and off.
Thanks,
Jordan Ly
> On March 7, 2018, 6:48 p.m., David McLaughlin wrote:
> > So what happens if there are two bad hosts? :)
>
> Jordan Ly wrote:
> This does not scale past n=1
>
> We can make this more generic by getting the list of hosts the task has
> previously fa
iew198803
---
On March 7, 2018, 5:50 a.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
/TaskAssignerImplTest.java
864538b6730d7318385494818276ba370124b8e9
Diff: https://reviews.apache.org/r/65941/diff/1/
Testing
---
`./gradlew test`
Benchmarks and live-cluster testing coming soon.
Thanks,
Jordan Ly
]: Bottle v0.11.6 server starting up
(using CherryPyServer())...
Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on
http://192.168.33.7:1338/
Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit.
```
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65873/#review198498
---
Ship it!
Any notable changes?
- Jordan Ly
On March 2, 2018
: https://reviews.apache.org/r/65769/diff/1/
Testing
---
`./gradlew test`
`./gradlew jmh`
end-to-end tests pass.
Thanks,
Jordan Ly
---
`./gradlew test`
Manually verified Firefox, Chrome, and Safari.
Thanks,
Jordan Ly
ne has a way to confirm
please let me know :)
- Jordan Ly
On Feb. 16, 2018, 8:59 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
bfd117b4988c35c6b3f95508b2924bbd19b0c692
Diff: https://reviews.apache.org/r/65690/diff/1/
Testing
---
`./gradlew test`
Manual testing in Safari, Chrome, and Firefox.
Thanks,
Jordan Ly
s.apache.org/r/65680/diff/2/
Changes: https://reviews.apache.org/r/65680/diff/1-2/
Testing
---
Repro'd bug using steps above. Validated code changes solved issue.
Added small change in unit test to ensure state is now preserved in the Quartz
job context.
`./gradlew test`
Thanks,
Jordan Ly
ted code changes solved issue.
Added small change in unit test to ensure state is now preserved in the Quartz
job context.
`./gradlew test`
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65648/#review197574
---
Ship it!
Ship It!
- Jordan Ly
On Feb. 14, 2018, 5:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197488
---
Ship it!
Ship It!
- Jordan Ly
On Feb. 12, 2018, 8:36 a.m
: aurora
Description
---
Add GPG key for jorda...@apache.org
Diffs
-
KEYS 843e955e8f69e4d36b61df66aa20a1c914cb77c9
Diff: https://reviews.apache.org/r/65650/diff/1/
Testing
---
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65649/#review197487
---
Ship it!
Ship It!
- Jordan Ly
On Feb. 14, 2018, 5:05 a.m
correctly but inspecting the `thrift.js` file being return showed that
the version was still `0.91`. I had to do a `git clean -fdx` and destroy/bring
up the vagrant cluster again in order to reproduce the error above.
- Jordan Ly
On Jan. 31, 2018, 10:11 a.m., Stephan Erb wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65537/#review196936
---
Ship it!
Ship It!
- Jordan Ly
On Feb. 6, 2018, 10:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65434/#review196603
---
Ship it!
Ship It!
- Jordan Ly
On Jan. 31, 2018, 10:57 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65303/#review196592
---
Ship it!
Ship It!
- Jordan Ly
On Jan. 31, 2018, 6:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65338/#review196275
---
Ship it!
Ship It!
- Jordan Ly
On Jan. 25, 2018, 6:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65281/#review196046
---
Ship it!
Nice test for future cases.
- Jordan Ly
On Jan. 23
ld be a module, right?
Yep! Good catch, changed.
- Jordan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65233/#review195867
---
On Ja
---
`./gradlew test`
`./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh`
Testing injection of a custom `OfferSet` onto a test cluster.
Thanks,
Jordan Ly
s that the number of tasks per agent can
> > shift drastically, sometimes even up to a point where the Thermos observer
> > is completely unusable).
>
> Jordan Ly wrote:
> Some context for the new interface:
>
> For performance, it is helpful to control the data struc
1e36b2c3094e99f05aa4a4f098a48df2293b4320
Diff: https://reviews.apache.org/r/65225/diff/1/
Testing
---
TODO: I am planning on adding tests for `FilterableCollection`, just wanted to
put this out there for quick comments.
I've done some ad-hoc testing of injecting custom collection types.
Thanks,
Jordan Ly
/apache/aurora/scheduler/scheduling/TaskAssignerImplTest.java
Lines 369-372 (original), 356-358 (patched)
<https://reviews.apache.org/r/64954/#comment274180>
nit: can you just expect 0
- Jordan Ly
On Jan. 9, 2018, 6:32 p.m., Bill Farner
duling/TaskSchedulerImpl.java
Lines 152-158 (original), 141-144 (patched)
<https://reviews.apache.org/r/64954/#comment273872>
Is this check effectively the same as the check in `fetchTasks`? Unless
`ids` can be empty...
- Jordan Ly
On Jan. 4, 2018, 7:08 p.m., Bill
-
On Jan. 4, 2018, 7:08 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64954/
> ---
>
> (Updated Jan. 4, 2018, 7:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64519/#review194729
---
Ship it!
This LGTM!
- Jordan Ly
On Dec. 12, 2017, 1:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64629/#review193946
---
Ship it!
Ship It!
- Jordan Ly
On Dec. 14, 2017, 11:09 p.m
t;
> (Updated Dec. 14, 2017, 10:05 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This tool was originally intended as a migration path between Persistenc
> On Dec. 14, 2017, 2:07 a.m., Jordan Ly wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
> > Line 88 (original), 90 (patched)
> > <https://reviews.apache.org/r/64286/diff/3/?file=1914592#file1914592line90>
> >
&g
rc/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java
Lines 100 (patched)
<https://reviews.apache.org/r/64286/#comment272393>
Do we need to map edit -> op?
- Jordan Ly
On Dec.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193610
---
@ReviewBot retry
- Jordan Ly
On Dec. 12, 2017, 7:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193595
---
@ReviewBot retry
- Jordan Ly
On Dec. 12, 2017, 7:15 p.m
and the unknown cause of the actual errors. Maybe we run the
reviewbot on this repo repeatedly? Obviously not the most scientifically sound
solution.
EDIT 12/12: I tested this by putting a long sleep in `onThrowable` which causes
the issue in master and is fixed with this patch.
Thanks,
Jordan
rowable t) {
> > +try {
> > + Thread.sleep(1000);
> > +} catch (InterruptedException e) {
> > +}
> > errorsCounter.incrementAndGet();
> > LOG.error("Error sending a Webhook event", t);
> > ```
> >
> > If i
/aurora/scheduler/events/WebhookTest.java
> 1b5d2d02535345edfe6cf04d18d00434393f800b
>
>
> Diff: https://reviews.apache.org/r/64523/diff/1/
>
>
> Testing
> ---
>
> This change seems pretty hard to test considering the differences in
> environment and the unknown cause of the actual errors. Maybe we run the
> reviewbot on this repo repeatedly? Obviously not the most scientifically
> sound solution.
>
>
> Thanks,
>
> Jordan Ly
>
>
/64523/diff/1/
Testing
---
This change seems pretty hard to test considering the differences in
environment and the unknown cause of the actual errors. Maybe we run the
reviewbot on this repo repeatedly? Obviously not the most scientifically sound
solution.
Thanks,
Jordan Ly
To reply, visit:
https://reviews.apache.org/r/64459/#review193287
-------
On Dec. 8, 2017, 8:08 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail.
pshot failures propogate, do they kill the scheduler or just the
service? If everything stays up, can we increment a counter for failed
snapshots?
We probably don't want to kill the service if a snapshot fails since that
means it will never try to snapshot again.
- Jordan Ly
On Dec.
1 - 100 of 220 matches
Mail list logo
