will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Dec. 16, 2015, 7:15 a.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To re
appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Dec. 16, 2015, 4:41 p.m., Kasisnu Singh wrote:
>
> ---
> This is an automatical
will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Dec. 14, 2015, 10:36 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To re
will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Nov. 25, 2015, 5 p.m., George Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Dec. 7, 2015, 1:17 p.m., Martin Hrabovcin wrote:
>
> ---
> This is an automatically generated e-mail. To re
to rebase?
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Dec. 2, 2015, 11:57 p.m., Steve Niemitz wrote:
>
> ---
> This is an automatically generated e-mail. To re
will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Dec. 11, 2015, 1:33 a.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To re
Optional and on the next line add the stopAsync as a tear down?
- John Sirois
On Dec. 16, 2015, 11:19 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41453/#review110739
---
Ship it!
Ship It!
- John Sirois
On Dec. 16, 2015, 12:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41521/#review111002
---
Ship it!
Ship It!
- John Sirois
On Dec. 17, 2015, 11:18 a.m
`
Thanks,
John Sirois
> On Nov. 15, 2015, 11:34 a.m., John Sirois wrote:
> > Brice - this would be nice to land. Are you able to put time towards the
> > cleanups suggested by Kevin and style fixes failing the build currently?
> > If so - great. If not, I can brush this up and send out a
6efe03fe4841cf1275e2ee0c7cc1b9576540f34e
Diff: https://reviews.apache.org/r/41528/diff/
Testing
---
Green locally: `./gradlew -Pq build`
Thanks,
John Sirois
/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
6efe03fe4841cf1275e2ee0c7cc1b9576540f34e
Diff: https://reviews.apache.org/r/41528/diff/
Testing
---
Green locally: `./gradlew -Pq build`
Thanks,
John Sirois
sit:
https://reviews.apache.org/r/41528/#review111058
---
On Dec. 17, 2015, 2:27 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
official rpm release, moving
the native log path is deemed safe since it affects no-one.
- John Sirois
On Dec. 18, 2015, 11:04 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
181/mesos|g'
/etc/sysconfig/aurora
```
- John Sirois
On Dec. 18, 2015, 11:35 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41559/#review111227
---
Ship it!
NMM - you did that!
- John Sirois
On Dec. 18, 2015
Request: http://localhost:/api/review-requests/2/reviews/
Request: http://localhost:/api/review-requests/2/diffs/
Latest feedback was given at2015-12-16T18:50:13Z
Latest build request from a user at 2015-12-16T18:50:13Z
Latest diff was posted at 2015-12-16T18:49:55Z
```
Thanks,
John Sirois
y need to be adjusted - or else give
and example for each OS.
- John Sirois
On Dec. 18, 2015, 12:58 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
https://reviews.apache.org/r/41565/#review111257
---
On Dec. 18, 2015, 1 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-ma
> On Dec. 18, 2015, 1:12 p.m., John Sirois wrote:
> >
I won't be able to get to trials until later this evening. Ideally though this
doc could be tied to the test/ provision.sh's somehow for more assured
working-ness. I have no useful suggestion though atm of how to
le in this repo.
- John Sirois
On Dec. 18, 2015, 1:39 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
/reviews.apache.org/r/41564/#comment171430>
s/aurora-thermos/aurora-executor/
- John Sirois
On Dec. 18, 2015, 1:39 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
18, 2015, 1:39 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
>
> (Updated Dec. 18, 2015, 1:39 p.m.)
>
>
&
oks fine although I used:
```
wget -c https://apache.bintray.com/aurora/aurora-tools_0.10.0-1_amd64.deb
sudo dpkg -i aurora-tools_0.10.0-1_amd64.deb
```
- John Sirois
On Dec. 18, 2015, 1:39 p.m., Bill Farner wrote:
>
> ---
> T
> On Dec. 18, 2015, 3:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 146
> > <https://reviews.apache.org/r/41564/diff/3/?file=1171347#file1171347line146>
> >
> > Isn't that outdated?
>
> John Sirois wrote:
> I think so - I used
able to
submit a hello_world.aurora successfully. I used 1 mod noted below:
docs/installing.md (line 263)
<https://reviews.apache.org/r/41564/#comment171702>
I used `openjdk-8-jre-headless` here.
- John Sirois
On Dec. 20, 2015, 10:32 a.m., Bill Farner
mbuild/RPMS/x86_64/aurora-scheduler-0.10.0-1.el7.centos.aurora.x86_64.rpm
```
Thanks,
John Sirois
tps://reviews.apache.org/r/41610/#comment171705>
NB: Without an update I was getting conflicts, seems ~unrelated, but I was
not able to make sense of this.
- John Sirois
On Dec. 21, 2015, 9:59 a.m., John Sirois wrote:
>
> ---
> This is a
example job
submission and involves the scheduler failing to open the distributed log -
looking into that currently.
docs/installing.md (line 236)
<https://reviews.apache.org/r/41564/#comment171707>
# Note: for older Aurora RPM versions, this may be called 'aurora-client'.
-
> On Dec. 21, 2015, 10:16 a.m., John Sirois wrote:
> > 1 small issue for CentOS noted below, the larger issue blocks example job
> > submission and involves the scheduler failing to open the distributed log -
> > looking into that currently.
Also discovered the aurora-
> On Dec. 21, 2015, 10:16 a.m., John Sirois wrote:
> > 1 small issue for CentOS noted below, the larger issue blocks example job
> > submission and involves the scheduler failing to open the distributed log -
> > looking into that currently.
>
> John Sirois wrote
LGTM. More work later to
make this process stable and easily testable / automated.
- John Sirois
On Dec. 20, 2015, 10:32 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> On Dec. 21, 2015, 10:01 a.m., John Sirois wrote:
> > builder/rpm/centos-7/Dockerfile, line 15
> > <https://reviews.apache.org/r/41610/diff/1/?file=1173924#file1173924line15>
> >
> > NB: Without an update I was getting conflicts, seems ~unrelated, but I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111520
---
Ship it!
Ship It!
- John Sirois
On Dec. 21, 2015, 11:41 a.m
server.
Thanks,
John Sirois
that some
external process ensures the `origin/master` reference is up2date (jenkins).
In my testing that external process was me doing a fetch before running this
tool.
- John Sirois
On Dec. 22, 2015, 2:26 p.m., John Sirois wrote
(+), 103 deletions(-)
Diffs (updated)
-
build-support/jenkins/review_feedback.py
ee37742c78a7b28bc1ccc687afae17f711471fc4
Diff: https://reviews.apache.org/r/41659/diff/
Testing
---
Extensive testing against a local server.
Thanks,
John Sirois
ttps://reviews.apache.org/r/41659/#review111790
---
On Dec. 22, 2015, 2:34 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
> On Dec. 27, 2015, 1:32 p.m., Bill Farner wrote:
> > Thanks, this is a great addition! Since i can't use `rbt` to apply this
> > patch, i'll pull it from your branch on github instead. Can you squash
> > that branch to a single commit? I'd like to just cherry-pick your commit
> > to preser
just cherry-pick your commit
> > to preserve authorship information.
>
> John Sirois wrote:
> FWIW, you can use this trick if there is no associated PR:
> `curl -sSL
> https://github.com/apache/aurora/compare/master...StephanErb:fmc.patch | git
> am -3`
...
; it's just something we need to be aware of (stay on top of closing RB's,
> > and keep an eye out for erroneous "needs rebase" messages from ReviewBot).
>
> John Sirois wrote:
> If the concept of a patch chain were made explicit and passed around then
/41755/diff/
Testing
---
./gradlew -Pq build
Thanks,
John Sirois
7eedd255dcda47350c645701ed2fc25d6b53ab96
Diff: https://reviews.apache.org/r/41755/diff/
Testing
---
./gradlew -Pq build
Thanks,
John Sirois
ing to unset-it.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/#review112088
---
On Dec. 28, 2015, 4:15 p.m., Jo
> On Dec. 28, 2015, 4:43 p.m., Zameer Manji wrote:
> > Not sure if you saw but setting classpath to null was the suggested work
> > around on my post on the gradle forum.
>
> John Sirois wrote:
> Ouch - did not. I played for a good while trying to build up the
6d9d2d4f502c0115aedbddeb46de6b19398b1e89
buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
gradle/wrapper/gradle-wrapper.properties
7eedd255dcda47350c645701ed2fc25d6b53ab96
Diff: https://reviews.apache.org/r/41755/diff/
Testing
---
./gradlew -Pq build
Thanks,
John Sirois
> On Dec. 28, 2015, 4:43 p.m., Zameer Manji wrote:
> > Not sure if you saw but setting classpath to null was the suggested work
> > around on my post on the gradle forum.
>
> John Sirois wrote:
> Ouch - did not. I played for a good while trying to build up the
/centos-7
../aurora/snapshot.tar.gz 0.12.0_SNAPSHOT
```
Thanks,
John Sirois
g/r/41763/#comment172489>
I'm not positive what the rubric is, but it reads to me like all forces
here above the '// Force ...' comment fold should use an `ext.XXX` variable to
"pin to the aurora prod dep".
- John Sirois
On Dec. 28, 201
---
On Dec. 28, 2015, 8:07 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41762/
> ---
>
> (
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41762/
> ---
>
> (Updated Dec. 28, 2015, 8:07 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
>
/ZooKeeperTestServer.java
(line 83)
<https://reviews.apache.org/r/41762/#comment172490>
'..., max 60 conections is ...' would be an even more helpful comment
- John Sirois
On Dec. 28, 2015, 8:07 p.m., Bill Farner wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41763/#review112181
---
Ship it!
Ship It!
- John Sirois
On Dec. 29, 2015, 9:45 a.m
> On Dec. 28, 2015, 8:12 p.m., Bill Farner wrote:
> >
>
> John Sirois wrote:
> I found that by upgrading all the way to 3.4.7 the krb issues go away in
> the unit tests (`./gradlew -Pq build`), although e2e krb fails (digging).
> Presuming I can find a fix for tha
that 3.4.2+
clients can read and write to 3.3.x servers from folks in the field with
production zk setups.
- John Sirois
On Dec. 29, 2015, 10:09 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To rep
experiments found no actual zk
client / server mismatch issues.
- John Sirois
On Dec. 29, 2015, 10:09 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -------
>
> (Updated Dec. 29, 2015, 2:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Descr
reply, visit:
> https://reviews.apache.org/r/41778/
> ---
>
> (Updated Dec. 29, 2015, 2:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> I'm using this f
mment172583>
Hrm, well this adds more work to removing debug guards, but I do think its
worth it to remove prod clutter.
- John Sirois
On Dec. 29, 2015, 2:08 p.m., Bill Farner wrote:
>
> -
s/all/cli/ for nicer ergonomics - easy guessability.
- John Sirois
On Dec. 29, 2015, 3:32 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
n Dec. 29, 2015, 3:32 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> ---
>
> (Updated
> On Dec. 29, 2015, 3:15 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, line
> > 100
> > <https://reviews.apache.org/r/41777/diff/1/?file=1177565#file1177565line100>
> >
> > This now always logs a
/ApiBeta.java (line 125)
<https://reviews.apache.org/r/41777/#comment172650>
You can use {}'s and drop the guard now.
- John Sirois
On Dec. 29, 2015, 4:52 p.m., Bill Farner wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41777/#review112269
---
Ship it!
Ship It!
- John Sirois
On Dec. 29, 2015, 5:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41785/#review112272
---
Ship it!
Ship It!
- John Sirois
On Dec. 29, 2015, 5:49 p.m
to the reader
than the RB id number.
build-support/jenkins/review_feedback.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Diffs
-
build-support/jenkins/review_feedback.py
aa2c836ad453a52bac29020a3be2c4f614b0ee8a
Diff: https://reviews.apache.org/r/41812/diff/
Testing
---
Manual curling of the api to check the schema for this correction.
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41785/#review112355
---
@ReviewBot retry
- John Sirois
On Dec. 29, 2015, 11:29 p.m
tps://reviews.apache.org/r/41812/#comment172830>
Rushed this one - 'RB#%d' is no longer correct.
Another xix RB coming.
- John Sirois
On Dec. 30, 2015, 4:33 p.m., John Sirois wrote:
>
> ---
> This is an automatic
---
build-support/jenkins/review_feedback.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Diffs
-
build-support/jenkins/review_feedback.py
7e11629baf891423d02a086848142d433dad351c
Diff: https://reviews.apache.org/r/41813/diff/
Testing
---
None.
Thanks,
John
> On Dec. 30, 2015, 4:50 p.m., John Sirois wrote:
> > build-support/jenkins/review_feedback.py, line 133
> > <https://reviews.apache.org/r/41812/diff/1/?file=1179937#file1179937line133>
> >
> > Rushed this one - 'RB#%d' is no longer correct.
>
e.org/r/41804/#comment172832>
It might be slightly less churn to move these in to the interface via
default methods - when the cutover is made to the new system where default
methods should only provide defaults, the edits will be line deletes or
replacement with default values.
- John Sir
`ApiBetaTest` from within IDEA using `./gradlew idea` to gen a new
project.
Thanks,
John Sirois
https://reviews.apache.org/r/41893/diff/
Testing
---
Not green locally due to ZK issues from
https://git1-us-west.apache.org/repos/asf/aurora/repo?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7,
but the CI script gets further on my machine with the junit
dep added
Thanks,
John Sirois
/BaseZooKeeperTest.java:import
org.junit.Before;
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java:import
org.junit.Rule;
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java:import
org.junit.rules.TemporaryFolder;
```
- John Sirois
On Jan. 4, 2016
?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7,
but the CI script gets further on my machine with this fix.
Thanks,
John Sirois
:
```
org.apache.aurora.common.zookeeper.GroupTest >
testJoinsAndWatchesSurviveDisconnect FAILED
java.lang.IllegalThreadStateException at GroupTest.java:153
```
- John Sirois
On Jan. 4, 2016, 2:30 p.m., John Sirois wrote:
>
> ---
> This is an a
ory.configure(NIOServerCnxnFactory.java:96)
at
org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:81)
at
org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.setUp(BaseZooKeeperTest.java:64)
...
```
Thanks,
John Sirois
/r/41897/diff/
Testing
---
Both `./build-support/jenkins/build.sh` and
`./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
green locally.
Thanks,
John Sirois
---
Not green locally due to ZK/krb interaction issues from
https://git1-us-west.apache.org/repos/asf/aurora/repo?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7,
but the CI script gets further on my machine with this fix.
Thanks,
John Sirois
it:
https://reviews.apache.org/r/41897/#review112679
---
On Jan. 4, 2016, 4:02 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
; ===[0m
> >
> > FAILURE
> >
> >
> > 23:20:37 04:05 [complete][31m
> >FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
I
579d86cd2e02ea3e1a7add9cdd8291a6dc9669ec
Diff: https://reviews.apache.org/r/41899/diff/
Testing
---
Locally green:
```
./build-support/jenkins/build.sh &&
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
> On Jan. 4, 2016, 4:17 p.m., Stephan Erb wrote:
> > News file needs updating too :-)
>
> John Sirois wrote:
> Good call - change coming as well as an updated reviews list.
Fixed.
- John
---
This is an automat
/build.sh` and
`./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
green locally.
Thanks,
John Sirois
2:
> > AssertionError
> > generated xml file:
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.observer.observer.xml
> >
> > [1m[31m=== 1 failed, 3 passed in 0.25 seconds
> >
t RB.
- John Sirois
On Jan. 4, 2016, 4:04 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41894/
> -
/ -- -kTaskObserverTest
done
```
After the change I cannot trigger the failure.
Thanks,
John Sirois
/test/python/apache/thermos/observer/ -- -kTaskObserverTest
done
```
After the change I cannot trigger the failure.
Thanks,
John Sirois
like it only
really tests the proper converson from Time Amounts to fractional second waits.
- John Sirois
On Jan. 4, 2016, 8:02 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41915/#review112750
---
On Jan. 4, 2016, 8:02 p.m., John Sirois wrote:
>
> --
ectly into the arg list,
> > e.g:'stop_event=threading.Event()'.
>
> John Sirois wrote:
> I'm leery of that for mutable objects like an Event. Surprising things
> happen if/when the containing object gets constructed a 2nd time and the
> single defau
> On Jan. 4, 2016, 8:05 p.m., John Sirois wrote:
> > Another answer could be to delete this test altogether. It looks like it
> > only really tests the proper converson from Time Amounts to fractional
> > second waits.
>
> Bill Farner wrote:
> I'm
ectly into the arg list,
> > e.g:'stop_event=threading.Event()'.
>
> John Sirois wrote:
> I'm leery of that for mutable objects like an Event. Surprising things
> happen if/when the containing object gets constructed a 2nd time and the
> single default Ev
ectly into the arg list,
> > e.g:'stop_event=threading.Event()'.
>
> John Sirois wrote:
> I'm leery of that for mutable objects like an Event. Surprising things
> happen if/when the containing object gets constructed a 2nd time and the
> single default Ev
> On Jan. 4, 2016, 8:05 p.m., John Sirois wrote:
> > Another answer could be to delete this test altogether. It looks like it
> > only really tests the proper converson from Time Amounts to fractional
> > second waits.
>
> Bill Farner wrote:
> I'm
://reviews.apache.org/r/41915/diff/
Testing
---
Before this change I got a failure between 1/5 and 1/10th of the
time via:
```
while true
do
./pants test src/test/python/apache/thermos/observer/ -- -kTaskObserverTest
done
```
After the change I cannot trigger the failure.
Thanks,
John
ectly into the arg list,
> > e.g:'stop_event=threading.Event()'.
>
> John Sirois wrote:
> I'm leery of that for mutable objects like an Event. Surprising things
> happen if/when the containing object gets constructed a 2nd time and the
> single default Ev
---
Locally green: `./build-support/jenkins/build.sh`.
That said - I could not reproduce the CI 120 minute timeouts as seen
here:
https://builds.apache.org/job/Aurora/1312/
https://builds.apache.org/job/Aurora/1313/
Thanks,
John Sirois
301 - 400 of 771 matches
Mail list logo
