Review Request 64508: Convert carriage returns to newlines in reviews

://reviews.apache.org/r/64508/diff/1/ Testing --- ./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu Thanks, Stephan Erb

Re: Review Request 64508: Convert carriage returns to newlines in reviews

. - Stephan Erb On Dec. 11, 2017, 9:47 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 64508: Convert carriage returns to newlines in reviews

t: https://reviews.apache.org/r/64508/#review193477 ----------- On Dec. 12, 2017, 10:05 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e

Re: Review Request 64508: Convert carriage returns to newlines in reviews

quot;\r" "\n" | tee build_outpu Thanks, Stephan Erb

Re: Review Request 64508: Convert carriage returns to newlines in reviews

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/#review193522 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 10:05 a.m

Review Request 64534: Reproduce Kerberos Python Build Issues

0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 Diff: https://reviews.apache.org/r/64534/diff/1/ Testing --- Thanks, Stephan Erb

Re: Review Request 64534: Reproduce Kerberos Python Build Issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64534/#review193527 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 12:38 p.m

Re: Review Request 64508: Convert carriage returns to newlines in reviews

for being sloppy here. I have pushed https://github.com/apache/aurora/commit/301f066369a9ef7262c1702c77004d12bc8eac00 unbreak the build. - Stephan Erb On Dec. 12, 2017, 10:05 a.m., Stephan Erb wrote: > > --- > This is an auto

Re: Review Request 64534: Reproduce Kerberos Python Build Issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64534/#review193530 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 12:38 p.m

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

()` to say > why it differs, but it does pass consistently for me. Jordan, will you update your PR? Or do you plan to file one, Bill? - Stephan ------- This is an automatically generated e-mail. To reply, visit: https://review

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64523/#review193590 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 3:29 a.m

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

- On Dec. 12, 2017, 8:15 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64523/ > --- > > (Updated Dec. 12, 2017, 8:15

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64523/#review193607 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 8:15 p.m

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

iew containing > > "@ReviewBot retry" > > Jordan Ly wrote: > I've never seen this fail before :( This is just not our week :) - Stephan ----------- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 64288: Add a SQL persistence implementation

a DBMS: How many entries would you expect in this table? (From a quick uninformed back-of-the-envelope calculation I would expect roughtly 5 million entries for a Twitter style cluster, which would be pretty reasonable) - Stephan Erb On Dec. 7, 2017, 7:27 p.m., Bill

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64523/#review193616 --- Ship it! Ship It! - Stephan Erb On Dec. 12, 2017, 8:15 p.m

Re: Review Request 64290: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193617 --- @ReviewBot retry - Stephan Erb On Dec. 9, 2017, 5:32 p.m

Re: Review Request 64341: Add metadata field to Job object in DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review193618 --- @ReviewBot retry - Stephan Erb On Dec. 11, 2017, 12:13 p.m

Re: Review Request 64290: Update to Thrift 0.10.0

Dec. 9, 2017, 5:32 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 5:32 p.m.) > > > R

Re: Review Request 64286: Recover snapshots via the Op stream

that still passes the tests, I tried to focus on the bigger picture. This looks OK to me. - Stephan Erb On Dec. 12, 2017, 6:46 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 64341: Add metadata field to Job object in DSL

. Feel free to ship without me though. - Stephan Erb On Dec. 11, 2017, 12:13 p.m., Jing Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 64519: Add a test to detect incompatible storage changes

. Feel free to ship without me though. - Stephan Erb On Dec. 12, 2017, 2:35 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 64824: Packaging workaround for empty strings parsed as non-empty lists

specs/debian/aurora-scheduler.upstart 3c3206887070f72061095b342bfbf8b535c82cff Diff: https://reviews.apache.org/r/64824/diff/1/ Testing --- Thanks, Stephan Erb

Re: Review Request 64824: Packaging workaround for empty strings parsed as non-empty lists

3f97a73249cd6601465be8a0031067715290cb9c specs/debian/aurora-scheduler.upstart 3c3206887070f72061095b342bfbf8b535c82cff Diff: https://reviews.apache.org/r/64824/diff/1/ Testing --- Thanks, Stephan Erb

Review Request 64825: Update packaging to latest Thrift, Mesos, and virtualenv

: https://reviews.apache.org/r/64825/diff/1/ Testing --- ./build-artifact.sh builder/rpm/centos-7/ snapshot.tar.gz 0.20.0-snapshot ./test/test-artifact.sh test/rpm/centos-7 /repo/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/x86_64 Thanks, Stephan Erb

Re: Review Request 65068: update discovery info documentation, when using mesos-dns

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65068/#review195135 --- Ship it! Ship It! - Stephan Erb On Jan. 10, 2018, 11:44 a.m

Re: Review Request 64824: Packaging workaround for empty strings parsed as non-empty lists

-mail. To reply, visit: https://reviews.apache.org/r/64824/#review194522 ----------- On Dec. 23, 2017, 3:45 p.m., Stephan Erb wrote: > > --- > This is an auto

Re: Review Request 64825: Update packaging to latest Thrift, Mesos, and virtualenv

257#file1927257line41> > > > > Also here. done - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64825/#review194721 ----------- On Dec. 23, 2017, 3:48 p.m., Stephan Erb

Re: Review Request 64825: Update packaging to latest Thrift, Mesos, and virtualenv

-snapshot ./test/test-artifact.sh test/rpm/centos-7 /repo/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/x86_64 Thanks, Stephan Erb

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

g/r/65233/#comment275185> Should be moved to the `Deprecation and removals` section below. - Stephan Erb On Jan. 19, 2018, 7:57 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

> On Jan. 19, 2018, 8:27 p.m., Stephan Erb wrote: > > The patch itself looks fine! However, I have difficulties assesing it > > properly as I am missing a bit of context. What is the main customization > > that you aim to implement using the new interface? > > &g

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

> On Jan. 19, 2018, 8:27 p.m., Stephan Erb wrote: > > The patch itself looks fine! However, I have difficulties assesing it > > properly as I am missing a bit of context. What is the main customization > > that you aim to implement using the new interface? > > &g

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65233/#review195874 --- Ship it! Ship It! - Stephan Erb On Jan. 20, 2018, 2:31 a.m

Re: Review Request 64288: Add a SQL persistence implementation

> On Dec. 12, 2017, 11:15 p.m., Stephan Erb wrote: > > The code looks fine and reasonable to me. I would still recommend proper > > scale testing though. > > > > At my company, we operate at a small scale and the Mesos replicated log > > works still wel

Re: Review Request 65281: Support PARTITIONED state in SLA calculations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65281/#review196010 --- Ship it! Ship It! - Stephan Erb On Jan. 23, 2018, 7:02 a.m

Re: Review Request 65281: Support PARTITIONED state in SLA calculations

> On Jan. 23, 2018, 7:11 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java > > Lines 319 (patched) > > > > > > Shouldn't `RUNNING` -> `PARTITIONED` be `DOWN`?

Re: Review Request 65303: Improve performance of MemTaskStore queries

/MemTaskStore.java Line 234 (original), 235 (patched) <https://reviews.apache.org/r/65303/#comment275620> Have you considered passing in the predicate filter in here? For index scans this should help to eliminate a large amount of allocations. - Stephan Erb On Jan. 24, 2018, 1:32 a.m., Bill

Re: Review Request 65338: Fix error handling logic for launch failures

where launching would fail, but we would still like the task to live on. - Stephan Erb On Jan. 25, 2018, 9:43 a.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 65433: Update Javascript Thrift to 0.10

111518739a7d353433ad59b7e48c84c2dbb546db Diff: https://reviews.apache.org/r/65433/diff/1/ Testing --- Manually verified that the UI is still working Thanks, Stephan Erb

Review Request 65434: Ensure primary_port warning respects announcer portmap

/client/config.py adc8db0290d80a0ebfed983f6518d063f355d81f src/test/python/apache/aurora/client/test_config.py 3d5289adcb2d53506644604380797ff64227fecd Diff: https://reviews.apache.org/r/65434/diff/1/ Testing --- ./build-support/jenkins/build.sh Thanks, Stephan Erb

Re: Review Request 65434: Ensure primary_port warning respects announcer portmap

(original), 49-50 (patched) <https://reviews.apache.org/r/65434/#comment276262> Note to reviewers: `config.raw().has_announce()` is already checked above so I could simplify the condition here. This is just a refactoring and independent of the behaviour change of this patch. - Stephan Er

Re: Review Request 65434: Ensure primary_port warning respects announcer portmap

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65434/#review196563 --- @ReviewBot retry - Stephan Erb On Jan. 31, 2018, 11:57 a.m

Re: Review Request 65303: Improve performance of MemTaskStore queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65303/#review196583 --- Ship it! Ship It! - Stephan Erb On Jan. 31, 2018, 7:12

Re: Review Request 65477: Fix UI table layout issue on Config Summaries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65477/#review196698 --- Ship it! Ship It! - Stephan Erb On Feb. 2, 2018, 8:52 a.m

Re: Review Request 65476: Add PartitionPolicy to config summary when defined

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65476/#review196699 --- Ship it! Ship It! - Stephan Erb On Feb. 2, 2018, 8:46 a.m

Re: Review Request 65477: Fix UI table layout issue on Config Summaries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65477/#review196701 --- @ReviewBot retry - Stephan Erb On Feb. 2, 2018, 8:52 a.m

Re: Review Request 65476: Add PartitionPolicy to config summary when defined

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65476/#review196700 --- @ReviewBot retry - Stephan Erb On Feb. 2, 2018, 8:46 a.m

Re: Review Request 65565: Vagrant image upgrade to Ubuntu Xenial

ssions for the upload, correct? - Stephan Erb On Feb. 8, 2018, 7:37 a.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

--- repeated git clean -xfd && ./build-support/jenkins/build.sh Thanks, Stephan Erb

Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

#x27;t read the files anywhere, not even on Jenkins. - Stephan Erb On Feb. 11, 2018, 11:44 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 65649: Adding support for a Thrift JSON request which defines UTF-8 as the charset for the Content-Type in the Request Headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65649/#review197520 --- Ship it! Ship It! - Stephan Erb On Feb. 14, 2018, 6:05 a.m

Re: Review Request 65650: Add GPG key for jorda...@apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65650/#review197546 --- Ship it! Ship It! - Stephan Erb On Feb. 14, 2018, 9:36 a.m

Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

t read the files anywhere, not even on Jenkins. - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65598/#review197571 ------------

Re: Review Request 65873: Upgrade RBT to 0.7.11

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65873/#review198508 --- Ship it! Ship It! - Stephan Erb On März 2, 2018, 1:14 vorm

Re: Review Request 65941: Avoid scheduling on the same host the ancestor of a task recently failed on

te: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65941/ > --- > > (Updated March 7, 2018, 6:50 a.m.) &g

Re: Review Request 63685: RFC: Use new scheduler UI as landing page

osing. - Stephan Erb On Nov. 8, 2017, 11:32 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder

the preferred backup way now, we have to update https://github.com/apache/aurora/blob/master/docs/operations/backup-restore.md. - Stephan Erb On Feb. 23, 2018, 7:04 p.m., Jordan Ly wrote: > > --- > This is an automatically ge

Re: Review Request 66074: Refactor ClusterState to more appropriate package, move binding to StateModule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66074/#review199334 --- Ship it! Ship It! - Stephan Erb On March 14, 2018, 11:07

Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder

> On March 16, 2018, 7:02 p.m., Stephan Erb wrote: > > Is this RecoveryTool just a prototype or used for real? If it is the > > preferred backup way now, we have to update > > https://github.com/apache/aurora/blob/master/docs/operations/backup-restore.md. > > Jor

Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65769/#review199394 --- Ship it! Ship It! - Stephan Erb On Feb. 23, 2018, 7:04 p.m

Review Request 66136: Switch Thermos to lazy log formatting

fa4f0fb7452bf8b85f9f3fa27283f54d7c0fe4f2 Diff: https://reviews.apache.org/r/66136/diff/1/ Testing --- Manually verified that the observer debug logs still contain useful output. Thanks, Stephan Erb

Review Request 66139: Speedup regular Thermos observer checkpoint refresh

The regular 2-3 second freezes when navigating the Thermos UI are now almost gone for me. Thanks, Stephan Erb

Re: Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199421 --- @ReviewBot retry - Stephan Erb On March 19, 2018, 3:55 p.m

Re: Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199485 --- @ReviewBot retry - Stephan Erb On March 19, 2018, 3:55 p.m

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199490 --- @ReviewBot retry - Stephan Erb On March 19, 2018, 5:24 p.m

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199564 ------- On March 20, 2018, 12:22 a.m., Stephan Erb wrote: > > -

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

] TaskObserver: finished checkpoint refresh in 0.48s D0320 22:18:59.031919 16250 task_observer.py:142] TaskObserver: finished checkpoint refresh in 0.49s D0320 22:19:04.512358 16250 task_observer.py:142] TaskObserver: finished checkpoint refresh in 0.48s Thanks, Stephan Erb

Review Request 66186: Upgrade to psutil with optimized Process.children()

double check this on a real running observer Thanks, Stephan Erb

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

/test_process_collector_psutil.py Line 22 (original), 22 (patched) <https://reviews.apache.org/r/66186/#comment279928> `process_iter` used to be an implementation detail of `Process.children()` but got removed in https://github.com/giampaolo/psutil/pull/1185/files - Stephan Erb On March 21, 2018, 12:

Re: Review Request 66199: Remove unused LOST_LOCK_MESSAGE variable in JobUpdateControllerImpl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66199/#review199771 --- Ship it! Ship It! - Stephan Erb On March 21, 2018, 10:38

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66190/#review199774 --- Ship it! Ship It! - Stephan Erb On March 21, 2018, 9:23 p.m

Re: Review Request 66103: Introduce mesos disk collector

to ensure pants pulls in the correct versions. - Stephan Erb On March 22, 2018, 10:52 p.m., Reza Motamedi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 66103: Introduce mesos disk collector

> On March 22, 2018, 11:31 p.m., Stephan Erb wrote: > > src/test/python/apache/thermos/monitoring/BUILD > > Lines 21 (patched) > > <https://reviews.apache.org/r/66103/diff/7/?file=1985807#file1985807line21> > > > > Requests has a few dependencies

Re: Review Request 66192: [WIP] Variable group size updates

lValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66192/ > ----------- > > (Updated March 21, 2018, 3:10

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199934 --- Ship it! Ship It! - Stephan Erb On March 23, 2018, 6:39 p.m

Re: Review Request 66269: End to end tests misc. fixes

! - Stephan Erb On March 26, 2018, 4:59 a.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66186/#review200265 --- @ReviewBot retry - Stephan Erb On March 21, 2018, 12:15 a.m

Re: Review Request 66482: Fixing issue where OpenJDK PPA would not install in Ubuntu Trusty in packaging tests.

-of-live is near https://www.ubuntu.com/info/release-end-of-life, so we could ask on the mailinglist who is using it and stop building packages for it after 0.20. - Stephan Erb On April 6, 2018, 1:58 a.m., Renan DelValle wrote

Re: Review Request 66491: Chaning default reviewers as well as reflecting the new address of gorealis.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66491/#review200700 --- Ship it! Ship It! - Stephan Erb On April 7, 2018, 2:18 vorm

Re: Review Request 66502: Update python virtualenv

specified here: https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17. Do you think you can bump that one as well? - Stephan Erb On April 9, 2018, 11:10 a.m., se choi wrote: > > --- > This is an automatically ge

Re: Review Request 66536: Add more preemption metrics (jobs preempted, preemptors) and logging statements

/aurora/scheduler/preemptor/Preemptor.java Line 86 (original), 88 (patched) <https://reviews.apache.org/r/66536/#comment281825> Witht the removal of the iterator this is a bit outdated. - Stephan Erb On April 11, 2018, 12:47 a.m., Jordan Ly

Re: Review Request 66502: Update python virtualenv

> On April 10, 2018, 11:37 a.m., Stephan Erb wrote: > > Thanks for the patch! We also have another virtulenv version specified > > here: > > https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17. > > Do you think you can bump that one

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

/ Testing (updated) --- Successfully verified in vagrant that CPU and memory are reported as expected. Thanks, Stephan Erb

Re: Review Request 66573: Add initial interval before searching for preemption slots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66573/#review200974 --- Ship it! Ship It! - Stephan Erb On April 12, 2018, 3:05 a.m

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

-mail. To reply, visit: https://reviews.apache.org/r/66186/#review200944 --- On April 12, 2018, 12:13 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

We can then simply enable the feature toggle by default after next release. @Jordan Ly, would this address your backwards incompatibility concerns? - Stephan Erb On May 15, 2018, 11:15 p.m., Santhosh Kumar Shanmugham wrote: > > --

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

ater. src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java Lines 384 (patched) <https://reviews.apache.org/r/66716/#comment285387> isProduction is deprecated. You will need to check the appropriate tier config here. - Stephan Erb On May 15, 20

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

> On May 16, 2018, 10:22 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java > > Lines 257-258 (patched) > > <https://reviews.apache.org/r/67141/diff/1/?file=2023580#file2023580line257> > > > > If

Re: Review Request 66192: [WIP] Variable group size updates

<https://reviews.apache.org/r/66192/#comment285402> With the current backfill mechanism, this will break for tasks read from storage. - Stephan Erb On May 15, 2018, 4:19 a.m., Renan DelValle wrote: > > --- > This is an automatically

Re: Review Request 66192: [WIP] Variable group size updates

> > Renan DelValle wrote: > Definitely, just wanted to get the latest version out to get feedback on > the Thrift Schema changes. This will indeed be configurable via pystachio, > just wanted to settle on the Thrift Schema before making those changes. > > San

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203528 --- Ship it! Ship It! - Stephan Erb On May 17, 2018, 4:07 a.m

Re: Review Request 67077: Remove resource properties from ResourceAggregate

`). I am happy about the refactoring overall. It is therefore fine with me to let this one slide. - Stephan Erb On May 11, 2018, 5:18 a.m., Jing Chen wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Review Request 67326: Update Pants to 1.6.0 and Virtualenv to 16.2.0

/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0 Diff: https://reviews.apache.org/r/67326/diff/1/ Testing --- ./build-support/jenkins/build.sh Thanks, Stephan Erb

Re: Review Request 66502: Update python virtualenv

filed https://reviews.apache.org/r/67326/ as a replacement and will close this patch now. Sorry for letting this one go stale. - Stephan Erb On April 9, 2018, 11:10 a.m., se choi wrote: > > --- > This is an automatically generat

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

g? src/main/python/apache/aurora/admin/host_maintenance.py Line 173 (original), 173 (patched) <https://reviews.apache.org/r/66716/#comment286244> Should we already call out the old maintenance mechanism as deprecated in the RELEASE-NOTES? - Stepha

Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to 16.2.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67326/#review204633 --- Friendly ping :) - Stephan Erb On May 25, 2018, 4:58 p.m

Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to 16.0.0

Thanks, Stephan Erb

Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to 16.0.0

good catch, thanks! - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67326/#review204723 --- On June 13, 2018, 9:41 p.m., Stephan Erb wrote: > > -

Review Request 67584: Update to Mesos 1.5

/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0 (new vagrant box) Running as we speak: * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0 (old vagrant box) Thanks, Stephan Erb

Re: Review Request 67584: Update to Mesos 1.5

-support/jenkins/build.sh` * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0 (new vagrant box) * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0 (old vagrant box) Thanks, Stephan Erb

<    5   6   7   8   9   10   11   >