Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26956/#review57540 --- Ship it! Ship It! - Joshua Cohen On Oct. 21, 2014, 12:42 a.m., D

Re: Review Request 26962: Script to build mesos.native egg in clean vagrant environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26962/#review57520 --- Ship it! Ship It! - Bill Farner On Oct. 21, 2014, 1:20 a.m., Kev

Re: Review Request 26899: Require StateManager callers to open their own transactions.

> On Oct. 21, 2014, 12:30 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 215 > > > > > > Mind renaming store to storeProvider? > > Bill Farner wrote: >

Re: Review Request 26899: Require StateManager callers to open their own transactions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/#review57512 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/Schedule

Review Request 26962: Script to build mesos.native egg in clean vagrant environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26962/ --- Review request for Aurora. Repository: aurora Description --- Our integr

Re: Review Request 26962: Script to build mesos.native egg in clean vagrant environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26962/ --- (Updated Oct. 20, 2014, 6:20 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 26899: Require StateManager callers to open their own transactions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/ --- (Updated Oct. 21, 2014, 1:09 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 26899: Require StateManager callers to open their own transactions.

> On Oct. 21, 2014, 12:30 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 215 > > > > > > Mind renaming store to storeProvider? I don't see any potential ris

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26956/#review57502 --- Ship it! Ship It! - Kevin Sweeney On Oct. 20, 2014, 5:42 p.m., D

Re: Review Request 26961: Fix checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26961/#review57500 --- Ship it! Ship It! - Bill Farner On Oct. 21, 2014, 12:52 a.m., Ke

Review Request 26961: Fix checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26961/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26956/ --- (Updated Oct. 21, 2014, 12:42 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26956/ --- (Updated Oct. 21, 2014, 12:40 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 4:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "what

Re: Review Request 26899: Require StateManager callers to open their own transactions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/#review57487 --- src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 4:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "what

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26851: Adding storage recovery from backup doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26851/ --- (Updated Oct. 20, 2014, 11:58 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26851: Adding storage recovery from backup doc.

> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote: > > docs/storage-config.md, line 22 > > > > > > s/is summarizing/summarizes/ Done. > On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote: > > docs/storage-config.md, line

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state than the time (I'm envisioning questions like > > "wha

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26956/#review57459 --- It's not entirely clear from the screenshot that "LOCAL" is a refere

Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26956/ --- Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-873

Re: Review Request 26852: Use mesos.native egg from svn.apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/#review57456 --- Submitting this as-is to unbreak the build. jfarrell, happy to addre

Re: Review Request 26531: Defining schema for the heartbeat RPC.

On Mon, Oct 20, 2014 at 1:00 PM, Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26531/#review57415 > --- > > >

Re: Review Request 26852: Use mesos.native egg from svn.apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/ --- (Updated Oct. 20, 2014, 1:13 p.m.) Review request for Aurora, Joe Smith, Bill F

Re: Review Request 26852: Use mesos.native egg from svn.apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/ --- (Updated Oct. 20, 2014, 1:13 p.m.) Review request for Aurora, Joe Smith, Bill F

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review57418 --- Ship it! Ship It! - David McLaughlin On Oct. 8, 2014, 11:56 p.m.

Review Request 26954: Deprecating Identity thrift struct (python).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-84 h

Re: Review Request 26531: Defining schema for the heartbeat RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review57415 --- I know I brought this up in the design discussion, so maybe this is

Re: Review Request 26881: Improve error messages in client commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/#review57416 --- Ship it! Ship It! - Joshua Cohen On Oct. 20, 2014, 7:36 p.m., Ma

Re: Review Request 26881: Improve error messages in client commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/#review57413 --- Ship it! Ship It! - Bill Farner On Oct. 20, 2014, 7:36 p.m., Mar

Re: Review Request 26881: Improve error messages in client commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/ --- (Updated Oct. 20, 2014, 3:36 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 26531: Defining schema for the heartbeat RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review57410 --- Paused at the RPC name, since the rest of the change is mechanical,

Re: Review Request 26832: Document common problems and solutions when creating a new cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26832/#review57411 --- Ship it! Ship It! - Kevin Sweeney On Oct. 20, 2014, 12:28 p.m.,

Re: Review Request 26832: Document common problems and solutions when creating a new cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26832/ --- (Updated Oct. 20, 2014, 7:28 p.m.) Review request for Aurora, Jay Buffington an

Re: Review Request 26832: Document common problems and solutions when creating a new cluster.

> On Oct. 20, 2014, 6:55 p.m., Kevin Sweeney wrote: > > docs/deploying-aurora-scheduler.md, line 29 > > > > > > While you're here - mind fixing this up. "The Aurora scheduler is", and > > "0.20.0" Done. > On Oct. 20

Re: Review Request 26881: Improve error messages in client commands.

> On Oct. 20, 2014, 1:17 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/cli/cron.py, line 48 > > > > > > I don't think the "reported by server" part is a useful detail, > > consider dropping. Ditto

Re: Review Request 26832: Document common problems and solutions when creating a new cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26832/#review57398 --- docs/deploying-aurora-scheduler.md

Re: Review Request 26881: Improve error messages in client commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/#review57399 --- Ship it! Ship It! - Zameer Manji On Oct. 17, 2014, 10:58 a.m., M

Re: Review Request 26899: Require StateManager callers to open their own transactions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/#review57397 --- Ship it! Ship It! - Kevin Sweeney On Oct. 17, 2014, 4:01 p.m., B

Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

> On Oct. 20, 2014, 6:36 p.m., Bill Farner wrote: > > Ship It! Thanks! This is now on master. $ git log -1 origin/master --abbrev-commit commit c6d0d78 Author: Joshua Cohen Date: Mon Oct 20 11:37:07 2014 -0700 Add a message when coverage exceeds minimum.

Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26902/#review57387 --- Ship it! Ship It! - Bill Farner On Oct. 20, 2014, 5:54 p.m., Jos

Re: Review Request 26851: Adding storage recovery from backup doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26851/#review57364 --- docs/storage-config.md

Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26902/ --- (Updated Oct. 20, 2014, 5:54 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 26851: Adding storage recovery from backup doc.

> On Oct. 17, 2014, 5:07 p.m., Bill Farner wrote: > > docs/storage_recovery.md, line 43 > > > > > > Avoid falling back to HTML if you can. In this case, triple backticks > > will do the same thing. > > Maxim Khutorne

Re: Review Request 26881: Improve error messages in client commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/#review57361 --- Ship it! src/main/python/apache/aurora/client/cli/cron.py

Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

> On Oct. 18, 2014, 12:50 a.m., Bill Farner wrote: > > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy, line > > 46 > > > > > > Should we be strict here and fail? > > Joshua Cohen wrote: > Yo

Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

> On Oct. 18, 2014, 12:50 a.m., Bill Farner wrote: > > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy, line > > 46 > > > > > > Should we be strict here and fail? You mean require the bar be rais