://reviews.apache.org/r/22998/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
/SnapshotStoreImplTest.java
5763fd0cb5ef4871e60a7d46d5e14e93e417c689
Diff: https://reviews.apache.org/r/22999/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22982/#review46758
---
On June 25, 2014, 7:59 p.m., Bill Farner wrote
. To reply, visit:
https://reviews.apache.org/r/22982/#review46770
---
On June 25, 2014, 7:59 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19796/#review46789
---
Ship it!
Ship It!
- Bill Farner
On June 26, 2014, 3:23 a.m
://reviews.apache.org/r/22982/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
/23087/diff/
Testing
---
$ git clean -fdx
$ ./gradlew clean build -Pq
Thanks,
Bill Farner
find/sed.
Fix coming up.
- Bill Farner
On June 26, 2014, 7:52 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22982
/scheduler/thrift/aop/ForwardingThrift.java
a746c48dd21a401b84ddcc610d7c99b4f35f8135
Diff: https://reviews.apache.org/r/22982/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
53e5749fe4f9ca573d5930a05f3952cb92dbd843
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
5763fd0cb5ef4871e60a7d46d5e14e93e417c689
Diff: https://reviews.apache.org/r/22999/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22948/#review46808
---
Ping - Kevin, Mark?
- Bill Farner
On June 25, 2014, 12:43 a.m
://reviews.apache.org/r/23107/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
://reviews.apache.org/r/23105/diff/
Testing
---
./gradlew run -Pq
Thanks,
Bill Farner
/#comment82453
Can you put a comment above, referencing AURORA-559 (just for some context).
- Bill Farner
On June 25, 2014, 8:18 p.m., Jake Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
. Thanks!
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java
https://reviews.apache.org/r/23180/#comment82626
Pull to previous line per preexisting style.
- Bill Farner
On June 30, 2014, 10:23 p.m., Joe Smith wrote
/scheduler/TaskVarsTest.java
2e128f49173a69bb09dee32e8dbac27e5d3b1021
Diff: https://reviews.apache.org/r/23189/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
limited to a
single job?
src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java
https://reviews.apache.org/r/23188/#comment82718
The Set-String change rears its head here - since you now need to match
the ordering to satisfy equals().
- Bill Farner
On July 1, 2014, 12
On July 1, 2014, 6:14 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 89
https://reviews.apache.org/r/23188/diff/1/?file=620711#file620711line89
I much prefer the previous signature. Why not push the Set-String
translation
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23191/#review47124
---
Ship it!
Ship It!
- Bill Farner
On July 1, 2014, 4:45 a.m
work, i'm going to chalk that up to a transient issue or brokenness with the
test itself.
Thanks,
Bill Farner
a746c48dd21a401b84ddcc610d7c99b4f35f8135
Diff: https://reviews.apache.org/r/22982/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23189/#review47072
---
On July 1, 2014, 1:53 a.m., Bill Farner wrote
ed63d5a9aeb2f5abac95997317c276b5045f9d0f
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java
2e128f49173a69bb09dee32e8dbac27e5d3b1021
Diff: https://reviews.apache.org/r/23189/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
On July 1, 2014, 8:51 p.m., Kevin Sweeney wrote:
Hi Kevin,
Can you please rebase this patch against master.
Thanks,
Kevin
Kevin Sweeney wrote:
(You can preview the diff that will be sent with ./rbt patch or by using
the draft feature.)
Sorry about that, i just snuck in
tearing down.
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review46929
---
On June 27, 2014, 5:42 a.m., Bill Farner wrote:
---
This is an automatically
?
Good call, done.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review46863
---
On June 27, 2014, 5:42 a.m., Bill Farner
22a40481b5b246989c2e17a72a0325649382dde1
Diff: https://reviews.apache.org/r/23107/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23105/#review46925
---
On June 27, 2014, 3:39 p.m., Bill Farner wrote:
---
This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23105/#review47077
---
On June 27, 2014, 3:39 p.m., Bill Farner wrote
/DbAttributeStoreTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23105/diff/
Testing
---
./gradlew run -Pq
Thanks,
Bill Farner
://reviews.apache.org/r/23238/diff/
Testing
---
vagrant up bash examples/vagrant/test_tutorial.sh
Observed that config bar is now present.
Thanks,
Bill Farner
to SchedulerThriftInterface, rather
than something that passes calls through to other components?
- Bill Farner
On July 2, 2014, 9:46 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On July 2, 2014, 10:01 p.m., Bill Farner wrote:
How would you feel about doing this more piecemeal? This is changing a lot
of important code, making it more likely that we'll miss something and
introduce bugs (this is made more likely since tests are changing a lot
too). Would
.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-94
https://issues.apache.org/jira/browse/AURORA-94
Repository: aurora
Description
---
Moving all SchedulerCore logic into SchedulerThriftInterface.
Unit tests in BaseSchedulerCoreImplTest.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23219/#review47260
---
Ping - Maxim?
- Bill Farner
On July 2, 2014, 12:47 a.m., Bill
/DbAttributeStoreTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23105/diff/
Testing
---
./gradlew run -Pq
Thanks,
Bill Farner
cc31187607e89a9daebe071a8a180d56d873e4c5
Diff: https://reviews.apache.org/r/20648/diff/
Testing
---
./gradlew build
sh examples/vagrant/test_tutorial.sh
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23105/#review47325
---
Kevin - ping?
- Bill Farner
On July 3, 2014, 2:27 a.m., Bill
/aurora/scheduler/storage/db/DbQuotaStoreTest.java
21151f5999452e6b90603ba3f3248d8f714f8dca
Diff: https://reviews.apache.org/r/23273/diff/
Testing
---
./gradlew build -Pq
Also attempted to repro as explained in AURORA-573, and i can no longer trigger
a SQL exception.
Thanks,
Bill Farner
On July 2, 2014, 11:11 p.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 414
https://reviews.apache.org/r/23188/diff/2/?file=623177#file623177line414
What's the motivation for including the job key? I would assume that
the caller either already
.
http://english.stackexchange.com/questions/19653/insecure-or-unsecure-when-dealing-with-security
Perhaps the appropriate change is 'UnsecuredAuthModule'
- Bill Farner
On July 7, 2014, 6:28 p.m., Brian Wickman wrote
resources at
well-known locations, which would be candidate for brittleness when there are
collisions. Jar signing is also broken by this approach. Unless there's a
compelling reason to introduce this trouble, i suggest we stay far, far away.
- Bill Farner
On July 17, 2014, 1:05 a.m., Kevin
/MemAttributeStoreTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23653/diff/
Testing
---
Reproduced the issue in vagrant, and subsequently in unit test.
./gradlew build -Pq
Thanks,
Bill Farner
-Pq
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review48074
---
Kevin - ping?
- Bill Farner
On July 2, 2014, 1:33 a.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23667/#review48082
---
Ship it!
Ship It!
- Bill Farner
On July 17, 2014, 10:49 p.m
src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java
ef8c08cf2d33fb119a271151dc34245c1c30d11f
Diff: https://reviews.apache.org/r/20648/diff/
Testing
---
./gradlew build
sh examples/vagrant/test_tutorial.sh
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23688/#review48145
---
Ship it!
Ship It!
- Bill Farner
On July 18, 2014, 4:58 p.m
9d500baf82914733c0f92752d9570da009870aa9
src/main/thrift/org/apache/aurora/gen/api.thrift
8ee43fa1f0e2e699b0f1a321e673e49221b528ad
Diff: https://reviews.apache.org/r/23741/diff/
Testing
---
Manual only, will post some snippets shortly.
Thanks,
Bill Farner
://reviews.apache.org/r/23718/#comment84596
I believe this file can be deleted, i don't know of any reason for empty
BUILD files to exist.
- Bill Farner
On July 20, 2014, 8:07 p.m., Jake Farrell wrote:
---
This is an automatically generated e
---
Ran jenkins locally, verified that jacoco output files are consumed and
coverage graph works.
Thanks,
Bill Farner
/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23254/#review48316
---
Ship it!
Ship It!
- Bill Farner
On July 21, 2014, 11:23 p.m
---
Thanks,
Bill Farner
/r/23741/ ?
- Bill Farner
On July 21, 2014, 10:58 p.m., Misho Krastev wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23666
/SchedulerThriftInterface.java
https://reviews.apache.org/r/23834/#comment85095
@Nullable
- Bill Farner
On July 23, 2014, 2:21 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/SnapshotStoreImplTest.java
22a40481b5b246989c2e17a72a0325649382dde1
Diff: https://reviews.apache.org/r/23107/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
vagrant up
bash examples/vagrant/test_tutorial.sh
Thanks,
Bill Farner
failing?
- Bill Farner
On July 23, 2014, 11:33 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23872
invocation method - it captures calls via __getattr__, and
then dynamically invokes them on a parameter list. There's no python object
or class to spec - just a class with __getattr__ wired up to thrift.
-Mark
On Wed, Jul 23, 2014 at 7:48 PM, Bill Farner wfar...@apache.org wrote:
Would
/
---
(Updated July 23, 2014, 8:51 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
---
This is an exemplar ServerSet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23931/#review48740
---
Ship it!
Ship It!
- Bill Farner
On July 25, 2014, 1:48 p.m
}
]
}
]
},
serverInfo: {
clusterName: example,
statsUrlPrefix: ,
thriftAPIVersion: 3
}
}
Thanks,
Bill Farner
://reviews.apache.org/r/23863/#comment85508
Better yet, just put a .py file in the repo and reference it from
/vagrant/...
- Bill Farner
On July 24, 2014, 10:32 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail
,
statsUrlPrefix: ,
thriftAPIVersion: 3
}
}
Thanks,
Bill Farner
://reviews.apache.org/r/23961/diff/
Testing
---
./gradlew clean build -Pq
Thanks,
Bill Farner
On July 22, 2014, 12:54 a.m., Bill Farner wrote:
Do you think this should be obviated by https://reviews.apache.org/r/23741/
?
Misho Krastev wrote:
This looks like elegant (declarative) solution to export REST variant of
the native thrift interface. I am not familiar
to veto the
latest patch.
- Bill Farner
On July 26, 2014, 6:16 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23741
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24017/#review48934
---
Ship it!
Ship It!
- Bill Farner
On July 28, 2014, 11:10 p.m
On July 28, 2014, 11:44 p.m., Bill Farner wrote:
Thanks for linking to the release notes. Some relevant changes i spotted:
It’s no longer necessary to pass -g (or --guess-fields) to rbt post in
order
to automatically fill in the Summary and Description fields. This is
now
Diff: https://reviews.apache.org/r/24042/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23471/#review48993
---
wickman, ping?
- Bill Farner
On July 22, 2014, 11:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review48994
---
Ship it!
Ship It!
- Bill Farner
On July 9, 2014, 7:50 p.m
/ServletModuleTest.java
90a001b38ce35fe4da666febde328c1af30f9663
Diff: https://reviews.apache.org/r/24059/diff/
Testing
---
./gradlew clean build -Pq
bash examples/vagrant/test_tutorial.sh
Manually clicked around in a local scheduler.
Thanks,
Bill Farner
On July 29, 2014, 6:52 p.m., David McLaughlin wrote:
This already has two ship its. Mark, do you mind removing yourself and
adding Bill?
FYI - i don't believe Mark will have RB permissions to edit the review. You
can feel free to do the swap and proceed with the commit.
- Bill
://reviews.apache.org/r/24059/#review49002
---
On July 29, 2014, 6:05 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review49015
---
Ship it!
Ship It!
- Bill Farner
On July 29, 2014, 7:14 p.m
/scheduler/http/ui/taskStatus.html
bdf15cf021e51fb646d725744f94a4589d7b0761
Diff: https://reviews.apache.org/r/24062/diff/
Testing
---
Manually verified
Thanks,
Bill Farner
/test_tutorial.sh
Manually clicked around in a local scheduler.
Thanks,
Bill Farner
---
On July 29, 2014, 9:44 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24059/
---
(Updated July 29, 2014, 9:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23329/#review49045
---
Reviewers - ping?
- Bill Farner
On July 9, 2014, 9:50 p.m
. If it's now
in, can you please close the review?
- Bill Farner
On July 17, 2014, 2:09 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457
/InstanceUpdaterTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/24078/diff/
Testing
---
./gradlew build -Pq, 100% instruction and branch test coverage.
Thanks,
Bill Farner
/
---
(Updated July 29, 2014, 7:14 p.m.)
Review request for Aurora, Jake Farrell and Bill Farner.
Bugs: AURORA-620
https://issues.apache.org/jira/browse/AURORA-620
Repository: aurora
Description
---
Use JCenter over HTTPS instead
/
---
(Updated July 9, 2014, 7:50 p.m.)
Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-579
https://issues.apache.org/jira/browse/AURORA-579
Repository: aurora
Description
---
Upgrading Mesos version from
parameters for this:
Response getUpdates(1: string role, 2: JobKey job, 3: UpdateStatus status)
- Bill Farner
On July 30, 2014, 9:12 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit
add two more test cases with batch_size 1:
- instances % batch_size == 0
- instances % batch_size != 0
- Bill Farner
On July 30, 2014, 11:59 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail
On July 31, 2014, 12:19 a.m., Bill Farner wrote:
src/test/python/apache/aurora/client/api/test_updater.py, line 821
https://reviews.apache.org/r/24126/diff/1/?file=646405#file646405line821
Can you add two more test cases with batch_size 1:
- instances % batch_size
On July 31, 2014, 11:13 p.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 546
https://reviews.apache.org/r/24116/diff/3/?file=647049#file647049line546
I find the latest revision of the structs a bit tough to comprehend.
How about this tweak
-CREATION
src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/24078/diff/
Testing
---
./gradlew build -Pq, 100% instruction and branch test coverage.
Thanks,
Bill Farner
, visit:
https://reviews.apache.org/r/24078/#review49259
---
On July 30, 2014, 1:06 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On July 31, 2014, 11:13 p.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 546
https://reviews.apache.org/r/24116/diff/3/?file=647049#file647049line546
I find the latest revision of the structs a bit tough to comprehend.
How about this tweak
://reviews.apache.org/r/22944/
---
(Updated July 29, 2014, 7:20 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-551
https://issues.apache.org/jira/browse/AURORA-551
Repository: aurora
Description
generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/
---
(Updated Aug. 1, 2014, 9:40 p.m.)
Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-611
https
On Aug. 1, 2014, 10:02 p.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 541
https://reviews.apache.org/r/24116/diff/5/?file=648844#file648844line541
I wonder if we should use this opportunity to choose a name that does
not imply batching
, 2014, 10:53 p.m.)
Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-611
https://issues.apache.org/jira/browse/AURORA-611
Repository: aurora
Description
---
First stab at update APIs.
Diffs
-
src/main/java/org
---
Thanks,
Bill Farner
/aurora/client/api/test_scheduler_client.py
dd16fe2afe681f81e27f1eeddd5127b322934d74
Diff: https://reviews.apache.org/r/24241/diff/
Testing
---
./pants src/test/python:all -vxs
Thanks,
Bill Farner
to
confusing double-negatives. Consider s/do_not_//
- Bill Farner
On Aug. 4, 2014, 6:02 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24243
301 - 400 of 1375 matches
Mail list logo
