oning.
To me, it seems like expecting someone to have a lockid for a pause or a resume
call is a good idea. It allows someone to pass responsibility for an ongoing
update to another person, without having to allow anyone at all to
interrupt/resume it.
- Mark Chu-Carroll
On Aug. 18, 2014, 4:1
st_kill.py
ee64908855a4960f44ce96c810e69dd105d2ce5d
src/test/python/apache/aurora/client/cli/test_restart.py
14a08e873058374a9bfe4ffbff8ae7279123f264
Diff: https://reviews.apache.org/r/24852/diff/
Testing
---
Ran test suite.
Thanks,
Mark Chu-Carroll
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24852/#review50974
---
On Aug. 19, 2014, 11:22 a.m., Mark Chu-Carroll wrote:
>
> ---
? Diff shows it in green for some
> > reason...
>
> Mark Chu-Carroll wrote:
> No, this is a new test. It's almost identical to an existing test, except
> that instead of checking API calls, it's checking output.
>
> Maxim Khutornenko wrote:
> Please, drop the
,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24953/#review51218
---
On Aug. 21, 2014, 4:44 p.m., Mark Chu-Carroll wrote:
>
> ---
-
Ran test suite.
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51319
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Aug. 22, 2014, 5:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25159/#review51807
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Aug. 28, 2014, 2:16 p.m
/apache/aurora/client/cli/test_supdate.py PRE-CREATION
src/test/python/apache/aurora/client/cli/util.py
95a2123e127c9811fd2305e71cfc5c7c4376f904
Diff: https://reviews.apache.org/r/25255/diff/
Testing
---
New suite of tests for the new command; all unit tests pass.
Thanks,
Mark Chu
nds of methods should check the result code, raise an exception if
the API call failed, and then return a meaningful, simple result.
(Same comment applies to get_job_update_details)
- Mark Chu-Carroll
On Aug. 29, 2014, 6:28 p.m., Maxim Khutornenko wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52065
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Aug. 29, 2014, 7:17 p.m
aurora/e2e/test_end_to_end_v2.sh
14a0b62c1b06179211d79f35a9c6df162c9a5999
Diff: https://reviews.apache.org/r/25297/diff/
Testing
---
- Ran all unit tests successfully.
- Ran end-to-end tests successfully.
-
Thanks,
Mark Chu-Carroll
-end tests successfully.
-
Thanks,
Mark Chu-Carroll
unit tests successfully.
- Ran end-to-end tests successfully.
-
Thanks,
Mark Chu-Carroll
ault altogether)?
>
> I was saying switch the default so it's the new syntax
>
>
> - Joe
>
> On August 29th, 2014, 4:17 p.m. PDT, Joshua Cohen wrote:
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias
> Weingartner.
> By Joshua Cohen.
>
&g
client/cli/test_status.py
311fac02af32e0ed687489a2352164effb4dba96
Diff: https://reviews.apache.org/r/25309/diff/
Testing
---
Ran unit tests; added new test cases.
Thanks,
Mark Chu-Carroll
> On Sept. 2, 2014, 3:35 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/api/__init__.py, line 176
> > <https://reviews.apache.org/r/25204/diff/1/?file=672539#file672539line176>
> >
> > Nit - but why are you changing the parameter comm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25204/#review52214
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Aug. 29, 2014, 6:28 p.m
e
argument specifies the action that the user wants, which can be update, pause,
resume, or abort.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review52043
-
25309/diff/
Testing
---
Ran unit tests; added new test cases.
Thanks,
Mark Chu-Carroll
s://reviews.apache.org/r/25309/#review52308
-------
On Sept. 4, 2014, 9:24 a.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. T
timestamps, so that it doesn't matter
where the test is run.
Diffs
-
src/test/python/apache/aurora/client/cli/test_status.py
2af24fbaa4971819636898df752fa886553d75a3
Diff: https://reviews.apache.org/r/25350/diff/
Testing
---
Thanks,
Mark Chu-Carroll
/test/python/apache/aurora/client/cli/util.py
95a2123e127c9811fd2305e71cfc5c7c4376f904
Diff: https://reviews.apache.org/r/25450/diff/
Testing
---
Added new unit tests.
Thanks,
Mark Chu-Carroll
E-CREATION
Diff: https://reviews.apache.org/r/22457/diff/
Testing
---
New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests
of the new functionality.
All tests pass.
Thanks,
Mark Chu-Carroll
fixed
> > before piling up more test cases like this?
I'll look, and see if I can figure out where that's coming from.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
put already has success message(s):
> >
> > ...
> > log(info): Killed: 8
> > log(info): Instance 0 has been up and healthy for at least 45 seconds
> > log(info): Instance 1 has been up and healthy for at least 45 seconds
> > log(info): Update successful
>
5c7c4376f904
Diff: https://reviews.apache.org/r/25450/diff/
Testing
---
Added new unit tests.
Thanks,
Mark Chu-Carroll
38b5f6e306c2c8dd9aa8d98e21c6a628028ad899
src/test/python/apache/aurora/client/cli/test_status.py
721d9764190bdc4b1c5b65e416a039803b7c507c
Diff: https://reviews.apache.org/r/25505/diff/
Testing
---
Added new unit tests; all tests pass.
Thanks,
Mark Chu-Carroll
tps://reviews.apache.org/r/25505/#comment92095>
Yup, you're right.
- Mark Chu-Carroll
On Sept. 10, 2014, 11:56 a.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
pass.
Thanks,
Mark Chu-Carroll
rg/r/25505/diff/
Testing
---
Added new unit tests; all tests pass.
Thanks,
Mark Chu-Carroll
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review52220
---
On Sept. 2, 2014, 12:36 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically gene
to the
comments never got sent - guessing chrome timed out, and I didn't notice.
Please don't re-review this yet - I'm reworking some of the code; I'll send an
update when it's ready.
- Mark Chu-Carroll
On Sept. 2, 2014, 12:36 p.m
iff: https://reviews.apache.org/r/25255/diff/
Testing
---
New suite of tests for the new command; all unit tests pass.
Thanks,
Mark Chu-Carroll
befa50
Diff: https://reviews.apache.org/r/25543/diff/
Testing
---
- Ran all unit tests: several fail, but they also fail under the previous
version of pants.
- Built all python_binary targets in src/main/python/apache/aurora.
- Verified that resulting pexes executed correctly.
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review53071
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Sept. 10, 2014, 6:43
e
Diff: https://reviews.apache.org/r/25582/diff/
Testing
---
Added new tests to catch this case;
Ran all client unit tests, all tests pass.
Thanks,
Mark Chu-Carroll
n/apache/aurora/client/commands/test_ssh.py
4070b710b005c91fe08dd7906cd93bf3a8cdba9e
Diff: https://reviews.apache.org/r/25582/diff/
Testing
---
Added new tests to catch this case;
Ran all client unit tests, all tests pass.
Thanks,
Mark Chu-Carroll
reviews.apache.org/r/25543/#review53239
---
On Sept. 11, 2014, 12:13 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review53330
---
ping? THis is ready for another look.
- Mark Chu-Carroll
On Sept
is *not* acceptable in a production
tool.
One fringe benefit of this approach is that it's really easy to leave it out of
the production executable until it's ready to go.
-Mark
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2525
hink "i want
> to update my job", not "i want to start an update". So if the goal of
> organizing commands by nouns is to make it intuitive, i think "update
> start" is less natural than "job update".
>
> -=Bill
>
> On M
message, and it's easy to remember.
On Mon, Sep 15, 2014 at 5:16 PM, Maxim Khutornenko wrote:
> I guess there is also the option you originally proposed: "aurora job
> update --start|--pause|--resume|--abort".
>
> If you don't like the option syntax, would it be
Chu-Carroll
command; all unit tests pass.
Thanks,
Mark Chu-Carroll
/options.py
36f80aa175beaf8f2dc6b6f962394643313d6405
src/main/python/apache/aurora/client/cli/task.py
5b5710ae9005664e17be1053c63b282364ae0300
Diff: https://reviews.apache.org/r/25918/diff/
Testing
---
All unit tests pass.
Thanks,
Mark Chu-Carroll
a/client/cli/util.py
a50b83c571390374975accf75e31f392dbdaaa04
Diff: https://reviews.apache.org/r/26004/diff/
Testing
---
Added new unit tests; all tests pass.
Thanks,
Mark Chu-Carroll
759428
Diff: https://reviews.apache.org/r/26014/diff/
Testing
---
Quick fix: no additional test. I'll add a regression test when rosh hashanah is
over.
Thanks,
Mark Chu-Carroll
normal parameter to status is a good design for the
command-line.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26004/#review54466
-----------
On Sept. 24, 2014, 4:24 p.m., Mark Chu-Carroll wrote
---
manual testing.
Thanks,
Mark Chu-Carroll
ng? Something which is consistent with the job verbs would be great.
>
> Mark Chu-Carroll wrote:
> I was following the pattern that I saw in the API implementation. In
> early iterations, it exposed updated ids; in later ones, the IDs were removed
> from the user-level API. We
ng code is disabled, but pass with in on.
- added a new unit test to check that unresolved bindings generate an error.
Thanks,
Mark Chu-Carroll
iff: https://reviews.apache.org/r/26270/diff/
Testing
---
Unit tests:
- verified that tests fail if the binding code is disabled, but pass with in on.
- added a new unit test to check that unresolved bindings generate an error.
Thanks,
Mark Chu-Carroll
li/util.py
a50b83c571390374975accf75e31f392dbdaaa04
Diff: https://reviews.apache.org/r/26270/diff/
Testing
---
Unit tests:
- verified that tests fail if the binding code is disabled, but pass with in on.
- added a new unit test to check that unresolved bindings generate an error.
Thanks,
Mark Chu-Carroll
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26137/#review54953
-----------
On Sept. 29, 2014, 11:05 a.m., Mark Chu-Carroll wrote:
>
> --
ora/client/cli/test_supdate.py
2782fee2867c6ef79349240299de082f07f7967a
src/test/python/apache/aurora/client/cli/util.py
e1ee884c06f3bc22bcd9e908ff61af9459a0b535
Diff: https://reviews.apache.org/r/26004/diff/
Testing
---
Added new unit tests; all tests pass.
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26098/#review55334
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Sept. 26, 2014, 5:35
operties to
> > catch accidental regressions?
>
> David McLaughlin wrote:
> Piggy backing this issue to add that my ship it is pending a test for
> this command at least?
>
> Mark Chu-Carroll wrote:
> I don't know of any way to write a single test that wo
hanks,
Mark Chu-Carroll
https://reviews.apache.org/r/26328/diff/
Testing
---
New unit test.
Thanks,
Mark Chu-Carroll
obnoxious to do that.
- Mark Chu-Carroll
On Oct. 3, 2014, 4:47 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
c/test/python/apache/aurora/client/cli/util.py
e1ee884c06f3bc22bcd9e908ff61af9459a0b535
Diff: https://reviews.apache.org/r/26004/diff/
Testing
---
Added new unit tests; all tests pass.
Thanks,
Mark Chu-Carroll
://reviews.apache.org/r/26363/diff/
Testing
---
New unit tests added, all test pass.
Thanks,
Mark Chu-Carroll
's a
place where the scheduler is sending things via the deprecated field but not
via the details list, then that should be changed.
- Mark Chu-Carroll
On Oct. 2, 2014, 6:28 p.m., Maxim Khutornenko wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/#review55527
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Oct. 6, 2014, 12:58 p.m
tps://reviews.apache.org/r/26288/#comment95906>
If the client-side API is using a deprecated field of this structure, then
that should be fixed. We shouldn't be patching this to prevent the need to
remove deprecations from the client-side API.
- Mark Chu-Carroll
On Oct. 2, 2014, 6:28
8e696fe3
src/test/python/apache/aurora/client/cli/test_supdate.py
2782fee2867c6ef79349240299de082f07f7967a
src/test/python/apache/aurora/client/cli/util.py
e1ee884c06f3bc22bcd9e908ff61af9459a0b535
Diff: https://reviews.apache.org/r/26328/diff/
Testing
---
New unit test.
Thanks,
Mark Chu-Carroll
https://reviews.apache.org/r/26328/diff/
Testing
---
New unit test.
Thanks,
Mark Chu-Carroll
ng? Something which is consistent with the job verbs would be great.
>
> Mark Chu-Carroll wrote:
> I was following the pattern that I saw in the API implementation. In
> early iterations, it exposed updated ids; in later ones, the IDs were removed
> from the user-level API. We
/cli/test_supdate.py
2782fee2867c6ef79349240299de082f07f7967a
src/test/python/apache/aurora/client/cli/util.py
e1ee884c06f3bc22bcd9e908ff61af9459a0b535
Diff: https://reviews.apache.org/r/26004/diff/
Testing
---
Added new unit tests; all tests pass.
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26388/#review55602
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Oct. 6, 2014, 6:01 p.m
update the review title, just so that when we look at reviews, we know
what this one actually changed?
- Mark Chu-Carroll
On Oct. 6, 2014, 7:40 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail.
y job list json case.
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55717
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Oct. 4, 2014, 1:55 p.m
o bet that there is a way to
get that branch active in a test. Every single time that I've ever said that
something couldn't be tested, or that some branch couldn't be exercised in a
test, I've always been wrong. There's a way.
- Mark Chu-Carroll
On Oct. 4, 2014
tps://reviews.apache.org/r/26328/#comment96178>
It writes into the current directory where the user is executing the client.
- Mark Chu-Carroll
On Oct. 6, 2014, 2:55 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatica
t/cli/test_create.py
6e55188bdfc576506848605debb391288e696fe3
Diff: https://reviews.apache.org/r/26328/diff/
Testing
---
New unit test.
Thanks,
Mark Chu-Carroll
c/main/python/apache/aurora/client/commands/ssh.py
9ee94a0bdfd8bbc030ae978e2ac3fe39571b4ce2
src/test/python/apache/aurora/client/commands/test_ssh.py
c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8
Diff: https://reviews.apache.org/r/26445/diff/
Testing
---
New unit test.
Thanks,
Mark Chu-Carroll
/
Testing
---
Added new unit test; verified all tests pass.
Thanks,
Mark Chu-Carroll
cking with should be done explicitly in the most
local-possible context.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26363/#review55512
-------------
/aurora/client/cli/test_update.py
85b1db19d89967a741bfba7964eeb368426f0b61
Diff: https://reviews.apache.org/r/26363/diff/
Testing
---
New unit tests added, all test pass.
Thanks,
Mark Chu-Carroll
/test_update.py
cff1b6578aec6f5bcc1e610e58b47af233f32b41
Diff: https://reviews.apache.org/r/26363/diff/
Testing
---
New unit tests added, all test pass.
Thanks,
Mark Chu-Carroll
/test_help.py
f73c8a3778b7d118ea2865f213b442a607fb4a7d
Diff: https://reviews.apache.org/r/26688/diff/
Testing
---
Thanks,
Mark Chu-Carroll
nnel descriptors, instance lists, usernames,
etc. Saying "str" doesn't tell you anything meaningful about what's expected.
- Mark Chu-Carroll
On Oct. 14, 2014, 11:07 a.m., Mark Chu-Carroll wrote:
>
> ---
> This
> On Oct. 14, 2014, 1 p.m., Mark Chu-Carroll wrote:
> > src/test/python/apache/aurora/client/cli/test_help.py, line 75
> > <https://reviews.apache.org/r/26688/diff/1/?file=720844#file720844line75>
> >
> > Yes, they are guaranteed to be unique. The argparse
the same way as before this change.
Thanks,
Mark Chu-Carroll
/apache/aurora/client/cli/test_help.py
f73c8a3778b7d118ea2865f213b442a607fb4a7d
Diff: https://reviews.apache.org/r/26688/diff/
Testing
---
Thanks,
Mark Chu-Carroll
-error-log-dir=error-log-dir
Directory location where error files containing stack traces should be
written. If the directory doesn't exist, it will be created
Remove the cron schedule for a job.
{noformat}
Thanks,
Mark Chu-Carroll
strings - so this test tries to specifically check that
that's not happening anymore. If it fails, we know exactly what the problem is.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apach
possible.
How about adding "numeric level as defined by python standard logging"?
- Mark Chu-Carroll
On Oct. 15, 2014, 12:46 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically g
eric_level
Set logging to a specific numeric level.
--error-log-dir=error-log-dir
Directory location where error files containing stack traces should be
written. If the directory doesn't exist, it will be created
Remove the cron schedule for a job.
{noformat}
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review57177
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Oct. 8, 2014, 7:46 p.m
57c5
src/test/python/apache/aurora/client/cli/test_supdate.py
6775c389cb1a0b80dd17fe179e8b98d4e9db0332
Diff: https://reviews.apache.org/r/26881/diff/
Testing
---
Thanks,
Mark Chu-Carroll
job", to make it more concise, but still include the information.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26881/#review57361
----------
/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
8f4d2b01c9fa5a6ec9e8885a2d4fa0e9c3abb8a1
Diff: https://reviews.apache.org/r/26881/diff/
Testing
---
Thanks,
Mark Chu-Carroll
/client/cli/test_update.py .
== 62 passed in 6.42 seconds ===
src.test.python.apache.aurora.client.cli.job
. SUCCESS
Thanks,
Mark Chu-Carroll
s an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26753/#review56757
---
On Oct. 15, 2014, 12:20 p.m., Mark Chu-Carroll wrote:
>
> ---
ly generated e-mail. To reply, visit:
https://reviews.apache.org/r/26982/#review57622
---
On Oct. 21, 2014, 12:19 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatical
e updated setup, and
verified that they fail in exactly the same way as before this change.
Thanks,
Mark Chu-Carroll
1 - 100 of 569 matches
Mail list logo
