Re: Review Request 31101: Native Debian packaging for Aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/#review74880 --- debian/aurora-executor.thermos.default https://reviews.apache.org/r/31101/#comment121698 needs license header debian/aurora-executor.thermos.init https://reviews.apache.org/r/31101/#comment121697 Needs license header debian/aurora-scheduler.default https://reviews.apache.org/r/31101/#comment121701 needs license header debian/aurora-scheduler.init https://reviews.apache.org/r/31101/#comment121700 needs license header debian/aurora-scheduler.postinst https://reviews.apache.org/r/31101/#comment121699 needs license header debian/embed-runner-in-executor.py https://reviews.apache.org/r/31101/#comment121702 if we keep this file then it needs license header added debian/rules https://reviews.apache.org/r/31101/#comment121703 needs license header Bunch of files missing license headers as notes, but overall looks good. Would be nice to not have to put this at the top level, as wfarner pointed out also, but then would have to deal with symlinking and juggling to make it work (we did this in thrift before moving to the top level for ease). Would be good to wrap creation into a task that executed dch and dpkg commands all in one call - Jake Farrell On Feb. 17, 2015, 12:20 a.m., Benjamin Staffin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/ --- (Updated Feb. 17, 2015, 12:20 a.m.) Review request for Aurora and Jake Farrell. Bugs: AURORA-951 https://issues.apache.org/jira/browse/AURORA-951 Repository: aurora Description --- Native Debian packaging for Aurora This uses Debian package dependencies to install gradle and thrift-compiler. Gradle 2.2.1 isn't in Debian or Ubuntu yet, but you can build your own package easily enough using https://github.com/benley/gradle-packaging Diffs - debian/aurora-doc.docs PRE-CREATION debian/aurora-doc.examples PRE-CREATION debian/aurora-executor.dirs PRE-CREATION debian/aurora-executor.install PRE-CREATION debian/aurora-executor.links PRE-CREATION debian/aurora-executor.thermos.default PRE-CREATION debian/aurora-executor.thermos.init PRE-CREATION debian/aurora-executor.thermos.upstart PRE-CREATION debian/aurora-scheduler.default PRE-CREATION debian/aurora-scheduler.init PRE-CREATION debian/aurora-scheduler.install PRE-CREATION debian/aurora-scheduler.links PRE-CREATION debian/aurora-scheduler.postinst PRE-CREATION debian/aurora-scheduler.upstart PRE-CREATION debian/aurora-tools.install PRE-CREATION debian/aurora-tools.links PRE-CREATION debian/changelog PRE-CREATION debian/clusters.json PRE-CREATION debian/compat PRE-CREATION debian/control PRE-CREATION debian/copyright PRE-CREATION debian/embed-runner-in-executor.py PRE-CREATION debian/pants.ini PRE-CREATION debian/rules PRE-CREATION debian/source/format PRE-CREATION Diff: https://reviews.apache.org/r/31101/diff/ Testing --- Built debs in a clean Ubuntu 14.04 environment using git-buildpackage and pbuilder. Have been using debs built from this branch on a testing cluster for a few months now. Thanks, Benjamin Staffin
Review Request 30600: AURORA-1099: 0.7.0 missing license headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30600/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1099 https://issues.apache.org/jira/browse/AURORA-1099 Repository: aurora Description --- AURORA-1099: 0.7.0 missing license headers Diffs - buildSrc/build.gradle 360eb6d199c706394a02ea77d1ee05b238e4b98f examples/jobs/cron_hello_world.aurora f562df26fb7c6c0d91e34f1b122245f326b5c079 examples/jobs/docker/hello_docker.aurora 1403f8a390ba620fe6507a42b82641fc313436e8 src/main/resources/apache/aurora/client/cli/BUILD 10a7d810a3720c00976172f61eab5f7cf054c452 src/test/sh/org/apache/aurora/e2e/validate_serverset.py 352cef87ab351928ae20d22027a35b59574b37a5 Diff: https://reviews.apache.org/r/30600/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 28449: Fix some URLs and text in release emails to include -incubating where appropriate.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28449/#review63560
---
Ship it!
Ship It!
- Jake Farrell
On Nov. 25, 2014, 9 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28449/
---
(Updated Nov. 25, 2014, 9 p.m.)
Review request for Aurora and Jake Farrell.
Repository: aurora
Description
---
When running the release script, i noticed a few URLs were incorrect in the
email draft it produced. Here's the output:
```
Done creating the release. The following draft email has been created
to send to the d...@aurora.incubator.apache.org mailing list.
To: d...@aurora.incubator.apache.org
Subject: [RESULT][VOTE] Release Apache Aurora 0.6.0 (incubating) RC2
All,
The vote to accept Apache Aurora 0.6.0 RC#{rc_tag_version}
as the official Apache Aurora 0.6.0 release has passed.
+1 (Binding)
--
+1 (Non-binding)
--
There were no 0 or -1 votes. Thank you to all who helped make this release.
Aurora 0.6.0 includes the following:
---
The CHANGELOG for the release is available at:
https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.gitf=CHANGELOGhb=0.6.0
The tag used to create the release with is 0.6.0:
https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.githb=0.6.0
The release is available at:
https://dist.apache.org/repos/dist/release/incubator/aurora/0.6.0/apache-aurora-0.6.0-incubating.tar.gz
The MD5 checksum of the release can be found at:
https://dist.apache.org/repos/dist/release/incubator/aurora/0.6.0/apache-aurora-0.6.0-incubating.tar.gz.md5
The signature of the release can be found at:
https://dist.apache.org/repos/dist/release/incubator/aurora/0.6.0/apache-aurora-0.6.0-incubating.asc
The GPG key used to sign the release are available at:
https://dist.apache.org/repos/dist/release/incubator/aurora/KEYS
```
The URL for the `CHANGELOG` and tag (first two URLs) are lacking
'-incubating' (from :216 and :219). I've fixed those, and changed a few
other locations that might deserve the same treatment, though i feel less
strongly about the others.
Diffs
-
build-support/release/release a72c308cdd1cca700017bdffe849fd094e31ab8b
Diff: https://reviews.apache.org/r/28449/diff/
Testing
---
Thanks,
Bill Farner
Re: Review Request 28447: Disambiguate tag push from branch push in release script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28447/#review63037 --- Ship it! Ship It! - Jake Farrell On Nov. 25, 2014, 8:36 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28447/ --- (Updated Nov. 25, 2014, 8:36 p.m.) Review request for Aurora and Jake Farrell. Repository: aurora Description --- The git-push invocation on :140 would fail because after calling git-tag on :139, we have a branch and tag of the same name. Need to tell git which one we want to push. Diffs - build-support/release/release a72c308cdd1cca700017bdffe849fd094e31ab8b Diff: https://reviews.apache.org/r/28447/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 28198: Add an example on how to build with Docker.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62623 --- examples/docker/Dockerfile https://reviews.apache.org/r/28198/#comment104695 Maintainer should be dev@aurora examples/docker/Dockerfile https://reviews.apache.org/r/28198/#comment104696 Should reduce these RUN calls into one liners where possible to reduce number of layers being introduced on the image Great idea, glad to see this being introduced - Jake Farrell On Nov. 19, 2014, 6:02 p.m., Tony Dong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 6:02 p.m.) Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji. Repository: aurora Description --- Add an example on how to build with Docker. Diffs - README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d examples/docker/Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/28198/diff/ Testing --- Thanks, Tony Dong
Review Request 28170: AURORA-933 - python missing license headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28170/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-933 https://issues.apache.org/jira/browse/AURORA-933 Repository: aurora Description --- Adds missing license headers to .py files Diffs - src/main/python/apache/aurora/executor/thermos_statuses.py 634185a7f8b33858a6f3ae7b1e5722c18ee51bf0 src/test/python/apache/aurora/client/api/api_util.py 6e12154fcd6609b763935b9fb7458946efd7d3d6 Diff: https://reviews.apache.org/r/28170/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 27830: Undo 0.6.0 .auroraversion and CHANGELOG changes to prepare for 0.6.0-RC1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27830/#review60680 --- Ship it! Ship It! - Jake Farrell On Nov. 10, 2014, 9:11 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27830/ --- (Updated Nov. 10, 2014, 9:11 p.m.) Review request for Aurora and Jake Farrell. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Undo 0.6.0 .auroraversion and CHANGELOG changes to prepare for 0.6.0-RC1 Diffs - .auroraversion e8ff9d45c6326c28dae836a1409ec0c9b00fd75a CHANGELOG f44375dd11708bcd0706dd5773e450aeb04bbfc3 Diff: https://reviews.apache.org/r/27830/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.
On Oct. 29, 2014, 11:49 p.m., Kevin Sweeney wrote: Would this be a good time to suggest moving these to src/test/resources to match other conventions? As far as I can tell it should be a quick sed one-liner. +1 - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59080 --- On Oct. 29, 2014, 11:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 11:38 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Document thermos checkpoint files, include them in git archives. Diffs - .gitattributes 8d50d053e8aa5f4e54fc85c687f9869875d22e09 docs/test-resource-generation.md PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/README PRE-CREATION Diff: https://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner
Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59111 --- Ship it! Ship It! - Jake Farrell On Oct. 29, 2014, 11:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 11:38 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Document thermos checkpoint files, include them in git archives. Diffs - .gitattributes 8d50d053e8aa5f4e54fc85c687f9869875d22e09 docs/test-resource-generation.md PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/README PRE-CREATION Diff: https://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner
Re: Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253/#review58750 --- why is this not being handled via the release scripts? - Jake Farrell On Oct. 27, 2014, 11:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253/ --- (Updated Oct. 27, 2014, 11:25 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- In preparation for the next release, setting our snapshot version to 0.6.0. Diffs - .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea Diff: https://reviews.apache.org/r/27253/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT
On Oct. 28, 2014, 1:48 a.m., Jake Farrell wrote: why is this not being handled via the release scripts? ignore, know the reasoning (minor vs major updated during last 0.5.0rc) - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253/#review58750 --- On Oct. 27, 2014, 11:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253/ --- (Updated Oct. 27, 2014, 11:25 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- In preparation for the next release, setting our snapshot version to 0.6.0. Diffs - .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea Diff: https://reviews.apache.org/r/27253/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 26852: Use mesos.native egg from ~kevints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/#review57170 --- examples/vagrant/provision-dev-cluster.sh https://reviews.apache.org/r/26852/#comment97672 What about putting it in svn rather that on people.a.o, perhaps in http://svn.apache.org/repos/asf/incubator/aurora/3rdparty/ - Jake Farrell On Oct. 17, 2014, 1:50 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/ --- (Updated Oct. 17, 2014, 1:50 a.m.) Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. Bugs: AURORA-863 https://issues.apache.org/jira/browse/AURORA-863 Repository: aurora Description --- Use mesos.native egg from ~kevints Diffs - examples/vagrant/provision-dev-cluster.sh 740bc212ba604b2c64af92eba1be41e8ed3fdbde Diff: https://reviews.apache.org/r/26852/diff/ Testing --- (Awaiting e2e test results ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) Thanks, Kevin Sweeney
Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25466/#review54282 --- psutil 2.1.2 now available, since we are upgrading here might as well go with the latest version https://github.com/giampaolo/psutil/blob/master/HISTORY.rst - Jake Farrell On Sept. 9, 2014, 6:38 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25466/ --- (Updated Sept. 9, 2014, 6:38 p.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-412 https://issues.apache.org/jira/browse/AURORA-412 Repository: aurora Description --- Upgrade Aurora to psutil 2.1.1 Diffs - 3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 src/main/python/apache/aurora/executor/executor_vars.py 7665a77ca13bbbc337e345356b70f12357692f3d src/main/python/apache/aurora/executor/gc_executor.py 572c106038602b795a5b6bf08b2b85cf4b6bfec6 src/main/python/apache/thermos/core/helper.py 9e4a8fb70df984d175129cb49025b3c222a64679 src/main/python/apache/thermos/monitoring/process_collector_psutil.py 298459bab01d2c01bef1d69c1150ff2d5737ebbf src/test/python/apache/thermos/core/test_helper.py 58096119e1b412afa36a09da5759c5223a5b5d75 Diff: https://reviews.apache.org/r/25466/diff/ Testing --- Ran tests on OS X but not yet on Linux. There is adequate coverage. ==edit, Linux test output== src.test.python.apache.thermos.bin.test_thermos . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.common.test_planner . SUCCESS src.test.python.apache.thermos.common.test_task_planner . SUCCESS src.test.python.apache.thermos.config.test_schema . SUCCESS src.test.python.apache.thermos.core.test_angry . SUCCESS src.test.python.apache.thermos.core.test_ephemerals . SUCCESS src.test.python.apache.thermos.core.test_failing_runner . SUCCESS src.test.python.apache.thermos.core.test_failure_limit . SUCCESS src.test.python.apache.thermos.core.test_finalization . SUCCESS src.test.python.apache.thermos.core.test_helper . SUCCESS src.test.python.apache.thermos.core.test_process . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS src.test.python.apache.aurora.admin.admin_util . SUCCESS src.test.python.apache.aurora.admin.host_maintenance . SUCCESS src.test.python.apache.aurora.client.api.api . SUCCESS src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.mux . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.api.updater_util . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.api . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.config . SUCCESS
Re: Review Request 24173: AURORA-607:release script is broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24173/ --- (Updated Sept. 22, 2014, 5:46 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: aurora-607 https://issues.apache.org/jira/browse/aurora-607 Repository: aurora Description --- Updates release script to promote a voted on rc to an official release. Diffs (updated) - build-support/release/release d94f3ba737ad221ee15f9ff7050065d58d073b5c Diff: https://reviews.apache.org/r/24173/diff/ Testing --- ./build-support/release/release -r 2 I have not tested the actual promotion of the rc to release, as this is the first official ASF release of Apache Aurora I saved that for Kevin to do Steps to publish the 0.5.0 release with this script: * git checkout 0.5.0-rc2 * apply this patch * comment out dirty tree exit condition, line 89 of ./build-support/release/release * test with: ./build-support/release/release -r 2 * rm -rf dist * publish with: ./build-support/release/release -r 2 -p Thanks, Jake Farrell
Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/ --- Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-736 https://issues.apache.org/jira/browse/AURORA-736 Repository: aurora Description --- AURORA-736 - Update committer docs with steps for adding a gpg key Diffs - docs/committers.md 3f68f89f921e1e17e6eb53ef13c550b3e52fce96 Diff: https://reviews.apache.org/r/25898/diff/ Testing --- Thanks, Jake Farrell
Review Request 24173: AURORA-607:release script is broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24173/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: aurora-607 https://issues.apache.org/jira/browse/aurora-607 Repository: aurora Description --- Updates release script to promote a voted on rc to an official release. Diffs - build-support/release/release d94f3ba737ad221ee15f9ff7050065d58d073b5c Diff: https://reviews.apache.org/r/24173/diff/ Testing --- ./build-support/release/release -r 2 I have not tested the actual promotion of the rc to release, as this is the first official ASF release of Apache Aurora I saved that for Kevin to do Steps to publish the 0.5.0 release with this script: * git checkout 0.5.0-rc2 * apply this patch * comment out dirty tree exit condition, line 89 of ./build-support/release/release * test with: ./build-support/release/release -r 2 * rm -rf dist * publish with: ./build-support/release/release -r 2 -p Thanks, Jake Farrell
Re: Review Request 23329: remove embedded jquery
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/#review49153 --- ./src/main/python/apache/thermos/observer/http/assets/jquery* should be removed in favor of using 3rdparty bower components (these are the last deps in the src tree that are not in 3rdparty currently) - Jake Farrell On July 9, 2014, 9:50 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/ --- (Updated July 9, 2014, 9:50 p.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-578 https://issues.apache.org/jira/browse/AURORA-578 Repository: aurora Description --- remove embedded jquery Diffs - src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23329/diff/ Testing --- Thanks, David Robinson
Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review49076 --- +0, I dont really think that this is necessary and will add overhead (especially with AURORA-616), thoughts on opening this up on the dev@ list to a wider discussion? - Jake Farrell On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/ --- (Updated July 29, 2014, 7:14 p.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-620 https://issues.apache.org/jira/browse/AURORA-620 Repository: aurora Description --- Use JCenter over HTTPS instead of Maven Central Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb Diff: https://reviews.apache.org/r/24063/diff/ Testing --- rm -fr ~/.gradle/caches ./gradlew build Thanks, Kevin Sweeney
Review Request 23931: AURORA-600:RC2 License and NOTICE updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23931/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-600 https://issues.apache.org/jira/browse/AURORA-600 Repository: aurora Description --- AURORA-600:RC2 License and NOTICE updates Updates LICENSE and NOTICE for comments found during RC2 review Diffs - LICENSE 8510f4899325c3da52b66cfad3ed2378167c6b94 NOTICE 86fbd708d9806db4d92fa76fdea17666193e5518 Diff: https://reviews.apache.org/r/23931/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 23931: AURORA-600:RC2 License and NOTICE updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23931/ --- (Updated July 25, 2014, 1:48 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-600 https://issues.apache.org/jira/browse/AURORA-600 Repository: aurora Description --- AURORA-600:RC2 License and NOTICE updates Updates LICENSE and NOTICE for comments found during RC2 review Diffs (updated) - LICENSE 8510f4899325c3da52b66cfad3ed2378167c6b94 NOTICE 86fbd708d9806db4d92fa76fdea17666193e5518 Diff: https://reviews.apache.org/r/23931/diff/ Testing --- Thanks, Jake Farrell
Review Request 23876: AURORA-599 - Reset changelog and version for 0.5.0 rc2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23876/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-599 https://issues.apache.org/jira/browse/AURORA-599 Repository: aurora Description --- AURORA-599 - Reset changelog and version for 0.5.0 rc2 Resets the CHANGELOG and .auroraversion back to state it was before 0.5.0-rc1 was cut. Jira fixVersion fields have been updated as well to match any recent resolved tickets since 0.5.0-rc1 was cut that did not get tagged correctly. Diffs - .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea CHANGELOG 017b54652c3d16017f908829d98d3d842e51dbbe Diff: https://reviews.apache.org/r/23876/diff/ Testing --- Thanks, Jake Farrell
Review Request 23688: AURORA-590: Release scripts branch and CHANGELOG urls are wrong in generated email template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23688/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-590 https://issues.apache.org/jira/browse/AURORA-590 Repository: aurora Description --- AURORA-590: Release scripts branch and CHANGELOG urls are wrong in generated email template Fixes urls in email templates to point to correct locations Diffs - build-support/release/release 1ef26b1983c36114007cb26a447e9a5ba3d67893 build-support/release/release-candidate 56012295676ade2ded875396db3fe8e6118de829 Diff: https://reviews.apache.org/r/23688/diff/ Testing --- The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.gitf=CHANGELOGhb=0.5.0-rc1 The branch used to create the release candidate is: https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.githb=0.5.0-rc1 Thanks, Jake Farrell
Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)
On July 17, 2014, 5:33 p.m., Bill Farner wrote: 'Fat jars' are inherently problematic. Some libraries expect resources at well-known locations, which would be candidate for brittleness when there are collisions. Jar signing is also broken by this approach. Unless there's a compelling reason to introduce this trouble, i suggest we stay far, far away. +1, agree with avoiding this - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23595/#review48022 --- On July 17, 2014, 1:05 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23595/ --- (Updated July 17, 2014, 1:05 a.m.) Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora Description --- Add the gradle shadow plugin (for fat jar support) Diffs - build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 Diff: https://reviews.apache.org/r/23595/diff/ Testing --- Built a fat jar, verified that it contains all transitive aurora dependencies and runs. % ./gradlew shadowJar Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8 :bootstrapThrift UP-TO-DATE :checkPython :generateSources UP-TO-DATE :compileGeneratedJava UP-TO-DATE :processGeneratedResources UP-TO-DATE :generatedClasses UP-TO-DATE :compileJava UP-TO-DATE :processResources UP-TO-DATE :classes UP-TO-DATE :shadowJar BUILD SUCCESSFUL Total time: 20.956 secs % jar tf dist/libs/aurora-0.5.0-SNAPSHOT-all.jar | wc -l Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8 20712 % java -jar dist/libs/aurora-0.5.0-SNAPSHOT-all.jar -help 2/dev/null | wc -l 235 Thanks, Kevin Sweeney
Review Request 23317: AURORA-565:update top level README with instructions on bootstrapping and running initial test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23317/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-565 https://issues.apache.org/jira/browse/AURORA-565 Repository: aurora Description --- AURORA-565: update top level README with instructions on bootstrapping and running initial test Updates README with basic instructions to get started with Apache Aurora. Preview: https://github.com/jfarrell/incubator-aurora/tree/AURORA-565 Diffs - README.md 82096f60c5eed8d34a1c180e975052405329d39a Diff: https://reviews.apache.org/r/23317/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 23238: Move license header to inner node in angular fragments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23238/#review47230 --- Ship it! Ship It! - Jake Farrell On July 2, 2014, 6:56 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23238/ --- (Updated July 2, 2014, 6:56 p.m.) Review request for Aurora, Joe Smith and Maxim Khutornenko. Bugs: AURORA-563 https://issues.apache.org/jira/browse/AURORA-563 Repository: aurora Description --- Move license header to inner node in angular fragments. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 1a77bd129aecfdbff1922edaa43f1738c1e09312 src/main/resources/org/apache/aurora/scheduler/http/ui/configSummary.html 6fb8dadfdce3307fcf3a48da83065a3b63cf20d8 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html f54137c7f42a78cede21c5223ba4954ab9f58488 src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 83500b4a10d2928f9fdcca7ee10f84ca2a51c6b6 src/main/resources/org/apache/aurora/scheduler/http/ui/home.html 711073f919254bba4ec7f752228363c967662afc src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 2e4c0d427474b6758c352939f857536e8b6cf290 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html b266b915d64ddee997c48f4a3e0aecf254135ed9 src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html 4e72c226299579b4ea85973ed77b7085eb99b073 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html cfd424cd7184b5212709a5efdb6b3e0dde31f3c9 src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html f1a4da84601f1c4f91a8c8884f7da497c3998d18 src/main/resources/org/apache/aurora/scheduler/http/ui/schedulingDetail.html 7649d0bfc0bb2e55be8c1ecb4f9efa0ae30f9b20 src/main/resources/org/apache/aurora/scheduler/http/ui/taskLink.html 144a3b73a7aefaa73f31fe6766f430c3debf3c00 src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html cd4172e174606a047862733ad220946531334d15 src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 2fb9543dcb8cfcc6e6e7a87562c8f18a07e29912 Diff: https://reviews.apache.org/r/23238/diff/ Testing --- vagrant up bash examples/vagrant/test_tutorial.sh Observed that config bar is now present. Thanks, Bill Farner
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
On June 27, 2014, 6:01 p.m., Kevin Sweeney wrote: overall -1 to shipping as-is, since this will break tests in the source distribution Lets discuss this further at the monday meeting then - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22983/#review46884 --- On June 25, 2014, 8:18 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22983/ --- (Updated June 25, 2014, 8:18 p.m.) Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-278 https://issues.apache.org/jira/browse/AURORA-278 Repository: aurora Description --- AURORA-278 - Remove binaries from source RC Diffs - .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea .gitattributes PRE-CREATION CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7 build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947 build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db Diff: https://reviews.apache.org/r/22983/diff/ Testing --- ./builds-support/release/release-candidate -r 1 -l m verified gig sig, md5, sha, untared release and looked for binary artifacts. Additional review opened to address missing headers Thanks, Jake Farrell
Re: Review Request 21402: Add python checkstyle hooks.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21402/#review46638
---
Ship it!
Looks good, please create a ticket to capture the log output so it is not
forgotten about
- Jake Farrell
On May 13, 2014, 8:04 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21402/
---
(Updated May 13, 2014, 8:04 p.m.)
Review request for Aurora, Jake Farrell and Kevin Sweeney.
Bugs: AURORA-149
https://issues.apache.org/jira/browse/AURORA-149
Repository: aurora
Description
---
Consolidates python checks into build-support/python.
Adds checkstyle tool, which runs pep8, pyflakes and a number of general code
cleanliness plugins.
Should I add the proposed style guide in this review or is a subsequent
review fine? It's essentially 2sp indent, 100-col lines, naming conventions
+ a few things to make life easy in a 2.x+3.x codebase. These latter plugins
can be omitted via the -n option in the checkstyle tool.
I have a separate branch that goes through and fixes all the checkstyle
errors. It's a ~1000 line diff but mostly minor changes.
Diffs
-
.gitignore cd7bc6dd122fd3490568fe5b2a68d59cfff7fbff
build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a
build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f
build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a
build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07
build-support/python/checkstyle PRE-CREATION
build-support/python/checkstyle-check PRE-CREATION
src/main/python/apache/aurora/client/cli/task.py
1bd746da2f39f78b1497701f69777ca3ea6b70ea
Diff: https://reviews.apache.org/r/21402/diff/
Testing
---
mba=aurora=; build-support/python/checkstyle-check src/main/python/ | grep
^\w | awk '{ print $1 }' | sort | uniq -c | sort -rn
120 E251:ERROR
90 F401:ERROR
86 T001:ERROR
65 E221:ERROR
28 T800:WARNING
27 T301:ERROR
22 T302:ERROR
20 T607:ERROR
19 E261:ERROR
17 E303:ERROR
14 E501:ERROR
13 F841:ERROR
11 E226:ERROR
8 F821:ERROR
6 T803:ERROR
6 T802:WARNING
4 T000:ERROR
4 F403:ERROR
4 E712:ERROR
3 E241:ERROR
3 E203:ERROR
3 E202:ERROR
2 T801:ERROR
2 T602:ERROR
2 T200:ERROR
2 T100:ERROR
2 T002:ERROR
2 E711:ERROR
2 E201:ERROR
1 E231:ERROR
1 E222:ERROR
1 E122:ERROR
Thanks,
Brian Wickman
Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt
On April 25, 2014, 4:06 a.m., Bill Farner wrote: I have some reservations with this, but they're not well-formed. I like the idea of giving committers a chance to chime in on reviews, and we seem to be building process around reviewboard for that. We also have plans to build test automation around reviewboard. This seems to turn github into a back door of sorts for changes to not receive the same level of scrutiny. What are your thoughts? Jake Farrell wrote: Github makes it easier for some to contribute patches, but we should require the same criteria as we do with reviewboard (Jira ticket, tests performed, etc). This tooling is just to make it easier for us to manage those contributions, wish we could disable Github pull requests on the mirrors, but that is not an available option Bill Farner wrote: I've obviously been delinquent here. My apologies. Overall -1 on this feature. I'm not fond of the idea of pulling diffs from different places. The biggest issue for me is that we lose a canonical location for code reviews. A big downside is that we would no longer have a cohesive history of the code (i consider code reviews a non-trivial part of the history of project). It also complicates future automation like code review validation on commits, which i am very interested in doing to keep our commit history clean and enforce agreed-upon best practices. I'm fine not including this as long as we have a documented process and stick to it - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/#review41435 --- On April 17, 2014, 4 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/ --- (Updated April 17, 2014, 4 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-323 https://issues.apache.org/jira/browse/AURORA-323 Repository: aurora Description --- AURORA-323:Add ability to merge in github pull requests similar to rbt Created a new extension for rbt which adds a new github subcommand to preview and merge/commit available pull requests. Adds text to the commit message so when github mirrors the given commit the pull request will automatically be closed. Diffs - .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 Diff: https://reviews.apache.org/r/20407/diff/ Testing --- Preview a pull request patch ./rbt github -p 7 Commit a pull request ./rbt github -c 7 Thanks, Jake Farrell
Review Request 22976: AURORA-552: License headers missing
/resources/org/apache/aurora/scheduler/http/ui/taskLink.html 3779b7e1a98205968548724020fcce17b0d052cf src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html 8f7b0c870553baae981dba6e4283a6fe8a5a4488 src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 3ae5013ecc0c5dc0e3175e3587b49aa5a3c4db86 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 1e5c625bb9b5b0b9a2c4411fed3e4222e068ecb7 src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml 9a87d770be7348a15c254310d0020969d42e4470 src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml 3797e4c7798d4439053e2c68a4c81a1ec9368a82 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 405fda5e89b8610838d75a33e0e2e449420afccd src/test/python/apache/aurora/client/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/test/python/apache/aurora/common/test_transport.py c9a41417d31dc3d40cb490b7f781fcdc7d2eee7b src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 80871273fc4d47558253e6b09c92724e8693bc11 src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora fc723cf232ddbc10458fc394e37358c8523118c2 Diff: https://reviews.apache.org/r/22976/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 22976: AURORA-552: License headers missing
8fee0196e255d6f14012a6f27d1b83321800ffb3 src/main/resources/org/apache/aurora/scheduler/http/ui/taskLink.html 3779b7e1a98205968548724020fcce17b0d052cf src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html 8f7b0c870553baae981dba6e4283a6fe8a5a4488 src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 3ae5013ecc0c5dc0e3175e3587b49aa5a3c4db86 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 1e5c625bb9b5b0b9a2c4411fed3e4222e068ecb7 src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml 9a87d770be7348a15c254310d0020969d42e4470 src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml 3797e4c7798d4439053e2c68a4c81a1ec9368a82 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 405fda5e89b8610838d75a33e0e2e449420afccd src/test/python/apache/aurora/client/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/test/python/apache/aurora/common/test_transport.py c9a41417d31dc3d40cb490b7f781fcdc7d2eee7b src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 80871273fc4d47558253e6b09c92724e8693bc11 src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora fc723cf232ddbc10458fc394e37358c8523118c2 Diff: https://reviews.apache.org/r/22976/diff/ Testing --- Thanks, Jake Farrell
Review Request 22983: AURORA-278 - Remove binaries from source RC
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22983/ --- Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-278 https://issues.apache.org/jira/browse/AURORA-278 Repository: aurora Description --- AURORA-278 - Remove binaries from source RC Diffs - .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea .gitattributes PRE-CREATION CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7 build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947 build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db Diff: https://reviews.apache.org/r/22983/diff/ Testing --- ./builds-support/release/release-candidate -r 1 -l m verified gig sig, md5, sha, untared release and looked for binary artifacts. Additional review opened to address missing headers Thanks, Jake Farrell
Re: Review Request 22956: AURORA-231: Upgrade gradle license plugin to v9 which contains reduced debug output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22956/ --- (Updated June 26, 2014, 2:28 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Summary (updated) - AURORA-231: Upgrade gradle license plugin to v9 which contains reduced debug output Bugs: AURORA-231 https://issues.apache.org/jira/browse/AURORA-231 Repository: aurora Description (updated) --- AURORA-231: Upgrade gradle license plugin to v9 which contains reduced debug output Upgrades license plugin to latest version which contains updates to silence ignored headers [1]. [1]: https://github.com/hierynomus/license-gradle-plugin/pull/31 Diffs - build.gradle bcecb43308a654e79db5cbd0ba973b2410b00de9 Diff: https://reviews.apache.org/r/22956/diff/ Testing --- ./gradlew -Pq clean build Thanks, Jake Farrell
Re: Review Request 19796: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19796/ --- (Updated June 26, 2014, 3:23 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- rebase against master, gradlew clean build passes tests Bugs: AURORA-145 https://issues.apache.org/jira/browse/AURORA-145 Repository: aurora Description --- AURORA-145:Test dependencies leak into distribution Moves testing dependencies out of main src into test. Diffs (updated) - build.gradle be2ff053f5bba4248a1ddc2f67b4f055e4e3f841 src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java Diff: https://reviews.apache.org/r/19796/diff/ Testing --- Was initially waiting on AURORA-132 for this. ran build-support/jenkins/build.sh and created dists with no issues. Thanks, Jake Farrell
Re: Review Request 21402: Add python checkstyle hooks.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21402/#review43400
---
Ship it!
Looks good, thoughts on saving the output to a build log file rather than
/dev/null and prompting to re-run on error?
- Jake Farrell
On May 13, 2014, 8:04 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21402/
---
(Updated May 13, 2014, 8:04 p.m.)
Review request for Aurora, Jake Farrell and Kevin Sweeney.
Bugs: AURORA-149
https://issues.apache.org/jira/browse/AURORA-149
Repository: aurora
Description
---
Consolidates python checks into build-support/python.
Adds checkstyle tool, which runs pep8, pyflakes and a number of general code
cleanliness plugins.
Should I add the proposed style guide in this review or is a subsequent
review fine? It's essentially 2sp indent, 100-col lines, naming conventions
+ a few things to make life easy in a 2.x+3.x codebase. These latter plugins
can be omitted via the -n option in the checkstyle tool.
I have a separate branch that goes through and fixes all the checkstyle
errors. It's a ~1000 line diff but mostly minor changes.
Diffs
-
.gitignore cd7bc6dd122fd3490568fe5b2a68d59cfff7fbff
build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a
build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f
build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a
build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07
build-support/python/checkstyle PRE-CREATION
build-support/python/checkstyle-check PRE-CREATION
src/main/python/apache/aurora/client/cli/task.py
1bd746da2f39f78b1497701f69777ca3ea6b70ea
Diff: https://reviews.apache.org/r/21402/diff/
Testing
---
mba=aurora=; build-support/python/checkstyle-check src/main/python/ | grep
^\w | awk '{ print $1 }' | sort | uniq -c | sort -rn
120 E251:ERROR
90 F401:ERROR
86 T001:ERROR
65 E221:ERROR
28 T800:WARNING
27 T301:ERROR
22 T302:ERROR
20 T607:ERROR
19 E261:ERROR
17 E303:ERROR
14 E501:ERROR
13 F841:ERROR
11 E226:ERROR
8 F821:ERROR
6 T803:ERROR
6 T802:WARNING
4 T000:ERROR
4 F403:ERROR
4 E712:ERROR
3 E241:ERROR
3 E203:ERROR
3 E202:ERROR
2 T801:ERROR
2 T602:ERROR
2 T200:ERROR
2 T100:ERROR
2 T002:ERROR
2 E711:ERROR
2 E201:ERROR
1 E231:ERROR
1 E222:ERROR
1 E122:ERROR
Thanks,
Brian Wickman
Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt
On April 25, 2014, 4:06 a.m., Bill Farner wrote: I have some reservations with this, but they're not well-formed. I like the idea of giving committers a chance to chime in on reviews, and we seem to be building process around reviewboard for that. We also have plans to build test automation around reviewboard. This seems to turn github into a back door of sorts for changes to not receive the same level of scrutiny. What are your thoughts? Github makes it easier for some to contribute patches, but we should require the same criteria as we do with reviewboard (Jira ticket, tests performed, etc). This tooling is just to make it easier for us to manage those contributions, wish we could disable Github pull requests on the mirrors, but that is not an available option - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/#review41435 --- On April 17, 2014, 4 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/ --- (Updated April 17, 2014, 4 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-323 https://issues.apache.org/jira/browse/AURORA-323 Repository: aurora Description --- AURORA-323:Add ability to merge in github pull requests similar to rbt Created a new extension for rbt which adds a new github subcommand to preview and merge/commit available pull requests. Adds text to the commit message so when github mirrors the given commit the pull request will automatically be closed. Diffs - .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 Diff: https://reviews.apache.org/r/20407/diff/ Testing --- Preview a pull request patch ./rbt github -p 7 Commit a pull request ./rbt github -c 7 Thanks, Jake Farrell
Re: Review Request 21386: Add support for custom project to list-missing-shipits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21386/#review43080 --- please create a jira issue for this and then +1 - Jake Farrell On May 13, 2014, 9:18 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21386/ --- (Updated May 13, 2014, 9:18 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Add support for custom project to list-missing-shipits. Search for rbt on PATH. Diffs - build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7 Diff: https://reviews.apache.org/r/21386/diff/ Testing --- Ran script against project Mesos. Thanks, Dominic Hamon
Review Request 21253: AURORA-392: Add apache- to source distribution name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21253/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-392 https://issues.apache.org/jira/browse/AURORA-392 Repository: aurora Description --- AURORA-392: Add apache- to source distribution name Updates release scripts to prefix the package with Apache namespace. Diffs - build-support/release/release eefd2cb5b82cf75a6d8718bd7b99264020c12895 build-support/release/release-candidate 2a86413feed290fe15aacc43bd6ca2a62a902e51 Diff: https://reviews.apache.org/r/21253/diff/ Testing --- Performing dry-run apache-aurora-0.5.1-rc0-incubating.tar.gz apache-aurora-0.5.1-rc0-incubating.tar.gz.md5 apache-aurora-0.5.1-rc0-incubating.tar.gz.asc apache-aurora-0.5.1-rc0-incubating.tar.gz.sha Thanks, Jake Farrell
Review Request 21111: AURORA-388 - Update changelog to only pickup fixed issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-388 https://issues.apache.org/jira/browse/AURORA-388 Repository: aurora Description --- AURORA-388 - Update changelog to only pickup fixed issues Updates the changelog jql to only pick up fixed and done issues. Diffs - build-support/release/changelog 6bd8ee9e6136c13e223bc166a06c8d80dce2468a Diff: https://reviews.apache.org/r/2/diff/ Testing --- Removed CHANGELOG file and switched .auroraversion to 0.5.0 and re-ran script, came back with 160 issues vs the 183 currently listed. Thanks, Jake Farrell
Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21055/#review42098 --- 3rdparty/python/BUILD https://reviews.apache.org/r/21055/#comment75840 can not depend on the .git dir at the tlp as in the release there is no .git dir build-support/jenkins/build_mesos.sh https://reviews.apache.org/r/21055/#comment75844 Since this is only used by build_executor jenkins script does it need to be its own file? build-support/jenkins/build_mesos.sh https://reviews.apache.org/r/21055/#comment75841 space at end of line build-support/jenkins/build_mesos.sh https://reviews.apache.org/r/21055/#comment75842 this should detect python version like all other py scripts in use src/test/python/apache/aurora/executor/test_thermos_executor.py https://reviews.apache.org/r/21055/#comment75843 Nice catch - Jake Farrell On May 4, 2014, 12:02 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21055/ --- (Updated May 4, 2014, 12:02 a.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and Brian Wickman. Repository: aurora Description --- AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests I took this over from wickman at his request (old review: https://reviews.apache.org/r/19955/). Changes: - Use mesos 0.18.0 instead of 0.17.0 - Download mesos source from apache.org - Conditionally build mesos .egg - Fix a test in test_thermos_executor.py that was broken Diffs - .mesosversion PRE-CREATION 3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f build-support/jenkins/build_executor.sh PRE-CREATION build-support/jenkins/build_mesos.sh PRE-CREATION build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 src/test/python/apache/aurora/executor/test_thermos_executor.py 0b143d0a2cbb25c1d35f79963478800a6b6713ec Diff: https://reviews.apache.org/r/21055/diff/ Testing --- ./build-support/jenkins/build_mesos.sh ./pants src/test/python/apache/aurora/executor:executor-large -vxs (what the new build_executor.sh script does) Thanks, Dan Norris
Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21055/#review42099 --- Nice work Dan, overall just some minimal comments aimed more at the review group than the actual patch iteself. Thanks for picking this up and finishing the work on it - Jake Farrell On May 4, 2014, 12:02 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21055/ --- (Updated May 4, 2014, 12:02 a.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and Brian Wickman. Repository: aurora Description --- AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests I took this over from wickman at his request (old review: https://reviews.apache.org/r/19955/). Changes: - Use mesos 0.18.0 instead of 0.17.0 - Download mesos source from apache.org - Conditionally build mesos .egg - Fix a test in test_thermos_executor.py that was broken Diffs - .mesosversion PRE-CREATION 3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f build-support/jenkins/build_executor.sh PRE-CREATION build-support/jenkins/build_mesos.sh PRE-CREATION build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 src/test/python/apache/aurora/executor/test_thermos_executor.py 0b143d0a2cbb25c1d35f79963478800a6b6713ec Diff: https://reviews.apache.org/r/21055/diff/ Testing --- ./build-support/jenkins/build_mesos.sh ./pants src/test/python/apache/aurora/executor:executor-large -vxs (what the new build_executor.sh script does) Thanks, Dan Norris
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19710/ --- (Updated April 30, 2014, 6:09 p.m.) Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Changes --- Addresses comments for release-candidate script, adds verify-release-candidate script and adds update to release script to update .auroraversion and create a release branch along with the tag. Bugs: AURORA-78 https://issues.apache.org/jira/browse/AURORA-78 Repository: aurora Description --- AURORA-78: automate and enforce release workflow Adds scripts to generate the CHANGELOG from JIRA, create the release candidate, generate the release candidate VOTE email draft, generate the release from the release candidate and the RESULT VOTE email draft. docs/committers.md added with process flow details. Diffs (updated) - build-support/release/changelog PRE-CREATION build-support/release/release PRE-CREATION build-support/release/release-candidate PRE-CREATION build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b build-support/release/verify-release-candidate PRE-CREATION docs/committers.md PRE-CREATION docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 Diff: https://reviews.apache.org/r/19710/diff/ Testing --- Have been running these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs. Thanks, Jake Farrell
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19710/ --- (Updated April 30, 2014, 6:38 p.m.) Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-78 https://issues.apache.org/jira/browse/AURORA-78 Repository: aurora Description --- AURORA-78: automate and enforce release workflow Adds scripts to generate the CHANGELOG from JIRA, create the release candidate, generate the release candidate VOTE email draft, generate the release from the release candidate and the RESULT VOTE email draft. docs/committers.md added with process flow details. Diffs (updated) - build-support/release/changelog PRE-CREATION build-support/release/release PRE-CREATION build-support/release/release-candidate PRE-CREATION build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b build-support/release/verify-release-candidate PRE-CREATION docs/committers.md PRE-CREATION docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 Diff: https://reviews.apache.org/r/19710/diff/ Testing --- Have been running these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs. Thanks, Jake Farrell
Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.
On April 28, 2014, 11 p.m., Maxim Khutornenko wrote: FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way. Bill Farner wrote: The time sink is not inherent to running in vagrant, but that we have not yet invested time in streamlining the code iteration process in the vagrant environment (i.e. rather than destroy/up). Keeping the isolated mode around doesn't nudge us to define that process. Suman Karumuri wrote: Can we keep gradle run target without the isolated scheduler module? I can see a how it can make testing quicker. Bill Farner wrote: Can we keep gradle run target without the isolated scheduler module? Have any ideas? I don't see a path without moving the existing if production do this, else do this scattered around. I can see a how it can make testing quicker. It really shouldn't by any meaningful amount. vagrant up will always be slower than ./gradlew run, but my point is that we need to define a development flow that doesn't require repeated vagrant up/destroy. Maxim Khutornenko wrote: ...we need to define a development flow that doesn't require repeated vagrant up/destroy. IMO, forcing ourselves into vagrant-only approach limits our iteration speed. I would rather prefer having an option to debug simple things on the spot without the need to git commit any changes or run the vagrant VM. Both approaches have their strengths and I don't think the isolated module code is pressing us hard for removal. Bill Farner wrote: without the need to git commit any changes This actually supports my point of apathy if we keep this approach - there's no real reason we need to git commit to use vagrant, it's just the way the setup is right now. It will be trivial to remove that requirement. Kevin Sweeney wrote: In theory a workflow where we do ./gradlew installApp; vagrant ssh -- sudo restart aurora-scheduler; vagrant ssh -- tail -f /var/log/upstart/aurora-scheduler.log inside the VM gives us the same iteration speed (since gradle will still do incremental compilation). I think the key there would be to use a symlink to /vagrant/dist/install in the scheduler rather than build internally. Switching to using config.vm.synced_folder will also help so we can use the local checked out repo and live edit whats in the vm without having to copy files back and forth. If we are going to keep the isolated scheduler around then we should move it into test as all that has been discussed with this is around testing and not for use outside of that - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review41646 --- On April 24, 2014, 4:22 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/ --- (Updated April 24, 2014, 4:22 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-340 https://issues.apache.org/jira/browse/AURORA-340 Repository: aurora Description --- Remove IsolatedSchedulerModule and surrounding code. Diffs - build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 1bfd4b69584122f62616ce93098a56fe3cf195d8 src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 9186aebef2babc4a76fe05eb3b412be26d7de3c6 src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java cc31187607e89a9daebe071a8a180d56d873e4c5 Diff: https://reviews.apache.org/r/20648/diff/ Testing --- ./gradlew build sh examples/vagrant/test_tutorial.sh Thanks, Bill Farner
Re: Review Request 20824: AURORA-278: Review Incubator release check list - missing license headers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20824/
---
(Updated April 29, 2014, 8:51 p.m.)
Review request for Aurora and Kevin Sweeney.
Changes
---
Updating js, py and sh files with missing license headers, updates LICENSE as
well for multiple jQuery paths
Bugs: AURORA-278
https://issues.apache.org/jira/browse/AURORA-278
Repository: aurora
Description
---
AURORA-278: Review Incubator release check list
Adds missing license headers in python files.
Diffs (updated)
-
LICENSE 1aea1f72b3a17da4804e8e1918311f07a14f1b0a
examples/vagrant/test_tutorial.sh b607c3a8306cd6d62b6f6508ee336b5bb3cddd88
src/main/python/apache/aurora/common/shellify.py
67d81f0983a343d5527ce6152bad2d591e5f08dd
src/main/python/apache/thermos/observer/http/assets/jquery.pailer.js
5962f9e9d347f10610229e9a50d1e2a93f2f8dc0
src/main/python/apache/thermos/observer/http/assets/observer.js
84aec5d8d762a9b51d0620dcc7a7a602dd2676c9
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js
8806964c2c60f0777b38ae42375a0ca89e5a5a7e
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
e0b3aab6b383f59094785e50ecfc839695e4a038
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js
5d6f2b6665915c84c76e2b930e498c8972ae5094
src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js
2a3959c6308bebff87c297191d36612d0510d546
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
e04c8c61ecef920cafe879d6d12b337783c70f10
src/test/python/apache/aurora/common/test_shellify.py
8ecce7ff98769cd17cc016bee30750c5841fa942
Diff: https://reviews.apache.org/r/20824/diff/
Testing
---
Since there is no checkstyle yet for py code ran following check to see which
py files where missing headers still
Dir['src/**/*.py'].each { |f| content = File.open(f).read(); next if
content.empty? ; puts f unless File.open(f).read().include?(Apache Software
Foundation) }
Thanks,
Jake Farrell
Review Request 20782: AURORA-278:Review Incubator release check list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20782/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-278 https://issues.apache.org/jira/browse/AURORA-278 Repository: aurora Description --- AURORA-278:Review Incubator release check list Updating LICENSE file for new JS additions. Diffs - LICENSE 720805eff74008a71bb5febd6d13996b341f23cd Diff: https://reviews.apache.org/r/20782/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 20782: AURORA-278:Review Incubator release check list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20782/ --- (Updated April 28, 2014, 7:39 p.m.) Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Bill Farner. Changes --- Added Bugs: AURORA-278 https://issues.apache.org/jira/browse/AURORA-278 Repository: aurora Description --- AURORA-278:Review Incubator release check list Updating LICENSE file for new JS additions. Diffs - LICENSE 720805eff74008a71bb5febd6d13996b341f23cd Diff: https://reviews.apache.org/r/20782/diff/ Testing --- Thanks, Jake Farrell
Review Request 20824: AURORA-278: Review Incubator release check list - missing license headers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20824/
---
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-278
https://issues.apache.org/jira/browse/AURORA-278
Repository: aurora
Description
---
AURORA-278: Review Incubator release check list
Adds missing license headers in python files.
Diffs
-
src/main/python/apache/aurora/common/shellify.py
67d81f0983a343d5527ce6152bad2d591e5f08dd
src/test/python/apache/aurora/common/test_shellify.py
8ecce7ff98769cd17cc016bee30750c5841fa942
Diff: https://reviews.apache.org/r/20824/diff/
Testing
---
Since there is no checkstyle yet for py code ran following check to see which
py files where missing headers still
Dir['src/**/*.py'].each { |f| content = File.open(f).read(); next if
content.empty? ; puts f unless File.open(f).read().include?(Apache Software
Foundation) }
Thanks,
Jake Farrell
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19710/ --- (Updated April 28, 2014, 3:39 a.m.) Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Changes --- All comments addressed, switched to dry-run as the default and added more documentation Bugs: AURORA-78 https://issues.apache.org/jira/browse/AURORA-78 Repository: aurora Description --- AURORA-78: automate and enforce release workflow Adds scripts to generate the CHANGELOG from JIRA, create the release candidate, generate the release candidate VOTE email draft, generate the release from the release candidate and the RESULT VOTE email draft. docs/committers.md added with process flow details. Diffs (updated) - build-support/release/changelog PRE-CREATION build-support/release/release PRE-CREATION build-support/release/release-candidate PRE-CREATION build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b docs/committers.md PRE-CREATION docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 Diff: https://reviews.apache.org/r/19710/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19710/ --- (Updated April 28, 2014, 4:12 a.m.) Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-78 https://issues.apache.org/jira/browse/AURORA-78 Repository: aurora Description --- AURORA-78: automate and enforce release workflow Adds scripts to generate the CHANGELOG from JIRA, create the release candidate, generate the release candidate VOTE email draft, generate the release from the release candidate and the RESULT VOTE email draft. docs/committers.md added with process flow details. Diffs - build-support/release/changelog PRE-CREATION build-support/release/release PRE-CREATION build-support/release/release-candidate PRE-CREATION build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b docs/committers.md PRE-CREATION docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 Diff: https://reviews.apache.org/r/19710/diff/ Testing (updated) --- Have been running these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs. Thanks, Jake Farrell
Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4
On April 25, 2014, 9:08 p.m., Kevin Sweeney wrote: Is there a changelog? What's coming in here? Is there a ticket open for this? - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20735/#review41527 --- On April 25, 2014, 9:06 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20735/ --- (Updated April 25, 2014, 9:06 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Upgrade aurora repo to twitter.common.python 0.5.4 Diffs - 3rdparty/python/BUILD de7d93fc7d5e94db0f4bafbef3269e5df30fce6c Diff: https://reviews.apache.org/r/20735/diff/ Testing --- ./pants src/test/python:all -v Thanks, Brian Wickman
Re: Review Request 20650: Exclude reports directory from idea project.
On April 24, 2014, 6:36 a.m., Suman Karumuri wrote: build.gradle, line 338 https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338 Can we add dist/ to this list? +1 with dist added - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20650/#review41272 --- On April 24, 2014, 5:05 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20650/ --- (Updated April 24, 2014, 5:05 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- IDEA indexes non-excluded directories in dist. This makes indexing take much longer than necesary, and causes bogus results when searching for usages of symbols. This fixes (the majority, at least) both issues. Diffs - build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 Diff: https://reviews.apache.org/r/20650/diff/ Testing --- IDEA no longer goes into as much of an indexing frenzy after running ./gradlew build, and searching for symbols does not turn up javadoc HTML and test results. Thanks, Bill Farner
Re: Review Request 19627: Updates documentation files for markdown consistency
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19627/#review41296 --- Ship it! Thanks for tackling this Dave, looks good for doc - site - Jake Farrell On April 24, 2014, 12:43 a.m., Dave Lester wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19627/ --- (Updated April 24, 2014, 12:43 a.m.) Review request for Aurora and Mark Chu-Carroll. Repository: aurora Description --- Updates documentation to add headers to pages that needed them, cleans up whitespace, and makes markdown for headers consistent. Diffs - docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b docs/developing-aurora-scheduler.md 95bf47278b4cf040ed902e43a151fe9fae19bfc5 docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 docs/resourceisolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887 docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53 Diff: https://reviews.apache.org/r/19627/diff/ Testing --- Thanks, Dave Lester
Re: Review Request 20583: upgrade aurora repo to newer pants and commons
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/#review41299 --- Dan has a review up for testing the version of python in use for development, do we want to pull 2.6 out of that check list if we are seeing these errors from stdlib caused in that version? - Jake Farrell On April 24, 2014, 1:33 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/ --- (Updated April 24, 2014, 1:33 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Pins twitter.common on 0.3.0 (save twitter.common.python which is released out of band.) Upgrades aurora to twitter.pants 0.0.18 which uses twitter.common.python==0.5.1 and produces wheels. Updates the thrift python namespaces so that the autogenerated python artifacts do not clobber each other. Diffs - 3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f BUILD c075158c7104db84c9eacfd83262e8fd7f120a4c build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 pants 56847307fcffb244c1debb14f2250564a9174955 pants.ini 5e85d50bc488b2b153a437b946b425f2b512b30e src/main/python/apache/aurora/admin/host_maintenance.py 6a21ddeb4203a07a04360f68c4a338fe3da52c70 src/main/python/apache/aurora/client/api/__init__.py ecc3742411b9fed73d6e4cea43da1bc25e2ae97e src/main/python/apache/aurora/client/api/command_runner.py f7605f40b5c4ec864a1bae68649f282268260528 src/main/python/apache/aurora/client/api/health_check.py de7dc69d798e2b90844e95501b4375f90f6e5f94 src/main/python/apache/aurora/client/api/instance_watcher.py d7db426e6ac712e69eb18a10b6e4cb2da4509aa9 src/main/python/apache/aurora/client/api/job_monitor.py 537e417e074468e169062b73ab207331c51d6a30 src/main/python/apache/aurora/client/api/quota_check.py c58bc4bfac47f85f674af15845b06d9f2294fe57 src/main/python/apache/aurora/client/api/restarter.py d060c1b27af2864a33e6524e58b81fe767ec2e98 src/main/python/apache/aurora/client/api/scheduler_client.py d0e0821a8e8ad38302678ecf686a6028300ebe22 src/main/python/apache/aurora/client/api/sla.py c381de4f1c8eb289efedce9a4efe93d44f44ff62 src/main/python/apache/aurora/client/api/updater.py 9739af025b810c48f10f65edc2c10da88a8b1a2a src/main/python/apache/aurora/client/base.py a33e65ce2b455148d4944d20bbff638dfca7d34a src/main/python/apache/aurora/client/cli/context.py 957c788c8b073c3711b81a3d56b29b926c717eaa src/main/python/apache/aurora/client/cli/jobs.py 0534bdf72a332caa606dd3a7ca743a59e03738ef src/main/python/apache/aurora/client/cli/quota.py 80f7817890c383fec78811ece7d88e90829b067e src/main/python/apache/aurora/client/cli/task.py e4ee77ede119fc1e3bd196293965073405bb48b3 src/main/python/apache/aurora/client/commands/admin.py 3765a2eb85c1782f0b86d46bec50043d908bb09f src/main/python/apache/aurora/client/commands/core.py 67c061eace86b7a28d2c3ae03e23c7d77fc7957f src/main/python/apache/aurora/client/config.py 855f7091837695658fbcd9003f7f85ee28aacde7 src/main/python/apache/aurora/client/hooks/hooked_api.py 48e85143040b41f9337fd562151665bc47bb714f src/main/python/apache/aurora/common/aurora_job_key.py a0bc6e5674b6c91442b5619f2dd93afa1aa62e30 src/main/python/apache/aurora/common/auth/auth_module.py c055036ef2fcfa47fc7e592a284d1d83fe21dc8f src/main/python/apache/aurora/common/auth/auth_module_manager.py 53b2a3100a094905b3bf093dd7513aaceaadb074 src/main/python/apache/aurora/config/schema/base.py 4a086b31802a0362a6855390dd0d5b431b3a9551 src/main/python/apache/aurora/config/thrift.py 4cc0f0757df6cae387a1f2c293e361dac95e5914 src/main/python/apache/aurora/executor/common/task_info.py 29a05be18febf1a75914b60bc84ad1bd3d629bb1 src/main/python/apache/aurora/executor/executor_vars.py f358fe5a220e57842f7fbf3d83ffeff35bc9a41e src/main/python/apache/aurora/executor/gc_executor.py e860a5808ff8c2f2ffc4070d52af5533209b7e59 src/main/python/apache/thermos/testing/runner.py 0ef4cac3cfb16db91be2eac349852d989fdf4e3f src/main/thrift/org/apache/aurora/gen/BUILD dce379cedc0fe025e59dbed6186f650a58bc42c2 src/main/thrift/org/apache/aurora/gen/api.thrift 32596d3da535226e521109a2ae4e5ee112999642 src/test/python/apache/aurora/admin/test_host_maintenance.py 95497aea3d3f769b2460adbfe7a7b72d775ced6f src/test/python/apache/aurora/client/api/test_disambiguator.py d964d9165190ebb86e3cd2a866f537c707456126 src/test/python/apache/aurora/client/api/test_health_check.py d503281ac492a72f49f17b48ba306bc2135f4d05 src/test/python/apache/aurora/client/api/test_instance_watcher.py
Re: Review Request 20583: upgrade aurora repo to newer pants and commons
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/#review41345 --- Ship it! Ship It! - Jake Farrell On April 24, 2014, 1:33 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/ --- (Updated April 24, 2014, 1:33 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Pins twitter.common on 0.3.0 (save twitter.common.python which is released out of band.) Upgrades aurora to twitter.pants 0.0.18 which uses twitter.common.python==0.5.1 and produces wheels. Updates the thrift python namespaces so that the autogenerated python artifacts do not clobber each other. Diffs - 3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f BUILD c075158c7104db84c9eacfd83262e8fd7f120a4c build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 pants 56847307fcffb244c1debb14f2250564a9174955 pants.ini 5e85d50bc488b2b153a437b946b425f2b512b30e src/main/python/apache/aurora/admin/host_maintenance.py 6a21ddeb4203a07a04360f68c4a338fe3da52c70 src/main/python/apache/aurora/client/api/__init__.py ecc3742411b9fed73d6e4cea43da1bc25e2ae97e src/main/python/apache/aurora/client/api/command_runner.py f7605f40b5c4ec864a1bae68649f282268260528 src/main/python/apache/aurora/client/api/health_check.py de7dc69d798e2b90844e95501b4375f90f6e5f94 src/main/python/apache/aurora/client/api/instance_watcher.py d7db426e6ac712e69eb18a10b6e4cb2da4509aa9 src/main/python/apache/aurora/client/api/job_monitor.py 537e417e074468e169062b73ab207331c51d6a30 src/main/python/apache/aurora/client/api/quota_check.py c58bc4bfac47f85f674af15845b06d9f2294fe57 src/main/python/apache/aurora/client/api/restarter.py d060c1b27af2864a33e6524e58b81fe767ec2e98 src/main/python/apache/aurora/client/api/scheduler_client.py d0e0821a8e8ad38302678ecf686a6028300ebe22 src/main/python/apache/aurora/client/api/sla.py c381de4f1c8eb289efedce9a4efe93d44f44ff62 src/main/python/apache/aurora/client/api/updater.py 9739af025b810c48f10f65edc2c10da88a8b1a2a src/main/python/apache/aurora/client/base.py a33e65ce2b455148d4944d20bbff638dfca7d34a src/main/python/apache/aurora/client/cli/context.py 957c788c8b073c3711b81a3d56b29b926c717eaa src/main/python/apache/aurora/client/cli/jobs.py 0534bdf72a332caa606dd3a7ca743a59e03738ef src/main/python/apache/aurora/client/cli/quota.py 80f7817890c383fec78811ece7d88e90829b067e src/main/python/apache/aurora/client/cli/task.py e4ee77ede119fc1e3bd196293965073405bb48b3 src/main/python/apache/aurora/client/commands/admin.py 3765a2eb85c1782f0b86d46bec50043d908bb09f src/main/python/apache/aurora/client/commands/core.py 67c061eace86b7a28d2c3ae03e23c7d77fc7957f src/main/python/apache/aurora/client/config.py 855f7091837695658fbcd9003f7f85ee28aacde7 src/main/python/apache/aurora/client/hooks/hooked_api.py 48e85143040b41f9337fd562151665bc47bb714f src/main/python/apache/aurora/common/aurora_job_key.py a0bc6e5674b6c91442b5619f2dd93afa1aa62e30 src/main/python/apache/aurora/common/auth/auth_module.py c055036ef2fcfa47fc7e592a284d1d83fe21dc8f src/main/python/apache/aurora/common/auth/auth_module_manager.py 53b2a3100a094905b3bf093dd7513aaceaadb074 src/main/python/apache/aurora/config/schema/base.py 4a086b31802a0362a6855390dd0d5b431b3a9551 src/main/python/apache/aurora/config/thrift.py 4cc0f0757df6cae387a1f2c293e361dac95e5914 src/main/python/apache/aurora/executor/common/task_info.py 29a05be18febf1a75914b60bc84ad1bd3d629bb1 src/main/python/apache/aurora/executor/executor_vars.py f358fe5a220e57842f7fbf3d83ffeff35bc9a41e src/main/python/apache/aurora/executor/gc_executor.py e860a5808ff8c2f2ffc4070d52af5533209b7e59 src/main/python/apache/thermos/testing/runner.py 0ef4cac3cfb16db91be2eac349852d989fdf4e3f src/main/thrift/org/apache/aurora/gen/BUILD dce379cedc0fe025e59dbed6186f650a58bc42c2 src/main/thrift/org/apache/aurora/gen/api.thrift 32596d3da535226e521109a2ae4e5ee112999642 src/test/python/apache/aurora/admin/test_host_maintenance.py 95497aea3d3f769b2460adbfe7a7b72d775ced6f src/test/python/apache/aurora/client/api/test_disambiguator.py d964d9165190ebb86e3cd2a866f537c707456126 src/test/python/apache/aurora/client/api/test_health_check.py d503281ac492a72f49f17b48ba306bc2135f4d05 src/test/python/apache/aurora/client/api/test_instance_watcher.py f001ba45ca12332c9a2e18ff5348a0e6ce276926 src/test/python/apache/aurora/client/api/test_job_monitor.py 4ab8a5d68f55c9ace7a9e845edcca5db08990e25 src/test/python/apache
Re: Review Request 20650: Exclude reports directory from idea project.
On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
build.gradle, line 338
https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338
Can we add dist/ to this list?
Jake Farrell wrote:
+1 with dist added
Bill Farner wrote:
You cannot exclude dist/, since our generated code lands beneath dist
(see comment immediately above this line). We could put generated source
elsewhere, but i don't want to do that without more careful thought (Kevin
had the idea to use a subproject for code generation, which might be a better
route).
Bill Farner wrote:
Is it possible then to exclude everything but the generated-src in dist?
Yes! My first attempt was to list and filter the children of dist/.
However, this doesn't work if dist/reports or dist/test-results don't exist
yet (which would be the case if you ran ./gradlew idea on a fresh clone).
Maxim Khutornenko wrote:
This looks promising
(http://stackoverflow.com/questions/16702126/how-to-specify-intellij-exclude-directories-using-gradle):
buildDir.listFiles({d,f-f != 'generated-sources'} as
FilenameFilter).each {excludeDirs += it}} // Exclude each buildDir child
(except generating-source).
excludeDirs = []
// Exclude everything in dist except the generated-src
buildDir.listFiles({dir,name - name != 'generated-src'} as
FilenameFilter).each { excludeDirs += it }
- Jake
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---
On April 24, 2014, 5:05 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/
---
(Updated April 24, 2014, 5:05 a.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository: aurora
Description
---
IDEA indexes non-excluded directories in dist. This makes indexing take much
longer than necesary, and causes bogus results when searching for usages of
symbols. This fixes (the majority, at least) both issues.
Diffs
-
build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411
Diff: https://reviews.apache.org/r/20650/diff/
Testing
---
IDEA no longer goes into as much of an indexing frenzy after running
./gradlew build, and searching for symbols does not turn up javadoc HTML and
test results.
Thanks,
Bill Farner
Re: Review Request 20678: Remove unused mootools dependency
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20678/#review41365 --- Ship it! Ship It! - Jake Farrell On April 24, 2014, 6:46 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20678/ --- (Updated April 24, 2014, 6:46 p.m.) Review request for Aurora, Jake Farrell and Brian Wickman. Bugs: AURORA-147 https://issues.apache.org/jira/browse/AURORA-147 Repository: aurora Description --- Remove unused mootools dependency While looking through our dependencies I noticed we don't use this anymore. Diffs - src/main/python/apache/thermos/observer/http/assets/mootools-core.js 959afa4a01cfd185c14f8189165bdbde9afee733 Diff: https://reviews.apache.org/r/20678/diff/ Testing --- git grep mootools Thanks, Kevin Sweeney
Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20027/#review41436 --- Ship it! Ship It! - Jake Farrell On April 9, 2014, 2:31 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20027/ --- (Updated April 9, 2014, 2:31 a.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-234 https://issues.apache.org/jira/browse/AURORA-234 Repository: aurora Description --- AURORA-234: Consider using markdown-style tables instead of HTML Diffs - docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 Diff: https://reviews.apache.org/r/20027/diff/ Testing --- Generated the Aurora site using Middleman. Everything renders correctly, though I've updated the Jira ticket with a comparison between the two rendered tables. Commit on Github: https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97 Thanks, Dan Norris
Re: Review Request 20571: Replace sed command with linux and OSX-friendly perl expression.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20571/#review41054 --- Ship it! Whats the bug associated with this? other than that +1 - Jake Farrell On April 22, 2014, 7:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20571/ --- (Updated April 22, 2014, 7:55 p.m.) Review request for Aurora and Jake Farrell. Repository: aurora Description --- Replace sed command with linux and OSX-friendly perl expression. Some context discussion here: http://stackoverflow.com/questions/2320564/variations-of-sed-between-osx-and-gnu-linux Diffs - examples/vagrant/test_tutorial.sh 1b745b817feffc955fd6fce34eeeb520663302fb Diff: https://reviews.apache.org/r/20571/diff/ Testing --- I can now successfully run this script on OS X 10.9 and Ubuntu 13.10. Thanks, Bill Farner
Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/#review40990 --- Ship it! Ship It! - Jake Farrell On April 21, 2014, 7:47 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/ --- (Updated April 21, 2014, 7:47 p.m.) Review request for Aurora, Jake Farrell and Maxim Khutornenko. Bugs: AURORA-299 https://issues.apache.org/jira/browse/AURORA-299 Repository: aurora Description --- Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster. Diffs - docs/tutorial.md 64981a7a4cef35036ad660142fe15fd95e1b6068 examples/vagrant/provision-dev-cluster.sh ec9554356cd789d308a5adce4784b04abe64ab95 Diff: https://reviews.apache.org/r/20238/diff/ Testing --- $ time vagrant up ... real 13m59.641s user 0m16.606s sys 0m5.275s (Previously this was ~20 min on my 2011 macbook air.) $ sh examples/vagrant/test_tutorial.sh Checking scheduler health...PASS Checking observer health...PASS Checking master health...PASS Checking slave health...PASS Running create command...PASS Waiting to observe FAILED task...PASS Running update command...PASS Waiting to observe RUNNING task...PASS Running killall command...PASS Thanks, Bill Farner
Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/#review40852 --- build.gradle https://reviews.apache.org/r/20238/#comment74093 New version of bootstrapThrift is in trunk examples/vagrant/provision-dev-cluster.sh https://reviews.apache.org/r/20238/#comment74094 we can put the deb in our svn repo if you would prefer that examples/vagrant/provision-dev-cluster.sh https://reviews.apache.org/r/20238/#comment74095 No longer need the flag based on bootstrapThrift changes in trunk - Jake Farrell On April 10, 2014, 10:44 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/ --- (Updated April 10, 2014, 10:44 p.m.) Review request for Aurora, Jake Farrell and Maxim Khutornenko. Bugs: AURORA-299 https://issues.apache.org/jira/browse/AURORA-299 Repository: aurora Description --- Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster. Diffs - build.gradle cdcc0158079bc91b5c10fad4e7c80d2f98da227f docs/tutorial.md 64981a7a4cef35036ad660142fe15fd95e1b6068 examples/vagrant/provision-dev-cluster.sh ec9554356cd789d308a5adce4784b04abe64ab95 Diff: https://reviews.apache.org/r/20238/diff/ Testing --- $ time vagrant up ... real 13m59.641s user 0m16.606s sys 0m5.275s (Previously this was ~20 min on my 2011 macbook air.) $ sh examples/vagrant/test_tutorial.sh Checking scheduler health...PASS Checking observer health...PASS Checking master health...PASS Checking slave health...PASS Running create command...PASS Waiting to observe FAILED task...PASS Running update command...PASS Waiting to observe RUNNING task...PASS Running killall command...PASS Thanks, Bill Farner
Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/#review40853 --- +1 with changes mentioned - Jake Farrell On April 10, 2014, 10:44 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/ --- (Updated April 10, 2014, 10:44 p.m.) Review request for Aurora, Jake Farrell and Maxim Khutornenko. Bugs: AURORA-299 https://issues.apache.org/jira/browse/AURORA-299 Repository: aurora Description --- Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster. Diffs - build.gradle cdcc0158079bc91b5c10fad4e7c80d2f98da227f docs/tutorial.md 64981a7a4cef35036ad660142fe15fd95e1b6068 examples/vagrant/provision-dev-cluster.sh ec9554356cd789d308a5adce4784b04abe64ab95 Diff: https://reviews.apache.org/r/20238/diff/ Testing --- $ time vagrant up ... real 13m59.641s user 0m16.606s sys 0m5.275s (Previously this was ~20 min on my 2011 macbook air.) $ sh examples/vagrant/test_tutorial.sh Checking scheduler health...PASS Checking observer health...PASS Checking master health...PASS Checking slave health...PASS Running create command...PASS Waiting to observe FAILED task...PASS Running update command...PASS Waiting to observe RUNNING task...PASS Running killall command...PASS Thanks, Bill Farner
Re: Review Request 20246: AURORA-299: use system thrift if available
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20246/ --- (Updated April 19, 2014, 3:35 a.m.) Review request for Aurora and Bill Farner. Changes --- sorry for the delay, addressed all comments (nice call with .execute().text.trim(), hadnt thought of that route) Bugs: AURORA-299 https://issues.apache.org/jira/browse/AURORA-299 Repository: aurora Description --- AURORA-299: use system thrift if available Updates gradle bootstrapThrift to use a system installed Thrift if available and if it is the same version we are currently using. Diffs (updated) - build.gradle ea488414d366ece89ba25e42b98f6ad7ddbf3378 Diff: https://reviews.apache.org/r/20246/diff/ Testing --- ran build with and without Thrift installed Thanks, Jake Farrell
Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/ --- (Updated April 17, 2014, 4 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- instead of including this as an Aurora specific rbt extension i've made it generic and published it on pypi Bugs: AURORA-323 https://issues.apache.org/jira/browse/AURORA-323 Repository: aurora Description --- AURORA-323:Add ability to merge in github pull requests similar to rbt Created a new extension for rbt which adds a new github subcommand to preview and merge/commit available pull requests. Adds text to the commit message so when github mirrors the given commit the pull request will automatically be closed. Diffs (updated) - .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 Diff: https://reviews.apache.org/r/20407/diff/ Testing --- Preview a pull request patch ./rbt github -p 7 Commit a pull request ./rbt github -c 7 Thanks, Jake Farrell
Re: Review Request 20377: Use git-describe to generate version number.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20377/#review40478 --- Thoughts on moving all the repeated calls in each BUILD file to ./pants and exporting as an env var? build.gradle looks fine, only issue is that source releases typically will not have .git included with them so we can not use git describe for the source release. Should change so that if git describe fails then it falls through to .auroraversion - Jake Farrell On April 15, 2014, 9:23 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20377/ --- (Updated April 15, 2014, 9:23 p.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-320 https://issues.apache.org/jira/browse/AURORA-320 Repository: aurora Description --- Use git-describe to generate version number instead of .auroraversion. Diffs - build.gradle ea488414d366ece89ba25e42b98f6ad7ddbf3378 src/main/python/apache/aurora/client/BUILD 118c4a080b2aac88f1fb6365787b3bb55a665bea src/main/python/apache/aurora/common/BUILD 4646c05972b678371e9b030e042b8899568b8374 src/main/python/apache/aurora/config/BUILD d7467280843e3c5f9f16e46258a12b07b7b99f49 src/main/python/apache/aurora/executor/BUILD 9f0cad0244c46d3175b492f65b37e1cb0619aa34 src/main/python/apache/thermos/BUILD 19b242dba75017e57a25def26530fffcf0c758a6 src/main/python/apache/thermos/common/BUILD a256f2e015c2984adc8aa34c3a7e99a50a978083 src/main/python/apache/thermos/config/BUILD b0806057db4d221467a29ff5c2761113e7b1030c src/main/python/apache/thermos/core/BUILD 77bd289cdfe8ffa17a011e7d4d8debe44d45310a src/main/python/apache/thermos/monitoring/BUILD 448baadf641bf44d28e91b4d0c5f6303f4ae62e7 src/main/python/apache/thermos/observer/BUILD 79168825d1fd5660a01a8b229a765149bc84b358 src/main/thrift/org/apache/aurora/gen/BUILD dce379cedc0fe025e59dbed6186f650a58bc42c2 src/main/thrift/org/apache/thermos/BUILD 2765575b3c29cfed4dea64e0132443a9874ce83c Diff: https://reviews.apache.org/r/20377/diff/ Testing --- ./gradlew assemble = dist/libs/aurora-0.3.0-209-g31ec70b.jar ./build-support/release/make-python-sdists = dist/apache.aurora.client-0.3.0-209-g31ec70b.tar.gz echo 'also marks dirty' DISCLAIMER ./gradlew assemble = dist/libs/aurora-0.3.0-209-g31ec70b-dirty.jar ./build-support/release/make-python-sdists = dist/apache.aurora.client-0.3.0-209-g31ec70b-dirty.tar.gz Thanks, Kevin Sweeney
Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-323 https://issues.apache.org/jira/browse/AURORA-323 Repository: aurora Description --- AURORA-323:Add ability to merge in github pull requests similar to rbt Created a new extension for rbt which adds a new github subcommand to preview and merge/commit available pull requests. Adds text to the commit message so when github mirrors the given commit the pull request will automatically be closed. Diffs - .gitignore cd7bc6dd122fd3490568fe5b2a68d59cfff7fbff build-support/rbt/rbt-github/rbt_github/__init__.py PRE-CREATION build-support/rbt/rbt-github/rbt_github/command.py PRE-CREATION build-support/rbt/rbt-github/setup.py PRE-CREATION rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 Diff: https://reviews.apache.org/r/20407/diff/ Testing --- Preview a pull request patch ./rbt github -p 7 Commit a pull request ./rbt github -c 7 Thanks, Jake Farrell
Re: Review Request 20188: Update end-to-end test for single-node cluster
On April 10, 2014, 4:53 p.m., Bill Farner wrote: This is one of several non-jenkins tests that seems easy to neglect. Do you think it's worth creating a test-all.sh somewhere, and push for that being proven green in the 'Testing done' section of reviews? Kevin Sweeney wrote: As far as I know this is the only non-Jenkins test and we are actively looking for support to run it from Jenkins (https://issues.apache.org/jira/browse/AURORA-127). end-to-end and AURORA-14 are the only ones I know of that we currently dont test for in jenkins - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20188/#review40032 --- On April 10, 2014, 1:29 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20188/ --- (Updated April 10, 2014, 1:29 a.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-315 https://issues.apache.org/jira/browse/AURORA-315 Repository: aurora Description --- Update end-to-end test for single-node cluster Diffs - src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora 65c561dd069d5b0732f5368030d1f954ec19a8a2 src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora e7b76a733105acf76aa301eb07b9da6df72bc270 src/test/sh/org/apache/aurora/e2e/test_common.sh 4ad91e6f72ae9942565c32c950c996dbf2bf09b0 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b3292f4ec25936ff6f576518ac9814c14a9610b4 Diff: https://reviews.apache.org/r/20188/diff/ Testing --- vagrant destroy -f ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney
Review Request 20246: AURORA-299: use system thrift if available
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20246/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-299 https://issues.apache.org/jira/browse/AURORA-299 Repository: aurora Description --- AURORA-299: use system thrift if available Updates gradle bootstrapThrift to use a system installed Thrift if available and if it is the same version we are currently using. Diffs - build.gradle cdcc0158079bc91b5c10fad4e7c80d2f98da227f Diff: https://reviews.apache.org/r/20246/diff/ Testing --- ran build with and without Thrift installed Thanks, Jake Farrell
Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/#review40116 --- build.gradle https://reviews.apache.org/r/20238/#comment72976 I had a slightly different approach to this that automated the bootstrapThrift check and usage that did not depend on a flag. put up as a separate review so we could compare notes https://reviews.apache.org/r/20246/ examples/vagrant/provision-dev-cluster.sh https://reviews.apache.org/r/20238/#comment72974 could put this into the Aurora svn and pull from there or use this path until I can get Thrift into a more standard install location examples/vagrant/provision-dev-cluster.sh https://reviews.apache.org/r/20238/#comment72975 I dont think that we need this flag, have a slightly different patch for build.gradle which automates the check and building of Thrift, will throw it up for review - Jake Farrell On April 10, 2014, 10:44 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/ --- (Updated April 10, 2014, 10:44 p.m.) Review request for Aurora, Jake Farrell and Maxim Khutornenko. Bugs: AURORA-299 https://issues.apache.org/jira/browse/AURORA-299 Repository: aurora Description --- Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster. Diffs - build.gradle cdcc0158079bc91b5c10fad4e7c80d2f98da227f docs/tutorial.md 64981a7a4cef35036ad660142fe15fd95e1b6068 examples/vagrant/provision-dev-cluster.sh ec9554356cd789d308a5adce4784b04abe64ab95 Diff: https://reviews.apache.org/r/20238/diff/ Testing --- $ time vagrant up ... real 13m59.641s user 0m16.606s sys 0m5.275s (Previously this was ~20 min on my 2011 macbook air.) $ sh examples/vagrant/test_tutorial.sh Checking scheduler health...PASS Checking observer health...PASS Checking master health...PASS Checking slave health...PASS Running create command...PASS Waiting to observe FAILED task...PASS Running update command...PASS Waiting to observe RUNNING task...PASS Running killall command...PASS Thanks, Bill Farner
Re: Review Request 19955: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests
On April 2, 2014, 8:18 p.m., Jake Farrell wrote: build-support/jenkins/build_mesos.sh, line 25 https://reviews.apache.org/r/19955/diff/1/?file=546083#file546083line25 Should be downloaded from Apache url http://www.us.apache.org/dist/thrift/$MESOS_VERSION/ ha, sorry, reflex typing there. url should be http://www.us.apache.org/dist/mesos/$MESOS_VERSION/ - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19955/#review39342 --- On April 2, 2014, 7:37 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19955/ --- (Updated April 2, 2014, 7:37 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-14 https://issues.apache.org/jira/browse/AURORA-14 Repository: aurora Description --- add TODO to build_mesos regarding mirror. codify .mesosversion. add an executor jenkins build script that fetches mesos core. Diffs - .mesosversion PRE-CREATION 3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f build-support/jenkins/build_executor.sh PRE-CREATION build-support/jenkins/build_mesos.sh PRE-CREATION build.gradle 109c193da3324bd5534b409bfabb6aeb0adda7b1 Diff: https://reviews.apache.org/r/19955/diff/ Testing --- still running the build Thanks, Brian Wickman
Review Request 19796: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19796/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-145 https://issues.apache.org/jira/browse/AURORA-145 Repository: aurora Description --- AURORA-145:Test dependencies leak into distribution Moves testing dependencies out of main src into test. Diffs - build.gradle f10f22cb27dca28d1087a03b12d0defcaf1a7836 src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java Diff: https://reviews.apache.org/r/19796/diff/ Testing --- Was initially waiting on AURORA-132 for this. ran build-support/jenkins/build.sh and created dists with no issues. Thanks, Jake Farrell
Re: Review Request 19462: [AURORA-282] add gradle target distDeb
On March 28, 2014, 11:14 p.m., Bill Farner wrote: I'm slightly concerned over further expanding the installation requirements for developing on aurora. So far we've made efforts to minimize this (gradle wrapper, building thrift on the fly). Jake - can you think of a sane way to add this feature such that new developers can still use this feature without another external software requirement? outside of creating and maintaing the debian control files and packaging within a vagrant image fpm is the easiest and the most common for this. perhaps this would be better off as a script and we automatically pull in the deps and manage it that way rather than via gradle - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19462/#review38965 --- On March 27, 2014, 1:23 p.m., Damien Hardy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19462/ --- (Updated March 27, 2014, 1:23 p.m.) Review request for Aurora and Jake Farrell. Bugs: AURORA-282 https://issues.apache.org/jira/browse/AURORA-282 Repository: aurora Description --- Add a gradle target distDeb producing a deb package using fpm gradle plugin Should be use also to produce rpm package. Diffs - .gitignore 7e43385 build.gradle f3b packaging/debian/control/postinstall PRE-CREATION packaging/debian/control/postuninstall PRE-CREATION packaging/debian/control/preuninstall PRE-CREATION packaging/debian/default/aurora-scheduler PRE-CREATION packaging/debian/init.d/aurora-scheduler PRE-CREATION Diff: https://reviews.apache.org/r/19462/diff/ Testing --- Thanks, Damien Hardy
Review Request 19710: AURORA-78: automate and enforce release workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19710/ --- Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-78 https://issues.apache.org/jira/browse/AURORA-78 Repository: aurora Description --- AURORA-78: automate and enforce release workflow Adds scripts to generate the CHANGELOG from JIRA, create the release candidate, generate the release candidate VOTE email draft, generate the release from the release candidate and the RESULT VOTE email draft. docs/committers.md added with process flow details. Diffs - CHANGELOG PRE-CREATION build-support/release/changelog PRE-CREATION build-support/release/release PRE-CREATION build-support/release/release-candidate PRE-CREATION build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b docs/committers.md PRE-CREATION docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 Diff: https://reviews.apache.org/r/19710/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 19627: Updates documentation to specify template, adds headers to pages that needed them, cleans up whitespace, and makes markdown for headers consistent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19627/#review38514 --- docs/README.md https://reviews.apache.org/r/19627/#comment70755 Can remove all of these yaml headers in the markdown documentation and just use the following in config.rb to map the layout page /documentation/*, :layout = documentation - Jake Farrell On March 25, 2014, 7:57 p.m., Dave Lester wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19627/ --- (Updated March 25, 2014, 7:57 p.m.) Review request for Aurora. Repository: aurora Description --- Updates documentation to specify template, adds headers to pages that needed them, cleans up whitespace, and makes markdown for headers consistent. Diffs - docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b docs/developing-aurora-scheduler.md 95bf47278b4cf040ed902e43a151fe9fae19bfc5 docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 docs/resourceisolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887 docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53 Diff: https://reviews.apache.org/r/19627/diff/ Testing --- Thanks, Dave Lester
Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution
On March 21, 2014, 2:52 p.m., Bill Farner wrote: Jake - do you agree with discarding this in favor of https://reviews.apache.org/r/17750/? Was waiting on Kevin to commit that and then was going to rebase the other changes that I did for this against his https://reviews.apache.org/r/17750 - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review38101 --- On Feb. 7, 2014, 1:45 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/ --- (Updated Feb. 7, 2014, 1:45 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-145 https://issues.apache.org/jira/browse/AURORA-145 Repository: aurora Description --- AURORA-145:Test dependencies leak into distribution First part of Aurora-145 which makes easy mock and zookeeper testing part of the test compile only. Part two will be to look at 3rd party dependencies and see what we can do to make the dist smaller. Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java 041d1f9937672df64864be09bbc4fd2a38b9b1ab src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 6cfaf39ee41862d088ab9747b7820da3f5014a0c src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a Diff: https://reviews.apache.org/r/17818/diff/ Testing --- ran all unit tests with no failures Thanks, Jake Farrell
Re: Review Request 19462: [AURORA-282] add gradle target distDeb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19462/#review37895 --- build.gradle https://reviews.apache.org/r/19462/#comment69672 Plugins imports should be alphabetical build.gradle https://reviews.apache.org/r/19462/#comment69673 Dependency classpath import should be alphabetical build.gradle https://reviews.apache.org/r/19462/#comment69675 shouldnt this be in /usr/local/lib build.gradle https://reviews.apache.org/r/19462/#comment69677 Is this needed since fileArgs default to '.'? build.gradle https://reviews.apache.org/r/19462/#comment69676 Extra options should also include --license = Apache 2.0 License, --maintainer = Apache Aurora Developers d...@aurora.incubator.apache.org, --vendor=Apache Aurora, --version=$version, --description=Apache Aurora, build.gradle https://reviews.apache.org/r/19462/#comment69674 Please move packaging dir to build-support/packaging Will run through the scrips and review them when i have a change to test and run. At quick glance looks like some spacing is off and there are some extra comments. Thanks again for the work on this - Jake Farrell On March 20, 2014, 3:43 p.m., Damien Hardy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19462/ --- (Updated March 20, 2014, 3:43 p.m.) Review request for Aurora and Jake Farrell. Bugs: AURORA-282 https://issues.apache.org/jira/browse/AURORA-282 Repository: aurora Description --- Add a gradle target distDeb producing a deb package using fpm gradle plugin Should be use also to produce rpm package. Diffs - build.gradle f3b packaging/debian/default/aurora-scheduler PRE-CREATION packaging/debian/init.d/aurora-scheduler PRE-CREATION packaging/postinstall PRE-CREATION packaging/postuninstall PRE-CREATION packaging/preuninstall PRE-CREATION Diff: https://reviews.apache.org/r/19462/diff/ Testing --- Thanks, Damien Hardy
Re: Review Request 18926: Aurora-102: Add failOnVersionConfict() to scheduler build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18926/ --- (Updated March 10, 2014, 4:22 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Updated Summary (updated) - Aurora-102: Add failOnVersionConfict() to scheduler build Bugs: AURORA-102 https://issues.apache.org/jira/browse/AURORA-102 Repository: aurora Description (updated) --- Aurora-102: Add failOnVersionConfict() to scheduler build Adds resolution strategy to compile time to detect and fail if any dependency versions have conflicts. Diffs (updated) - build.gradle 9b8827ea05932620ebac4929838c158e853d73ae Diff: https://reviews.apache.org/r/18926/diff/ Testing --- ran local build with protobuf dependency set to 2.4.1 FAILURE: Build failed with an exception. * What went wrong: Could not resolve all dependencies for configuration ':compile'. A conflict was found between the following modules: - com.google.protobuf:protobuf-java:2.4.1 - com.google.protobuf:protobuf-java:2.5.0 changed to version 2.5.0 BUILD SUCCESSFUL Thanks, Jake Farrell
Re: Review Request 18926: Aurora-102: Add failOnVersionConfict() to scheduler build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18926/ --- (Updated March 10, 2014, 9 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Added comments and updated junit version to simplify for upstream fixes on dependency collisions later Bugs: AURORA-102 https://issues.apache.org/jira/browse/AURORA-102 Repository: aurora Description --- Aurora-102: Add failOnVersionConfict() to scheduler build Adds resolution strategy to compile time to detect and fail if any dependency versions have conflicts. Diffs (updated) - build.gradle 9b8827ea05932620ebac4929838c158e853d73ae src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 50c76df6cc5f3d6e8072bc23ac6570dda3aabcbd Diff: https://reviews.apache.org/r/18926/diff/ Testing --- ran local build with protobuf dependency set to 2.4.1 FAILURE: Build failed with an exception. * What went wrong: Could not resolve all dependencies for configuration ':compile'. A conflict was found between the following modules: - com.google.protobuf:protobuf-java:2.4.1 - com.google.protobuf:protobuf-java:2.5.0 changed to version 2.5.0 BUILD SUCCESSFUL Thanks, Jake Farrell
Re: Review Request 18546: Renamed Quota to ResourceAggregate.
On Feb. 27, 2014, 2:54 a.m., Maxim Khutornenko wrote: This change needs to be split into at least 3 checkins to ensure proper upgrade story: - thrift changes along with scheduler changes: dual write in storage.thrift and StorageBackfill to ensure smooth deploy rollback - client changes to switch to the new thrift fields - final cleanup of the old quota fields. Let's sync offline to discuss details. Let's sync offline to discuss details. please use the dev@ list or comment on the ticket - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35590 --- On Feb. 27, 2014, 2:44 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 27, 2014, 2:44 a.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-105 https://issues.apache.org/jira/browse/AURORA-105 Repository: aurora Description --- Updated client to use the new struct. The client tests fail on my laptop. So, muted the failing assertion for now and added AURORA-237. Diffs - build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java a2008758f25d33dc000834ff0d77cba2352013ed src/main/java/org/apache/aurora/scheduler/http/Quotas.java 5f7e34ee1b09fc139ae5eb41fc68a716d555721f src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 6ff70af3975eeaf7bd3efd62eac29bc84b411b1d src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java c8985351fb21c010d3ae5fde5d00f25e77076b37 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 0e286d8d822759169a11d363f09f5322408a103c src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 9868abc2c3d216ccb7d7749df739e0a898df737d src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 9da3c3e9a1bd732633da8afdda89484f5f4475cb src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970 src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java e3dffe080e3f46bff8eae23591da7a79b5237564 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 42c405ac43b6676b737c8e46a4f09bddcbeb9bed src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java cb0ba508605cd2e98da83ef656a516e6c6e2d244 src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java b9bb4bb7a0f2892f29877e070d80cb900365453a src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/python/apache/aurora/client/api/__init__.py 37b7f428677c7f668079373d9a40e3a104c78e3b src/main/python/apache/aurora/client/api/quota_check.py 7de02c43438075629ff9ef93c79d8d7ecfb884c1 src/main/python/apache/aurora/client/api/sla.py 131c357d60fd00740b51055f555d56c599124d15 src/main/python/apache/aurora/client/api/updater.py 924e6d6138b3a192ff42c31588665985f8eb7d13 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/main/thrift/org/apache/aurora/gen/storage.thrift f138c74b2790612d932d330087c6d6d8c24d1570 src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java e366026df7d8d4e1e356889eefaa6fba1aa2e612 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 82e17df016b0f1ad39f8817abe065394edb9f656 src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java c785b1c83ea2b530566050a80214861b3b5b47da src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java a07f3c98a72b3fccb1e1091ffa6bcafedde30247 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 69dadaf08e0c2771a0820406e8ed0c3778a83066 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 4a2d39d8b25c4a6b161c47d6ba7068d74f8a60e0
Re: Review Request 18580: Upgrade mesos to 0.16.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/#review35685 --- Ship it! Ship It! - Jake Farrell On Feb. 27, 2014, 6:53 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/ --- (Updated Feb. 27, 2014, 6:53 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-240 https://issues.apache.org/jira/browse/AURORA-240 Repository: aurora Description --- Upgrade mesos to 0.16.0 Diffs - 3rdparty/python/BUILD 2c7646ced42a4215267291f566726a46e41575d9 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 docs/deploying-aurora-scheduler.md 1718f8923ae33e3cac6f88fa54cef582e2f2342c examples/scheduler/scheduler-local.sh e1e394e5259686f30dc14856a455abf6197a26b0 examples/vagrant/provision-aurora-scheduler.sh 894a4d20a9084c7eb6bc3acf70d7c45d0052ca8d examples/vagrant/provision-dev-environment.sh 7fc11bf523a054f6d068cf676e87bb043d854a25 examples/vagrant/provision-mesos-master.sh 6e8a923b829b6665751cf81353d89467fdd28da5 examples/vagrant/provision-mesos-slave.sh ef9180e40ac714d12d412c3e705b2e4dbad42ca2 Diff: https://reviews.apache.org/r/18580/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
On Feb. 27, 2014, 11:04 p.m., Kevin Sweeney wrote: build.gradle, lines 251-260 https://reviews.apache.org/r/18537/diff/1/?file=504979#file504979line251 Rather than give up if /usr/bin/python isn't =2.6,3, shouldn't it instead check for python2.7 and python2.6 on PATH (similar to https://github.com/apache/incubator-aurora/blob/master/build-support/virtualenv#L6-L13 ). this check appears to only ensure that the python script used in the gradle build (thrift_wrapper_codegen.py) is able to run and that call uses whatever python on the path and does not use the python27 or python26 https://github.com/apache/incubator-aurora/blob/master/build.gradle#L241 thrift_wrapper_codegen.py is only used in the java build right now and probably should be migrated over to a gradle task/plugin so python is not needed, but that should be created and tackled in another ticket if needed - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/#review35721 --- On Feb. 26, 2014, 10:06 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated Feb. 26, 2014, 10:06 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs - build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 18528: Make markdown TOC and anchors more plaintext-friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/#review3 --- Ship it! Ship It! - Jake Farrell On Feb. 26, 2014, 7:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/ --- (Updated Feb. 26, 2014, 7:07 p.m.) Review request for Aurora, Maxim Khutornenko and Tom Galloway. Repository: aurora Description --- Used this guy to spit out the TOC: http://doctoc.herokuapp.com/ Diffs - docs/configurationreference.md 3c76d594f2564e77912bd07b33a9ae0a6bbf8a11 Diff: https://reviews.apache.org/r/18528/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_cleanup/docs/configurationreference.md Thanks, Bill Farner
Re: Review Request 18294: Update gradle wrapper to 1.11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18294/#review35019 --- Ship it! Would say that what we have here now is good and if this comes up as an issue we can either automate adding a license header at that time with the gradle-license-plugin or remove gradlew and add a bootstrap script to generate it (and adding gradle* to the gitignore) - Jake Farrell On Feb. 20, 2014, 5:50 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18294/ --- (Updated Feb. 20, 2014, 5:50 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Release notes for intervening versions: http://www.gradle.org/docs/1.9/release-notes http://www.gradle.org/docs/1.10/release-notes http://www.gradle.org/docs/1.11/release-notes Also added the 'project-report' plugin, which can generate a nice HTML dependency report (added in 1.9). $ ./gradlew htmlDependencyReport $ open dist/reports/project/dependencies/index.html Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d gradle/wrapper/gradle-wrapper.properties 23ea6e137f8d386bf9cea7776dc7bf6849982345 gradlew b6fd1324f692cd66635e29eff3e8736f6c0be43c Diff: https://reviews.apache.org/r/18294/diff/ Testing --- ./gradlew clean build Thanks, Bill Farner
Re: Review Request 17771: AURORA-193: Fix license plugin
On Feb. 6, 2014, 5:23 a.m., Jake Farrell wrote:
The new patch does not modify the gradle-license-plugin sourceSet as
intended, it ends up using the default of sourceSet.all in the plugin which
grabs all resources, dist, and 3rdparty dirs. Digging into the code the
license plugin extends SourceTask, which has the setSource function to
replace all sourceSets within the SourceTask, leveraging this for any
License task type we can set the paths we want to use and this fixes the
issue.
testing done: rm -rf .gradle ./gradlew clean build
Changes needed to make are:
tasks.withType(nl.javadude.gradle.plugins.license.License).each {
licenseTask -
licenseTask.setSource files($projectDir/src/main/java,
$projectDir/src/test/java)
}
license {
header rootProject.file('config/checkstyle/apache.header')
strictCheck true
skipExistingHeaders true
ext.year = Calendar.getInstance().get(Calendar.YEAR)
}
new review submitted with these updates: https://reviews.apache.org/r/18316/
- Jake
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17771/#review33762
---
On Feb. 6, 2014, 1:55 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17771/
---
(Updated Feb. 6, 2014, 1:55 a.m.)
Review request for Aurora, Jake Farrell and Maxim Khutornenko.
Bugs: AURORA-193
https://issues.apache.org/jira/browse/AURORA-193
Repository: aurora
Description
---
Copy sourceSets instead of mutating it.
Diffs
-
build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
Diff: https://reviews.apache.org/r/17771/diff/
Testing
---
./gradlew clean build
Thanks,
Kevin Sweeney
Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available.
On Feb. 20, 2014, 2:05 a.m., Maxim Khutornenko wrote: dist/generated-src/gen-java/.empty, line 1 https://reviews.apache.org/r/18297/diff/1/?file=498504#file498504line1 Any chance these could be replaced by a something like createPath task that the idea task would dependOn? More: http://www.gradle.org/docs/current/userguide/more_about_tasks.html Kevin Sweeney wrote: +1, the current approach is giving me some gentoo-related flashbacks Agree, dist dir should not be included in the src, having a task to check and add these would be a better approach - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/#review34965 --- On Feb. 20, 2014, 1:43 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/ --- (Updated Feb. 20, 2014, 1:43 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I tried to put relevant context in a comment in build.gradle, so please read that for background on this change. I've also added placeholder files for the gen-java and gen-js directories. This is because the idea plugin will not include source directories that do not exist. Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d dist/generated-src/gen-java/.empty PRE-CREATION dist/generated-src/gen-js/.empty PRE-CREATION Diff: https://reviews.apache.org/r/18297/diff/ Testing --- Several orderings of invoking: rm aurora.iml git clean -fdx ./gradlew idea Thanks, Bill Farner
Re: Review Request 18294: Update gradle wrapper to 1.11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18294/#review34980
---
build.gradle
https://reviews.apache.org/r/18294/#comment65373
We should add the version of gradle in use as a task to make sure that if
the wrapper is regenerated it always uses the same set version (
http://www.apache.org/dev/release.html#what)
task wrapper(type: Wrapper) {
gradleVersion = '1.11'
}
- Jake Farrell
On Feb. 20, 2014, 12:24 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18294/
---
(Updated Feb. 20, 2014, 12:24 a.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository: aurora
Description
---
Release notes for intervening versions:
http://www.gradle.org/docs/1.9/release-notes
http://www.gradle.org/docs/1.10/release-notes
http://www.gradle.org/docs/1.11/release-notes
Also added the 'project-report' plugin, which can generate a nice HTML
dependency report (added in 1.9).
$ ./gradlew htmlDependencyReport
$ open dist/reports/project/dependencies/index.html
Diffs
-
build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
gradle/wrapper/gradle-wrapper.jar 667288ad6c2b3b87c990ece1267e56f0bcbf3622
gradle/wrapper/gradle-wrapper.properties
23ea6e137f8d386bf9cea7776dc7bf6849982345
Diff: https://reviews.apache.org/r/18294/diff/
Testing
---
./gradlew clean build
Thanks,
Bill Farner
Review Request 17818: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-145 https://issues.apache.org/jira/browse/AURORA-145 Repository: aurora Description --- AURORA-145:Test dependencies leak into distribution First part of Aurora-145 which makes easy mock and zookeeper testing part of the test compile only. Part two will be to look at 3rd party dependencies and see what we can do to make the dist smaller. Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java d8c40222809f525ce485a002873f1fe9dedc2748 src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java 041d1f9937672df64864be09bbc4fd2a38b9b1ab src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 6cfaf39ee41862d088ab9747b7820da3f5014a0c src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a Diff: https://reviews.apache.org/r/17818/diff/ Testing --- ran all unit tests with no failures Thanks, Jake Farrell
Review Request 17768: AURORA-193: License header cleanup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17768/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-193 https://issues.apache.org/jira/browse/AURORA-193 Repository: aurora Description --- AURORA-193: License header cleanup Reverting the gradle license header plugin from commit b493b91. The sourceSet exludes is modifying the global sourceSet and causing the tests to break. Diffs - build.gradle 5b98659b9cb93a25f0f196285910cf6afb416072 Diff: https://reviews.apache.org/r/17768/diff/ Testing --- $ ./gradlew clean build --stacktrace make: Nothing to be done for `all'. All checksums match. :clean :about :bootstrapThrift UP-TO-DATE :generateSources :compileGeneratedJava Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. :processGeneratedResources UP-TO-DATE :generatedClasses :compileJava Note: Writing file:/Users/jake.farrell/sandbox/apache/aurora/trunk/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :assemble :checkstyleMain :compileTestJava :processTestResources :testClasses :checkstyleTest :test :jacocoTestReport Coverage report generated: file:Users/jcf/sandbox/apache/aurora/trunk/dist/reports/jacoco/test/html/index.html :check :build BUILD SUCCESSFUL Thanks, Jake Farrell
Review Request 17717: License header cleanup introduced in a584410c.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17717/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- License header cleanup introduced in a584410c. Diffs - build-support/thrift/Makefile c009890465323c022596aab84553bd00659dba9b config/checkstyle/checkstyle.xml 071e40c52c4f770902fb1c79002198ef35f2cf41 src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java c450276dfaf1f676f63ce55ec37e1d256c993164 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 940dac4e47bd19e48e8226def245a53ad6f19710 Diff: https://reviews.apache.org/r/17717/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review32997 --- src/test/sh/org/apache/aurora/e2e/flask/BUILD https://reviews.apache.org/r/17457/#comment62126 requirements moved to global location in AURORA-30 to 3rdparty/python/BUILD - Jake Farrell On Jan. 28, 2014, 4:24 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Jan. 28, 2014, 4:24 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-80 https://issues.apache.org/jira/browse/aurora-80 Repository: aurora Description --- Got an initial version of the end-to-end test working. Currently creates a job, probes it via the scheduler pages, updates it, and kills it. AURORA-127 will extend this to run multiple instances; AURORA-125 will extend this to use aurora run and aurora ssh to probe the running tasks. Diffs - src/test/sh/org/apache/aurora/e2e/flask/BUILD PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.py PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh PRE-CREATION Diff: https://reviews.apache.org/r/17457/diff/ Testing --- [sun-wukong incubator-aurora (e2e)]$ sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Bringing machine 'devtools' up with 'virtualbox' provider... Bringing machine 'zookeeper' up with 'virtualbox' provider... Bringing machine 'mesos-master' up with 'virtualbox' provider... Bringing machine 'mesos-slave' up with 'virtualbox' provider... Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... [devtools] VirtualBox VM is already running. [zookeeper] VirtualBox VM is already running. [mesos-master] VirtualBox VM is already running. [mesos-slave] VirtualBox VM is already running. [aurora-scheduler] VirtualBox VM is already running. Cloning into '/home/vagrant/test_dev'... done. Already on 'e2e' Already up-to-date. + VIRTUALENV_VERSION=1.10.1 + which python2.7 ++ which python2.7 + PY=/usr/bin/python2.7 + echo 'Using /usr/bin/python2.7' Using /usr/bin/python2.7 + '[' -f build-support/virtualenv-1.10.1/BOOTSTRAPPED ']' + pushd build-support ~/test_dev/build-support ~/test_dev + curl -O https://pypi.python.org/packages/source/v/virtualenv/virtualenv-1.10.1.tar.gz % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 1294k 100 1294k0 0 3261k 0 --:--:-- --:--:-- --:--:-- 3817k + tar zxvf virtualenv-1.10.1.tar.gz virtualenv-1.10.1/ virtualenv-1.10.1/AUTHORS.txt virtualenv-1.10.1/bin/ virtualenv-1.10.1/bin/rebuild-script.py virtualenv-1.10.1/docs/ virtualenv-1.10.1/docs/_theme/ virtualenv-1.10.1/docs/_theme/nature/ virtualenv-1.10.1/docs/_theme/nature/static/ virtualenv-1.10.1/docs/_theme/nature/static/nature.css_t virtualenv-1.10.1/docs/_theme/nature/static/pygments.css virtualenv-1.10.1/docs/_theme/nature/theme.conf virtualenv-1.10.1/docs/conf.py virtualenv-1.10.1/docs/index.rst virtualenv-1.10.1/docs/make.bat virtualenv-1.10.1/docs/Makefile virtualenv-1.10.1/docs/news.rst virtualenv-1.10.1/LICENSE.txt virtualenv-1.10.1/MANIFEST.in virtualenv-1.10.1/PKG-INFO virtualenv-1.10.1/README.rst virtualenv-1.10.1/scripts/ virtualenv-1.10.1/scripts/virtualenv virtualenv-1.10.1/setup.cfg virtualenv-1.10.1/setup.py virtualenv-1.10.1/virtualenv.egg-info/ virtualenv-1.10.1/virtualenv.egg-info/dependency_links.txt virtualenv-1.10.1/virtualenv.egg-info/entry_points.txt virtualenv-1.10.1/virtualenv.egg-info/not-zip-safe virtualenv-1.10.1/virtualenv.egg-info/PKG-INFO virtualenv-1.10.1/virtualenv.egg-info/SOURCES.txt virtualenv-1.10.1/virtualenv.egg-info/top_level.txt virtualenv-1.10.1/virtualenv.py virtualenv-1.10.1/virtualenv_embedded/ virtualenv-1.10.1/virtualenv_embedded/activate.bat virtualenv-1.10.1/virtualenv_embedded/activate.csh virtualenv-1.10.1/virtualenv_embedded/activate.fish virtualenv-1.10.1/virtualenv_embedded/activate.ps1 virtualenv-1.10.1/virtualenv_embedded/activate.sh virtualenv-1.10.1/virtualenv_embedded/activate_this.py virtualenv-1.10.1/virtualenv_embedded/deactivate.bat virtualenv-1.10.1/virtualenv_embedded/distutils-init.py virtualenv-1.10.1/virtualenv_embedded/distutils.cfg virtualenv-1.10.1/virtualenv_embedded/site.py virtualenv-1.10.1/virtualenv_support
Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps
78e74d8dd9ee45b6ecc0574eb87f772d94d06eb0 src/main/python/apache/aurora/executor/BUILD 8037330f47e872785dc667a6dae31307bbedf51e src/main/python/apache/aurora/executor/bin/BUILD 91cc91042c1ad6647d93ba9e537514d10c015c30 src/main/python/apache/aurora/executor/common/BUILD ecbcf464c93de75aa58534988c1b1aad2790dabc src/main/python/apache/thermos/BUILD.thirdparty 5a54f4a5d7bd8774b3ff16e89486fa3ccbbe7cd8 src/main/python/apache/thermos/bin/BUILD 4b2975f3e18d788295901f5d0188ce2818843c04 src/main/python/apache/thermos/common/BUILD 298128621198a1cec90609e1f13d523479184344 src/main/python/apache/thermos/config/BUILD 6fdd55e8fb5ba122923eb56b05efbca6e5069efd src/main/python/apache/thermos/core/BUILD 0e86be73f6b67a5e8ce86fc1b2a67251ef35 src/main/python/apache/thermos/monitoring/BUILD 36dada4473d3213560b0f669f9b63018955824a5 src/main/python/apache/thermos/observer/BUILD 4aead08bfb591f74b7fa4ee1541611031af6aff7 src/main/python/apache/thermos/observer/bin/BUILD d40237f330aec4ae36e5a4973ec94946a93323f4 src/main/python/apache/thermos/observer/http/BUILD 96156f56d373f61bf8cbe2175b1c6fd3ce773eee src/main/python/apache/thermos/testing/BUILD 16f3dbb8c45420b6388a1e8266f3fd49104e771e src/test/python/apache/aurora/admin/BUILD d3820ffb4cff9b43a080580607207f8cb629c2e9 src/test/python/apache/aurora/client/BUILD a61b37ad40af8c5769079944322aa57105af4ccb src/test/python/apache/aurora/client/api/BUILD 5665dad0230bed6046cd2fa87c9eac8e7bffd5b0 src/test/python/apache/aurora/client/cli/BUILD e619d22f8aea783ba1af73ba776c3e82adf5ff5a src/test/python/apache/aurora/client/commands/BUILD a275504c05cbade9973ae74da3d5a991224c64b1 src/test/python/apache/aurora/client/hooks/BUILD 0283838d247447731dc6d2d67c3f8154737de6bb src/test/python/apache/aurora/common/BUILD 9c8931ba58f970e1c3214af711b8359d79b42f3a src/test/python/apache/aurora/config/BUILD b0951e8d7df2710eefcde3230a4fe85c38fdec51 src/test/python/apache/aurora/executor/BUILD 38c11d50cd3d4c859431760468723dfaa2b57b47 src/test/python/apache/aurora/executor/common/BUILD 2b3ee27dd5e45c88af268c93920833e3896b4ccc src/test/python/apache/thermos/common/BUILD 00eb3d2157f174b7113c5edec1189d454a25adbb src/test/python/apache/thermos/config/BUILD e7e1fd8f64243607c0a7c4647afb95c0a3c7d7eb src/test/python/apache/thermos/core/BUILD 2a060f9c7381ebddaf2f84a9b2d72bee8fe03581 Diff: https://reviews.apache.org/r/17419/diff/ Testing --- Ran build-support/jenkins/build.sh and it passes all tests for java and python locally Thanks, Jake Farrell
Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15
On Jan. 21, 2014, 11:32 p.m., Kevin Sweeney wrote: Thanks for taking care of this Bill. Aside: this seems to warrant a linked ticket (reference it on the first line of your commit so that jenkins will comment). Bill Farner wrote: reference it on the first line of your commit I didn't realize this was wired up yet, cool! Do you mean to say that the first line of the summary/description? yes, commits with the first line of AURORA-XXX: description will get picked up by jenkins after running the ci build from a scm change and jenkins will comment back the success of that build on the jira ticket. - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17161/#review32441 --- On Jan. 21, 2014, 11:18 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17161/ --- (Updated Jan. 21, 2014, 11:18 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict. Diffs - build.gradle 00cabb00b81b320ef2c474da759281b3fda24967 Diff: https://reviews.apache.org/r/17161/diff/ Testing --- ./gradlew build I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts. Thanks, Bill Farner
Review Request 17106: AURORA-60:Commit e1aee67 re-creates src/main/python/twitter after namespace change occurring
. SUCCESS src.test.python.apache.thermos.core.test_process . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS Thanks, Jake Farrell
Review Request 17110: AURORA-3:Adding license header to missing files (py, bash, thrift, ...)
src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.bin.test_thermos . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.common.test_planner . SUCCESS src.test.python.apache.thermos.common.test_task_planner . SUCCESS src.test.python.apache.thermos.config.test_schema . SUCCESS src.test.python.apache.thermos.core.test_angry . SUCCESS src.test.python.apache.thermos.core.test_ephemerals . SUCCESS src.test.python.apache.thermos.core.test_failing_runner . SUCCESS src.test.python.apache.thermos.core.test_failure_limit . SUCCESS src.test.python.apache.thermos.core.test_finalization . SUCCESS src.test.python.apache.thermos.core.test_helper . SUCCESS src.test.python.apache.thermos.core.test_process . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS Thanks, Jake Farrell
Re: Review Request 17110: AURORA-3:Adding license header to missing files (py, bash, thrift, ...)
src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.bin.test_thermos . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.common.test_planner . SUCCESS src.test.python.apache.thermos.common.test_task_planner . SUCCESS src.test.python.apache.thermos.config.test_schema . SUCCESS src.test.python.apache.thermos.core.test_angry . SUCCESS src.test.python.apache.thermos.core.test_ephemerals . SUCCESS src.test.python.apache.thermos.core.test_failing_runner . SUCCESS src.test.python.apache.thermos.core.test_failure_limit . SUCCESS src.test.python.apache.thermos.core.test_finalization . SUCCESS src.test.python.apache.thermos.core.test_helper . SUCCESS src.test.python.apache.thermos.core.test_process . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS Thanks, Jake Farrell
Re: Review Request 17110: AURORA-3:Adding license header to missing files (py, bash, thrift, ...)
src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.bin.test_thermos . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.common.test_planner . SUCCESS src.test.python.apache.thermos.common.test_task_planner . SUCCESS src.test.python.apache.thermos.config.test_schema . SUCCESS src.test.python.apache.thermos.core.test_angry . SUCCESS src.test.python.apache.thermos.core.test_ephemerals . SUCCESS src.test.python.apache.thermos.core.test_failing_runner . SUCCESS src.test.python.apache.thermos.core.test_failure_limit . SUCCESS src.test.python.apache.thermos.core.test_finalization . SUCCESS src.test.python.apache.thermos.core.test_helper . SUCCESS src.test.python.apache.thermos.core.test_process . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS Thanks, Jake Farrell
Re: Review Request 17057: Deploying Aurora documentation improvements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17057/#review32204 --- Ship it! Ship It! - Jake Farrell On Jan. 17, 2014, 6:47 p.m., Jeremy Lingmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17057/ --- (Updated Jan. 17, 2014, 6:47 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Deploying Aurora documentation improvements * Update the path examples so they are correct (dist instead of build, handle versioned build file names) * Fix a few markdown formatting issues * Add additional info on the requirements to build a distribution zip file Diffs - docs/deploying-aurora-scheduler.md c11f2a9fd91e6826e227e320aa94a0a529191a3e Diff: https://reviews.apache.org/r/17057/diff/ Testing --- Previewed markdown changes with grip: https://github.com/joeyespo/grip Thanks, Jeremy Lingmann
Re: Review Request 16868: Fix build break caused by a584410.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16868/#review31805 --- Ship it! Ship It! - Jake Farrell On Jan. 14, 2014, 8:53 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16868/ --- (Updated Jan. 14, 2014, 8:53 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Repository: aurora Description --- Fix build break caused by a584410. Diffs - src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9 src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665 Diff: https://reviews.apache.org/r/16868/diff/ Testing --- ./pants src/test/python:all I have a failure on test_ephemerals: src.test.python.apache.thermos.core.test_ephemerals . FAILURE Confirmed that this test fails before the breaking SHA above, so i suspect it's specific to my machine (given that build is green for others). Thanks, Bill Farner
