[Impala-ASF-CR] IMPALA-6805: Show current database in Impala shell prompt

2018-04-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. Patch Set 6: Code-Review+1 Looks good to me. David,

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 6: (1 comment) Nice work!

[Impala-ASF-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9940 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. KUDU-2401:

[Impala-ASF-CR] IMPALA-6817: Clean up Impala privilege model

2018-04-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9942 ) Change subject: IMPALA-6817: Clean up Impala privilege model .. IMPALA-6817: Clean up Impala privilege model When we added support for

[Impala-ASF-CR] IMPALA-6817: Clean up Impala privilege model

2018-04-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/9942 ) Change subject: IMPALA-6817: Clean up Impala privilege model .. IMPALA-6817: Clean up Impala privilege model When we added support for

[Impala-ASF-CR] IMPALA-6817: Clean up Impala privilege model

2018-04-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9942 ) Change subject: IMPALA-6817: Clean up Impala privilege model .. IMPALA-6817: Clean up Impala privilege model When we added support for

[Impala-ASF-CR] IMPALA-6817: Clean up Impala authorization model

2018-04-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9942 Change subject: IMPALA-6817: Clean up Impala authorization model .. IMPALA-6817: Clean up Impala authorization model When we added

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-04-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9085 ) Change subject: IMPALA-6070: Expose using Docker to run tests faster. .. Patch Set 8: Code-Review+2 Carry +2. Rat build failed on

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9085 ) Change subject: IMPALA-6070: Expose using Docker to run tests faster. .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-04-05 Thread Philip Zeyliger (Code Review)
Hello Lars Volker, Taras Bobrovytsky, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9085 to look at the new patch set (#8). Change subject: IMPALA-6070: Expose using Docker to run tests faster.

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 14: Fixed some compiler warnings. I can build with

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#14). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. IMPALA-5893: Remove old kinit code for Impala 3 We've gone through a

[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9941 Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. IMPALA-5893: Remove old kinit code for Impala 3 We've gone through a

[Impala-ASF-CR] IMPALA-6805: Show current database in Impala shell prompt

2018-04-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/9927 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. IMPALA-6805: Show current database in Impala shell prompt

[Impala-ASF-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9940 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 1: Build

[Impala-ASF-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9940 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9940 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9085 ) Change subject: IMPALA-6070: Expose using Docker to run tests faster. .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6810, IMPALA-6814: Skip remote tests that expect a local env

2018-04-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9937 ) Change subject: IMPALA-6810, IMPALA-6814: Skip remote tests that expect a local env .. Patch Set 1: There is only one test case that

[Impala-ASF-CR] IMPALA-6805: Show current database in Impala shell prompt

2018-04-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 13: Actually I think the ASAN build is just slow - not

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 13: Code-Review+2 I'm still in the process of running

[Impala-ASF-CR] [DOCS] Removed old files no longer in use

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9938 ) Change subject: [DOCS] Removed old files no longer in use .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9940 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 1: This is the fix

[Impala-ASF-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9940 Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. KUDU-2401: External TLS

[Impala-ASF-CR] [DOCS] Removed old files no longer in use

2018-04-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9938 ) Change subject: [DOCS] Removed old files no longer in use .. Patch Set 1: Code-Review+2 I verified the changes and did a clean test

[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9929 ) Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528 .. IMPALA-6807: [DOCS] Update the known issue

[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 ) Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528 .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 ) Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528

2018-04-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 ) Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528 .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-04-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. IMPALA-2195: Improper handling of comments in queries This patch

[Impala-ASF-CR] [DOCS] Removed old files no longer in use

2018-04-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9938 Change subject: [DOCS] Removed old files no longer in use .. [DOCS] Removed old files no longer in use Change-Id:

[Impala-ASF-CR] IMPALA-6810, IMPALA-6814: Skip remote tests that expect a local env

2018-04-05 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9937 Change subject: IMPALA-6810, IMPALA-6814: Skip remote tests that expect a local env .. IMPALA-6810, IMPALA-6814: Skip remote tests that

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9085 ) Change subject: IMPALA-6070: Expose using Docker to run tests faster. .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-04-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9085 ) Change subject: IMPALA-6070: Expose using Docker to run tests faster. .. IMPALA-6070: Expose using Docker to run tests faster. Allows

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-04-05 Thread Zach Amsden (Code Review)
Zach Amsden has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. IMPALA-6389: Make '\0' delimited text files work Initially I

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-05 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9928 to look at the new patch set (#2). Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY ..

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-04-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 3: Code-Review+2 Yes, I did - forgot to carry the +2 after

[Impala-ASF-CR] IMPALA-6807: [DOCS] Update the known issue for HDFS-12528

2018-04-05 Thread Alex Rodoni (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9929 to look at the new patch set (#3). Change subject: IMPALA-6807: [DOCS] Update the known issue for HDFS-12528

[Impala-ASF-CR] IMPALA-6549: [DOCS] Update the known issue for HDFS-12528

2018-04-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 ) Change subject: IMPALA-6549: [DOCS] Update the known issue for HDFS-12528 .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6549: [DOCS] Update the known issue for HDFS-12528

2018-04-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9929 ) Change subject: IMPALA-6549: [DOCS] Update the known issue for HDFS-12528 .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 6: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-04-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-05 Thread Zoltan Borok-Nagy (Code Review)
Hello Fredy Wijaya, Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9090 to look at the new patch set (#6). Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 21: (3 comments)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-05 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#21). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 13: (4 comments) Sure, Tim. Thank you for doing local

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#13). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] Loosen hive-exec.jar glob pattern in copy-udfs-udas.sh.

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9925 ) Change subject: Loosen hive-exec.jar glob pattern in copy-udfs-udas.sh. .. Loosen hive-exec.jar glob pattern in

[Impala-ASF-CR] Loosen hive-exec.jar glob pattern in copy-udfs-udas.sh.

2018-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9925 ) Change subject: Loosen hive-exec.jar glob pattern in copy-udfs-udas.sh. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 12: (4 comments) Had some minor comments, but I'm ready