[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 8: (13 comments) Just came across this CR.

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 1: Verified-1 Build

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 3: Verified+1 > It's a whitespace-only change and it compiled. Thanks for

[Impala-ASF-CR] IMPALA-7089: reenable test kudu dml reporting

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10577 ) Change subject: IMPALA-7089: reenable test_kudu_dml_reporting .. Patch Set 2: Code-Review+2 Let's get this test coverage back now

[Impala-ASF-CR] IMPALA-7089: reenable test kudu dml reporting

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10577 ) Change subject: IMPALA-7089: reenable test_kudu_dml_reporting .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 ) Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-7110. Fix errors from error-prone

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix errors from error-prone .. IMPALA-7110. Fix errors from error-prone * Fixes several cases of

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Fix Indents from IMPALA-4970 fixing the mistake in indentation made

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: Fix Indents from IMPALA-4970 .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/10560 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. IMPALA-6956: deflake and logging for

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. IMPALA-7105. Ensure fe tests pass when

[Impala-ASF-CR] IMPALA-7110. Fix errors from error-prone

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix errors from error-prone .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2782: part 2 - Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2018-06-05 Thread Vincent Tran (Code Review)
Hello a...@phdata.io, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10580 to look at the new patch set (#2). Change subject: IMPALA-2782: part 2 - Allow impala-shell to connect directly to impalad when configured with load balancer and

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10611 Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. IMPALA-7128 (part 1) Refactor interfaces for

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. IMPALA-7016: Implement ALTER DATABASE SET OWNER Alters the database

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: -Code-Review We have the kudu_latest_observed_timestamp logic

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Pretty sure this was an OOM due to

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 ) Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7078: Part 2: reduce queue size based on num scanner threads

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10573 to look at the new patch set (#4). Change subject: IMPALA-7078: Part 2: reduce queue size based on num_scanner_threads

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10550 to look at the new patch set (#11). Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

[Impala-ASF-CR] IMPALA-7078: Part 2: reduce queue size based on num scanner threads

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10573 to look at the new patch set (#3). Change subject: IMPALA-7078: Part 2: reduce queue size based on num_scanner_threads

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 ) Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10550 to look at the new patch set (#10). Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

[Impala-ASF-CR] IMPALA-7078: Part 2: reduce queue size based on num scanner threads

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10573 ) Change subject: IMPALA-7078: Part 2: reduce queue size based on num_scanner_threads .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 ) Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10550 to look at the new patch set (#8). Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 ) Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7078: Part 2: reduce queue size based on num scanner threads

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10573 ) Change subject: IMPALA-7078: Part 2: reduce queue size based on num_scanner_threads .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 6: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. IMPALA-7101: Fix race

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10602 to look at the new patch set (#2). Change subject: IMPALA-6956: deflake and logging for query_expiration test ..

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. IMPALA-7106: Print rewritten SQL correctly when

[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 ) Change subject: IMPALA-6035: Add query options to limit thread reservation .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 ) Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans .. Patch Set 7: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting

2018-06-05 Thread Alex Rodoni (Code Review)
Hello Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10457 to look at the new patch set (#4). Change subject: IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting

[Impala-ASF-CR] IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10457 ) Change subject: IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. Patch Set 1: Build started:

[Impala-ASF-CR] Add missing namespace qualifiers

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10608 ) Change subject: Add missing namespace qualifiers .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Add missing namespace qualifiers

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10608 ) Change subject: Add missing namespace qualifiers .. Add missing namespace qualifiers As part of an upcoming rebase of

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 8: (5 comments)

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: Code-Review-2 Please don't merge this until I give it

[Impala-ASF-CR] IMPALA-7110. Fix errors from error-prone

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix errors from error-prone .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7110. Fix errors from error-prone

2018-06-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix errors from error-prone .. Patch Set 2: Code-Review+2 maven profile looks fine. -- To view,

[Impala-ASF-CR] IMPALA-7110. Fix errors from error-prone

2018-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix errors from error-prone .. Patch Set 2: Code-Review+1 (1 comment) Phil, can you +2 this, I'm

[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10512 ) Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. IMPALA-7012: Fix NPE when parsing unexpected

[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10512 ) Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: Another idea that also

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (2 comments) Todd,

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] [experimental] Clang Tidy Diff trial balloon

2018-06-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9751 ) Change subject: [experimental] Clang Tidy Diff trial balloon .. Patch Set 2: Any updates on this? -- To view, visit

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (2 comments)

[Impala-ASF-CR] Guard S3 access check with variable

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10607 ) Change subject: Guard S3 access check with variable .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] Guard S3 access check with variable

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10607 ) Change subject: Guard S3 access check with variable .. Guard S3 access check with variable We've recently seen

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-05 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 8: Philip, can you review this and give a +2 if you

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. IMPALA-7120: remove sonatype repository >From what I can tell, we

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. Patch Set 2: Verified+1 Yep, it worked after I blew away ~/.m2/repository

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (1 comment) thanks for the

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. Patch Set 2: I'll try that also to confirm. -- To view, visit

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. Patch Set 2: Code-Review+2 If this passes the build, it should be good.

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. Patch Set 2: I looked at the mvn logs and it appears that this change

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. IMPALA-7100: [DOCS] Consistent

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. IMPALA-6917: Implement COMMENT ON TABLE/VIEW This patch implements

[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 ) Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs .. Patch Set 5: Hi Vuk, Could you review the

[Impala-ASF-CR] IMPALA-7110. Fix errors from error-prone

2018-06-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10583 to look at the new patch set (#2). Change subject: IMPALA-7110. Fix errors from error-prone

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7110. Fix some warnings from error-prone

2018-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix some warnings from error-prone .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. Patch Set 2: Code-Review+1 Feel free to

[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 ) Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI .. Patch Set 2: Hi Lars, Could you review the patch

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. Patch Set 2: HI Balazs, Could you review my

[Impala-ASF-CR] IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting

2018-06-05 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10457 ) Change subject: IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 5: Tim, please take a look at the

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10601 to look at the new patch set (#5). Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 4: Oops, hold on one second. --

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 3: (3 comments) Tim, could you

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10601 to look at the new patch set (#4). Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: READ_AT_SNAPSHOT was reverted because it caused

[Impala-ASF-CR] Add missing namespace qualifiers

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10608 ) Change subject: Add missing namespace qualifiers .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10606 to look at the new patch set (#2). Change subject: IMPALA-7120: remove sonatype repository ..

[Impala-ASF-CR] Add missing namespace qualifiers

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10608 ) Change subject: Add missing namespace qualifiers .. Patch Set 1: Code-Review+2 Thanks! Seems ok to go in now. -- To view, visit

[Impala-ASF-CR] Add missing namespace qualifiers

2018-06-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10608 Change subject: Add missing namespace qualifiers .. Add missing namespace qualifiers As part of an upcoming rebase of the KRPC code,

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Thanks! Sorry to be pedantic -- To view, visit

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: Build started:

  1   2   >