[Impala-ASF-CR] IMPALA-11948: Remove operation logging from getCatalogServerMetrics

2023-02-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19557 ) Change subject: IMPALA-11948: Remove operation logging from getCatalogServerMetrics .. Patch Set 3: Code-Review+1 Thanks. -- To

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-11948: Remove operation logging from getCatalogServerMetrics

2023-02-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19557 ) Change subject: IMPALA-11948: Remove operation logging from getCatalogServerMetrics .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-11948: Remove operation logging from getCatalogServerMetrics

2023-02-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19557 ) Change subject: IMPALA-11948: Remove operation logging from getCatalogServerMetrics .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 3: Code-Review+1 Thanks, this is fine for me.

[Impala-ASF-CR] IMPALA-11795: Ignore high/low values stats for timestamp columns

2023-02-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 ) Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns .. Patch Set 1: Code-Review+1 Looks good, thanks.

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt flakiness

2023-02-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt flakiness .. Patch Set 7: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt flakiness

2023-02-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt flakiness .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-11803: Fix hitting DCHECK when running union on empty table with MT DOP>1

2023-02-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19474 ) Change subject: IMPALA-11803: Fix hitting DCHECK when running union on empty table with MT_DOP>1 .. Patch Set 6: Code-Review+1

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 2: Code-Review+1 (2 comments) Thanks Quanlong!

[Impala-ASF-CR] IMPALA-11803: Fix hitting DCHECK when running union on empty table with MT DOP>1

2023-02-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19474 ) Change subject: IMPALA-11803: Fix hitting DCHECK when running union on empty table with MT_DOP>1 .. Patch Set 4: (1 comment) Thanks

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-11937: Fix wrong GROUP BY ordinal in PERF AGG-Q10

2023-02-25 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19531 ) Change subject: IMPALA-11937: Fix wrong GROUP BY ordinal in PERF_AGG-Q10 .. Patch Set 1: Code-Review+1 I can give +2 if no-one else

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-24 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19530 ) Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg .. Patch Set 5: Code-Review+1 Thanks Riza. --

[Impala-ASF-CR] IMPALA-11701 Part1: Don't push down predicates if already applied by Iceberg

2023-02-24 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19534 ) Change subject: IMPALA-11701 Part1: Don't push down predicates if already applied by Iceberg .. Patch Set 1: (21 comments)

[Impala-ASF-CR] IMPALA-11943: Mark utf8 string functions with IR ALWAYS INLINE

2023-02-24 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19535 ) Change subject: IMPALA-11943: Mark utf8 string functions with IR_ALWAYS_INLINE .. Patch Set 1: (2 comments) Thanks Quanlong for

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-24 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19530 ) Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-11898: Add query options in the profile if the query failed in planning

2023-02-24 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 ) Change subject: IMPALA-11898: Add query options in the profile if the query failed in planning .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class

2023-02-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 ) Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class .. Patch Set

[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger

2023-02-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18824 ) Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. Patch Set 9: (10 comments)

[Impala-ASF-CR] IMPALA-11606: Add the 'mem-tracker.process.bytes-untracked' metric.

2023-02-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19029 ) Change subject: IMPALA-11606: Add the 'mem-tracker.process.bytes-untracked' metric. .. Patch Set 9: (6 comments)

[Impala-ASF-CR] IMPALA-11803: Impalad hit DCHECK when running union on empty table with MT DOP>1

2023-02-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19474 ) Change subject: IMPALA-11803: Impalad hit DCHECK when running union on empty table with MT_DOP>1 .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 1: Thanks Quanlong, this seems good to me. I

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 8: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-11898: Add query options in the profile if the query failed in planning

2023-02-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 ) Change subject: IMPALA-11898: Add query options in the profile if the query failed in planning .. Patch Set 1: (3 comments) Thank

[Impala-ASF-CR] IMPALA-10111: Fix TestWebPage::test query stmt is flakiness

2023-02-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 ) Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness .. Patch Set 5: (6 comments)

[native-toolchain-CR] IMPALA-11927: Enable frame pointers for snappy and lz4

2023-02-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19521 ) Change subject: IMPALA-11927: Enable frame pointers for snappy and lz4 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-11911: Fix NULL argument handling in Hive GenericUDFs

2023-02-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19499 ) Change subject: IMPALA-11911: Fix NULL argument handling in Hive GenericUDFs .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs

2023-02-21 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 ) Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs .. Patch Set 4: (11 comments)

[Impala-ASF-CR] IMPALA-11908: Parser change for Iceberg metadata querying

2023-02-21 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19483 ) Change subject: IMPALA-11908: Parser change for Iceberg metadata querying .. Patch Set 5: (1 comment) Thanks Tamás!

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

2023-02-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 ) Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

2023-02-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19487 ) Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types .. IMPALA-11869: Use to_string() in PrintValue

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

2023-02-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19487 Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types .. IMPALA-11869: Use to_string() in PrintValue

[Impala-ASF-CR] IMPALA-11908: Parser change for Iceberg metadata querying

2023-02-09 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19483 ) Change subject: IMPALA-11908: Parser change for Iceberg metadata querying .. Patch Set 4: (11 comments)

[Impala-ASF-CR] IMPALA-11834: Error reporting addendum

2023-02-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19481 ) Change subject: IMPALA-11834: Error reporting addendum .. Patch Set 2: Code-Review+2 Thanks. -- To view, visit

[Impala-ASF-CR] IMPALA-11834: Error reporting addendum

2023-02-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19481 ) Change subject: IMPALA-11834: Error reporting addendum .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11895: Need accessor methods for third party extension

2023-02-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19469 ) Change subject: IMPALA-11895: Need accessor methods for third party extension .. Patch Set 1: (1 comment) Can we be sure that we

[Impala-ASF-CR] IMPALA-11834: Error reporting addendum

2023-02-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19481 ) Change subject: IMPALA-11834: Error reporting addendum .. Patch Set 2: (1 comment) Thanks, just a small comment.

[Impala-ASF-CR] IMPALA-11745: Add Hive's ESRI geospatial functions as builtins

2023-02-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 ) Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins .. Patch Set 26: (2 comments)

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

2023-02-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19477 ) Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11845: (Addendum) Don't specify db name in the new struct tests

2023-02-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19470 ) Change subject: IMPALA-11845: (Addendum) Don't specify db name in the new struct tests .. Patch Set 1: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-11745: Add Hive's ESRI geospatial functions as builtins

2023-02-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 ) Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins .. Patch Set 23: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11745: Add Hive's ESRI geospatial functions as builtins

2023-02-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 ) Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins .. Patch Set 22: (2 comments) Looks good, just a few

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-30 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load

2023-01-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 ) Change subject: IMPALA-11285: Deflake timeout in test_async_load .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11872: Fix typo in executor groups flag description

2023-01-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19453 ) Change subject: IMPALA-11872: Fix typo in executor_groups flag description .. Patch Set 1: Is it sure that it is a typo? Here it

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 6: Code-Review+1 -- To

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-27 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. WIP - IMPALA-11828: Incorrect result of joining

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-27 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. WIP - IMPALA-11828: Incorrect result of joining

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19441 ) Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. Patch Set 2: There were some tests that failed in

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-26 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. WIP - IMPALA-11828: Incorrect result of joining

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19441 ) Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11745: Add Hive's ESRI geospatial functions as builtins

2023-01-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 ) Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins .. Patch Set 18: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11745: Add Hive's ESRI geospatial functions as builtins

2023-01-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 ) Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins .. Patch Set 17: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-26 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR] IMPALA-3880: Add list of all tables queried to runtime profile

2023-01-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19401 ) Change subject: IMPALA-3880: Add list of all tables queried to runtime profile .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3880: Add list of all tables queried to runtime profile

2023-01-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19401 ) Change subject: IMPALA-3880: Add list of all tables queried to runtime profile .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-25 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR] IMPALA-11745: Add Hive's ESRI geospatial functions as builtins

2023-01-25 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 ) Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins .. Patch Set 14: (10 comments)

[Impala-ASF-CR] IMPALA-3880: Add list of all tables queried to runtime profile

2023-01-24 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19401 ) Change subject: IMPALA-3880: Add list of all tables queried to runtime profile .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11745: Add Hive's ESRI geospatial functions as builtins

2023-01-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 ) Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins .. Patch Set 13: (20 comments)

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 5: (1 comment)

[Impala-ASF-CR] WIP IMPALA-11718: Improve support for Hive Generic UDFs

2023-01-20 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19177 ) Change subject: WIP IMPALA-11718: Improve support for Hive Generic UDFs .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-20 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 5: (1 comment)

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-20 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19434 Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. WIP - IMPALA-11828: Incorrect result of joining

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-20 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 4: Code-Review+1 (3

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-19 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-19 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 2: (3 comments) Thanks

[Impala-ASF-CR] IMPALA-11626: Handled COMMIT COMPACTION EVENT from HMS

2023-01-19 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19155 ) Change subject: IMPALA-11626: Handled COMMIT_COMPACTION_EVENT from HMS .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-11840: Error with joining unnest with views

2023-01-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19426 ) Change subject: IMPALA-11840: Error with joining unnest with views .. Patch Set 3: Code-Review+2 Carrying Csaba's +2. -- To view,

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11840: Error with joining unnest with views

2023-01-18 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19426 ) Change subject: IMPALA-11840: Error with joining unnest with views .. IMPALA-11840: Error with joining unnest with views Queries fail

[Impala-ASF-CR] IMPALA-11840: Error with joining unnest with views

2023-01-18 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19426 ) Change subject: IMPALA-11840: Error with joining unnest with views .. IMPALA-11840: Error with joining unnest with views Queries fail

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-11840: Error with joining unnest with views

2023-01-17 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19426 Change subject: IMPALA-11840: Error with joining unnest with views .. IMPALA-11840: Error with joining unnest with views Queries fail

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-17 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18958 ) Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-17 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-16 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 4: Code-Review+1

[Impala-ASF-CR] IMPALA-11778: Printing maps may produce invalid json

2023-01-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19364 ) Change subject: IMPALA-11778: Printing maps may produce invalid json .. IMPALA-11778: Printing maps may produce invalid json Impala

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method

2023-01-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 ) Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method .. Patch Set 3: Code-Review+1

[Impala-ASF-CR] IMPALA-10851: Codegen for structs

2023-01-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/18526 ) Change subject: IMPALA-10851: Codegen for structs .. IMPALA-10851: Codegen for structs IMPALA-9495 added support for struct types in

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-01-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. IMPALA-10753: Incorrect length when

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR] IMPALA-3880: Add list of all tables queried to runtime profile

2023-01-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19401 ) Change subject: IMPALA-3880: Add list of all tables queried to runtime profile .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-06 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results

2023-01-06 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19402 ) Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results .. IMPALA-11825: Doc update 4.2.0 breaks web search results We

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-05 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results

2023-01-05 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19402 Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results .. IMPALA-11825: Doc update 4.2.0 breaks web search results

[Impala-ASF-CR] IMPALA-11620: Enable setting 'write.format.default'

2023-01-05 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19221 ) Change subject: IMPALA-11620: Enable setting 'write.format.default' .. Patch Set 3: (2 comments)

[Impala-ASF-CR](asf-site) Add documentation for 4.2.0

2023-01-02 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19367 ) Change subject: Add documentation for 4.2.0 .. Add documentation for 4.2.0 This commit adds documentation for Impala 4.2.0 and updates

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

2023-01-02 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19359 ) Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option .. IMPALA-11799: Fix example of the hs2_fp_format shell

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-16 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

<    2   3   4   5   6   7   8   9   10   11   >