[Impala-ASF-CR] IMPALA-13057: Incorporate tuple/slot information into tuple cache key

2024-05-22 Thread Joe McDonnell (Code Review)
Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21398 to look at the new patch set (#6). Change subject: IMPALA-13057: Incorporate tuple/slot information into tuple cache key

[Impala-ASF-CR] IMPALA-13057: Incorporate tuple/slot information into tuple cache key

2024-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21398 ) Change subject: IMPALA-13057: Incorporate tuple/slot information into tuple cache key .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-13076 Add pstack and jstack to Impala Redhat docker images

2024-05-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21433 ) Change subject: IMPALA-13076 Add pstack and jstack to Impala Redhat docker images .. Patch Set 1: It makes sense to include

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. IMPALA-13020 (part 2): Split

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. IMPALA-13020 (part 1): Change

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. Patch Set 5: Verified+1 Code-Review+2 I'm

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, Riza Suminto, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21420 to look at the new patch set (#3). Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21421 ) Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21421 ) Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. IMPALA-13072: Add retries for s3 uploads to

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: (1 comment) > Also,

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-15 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, Riza Suminto, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21420 to look at the new patch set (#2). Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: (1 comment)

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21421 ) Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. Patch Set 1: > https://gerrit.cloudera.org/c/21341/

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21421 Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. IMPALA-13072: Add retries for s3 uploads to combat

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: I need to take this

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-10 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21367 to look at the new patch set (#5). Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21420 Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. IMPALA-13020 (part 2): Split out

[Impala-ASF-CR] IMPALA-10451: Fix avro table loading failures caused by HIVE-24157

2024-05-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21413 ) Change subject: IMPALA-10451: Fix avro table loading failures caused by HIVE-24157 .. IMPALA-10451: Fix avro table loading

[Impala-ASF-CR] IMPALA-10451: Fix avro table loading failures caused by HIVE-24157

2024-05-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21413 ) Change subject: IMPALA-10451: Fix avro table loading failures caused by HIVE-24157 .. Patch Set 2: Verified+1 This is just a flaky

[Impala-ASF-CR] IMPALA-10451: Fix avro table loading failures caused by HIVE-24157

2024-05-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-10451: Fix avro table loading failures caused by HIVE-24157 .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-12934: Added Calcite parsing files to Impala

2024-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21194 ) Change subject: IMPALA-12934: Added Calcite parsing files to Impala .. IMPALA-12934: Added Calcite parsing files to Impala

[Impala-ASF-CR] IMPALA-12934: Added Calcite parsing files to Impala

2024-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21194 ) Change subject: IMPALA-12934: Added Calcite parsing files to Impala .. Patch Set 10: Code-Review+2 I think long term we will be

[Impala-ASF-CR] IMPALA-10451: Fix avro table loading failures caused by HIVE-24157

2024-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21413 Change subject: IMPALA-10451: Fix avro table loading failures caused by HIVE-24157 .. IMPALA-10451: Fix avro table loading failures

[Impala-ASF-CR] IMPALA-13057: Incorporate tuple/slot information into tuple cache key

2024-05-07 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21398 to look at the new patch set (#4). Change subject: IMPALA-13057: Incorporate tuple/slot information into tuple cache key

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 ) Change subject: IMPALA-12935: First pass on Calcite planner functions .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-12934: Added Calcite parsing files to Impala

2024-05-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21194 ) Change subject: IMPALA-12934: Added Calcite parsing files to Impala .. Patch Set 9: (2 comments) So, I went down a rabbit hole

[Impala-ASF-CR] IMPALA-13020: Change thrift rpc max message size to int64 t

2024-05-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t .. Patch Set 4: (1 comment)

[Impala-ASF-CR] Prototype: IMPALA-13057: Incorporate tuple/slot information to tuple cache key

2024-05-06 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21398 to look at the new patch set (#3). Change subject: Prototype: IMPALA-13057: Incorporate tuple/slot information to tuple cache key

[Impala-ASF-CR] Prototype: Incorporate tuple/slot information to tuple cache key

2024-05-04 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21398 to look at the new patch set (#2). Change subject: Prototype: Incorporate tuple/slot information to tuple cache key

[Impala-ASF-CR] Prototype: Incorporate tuple/slot information to tuple cache key

2024-05-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21398 Change subject: Prototype: Incorporate tuple/slot information to tuple cache key .. Prototype: Incorporate tuple/slot information to

[Impala-ASF-CR] IMPALA-13044: Upgrade bouncycastle to 1.78

2024-05-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21371 ) Change subject: IMPALA-13044: Upgrade bouncycastle to 1.78 .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-13020: Change thrift rpc max message size to int64 t

2024-05-01 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21367 to look at the new patch set (#4). Change subject: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t

[Impala-ASF-CR] IMPALA-13020: Change thrift rpc max message size to int64 t

2024-05-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-13020: Change thrift rpc max message size to int64 t

2024-05-01 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21367 to look at the new patch set (#3). Change subject: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 ) Change subject: IMPALA-12935: First pass on Calcite planner functions .. Patch Set 5: (3 comments) I'm starting to wrap my head

[Impala-ASF-CR] IMPALA-13049: Add dependency management for log4j2 to use 2.18.0

2024-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21379 ) Change subject: IMPALA-13049: Add dependency management for log4j2 to use 2.18.0 .. IMPALA-13049: Add dependency management

[Impala-ASF-CR] IMPALA-12934: Added Calcite parsing files to Impala

2024-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21194 ) Change subject: IMPALA-12934: Added Calcite parsing files to Impala .. Patch Set 8: Code-Review+1 (1 comment) This change looks good

[native-toolchain-CR] IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

2024-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21343 ) Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++ .. IMPALA-13020: Use 64-bit integer for

[native-toolchain-CR] IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

2024-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21343 ) Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++ .. Patch Set 3: Verified+1 This passed and a

[Impala-ASF-CR] IMPALA-13049: Add dependency management for log4j2 to use 2.18.0

2024-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21379 Change subject: IMPALA-13049: Add dependency management for log4j2 to use 2.18.0 .. IMPALA-13049: Add dependency management for log4j2

[native-toolchain-CR] IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

2024-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21343 ) Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++ .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12684: Enable IMPALA COMPRESSED DEBUG INFO by default

2024-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20871 ) Change subject: IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default .. IMPALA-12684: Enable

[Impala-ASF-CR] IMPALA-12934: Added Calcite parsing files to Impala

2024-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21194 ) Change subject: IMPALA-12934: Added Calcite parsing files to Impala .. Patch Set 7: (1 comment)

[Impala-ASF-CR] PROTOTYPE: IMPALA-13020: Change thrift rpc max message size to int64 t

2024-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: PROTOTYPE: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t .. Patch Set 2: (1 comment)

[Impala-ASF-CR] PROTOTYPE: IMPALA-13020: Change thrift rpc max message size to int64 t

2024-04-28 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21367 to look at the new patch set (#2). Change subject: PROTOTYPE: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t

[Impala-ASF-CR] PROTOTYPE: IMPALA-13020: Change thrift rpc max message size to int64 t

2024-04-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21367 Change subject: PROTOTYPE: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t .. PROTOTYPE: IMPALA-13020: Change

[native-toolchain-CR] IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

2024-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21343 ) Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++ .. Patch Set 2: (2 comments) Updated Thrift

[native-toolchain-CR] IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

2024-04-26 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21343 to look at the new patch set (#3). Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

[native-toolchain-CR] IMPALA-12886: Bump GoogleTest version to 1.14.0

2024-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21133 ) Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 .. Patch Set 3: Code-Review+2 This looks good to me -- To view,

[Impala-ASF-CR] IMPALA-12872: Use Calcite for optimization - part 1: simple queries

2024-04-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for optimization - part 1: simple queries .. Patch Set 26: Code-Review+2 Merging this.

[Impala-ASF-CR] IMPALA-12872: Use Calcite for optimization - part 1: simple queries

2024-04-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for optimization - part 1: simple queries .. IMPALA-12872: Use Calcite for

[Impala-ASF-CR] IMPALA-12872: Use Calcite for optimization - part 1: simple queries

2024-04-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for optimization - part 1: simple queries .. Patch Set 26: Code-Review+1 I think this

[Impala-ASF-CR] IMPALA-12872: Use Calcite for optimization - part 1: simple queries

2024-04-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for optimization - part 1: simple queries .. Patch Set 25: (1 comment)

[native-toolchain-CR] IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

2024-04-22 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21343 to look at the new patch set (#2). Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

[native-toolchain-CR] IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

2024-04-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21343 ) Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++ .. Patch Set 1: Here is a better view of the new

[native-toolchain-CR] IMPALA-13020: Use 64-bit integer for Thrift max message size on C++

2024-04-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21343 Change subject: IMPALA-13020: Use 64-bit integer for Thrift max message size on C++ .. IMPALA-13020: Use 64-bit integer for Thrift max

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21171 ) Change subject: IMPALA-12905: Disk-based tuple caching .. IMPALA-12905: Disk-based tuple caching This implements on-disk

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 ) Change subject: IMPALA-12905: Disk-based tuple caching .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-09 Thread Joe McDonnell (Code Review)
Hello Kurt Deschler, Yida Wu, Alexey Serbin, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21171 to look at the new patch set (#10). Change subject: IMPALA-12905: Disk-based tuple caching

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 ) Change subject: IMPALA-12905: Disk-based tuple caching .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-12564: Prevent Hive loading libfesupport.so in the minicluster during TSAN runs

2024-04-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21191 ) Change subject: IMPALA-12564: Prevent Hive loading libfesupport.so in the minicluster during TSAN runs .. Patch Set 5: Code-Review+1

[Impala-ASF-CR] IMPALA-12872: Use Calcite for optimization - part 1: simple queries

2024-04-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for optimization - part 1: simple queries .. Patch Set 18: (7 comments) This is looking

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-08 Thread Joe McDonnell (Code Review)
Hello Kurt Deschler, Yida Wu, Alexey Serbin, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21171 to look at the new patch set (#9). Change subject: IMPALA-12905: Disk-based tuple caching

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 ) Change subject: IMPALA-12905: Disk-based tuple caching .. Patch Set 8: (5 comments)

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 ) Change subject: IMPALA-12905: Disk-based tuple caching .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-05 Thread Joe McDonnell (Code Review)
Hello Kurt Deschler, Yida Wu, Alexey Serbin, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21171 to look at the new patch set (#8). Change subject: IMPALA-12905: Disk-based tuple caching

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-04 Thread Joe McDonnell (Code Review)
Hello Kurt Deschler, Yida Wu, Alexey Serbin, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21171 to look at the new patch set (#7). Change subject: IMPALA-12905: Disk-based tuple caching

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 ) Change subject: IMPALA-12905: Disk-based tuple caching .. Patch Set 6: (13 comments)

[native-toolchain-CR] IMPALA-12697: Set FAIL ON PUBLISH to true by default

2024-03-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21134 ) Change subject: IMPALA-12697: Set FAIL_ON_PUBLISH to true by default .. IMPALA-12697: Set FAIL_ON_PUBLISH to true by default

[native-toolchain-CR] IMPALA-12697: Set FAIL ON PUBLISH to true by default

2024-03-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21134 ) Change subject: IMPALA-12697: Set FAIL_ON_PUBLISH to true by default .. Patch Set 2: Verified+1 Verified that this does what it is

[native-toolchain-CR] IMPALA-12697: Set FAIL ON PUBLISH to true by default

2024-03-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21134 ) Change subject: IMPALA-12697: Set FAIL_ON_PUBLISH to true by default .. Patch Set 2: Code-Review+2 Rebased, carry +2 -- To view,

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-03-28 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21171 to look at the new patch set (#5). Change subject: IMPALA-12905: Disk-based tuple caching

[Impala-ASF-CR] PROTOTYPE: IMPALA-12905: Disk-based tuple caching

2024-03-27 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21171 to look at the new patch set (#4). Change subject: PROTOTYPE: IMPALA-12905: Disk-based tuple caching

[Impala-ASF-CR] IMPALA-12872: Use Calcite for optimization - part 1: simple queries

2024-03-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for optimization - part 1: simple queries .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-12807: Add support for mold linker

2024-03-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21121 ) Change subject: IMPALA-12807: Add support for mold linker .. IMPALA-12807: Add support for mold linker This adds support for

[Impala-ASF-CR] IMPALA-12872: Use Calcite for optimization - part 1: simple queries

2024-03-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for optimization - part 1: simple queries .. Patch Set 12: (6 comments)

[Impala-ASF-CR] IMPALA-12807: Add support for mold linker

2024-03-25 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21121 to look at the new patch set (#3). Change subject: IMPALA-12807: Add support for mold linker

[Impala-ASF-CR] IMPALA-12807: Add support for mold linker

2024-03-25 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21121 to look at the new patch set (#2). Change subject: IMPALA-12807: Add support for mold linker ..

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

2024-03-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21165 ) Change subject: Add RE2 2024-03-01 and Abseil .. Patch Set 3: Verified+1 Internal build succeeded -- To view, visit

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

2024-03-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21165 ) Change subject: Add RE2 2024-03-01 and Abseil .. Add RE2 2024-03-01 and Abseil This adds a build of the latest RE2 release

[native-toolchain-CR] Add libpfm / google benchmark

2024-03-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21164 ) Change subject: Add libpfm / google benchmark .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21164 To

[native-toolchain-CR] Add libpfm / google benchmark

2024-03-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21164 ) Change subject: Add libpfm / google benchmark .. Add libpfm / google benchmark Google benchmark is a framework for writing

[Impala-ASF-CR] IMPALA-12896 (Part 2): JDBC table must be created as external table

2024-03-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21159 ) Change subject: IMPALA-12896 (Part 2): JDBC table must be created as external table .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12564: Prevent Hive loading libfesupport.so in the minicluster during TSAN runs

2024-03-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21191 ) Change subject: IMPALA-12564: Prevent Hive loading libfesupport.so in the minicluster during TSAN runs .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12896 (Part 2): JDBC table must be created as external table

2024-03-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21159 ) Change subject: IMPALA-12896 (Part 2): JDBC table must be created as external table .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-12896 (Part 2): JDBC table must be created as external table

2024-03-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21159 ) Change subject: IMPALA-12896 (Part 2): JDBC table must be created as external table .. Patch Set 3: (1 comment)

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

2024-03-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21165 ) Change subject: Add RE2 2024-03-01 and Abseil .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[native-toolchain-CR] Add libpfm / google benchmark

2024-03-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21164 ) Change subject: Add libpfm / google benchmark .. Patch Set 2: (2 comments)

[native-toolchain-CR] Add libpfm / google benchmark

2024-03-22 Thread Joe McDonnell (Code Review)
Hello Laszlo Gaal, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21164 to look at the new patch set (#3). Change subject: Add libpfm / google benchmark .. Add libpfm / google benchmark

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

2024-03-22 Thread Joe McDonnell (Code Review)
Hello Laszlo Gaal, Michael Smith, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21165 to look at the new patch set (#2). Change subject: Add RE2 2024-03-01 and Abseil .. Add RE2

[Impala-ASF-CR] IMPALA-12872: Use Calcite for optimization - part 1: simple queries

2024-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 ) Change subject: IMPALA-12872: Use Calcite for optimization - part 1: simple queries .. Patch Set 10: (9 comments)

[native-toolchain-CR] PROTOTYPE: Build shared libs for googletest

2024-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21177 Change subject: PROTOTYPE: Build shared libs for googletest .. PROTOTYPE: Build shared libs for googletest This also bumps googletest

[native-toolchain-CR] IMPALA-12915: Build shared library of GTest

2024-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21161 ) Change subject: IMPALA-12915: Build shared library of GTest .. Patch Set 3: Be sure to rebase this, as we have been batching up a few

[native-toolchain-CR] IMPALA-12915: Build shared library of GTest

2024-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21161 ) Change subject: IMPALA-12915: Build shared library of GTest .. Patch Set 3: Code-Review+2 This looks good to me -- To view, visit

[native-toolchain-CR] IMPALA-12915: Build shared library of GTest

2024-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21161 ) Change subject: IMPALA-12915: Build shared library of GTest .. Patch Set 2: Code-Review+1 > (1 comment) > > > We've got a couple

[native-toolchain-CR] IMPALA-12915: Build shared library of GTest

2024-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21161 ) Change subject: IMPALA-12915: Build shared library of GTest .. Patch Set 2: (1 comment)

[native-toolchain-CR] IMPALA-12915: Build shared library of GTest

2024-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21161 ) Change subject: IMPALA-12915: Build shared library of GTest .. Patch Set 1: (1 comment) We've got a couple things in flight. This

  1   2   3   4   5   6   7   8   9   10   >