[Impala-ASF-CR] test-with-docker: work with git worktree

2018-05-09 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10335 ) Change subject: test-with-docker: work with git worktree .. Patch Set 1: Why don't you put JIRA on the commit msg? -- To view, visit

[Impala-ASF-CR] test-with-docker: exit properly on failures

2018-05-09 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10318 ) Change subject: test-with-docker: exit properly on failures .. Patch Set 1: Why don't you put JIRA on the commit msg? -- To view,

[Impala-ASF-CR] IMPALA-6923:Update scripts in benchmark folder to store workload and few minor updates

2018-05-09 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 ) Change subject: IMPALA-6923:Update scripts in benchmark folder to store workload and few minor updates .. Patch Set 8: (3 comments)

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 2: Why don't you put JIRA in your commit

[Impala-ASF-CR] IMPALA-6635: Enable disk spill encryption by default

2018-05-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10345 ) Change subject: IMPALA-6635: Enable disk spill encryption by default .. Patch Set 3: Is this change a part of the fix for 6635? I was

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6995: avoid DCHECK in TimestampParse::Parse()

2018-05-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10349 ) Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-04-30 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 19: Sorry for the delay. I am facing a minor problem in

[Impala-ASF-CR] IMPALA-3282: [DOCS] Adds regexp escape built-in function

2018-04-24 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10174 Change subject: IMPALA-3282: [DOCS] Adds regexp_escape built-in function .. IMPALA-3282: [DOCS] Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-04-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: @Gabor and Attila, thanks for your

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-04-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 19: @Alex, thank you for the comment. The problem was

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2018-04-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 8: @Csaba, thanks for your review. I have been

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-04-02 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 19: (2 comments) Hi Alex, Sorry for the late response.

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

2018-03-28 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9030 ) Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-03-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: Sure! Thank you. -- To view, visit

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-03-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 9: (1 comment) Thanks for your comment.

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-03-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 4: Thank you all for the reviews. -- To view, visit

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-02-26 Thread Kim Jin Chul (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9391 to look at the new patch set (#2). Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC ..

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-26 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 19: Thanks for your comment. I've resolved the conflicts

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-26 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#19). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-02-21 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9391 Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. IMPALA-5607: Add additional units to EXTRACT,

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2018-02-21 Thread Kim Jin Chul (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8747 to look at the new patch set (#8). Change subject: IMPALA-5993: Fix the file offset in value parsing error ..

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-21 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 10: (5 comments) Thanks for your comments. I've

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-21 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#10). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 18: Applied the update for the expected results -- To

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-18 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#18). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 1: (10 comments) Thanks for the comments. I've

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-18 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#9). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 17: Code-Review-1 Let me look into the failure. -- To

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 15: (1 comment) Applied the update.

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#16). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 14: (1 comment) Applied the update. I realized that

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-12 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#15). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 13: Applied the update. -- To view, visit

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#14). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2018-02-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 7: Hi Lars, You may be busy. It would be great if

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 13: (1 comment) The timed out issue at Jenkins should be

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#13). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-01 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 12: Code-Review-1 My change seems to be related with the

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 9: Thank you all for the reviews. -- To view, visit

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-01-30 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 8: (5 comments) Applied the update.

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-01-30 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#8). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-29 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#10). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-29 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-01-25 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 7: (5 comments) Applied the update. @Gabor, I

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-25 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9030 ) Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: > In addition to the text that

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-25 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#9). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-01-25 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 1: (5 comments) Applied the update.

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-01-25 Thread Kim Jin Chul (Code Review)
Hello John Russell, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9031 to look at the new patch set (#2). Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-23 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 7: (12 comments) Applied update.

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-23 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#8). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 11: Thanks you all for the reviews! -- To

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#10). Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-23 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 6: (22 comments) Applied the update.

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-23 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#7). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 8: (1 comment) Applied the update.

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#9). Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#7). Change subject: IMPALA-3282: Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#6). Change subject: IMPALA-3282: Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#8). Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-16 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#5). Change subject: IMPALA-3282: Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2018-01-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 7: (25 comments) Hi Lars, Sorry I thought I

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 7: Docs: https://gerrit.cloudera.org/#/c/9031/ -- To

[Impala-ASF-CR] [DOCS] Doc for MURMUR HASH() function

2018-01-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9031 Change subject: [DOCS] Doc for MURMUR_HASH() function .. [DOCS] Doc for MURMUR_HASH() function Change-Id:

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 12: docs:

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-16 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#7). Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end .. Patch Set 6: (11 comments)

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-15 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-15 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#6). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2018-01-15 Thread Kim Jin Chul (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8747 to look at the new patch set (#7). Change subject: IMPALA-5993: Fix the file offset in value parsing error ..

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 7: I appreciate all your reviews! -- To view, visit

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 4: Code-Review-1 (1 comment) Performance comparison:

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 12: I appreciate all your reviews! @John,

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-10 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#6). Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-10 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#5). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-07 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#5). Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-07 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-07 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#4). Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-07 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#3). Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 9: Tho examples for INSERT/UPSERT are

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-06 Thread Kim Jin Chul (Code Review)
Hello Attila Jeges, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8893 to look at the new patch set (#5). Change subject: IMPALA-3651: Adds murmur_hash() built-in function

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-06 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#4). Change subject: IMPALA-3282: Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-06 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#3). Change subject: IMPALA-3282: Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-04 Thread Kim Jin Chul (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8893 to look at the new patch set (#4). Change subject: IMPALA-3651: Adds murmur_hash() built-in function

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-04 Thread Kim Jin Chul (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8893 to look at the new patch set (#3). Change subject: IMPALA-3651: Adds murmur_hash() built-in function

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-04 Thread Kim Jin Chul (Code Review)
Hello John Russell, Dimitris Tsirogiannis, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#9). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-3060: draft: Supports IS [NOT] NULL feature for complex type

2018-01-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has abandoned this change. ( http://gerrit.cloudera.org:8080/8710 ) Change subject: IMPALA-3060: draft: Supports IS [NOT] NULL feature for complex type .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-5341: [draft] introduce row-size match

2018-01-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8542 Change subject: IMPALA-5341: [draft] introduce row-size match .. IMPALA-5341: [draft] introduce row-size match Change-Id:

[Impala-ASF-CR] IMPALA-3060: draft: Supports IS [NOT] NULL feature for complex type

2018-01-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8710 ) Change subject: IMPALA-3060: draft: Supports IS [NOT] NULL feature for complex type .. IMPALA-3060: draft: Supports IS [NOT] NULL feature

  1   2   3   >