[Impala-ASF-CR] IMPALA-5341: [draft] introduce row-size match

2018-01-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has abandoned this change. ( http://gerrit.cloudera.org:8080/8542 ) Change subject: IMPALA-5341: [draft] introduce row-size match .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8542 To unsubscribe,

[Impala-ASF-CR] Added the "SET ROW FORMAT" option to the "ALTER TABLE" command.

2018-01-03 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: Added the "SET ROW FORMAT" option to the "ALTER TABLE" command. .. Patch Set 1: (11 comments)

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2017-12-20 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. IMPALA-3282: Adds regexp_escape built-in function Escapes the

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2017-12-20 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8900 Change subject: IMPALA-3282: Adds regexp_escape built-in function .. IMPALA-3282: Adds regexp_escape built-in function Escapes the

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2017-12-20 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. IMPALA-3651: Adds murmur_hash() built-in function murmur_hash relys

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2017-12-20 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8893 Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. IMPALA-3651: Adds murmur_hash() built-in function murmur_hash relys

[Impala-ASF-CR] IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

2017-12-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8829 ) Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp .. Patch Set 5: Jim, thanks for your review! --

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2017-12-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2017-12-18 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#2). Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

2017-12-17 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8829 ) Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

2017-12-17 Thread Kim Jin Chul (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8829 to look at the new patch set (#3). Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2017-12-17 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 3: @Dimitris, thanks for your review of my initial change

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2017-12-17 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#4). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 7: (2 comments) Thanks for the finding

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-16 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#8). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-15 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 16: @Zoltan, Tim, I appreciate your review! -- To

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#14). Change subject: IMPALA-4664: Unexpected string conversion in Shell

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#13). Change subject: IMPALA-4664: Unexpected string conversion in Shell

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 12: Code-Review-1 Let me take a look at the failure and

[Impala-ASF-CR] IMPALA-3942: Fix unexpected conversion of string literal in front-end

2017-12-14 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix unexpected conversion of string literal in front-end .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#6). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#11). Change subject: IMPALA-4664: Unexpected string conversion in Shell

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has abandoned this change. ( http://gerrit.cloudera.org:8080/8639 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Abandoned The problem in IMPALA-4664 should be also resolved by the change:

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#5). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#10). Change subject: IMPALA-2640: Make a given command case-sensitive

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 10: (6 comments)

[Impala-ASF-CR] IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8829 ) Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8829 to look at the new patch set (#2). Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

[Impala-ASF-CR] IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8829 Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp .. IMPALA-5754: Rollback the exclusion of clang-tidy

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 22: @Jim, I pushed a fix for rollback of the exclusion

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 22: @Jim, Michael and Attila, I appreciate your

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#4). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: (4 comments) Thanks a lot for your

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#3). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-12 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 20: Thanks for the information. I would like to exclude

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-12 Thread Kim Jin Chul (Code Review)
Hello Michael Ho, Jim Apple, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8355 to look at the new patch set (#20). Change subject: IMPALA-5754: Improve randomness of rand()/random()

[Impala-ASF-CR] IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT

2017-12-12 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: Code-Review-1 (2 comments) Currently I count

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 9: (3 comments) Thanks for your advice.

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#9). Change subject: IMPALA-2640: Make a given command case-sensitive

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#8). Change subject: IMPALA-2640: Make a given command case-sensitive

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (6 comments) Thanks for your answers.

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 17: Fixed. Build failure happened due to missing

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-11 Thread Kim Jin Chul (Code Review)
Hello Michael Ho, Jim Apple, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8355 to look at the new patch set (#17). Change subject: IMPALA-5754: Improve randomness of rand()/random()

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-11 Thread Kim Jin Chul (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8747 to look at the new patch set (#5). Change subject: IMPALA-5993: Fix the file offset in value parsing error ..

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-10 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#7). Change subject: IMPALA-2640: Make a given command case-sensitive

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 4: Code-Review-1 Lars, as I mentioned in the JIRA,

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8639 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello Michael Ho, Jim Apple, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8355 to look at the new patch set (#16). Change subject: IMPALA-5754: Improve randomness of rand()/random()

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 15: The third party library is officially released

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello Michael Ho, Jim Apple, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8355 to look at the new patch set (#15). Change subject: IMPALA-5754: Improve randomness of rand()/random()

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#6). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#5). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-2640: Maintain the command given by an user

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#3). Change subject: IMPALA-2640: Maintain the command given by an user

[Impala-ASF-CR] IMPALA-2640: Maintain the command given by an user

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Maintain the command given by an user .. Patch Set 2: Code-Review-1 I found that "ctrl + d" (EOF) does not

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-05 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-05 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#4). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-2640: Maintain the command given by an user

2017-12-05 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#2). Change subject: IMPALA-2640: Maintain the command given by an user

[Impala-ASF-CR] IMPALA-2640: Maintain the command given by an user

2017-12-05 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Maintain the command given by an user .. Patch Set 1: Confirmed green on local for the test:

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8747 to look at the new patch set (#3). Change subject: IMPALA-5993: Fix the file offset in value parsing error ..

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 2: Code-Review-1 (6 comments) Preparing a

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8747 to look at the new patch set (#2). Change subject: IMPALA-5993: Fix the file offset in value parsing error ..

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: Code-Review-1 (4 comments) As I commented,

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8747 Change subject: IMPALA-5993: Fix the file offset in value parsing error .. IMPALA-5993: Fix the file offset in value parsing error This

[Impala-ASF-CR] IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT

2017-12-03 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT .. Patch Set 1: Thanks for the information. Let me

[Impala-ASF-CR] IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT

2017-12-03 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT .. Patch Set 1: @John, as far as I know you're in

[Impala-ASF-CR] IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT

2017-12-03 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT .. Patch Set 1: May I add the new syntax to docs? --

[Impala-ASF-CR] IMPALA-3060: draft: Supports IS [NOT] NULL feature for complex type

2017-11-30 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8710 Change subject: IMPALA-3060: draft: Supports IS [NOT] NULL feature for complex type .. IMPALA-3060: draft: Supports IS [NOT] NULL

[Impala-ASF-CR] IMPALA-4506: Do not display some intro message if --quiet is set

2017-11-30 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 ) Change subject: IMPALA-4506: Do not display some intro message if --quiet is set .. Patch Set 7: @Jim and Philip, I appreciate your

[Impala-ASF-CR] IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT

2017-11-28 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8676 Change subject: IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT .. IMPALA-4168: Adopt Oracle-style hint placement for

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-11-28 Thread Kim Jin Chul (Code Review)
Hello Tim Armstrong, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8639 to look at the new patch set (#4). Change subject: IMPALA-4664: Unexpected string conversion in Shell

[Impala-ASF-CR] IMPALA-5146: Fix inconsitent results at FROM UNIXTIME()

2017-11-28 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8629 ) Change subject: IMPALA-5146: Fix inconsitent results at FROM_UNIXTIME() .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4506: Do not display some intro message if --quiet is set

2017-11-28 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 ) Change subject: IMPALA-4506: Do not display some intro message if --quiet is set .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4506: Do not display some intro message if --quiet is set

2017-11-28 Thread Kim Jin Chul (Code Review)
Hello Jim Apple, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8613 to look at the new patch set (#5). Change subject: IMPALA-4506: Do not display some intro message if --quiet is set

[Impala-ASF-CR] IMPALA-5146: Fix inconsitent results at FROM UNIXTIME()

2017-11-28 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8629 ) Change subject: IMPALA-5146: Fix inconsitent results at FROM_UNIXTIME() .. Patch Set 4: (2 comments) Thanks Dan for the notification.

[Impala-ASF-CR] IMPALA-4506: Do not display some intro message if --quiet is set

2017-11-27 Thread Kim Jin Chul (Code Review)
Hello Jim Apple, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8613 to look at the new patch set (#4). Change subject: IMPALA-4506: Do not display some intro message if --quiet is set

[Impala-ASF-CR] IMPALA-4506: Do not display some intro message if --quiet is set

2017-11-27 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 ) Change subject: IMPALA-4506: Do not display some intro message if --quiet is set .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark

2017-11-27 Thread Kim Jin Chul (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8641 to look at the new patch set (#2). Change subject: IMPALA-3784: Fixed broken status-benchmark .. IMPALA-3784: Fixed

[Impala-ASF-CR] IMPALA-5146: Fix inconsitent results at FROM UNIXTIME()

2017-11-27 Thread Kim Jin Chul (Code Review)
Hello Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8629 to look at the new patch set (#3). Change subject: IMPALA-5146: Fix inconsitent results at FROM_UNIXTIME()

[Impala-ASF-CR] IMPALA-4506: Do not display some intro message if --quiet is set

2017-11-27 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 ) Change subject: IMPALA-4506: Do not display some intro message if --quiet is set .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-11-23 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8639 Change subject: IMPALA-4664: Unexpected string conversion in Shell .. IMPALA-4664: Unexpected string conversion in Shell Impala shell

[Impala-ASF-CR] IMPALA-5146: Fix inconsitent results at FROM UNIXTIME()

2017-11-22 Thread Kim Jin Chul (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8629 to look at the new patch set (#2). Change subject: IMPALA-5146: Fix inconsitent results at FROM_UNIXTIME() ..

[Impala-ASF-CR] IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

2017-11-22 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8614 ) Change subject: IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

2017-11-21 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8614 ) Change subject: IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

2017-11-21 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8614 ) Change subject: IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

2017-11-21 Thread Kim Jin Chul (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8614 to look at the new patch set (#3). Change subject: IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

[Impala-ASF-CR] IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

2017-11-21 Thread Kim Jin Chul (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8614 to look at the new patch set (#2). Change subject: IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

[Impala-ASF-CR] IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

2017-11-21 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8614 ) Change subject: IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4506: Do not display some intro message if --quiet is set

2017-11-20 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 ) Change subject: IMPALA-4506: Do not display some intro message if --quiet is set .. Patch Set 1: (1 comment)

<    1   2   3   >