[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21377 ) Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column .. Patch Set 8: Code-Review+2 > Patch Set 7: Verifi

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-23 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Kurt Deschler, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21377 to look at the new patch set (#8). Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

[Impala-ASF-CR] IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21450 ) Change subject: IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once .. IMPALA-13105: Fix multiple i

[Impala-ASF-CR] IMPALA-12939: Bound IMPALA BUILD THREADS for cgroups and memory

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21200 ) Change subject: IMPALA-12939: Bound IMPALA_BUILD_THREADS for cgroups and memory .. Patch Set 8: Code-Review+2 (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21377 ) Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column .. Patch Set 6: Thank you Aman for your review! I'l

[Impala-ASF-CR] IMPALA-13083: Clarify REASON MEM LIMIT TOO LOW FOR RESERVATION

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21436 ) Change subject: IMPALA-13083: Clarify REASON_MEM_LIMIT_TOO_LOW_FOR_RESERVATION .. Patch Set 5: Thank you Andrew for your review! -- T

[Impala-ASF-CR] IMPALA-12680: Fix NullPointerException during AlterTableAddPartitions

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21430 ) Change subject: IMPALA-12680: Fix NullPointerException during AlterTableAddPartitions .. Patch Set 1: (5 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-12939: Bound IMPALA BUILD THREADS for cgroups and memory

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21200 ) Change subject: IMPALA-12939: Bound IMPALA_BUILD_THREADS for cgroups and memory .. Patch Set 8: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21377 ) Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column .. Patch Set 6: (2 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21450 ) Change subject: IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once .. Patch Set 1: Code-Review+2 Looks OK

[Impala-ASF-CR] IMPALA-12939: Bound IMPALA BUILD THREADS for cgroups and memory

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21200 ) Change subject: IMPALA-12939: Bound IMPALA_BUILD_THREADS for cgroups and memory .. Patch Set 7: Code-Review+1 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-12939: Bound IMPALA BUILD THREADS for cgroups and memory

2024-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21200 ) Change subject: IMPALA-12939: Bound IMPALA_BUILD_THREADS for cgroups and memory .. Patch Set 5: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-13083: Clarify REASON MEM LIMIT TOO LOW FOR RESERVATION

2024-05-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21436 ) Change subject: IMPALA-13083: Clarify REASON_MEM_LIMIT_TOO_LOW_FOR_RESERVATION .. Patch Set 3: > Patch Set 3: Verified-1 > > Build fail

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 9: (1 comment) http

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21377 ) Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column .. Patch Set 6: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-21 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Kurt Deschler, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21377 to look at the new patch set (#6). Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 9: Code-Review+1 --

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 9: (3 comments) htt

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21377 ) Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column .. Patch Set 5: (9 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-21 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Kurt Deschler, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21377 to look at the new patch set (#5). Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-21 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Kurt Deschler, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21377 to look at the new patch set (#4). Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 8: (3 comments) htt

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 5: (5 comments) htt

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-20 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21440 ) Change subject: IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an expected constant .. Patch S

[Impala-ASF-CR] IMPALA-13083: Clarify REASON MEM LIMIT TOO LOW FOR RESERVATION

2024-05-20 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21436 ) Change subject: IMPALA-13083: Clarify REASON_MEM_LIMIT_TOO_LOW_FOR_RESERVATION .. Patch Set 2: (15 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-13083: Clarify REASON MEM LIMIT TOO LOW FOR RESERVATION

2024-05-20 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21436 to look at the new patch set (#2). Change subject: IMPALA-13083: Clarify REASON_MEM_LIMIT_TOO_LOW_FOR_RESERVATION .

[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds

2024-05-20 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 ) Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds .. Patch Set 1: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-20 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 4: (6 comments) htt

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 1: (3 comments) htt

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21440 ) Change subject: IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an expected constant .. Patch S

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21439 ) Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build .. Patch Set 2: Code-Review+2 Thanks Csaba! Carry +2.

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Riza Suminto (Code Review)
Hello Laszlo Gaal, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21439 to look at the new patch set (#2). Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: Code-Review+1 > Patch Se

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21439 Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build .. IMPALA-13040: (addendum) Inject larger delay for sani

[Impala-ASF-CR] IMPALA-13083: Clarify REASON MEM LIMIT TOO LOW FOR RESERVATION

2024-05-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21436 Change subject: IMPALA-13083: Clarify REASON_MEM_LIMIT_TOO_LOW_FOR_RESERVATION .. IMPALA-13083: Clarify REASON_MEM_LIMIT_TOO_LOW_FOR_RESE

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: Also, please update test

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: (4 comments) Please als

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-13 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. IMPALA-13051: Speed up, refactor query log tests Sets faste

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 10: Code-Review+1 Looks good to me. I will give my +2 if

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: (3 comments) http://ger

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 9: Code-Review+1 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 12: Thanks for all of your reviews! -- To

[Impala-ASF-CR] IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables

2024-05-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 ) Change subject: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables .. Patch Set 4: Code-R

[Impala-ASF-CR] IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables

2024-05-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 ) Change subject: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables .. Patch Set 3: Code-R

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 10: Code-Review+2 Carry +2 since change in p

[Impala-ASF-CR] IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables

2024-05-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 ) Change subject: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables .. Patch Set 2: Code-R

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-09 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Jason Fehr, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21383 to look at the new patch set (#10). Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-09 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Jason Fehr, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21383 to look at the new patch set (#8). Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ..

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-09 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Jason Fehr, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21383 to look at the new patch set (#7). Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ..

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-08 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Jason Fehr, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21383 to look at the new patch set (#6). Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ..

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-08 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Jason Fehr, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21383 to look at the new patch set (#5). Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ..

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-08 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21383 to look at the new patch set (#4). Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ...

[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 5: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1

2024-05-07 Thread Riza Suminto (Code Review)
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21405 to look at the new patch set (#5). Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 ..

[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 4: (1 comment) > Patch Set 4: Verifi

[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 3: (4 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1

2024-05-07 Thread Riza Suminto (Code Review)
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21405 to look at the new patch set (#3). Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 ..

[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1

2024-05-07 Thread Riza Suminto (Code Review)
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21405 to look at the new patch set (#2). Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 ..

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-07 Thread Riza Suminto (Code Review)
Hello Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21383 to look at the new patch set (#3). Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ..

[Impala-ASF-CR] IMPALA-13018: Fix test tpcds q80a for JDBC table

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 ) Change subject: IMPALA-13018: Fix test_tpcds_q80a for JDBC table .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13061: Create query live as external table

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21401 ) Change subject: IMPALA-13061: Create query live as external table .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 1: > Patch Set 1: > > This patch only

[Impala-ASF-CR] IMPALA-13061: Set transactional�lse on query live table

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21401 ) Change subject: IMPALA-13061: Set transactional=false on query live table .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 1: This patch only help bypassing the

[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1

2024-05-07 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21405 Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. IMPALA-13058: Init first_arrival_time_ and comple

[Impala-ASF-CR] IMPALA-13054: Avoid revisiting children in QueryStateExpanded

2024-05-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21392 ) Change subject: IMPALA-13054: Avoid revisiting children in QueryStateExpanded .. Patch Set 2: Code-Review+2 LGTM -- To view, visit ht

[Impala-ASF-CR] IMPALA-13054: Avoid revisiting children in QueryStateExpanded

2024-05-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21392 ) Change subject: IMPALA-13054: Avoid revisiting children in QueryStateExpanded .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-13051: Speed up, refactor query log tests

2024-05-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: IMPALA-13051: Speed up, refactor query log tests .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2135

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-02 Thread Riza Suminto (Code Review)
Hello Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21383 to look at the new patch set (#2). Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote ..

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21383 ) Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote

2024-05-01 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21383 Change subject: IMPALA-13040: Add waiting mechanism in UpdateFilterFromRemote .. IMPALA-13040: Add waiting mechanism in UpdateFilterFromR

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-01 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Kurt Deschler, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21377 to look at the new patch set (#2). Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-05-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21377 ) Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column .. Patch Set 1: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column

2024-04-30 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21377 Change subject: IMPALA-8042: Assign BETWEEN selectivity for discrete-unique column .. IMPALA-8042: Assign BETWEEN selectivity for discre

[Impala-ASF-CR] IMPALA-13045: Wait for impala query live to exist

2024-04-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21372 ) Change subject: IMPALA-13045: Wait for impala_query_live to exist .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-13045: Wait for impala query live to exist

2024-04-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21372 ) Change subject: IMPALA-13045: Wait for impala_query_live to exist .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2137

[Impala-ASF-CR] IMPALA-13012: Lower default query log max queued

2024-04-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21351 ) Change subject: IMPALA-13012: Lower default query_log_max_queued .. Patch Set 8: Code-Review+2 Did another pass. Looks OK to go. Change

[Impala-ASF-CR] IMPALA-12997: Use graceful shutdown for query log tests

2024-04-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21345 ) Change subject: IMPALA-12997: Use graceful shutdown for query log tests .. Patch Set 12: Code-Review+2 Looks good. Thanks for digging i

[Impala-ASF-CR] IMPALA-12997: Use graceful shutdown for query log tests

2024-04-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21345 ) Change subject: IMPALA-12997: Use graceful shutdown for query log tests .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-13012: Lower default query log max queued

2024-04-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21351 ) Change subject: IMPALA-13012: Lower default query_log_max_queued .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-13005: Create Query Live table in HMS

2024-04-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21302 ) Change subject: IMPALA-13005: Create Query Live table in HMS .. Patch Set 15: Code-Review+2 (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-13024: Ignore slots if using default pool and empty group

2024-04-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21340 ) Change subject: IMPALA-13024: Ignore slots if using default pool and empty group .. Patch Set 8: Code-Review+2 Carry +2. -- To view,

[Impala-ASF-CR] IMPALA-13024: Ignore slots if using default pool and empty group

2024-04-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21340 ) Change subject: IMPALA-13024: Ignore slots if using default pool and empty group .. Patch Set 8: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-13024: Ignore slots if using default pool and empty group

2024-04-26 Thread Riza Suminto (Code Review)
Hello Abhishek Rawat, Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21340 to look at the new patch set (#8). Change subject: IMPALA-13024: Ignore slots if using default pool and empty group ...

[Impala-ASF-CR] IMPALA-13012: Lower default query log max queued

2024-04-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21351 ) Change subject: IMPALA-13012: Lower default query_log_max_queued .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-13005: Create Query Live table in HMS

2024-04-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21302 ) Change subject: IMPALA-13005: Create Query Live table in HMS .. Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/21302/1

[Impala-ASF-CR] Refactor Workload Management

2024-04-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 ) Change subject: Refactor Workload Management .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21358/1//COMMIT_MSG Comm

<    1   2   3   4   5   6   7   8   9   10   >