[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10030: Remove unnecessary jar dependencies

2020-08-31 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16311 ) Change subject: IMPALA-10030: Remove unnecessary jar dependencies .. Patch Set 4: I ran exhaustive tests + on-prem E2E tests (L0s). I

[Impala-ASF-CR] IMPALA-10030: Remove unnecessary jar dependencies

2020-08-31 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16311 to look at the new patch set (#4). Change subject: IMPALA-10030: Remove unnecessary jar dependencies

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-08-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 ) Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. Patch Set 4: > Did you think at all about

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-08-28 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16320 to look at the new patch set (#4). Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images

[Impala-ASF-CR] IMPALA-10030: Remove unnecessary jar dependencies

2020-08-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16311 ) Change subject: IMPALA-10030: Remove unnecessary jar dependencies .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10030: Remove unnecessary jar dependencies

2020-08-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16311 ) Change subject: IMPALA-10030: Remove unnecessary jar dependencies .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10030: Remove unnecessary jar dependencies

2020-08-28 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16311 to look at the new patch set (#3). Change subject: IMPALA-10030: Remove unnecessary jar dependencies

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-08-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 ) Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. Patch Set 3: (2 comments) Rebased the patch as

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-08-28 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16320 to look at the new patch set (#3). Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images

[Impala-ASF-CR] IMPALA-9989 Improve admission control pool stats logging

2020-08-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 ) Change subject: IMPALA-9989 Improve admission control pool stats logging .. Patch Set 41: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state

2020-08-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16351 ) Change subject: IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-08-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: WIP IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 2: (6 comments) general approach

[Impala-ASF-CR] IMPALA-9989 Improve admission control pool stats logging

2020-08-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 ) Change subject: IMPALA-9989 Improve admission control pool stats logging .. Patch Set 40: (1 comment)

[Impala-ASF-CR] IMPALA-9989 Improve admission control pool stats logging

2020-08-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 ) Change subject: IMPALA-9989 Improve admission control pool stats logging .. Patch Set 38: Code-Review+1 (8 comments) I didn't look

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Patch Set

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16331 ) Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile .. IMPALA-7779 Parquet Scanner can write binary

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 ) Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Patch Set

[Impala-ASF-CR] IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state

2020-08-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16351 ) Change subject: IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state

2020-08-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16351 ) Change subject: IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10073: Create shaded dependency for S3A and aws-java-sdk-bundle

2020-08-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16342 Change subject: IMPALA-10073: Create shaded dependency for S3A and aws-java-sdk-bundle .. IMPALA-10073: Create shaded dependency for

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Patch Set

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 ) Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-08-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 40: Code-Review+2 Carrying +2. --

[Impala-ASF-CR] WIP IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 ) Change subject: WIP IMPALA-7779 Parquet Scanner can write binary data into profile .. Patch Set 1: (1 comment) overall, looks

[Impala-ASF-CR] IMPALA-9225: Add query option for retryable queries to spool all results before returning any to the client

2020-08-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Add query option for retryable queries to spool all results before returning any to the client .. Patch

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has removed a vote on this change. Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-10054: Fix flakiness in test multiple sort run bytes limits

2020-08-11 Thread Sahil Takiar (Code Review)
Sahil Takiar has removed a vote on this change. Change subject: IMPALA-10054: Fix flakiness in test_multiple_sort_run_bytes_limits .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-10054: Fix flakiness in test multiple sort run bytes limits

2020-08-11 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16301 ) Change subject: IMPALA-10054: Fix flakiness in test_multiple_sort_run_bytes_limits .. Patch Set 5: Looks like it failed due to

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-08-11 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 35: (2 comments)

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-08-11 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16320 to look at the new patch set (#2). Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has removed a vote on this change. Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 8: Code-Review+2 More flaky

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-08-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16320 Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. IMPALA-10016: Split jars for Impala exec and coord

[Impala-ASF-CR] IMPALA-10030: Remove unnecessary jar dependencies

2020-08-10 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16311 to look at the new patch set (#2). Change subject: IMPALA-10030: Remove unnecessary jar dependencies ..

[Impala-ASF-CR] IMPALA-10030: Remove unnecessary jar dependencies

2020-08-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16311 ) Change subject: IMPALA-10030: Remove unnecessary jar dependencies .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has removed a vote on this change. Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 7: Code-Review+2 Flaky test

[Impala-ASF-CR] IMPALA-10016: Remove unnecessary jar dependencies

2020-08-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16311 Change subject: IMPALA-10016: Remove unnecessary jar dependencies .. IMPALA-10016: Remove unnecessary jar dependencies Remove the

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has removed a vote on this change. Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 6: Failed because of

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-08-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 28: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-08-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 25: (1 comment)

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-08-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 25: (1 comment)

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-08-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 7: Code-Review+2 Pre-commit failure

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-08-07 Thread Sahil Takiar (Code Review)
Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16188 to look at the new patch set (#7). Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-08-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 25: (1 comment)

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-06 Thread Sahil Takiar (Code Review)
Hello Qifan Chen, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16263 to look at the new patch set (#5). Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-06 Thread Sahil Takiar (Code Review)
Hello Qifan Chen, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16263 to look at the new patch set (#4). Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries

[Impala-ASF-CR] IMPALA-10053: Remove uses of MonoTime::GetDeltaSince()

2020-08-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16296 ) Change subject: IMPALA-10053: Remove uses of MonoTime::GetDeltaSince() .. Patch Set 1: Code-Review+2 Nice catch, LGTM -- To view,

[Impala-ASF-CR] IMPALA-10005: Fix Snappy decompression for non-block filesystems

2020-08-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16278 ) Change subject: IMPALA-10005: Fix Snappy decompression for non-block filesystems .. Patch Set 2: Code-Review+2 Thanks for the

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-08-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 25: (2 comments)

[Impala-ASF-CR] IMPALA-10005: Fix Snappy decompression for non-block filesystems

2020-08-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16278 ) Change subject: IMPALA-10005: Fix Snappy decompression for non-block filesystems .. Patch Set 2: (3 comments) mostly questions

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-07-31 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-07-31 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16263 to look at the new patch set (#3). Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-07-31 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16263 to look at the new patch set (#2). Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-07-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16263 Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. IMPALA-10029: Strip debug symbols from

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 5: (2 comments) > Did you run

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 25: (1 comment)

[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.04

2020-07-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16241 ) Change subject: IMPALA-10007: Impala development environment does not support Ubuntu 20.04 .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 23: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16238 ) Change subject: IMPALA-10007: Impala development environment does not support Ubuntu 20.4 .. Patch Set 5: (3 comments) just a few

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 22: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 5: hmm I thought core tests were

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-23 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16188 to look at the new patch set (#5). Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-07-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 3: > This patch LGTM. > > Hive supports

[Impala-ASF-CR] IMPALA-5746: Cancel all queries scheduled by failed coordinators

2020-07-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16215 ) Change subject: IMPALA-5746: Cancel all queries scheduled by failed coordinators .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls

2020-07-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has removed a vote on this change. Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls

2020-07-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16218 ) Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls .. Patch Set 2: Failed due to IMPALA-9991.

[Impala-ASF-CR] IMPALA-9953: Shell should continue fetching even when 0 rows are returned

2020-07-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16222 ) Change subject: IMPALA-9953: Shell should continue fetching even when 0 rows are returned .. Patch Set 3: A bunch of HBase tests

[Impala-ASF-CR] IMPALA-9953: Shell should continue fetching even when 0 rows are returned

2020-07-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has removed a vote on this change. Change subject: IMPALA-9953: Shell should continue fetching even when 0 rows are returned .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-9953: Shell should continue fetching even when 0 rows are returned

2020-07-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has removed a vote on this change. Change subject: IMPALA-9953: Shell should continue fetching even when 0 rows are returned .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-9953: Shell should continue fetching even when 0 rows are returned

2020-07-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16222 ) Change subject: IMPALA-9953: Shell should continue fetching even when 0 rows are returned .. Patch Set 2: Failed because of

[Impala-ASF-CR] IMPALA-5746: Cancel all queries scheduled by failed coordinators

2020-07-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16215 ) Change subject: IMPALA-5746: Cancel all queries scheduled by failed coordinators .. Patch Set 3: (3 comments)

[Impala-ASF-CR] WIP CDPD-8989 Improve admission control pool stats logging to be more explicit

2020-07-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 ) Change subject: WIP CDPD-8989 Improve admission control pool stats logging to be more explicit .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 22: (2 comments)

[Impala-ASF-CR] IMPALA-9953: Shell should continue fetching even when 0 rows are returned

2020-07-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16222 Change subject: IMPALA-9953: Shell should continue fetching even when 0 rows are returned .. IMPALA-9953: Shell should continue

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-07-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded a new patch set (#3) to the change originally created by Eugene Zimichev. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key ..

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-07-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 2: @Tim - cleaned up the patch a bit,

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-07-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded a new patch set (#2) to the change originally created by Eugene Zimichev. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key ..

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-20 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16188 to look at the new patch set (#3). Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-20 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16188 to look at the new patch set (#2). Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 1: (1 comment) Addressed comments.

[Impala-ASF-CR] IMPALA-9799: Add retries to TestFetchFirst get num in flight queries calls

2020-07-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16218 Change subject: IMPALA-9799: Add retries to TestFetchFirst get_num_in_flight_queries calls .. IMPALA-9799: Add retries to

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 17: (11 comments)

[Impala-ASF-CR] IMPALA-9833: Bump timeout in TestQueryStates.test error query state

2020-07-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16205 Change subject: IMPALA-9833: Bump timeout in TestQueryStates.test_error_query_state .. IMPALA-9833: Bump timeout in

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16188 Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. IMPALA-9478: Profiles should indicate if custom

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

2020-07-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 ) Change subject: IMPALA-5534: Fix and enable experimental failure tests .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

2020-07-13 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16157 to look at the new patch set (#4). Change subject: IMPALA-5534: Fix and enable experimental failure tests

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

2020-07-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 ) Change subject: IMPALA-5534: Fix and enable experimental failure tests .. Patch Set 3: Code-Review+2 Carrying +2. -- To view, visit

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

2020-07-13 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16157 to look at the new patch set (#3). Change subject: IMPALA-5534: Fix and enable experimental failure tests

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

2020-07-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 ) Change subject: IMPALA-5534: Fix and enable experimental failure tests .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 14: (10 comments)

[Impala-ASF-CR] IMPALA-9834: De-flake TestQueryRetries on EC builds

2020-07-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16149 ) Change subject: IMPALA-9834: De-flake TestQueryRetries on EC builds .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-9834: De-flake TestQueryRetries on EC builds

2020-07-08 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16149 to look at the new patch set (#2). Change subject: IMPALA-9834: De-flake TestQueryRetries on EC builds

<    1   2   3   4   5   6   7   8   9   10   >